@ionic/core 7.5.8-dev.11701806358.1ca1b519 → 7.5.8-dev.11701894917.1c1465bd

package/dist/collection/components/{picker-legacy-column/picker-column.md.css → picker-column-internal/picker-column-internal.md.css}

@@ -53,97 +53,89 @@
  *   }
  * }
  */
-.picker-col {
-  display: flex;
-  position: relative;
-  flex: 1;
-  justify-content: center;
-  height: 100%;
-  box-sizing: content-box;
-  contain: content;
+:host {
+  -webkit-padding-start: 16px;
+  padding-inline-start: 16px;
+  -webkit-padding-end: 16px;
+  padding-inline-end: 16px;
+  padding-top: 0px;
+  padding-bottom: 0px;
+  height: 200px;
+  outline: none;
+  font-size: 22px;
+  scroll-snap-type: y mandatory;
+  /**
+   * Need to explicitly set overflow-x: hidden
+   * for older implementations of scroll snapping.
+   */
+  overflow-x: hidden;
+  overflow-y: scroll;
+  scrollbar-width: none;
+  text-align: center;
 }
 
-.picker-opts {
-  position: relative;
-  flex: 1;
-  max-width: 100%;
+/**
+ * Hide scrollbars on Chrome and Safari
+ */
+:host::-webkit-scrollbar {
+  display: none;
 }
 
-.picker-opt {
-  top: 0;
+:host .picker-item {
+  padding-left: 0;
+  padding-right: 0;
+  padding-top: 0;
+  padding-bottom: 0;
+  margin-left: 0;
+  margin-right: 0;
+  margin-top: 0;
+  margin-bottom: 0;
   display: block;
-  position: absolute;
   width: 100%;
-  border: 0;
-  text-align: center;
+  height: 34px;
+  border: 0px;
+  outline: none;
+  background: transparent;
+  color: inherit;
+  font-family: var(--ion-font-family, inherit);
+  font-size: inherit;
+  line-height: 34px;
+  text-align: inherit;
   text-overflow: ellipsis;
   white-space: nowrap;
-  contain: strict;
+  cursor: pointer;
   overflow: hidden;
-  will-change: transform;
-}
-@supports (inset-inline-start: 0) {
-  .picker-opt {
-    inset-inline-start: 0;
-  }
-}
-@supports not (inset-inline-start: 0) {
-  .picker-opt {
-    left: 0;
-  }
-  :host-context([dir=rtl]) .picker-opt {
-    left: unset;
-    right: unset;
-    right: 0;
-  }
-  [dir=rtl] .picker-opt {
-    left: unset;
-    right: unset;
-    right: 0;
-  }
-  @supports selector(:dir(rtl)) {
-    .picker-opt:dir(rtl) {
-      left: unset;
-      right: unset;
-      right: 0;
-    }
-  }
-}
-
-.picker-opt.picker-opt-disabled {
-  pointer-events: none;
+  scroll-snap-align: center;
 }
 
-.picker-opt-disabled {
-  opacity: 0;
+:host .picker-item-empty,
+:host .picker-item[disabled] {
+  cursor: default;
 }
 
-.picker-opts-left {
-  justify-content: flex-start;
+:host .picker-item-empty,
+:host(:not([disabled])) .picker-item[disabled] {
+  scroll-snap-align: none;
 }
 
-.picker-opts-right {
-  justify-content: flex-end;
+:host([disabled]) {
+  overflow-y: hidden;
 }
 
-.picker-opt:active, .picker-opt:focus {
-  outline: none;
+:host .picker-item[disabled] {
+  opacity: 0.4;
 }
 
-.picker-prefix {
-  position: relative;
-  flex: 1;
-  text-align: end;
-  white-space: nowrap;
+:host(.picker-column-active) .picker-item.picker-item-active {
+  color: var(--ion-color-base);
 }
 
-.picker-suffix {
-  position: relative;
-  flex: 1;
-  text-align: start;
-  white-space: nowrap;
+@media (any-hover: hover) {
+  :host(:focus) {
+    outline: none;
+    background: rgba(var(--ion-color-base-rgb), 0.2);
+  }
 }
-
 /**
  * Convert a font size to a dynamic font size.
  * Fonts that participate in Dynamic Type should use
@@ -199,48 +191,6 @@
  *   }
  * }
  */
-.picker-col {
-  -webkit-padding-start: 8px;
-  padding-inline-start: 8px;
-  -webkit-padding-end: 8px;
-  padding-inline-end: 8px;
-  padding-top: 0;
-  padding-bottom: 0;
-  transform-style: preserve-3d;
-}
-
-.picker-prefix,
-.picker-suffix,
-.picker-opts {
-  top: 77px;
-  transform-style: preserve-3d;
-  color: inherit;
-  font-size: 22px;
-  line-height: 42px;
-  pointer-events: none;
-}
-
-.picker-opt {
-  margin-left: 0;
-  margin-right: 0;
-  margin-top: 0;
-  margin-bottom: 0;
-  padding-left: 0;
-  padding-right: 0;
-  padding-top: 0;
-  padding-bottom: 0;
-  height: 43px;
-  transition-timing-function: ease-out;
-  background: transparent;
-  color: inherit;
-  font-size: 22px;
-  line-height: 42px;
-  backface-visibility: hidden;
-  pointer-events: auto;
-}
-
-.picker-prefix,
-.picker-suffix,
-.picker-opt.picker-opt-selected {
-  color: var(--ion-color-primary, #3880ff);
+:host .picker-item-active {
+  color: var(--ion-color-base);
 }

package/dist/collection/components/{picker-column/test/basic/picker-column.e2e.js → picker-column-internal/test/basic/picker-column-internal.e2e.js}

@@ -7,20 +7,20 @@ import { configs, test } from "../../../../utils/test/playwright/index";
  * This behavior does not vary across modes/directions.
  */
 configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
-    test.describe(title('picker-column'), () => {
+    test.describe(title('picker-column-internal'), () => {
         test.beforeEach(async ({ page }) => {
-            await page.goto('/src/components/picker-column/test/basic', config);
+            await page.goto('/src/components/picker-column-internal/test/basic', config);
         });
         test('should render a picker item for each item', async ({ page }) => {
-            const columns = page.locator('ion-picker-column ion-picker-column-option');
+            const columns = page.locator('ion-picker-column-internal .picker-item:not(.picker-item-empty)');
             await expect(columns).toHaveCount(24);
         });
         test('should render 6 empty picker items', async ({ page }) => {
-            const columns = page.locator('ion-picker-column .picker-item-empty');
+            const columns = page.locator('ion-picker-column-internal .picker-item-empty');
             await expect(columns).toHaveCount(6);
         });
         test('should not have an active item when value is not set', async ({ page }) => {
-            const activeColumn = page.locator('ion-picker-column ion-picker-column-option.option-active');
+            const activeColumn = page.locator('ion-picker-column-internal .picker-item-active');
             await expect(activeColumn).toHaveCount(0);
         });
         test('should have an active item when value is set', async ({ page }) => {
@@ -28,7 +28,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
                 el.value = '12';
             });
             await page.waitForChanges();
-            const activeColumn = page.locator('ion-picker-column ion-picker-column-option.option-active');
+            const activeColumn = page.locator('ion-picker-column-internal .picker-item-active');
             expect(activeColumn).not.toBeNull();
         });
         // TODO FW-3616
@@ -38,8 +38,8 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
                 el.scrollTop = 801;
             });
             await page.waitForChanges();
-            const activeColumn = page.locator('ion-picker-column ion-picker-column-option.option-active');
-            await expect(activeColumn).toHaveJSProperty('value', 23);
+            const activeColumn = page.locator('ion-picker-column-internal .picker-item-active');
+            expect(await (activeColumn === null || activeColumn === void 0 ? void 0 : activeColumn.innerText())).toEqual('23');
         });
         test('should not emit ionChange when the value is modified externally', async ({ page, skip }) => {
             skip.browser('firefox', 'https://bugzilla.mozilla.org/show_bug.cgi?id=1766890');

package/dist/collection/components/picker-column-internal/test/disabled/picker-column-internal.e2e.js

@@ -0,0 +1,162 @@
+/*!
+ * (C) Ionic http://ionicframework.com - MIT License
+ */
+import { expect } from "@playwright/test";
+import { configs, test } from "../../../../utils/test/playwright/index";
+/**
+ * This behavior does not vary across directions.
+ */
+configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+    test.describe(title('picker-column-internal: disabled rendering'), () => {
+        test('should not have visual regressions', async ({ page }) => {
+            await page.setContent(`
+        <ion-picker-internal>
+          <ion-picker-column-internal value="b"></ion-picker-column-internal>
+        </ion-picker-internal>
+
+        <script>
+          const column = document.querySelector('ion-picker-column-internal');
+          column.items = [
+            { text: 'A', value: 'a', disabled: true },
+            { text: 'B', value: 'b' },
+            { text: 'C', value: 'c', disabled: true }
+          ]
+        </script>
+      `, config);
+            const picker = page.locator('ion-picker-internal');
+            await expect(picker).toHaveScreenshot(screenshot(`picker-internal-disabled`));
+        });
+    });
+});
+/**
+ * This behavior does not vary across modes/directions.
+ */
+configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
+    test.describe(title('picker-column-internal: disabled items'), () => {
+        test('all picker items should be enabled by default', async ({ page }) => {
+            await page.setContent(`
+        <ion-picker-internal>
+          <ion-picker-column-internal></ion-picker-column-internal>
+        </ion-picker-internal>
+
+        <script>
+          const column = document.querySelector('ion-picker-column-internal');
+          column.items = [
+            { text: 'A', value: 'a' },
+            { text: 'B', value: 'b' },
+            { text: 'C', value: 'c' }
+          ]
+        </script>
+      `, config);
+            const pickerItems = page.locator('ion-picker-column-internal .picker-item:not(.picker-item-empty, [disabled])');
+            expect(await pickerItems.count()).toBe(3);
+        });
+        test('disabled picker item should not be interactive', async ({ page }) => {
+            await page.setContent(`
+        <ion-picker-internal>
+          <ion-picker-column-internal></ion-picker-column-internal>
+        </ion-picker-internal>
+
+        <script>
+          const column = document.querySelector('ion-picker-column-internal');
+          column.items = [
+            { text: 'A', value: 'a' },
+            { text: 'B', value: 'b', disabled: true },
+            { text: 'C', value: 'c' }
+          ]
+        </script>
+      `, config);
+            const disabledItem = page.locator('ion-picker-column-internal .picker-item[disabled]');
+            await expect(disabledItem).not.toBeEnabled();
+        });
+        test('disabled picker item should not be considered active', async ({ page }) => {
+            await page.setContent(`
+        <ion-picker-internal>
+          <ion-picker-column-internal value="b"></ion-picker-column-internal>
+        </ion-picker-internal>
+
+        <script>
+          const column = document.querySelector('ion-picker-column-internal');
+          column.items = [
+            { text: 'A', value: 'a' },
+            { text: 'B', value: 'b', disabled: true },
+            { text: 'C', value: 'c' }
+          ]
+        </script>
+      `, config);
+            const disabledItem = page.locator('ion-picker-column-internal .picker-item[data-value="b"]');
+            await expect(disabledItem).not.toHaveClass(/picker-item-active/);
+        });
+        test('setting the value to a disabled item should not cause that item to be active', async ({ page }) => {
+            await page.setContent(`
+        <ion-picker-internal>
+          <ion-picker-column-internal></ion-picker-column-internal>
+        </ion-picker-internal>
+
+        <script>
+          const column = document.querySelector('ion-picker-column-internal');
+          column.items = [
+            { text: 'A', value: 'a' },
+            { text: 'B', value: 'b', disabled: true },
+            { text: 'C', value: 'c' }
+          ]
+        </script>
+      `, config);
+            const pickerColumn = page.locator('ion-picker-column-internal');
+            await pickerColumn.evaluate((el) => (el.value = 'b'));
+            await page.waitForChanges();
+            const disabledItem = page.locator('ion-picker-column-internal .picker-item[data-value="b"]');
+            await expect(disabledItem).toBeDisabled();
+            await expect(disabledItem).not.toHaveClass(/picker-item-active/);
+        });
+        test('defaulting the value to a disabled item should not cause that item to be active', async ({ page }) => {
+            await page.setContent(`
+        <ion-picker-internal>
+          <ion-picker-column-internal></ion-picker-column-internal>
+        </ion-picker-internal>
+
+        <script>
+          const column = document.querySelector('ion-picker-column-internal');
+          column.items = [
+            { text: 'A', value: 'a' },
+            { text: 'B', value: 'b', disabled: true },
+            { text: 'C', value: 'c' }
+          ]
+          column.value = 'b'
+        </script>
+      `, config);
+            const disabledItem = page.locator('ion-picker-column-internal .picker-item[data-value="b"]');
+            await expect(disabledItem).toBeDisabled();
+            await expect(disabledItem).not.toHaveClass(/picker-item-active/);
+        });
+    });
+});
+/**
+ * This behavior does not vary across directions.
+ */
+configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+    test.describe(title('picker-column-internal: disabled column rendering'), () => {
+        test.beforeEach(async ({ page }) => {
+            await page.goto('/src/components/picker-column-internal/test/disabled', config);
+        });
+        test('disabled column should not have visual regressions', async ({ page }) => {
+            const disabledColumn = page.locator('#column-disabled');
+            await page.waitForChanges();
+            await expect(disabledColumn).toHaveScreenshot(screenshot('picker-internal-disabled-column'));
+        });
+    });
+});
+/**
+ * This behavior does not vary across modes/directions.
+ */
+configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
+    test.describe(title('picker-column-internal: disabled column'), () => {
+        test.beforeEach(async ({ page }) => {
+            await page.goto('/src/components/picker-column-internal/test/disabled', config);
+        });
+        test('item in disabled column should not be interactive', async ({ page }) => {
+            const secondItem = page.locator('#column-disabled .picker-item:not(.picker-item-empty)').nth(1);
+            await expect(secondItem).toBeDisabled();
+        });
+    });
+});