@ionic/core 7.5.8-dev.11701791090.18ebbea8 → 7.5.8-dev.11701806358.1ca1b519

package/dist/collection/components/picker-column/picker-column.md.css

@@ -53,97 +53,166 @@
  *   }
  * }
  */
-.picker-col {
+:host {
   display: flex;
-  position: relative;
-  flex: 1;
+  align-items: center;
   justify-content: center;
-  height: 100%;
-  box-sizing: content-box;
-  contain: content;
+  max-width: 100%;
+  height: 200px;
+  font-size: 22px;
+  text-align: center;
 }
 
 .picker-opts {
-  position: relative;
-  flex: 1;
-  max-width: 100%;
+  /**
+   * This padding must be set here and not on the
+   * host to ensure that the focus highlight on the
+   * column is not overly narrow.
+   */
+  -webkit-padding-start: 16px;
+  padding-inline-start: 16px;
+  -webkit-padding-end: 16px;
+  padding-inline-end: 16px;
+  padding-top: 0px;
+  padding-bottom: 0px;
+  /**
+   * When using reactive data, such as in datetime's
+   * wheel picker, there may be layout shifts between
+   * individual columns in a picker as the columns
+   * shrink to fit the widest item in the column.
+   * Setting a minimum width avoids this layout shifting.
+   *
+   * Note that we need this min-width set on the same
+   * element as the vertical padding (i.e. not on the
+   * host).
+   */
+  min-width: 26px;
+  max-height: 200px;
+  outline: none;
+  /**
+   * Added so that text-align can be set on the host
+   * from external components. For example, datetime
+   * changes the alignment of specific columns in its
+   * wheel pickers.
+   */
+  text-align: inherit;
+  scroll-snap-type: y mandatory;
+  /**
+   * Need to explicitly set overflow-x: hidden
+   * for older implementations of scroll snapping.
+   */
+  overflow-x: hidden;
+  overflow-y: scroll;
+  scrollbar-width: none;
+}
+
+/**
+ * Hide scrollbars on Chrome and Safari
+ */
+.picker-opts::-webkit-scrollbar {
+  display: none;
 }
 
-.picker-opt {
-  top: 0;
+::slotted(ion-picker-column-option) {
   display: block;
-  position: absolute;
-  width: 100%;
-  border: 0;
-  text-align: center;
+  scroll-snap-align: center;
+}
+
+.picker-item-empty,
+:host(:not([disabled])) ::slotted(ion-picker-column-option.option-disabled) {
+  scroll-snap-align: none;
+}
+
+::slotted([slot=prefix]), ::slotted([slot=suffix]) {
+  max-width: 200px;
   text-overflow: ellipsis;
   white-space: nowrap;
-  contain: strict;
   overflow: hidden;
-  will-change: transform;
-}
-@supports (inset-inline-start: 0) {
-  .picker-opt {
-    inset-inline-start: 0;
-  }
 }
-@supports not (inset-inline-start: 0) {
-  .picker-opt {
-    left: 0;
-  }
-  :host-context([dir=rtl]) .picker-opt {
-    left: unset;
-    right: unset;
-    right: 0;
-  }
-  [dir=rtl] .picker-opt {
-    left: unset;
-    right: unset;
-    right: 0;
-  }
-  @supports selector(:dir(rtl)) {
-    .picker-opt:dir(rtl) {
-      left: unset;
-      right: unset;
-      right: 0;
-    }
-  }
+
+::slotted([slot=prefix]) {
+  /**
+   * This is added in addition to the column's own padding so that there is white
+   * space between the slot and the column's focus highlight.
+   */
+  -webkit-padding-start: 16px;
+  padding-inline-start: 16px;
+  -webkit-padding-end: 16px;
+  padding-inline-end: 16px;
+  padding-top: 0;
+  padding-bottom: 0;
+  justify-content: end;
 }
 
-.picker-opt.picker-opt-disabled {
-  pointer-events: none;
+::slotted([slot=suffix]) {
+  /**
+   * This is added in addition to the column's own padding so that there is white
+   * space between the slot and the column's focus highlight.
+   */
+  -webkit-padding-start: 16px;
+  padding-inline-start: 16px;
+  -webkit-padding-end: 16px;
+  padding-inline-end: 16px;
+  padding-top: 0;
+  padding-bottom: 0;
+  justify-content: start;
 }
 
-.picker-opt-disabled {
-  opacity: 0;
+:host .picker-item {
+  padding-left: 0;
+  padding-right: 0;
+  padding-top: 0;
+  padding-bottom: 0;
+  margin-left: 0;
+  margin-right: 0;
+  margin-top: 0;
+  margin-bottom: 0;
+  display: block;
+  width: 100%;
+  height: 34px;
+  border: 0px;
+  outline: none;
+  background: transparent;
+  color: inherit;
+  font-family: var(--ion-font-family, inherit);
+  font-size: inherit;
+  line-height: 34px;
+  text-align: inherit;
+  text-overflow: ellipsis;
+  white-space: nowrap;
+  cursor: pointer;
+  overflow: hidden;
+  scroll-snap-align: center;
 }
 
-.picker-opts-left {
-  justify-content: flex-start;
+:host .picker-item-empty,
+:host .picker-item[disabled] {
+  cursor: default;
 }
 
-.picker-opts-right {
-  justify-content: flex-end;
+:host .picker-item-empty,
+:host(:not([disabled])) .picker-item[disabled] {
+  scroll-snap-align: none;
 }
 
-.picker-opt:active, .picker-opt:focus {
-  outline: none;
+:host([disabled]) {
+  overflow-y: hidden;
 }
 
-.picker-prefix {
-  position: relative;
-  flex: 1;
-  text-align: end;
-  white-space: nowrap;
+:host .picker-item[disabled] {
+  opacity: 0.4;
 }
 
-.picker-suffix {
-  position: relative;
-  flex: 1;
-  text-align: start;
-  white-space: nowrap;
+:host(.picker-column-active) .picker-item.picker-item-active {
+  color: var(--ion-color-base);
 }
 
+@media (any-hover: hover) {
+  :host(:focus) .picker-opts {
+    outline: none;
+    background: rgba(var(--ion-color-base-rgb), 0.2);
+  }
+}
 /**
  * Convert a font size to a dynamic font size.
  * Fonts that participate in Dynamic Type should use
@@ -199,48 +268,6 @@
  *   }
  * }
  */
-.picker-col {
-  -webkit-padding-start: 8px;
-  padding-inline-start: 8px;
-  -webkit-padding-end: 8px;
-  padding-inline-end: 8px;
-  padding-top: 0;
-  padding-bottom: 0;
-  transform-style: preserve-3d;
-}
-
-.picker-prefix,
-.picker-suffix,
-.picker-opts {
-  top: 77px;
-  transform-style: preserve-3d;
-  color: inherit;
-  font-size: 22px;
-  line-height: 42px;
-  pointer-events: none;
-}
-
-.picker-opt {
-  margin-left: 0;
-  margin-right: 0;
-  margin-top: 0;
-  margin-bottom: 0;
-  padding-left: 0;
-  padding-right: 0;
-  padding-top: 0;
-  padding-bottom: 0;
-  height: 43px;
-  transition-timing-function: ease-out;
-  background: transparent;
-  color: inherit;
-  font-size: 22px;
-  line-height: 42px;
-  backface-visibility: hidden;
-  pointer-events: auto;
-}
-
-.picker-prefix,
-.picker-suffix,
-.picker-opt.picker-opt-selected {
-  color: var(--ion-color-primary, #3880ff);
+:host .picker-item-active {
+  color: var(--ion-color-base);
 }

package/dist/collection/components/{picker-column-internal/test/basic/picker-column-internal.e2e.js → picker-column/test/basic/picker-column.e2e.js}

@@ -7,20 +7,20 @@ import { configs, test } from "../../../../utils/test/playwright/index";
  * This behavior does not vary across modes/directions.
  */
 configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
-    test.describe(title('picker-column-internal'), () => {
+    test.describe(title('picker-column'), () => {
         test.beforeEach(async ({ page }) => {
-            await page.goto('/src/components/picker-column-internal/test/basic', config);
+            await page.goto('/src/components/picker-column/test/basic', config);
         });
         test('should render a picker item for each item', async ({ page }) => {
-            const columns = page.locator('ion-picker-column-internal .picker-item:not(.picker-item-empty)');
+            const columns = page.locator('ion-picker-column ion-picker-column-option');
             await expect(columns).toHaveCount(24);
         });
         test('should render 6 empty picker items', async ({ page }) => {
-            const columns = page.locator('ion-picker-column-internal .picker-item-empty');
+            const columns = page.locator('ion-picker-column .picker-item-empty');
             await expect(columns).toHaveCount(6);
         });
         test('should not have an active item when value is not set', async ({ page }) => {
-            const activeColumn = page.locator('ion-picker-column-internal .picker-item-active');
+            const activeColumn = page.locator('ion-picker-column ion-picker-column-option.option-active');
             await expect(activeColumn).toHaveCount(0);
         });
         test('should have an active item when value is set', async ({ page }) => {
@@ -28,7 +28,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
                 el.value = '12';
             });
             await page.waitForChanges();
-            const activeColumn = page.locator('ion-picker-column-internal .picker-item-active');
+            const activeColumn = page.locator('ion-picker-column ion-picker-column-option.option-active');
             expect(activeColumn).not.toBeNull();
         });
         // TODO FW-3616
@@ -38,8 +38,8 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
                 el.scrollTop = 801;
             });
             await page.waitForChanges();
-            const activeColumn = page.locator('ion-picker-column-internal .picker-item-active');
-            expect(await (activeColumn === null || activeColumn === void 0 ? void 0 : activeColumn.innerText())).toEqual('23');
+            const activeColumn = page.locator('ion-picker-column ion-picker-column-option.option-active');
+            await expect(activeColumn).toHaveJSProperty('value', 23);
         });
         test('should not emit ionChange when the value is modified externally', async ({ page, skip }) => {
             skip.browser('firefox', 'https://bugzilla.mozilla.org/show_bug.cgi?id=1766890');

package/dist/collection/components/picker-column/test/disabled/picker-column.e2e.js

@@ -0,0 +1,113 @@
+/*!
+ * (C) Ionic http://ionicframework.com - MIT License
+ */
+import { expect } from "@playwright/test";
+import { configs, test } from "../../../../utils/test/playwright/index";
+/**
+ * This behavior does not vary across modes/directions.
+ */
+configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
+    test.describe(title('picker-column: disabled items'), () => {
+        // TODO FW-5580 move this to a spec test in picker-column-option
+        test('all picker items should be enabled by default', async ({ page }) => {
+            await page.setContent(`
+        <ion-picker>
+          <ion-picker-column>
+            <ion-picker-column-option value="a">A</ion-picker-column-option>
+            <ion-picker-column-option value="b">B</ion-picker-column-option>
+            <ion-picker-column-option value="c">C</ion-picker-column-option>
+          </ion-picker-column>
+        </ion-picker>
+      `, config);
+            const pickerItems = page.locator('ion-picker-column ion-picker-column-option button:not([disabled])');
+            expect(await pickerItems.count()).toBe(3);
+        });
+        // TODO FW-5580 move this to a spec test in picker-column-option
+        test('disabled picker item should not be interactive', async ({ page }) => {
+            await page.setContent(`
+        <ion-picker>
+          <ion-picker-column>
+            <ion-picker-column-option value="a">A</ion-picker-column-option>
+            <ion-picker-column-option value="b" disabled="true">B</ion-picker-column-option>
+            <ion-picker-column-option value="c">C</ion-picker-column-option>
+          </ion-picker-column>
+        </ion-picker>
+      `, config);
+            const disabledItem = page.locator('ion-picker-column ion-picker-column-option button').nth(1);
+            await expect(disabledItem).not.toBeEnabled();
+        });
+        test('disabled picker item should not be considered active', async ({ page }) => {
+            await page.setContent(`
+        <ion-picker>
+          <ion-picker-column value="b">
+            <ion-picker-column-option value="a">A</ion-picker-column-option>
+            <ion-picker-column-option value="b" disabled="true">B</ion-picker-column-option>
+            <ion-picker-column-option value="c">C</ion-picker-column-option>
+          </ion-picker-column>
+        </ion-picker>
+      `, config);
+            const disabledItem = page.locator('ion-picker-column-option').nth(1);
+            await expect(disabledItem).not.toHaveClass(/option-active/);
+        });
+        test('setting the value to a disabled item should not cause that item to be active', async ({ page }) => {
+            await page.setContent(`
+        <ion-picker>
+          <ion-picker-column>
+            <ion-picker-column-option value="a">A</ion-picker-column-option>
+            <ion-picker-column-option value="b" disabled="true">B</ion-picker-column-option>
+            <ion-picker-column-option value="c">C</ion-picker-column-option>
+          </ion-picker-column>
+        </ion-picker>
+      `, config);
+            const pickerColumn = page.locator('ion-picker-column');
+            await pickerColumn.evaluate((el) => (el.value = 'b'));
+            await page.waitForChanges();
+            const disabledItem = page.locator('ion-picker-column ion-picker-column-option').nth(1);
+            await expect(disabledItem).not.toHaveClass(/option-active/);
+        });
+        test('defaulting the value to a disabled item should not cause that item to be active', async ({ page }) => {
+            await page.setContent(`
+        <ion-picker>
+          <ion-picker-column value="b">
+            <ion-picker-column-option value="a">A</ion-picker-column-option>
+            <ion-picker-column-option value="b" disabled="true">B</ion-picker-column-option>
+            <ion-picker-column-option value="c">C</ion-picker-column-option>
+          </ion-picker-column>
+        </ion-picker>
+      `, config);
+            const disabledItem = page.locator('ion-picker-column ion-picker-column-option').nth(1);
+            await expect(disabledItem).not.toHaveClass(/option-active/);
+        });
+    });
+});
+/**
+ * This behavior does not vary across directions.
+ */
+// TODO FW-5580 fix this
+configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+    test.describe.skip(title('picker-column: disabled column rendering'), () => {
+        test.beforeEach(async ({ page }) => {
+            await page.goto('/src/components/picker-column/test/disabled', config);
+        });
+        test('disabled column should not have visual regressions', async ({ page }) => {
+            const disabledColumn = page.locator('#column-disabled');
+            await page.waitForChanges();
+            await expect(disabledColumn).toHaveScreenshot(screenshot('picker-disabled-column'));
+        });
+    });
+});
+/**
+ * This behavior does not vary across modes/directions.
+ */
+// TODO FW-5580 fix this
+configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
+    test.describe.skip(title('picker-column: disabled column'), () => {
+        test.beforeEach(async ({ page }) => {
+            await page.goto('/src/components/picker-column/test/disabled', config);
+        });
+        test('item in disabled column should not be interactive', async ({ page }) => {
+            const secondItem = page.locator('#column-disabled .picker-item:not(.picker-item-empty)').nth(1);
+            await expect(secondItem).toBeDisabled();
+        });
+    });
+});

package/dist/collection/components/picker-column/test/slots/picker-column.e2e.js

@@ -0,0 +1,39 @@
+/*!
+ * (C) Ionic http://ionicframework.com - MIT License
+ */
+import { expect } from "@playwright/test";
+import { configs, test } from "../../../../utils/test/playwright/index";
+configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+    test.describe(title('picker-column: slots'), () => {
+        test('should not have visual regressions with prefix and suffix', async ({ page }) => {
+            await page.setContent(`
+        <ion-picker>
+          <ion-picker-column value="b">
+            <ion-picker-column-option value="a">A</ion-picker-column-option>
+            <ion-picker-column-option value="b">B</ion-picker-column-option>
+            <ion-picker-column-option value="c">C</ion-picker-column-option>
+            <div slot="prefix">Prefix</div>
+            <div slot="suffix">Suffix</div>
+          </ion-picker-column>
+        </ion-picker>
+      `, config);
+            const picker = page.locator('ion-picker');
+            await expect(picker).toHaveScreenshot(screenshot(`picker-prefix-suffix`));
+        });
+        test('should not have visual regressions with a long prefix and suffix', async ({ page }) => {
+            await page.setContent(`
+        <ion-picker>
+          <ion-picker-column value="b">
+            <ion-picker-column-option value="a">A</ion-picker-column-option>
+            <ion-picker-column-option value="b">B</ion-picker-column-option>
+            <ion-picker-column-option value="c">C</ion-picker-column-option>
+            <div slot="prefix">Long prefix long prefix long prefix</div>
+            <div slot="suffix">Long suffix long suffix long suffix</div>
+          </ion-picker-column>
+        </ion-picker>
+      `, config);
+            const picker = page.locator('ion-picker');
+            await expect(picker).toHaveScreenshot(screenshot(`picker-long-prefix-suffix`));
+        });
+    });
+});

package/dist/collection/components/picker-column-option/picker-column-option.ios.css

@@ -0,0 +1,87 @@
+/**
+ * Convert a font size to a dynamic font size.
+ * Fonts that participate in Dynamic Type should use
+ * dynamic font sizes.
+ * @param size - The initial font size including the unit (i.e. px or pt)
+ * @param unit (optional) - The unit to convert to. Use this if you want to
+ * convert to a unit other than $baselineUnit.
+ */
+/**
+ * Convert a font size to a dynamic font size but impose
+ * a maximum font size.
+ * @param size - The initial font size including the unit (i.e. px or pt)
+ * @param maxScale - The maximum scale of the font (i.e. 2.5 for a maximum 250% scale).
+ * @param unit (optional) - The unit to convert the initial font size to. Use this if you want to
+ * convert to a unit other than $baselineUnit.
+ */
+/**
+ * Convert a font size to a dynamic font size but impose
+ * a minimum font size.
+ * @param size - The initial font size including the unit (i.e. px or pt)
+ * @param minScale - The minimum scale of the font (i.e. 0.8 for a minimum 80% scale).
+ * @param unit (optional) - The unit to convert the initial font size to. Use this if you want to
+ * convert to a unit other than $baselineUnit.
+ */
+/**
+ * Convert a font size to a dynamic font size but impose
+ * maximum and minimum font sizes.
+ * @param size - The initial font size including the unit (i.e. px or pt)
+ * @param minScale - The minimum scale of the font (i.e. 0.8 for a minimum 80% scale).
+ * @param maxScale - The maximum scale of the font (i.e. 2.5 for a maximum 250% scale).
+ * @param unit (optional) - The unit to convert the initial font size to. Use this if you want to
+ * convert to a unit other than $baselineUnit.
+ */
+/**
+ * A heuristic that applies CSS to tablet
+ * viewports.
+ *
+ * Usage:
+ * @include tablet-viewport() {
+ *   :host {
+ *     background-color: green;
+ *   }
+ * }
+ */
+/**
+ * A heuristic that applies CSS to mobile
+ * viewports (i.e. phones, not tablets).
+ *
+ * Usage:
+ * @include mobile-viewport() {
+ *   :host {
+ *     background-color: blue;
+ *   }
+ * }
+ */
+button {
+  padding-left: 0;
+  padding-right: 0;
+  padding-top: 0;
+  padding-bottom: 0;
+  margin-left: 0;
+  margin-right: 0;
+  margin-top: 0;
+  margin-bottom: 0;
+  width: 100%;
+  height: 34px;
+  border: 0px;
+  outline: none;
+  background: transparent;
+  color: inherit;
+  font-family: var(--ion-font-family, inherit);
+  font-size: inherit;
+  line-height: 34px;
+  text-align: inherit;
+  text-overflow: ellipsis;
+  white-space: nowrap;
+  cursor: pointer;
+  overflow: hidden;
+}
+
+:host(.option-disabled) {
+  opacity: 0.4;
+}
+
+:host(.option-disabled) button {
+  cursor: default;
+}