@ionic/core 7.5.8-dev.11701791090.18ebbea8 → 7.5.8-dev.11701806358.1ca1b519

package/dist/collection/components/picker/picker.md.css

@@ -54,61 +54,61 @@
  * }
  */
 :host {
+  display: flex;
+  position: relative;
+  align-items: center;
+  justify-content: center;
+  width: 100%;
+  height: 200px;
   /**
-   * @prop --background: Background of the picker
-   * @prop --background-rgb: Background of the picker in rgb format
-   *
-   * @prop --border-radius: Border radius of the picker
-   * @prop --border-color: Border color of the picker
-   * @prop --border-width: Border width of the picker
-   * @prop --border-style: Border style of the picker
-   *
-   * @prop --min-width: Minimum width of the picker
-   * @prop --width: Width of the picker
-   * @prop --max-width: Maximum width of the picker
-   *
-   * @prop --min-height: Minimum height of the picker
-   * @prop --height: Height of the picker
-   * @prop --max-height: Maximum height of the picker
-   *
-   * @prop --backdrop-opacity: Opacity of the backdrop
+   * Picker columns should display
+   * in the order in which developers
+   * added them and should ignore
+   * LTR vs RTL directions.
    */
-  --border-radius: 0;
-  --border-style: solid;
-  --min-width: auto;
-  --width: 100%;
-  --max-width: 500px;
-  --min-height: auto;
-  --max-height: auto;
-  -moz-osx-font-smoothing: grayscale;
-  -webkit-font-smoothing: antialiased;
-  top: 0;
-  display: block;
+  direction: ltr;
+  /**
+   * This is required otherwise the
+   * highlight will appear behind
+   * the picker when used inline.
+   */
+  z-index: 0;
+}
+
+:host .picker-before,
+:host .picker-after {
   position: absolute;
   width: 100%;
-  height: 100%;
-  outline: none;
-  font-family: var(--ion-font-family, inherit);
-  contain: strict;
-  user-select: none;
-  z-index: 1001;
+  /**
+   * The transform and z-index
+   * are needed for WebKit otherwise
+   * the fade will appear underneath the picker.
+   */
+  transform: translateZ(0);
+  z-index: 1;
+  pointer-events: none;
+}
+
+:host .picker-before {
+  top: 0;
+  height: 83px;
 }
 @supports (inset-inline-start: 0) {
-  :host {
+  :host .picker-before {
     inset-inline-start: 0;
   }
 }
 @supports not (inset-inline-start: 0) {
-  :host {
+  :host .picker-before {
     left: 0;
   }
-  :host-context([dir=rtl]) {
+  :host-context([dir=rtl]) .picker-before {
     left: unset;
     right: unset;
     right: 0;
   }
   @supports selector(:dir(rtl)) {
-    :host(:dir(rtl)) {
+    :host(:dir(rtl)) .picker-before {
       left: unset;
       right: unset;
       right: 0;
@@ -116,69 +116,82 @@
   }
 }
 
-:host(.overlay-hidden) {
-  display: none;
+:host .picker-after {
+  top: 116px;
+  height: 84px;
+}
+@supports (inset-inline-start: 0) {
+  :host .picker-after {
+    inset-inline-start: 0;
+  }
+}
+@supports not (inset-inline-start: 0) {
+  :host .picker-after {
+    left: 0;
+  }
+  :host-context([dir=rtl]) .picker-after {
+    left: unset;
+    right: unset;
+    right: 0;
+  }
+  @supports selector(:dir(rtl)) {
+    :host(:dir(rtl)) .picker-after {
+      left: unset;
+      right: unset;
+      right: 0;
+    }
+  }
 }
 
-.picker-wrapper {
-  border-radius: var(--border-radius);
+:host .picker-highlight {
+  border-radius: 8px;
   left: 0;
   right: 0;
+  top: 50%;
   bottom: 0;
   -webkit-margin-start: auto;
   margin-inline-start: auto;
   -webkit-margin-end: auto;
   margin-inline-end: auto;
-  margin-top: auto;
-  margin-bottom: auto;
-  transform: translate3d(0,  100%,  0);
-  display: flex;
+  margin-top: 0;
+  margin-bottom: 0;
   position: absolute;
-  flex-direction: column;
-  width: var(--width);
-  min-width: var(--min-width);
-  max-width: var(--max-width);
-  height: var(--height);
-  min-height: var(--min-height);
-  max-height: var(--max-height);
-  border-width: var(--border-width);
-  border-style: var(--border-style);
-  border-color: var(--border-color);
-  background: var(--background);
-  contain: strict;
-  overflow: hidden;
-  z-index: 10;
+  width: calc(100% - 16px);
+  height: 34px;
+  transform: translateY(-50%);
+  background: var(--wheel-highlight-background);
+  z-index: -1;
 }
 
-.picker-toolbar {
+:host input {
+  position: absolute;
+  top: 0;
+  left: 0;
+  right: 0;
+  bottom: 0;
   width: 100%;
-  background: transparent;
-  contain: strict;
-  z-index: 1;
-}
-
-.picker-button {
+  height: 100%;
+  margin: 0;
+  padding: 0;
   border: 0;
-  font-family: inherit;
+  outline: 0;
+  clip: rect(0 0 0 0);
+  opacity: 0;
+  overflow: hidden;
+  -webkit-appearance: none;
+  -moz-appearance: none;
 }
 
-.picker-button:active, .picker-button:focus {
-  outline: none;
+:host ::slotted(ion-picker-column:first-of-type) {
+  text-align: start;
 }
 
-.picker-columns {
-  display: flex;
-  position: relative;
-  justify-content: center;
-  margin-bottom: var(--ion-safe-area-bottom, 0);
-  contain: strict;
-  overflow: hidden;
+:host ::slotted(ion-picker-column:last-of-type) {
+  text-align: end;
 }
 
-.picker-above-highlight,
-.picker-below-highlight {
-  display: none;
-  pointer-events: none;
+:host ::slotted(ion-picker-column:only-child) {
+  text-align: center;
 }
 
 /**
@@ -236,119 +249,10 @@
  *   }
  * }
  */
-:host {
-  --background: var(--ion-background-color, #fff);
-  --border-width: 0.55px 0 0;
-  --border-color: var(--ion-item-border-color, var(--ion-border-color, var(--ion-color-step-150, rgba(0, 0, 0, 0.13))));
-  --height: 260px;
-  --backdrop-opacity: var(--ion-backdrop-opacity, 0.26);
-  color: var(--ion-item-color, var(--ion-text-color, #000));
-}
-
-.picker-toolbar {
-  display: flex;
-  justify-content: flex-end;
-  height: 44px;
+:host .picker-before {
+  background: linear-gradient(to bottom, rgba(var(--wheel-fade-background-rgb, var(--background-rgb, var(--ion-background-color-rgb, 255, 255, 255))), 1) 20%, rgba(var(--wheel-fade-background-rgb, var(--background-rgb, var(--ion-background-color-rgb, 255, 255, 255))), 0) 90%);
 }
 
-.picker-button,
-.picker-button.ion-activated {
-  margin-left: 0;
-  margin-right: 0;
-  margin-top: 0;
-  margin-bottom: 0;
-  -webkit-padding-start: 1.1em;
-  padding-inline-start: 1.1em;
-  -webkit-padding-end: 1.1em;
-  padding-inline-end: 1.1em;
-  padding-top: 0;
-  padding-bottom: 0;
-  height: 44px;
-  background: transparent;
-  color: var(--ion-color-primary, #3880ff);
-  font-size: 14px;
-  font-weight: 500;
-  text-transform: uppercase;
-  box-shadow: none;
-}
-
-.picker-columns {
-  height: 216px;
-  perspective: 1800px;
-}
-
-.picker-above-highlight {
-  top: 0;
-  transform: translate3d(0,  0,  90px);
-  position: absolute;
-  width: 100%;
-  height: 81px;
-  border-bottom: 1px solid var(--ion-item-border-color, var(--ion-border-color, var(--ion-color-step-150, rgba(0, 0, 0, 0.13))));
-  background: linear-gradient(to bottom, var(--ion-background-color, #fff) 20%, rgba(var(--ion-background-color-rgb, 255, 255, 255), 0.8) 100%);
-  z-index: 10;
-}
-@supports (inset-inline-start: 0) {
-  .picker-above-highlight {
-    inset-inline-start: 0;
-  }
-}
-@supports not (inset-inline-start: 0) {
-  .picker-above-highlight {
-    left: 0;
-  }
-  :host-context([dir=rtl]) .picker-above-highlight {
-    left: unset;
-    right: unset;
-    right: 0;
-  }
-  [dir=rtl] .picker-above-highlight {
-    left: unset;
-    right: unset;
-    right: 0;
-  }
-  @supports selector(:dir(rtl)) {
-    .picker-above-highlight:dir(rtl) {
-      left: unset;
-      right: unset;
-      right: 0;
-    }
-  }
-}
-
-.picker-below-highlight {
-  top: 115px;
-  transform: translate3d(0,  0,  90px);
-  position: absolute;
-  width: 100%;
-  height: 119px;
-  border-top: 1px solid var(--ion-item-border-color, var(--ion-border-color, var(--ion-color-step-150, rgba(0, 0, 0, 0.13))));
-  background: linear-gradient(to top, var(--ion-background-color, #fff) 30%, rgba(var(--ion-background-color-rgb, 255, 255, 255), 0.8) 100%);
-  z-index: 11;
-}
-@supports (inset-inline-start: 0) {
-  .picker-below-highlight {
-    inset-inline-start: 0;
-  }
-}
-@supports not (inset-inline-start: 0) {
-  .picker-below-highlight {
-    left: 0;
-  }
-  :host-context([dir=rtl]) .picker-below-highlight {
-    left: unset;
-    right: unset;
-    right: 0;
-  }
-  [dir=rtl] .picker-below-highlight {
-    left: unset;
-    right: unset;
-    right: 0;
-  }
-  @supports selector(:dir(rtl)) {
-    .picker-below-highlight:dir(rtl) {
-      left: unset;
-      right: unset;
-      right: 0;
-    }
-  }
+:host .picker-after {
+  background: linear-gradient(to top, rgba(var(--wheel-fade-background-rgb, var(--background-rgb, var(--ion-background-color-rgb, 255, 255, 255))), 1) 30%, rgba(var(--wheel-fade-background-rgb, var(--background-rgb, var(--ion-background-color-rgb, 255, 255, 255))), 0) 90%);
 }

package/dist/collection/components/{picker-internal/test/a11y/picker-internal.e2e.js → picker/test/a11y/picker.e2e.js}

@@ -5,9 +5,9 @@ import AxeBuilder from "@axe-core/playwright";
 import { expect } from "@playwright/test";
 import { configs, test } from "../../../../utils/test/playwright/index";
 configs().forEach(({ title, config }) => {
-    test.describe(title('picker-internal: a11y'), () => {
+    test.describe(title('picker: a11y'), () => {
         test('should not have accessibility violations', async ({ page }) => {
-            await page.goto(`/src/components/picker-internal/test/a11y`, config);
+            await page.goto(`/src/components/picker/test/a11y`, config);
             const results = await new AxeBuilder({ page }).analyze();
             expect(results.violations).toEqual([]);
         });

package/dist/collection/components/picker/test/basic/picker.e2e.js

@@ -3,23 +3,109 @@
  */
 import { expect } from "@playwright/test";
 import { configs, test } from "../../../../utils/test/playwright/index";
-configs().forEach(({ title, screenshot, config }) => {
-    test.describe(title('picker: basic'), () => {
-        test('should not have visual regressions', async ({ page }) => {
+/**
+ * This behavior does not vary across directions.
+ */
+configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+    test.describe(title('picker: rendering'), () => {
+        test('inline pickers should not have visual regression', async ({ page }) => {
+            await page.goto(`/src/components/picker/test/basic`, config);
+            const fullStack = page.locator('#inline ion-picker-column-option[data-test-value="full-stack"]');
+            const onion = page.locator('#inline ion-picker-column-option[data-test-value="onion"]');
+            await expect(fullStack).toHaveClass(/option-active/);
+            await expect(onion).toHaveClass(/option-active/);
+            await page.waitForChanges();
+            await expect(page.locator('#inline')).toHaveScreenshot(screenshot(`picker-inline-diff`));
+        });
+    });
+    test.describe(title('picker: overlay rendering'), () => {
+        test('popover: should not have visual regression', async ({ page }) => {
+            await page.goto(`/src/components/picker/test/basic`, config);
+            const button = page.locator('#popover');
+            const didPresent = await page.spyOnEvent('ionPopoverDidPresent');
+            const picker = page.locator('ion-popover ion-picker');
+            await button.click();
+            await didPresent.next();
+            await expect(picker).toBeVisible();
+            const popoverContent = page.locator('ion-popover .ion-delegate-host');
+            await expect(popoverContent).toHaveScreenshot(screenshot(`picker-popover-diff`), {
+                /**
+                 * Animations must be enabled to capture the screenshot.
+                 * By default, animations are disabled with toHaveScreenshot,
+                 * and when capturing the screenshot will call animation.finish().
+                 * This will cause the popover to close and the screenshot capture
+                 * to be invalid.
+                 */
+                animations: 'allow',
+            });
+        });
+        test('modal: should not have visual regression', async ({ page }) => {
             await page.goto('/src/components/picker/test/basic', config);
-            const didPresent = await page.spyOnEvent('ionPickerDidPresent');
-            const didDismiss = await page.spyOnEvent('ionPickerDidDismiss');
-            await page.click('#basic');
+            const button = page.locator('#modal');
+            const didPresent = await page.spyOnEvent('ionModalDidPresent');
+            const picker = page.locator('ion-modal ion-picker');
+            await button.click();
             await didPresent.next();
+            await expect(picker).toBeVisible();
+            const modalContent = page.locator('ion-modal .ion-delegate-host');
+            await expect(modalContent).toHaveScreenshot(screenshot(`picker-modal-diff`), {
+                /**
+                 * Animations must be enabled to capture the screenshot.
+                 * By default, animations are disabled with toHaveScreenshot,
+                 * and when capturing the screenshot will call animation.finish().
+                 * This will cause the modal to close and the screenshot capture
+                 * to be invalid.
+                 */
+                animations: 'allow',
+            });
+        });
+    });
+});
+/**
+ * This behavior does not vary across modes/directions.
+ */
+configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
+    test.describe(title('picker: focus'), () => {
+        test.beforeEach(async ({ page }) => {
+            await page.setContent(`
+        <ion-picker>
+          <ion-picker-column value="full-stack" id="first">
+            <ion-picker-column-option value="minified">Minified</ion-picker-column-option>
+            <ion-picker-column-option value="responsive">Responsive</ion-picker-column-option>
+            <ion-picker-column-option value="full-stack">Full Stack</ion-picker-column-option>
+            <ion-picker-column-option value="mobile-first">Mobile First</ion-picker-column-option>
+            <ion-picker-column-option value="serverless">Serverless</ion-picker-column-option>
+          </ion-picker-column>
+          <ion-picker-column value="onion" id="second">
+            <ion-picker-column-option value="tomato">Tomato</ion-picker-column-option>
+            <ion-picker-column-option value="avocado">Avocado</ion-picker-column-option>
+            <ion-picker-column-option value="onion">Onion</ion-picker-column-option>
+            <ion-picker-column-option value="potato">Potato</ion-picker-column-option>
+            <ion-picker-column-option value="artichoke">Artichoke</ion-picker-column-option>
+          </ion-picker-column>
+        </ion-picker>
+      `, config);
+        });
+        test('tabbing should correctly move focus between columns', async ({ page }) => {
+            const firstColumn = page.locator('ion-picker-column#first');
+            const secondColumn = page.locator('ion-picker-column#second');
+            // Focus first column
+            await page.keyboard.press('Tab');
+            await expect(firstColumn).toBeFocused();
             await page.waitForChanges();
-            await expect(page).toHaveScreenshot(screenshot(`picker-basic`));
-            await page.click('.picker-opt:nth-child(2)');
-            await page.click('ion-picker .save-btn');
-            await didDismiss.next();
-            await page.click('#basic');
-            await didPresent.next();
+            // Focus second column
+            await page.keyboard.press('Tab');
+            await expect(secondColumn).toBeFocused();
+        });
+        test('tabbing should correctly move focus back', async ({ page }) => {
+            const firstColumn = page.locator('ion-picker-column#first');
+            const secondColumn = page.locator('ion-picker-column#second');
+            await secondColumn.evaluate((el) => el.setFocus());
+            await expect(secondColumn).toBeFocused();
             await page.waitForChanges();
-            await expect(page).toHaveScreenshot(screenshot(`picker-value-selected`));
+            // Focus first column
+            await page.keyboard.press('Shift+Tab');
+            await expect(firstColumn).toBeFocused();
         });
     });
 });

package/dist/collection/components/{picker-internal/test/keyboard-entry/picker-internal.e2e.js → picker/test/keyboard-entry/picker.e2e.js}

@@ -6,16 +6,17 @@ import { configs, test } from "../../../../utils/test/playwright/index";
 /**
  * This behavior does not vary across modes/directions.
  */
+// TODO FW-5580 fix this functionality
 configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
-    test.describe(title('picker-internal: keyboard entry'), () => {
+    test.describe.skip(title('picker: keyboard entry'), () => {
         test('should scroll to and update the value prop for a single column', async ({ page }) => {
             await page.setContent(`
-        <ion-picker-internal>
-          <ion-picker-column-internal></ion-picker-column-internal>
-        </ion-picker-internal>
+        <ion-picker>
+          <ion-picker-column></ion-picker-column>
+        </ion-picker>
 
         <script>
-          const column = document.querySelector('ion-picker-column-internal');
+          const column = document.querySelector('ion-picker-column');
           column.items = [
             { text: '01', value: 1 },
             { text: '02', value: 2 },
@@ -27,22 +28,22 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
           column.numericInput = true;
         </script>
       `, config);
-            const column = page.locator('ion-picker-column-internal');
+            const column = page.locator('ion-picker-column');
             const ionChange = await page.spyOnEvent('ionChange');
-            await column.focus();
+            await column.evaluate((el) => el.setFocus());
             await page.keyboard.press('Digit2');
             await expect(ionChange).toHaveReceivedEventDetail({ text: '02', value: 2 });
             await expect(column).toHaveJSProperty('value', 2);
         });
         test('should scroll to and update the value prop for multiple columns', async ({ page }) => {
             await page.setContent(`
-        <ion-picker-internal>
-          <ion-picker-column-internal id="first"></ion-picker-column-internal>
-          <ion-picker-column-internal id="second"></ion-picker-column-internal>
-        </ion-picker-internal>
+        <ion-picker>
+          <ion-picker-column id="first"></ion-picker-column>
+          <ion-picker-column id="second"></ion-picker-column>
+        </ion-picker>
 
         <script>
-          const firstColumn = document.querySelector('ion-picker-column-internal#first');
+          const firstColumn = document.querySelector('ion-picker-column#first');
           firstColumn.items = [
             { text: '01', value: 1 },
             { text: '02', value: 2 },
@@ -53,7 +54,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
           firstColumn.value = 5;
           firstColumn.numericInput = true;
 
-          const secondColumn = document.querySelector('ion-picker-column-internal#second');
+          const secondColumn = document.querySelector('ion-picker-column#second');
           secondColumn.items = [
             { text: '20', value: 20 },
             { text: '21', value: 21 },
@@ -65,9 +66,9 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
           secondColumn.numericInput = true;
         </script>
       `, config);
-            const firstColumn = page.locator('ion-picker-column-internal#first');
-            const secondColumn = page.locator('ion-picker-column-internal#second');
-            const highlight = page.locator('ion-picker-internal .picker-highlight');
+            const firstColumn = page.locator('ion-picker-column#first');
+            const secondColumn = page.locator('ion-picker-column#second');
+            const highlight = page.locator('ion-picker .picker-highlight');
             const firstIonChange = await firstColumn.spyOnEvent('ionChange');
             const secondIonChange = await secondColumn.spyOnEvent('ionChange');
             const box = await highlight.boundingBox();
@@ -85,12 +86,12 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
         });
         test('should select 00', async ({ page }) => {
             await page.setContent(`
-        <ion-picker-internal>
-          <ion-picker-column-internal></ion-picker-column-internal>
-        </ion-picker-internal>
+        <ion-picker>
+          <ion-picker-column></ion-picker-column>
+        </ion-picker>
 
         <script>
-          const column = document.querySelector('ion-picker-column-internal');
+          const column = document.querySelector('ion-picker-column');
           column.items = [
             { text: '00', value: 12 },
             { text: '01', value: 1 },
@@ -103,9 +104,9 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
           column.numericInput = true;
         </script>
       `, config);
-            const column = page.locator('ion-picker-column-internal');
+            const column = page.locator('ion-picker-column');
             const ionChange = await page.spyOnEvent('ionChange');
-            await column.focus();
+            await column.evaluate((el) => el.setFocus());
             await page.keyboard.press('Digit0');
             await expect(ionChange).toHaveReceivedEventDetail({ text: '00', value: 12 });
             await expect(column).toHaveJSProperty('value', 12);