@internetarchive/collection-browser 2.12.1-alpha-webdev5427.7 → 2.12.2-alpha-webdev7587.0

package/src/collection-browser.ts

@@ -43,8 +43,6 @@ import {
   SORT_OPTIONS,
   defaultProfileElementSorts,
   FacetLoadStrategy,
-  defaultFacetDisplayOrder,
-  tvFacetDisplayOrder,
 } from './models';
 import {
   RestorationStateHandlerInterface,
@@ -1102,16 +1100,10 @@ export class CollectionBrowser
       `;
     }
 
-    // We switch to TV facet ordering & date picker if we are in a TV collection or showing TV search results
-    const shouldUseTvInterface =
-      this.isTVCollection ||
-      (!this.withinCollection && this.searchType === SearchType.TV);
-    const facetDisplayOrder = shouldUseTvInterface
-      ? tvFacetDisplayOrder
-      : defaultFacetDisplayOrder;
-
     const facets = html`
       <collection-facets
+        @facetsChanged=${this.facetsChanged}
+        @histogramDateRangeUpdated=${this.histogramDateRangeUpdated}
         .collectionPagePath=${this.collectionPagePath}
         .parentCollections=${this.dataSource.parentCollections}
         .pageSpecifierParams=${this.dataSource.pageSpecifierParams}
@@ -1130,21 +1122,16 @@ export class CollectionBrowser
         .collectionTitles=${this.dataSource.collectionTitles}
         .showHistogramDatePicker=${this.showHistogramDatePicker}
         .allowExpandingDatePicker=${!this.mobileView}
-        .allowDatePickerMonths=${shouldUseTvInterface}
         .contentWidth=${this.contentWidth}
         .query=${this.baseQuery}
         .filterMap=${this.dataSource.filterMap}
         .isManageView=${this.isManageView}
         .modalManager=${this.modalManager}
-        .analyticsHandler=${this.analyticsHandler}
-        .facetDisplayOrder=${facetDisplayOrder}
-        .isTvSearch=${shouldUseTvInterface}
         ?collapsableFacets=${this.mobileView}
         ?facetsLoading=${this.facetsLoading}
         ?fullYearAggregationLoading=${this.facetsLoading}
         @facetClick=${this.facetClickHandler}
-        @facetsChanged=${this.facetsChanged}
-        @histogramDateRangeUpdated=${this.histogramDateRangeUpdated}
+        .analyticsHandler=${this.analyticsHandler}
       >
       </collection-facets>
     `;

package/src/collection-facets/facet-row.ts

@@ -56,15 +56,11 @@ export class FacetRow extends LitElement {
     const showOnlyCheckboxId = `${facetType}:${bucket.key}-show-only`;
     const negativeCheckboxId = `${facetType}:${bucket.key}-negative`;
 
-    const extraNoteSpan = bucket.extraNote
-      ? html`<span class="facet-note">${bucket.extraNote}</span>`
-      : nothing;
-
     // For collections, we render the collection title as a link.
     // For other facet types, we just have a static value to use.
     const bucketTextDisplay =
       facetType !== 'collection'
-        ? html`${bucket.displayText ?? bucket.key} ${extraNoteSpan}`
+        ? html`${bucket.displayText ?? bucket.key}`
         : html`<a href="/details/${bucket.key}">
             ${this.collectionTitles?.get(bucket.key) ?? bucket.key}
           </a> `;
@@ -230,9 +226,6 @@ export class FacetRow extends LitElement {
         display: inline-block;
         flex: 1 1 0%;
       }
-      .facet-note {
-        color: #bbb;
-      }
       .facet-count {
         text-align: right;
       }

package/src/collection-facets/more-facets-content.ts

@@ -32,7 +32,6 @@ import {
   defaultFacetSort,
   getDefaultSelectedFacets,
   FacetEventDetails,
-  tvChannelFacetLabels,
 } from '../models';
 import type {
   CollectionTitles,
@@ -61,7 +60,7 @@ export class MoreFacetsContent extends LitElement {
 
   @property({ type: Object }) filterMap?: FilterMap;
 
-  @property({ type: Number }) searchType?: SearchType;
+  @property({ type: String }) searchType?: SearchType;
 
   @property({ type: Object }) pageSpecifierParams?: PageSpecifierParams;
 
@@ -84,11 +83,9 @@ export class MoreFacetsContent extends LitElement {
    */
   @property({ type: Object }) selectedFacets?: SelectedFacets;
 
-  @property({ type: Number }) sortedBy: AggregationSortType =
+  @property({ type: String }) sortedBy: AggregationSortType =
     AggregationSortType.COUNT;
 
-  @property({ type: Boolean }) isTvSearch = false;
-
   @property({ type: Object }) modalManager?: ModalManagerInterface;
 
   @property({ type: Object }) searchService?: SearchServiceInterface;
@@ -112,8 +109,7 @@ export class MoreFacetsContent extends LitElement {
    * eventually merged into the existing `selectedFacets` when the patron applies
    * their changes, or discarded if they cancel/close the dialog.
    */
-  @state() private unappliedFacetChanges: SelectedFacets =
-    getDefaultSelectedFacets();
+  @state() private unappliedFacetChanges = getDefaultSelectedFacets();
 
   /**
    * Which page of facets we are showing.
@@ -276,25 +272,13 @@ export class MoreFacetsContent extends LitElement {
     // Apply any unapplied selections that appear on this page
     const unappliedBuckets = this.unappliedFacetChanges[this.facetKey];
     for (const [index, bucket] of bucketsWithCount.entries()) {
-      const unappliedBucket = unappliedBuckets?.[bucket.key];
+      const unappliedBucket = unappliedBuckets[bucket.key];
       if (unappliedBucket) {
         bucketsWithCount[index] = { ...unappliedBucket };
       }
     }
-
-    // For TV creator facets, uppercase the display text
-    if (this.facetKey === 'creator' && this.isTvSearch) {
-      bucketsWithCount.forEach(b => {
-        b.displayText = (b.displayText ?? b.key)?.toLocaleUpperCase();
-
-        const channelLabel = tvChannelFacetLabels[b.displayText];
-        if (channelLabel && channelLabel !== b.displayText) {
-          b.extraNote = `(${channelLabel})`;
-        }
-      });
-    }
-
     facetGroup.buckets = bucketsWithCount;
+
     return facetGroup;
   }
 

package/src/collection-facets/smart-facets/smart-facet-bar.ts

@@ -202,7 +202,7 @@ export class SmartFacetBar extends LitElement {
         if (
           key === 'mediatype' &&
           this.selectedFacets &&
-          Object.values(this.selectedFacets.mediatype ?? {}).some(
+          Object.values(this.selectedFacets.mediatype).some(
             bucket => bucket.state !== 'none',
           )
         ) {
@@ -213,7 +213,7 @@ export class SmartFacetBar extends LitElement {
         const buckets = agg.buckets as Bucket[];
 
         const unusedBuckets = buckets.filter(b => {
-          const selectedFacetBucket = this.selectedFacets?.[facetType]?.[b.key];
+          const selectedFacetBucket = this.selectedFacets?.[facetType][b.key];
           if (selectedFacetBucket && selectedFacetBucket.state !== 'none') {
             return false;
           }

package/src/collection-facets.ts

@@ -11,7 +11,7 @@ import { map } from 'lit/directives/map.js';
 import { ref } from 'lit/directives/ref.js';
 import { msg } from '@lit/localize';
 import { classMap } from 'lit/directives/class-map.js';
-import {
+import type {
   Aggregation,
   AggregationSortType,
   Bucket,
@@ -36,7 +36,7 @@ import {
   SelectedFacets,
   FacetGroup,
   FacetBucket,
-  defaultFacetDisplayOrder,
+  facetDisplayOrder,
   facetTitles,
   lendingFacetDisplayNames,
   lendingFacetKeysVisibility,
@@ -44,7 +44,6 @@ import {
   suppressedCollections,
   defaultFacetSort,
   FacetEventDetails,
-  tvChannelFacetLabels,
 } from './models';
 import type {
   CollectionTitles,
@@ -69,7 +68,7 @@ import {
 export class CollectionFacets extends LitElement {
   @property({ type: Object }) searchService?: SearchServiceInterface;
 
-  @property({ type: Number }) searchType?: SearchType;
+  @property({ type: String }) searchType?: SearchType;
 
   @property({ type: Object }) aggregations?: Record<string, Aggregation>;
 
@@ -109,11 +108,6 @@ export class CollectionFacets extends LitElement {
 
   @property({ type: Boolean }) isManageView = false;
 
-  @property({ type: Boolean }) isTvSearch = false;
-
-  @property({ type: Array }) facetDisplayOrder: FacetOption[] =
-    defaultFacetDisplayOrder;
-
   @property({ type: Object, attribute: false })
   modalManager?: ModalManagerInterface;
 
@@ -140,9 +134,6 @@ export class CollectionFacets extends LitElement {
     creator: false,
     collection: false,
     year: false,
-    program: false,
-    person: false,
-    sponsor: false,
   };
 
   /**
@@ -236,7 +227,6 @@ export class CollectionFacets extends LitElement {
     const minDate = fullYearsHistogramAggregation?.first_bucket_key;
     const maxDate = fullYearsHistogramAggregation?.last_bucket_key;
     const buckets = fullYearsHistogramAggregation?.buckets as number[];
-    const dateFormat = this.isTvSearch ? 'YYYY-MM' : 'YYYY';
 
     // Because the modal manager does not clear its DOM content after being closed,
     // it may try to render the exact same date picker template when it is reopened.
@@ -261,7 +251,6 @@ export class CollectionFacets extends LitElement {
         .maxDate=${maxDate}
         .minSelectedDate=${this.minSelectedDate}
         .maxSelectedDate=${this.maxSelectedDate}
-        .dateFormat=${dateFormat}
         .buckets=${buckets}
         .modalManager=${this.modalManager}
         .analyticsHandler=${this.analyticsHandler}
@@ -275,7 +264,7 @@ export class CollectionFacets extends LitElement {
       headerColor: '#194880',
       showHeaderLogo: false,
       closeOnBackdropClick: true, // TODO: want to fire analytics
-      title: html`${msg('Select a date range')}`,
+      title: html`Select a date range`,
     });
 
     this.modalManager?.classList.add('expanded-date-picker');
@@ -330,18 +319,15 @@ export class CollectionFacets extends LitElement {
     const { fullYearsHistogramAggregation } = this;
     const minDate = fullYearsHistogramAggregation?.first_bucket_key;
     const maxDate = fullYearsHistogramAggregation?.last_bucket_key;
-    const dateFormat = this.isTvSearch ? 'YYYY-MM' : 'YYYY';
     return this.fullYearAggregationLoading
       ? html`<div class="histogram-loading-indicator">&hellip;</div>` // Ellipsis block
       : html`
           <histogram-date-range
-            class=${this.isTvSearch ? 'wide-inputs' : nothing}
             .minDate=${minDate}
             .maxDate=${maxDate}
             .minSelectedDate=${this.minSelectedDate ?? minDate}
             .maxSelectedDate=${this.maxSelectedDate ?? maxDate}
             .updateDelay=${100}
-            .dateFormat=${dateFormat}
             missingDataMessage="..."
             .width=${this.collapsableFacets && this.contentWidth
               ? this.contentWidth
@@ -377,7 +363,7 @@ export class CollectionFacets extends LitElement {
   private get mergedFacets(): FacetGroup[] {
     const facetGroups: FacetGroup[] = [];
 
-    this.facetDisplayOrder.forEach(facetKey => {
+    facetDisplayOrder.forEach(facetKey => {
       const selectedFacetGroup = this.selectedFacetGroups.find(
         group => group.key === facetKey,
       );
@@ -439,7 +425,7 @@ export class CollectionFacets extends LitElement {
       }
 
       // Sort the FacetBuckets so that selected and hidden buckets come before the rest
-      sortBucketsBySelectionState(bucketsWithCount, defaultFacetSort[facetKey]);
+      sortBucketsBySelectionState(bucketsWithCount);
 
       // For mediatype facets, ensure the collection bucket is always shown if present
       if (facetKey === 'mediatype') {
@@ -462,18 +448,6 @@ export class CollectionFacets extends LitElement {
         }
       }
 
-      // For TV creator facets, uppercase the display text
-      if (facetKey === 'creator' && this.isTvSearch) {
-        bucketsWithCount.forEach(b => {
-          b.displayText = (b.displayText ?? b.key)?.toLocaleUpperCase();
-
-          const channelLabel = tvChannelFacetLabels[b.displayText];
-          if (channelLabel && channelLabel !== b.displayText) {
-            b.extraNote = `(${channelLabel})`;
-          }
-        });
-      }
-
       // slice off how many items we want to show in page facet area
       facetGroup.buckets = bucketsWithCount.slice(0, allowedFacetCount);
 
@@ -705,7 +679,6 @@ export class CollectionFacets extends LitElement {
         .collectionTitles=${this.collectionTitles}
         .selectedFacets=${this.selectedFacets}
         .sortedBy=${sortedBy}
-        .isTvSearch=${this.isTvSearch}
         @facetsChanged=${(e: CustomEvent) => {
           const event = new CustomEvent<SelectedFacets>('facetsChanged', {
             detail: e.detail,
@@ -847,6 +820,8 @@ export class CollectionFacets extends LitElement {
 
         h3 {
           font-size: 1.4rem;
+          font-weight: 200
+          padding-bottom: 3px;
           margin: 0;
         }
 
@@ -883,10 +858,6 @@ export class CollectionFacets extends LitElement {
           height: 15px;
           cursor: pointer;
         }
-
-        histogram-date-range.wide-inputs {
-          --histogramDateRangeInputWidth: 4.8rem;
-        }
       `,
     ];
   }

package/src/data-source/collection-browser-data-source-interface.ts

@@ -156,7 +156,7 @@ export interface CollectionBrowserDataSourceInterface
   reset(): void;
 
   /**
-   * Resets the data source to its pages.
+   * Resets the data source's result pages, keeping other state intact.
    */
   resetPages(): void;
 

package/src/data-source/collection-browser-data-source.ts

@@ -258,8 +258,10 @@ export class CollectionBrowserDataSource
     if (Object.keys(this.pages).length < this.host.maxPagesToManage) {
       this.pages = {};
 
-      // Invalidate any fetches in progress
-      this.fetchesInProgress.clear();
+      // Invalidate any page fetches in progress (keep facet fetches)
+      this.fetchesInProgress.forEach(key => {
+        if (!key.startsWith('facets-')) this.fetchesInProgress.delete(key);
+      });
       this.requestHostUpdate();
     }
   }
@@ -676,7 +678,7 @@ export class CollectionBrowserDataSource
   get facetFetchQueryKey(): string {
     const profileKey = `pf;${this.host.withinProfile}--pe;${this.host.profileElement}`;
     const pageTarget = this.host.withinCollection ?? profileKey;
-    return `fq:${this.fullQuery}-pt:${pageTarget}-st:${this.host.searchType}`;
+    return `facets-fq:${this.fullQuery}-pt:${pageTarget}-st:${this.host.searchType}`;
   }
 
   /**
@@ -687,39 +689,27 @@ export class CollectionBrowserDataSource
   get filterMap(): FilterMap {
     const builder = new FilterMapBuilder();
 
-    const {
-      minSelectedDate,
-      maxSelectedDate,
-      selectedFacets,
-      selectedTitleFilter,
-      selectedCreatorFilter,
-    } = this.host;
-
-    // Add the date range, if applicable.
-    // If the min/max are just years, filter on `year` alone. If months/days are included, use `date` instead.
-    const dateRangeField =
-      minSelectedDate?.includes('-') || maxSelectedDate?.includes('-')
-        ? 'date'
-        : 'year';
-
-    if (minSelectedDate) {
+    // Add the date range, if applicable
+    if (this.host.minSelectedDate) {
       builder.addFilter(
-        dateRangeField,
-        minSelectedDate,
+        'year',
+        this.host.minSelectedDate,
         FilterConstraint.GREATER_OR_EQUAL,
       );
     }
-    if (maxSelectedDate) {
+    if (this.host.maxSelectedDate) {
       builder.addFilter(
-        dateRangeField,
-        maxSelectedDate,
+        'year',
+        this.host.maxSelectedDate,
         FilterConstraint.LESS_OR_EQUAL,
       );
     }
 
     // Add any selected facets
-    if (selectedFacets) {
-      for (const [facetName, facetValues] of Object.entries(selectedFacets)) {
+    if (this.host.selectedFacets) {
+      for (const [facetName, facetValues] of Object.entries(
+        this.host.selectedFacets,
+      )) {
         const { name, values } = this.prepareFacetForFetch(
           facetName,
           facetValues,
@@ -740,17 +730,17 @@ export class CollectionBrowserDataSource
     }
 
     // Add any letter filters
-    if (selectedTitleFilter) {
+    if (this.host.selectedTitleFilter) {
       builder.addFilter(
         'firstTitle',
-        selectedTitleFilter,
+        this.host.selectedTitleFilter,
         FilterConstraint.INCLUDE,
       );
     }
-    if (selectedCreatorFilter) {
+    if (this.host.selectedCreatorFilter) {
       builder.addFilter(
         'firstCreator',
-        selectedCreatorFilter,
+        this.host.selectedCreatorFilter,
         FilterConstraint.INCLUDE,
       );
     }

package/src/expanded-date-picker.ts

@@ -1,6 +1,5 @@
 import { css, html, LitElement, CSSResultGroup, TemplateResult } from 'lit';
 import { customElement, property } from 'lit/decorators.js';
-import { msg } from '@lit/localize';
 import type { ModalManagerInterface } from '@internetarchive/modal-manager';
 import type { AnalyticsManagerInterface } from '@internetarchive/analytics-manager';
 import {
@@ -20,8 +19,6 @@ export class ExpandedDatePicker extends LitElement {
 
   @property({ type: Array }) buckets?: number[];
 
-  @property({ type: String }) dateFormat: string = 'YYYY';
-
   @property({ type: Object, attribute: false })
   modalManager?: ModalManagerInterface;
 
@@ -37,7 +34,6 @@ export class ExpandedDatePicker extends LitElement {
           .maxDate=${this.maxDate}
           .minSelectedDate=${this.minSelectedDate ?? this.minDate}
           .maxSelectedDate=${this.maxSelectedDate ?? this.maxDate}
-          .dateFormat=${this.dateFormat}
           .updateDelay=${0}
           updateWhileFocused
           missingDataMessage="..."
@@ -51,7 +47,7 @@ export class ExpandedDatePicker extends LitElement {
             slot="inputs-right-side"
             @click=${this.applyBtnClicked}
           >
-            ${msg('Apply date range')}
+            Apply date range
           </button>
         </histogram-date-range>
       </div>

package/src/models.ts

@@ -530,24 +530,18 @@ export type FacetOption =
   | 'language'
   | 'creator'
   | 'collection'
-  | 'year'
-  // TV-specific facet options:
-  | 'program'
-  | 'person'
-  | 'sponsor';
+  | 'year';
 
 export type SelectedFacetState = 'selected' | 'hidden';
 
 export type FacetState = SelectedFacetState | 'none';
 
 export interface FacetBucket {
+  // for some facets, we augment the key with a display value
+  displayText?: string;
   key: string;
   count: number;
   state: FacetState;
-  // for some facets, we augment the key with a display value
-  displayText?: string;
-  // for TV channel facets, we add a parenthesized secondary name
-  extraNote?: string;
 }
 
 export interface FacetGroup {
@@ -577,11 +571,12 @@ export type FacetEventDetails = {
 
 export type FacetValue = string;
 
-export type SelectedFacets = Partial<
-  Record<FacetOption, Record<FacetValue, FacetBucket>>
+export type SelectedFacets = Record<
+  FacetOption,
+  Record<FacetValue, FacetBucket>
 >;
 
-export const getDefaultSelectedFacets = (): Required<SelectedFacets> => ({
+export const getDefaultSelectedFacets = (): SelectedFacets => ({
   subject: {},
   lending: {},
   mediatype: {},
@@ -589,15 +584,9 @@ export const getDefaultSelectedFacets = (): Required<SelectedFacets> => ({
   creator: {},
   collection: {},
   year: {},
-  program: {},
-  person: {},
-  sponsor: {},
 });
 
-/**
- * Facet display order when presenting results for all search types *except* TV (see below).
- */
-export const defaultFacetDisplayOrder: FacetOption[] = [
+export const facetDisplayOrder: FacetOption[] = [
   'mediatype',
   // 'lending', Commenting this out removes the lending facet from the sidebar for now
   'year',
@@ -607,23 +596,6 @@ export const defaultFacetDisplayOrder: FacetOption[] = [
   'language',
 ];
 
-/**
- * Specialized facet ordering when displaying TV search results
- */
-export const tvFacetDisplayOrder: FacetOption[] = [
-  'program',
-  'creator',
-  'year',
-  'subject',
-  'collection',
-  'person',
-  'sponsor',
-  'language',
-];
-
-/**
- * Human-readable titles for each facet group.
- */
 export const facetTitles: Record<FacetOption, string> = {
   subject: 'Subject',
   lending: 'Availability',
@@ -632,9 +604,6 @@ export const facetTitles: Record<FacetOption, string> = {
   creator: 'Creator',
   collection: 'Collection',
   year: 'Year',
-  program: 'Program',
-  person: 'Person',
-  sponsor: 'Sponsor',
 };
 
 /**
@@ -647,10 +616,7 @@ export const defaultFacetSort: Record<FacetOption, AggregationSortType> = {
   language: AggregationSortType.COUNT,
   creator: AggregationSortType.COUNT,
   collection: AggregationSortType.COUNT,
-  year: AggregationSortType.NUMERIC, // Year facets are ordered by their numeric value by default
-  program: AggregationSortType.COUNT,
-  person: AggregationSortType.COUNT,
-  sponsor: AggregationSortType.COUNT,
+  year: AggregationSortType.NUMERIC,
 };
 
 /**
@@ -664,47 +630,9 @@ export const valueFacetSort: Record<FacetOption, AggregationSortType> = {
   language: AggregationSortType.ALPHABETICAL,
   creator: AggregationSortType.ALPHABETICAL,
   collection: AggregationSortType.ALPHABETICAL,
-  year: AggregationSortType.NUMERIC, // Year facets' values should be compared numerically, not lexicographically (year 2001 > year 3)
-  program: AggregationSortType.ALPHABETICAL,
-  person: AggregationSortType.ALPHABETICAL,
-  sponsor: AggregationSortType.ALPHABETICAL,
+  year: AggregationSortType.NUMERIC,
 };
 
-/**
- * Extra parenthesized labels to show next to certain TV channel facets
- *
- * TODO this is temporary for testing
- */
-export const tvChannelFacetLabels: Record<string, string> = Object.fromEntries(
-  // prettier-ignore
-  Object.entries({
-    'Al Jazeera'     : ['ALJAZAM', 'ALJAZ'],
-    'Bloomberg'      : ['BLOOMBERG'],
-    'BBC'            : ['BBC', 'BBC1', 'BBC2'],
-    'BBC America'    : ['BBCAMERICA'],
-    'BBC News'       : ['BBCNEWS'],
-    'GB News'        : ['GBN'],
-    'BET'            : ['BETW'],
-    'CNBC'           : ['CNBC'],
-    'CNN'            : ['CNNW', 'CNN'],
-    'Comedy Central' : ['COM', 'COMW'],
-    'CSPAN'          : ['CSPAN', 'CSPAN2', 'CSPAN3'],
-    'Current'        : ['CURRENT'],
-    'Deutsche Welle' : ['DW'],
-    'France 24'      : ['FRANCE24'],
-    'FOX Business'   : ['FBC'],
-    'FOX News'       : ['FOXNEWSW', 'FOXNEWS'],
-    'LINKTV'         : ['LINKTV'],
-    'MSNBC'          : ['MSNBCW', 'MSNBC'],
-    'NHK World'      : ['NHK'],
-    'RT'             : ['RT'],
-    'Sky News'       : ['SKY'],
-  }).reduce(
-    (acc, [label, channels]) => acc.concat(channels.map(ch => [ch, label])),
-    [] as [string, string][],
-  ),
-);
-
 export type LendingFacetKey =
   | 'is_lendable'
   | 'is_borrowable'

package/src/restoration-state-handler.ts

@@ -185,16 +185,10 @@ export class RestorationStateHandler
       }
     }
 
-    const dateField =
-      state.minSelectedDate?.includes('-') ||
-      state.maxSelectedDate?.includes('-')
-        ? 'date'
-        : 'year';
-
     if (state.minSelectedDate && state.maxSelectedDate) {
       newParams.append(
         'and[]',
-        `${dateField}:[${state.minSelectedDate} TO ${state.maxSelectedDate}]`,
+        `year:[${state.minSelectedDate} TO ${state.maxSelectedDate}]`,
       );
     }
 
@@ -343,7 +337,6 @@ export class RestorationStateHandler
         }
 
         switch (field) {
-          case 'date':
           case 'year': {
             const [minDate, maxDate] = value.split(' TO ');
             // we have two potential ways of filtering by date:

package/src/utils/facet-utils.ts

@@ -62,7 +62,7 @@ export function updateSelectedFacetBucket(
   omitNoneState = false,
 ): SelectedFacets {
   const defaultedSelectedFacets = selectedFacets ?? getDefaultSelectedFacets();
-  const newFacets: SelectedFacets = {
+  const newFacets = {
     ...defaultedSelectedFacets,
     [facetType]: {
       ...defaultedSelectedFacets[facetType],
@@ -71,7 +71,7 @@ export function updateSelectedFacetBucket(
   };
 
   if (omitNoneState && bucket.state === 'none') {
-    delete newFacets[facetType]?.[bucket.key];
+    delete newFacets[facetType][bucket.key];
   }
 
   return newFacets;
@@ -93,7 +93,6 @@ export function cloneSelectedFacets(
 ): SelectedFacets {
   const cloneResult = getDefaultSelectedFacets();
   forEachFacetBucket(selectedFacets, (facetType, bucketKey, bucket) => {
-    if (!cloneResult[facetType]) cloneResult[facetType] = {};
     cloneResult[facetType][bucketKey] = bucket;
   });
   return cloneResult;
@@ -125,14 +124,13 @@ export function mergeSelectedFacets(
 ): SelectedFacets {
   const mergeResult = cloneSelectedFacets(destination);
   forEachFacetBucket(source, (facetType, bucketKey, bucket) => {
-    if (!mergeResult[facetType]) mergeResult[facetType] = {};
     mergeResult[facetType][bucketKey] = bucket;
   });
 
   // Normalize any 'none' states on the result (from either source or destination)
   forEachFacetBucket(mergeResult, (facetType, bucketKey, bucket) => {
     if (bucket.state === 'none') {
-      delete mergeResult[facetType]?.[bucketKey];
+      delete mergeResult[facetType][bucketKey];
     }
   });