@internetarchive/collection-browser 2.12.1-alpha-webdev5427.7 → 2.12.2-alpha-webdev7587.0

package/src/utils/local-date-from-utc.ts

@@ -11,5 +11,5 @@ export function localDateFromUTC(date: Date): Date {
  */
 export function isFirstMillisecondOfUTCYear(date?: Date): boolean {
   if (!date) return false;
-  return localDateFromUTC(date).toISOString().endsWith('-01-01T00:00:00.000Z');
+  return date.toISOString().endsWith('-01-01T00:00:00.000Z');
 }

package/test/collection-facets.test.ts

@@ -629,39 +629,6 @@ describe('Collection Facets', () => {
     expect(facetRows?.[7]?.bucket?.key).to.equal('collection');
   });
 
-  it('uses specified facet display order', async () => {
-    const el = await fixture<CollectionFacets>(
-      html`<collection-facets
-        .facetDisplayOrder=${['language', 'creator'] as FacetOption[]}
-      ></collection-facets>`,
-    );
-
-    const aggs: Record<string, Aggregation> = {
-      mediatype: new Aggregation({
-        buckets: [{ key: 'texts', doc_count: 5 }],
-      }),
-      collection: new Aggregation({
-        buckets: [{ key: 'foo', doc_count: 10 }],
-      }),
-      creator: new Aggregation({
-        buckets: [{ key: 'bar', doc_count: 15 }],
-      }),
-      language: new Aggregation({
-        buckets: [{ key: 'baz', doc_count: 20 }],
-      }),
-    };
-
-    el.aggregations = aggs;
-    await el.updateComplete;
-
-    const facetHeaders = el.shadowRoot?.querySelectorAll('.facet-group-header');
-
-    // The only two facet groups should be Language and Creator (in that order)
-    expect(facetHeaders?.length).to.equal(2);
-    expect(facetHeaders?.[0].textContent).to.contain('Language');
-    expect(facetHeaders?.[1].textContent).to.contain('Creator');
-  });
-
   describe('More Facets', () => {
     it('Does not render < allowedFacetCount', async () => {
       const el = await fixture<CollectionFacets>(

package/test/restoration-state-handler.test.ts

@@ -100,7 +100,7 @@ describe('Restoration state handler', () => {
     window.history.replaceState({ path: url.href }, '', url.href);
 
     const restorationState = handler.getRestorationState();
-    expect(restorationState.selectedFacets.year?.['2018'].state).to.equal(
+    expect(restorationState.selectedFacets.year['2018'].state).to.equal(
       'selected',
     );
   });
@@ -160,7 +160,7 @@ describe('Restoration state handler', () => {
     window.history.replaceState({ path: url.href }, '', url.href);
 
     const restorationState = handler.getRestorationState();
-    expect(restorationState.selectedFacets.subject?.foo.state).to.equal(
+    expect(restorationState.selectedFacets.subject.foo.state).to.equal(
       'selected',
     );
   });
@@ -173,7 +173,7 @@ describe('Restoration state handler', () => {
     window.history.replaceState({ path: url.href }, '', url.href);
 
     const restorationState = handler.getRestorationState();
-    expect(restorationState.selectedFacets.year?.['2018'].state).to.equal(
+    expect(restorationState.selectedFacets.year['2018'].state).to.equal(
       'hidden',
     );
   });
@@ -188,17 +188,17 @@ describe('Restoration state handler', () => {
 
     const restorationState = handler.getRestorationState();
 
-    expect(restorationState.selectedFacets.collection?.foo.state).to.equal(
+    expect(restorationState.selectedFacets.collection.foo.state).to.equal(
       'selected',
     );
-    expect(restorationState.selectedFacets.collection?.bar.state).to.equal(
+    expect(restorationState.selectedFacets.collection.bar.state).to.equal(
       'selected',
     );
 
-    expect(restorationState.selectedFacets.collection?.baz.state).to.equal(
+    expect(restorationState.selectedFacets.collection.baz.state).to.equal(
       'hidden',
     );
-    expect(restorationState.selectedFacets.collection?.boop.state).to.equal(
+    expect(restorationState.selectedFacets.collection.boop.state).to.equal(
       'hidden',
     );
   });
@@ -211,7 +211,7 @@ describe('Restoration state handler', () => {
     window.history.replaceState({ path: url.href }, '', url.href);
 
     const restorationState = handler.getRestorationState();
-    expect(restorationState.selectedFacets.collection?.foo.state).to.equal(
+    expect(restorationState.selectedFacets.collection.foo.state).to.equal(
       'hidden',
     );
   });
@@ -224,7 +224,7 @@ describe('Restoration state handler', () => {
     window.history.replaceState({ path: url.href }, '', url.href);
 
     const restorationState = handler.getRestorationState();
-    expect(restorationState.selectedFacets.subject?.foo.state).to.equal(
+    expect(restorationState.selectedFacets.subject.foo.state).to.equal(
       'selected',
     );
   });
@@ -237,7 +237,7 @@ describe('Restoration state handler', () => {
     window.history.replaceState({ path: url.href }, '', url.href);
 
     const restorationState = handler.getRestorationState();
-    expect(restorationState.selectedFacets.year?.['2018'].state).to.equal(
+    expect(restorationState.selectedFacets.year['2018'].state).to.equal(
       'hidden',
     );
   });

package/test/tiles/grid/item-tile.test.ts

@@ -247,7 +247,7 @@ describe('Item Tile', () => {
 
   it('should only show the year for a date published of Jan 1 at midnight UTC', async () => {
     const model: Partial<TileModel> = {
-      datePublished: new Date(2012, 0, 1, 0, 0, 0, 0),
+      datePublished: new Date('2012-01-01T00:00:00Z'),
     };
 
     const el = await fixture<ItemTile>(html`

package/test/tiles/list/tile-list-compact.test.ts

@@ -161,7 +161,7 @@ describe('List Tile Compact', () => {
 
   it('should only show the year for a date published of Jan 1 at midnight UTC', async () => {
     const model: Partial<TileModel> = {
-      datePublished: new Date(2012, 0, 1, 0, 0, 0, 0),
+      datePublished: new Date('2012-01-01T00:00:00Z'),
     };
 
     const el = await fixture<TileListCompact>(html`

package/test/tiles/list/tile-list.test.ts

@@ -216,9 +216,9 @@ describe('List Tile', () => {
     expect(dateRow?.textContent?.trim()).to.contain('Reviewed:  Jan 02, 2013');
   });
 
-  it('should only show the year for a date published of Jan 1 at midnight', async () => {
+  it('should only show the year for a date published of Jan 1 at midnight UTC', async () => {
     const model: Partial<TileModel> = {
-      datePublished: new Date(2012, 0, 1, 0, 0, 0, 0),
+      datePublished: new Date('2012-01-01T00:00:00Z'),
     };
 
     const el = await fixture<TileList>(html`
@@ -234,7 +234,7 @@ describe('List Tile', () => {
     expect(dateRow?.textContent?.trim()).to.contain('Published:  2012');
   });
 
-  it('should show full date added/archived/reviewed, even on Jan 1 at midnight', async () => {
+  it('should show full date added/archived/reviewed, even on Jan 1 at midnight UTC', async () => {
     const model: Partial<TileModel> = {
       dateAdded: new Date(2010, 0, 1, 0, 0, 0, 0),
       dateArchived: new Date(2011, 0, 1, 0, 0, 0, 0),

package/test/utils/local-date-from-utc.test.ts

@@ -16,18 +16,18 @@ describe('localDateFromUTC', () => {
 
 describe('isFirstMillisecondOfUTCYear', () => {
   it('returns true when date is exactly Jan 1 at midnight in UTC', async () => {
-    const midnightOnNewYearsDay = new Date(2010, 0, 1, 0, 0, 0, 0);
+    const midnightOnNewYearsDay = new Date('2010-01-01T00:00:00Z');
     expect(isFirstMillisecondOfUTCYear(midnightOnNewYearsDay)).to.be.true;
   });
 
   it('returns false when date is not exactly Jan 1 at midnight in UTC', async () => {
-    const oneMillisecondTooEarly = new Date(2009, 11, 31, 23, 59, 59, 999);
+    const oneMillisecondTooEarly = new Date('2009-12-31T23:59:59.999Z');
     expect(isFirstMillisecondOfUTCYear(oneMillisecondTooEarly)).to.be.false;
 
-    const oneMillisecondTooLate = new Date(2010, 0, 1, 0, 0, 0, 1);
+    const oneMillisecondTooLate = new Date('2010-01-01T00:00:00.001Z');
     expect(isFirstMillisecondOfUTCYear(oneMillisecondTooLate)).to.be.false;
 
-    const middleOfTheYear = new Date(2010, 6, 1, 0, 0, 0, 0);
+    const middleOfTheYear = new Date('2010-06-01T00:00:00Z');
     expect(isFirstMillisecondOfUTCYear(middleOfTheYear)).to.be.false;
   });