@infodb/p3 0.12.0 → 0.14.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +33 -35
- package/bin/p3.mjs +3 -2
- package/dist/web/assets/CompletionReview-BD7d6Yzt.js +1 -0
- package/dist/web/assets/ImprovementDialog-BoAZN1KR.js +1 -0
- package/dist/web/assets/Outputs-D-ZouoxF.js +1 -0
- package/dist/web/assets/RequestStatus-Bl3fdSbM.js +1 -0
- package/dist/web/assets/Tabs-CxeceOL-.js +1 -0
- package/dist/web/assets/TagInput-CeAbmGRR.js +1 -0
- package/dist/web/assets/TaskDrawer-BCriSnhe.js +6 -0
- package/dist/web/assets/_requestId-CZKMe_mC.js +1 -0
- package/dist/web/assets/_requestId-Fx4lLkFo.js +1 -0
- package/dist/web/assets/appCtx-BdxbkSZa.js +1 -0
- package/dist/web/assets/archive-D5IIxcSV.js +1 -0
- package/dist/web/assets/board-p6R9KMqd.js +1 -0
- package/dist/web/assets/done-BTOF188x.js +1 -0
- package/dist/web/assets/draft-BWYpm3PD.js +2 -0
- package/dist/web/assets/index-DFbY8NAR.css +2 -0
- package/dist/web/assets/index-Dpqi2dcC.js +12 -0
- package/dist/web/assets/link-D481whDt.js +1 -0
- package/dist/web/assets/metrics-CAzP6V8I.js +1 -0
- package/dist/web/assets/new-C65IJJg3.js +1 -0
- package/dist/web/assets/outputs-CXqnjSqV.js +1 -0
- package/dist/web/assets/preflightInput-ClKwkp8R.js +2 -0
- package/dist/web/assets/preload-helper-_dAYMct_.js +1 -0
- package/dist/web/assets/{quality-Pu6EISAM.js → quality-RFd-7k3r.js} +1 -1
- package/dist/web/assets/release-notes-Dtif8xsQ.js +5 -0
- package/dist/web/assets/requestData-SPc36t8Q.js +1 -0
- package/dist/web/assets/routes-DJj8CWuk.js +6 -0
- package/dist/web/assets/settings-DKJd7CLe.js +1 -0
- package/dist/web/assets/ui-CbEOnPnF.js +1 -0
- package/dist/web/assets/workTarget-DavxMs-c.js +30 -0
- package/dist/web/index.html +6 -4
- package/docs/architecture.md +430 -72
- package/docs/chatgpt-sign-in.md +2 -2
- package/docs/development.md +141 -64
- package/docs/feature-inventory.md +139 -0
- package/docs/how-to-use.md +389 -31
- package/docs/installation.md +261 -147
- package/docs/publishing.md +33 -14
- package/docs/refactoring.md +332 -0
- package/lib/cli/agentsStatus.js +198 -0
- package/lib/cli/guide.js +27 -0
- package/lib/cli/guide.md +217 -0
- package/lib/cli/help.js +45 -7
- package/lib/cli/main.js +58 -207
- package/lib/cli/project.js +34 -294
- package/lib/core/projectRegistry.js +2 -2
- package/lib/kit/appInfo.js +13 -0
- package/lib/kit/usage.js +27 -0
- package/lib/server/api/projectsRoutes.js +5 -5
- package/lib/server/server.js +7 -4
- package/lib/{cli → tasks/cli}/args.js +73 -9
- package/lib/{cli → tasks/cli}/chatgpt.js +1 -1
- package/lib/{cli → tasks/cli}/codex.js +1 -1
- package/lib/{cli → tasks/cli}/output.js +12 -2
- package/lib/{cli → tasks/cli}/preflightCommands.js +1 -1
- package/lib/tasks/cli/readOnly.js +75 -0
- package/lib/{cli → tasks/cli}/render.js +1 -1
- package/lib/{cli → tasks/cli}/requestCommands.js +24 -7
- package/lib/tasks/cli/showView.js +279 -0
- package/lib/{cli → tasks/cli}/taskCommands.js +55 -21
- package/lib/tasks/cli/tasksCli.js +149 -0
- package/lib/{core → tasks/core}/context.js +6 -9
- package/lib/tasks/core/errorOutcome.js +125 -0
- package/lib/{core → tasks/core}/hierarchy.js +1 -1
- package/lib/{core → tasks/core}/ops.js +17 -2
- package/lib/{core → tasks/core}/preflight/carryover.js +5 -1
- package/lib/{core → tasks/core}/preflight/codexEngine.js +36 -28
- package/lib/{core → tasks/core}/preflight/diagnose.js +4 -9
- package/lib/{core → tasks/core}/preflight/engine.js +9 -0
- package/lib/tasks/core/preflight/hostPaths.js +299 -0
- package/lib/{core → tasks/core}/preflight/input.js +33 -5
- package/lib/{core → tasks/core}/preflight/instructions.js +19 -2
- package/lib/{core → tasks/core}/preflight/mockEngine.js +27 -8
- package/lib/{core → tasks/core}/preflight/render.js +22 -3
- package/lib/{core → tasks/core}/preflight/service.js +86 -11
- package/lib/{core → tasks/core}/preflight/uiRender.js +5 -2
- package/lib/{core → tasks/core}/requestOps.js +214 -17
- package/lib/{core → tasks/core}/reviewRuns.js +127 -22
- package/lib/{core → tasks/core}/store/attachments.js +3 -2
- package/lib/{core → tasks/core}/store/collection.js +21 -2
- package/lib/tasks/core/store/fieldGroups.js +30 -0
- package/lib/tasks/core/store/jsonRecord.js +30 -0
- package/lib/{core → tasks/core}/store/normalize.js +15 -10
- package/lib/{core → tasks/core}/store/noteStore.js +2 -2
- package/lib/{core → tasks/core}/store/preflightStore.js +59 -22
- package/lib/{core → tasks/core}/store/projectFile.js +1 -1
- package/lib/{core → tasks/core}/store/workspace.js +28 -6
- package/lib/{core → tasks/core}/userConfig.js +1 -1
- package/lib/{core → tasks/core}/workTargets.js +1 -1
- package/lib/tasks/features/metrics/cli/metricsCommands.js +77 -0
- package/lib/tasks/features/metrics/core/definitions.js +445 -0
- package/lib/tasks/features/metrics/core/index.js +112 -0
- package/lib/tasks/features/metrics/core/manual.js +179 -0
- package/lib/tasks/features/metrics/server/metricsRoutes.js +8 -0
- package/lib/tasks/features/metrics/shared/metrics.js +42 -0
- package/lib/{core/milestoneReview → tasks/features/milestoneReview/core}/code.js +2 -11
- package/lib/{core/milestoneReview → tasks/features/milestoneReview/core}/material.js +5 -6
- package/lib/{core/milestoneReview → tasks/features/milestoneReview/core}/review.js +2 -2
- package/lib/{core/milestoneReview → tasks/features/milestoneReview/core}/service.js +38 -100
- package/lib/{core/milestoneReview → tasks/features/milestoneReview/core}/store.js +3 -3
- package/lib/{server/api → tasks/features/milestoneReview/server}/milestoneReviewRoutes.js +7 -13
- package/lib/{cli → tasks/features/quality/cli}/qualityCommands.js +36 -11
- package/lib/{core → tasks/features/quality/core}/qualityImprovement.js +16 -15
- package/lib/tasks/features/records/cli/revisitCommands.js +73 -0
- package/lib/tasks/features/records/core/completionRefs.js +46 -0
- package/lib/tasks/features/records/core/reviewCandidates.js +76 -0
- package/lib/tasks/features/records/shared/completionRecord.js +329 -0
- package/lib/tasks/features/records/shared/reviewCandidate.js +313 -0
- package/lib/tasks/features/records/shared/reworkHistory.js +86 -0
- package/lib/{cli → tasks/features/releaseNotes/cli}/releaseNotesCommands.js +7 -7
- package/lib/{core/releaseNotes → tasks/features/releaseNotes/core}/completeRequests.js +5 -6
- package/lib/{core/releaseNotes → tasks/features/releaseNotes/core}/generate.js +3 -14
- package/lib/{core/releaseNotes → tasks/features/releaseNotes/core}/material.js +3 -4
- package/lib/{core/releaseNotes → tasks/features/releaseNotes/core}/service.js +1 -1
- package/lib/{core/releaseNotes → tasks/features/releaseNotes/core}/store.js +2 -2
- package/lib/{server/api → tasks/features/releaseNotes/server}/releaseNoteRoutes.js +11 -20
- package/lib/tasks/features/requirements/cli/requirementCommands.js +289 -0
- package/lib/{shared → tasks/features/requirements/shared}/acceptance.js +292 -18
- package/lib/tasks/features/requirements/shared/requirementSource.js +635 -0
- package/lib/tasks/features/retro/cli/retroCommands.js +106 -0
- package/lib/tasks/features/retro/core/retrospective.js +197 -0
- package/lib/tasks/features/retro/shared/retrospective.js +286 -0
- package/lib/tasks/features/settings/cli/projectSettings.js +245 -0
- package/lib/{cli → tasks/features/settings/cli}/userConfig.js +50 -3
- package/lib/{core → tasks/features/settings/core}/machineSettingsEdit.js +2 -2
- package/lib/{core → tasks/features/settings/core}/repoAdmin.js +3 -3
- package/lib/{core → tasks/features/settings/core}/userTheme.js +2 -2
- package/lib/{server/api → tasks/features/settings/server}/repoRoutes.js +2 -2
- package/lib/{server/api → tasks/features/settings/server}/userThemeRoutes.js +3 -3
- package/lib/{cli → tasks/features/taskReview/cli}/taskReviewCommands.js +5 -5
- package/lib/{core/taskReview → tasks/features/taskReview/core}/material.js +13 -7
- package/lib/{core/taskReview → tasks/features/taskReview/core}/review.js +10 -3
- package/lib/{core/taskReview → tasks/features/taskReview/core}/service.js +24 -85
- package/lib/{core/taskReview → tasks/features/taskReview/core}/store.js +4 -4
- package/lib/{server/api → tasks/features/taskReview/server}/taskReviewRoutes.js +7 -14
- package/lib/{server → tasks/server}/api/manifest.js +51 -3
- package/lib/{server → tasks/server}/api/routes.js +134 -65
- package/lib/tasks/shared/commitRefs.js +10 -0
- package/lib/{shared → tasks/shared}/preflightInput.js +1 -1
- package/package.json +1 -43
- package/skills/p3/SKILL.md +9 -181
- package/dist/web/assets/ImprovementDialog-kQaVBGWH.js +0 -1
- package/dist/web/assets/Outputs-_nU_p3nu.js +0 -1
- package/dist/web/assets/RequestStatus-RG-OVQYY.js +0 -1
- package/dist/web/assets/Tabs-ew9i5SKX.js +0 -1
- package/dist/web/assets/TagInput-BtlJTF7i.js +0 -1
- package/dist/web/assets/TaskDrawer-DW8GyJqI.js +0 -6
- package/dist/web/assets/_requestId-6Nb727dD.js +0 -1
- package/dist/web/assets/_requestId-BykTgPax.js +0 -1
- package/dist/web/assets/appCtx-CxDdXABS.js +0 -1
- package/dist/web/assets/archive-Ckh295Xe.js +0 -1
- package/dist/web/assets/board-BVAIjK-Y.js +0 -1
- package/dist/web/assets/done-BGfA-3MA.js +0 -1
- package/dist/web/assets/draft-CfJeyLOl.js +0 -1
- package/dist/web/assets/index-CgRU744I.css +0 -2
- package/dist/web/assets/index-DacQ0yl4.js +0 -12
- package/dist/web/assets/new-DVygWvVc.js +0 -1
- package/dist/web/assets/outputs-B6xDsLZf.js +0 -1
- package/dist/web/assets/preflightInput-BAeEJYUK.js +0 -2
- package/dist/web/assets/preload-helper-DyCqp21K.js +0 -1
- package/dist/web/assets/release-notes-CCpzyiNf.js +0 -5
- package/dist/web/assets/requestData-D5vBnuMh.js +0 -1
- package/dist/web/assets/routes-Q91zvNc0.js +0 -4
- package/dist/web/assets/settings-BzRgcmUm.js +0 -1
- package/dist/web/assets/workTarget-C9c57JAO.js +0 -30
- package/lib/cli/readOnly.js +0 -38
- package/lib/cli/showView.js +0 -166
- /package/lib/{core/store → kit}/frontmatter.js +0 -0
- /package/lib/{core/store → kit}/fsutil.js +0 -0
- /package/lib/{cli → tasks/cli}/format.js +0 -0
- /package/lib/{core → tasks/core}/chatgpt.js +0 -0
- /package/lib/{core → tasks/core}/machineSettings.js +0 -0
- /package/lib/{core → tasks/core}/preflight/codexImage.js +0 -0
- /package/lib/{core → tasks/core}/preflight/docker.js +0 -0
- /package/lib/{core → tasks/core}/preflight/launch.js +0 -0
- /package/lib/{core → tasks/core}/preflight/launcher.mjs +0 -0
- /package/lib/{core → tasks/core}/preflight/mock-ui.html +0 -0
- /package/lib/{core → tasks/core}/preflight/mock-ui.png +0 -0
- /package/lib/{core → tasks/core}/preflight/owner.js +0 -0
- /package/lib/{core → tasks/core}/preflight/render-image/Dockerfile +0 -0
- /package/lib/{core → tasks/core}/preflight/render-image/fonts-ja.conf +0 -0
- /package/lib/{core → tasks/core}/preflight/render-image/render.mjs +0 -0
- /package/lib/{core → tasks/core}/preflight/split.js +0 -0
- /package/lib/{core → tasks/core}/preflight/uiMaterials.js +0 -0
- /package/lib/{core → tasks/core}/preflight/wireframe.js +0 -0
- /package/lib/{core → tasks/core}/preflight/xlsx.js +0 -0
- /package/lib/{core → tasks/core}/redact.js +0 -0
- /package/lib/{core → tasks/core}/repoRefs.js +0 -0
- /package/lib/{core → tasks/core}/requestStatus.js +0 -0
- /package/lib/{core → tasks/core}/store/archivedTasks.js +0 -0
- /package/lib/{core → tasks/core}/store/dataWatcher.js +0 -0
- /package/lib/{core → tasks/core}/store/locate.js +0 -0
- /package/lib/{core → tasks/core}/supersede.js +0 -0
- /package/lib/{core/milestoneReview → tasks/features/milestoneReview/core}/mockReviewer.js +0 -0
- /package/lib/{shared → tasks/features/milestoneReview/shared}/milestoneReview.js +0 -0
- /package/lib/{core → tasks/features/quality/core}/quality.js +0 -0
- /package/lib/{shared → tasks/features/quality/shared}/quality.js +0 -0
- /package/lib/{shared → tasks/features/quality/shared}/qualityImprovement.js +0 -0
- /package/lib/{shared → tasks/features/quality/shared}/qualityTemplates.js +0 -0
- /package/lib/{core/releaseNotes → tasks/features/releaseNotes/core}/mockSummarizer.js +0 -0
- /package/lib/{core/taskReview → tasks/features/taskReview/core}/mockReviewer.js +0 -0
- /package/lib/{core/taskReview → tasks/features/taskReview/core}/paths.js +0 -0
- /package/lib/{shared → tasks/features/taskReview/shared}/taskReview.js +0 -0
- /package/lib/{server → tasks/server}/api/chatgptRoutes.js +0 -0
- /package/lib/{server → tasks/server}/api/local.js +0 -0
- /package/lib/{shared → tasks/shared}/dates.js +0 -0
- /package/lib/{shared → tasks/shared}/directTask.js +0 -0
- /package/lib/{shared → tasks/shared}/hierarchy.js +0 -0
- /package/lib/{shared → tasks/shared}/milestoneGoals.js +0 -0
- /package/lib/{shared → tasks/shared}/milestoneOrder.js +0 -0
- /package/lib/{shared → tasks/shared}/preflightRunner.js +0 -0
- /package/lib/{shared → tasks/shared}/refs.js +0 -0
- /package/lib/{shared → tasks/shared}/repos.js +0 -0
- /package/lib/{shared → tasks/shared}/scopeView.js +0 -0
- /package/lib/{shared → tasks/shared}/tags.js +0 -0
- /package/lib/{shared → tasks/shared}/taskBlock.js +0 -0
- /package/lib/{shared → tasks/shared}/types.js +0 -0
- /package/lib/{shared → tasks/shared}/workTarget.js +0 -0
|
@@ -1,14 +1,12 @@
|
|
|
1
|
-
import { normalizeTaskId } from "
|
|
2
|
-
import {
|
|
3
|
-
import {
|
|
4
|
-
import { currentOwner } from "../preflight/owner.js";
|
|
5
|
-
import { RunControl, startedNow } from "../reviewRuns.js";
|
|
1
|
+
import { normalizeTaskId } from "../../../shared/refs.js";
|
|
2
|
+
import { currentOwner } from "../../../core/preflight/owner.js";
|
|
3
|
+
import { classifyAiFailure, pickReviewer, ReviewRunner, startedNow } from "../../../core/reviewRuns.js";
|
|
6
4
|
import { extractTaskReview, TaskReviewRejected } from "./material.js";
|
|
7
5
|
import { InvalidTaskReview, MATERIAL_MOUNT, parseTaskReview, TASK_REVIEW_INPUT_LIMIT, taskReviewPrompt } from "./review.js";
|
|
8
6
|
import { newTaskReviewRunId, parseTaskReviewKey } from "./store.js";
|
|
9
7
|
/**
|
|
10
8
|
* タスクの AI レビューを実行して記録する(CLI・API はここを呼ぶ)。材料は material.ts、依頼文と結果の確かめ方は review.ts、
|
|
11
|
-
* 保存は store.ts
|
|
9
|
+
* 保存は store.ts、実行の骨組み(二重の開始・時間切れ・取消・回復・遅れた結果の拒否)は reviewRuns.ts の ReviewRunner(マイルストーンレビューと共通)。
|
|
12
10
|
*
|
|
13
11
|
* - 頼む先は Preflight と同じ Codex の接続(ask。認証・パスの対応・診断・時間と使用量の上限・取消を共有する)。毎回新しいスレッドで、
|
|
14
12
|
* 固定した材料のフォルダだけを読むだけでマウントする。Mock は明示したときだけ(失敗しても Mock に切り替えない)
|
|
@@ -23,13 +21,12 @@ export class TaskReviewService {
|
|
|
23
21
|
ws;
|
|
24
22
|
reviewers;
|
|
25
23
|
opts;
|
|
26
|
-
|
|
27
|
-
control;
|
|
24
|
+
runner;
|
|
28
25
|
constructor(ws, reviewers, opts = {}) {
|
|
29
26
|
this.ws = ws;
|
|
30
27
|
this.reviewers = reviewers;
|
|
31
28
|
this.opts = opts;
|
|
32
|
-
this.
|
|
29
|
+
this.runner = new ReviewRunner(ws.taskReviews, { timeoutMs: opts.timeoutMs ?? TASK_REVIEW_TIMEOUT_MS, probe: opts.probe, pollMs: opts.pollMs, emit: (r) => this.emit(r) });
|
|
33
30
|
}
|
|
34
31
|
get store() {
|
|
35
32
|
return this.ws.taskReviews;
|
|
@@ -67,8 +64,7 @@ export class TaskReviewService {
|
|
|
67
64
|
const { instructions, prompt, size } = taskReviewPrompt(input);
|
|
68
65
|
if (size > TASK_REVIEW_INPUT_LIMIT)
|
|
69
66
|
throw new TaskReviewRejected("too_large", `材料が上限を超えています(${size} 文字 / 上限 ${TASK_REVIEW_INPUT_LIMIT} 文字)。切り詰めずに断ります。比較対象を絞ってください`);
|
|
70
|
-
const name = opts.engine
|
|
71
|
-
const reviewer = this.reviewers[name];
|
|
67
|
+
const { name, reviewer } = await pickReviewer(this.reviewers, opts.engine, this.opts.engine);
|
|
72
68
|
if (!reviewer)
|
|
73
69
|
throw new TaskReviewRejected("unavailable", `レビューを頼む先(${name})がありません`);
|
|
74
70
|
const run = {
|
|
@@ -83,65 +79,27 @@ export class TaskReviewService {
|
|
|
83
79
|
inputHash: input.hash,
|
|
84
80
|
log: [],
|
|
85
81
|
};
|
|
86
|
-
await this.
|
|
87
|
-
const
|
|
88
|
-
|
|
89
|
-
|
|
90
|
-
|
|
91
|
-
: "。終わるのを待つか取り消してください";
|
|
92
|
-
throw new TaskReviewRejected("running", `${key} のレビューは実行中です(${busy.run.id})${hint}`, busy.run.id);
|
|
93
|
-
}
|
|
94
|
-
await this.store.create(input, files, run);
|
|
82
|
+
await this.runner.begin(key, () => this.store.create(input, files, run), (busy) => {
|
|
83
|
+
const hint = busy.owner.state === "unknown"
|
|
84
|
+
? `。実行しているプロセスを確かめられません(${busy.owner.reason})。止まっていると確かめたら p3 review-cancel ${key} ${busy.run.id} --acknowledge-stopped で中断できます`
|
|
85
|
+
: "。終わるのを待つか取り消してください";
|
|
86
|
+
return new TaskReviewRejected("running", `${key} のレビューは実行中です(${busy.run.id})${hint}`, busy.run.id);
|
|
95
87
|
});
|
|
96
|
-
const abort = new AbortController();
|
|
97
|
-
const job = { key, abort, done: Promise.resolve() };
|
|
98
|
-
this.local.set(run.id, job);
|
|
99
|
-
this.emit(run);
|
|
100
88
|
const material = { name: MATERIAL_MOUNT, mount: MATERIAL_MOUNT, role: "固定したレビューの材料", readFirst: true, writable: false, map: [], status: "ok", local: this.store.materialDir(key, run.id) };
|
|
101
|
-
|
|
102
|
-
return run;
|
|
103
|
-
}
|
|
104
|
-
async execute(key, run, input, ask, reviewer, abort) {
|
|
105
|
-
const log = [];
|
|
106
|
-
const push = (e) => log.push({ at: new Date().toISOString(), ...e });
|
|
107
|
-
const timeoutMs = this.opts.timeoutMs ?? TASK_REVIEW_TIMEOUT_MS;
|
|
108
|
-
const timeout = AbortSignal.timeout(timeoutMs);
|
|
109
|
-
const signal = AbortSignal.any([abort.signal, timeout]);
|
|
110
|
-
const stopWatch = this.control.watch(key, run.id, log, abort, this.opts.pollMs ?? 1000);
|
|
111
|
-
let end;
|
|
112
|
-
let result;
|
|
113
|
-
try {
|
|
89
|
+
this.runner.launch(key, run, async (push, signal) => {
|
|
114
90
|
push({
|
|
115
91
|
kind: "info",
|
|
116
|
-
text: `材料: 比較項目 ${input.items.length} 件・比較対象 ${input.targets.map((
|
|
92
|
+
text: `材料: 比較項目 ${input.items.length} 件・比較対象 ${input.targets.map((x) => `${x.repo} ${x.kind === "range" ? `${x.range.base.slice(0, 7)}..${x.range.head.slice(0, 7)}` : x.commits.map((c) => c.sha.slice(0, 7)).join(",")}`).join(" / ")}・ファイル ${input.files.length} 件`,
|
|
117
93
|
});
|
|
118
|
-
const r = await reviewer.ask({ instructions
|
|
94
|
+
const r = await reviewer.ask({ instructions, prompt, refs: [material], label: "タスクのレビュー" }, push, signal);
|
|
119
95
|
if (signal.aborted)
|
|
120
96
|
throw signal.reason;
|
|
121
|
-
result
|
|
122
|
-
|
|
123
|
-
|
|
124
|
-
catch (e) {
|
|
125
|
-
if (abort.signal.aborted)
|
|
126
|
-
end = { status: "cancelled", error: "取り消しました" };
|
|
127
|
-
else if (timeout.aborted)
|
|
128
|
-
end = { status: "failed", failure: "timeout", error: `時間切れです(${Math.round(timeoutMs / 1000)} 秒)` };
|
|
129
|
-
else {
|
|
130
|
-
const [failure, error] = classify(e);
|
|
131
|
-
end = { status: "failed", failure, error };
|
|
132
|
-
}
|
|
133
|
-
push({ kind: "error", text: end.error });
|
|
134
|
-
}
|
|
135
|
-
finally {
|
|
136
|
-
stopWatch();
|
|
137
|
-
}
|
|
138
|
-
// 既に終わっていた(人が中断した・回復した)なら、遅れて届いた結果は取り込まない
|
|
139
|
-
await this.control.end(key, run.id, { ...end, log: [...log] }, result);
|
|
97
|
+
return { result: parseTaskReview(r.message, input, r.model), end: r.model ? { model: r.model } : {} };
|
|
98
|
+
}, (e) => classifyAiFailure(e, (x) => x instanceof InvalidTaskReview));
|
|
99
|
+
return run;
|
|
140
100
|
}
|
|
141
101
|
async recover(key) {
|
|
142
|
-
|
|
143
|
-
return;
|
|
144
|
-
await this.store.withLock(key, () => this.control.recoverLocked(key));
|
|
102
|
+
await this.runner.recover(key);
|
|
145
103
|
}
|
|
146
104
|
async list(rid, tid) {
|
|
147
105
|
const key = this.key(rid, tid);
|
|
@@ -149,39 +107,20 @@ export class TaskReviewService {
|
|
|
149
107
|
return this.store.list(key);
|
|
150
108
|
}
|
|
151
109
|
async get(rid, tid, run) {
|
|
152
|
-
|
|
153
|
-
await this.recover(key);
|
|
154
|
-
const rec = await this.store.get(key, run);
|
|
155
|
-
return { ...rec, ...(rec.run.status === "running" ? { owner: this.control.ownerOf(rec.run) } : {}) };
|
|
110
|
+
return this.runner.get(this.key(rid, tid), run);
|
|
156
111
|
}
|
|
157
112
|
async cancel(rid, tid, run, by, opts = {}) {
|
|
158
|
-
|
|
159
|
-
const local = this.local.get(run);
|
|
160
|
-
return this.control.cancel(key, run, by, { ...opts, label: `${key}/${run}`, abortLocal: () => local?.abort.abort(new Error("cancelled")) });
|
|
113
|
+
return this.runner.cancel(this.key(rid, tid), run, by, opts);
|
|
161
114
|
}
|
|
162
115
|
/** 終わるまで待つ(このプロセスの run だけ) */
|
|
163
116
|
async wait(rid, tid, run) {
|
|
164
|
-
await this.
|
|
117
|
+
await this.runner.waitLocal(run);
|
|
165
118
|
return this.get(rid, tid, run);
|
|
166
119
|
}
|
|
167
120
|
running() {
|
|
168
|
-
return this.
|
|
121
|
+
return this.runner.running();
|
|
169
122
|
}
|
|
170
123
|
async settle(opts = {}) {
|
|
171
|
-
|
|
172
|
-
if (opts.cancel)
|
|
173
|
-
for (const j of jobs)
|
|
174
|
-
j.abort.abort(new Error("cancelled"));
|
|
175
|
-
await Promise.allSettled(jobs.map((j) => j.done));
|
|
124
|
+
await this.runner.settle(opts);
|
|
176
125
|
}
|
|
177
126
|
}
|
|
178
|
-
function classify(e) {
|
|
179
|
-
const msg = e?.message ?? String(e);
|
|
180
|
-
if (e instanceof CodexUnavailableError || e instanceof ChatGptAuthError)
|
|
181
|
-
return ["unavailable", msg];
|
|
182
|
-
if (e instanceof CodexUsageLimitError)
|
|
183
|
-
return ["usage_limit", msg];
|
|
184
|
-
if (e instanceof InvalidTaskReview)
|
|
185
|
-
return ["invalid_output", msg];
|
|
186
|
-
return ["error", msg];
|
|
187
|
-
}
|
|
@@ -1,10 +1,10 @@
|
|
|
1
1
|
import { randomBytes } from "node:crypto";
|
|
2
2
|
import { lstat, mkdir, readdir, rm, writeFile } from "node:fs/promises";
|
|
3
3
|
import { dirname, join, resolve, sep } from "node:path";
|
|
4
|
-
import { REQUEST_ID, TASK_ID } from "
|
|
5
|
-
import { TASK_REVIEW_STATUSES, } from "
|
|
6
|
-
import { dirs, finishRunFile, readJson, ReviewStoreError, runStamp, updateRunFile, writeJson } from "
|
|
7
|
-
import { withFileLock } from "
|
|
4
|
+
import { REQUEST_ID, TASK_ID } from "../../../shared/refs.js";
|
|
5
|
+
import { TASK_REVIEW_STATUSES, } from "../shared/taskReview.js";
|
|
6
|
+
import { dirs, finishRunFile, readJson, ReviewStoreError, runStamp, updateRunFile, writeJson } from "../../../core/reviewRuns.js";
|
|
7
|
+
import { withFileLock } from "../../../../kit/fsutil.js";
|
|
8
8
|
import { safeRelPath } from "./paths.js";
|
|
9
9
|
/**
|
|
10
10
|
* タスクの AI レビューの履歴(要望のフォルダの中。要望をアーカイブすれば一緒に動き、タスクをアーカイブしても残る)。
|
|
@@ -1,9 +1,8 @@
|
|
|
1
|
+
import { apiError } from "../../../core/errorOutcome.js";
|
|
1
2
|
import { Hono } from "hono";
|
|
2
3
|
import { z } from "zod";
|
|
3
|
-
import {
|
|
4
|
-
import {
|
|
5
|
-
import { TaskReviewRejected } from "../../core/taskReview/material.js";
|
|
6
|
-
import { previewOf } from "../../shared/taskReview.js";
|
|
4
|
+
import { NotFoundError } from "../../../core/store/collection.js";
|
|
5
|
+
import { previewOf } from "../shared/taskReview.js";
|
|
7
6
|
/**
|
|
8
7
|
* タスクの AI レビュー(画面のため)。規則と保存は core/taskReview(CLI の p3 review と同じサービス)。
|
|
9
8
|
*
|
|
@@ -27,21 +26,15 @@ const startBody = z.object({
|
|
|
27
26
|
export function taskReviewRoutes(ctx) {
|
|
28
27
|
const app = new Hono();
|
|
29
28
|
const svc = () => ctx.taskReview;
|
|
29
|
+
// エラーの状態と code は core/errorOutcome.ts の表。この API では見つからないにも code を付ける
|
|
30
30
|
app.onError((err, c) => {
|
|
31
31
|
if (err instanceof NotFoundError)
|
|
32
32
|
return c.json({ error: err.message, code: "not_found" }, 404);
|
|
33
|
-
if (err instanceof ReviewStoreError) {
|
|
34
|
-
const status = err.code === "not_found" ? 404 : err.code === "bad_id" ? 400 : err.code === "broken" ? 422 : 409;
|
|
35
|
-
return c.json({ error: err.message, code: err.code }, status);
|
|
36
|
-
}
|
|
37
|
-
if (err instanceof TaskReviewRejected) {
|
|
38
|
-
const status = err.code === "running" || err.code === "material_changed" ? 409 : 400;
|
|
39
|
-
return c.json({ error: err.message, code: err.code, ...(err.running ? { run: err.running } : {}) }, status);
|
|
40
|
-
}
|
|
41
|
-
if (err instanceof ReviewCancelRefused)
|
|
42
|
-
return c.json({ error: err.message, code: err.code }, 409);
|
|
43
33
|
if (err instanceof z.ZodError)
|
|
44
34
|
return c.json({ error: "invalid input", issues: err.issues }, 400);
|
|
35
|
+
const r = apiError(err);
|
|
36
|
+
if (r)
|
|
37
|
+
return c.json(r.body, r.status);
|
|
45
38
|
console.error(err);
|
|
46
39
|
return c.json({ error: err.message }, 400);
|
|
47
40
|
});
|
|
@@ -67,12 +67,54 @@ export const AI_MANIFEST = {
|
|
|
67
67
|
desc: "参照先(共有の定義)。GET は読めたかの状態と、ローカルの画面にだけこのマシンのパス。POST {name, role?, readFirst?, writable?, map?, path?}",
|
|
68
68
|
},
|
|
69
69
|
{ method: "PUT|DELETE", path: "/api/repos/:name/path", desc: "参照先のこのマシンのパス(個人設定)。このマシンのローカルの画面(Origin)からだけ" },
|
|
70
|
-
{ method: "GET", path: "/api/requests[?parent=<要望ID>]", desc: "要望の一覧と進捗(更新の新しい順。parent で直下の子だけを親の表示順に)。止まっている自分のタスクの数 blocked と配下の数 subtree.blocked(作業中にも数える)、タスクの印に停止の今の値 block" },
|
|
70
|
+
{ method: "GET", path: "/api/requests[?parent=<要望ID>]", desc: "要望の一覧と進捗(更新の新しい順。parent で直下の子だけを親の表示順に)。止まっている自分のタスクの数 blocked と配下の数 subtree.blocked(作業中にも数える)、タスクの印に停止の今の値 block と証拠の概要 evidence({met, total, declarationOnly, metByBasis, problems}。本文は載せない。基準も証拠も無ければ省く)・完了したタスクの見直しの状態 review、要望ごとの見直し候補の数 review: {self?, tasks, below}(below は自分を除く配下)" },
|
|
71
71
|
{ method: "POST", path: "/api/requests", desc: "要望の作成(parent で子の要望にする。省いた期限・マイルストーン・タグは親から写す)" },
|
|
72
72
|
{
|
|
73
73
|
method: "GET",
|
|
74
74
|
path: "/api/requests/:rid",
|
|
75
|
-
desc: "要望・タスク・Preflight・置き換えられたタスクの印(superseded)・対応済なのに未完了のタスクがあるときの知らせ(issue)・親子(parent・ancestors・children・hierarchyIssues)・対応済にできるか(completion: blocker・見送りで対象外の子 excluded
|
|
75
|
+
desc: "要望・タスク・Preflight・置き換えられたタスクの印(superseded)・対応済なのに未完了のタスクがあるときの知らせ(issue)・親子(parent・ancestors・children・hierarchyIssues)・対応済にできるか(completion: blocker・見送りで対象外の子 excluded)・" +
|
|
76
|
+
"要求の出典と確認(requirement: {state, sources, answers, problems}。state は unrecorded / unconfirmed / confirmed / reconfirm / unlinked。申告の記録で P3 の保証ではない)・" +
|
|
77
|
+
"見直しが必要(候補)(review: {self?(対応済・完了済のときの要望自身の診断), tasks(タスクごとの概要), counts: {tasks, below}})",
|
|
78
|
+
},
|
|
79
|
+
{
|
|
80
|
+
method: "GET|POST",
|
|
81
|
+
path: "/api/requests/:rid/premises",
|
|
82
|
+
desc: "前提の変更(外部の規則の変更など。要望の premiseChanges に追記)。POST {op: \"add\", targets: [要望 ID|タスク ID|要望の根拠の ID], reason, condition, rev?} / {op: \"ack\", id, target, condition, rev?}(変更を確かめたことを残す)。" +
|
|
83
|
+
"基点の完了の記録より後の変更で、確認の無い対象は見直し候補の理由になる。過去の完了の記録・状態・済みは変えない。対象が無い・規則に合わなければ 400 premise_invalid、rev が違えば 409(何も書かない)",
|
|
84
|
+
},
|
|
85
|
+
{
|
|
86
|
+
method: "GET|POST",
|
|
87
|
+
path: "/api/requests/:rid/retrospective[/target]",
|
|
88
|
+
desc: "要望の振り返り。GET は {version, target?(今の対象), targets(確定と訂正の履歴), candidates(採用を終えた run: {run, kind: tasks|split|legacy, latest, basis: [{key?, target, state}], risks}), none?}。" +
|
|
89
|
+
"POST /target {run, reason?, version?} で対象を確定する(候補の run だけ。評価の版とリスクの原文を写す。2回目からの訂正は reason が要る)。候補でない・理由が無い → 400 retro_invalid、版が違う → 409 retro_conflict(何も書かない)。" +
|
|
90
|
+
"GET は今の対象のリスクと確認 risks: [{index, text, state, judgment?, history}]・三状態の件数 counts・全部の確認 judgments・根拠の今の照合 checks(ok|changed|missing|manual)も返す。" +
|
|
91
|
+
"POST /judgments {risk(0 から), state: occurred|not_occurred|unchecked, facts?, scope?, reason?, evidence: [{kind: task_review, task, run, section, index?} | {kind: milestone_review, milestone, run, section, index?, reason?} | {kind: rework, task, history} | {kind: manual, reference, note?}], version?} でリスクの確認を追記する(人の判断。起きた → facts と根拠、起きなかった → scope と根拠、判断を変える → reason。範囲外の根拠は 400)",
|
|
92
|
+
},
|
|
93
|
+
{
|
|
94
|
+
method: "GET",
|
|
95
|
+
path: "/api/metrics[?milestone=<ID>]",
|
|
96
|
+
desc: "開発の指標(p3 metrics と同じ)。範囲は省けばプロジェクト全体(マイルストーンなしを含む)、milestone は登録済みのマイルストーンに直接属する要望(見送り・アーカイブは除く。登録に無い ID は 400 metrics_invalid)。" +
|
|
97
|
+
"{scope, scopeLabel, scopeRule, metrics: [{id, label, kind: record|manual, unit: hours|count|amount, source, target, method, missingRule, recordHint?, state: ok|no_targets|no_data|not_reached|unrecorded, value(ok 以外は null。manual は1行のときだけ), targets, observed, missing, denominator?, breakdown, missingItems, rows?(manual: 範囲が一致する人の記録 {id, from, to, value, unit, source, note?, rev, ...}。合算しない)}], notices(broken_request|manual_unreadable|manual_orphan), scopes}。" +
|
|
98
|
+
"記録の欠けは 0 にせず missing に数える。読むだけ(レビューは実行しない。人の記録を書くのは CLI の p3 metrics record だけ)",
|
|
99
|
+
},
|
|
100
|
+
{
|
|
101
|
+
method: "GET",
|
|
102
|
+
path: "/api/revisit[?request=<要望ID>]",
|
|
103
|
+
desc: "見直しが必要(候補)の一覧(完了したタスクと対応済・完了済の要望。完了済みも含む)。各項目は {target, state, record, qualityVersion, reasons: [{code, target, was?, now?, related?}], unreadable?}。" +
|
|
104
|
+
"品質は作業先に当てはまる項目の差だけを見て、設定全体の版の違い・参照先の HEAD の更新では候補にしない。読むだけでファイルを書かない。タスクの一覧は ?review=true で候補だけに絞れる",
|
|
105
|
+
},
|
|
106
|
+
{
|
|
107
|
+
method: "POST",
|
|
108
|
+
path: "/api/requests/:rid/sources",
|
|
109
|
+
desc: "要求の根拠の記録を変える {ops: [{op:\"add\", target?, source?, basis?, confirm?:{by, on}} | {op:\"edit\", id, target?, source?, basis?, confirm?} | {op:\"confirm\", id, by, on} | {op:\"remove\", id}], rev?}(CLI の p3 source と同じ。結果は {request, requirement})。" +
|
|
110
|
+
"確認には出典・根拠・確かめた人(役割名・アクター名)・YYYY-MM-DD の日が要る。題・本文・記録の内容が変わると確認は再確認が必要になる(元に戻しても戻らない)。" +
|
|
111
|
+
"規則に合わなければ 400 code: requirement_invalid、rev が違えば 409 rev_conflict(どちらも何も書かない)。要望の根拠・回答は評価対象に入る(変えるとその評価からは採用しない)",
|
|
112
|
+
},
|
|
113
|
+
{
|
|
114
|
+
method: "POST",
|
|
115
|
+
path: "/api/requests/:rid/answers",
|
|
116
|
+
desc: "Preflight の確認事項(run の assessment.clarifications)に回答する {run, question, answer(null で消す), by?, on?, source?, basis?, links?: [根拠の記録の ID], rev?}(CLI の p3 answer と同じ)。" +
|
|
117
|
+
"回答は要望の clarifyAnswers に残し、過去の run は書き換えない。回答しただけでは根拠の記録を確認記録ありにしない。再評価は別に明示して始める",
|
|
76
118
|
},
|
|
77
119
|
{
|
|
78
120
|
method: "PATCH",
|
|
@@ -90,8 +132,13 @@ export const AI_MANIFEST = {
|
|
|
90
132
|
},
|
|
91
133
|
{ method: "GET|POST", path: "/api/requests/:rid/tasks", desc: "要望のタスク(GET の ?blocked=true で止まっているものだけ(status・area・q と AND)。POST の criteria: [文] で受け入れ基準を付ける(ID は p3 が振る)。対応済の要望に未完了のタスクを足すと進行中に戻し reopened を返す。対応済の祖先も戻して reopenedAncestors、完了済の祖先は warnings の ancestor_done)" },
|
|
92
134
|
{ method: "GET|PATCH|DELETE", path: "/api/requests/:rid/tasks/:tid", desc: "タスク(GET は置き換えの印 superseded と受け入れ基準の状態 acceptance(不足 shortfalls。基準なしは null)も返す。PATCH は rev で楽観ロック、null で項目を消す。置き換えられたタスクを作業中にすると warnings を添える。" +
|
|
93
|
-
"受け入れ基準・証拠は PATCH の acceptance: [{op: add|edit|remove|order|record|unrecord, ...}]
|
|
135
|
+
"受け入れ基準・証拠は PATCH の acceptance: [{op: add|edit|remove|order|record|unrecord|source, ...}] で順に当て(source は {op:\"source\", id: 基準の ID, source: 要求の根拠への操作}。POST sources と同じ操作で、from で要望の記録を写す)、規則に合わなければ何も書かず 400 code: acceptance_invalid。" +
|
|
136
|
+
"record の basis は根拠 {kind: unverified|declaration} / {kind: read, reference} / {kind: machine, command, result, target}(作業した側の申告。P3 は検査を実行しない)。" +
|
|
137
|
+
"省くと同じ結果の前の証拠の根拠を引き継ぎ、無ければ unverified は未確認・ほかは申告のみ。met / unmet に未確認、unverified にほかの根拠は付けられない。" +
|
|
138
|
+
"acceptance には根拠ごとの met の件数 metByBasis と申告のみの基準 declarationOnly も入る。" +
|
|
94
139
|
"済みのタスクの基準・証拠の中身が変わると済みを外し checkCleared を返す。" +
|
|
140
|
+
"完了・済みにすると、そのときの条件の写しを completionRecords に追記する(要望の PATCH の対応済・完了済も同じ。記録の値は受け付けない。記録が読めず足せなければ completionSkipped)。" +
|
|
141
|
+
"GET は見直しの診断 review(完了したタスクだけ。state: no_record|unreadable|none|candidate、基点の record、reasons: [{code, target, was?, now?, related?}]。状態は変えない)も返す。" +
|
|
95
142
|
"止まっている理由(停止)は PATCH の blockOp: {op: set, reason, decision?}(作業中だけ。内容を直しても since は変えない)/ {op: clear, resolution}(解除。状態は変えない)で変え、" +
|
|
96
143
|
"日時・履歴は受け付けない。規則に合わなければ 400 block_invalid / block_not_doing、止まったまま未着手・完了へ動かすと 409 blocked(解除と移動を同じ PATCH に書けば一緒に保存する))" },
|
|
97
144
|
{
|
|
@@ -141,6 +188,7 @@ export const AI_MANIFEST = {
|
|
|
141
188
|
path: "/api/requests/:rid/preflight/:run/drafts/:key",
|
|
142
189
|
desc: "タスク案を直す {title?, description?, include?, repo?, acceptanceCriteria?, expectedTitle?, expectedCriteria?}。" +
|
|
143
190
|
"acceptanceCriteria は受け入れ基準の並び全体 [{id?, text}](id は残し、無い項目に振る。空で基準なし)で、expectedCriteria(編集を始めたときの基準)が要る。違えば 409 rev_conflict。" +
|
|
191
|
+
"sourceOps: 基準ごとの要求の根拠への操作 [{id: 基準の ID, source: 上の sources と同じ操作(add は from: 要望の記録の ID で写せる)}]。expectedSources(編集を始めたときの acceptanceSources)が要り、違えば 409 rev_conflict。" +
|
|
144
192
|
"expectedTitle(編集を始めたときの題。制御用で案には書かない)を渡すと、" +
|
|
145
193
|
"案のファイルを読み直した今の題と比べ、違えば 409 code: rev_conflict(current に今の案)で書かない。画面から題を変えるときは必ず渡す",
|
|
146
194
|
},
|