@infodb/p3 0.12.0 → 0.14.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +33 -35
- package/bin/p3.mjs +3 -2
- package/dist/web/assets/CompletionReview-BD7d6Yzt.js +1 -0
- package/dist/web/assets/ImprovementDialog-BoAZN1KR.js +1 -0
- package/dist/web/assets/Outputs-D-ZouoxF.js +1 -0
- package/dist/web/assets/RequestStatus-Bl3fdSbM.js +1 -0
- package/dist/web/assets/Tabs-CxeceOL-.js +1 -0
- package/dist/web/assets/TagInput-CeAbmGRR.js +1 -0
- package/dist/web/assets/TaskDrawer-BCriSnhe.js +6 -0
- package/dist/web/assets/_requestId-CZKMe_mC.js +1 -0
- package/dist/web/assets/_requestId-Fx4lLkFo.js +1 -0
- package/dist/web/assets/appCtx-BdxbkSZa.js +1 -0
- package/dist/web/assets/archive-D5IIxcSV.js +1 -0
- package/dist/web/assets/board-p6R9KMqd.js +1 -0
- package/dist/web/assets/done-BTOF188x.js +1 -0
- package/dist/web/assets/draft-BWYpm3PD.js +2 -0
- package/dist/web/assets/index-DFbY8NAR.css +2 -0
- package/dist/web/assets/index-Dpqi2dcC.js +12 -0
- package/dist/web/assets/link-D481whDt.js +1 -0
- package/dist/web/assets/metrics-CAzP6V8I.js +1 -0
- package/dist/web/assets/new-C65IJJg3.js +1 -0
- package/dist/web/assets/outputs-CXqnjSqV.js +1 -0
- package/dist/web/assets/preflightInput-ClKwkp8R.js +2 -0
- package/dist/web/assets/preload-helper-_dAYMct_.js +1 -0
- package/dist/web/assets/{quality-Pu6EISAM.js → quality-RFd-7k3r.js} +1 -1
- package/dist/web/assets/release-notes-Dtif8xsQ.js +5 -0
- package/dist/web/assets/requestData-SPc36t8Q.js +1 -0
- package/dist/web/assets/routes-DJj8CWuk.js +6 -0
- package/dist/web/assets/settings-DKJd7CLe.js +1 -0
- package/dist/web/assets/ui-CbEOnPnF.js +1 -0
- package/dist/web/assets/workTarget-DavxMs-c.js +30 -0
- package/dist/web/index.html +6 -4
- package/docs/architecture.md +430 -72
- package/docs/chatgpt-sign-in.md +2 -2
- package/docs/development.md +141 -64
- package/docs/feature-inventory.md +139 -0
- package/docs/how-to-use.md +389 -31
- package/docs/installation.md +261 -147
- package/docs/publishing.md +33 -14
- package/docs/refactoring.md +332 -0
- package/lib/cli/agentsStatus.js +198 -0
- package/lib/cli/guide.js +27 -0
- package/lib/cli/guide.md +217 -0
- package/lib/cli/help.js +45 -7
- package/lib/cli/main.js +58 -207
- package/lib/cli/project.js +34 -294
- package/lib/core/projectRegistry.js +2 -2
- package/lib/kit/appInfo.js +13 -0
- package/lib/kit/usage.js +27 -0
- package/lib/server/api/projectsRoutes.js +5 -5
- package/lib/server/server.js +7 -4
- package/lib/{cli → tasks/cli}/args.js +73 -9
- package/lib/{cli → tasks/cli}/chatgpt.js +1 -1
- package/lib/{cli → tasks/cli}/codex.js +1 -1
- package/lib/{cli → tasks/cli}/output.js +12 -2
- package/lib/{cli → tasks/cli}/preflightCommands.js +1 -1
- package/lib/tasks/cli/readOnly.js +75 -0
- package/lib/{cli → tasks/cli}/render.js +1 -1
- package/lib/{cli → tasks/cli}/requestCommands.js +24 -7
- package/lib/tasks/cli/showView.js +279 -0
- package/lib/{cli → tasks/cli}/taskCommands.js +55 -21
- package/lib/tasks/cli/tasksCli.js +149 -0
- package/lib/{core → tasks/core}/context.js +6 -9
- package/lib/tasks/core/errorOutcome.js +125 -0
- package/lib/{core → tasks/core}/hierarchy.js +1 -1
- package/lib/{core → tasks/core}/ops.js +17 -2
- package/lib/{core → tasks/core}/preflight/carryover.js +5 -1
- package/lib/{core → tasks/core}/preflight/codexEngine.js +36 -28
- package/lib/{core → tasks/core}/preflight/diagnose.js +4 -9
- package/lib/{core → tasks/core}/preflight/engine.js +9 -0
- package/lib/tasks/core/preflight/hostPaths.js +299 -0
- package/lib/{core → tasks/core}/preflight/input.js +33 -5
- package/lib/{core → tasks/core}/preflight/instructions.js +19 -2
- package/lib/{core → tasks/core}/preflight/mockEngine.js +27 -8
- package/lib/{core → tasks/core}/preflight/render.js +22 -3
- package/lib/{core → tasks/core}/preflight/service.js +86 -11
- package/lib/{core → tasks/core}/preflight/uiRender.js +5 -2
- package/lib/{core → tasks/core}/requestOps.js +214 -17
- package/lib/{core → tasks/core}/reviewRuns.js +127 -22
- package/lib/{core → tasks/core}/store/attachments.js +3 -2
- package/lib/{core → tasks/core}/store/collection.js +21 -2
- package/lib/tasks/core/store/fieldGroups.js +30 -0
- package/lib/tasks/core/store/jsonRecord.js +30 -0
- package/lib/{core → tasks/core}/store/normalize.js +15 -10
- package/lib/{core → tasks/core}/store/noteStore.js +2 -2
- package/lib/{core → tasks/core}/store/preflightStore.js +59 -22
- package/lib/{core → tasks/core}/store/projectFile.js +1 -1
- package/lib/{core → tasks/core}/store/workspace.js +28 -6
- package/lib/{core → tasks/core}/userConfig.js +1 -1
- package/lib/{core → tasks/core}/workTargets.js +1 -1
- package/lib/tasks/features/metrics/cli/metricsCommands.js +77 -0
- package/lib/tasks/features/metrics/core/definitions.js +445 -0
- package/lib/tasks/features/metrics/core/index.js +112 -0
- package/lib/tasks/features/metrics/core/manual.js +179 -0
- package/lib/tasks/features/metrics/server/metricsRoutes.js +8 -0
- package/lib/tasks/features/metrics/shared/metrics.js +42 -0
- package/lib/{core/milestoneReview → tasks/features/milestoneReview/core}/code.js +2 -11
- package/lib/{core/milestoneReview → tasks/features/milestoneReview/core}/material.js +5 -6
- package/lib/{core/milestoneReview → tasks/features/milestoneReview/core}/review.js +2 -2
- package/lib/{core/milestoneReview → tasks/features/milestoneReview/core}/service.js +38 -100
- package/lib/{core/milestoneReview → tasks/features/milestoneReview/core}/store.js +3 -3
- package/lib/{server/api → tasks/features/milestoneReview/server}/milestoneReviewRoutes.js +7 -13
- package/lib/{cli → tasks/features/quality/cli}/qualityCommands.js +36 -11
- package/lib/{core → tasks/features/quality/core}/qualityImprovement.js +16 -15
- package/lib/tasks/features/records/cli/revisitCommands.js +73 -0
- package/lib/tasks/features/records/core/completionRefs.js +46 -0
- package/lib/tasks/features/records/core/reviewCandidates.js +76 -0
- package/lib/tasks/features/records/shared/completionRecord.js +329 -0
- package/lib/tasks/features/records/shared/reviewCandidate.js +313 -0
- package/lib/tasks/features/records/shared/reworkHistory.js +86 -0
- package/lib/{cli → tasks/features/releaseNotes/cli}/releaseNotesCommands.js +7 -7
- package/lib/{core/releaseNotes → tasks/features/releaseNotes/core}/completeRequests.js +5 -6
- package/lib/{core/releaseNotes → tasks/features/releaseNotes/core}/generate.js +3 -14
- package/lib/{core/releaseNotes → tasks/features/releaseNotes/core}/material.js +3 -4
- package/lib/{core/releaseNotes → tasks/features/releaseNotes/core}/service.js +1 -1
- package/lib/{core/releaseNotes → tasks/features/releaseNotes/core}/store.js +2 -2
- package/lib/{server/api → tasks/features/releaseNotes/server}/releaseNoteRoutes.js +11 -20
- package/lib/tasks/features/requirements/cli/requirementCommands.js +289 -0
- package/lib/{shared → tasks/features/requirements/shared}/acceptance.js +292 -18
- package/lib/tasks/features/requirements/shared/requirementSource.js +635 -0
- package/lib/tasks/features/retro/cli/retroCommands.js +106 -0
- package/lib/tasks/features/retro/core/retrospective.js +197 -0
- package/lib/tasks/features/retro/shared/retrospective.js +286 -0
- package/lib/tasks/features/settings/cli/projectSettings.js +245 -0
- package/lib/{cli → tasks/features/settings/cli}/userConfig.js +50 -3
- package/lib/{core → tasks/features/settings/core}/machineSettingsEdit.js +2 -2
- package/lib/{core → tasks/features/settings/core}/repoAdmin.js +3 -3
- package/lib/{core → tasks/features/settings/core}/userTheme.js +2 -2
- package/lib/{server/api → tasks/features/settings/server}/repoRoutes.js +2 -2
- package/lib/{server/api → tasks/features/settings/server}/userThemeRoutes.js +3 -3
- package/lib/{cli → tasks/features/taskReview/cli}/taskReviewCommands.js +5 -5
- package/lib/{core/taskReview → tasks/features/taskReview/core}/material.js +13 -7
- package/lib/{core/taskReview → tasks/features/taskReview/core}/review.js +10 -3
- package/lib/{core/taskReview → tasks/features/taskReview/core}/service.js +24 -85
- package/lib/{core/taskReview → tasks/features/taskReview/core}/store.js +4 -4
- package/lib/{server/api → tasks/features/taskReview/server}/taskReviewRoutes.js +7 -14
- package/lib/{server → tasks/server}/api/manifest.js +51 -3
- package/lib/{server → tasks/server}/api/routes.js +134 -65
- package/lib/tasks/shared/commitRefs.js +10 -0
- package/lib/{shared → tasks/shared}/preflightInput.js +1 -1
- package/package.json +1 -43
- package/skills/p3/SKILL.md +9 -181
- package/dist/web/assets/ImprovementDialog-kQaVBGWH.js +0 -1
- package/dist/web/assets/Outputs-_nU_p3nu.js +0 -1
- package/dist/web/assets/RequestStatus-RG-OVQYY.js +0 -1
- package/dist/web/assets/Tabs-ew9i5SKX.js +0 -1
- package/dist/web/assets/TagInput-BtlJTF7i.js +0 -1
- package/dist/web/assets/TaskDrawer-DW8GyJqI.js +0 -6
- package/dist/web/assets/_requestId-6Nb727dD.js +0 -1
- package/dist/web/assets/_requestId-BykTgPax.js +0 -1
- package/dist/web/assets/appCtx-CxDdXABS.js +0 -1
- package/dist/web/assets/archive-Ckh295Xe.js +0 -1
- package/dist/web/assets/board-BVAIjK-Y.js +0 -1
- package/dist/web/assets/done-BGfA-3MA.js +0 -1
- package/dist/web/assets/draft-CfJeyLOl.js +0 -1
- package/dist/web/assets/index-CgRU744I.css +0 -2
- package/dist/web/assets/index-DacQ0yl4.js +0 -12
- package/dist/web/assets/new-DVygWvVc.js +0 -1
- package/dist/web/assets/outputs-B6xDsLZf.js +0 -1
- package/dist/web/assets/preflightInput-BAeEJYUK.js +0 -2
- package/dist/web/assets/preload-helper-DyCqp21K.js +0 -1
- package/dist/web/assets/release-notes-CCpzyiNf.js +0 -5
- package/dist/web/assets/requestData-D5vBnuMh.js +0 -1
- package/dist/web/assets/routes-Q91zvNc0.js +0 -4
- package/dist/web/assets/settings-BzRgcmUm.js +0 -1
- package/dist/web/assets/workTarget-C9c57JAO.js +0 -30
- package/lib/cli/readOnly.js +0 -38
- package/lib/cli/showView.js +0 -166
- /package/lib/{core/store → kit}/frontmatter.js +0 -0
- /package/lib/{core/store → kit}/fsutil.js +0 -0
- /package/lib/{cli → tasks/cli}/format.js +0 -0
- /package/lib/{core → tasks/core}/chatgpt.js +0 -0
- /package/lib/{core → tasks/core}/machineSettings.js +0 -0
- /package/lib/{core → tasks/core}/preflight/codexImage.js +0 -0
- /package/lib/{core → tasks/core}/preflight/docker.js +0 -0
- /package/lib/{core → tasks/core}/preflight/launch.js +0 -0
- /package/lib/{core → tasks/core}/preflight/launcher.mjs +0 -0
- /package/lib/{core → tasks/core}/preflight/mock-ui.html +0 -0
- /package/lib/{core → tasks/core}/preflight/mock-ui.png +0 -0
- /package/lib/{core → tasks/core}/preflight/owner.js +0 -0
- /package/lib/{core → tasks/core}/preflight/render-image/Dockerfile +0 -0
- /package/lib/{core → tasks/core}/preflight/render-image/fonts-ja.conf +0 -0
- /package/lib/{core → tasks/core}/preflight/render-image/render.mjs +0 -0
- /package/lib/{core → tasks/core}/preflight/split.js +0 -0
- /package/lib/{core → tasks/core}/preflight/uiMaterials.js +0 -0
- /package/lib/{core → tasks/core}/preflight/wireframe.js +0 -0
- /package/lib/{core → tasks/core}/preflight/xlsx.js +0 -0
- /package/lib/{core → tasks/core}/redact.js +0 -0
- /package/lib/{core → tasks/core}/repoRefs.js +0 -0
- /package/lib/{core → tasks/core}/requestStatus.js +0 -0
- /package/lib/{core → tasks/core}/store/archivedTasks.js +0 -0
- /package/lib/{core → tasks/core}/store/dataWatcher.js +0 -0
- /package/lib/{core → tasks/core}/store/locate.js +0 -0
- /package/lib/{core → tasks/core}/supersede.js +0 -0
- /package/lib/{core/milestoneReview → tasks/features/milestoneReview/core}/mockReviewer.js +0 -0
- /package/lib/{shared → tasks/features/milestoneReview/shared}/milestoneReview.js +0 -0
- /package/lib/{core → tasks/features/quality/core}/quality.js +0 -0
- /package/lib/{shared → tasks/features/quality/shared}/quality.js +0 -0
- /package/lib/{shared → tasks/features/quality/shared}/qualityImprovement.js +0 -0
- /package/lib/{shared → tasks/features/quality/shared}/qualityTemplates.js +0 -0
- /package/lib/{core/releaseNotes → tasks/features/releaseNotes/core}/mockSummarizer.js +0 -0
- /package/lib/{core/taskReview → tasks/features/taskReview/core}/mockReviewer.js +0 -0
- /package/lib/{core/taskReview → tasks/features/taskReview/core}/paths.js +0 -0
- /package/lib/{shared → tasks/features/taskReview/shared}/taskReview.js +0 -0
- /package/lib/{server → tasks/server}/api/chatgptRoutes.js +0 -0
- /package/lib/{server → tasks/server}/api/local.js +0 -0
- /package/lib/{shared → tasks/shared}/dates.js +0 -0
- /package/lib/{shared → tasks/shared}/directTask.js +0 -0
- /package/lib/{shared → tasks/shared}/hierarchy.js +0 -0
- /package/lib/{shared → tasks/shared}/milestoneGoals.js +0 -0
- /package/lib/{shared → tasks/shared}/milestoneOrder.js +0 -0
- /package/lib/{shared → tasks/shared}/preflightRunner.js +0 -0
- /package/lib/{shared → tasks/shared}/refs.js +0 -0
- /package/lib/{shared → tasks/shared}/repos.js +0 -0
- /package/lib/{shared → tasks/shared}/scopeView.js +0 -0
- /package/lib/{shared → tasks/shared}/tags.js +0 -0
- /package/lib/{shared → tasks/shared}/taskBlock.js +0 -0
- /package/lib/{shared → tasks/shared}/types.js +0 -0
- /package/lib/{shared → tasks/shared}/workTarget.js +0 -0
|
@@ -1,17 +1,18 @@
|
|
|
1
1
|
import { qualityTemplate, qualityView, updateQuality } from "../core/quality.js";
|
|
2
2
|
import { checkLine } from "../shared/quality.js";
|
|
3
3
|
import { diagnoseQuality, improvementDraft, registerImprovement } from "../core/qualityImprovement.js";
|
|
4
|
-
import { readBody } from "
|
|
5
|
-
import { table } from "
|
|
6
|
-
import { UsageError } from "
|
|
4
|
+
import { readBody } from "../../../cli/args.js";
|
|
5
|
+
import { table } from "../../../cli/format.js";
|
|
6
|
+
import { UsageError } from "../../../../kit/usage.js";
|
|
7
7
|
/**
|
|
8
8
|
* 品質基準(core/quality.ts。画面の設定の「品質基準」と同じ)。
|
|
9
9
|
* quality 今の設定(未設定・設定済み・読めない)とテンプレートの改版の差分
|
|
10
10
|
* quality templates / quality template <id> 同梱のテンプレートの一覧・中身
|
|
11
|
-
* quality init
|
|
11
|
+
* quality init 空の品質基準を設定する(意図して空。必須ではなく、設定済みなら内容は変えない)
|
|
12
12
|
* quality adopt <テンプレート> テンプレートを写して採用する / quality upgrade <テンプレート> 改版の差分を当てる
|
|
13
13
|
* quality add --text 文 [--repo 名前]... (--command コマンド --success 成功の条件 | --reference 確かめ方)
|
|
14
|
-
* quality set <Q1> [--text] [--repo]... [--command --success | --reference] quality rm <Q1>
|
|
14
|
+
* quality set <Q1> [--text] [--repo 名前|all]... [--command --success | --reference] quality rm <Q1>
|
|
15
|
+
* --repo は繰り返して複数の参照先を指定する(qualityRepos)。add で省くと全参照先、set で省くと対象は変えない
|
|
15
16
|
* quality exempt <Q1> --reason 理由 / quality unexempt <Q1>
|
|
16
17
|
* 変える操作は --version <版>(quality --json の version)を付けると、違えば競合(終了コード 3)
|
|
17
18
|
*/
|
|
@@ -45,6 +46,8 @@ export async function qualityCommand(env) {
|
|
|
45
46
|
return { kind: "machine", command: o.command ?? "", success: o.success ?? "" };
|
|
46
47
|
return undefined;
|
|
47
48
|
};
|
|
49
|
+
if (o.repos !== undefined && sub !== "add" && sub !== "set")
|
|
50
|
+
throw new UsageError(`--repo は p3 quality add / set でだけ使えます(${sub} は対象を取りません)`);
|
|
48
51
|
let ops;
|
|
49
52
|
switch (sub) {
|
|
50
53
|
case "init":
|
|
@@ -64,14 +67,16 @@ export async function qualityCommand(env) {
|
|
|
64
67
|
const c = check();
|
|
65
68
|
if (!c)
|
|
66
69
|
throw new UsageError("確認の方法を指定してください: --command <コマンド> --success <成功の条件>(機械の検査)か --reference <確かめ方>(人の確認)");
|
|
67
|
-
|
|
70
|
+
const repos = qualityRepos(o.repos, ws.project.repos.map((r) => r.name));
|
|
71
|
+
ops = [{ op: "add", standard: { text: readBody(o.text ?? ""), ...(repos ? { repos } : {}), check: c } }];
|
|
68
72
|
break;
|
|
69
73
|
}
|
|
70
74
|
case "set": {
|
|
71
75
|
if (!rest[0])
|
|
72
|
-
throw new UsageError("使い方: p3 quality set <Q1> [--text 文] [--repo
|
|
76
|
+
throw new UsageError("使い方: p3 quality set <Q1> [--text 文] [--repo 名前 ...|all] [--command ... --success ... | --reference ...]");
|
|
73
77
|
const c = check();
|
|
74
|
-
|
|
78
|
+
const repos = qualityRepos(o.repos, ws.project.repos.map((r) => r.name));
|
|
79
|
+
ops = [{ op: "edit", id: rest[0], standard: { ...(o.text !== undefined ? { text: readBody(o.text) } : {}), ...(repos ? { repos } : {}), ...(c ? { check: c } : {}) } }];
|
|
75
80
|
break;
|
|
76
81
|
}
|
|
77
82
|
case "rm":
|
|
@@ -96,6 +101,24 @@ export async function qualityCommand(env) {
|
|
|
96
101
|
const v = await updateQuality(ws, ops, { expectedVersion: o.version });
|
|
97
102
|
return out.result(v, () => formatQuality(v));
|
|
98
103
|
}
|
|
104
|
+
/**
|
|
105
|
+
* 品質基準の対象(--repo を繰り返した全部)。省くと undefined(add は全参照先・set は今の対象のまま)、all は全参照先([])。
|
|
106
|
+
* all と個別の名前は一緒に使えない。同じ名前は1つにまとめる。登録されていない名前は保存の規則(shared/quality.ts)が断る
|
|
107
|
+
*/
|
|
108
|
+
export function qualityRepos(raw, repoNames) {
|
|
109
|
+
if (raw === undefined)
|
|
110
|
+
return undefined;
|
|
111
|
+
const names = [...new Set(raw.map((r) => r.trim()))];
|
|
112
|
+
if (names.includes(""))
|
|
113
|
+
throw new UsageError("--repo に参照先の名前を指定してください(全参照先なら --repo all)");
|
|
114
|
+
if (!names.includes("all"))
|
|
115
|
+
return names;
|
|
116
|
+
if (names.length > 1)
|
|
117
|
+
throw new UsageError(`--repo all(全参照先)と個別の参照先(${names.filter((n) => n !== "all").join(", ")})は一緒に指定できません`);
|
|
118
|
+
if (repoNames.includes("all"))
|
|
119
|
+
throw new UsageError("「all」という名前の参照先があるため、--repo all が全参照先か参照先 all かを決められません(画面の品質基準で対象を選んでください)");
|
|
120
|
+
return [];
|
|
121
|
+
}
|
|
99
122
|
/**
|
|
100
123
|
* quality improve [task <要望>/<T> <run> | milestone <ID> <run>] 不足の診断と改善要望の原稿(読むだけ。省くとプロジェクトの設定)
|
|
101
124
|
* --key <不足の鍵>...(省くと既定で選ぶもの)
|
|
@@ -140,8 +163,10 @@ export function formatQuality(v) {
|
|
|
140
163
|
const q = v.quality;
|
|
141
164
|
if (q.state === "unset") {
|
|
142
165
|
return [
|
|
143
|
-
"品質基準:
|
|
144
|
-
"
|
|
166
|
+
"品質基準: 未設定(このままでも作業は続けられます。p3 quality init は必須ではありません)",
|
|
167
|
+
" 基準を足す: p3 quality add --text 文 (--command コマンド --success 成功の条件 | --reference 確かめ方) [--repo 名前 ...]",
|
|
168
|
+
" テンプレートから: p3 quality adopt basic(一覧は p3 quality templates)",
|
|
169
|
+
" 基準を置かないと決めたことを残す: p3 quality init(意図して空にする。設定済みなら何も変えない)",
|
|
145
170
|
].join("\n");
|
|
146
171
|
}
|
|
147
172
|
if (q.state === "invalid")
|
|
@@ -150,7 +175,7 @@ export function formatQuality(v) {
|
|
|
150
175
|
if (!q.config.standards.length)
|
|
151
176
|
lines.push(" (意図して空にしています)");
|
|
152
177
|
for (const s of q.config.standards) {
|
|
153
|
-
lines.push(` ${s.id} ${s.text}${s.
|
|
178
|
+
lines.push(` ${s.id} ${s.text}${s.exempt ? " ※除外" : ""}`, ` 対象: ${s.repos?.length ? s.repos.join(", ") : "全参照先"}`, ` ${checkLine(s.check)}`);
|
|
154
179
|
if (s.exempt)
|
|
155
180
|
lines.push(` 除外の理由: ${s.exempt.reason}`);
|
|
156
181
|
}
|
|
@@ -1,9 +1,9 @@
|
|
|
1
1
|
import { createHash, randomBytes } from "node:crypto";
|
|
2
|
-
import { readFile } from "node:fs/promises";
|
|
3
2
|
import { join } from "node:path";
|
|
4
3
|
import { checkLine } from "../shared/quality.js";
|
|
5
|
-
import { createRequest } from "
|
|
6
|
-
import { withFileLock
|
|
4
|
+
import { createRequest } from "../../../core/requestOps.js";
|
|
5
|
+
import { withFileLock } from "../../../../kit/fsutil.js";
|
|
6
|
+
import { readJsonRecord, writeJsonRecord } from "../../../core/store/jsonRecord.js";
|
|
7
7
|
/**
|
|
8
8
|
* 品質の不足から改善要望を作る(CLI の p3 quality improve・API の /quality/improvements)。
|
|
9
9
|
*
|
|
@@ -150,19 +150,20 @@ export function improvementDraft(d, keys) {
|
|
|
150
150
|
}
|
|
151
151
|
const ledgerPath = (dataDir) => join(dataDir, "quality-improvements.json");
|
|
152
152
|
export const tokenTag = (token) => `quality-improvement:${token}`;
|
|
153
|
-
|
|
154
|
-
|
|
155
|
-
|
|
156
|
-
|
|
157
|
-
|
|
158
|
-
|
|
159
|
-
|
|
160
|
-
|
|
161
|
-
|
|
162
|
-
|
|
163
|
-
|
|
153
|
+
/** 登録の記録を読む。無い・読めない(readFile の失敗)・空のファイル・形が違うものは空とみなし、JSON として読めなければ断る(今の扱い。docs/refactoring.md) */
|
|
154
|
+
function readLedger(dataDir) {
|
|
155
|
+
const empty = () => ({ version: 1, entries: {} });
|
|
156
|
+
return readJsonRecord(ledgerPath(dataDir), {
|
|
157
|
+
missing: empty,
|
|
158
|
+
readFailed: empty,
|
|
159
|
+
blank: empty,
|
|
160
|
+
invalidJson: () => {
|
|
161
|
+
throw new ImprovementError("invalid", `quality-improvements.json が読めません(${ledgerPath(dataDir)})。直すか退けてからやり直してください`);
|
|
162
|
+
},
|
|
163
|
+
shape: (v) => (v && typeof v.entries === "object" ? v : empty()),
|
|
164
|
+
});
|
|
164
165
|
}
|
|
165
|
-
const writeLedger = (dataDir, l) =>
|
|
166
|
+
const writeLedger = (dataDir, l) => writeJsonRecord(ledgerPath(dataDir), l);
|
|
166
167
|
const CLOSED = ["done", "rejected"];
|
|
167
168
|
/**
|
|
168
169
|
* 明示して登録する。hash は原稿を作った診断の版。reopenClosed: 閉じた要望が登録先の不足から作り直す。
|
|
@@ -0,0 +1,73 @@
|
|
|
1
|
+
import { REVIEW_CODE_LABEL, REVIEW_STATE_HINT, REVIEW_STATE_LABEL } from "../shared/reviewCandidate.js";
|
|
2
|
+
import { recordPremise } from "../../../core/requestOps.js";
|
|
3
|
+
import { reviewCandidates } from "../core/reviewCandidates.js";
|
|
4
|
+
import { UsageError } from "../../../../kit/usage.js";
|
|
5
|
+
/**
|
|
6
|
+
* 見直しが必要(候補)と前提の変更のコマンド(規則は shared/reviewCandidate.ts)。
|
|
7
|
+
*
|
|
8
|
+
* revisit [<要望>] [--all] 見直し候補(完了したタスクと対応済・完了済の要望。完了済みも含む)
|
|
9
|
+
* premise [<要望>] 前提の変更の一覧
|
|
10
|
+
* premise [<要望>] add --target <ID>... --reason 理由 --condition 新しい条件 前提の変更を記録する(外部の規則の変更など)
|
|
11
|
+
* premise [<要望>] ack <P> --target <ID> --condition 確かめた条件 変更を確かめたことを記録する
|
|
12
|
+
*/
|
|
13
|
+
/** 診断の行(p3 show・p3 revisit で使う) */
|
|
14
|
+
export function formatReview(d, { head = true } = {}) {
|
|
15
|
+
const lines = head ? [`見直し: ${REVIEW_STATE_LABEL[d.state]}${d.record ? `(基点 ${d.record})` : ""}`] : [];
|
|
16
|
+
if (d.state !== "candidate")
|
|
17
|
+
lines.push(` ${REVIEW_STATE_HINT[d.state]}`);
|
|
18
|
+
for (const r of d.reasons) {
|
|
19
|
+
lines.push(` - ${REVIEW_CODE_LABEL[r.code]} ${r.target}${r.related?.length ? `(関係: ${r.related.join(", ")})` : ""}`);
|
|
20
|
+
if (r.was !== undefined)
|
|
21
|
+
lines.push(` 当時: ${r.was}`);
|
|
22
|
+
if (r.now !== undefined)
|
|
23
|
+
lines.push(` 今: ${r.now}`);
|
|
24
|
+
}
|
|
25
|
+
for (const u of d.unreadable ?? [])
|
|
26
|
+
lines.push(` ※比べられない: ${u}`);
|
|
27
|
+
if (d.state === "candidate")
|
|
28
|
+
lines.push(" 候補を出すだけで、状態・済みは変えていません。確かめたら、もう一度済みにすると新しい記録が基点になります");
|
|
29
|
+
return lines;
|
|
30
|
+
}
|
|
31
|
+
const premiseLines = (c) => [
|
|
32
|
+
`${c.id} ${c.at} ${c.by ?? ""} 対象: ${c.targets.join(", ")}`,
|
|
33
|
+
` 理由: ${c.reason}`,
|
|
34
|
+
` 新しい条件: ${c.condition}`,
|
|
35
|
+
...(c.acks ?? []).map((a) => ` 確認: ${a.target} ${a.condition} ${a.at} ${a.by ?? ""}`),
|
|
36
|
+
];
|
|
37
|
+
export async function revisitCommand(cmd, env) {
|
|
38
|
+
const { ctx, out, args, o, actor, current, expectedRev, requestArg } = env;
|
|
39
|
+
if (cmd === "revisit") {
|
|
40
|
+
const rid = args[0] ? requestArg(args[0]) : o.all || !current ? undefined : current;
|
|
41
|
+
const list = reviewCandidates(ctx, rid ? { request: rid } : {});
|
|
42
|
+
return out.result(list, () => (list.length ? list.flatMap((d) => [d.target, ...formatReview(d, { head: false }), ""]).join("\n").trimEnd() : `見直しが必要(候補)はありません${rid ? `(${rid}。全要望は --all)` : ""}`));
|
|
43
|
+
}
|
|
44
|
+
if (cmd !== "premise" && cmd !== "premises")
|
|
45
|
+
return undefined;
|
|
46
|
+
const subs = new Set(["add", "ack", "ls"]);
|
|
47
|
+
const rest = subs.has(args[0] ?? "") || args.length === 0 ? args : args.slice(1);
|
|
48
|
+
const rid = requestArg(subs.has(args[0] ?? "") || args.length === 0 ? undefined : args[0]);
|
|
49
|
+
const sub = rest[0] ?? "ls";
|
|
50
|
+
if (sub === "ls") {
|
|
51
|
+
const list = ctx.ws.requests.require(rid).premiseChanges ?? [];
|
|
52
|
+
return out.result(list, () => (list.length ? list.flatMap(premiseLines).join("\n") : `${rid} に前提の変更の記録はありません`));
|
|
53
|
+
}
|
|
54
|
+
const condition = o.condition;
|
|
55
|
+
if (!condition)
|
|
56
|
+
throw new UsageError("--condition(新しい条件・版。ack では確かめた条件)を指定してください");
|
|
57
|
+
let op;
|
|
58
|
+
if (sub === "add") {
|
|
59
|
+
if (!o.target?.length || !o.reason)
|
|
60
|
+
throw new UsageError("--target <要望 ID・タスク ID・要望の根拠の ID>(複数可)と --reason を指定してください");
|
|
61
|
+
op = { op: "add", targets: o.target, reason: o.reason, condition };
|
|
62
|
+
}
|
|
63
|
+
else if (sub === "ack") {
|
|
64
|
+
const id = rest[1];
|
|
65
|
+
if (!id || o.target?.length !== 1)
|
|
66
|
+
throw new UsageError("p3 premise ack <P1> --target <ID> --condition <確かめた条件>");
|
|
67
|
+
op = { op: "ack", id, target: o.target[0], condition };
|
|
68
|
+
}
|
|
69
|
+
else
|
|
70
|
+
throw new UsageError("p3 premise [<要望>] [ls | add | ack <P>]");
|
|
71
|
+
const { change, request } = await recordPremise(ctx, rid, op, { expectedRev, actor });
|
|
72
|
+
return out.result({ change, rev: request.rev }, () => [`${sub === "add" ? "記録しました" : "確認を記録しました"}(rev ${request.rev})`, ...premiseLines(change)].join("\n"));
|
|
73
|
+
}
|
|
@@ -0,0 +1,46 @@
|
|
|
1
|
+
import { execFile } from "node:child_process";
|
|
2
|
+
/**
|
|
3
|
+
* 完了の記録に残す参照先の取得(shared/completionRecord.ts の RefCapture)。登録された参照先ごとに、このマシンのパスで
|
|
4
|
+
* HEAD のコミットと未コミットの変更の有無を取る。取れなければ理由を残す(推測で埋めない)。このマシンのパスは残さない。
|
|
5
|
+
* 書く前(ロックの外)に取るので、取得時刻を参照先ごとに残す
|
|
6
|
+
*/
|
|
7
|
+
const UNAVAILABLE = {
|
|
8
|
+
unregistered: "このマシンのパスが登録されていません",
|
|
9
|
+
missing: "登録したパスがありません",
|
|
10
|
+
notdir: "登録したパスがフォルダではありません",
|
|
11
|
+
};
|
|
12
|
+
function git(local, args) {
|
|
13
|
+
return new Promise((resolve) => {
|
|
14
|
+
execFile("git", ["-C", local, ...args], { encoding: "utf8", timeout: 15_000, maxBuffer: 16 * 1024 * 1024 }, (err, stdout, stderr) => resolve(err ? { ok: false, err: `${stderr || err.message}` } : { ok: true, out: stdout }));
|
|
15
|
+
});
|
|
16
|
+
}
|
|
17
|
+
/** git の失敗の理由(このマシンのパスを伏せて1行に) */
|
|
18
|
+
const reasonOf = (err, local) => (err.split("\n").find((l) => l.trim()) ?? "git の実行に失敗しました").split(local).join("<参照先>").trim().slice(0, 300);
|
|
19
|
+
export async function captureRef(r, now = () => new Date().toISOString()) {
|
|
20
|
+
if (r.status !== "ok" || !r.local) {
|
|
21
|
+
const state = r.status === "ok" ? "unregistered" : r.status;
|
|
22
|
+
return { name: r.name, state, at: now(), reason: UNAVAILABLE[state] };
|
|
23
|
+
}
|
|
24
|
+
const local = r.local;
|
|
25
|
+
const inside = await git(local, ["rev-parse", "--is-inside-work-tree"]);
|
|
26
|
+
if (!inside.ok) {
|
|
27
|
+
if (/not a git repository/i.test(inside.err))
|
|
28
|
+
return { name: r.name, state: "not_git", at: now(), reason: "git のリポジトリではありません" };
|
|
29
|
+
return { name: r.name, state: "failed", at: now(), reason: reasonOf(inside.err, local) };
|
|
30
|
+
}
|
|
31
|
+
const head = await git(local, ["rev-parse", "HEAD"]);
|
|
32
|
+
if (!head.ok)
|
|
33
|
+
return { name: r.name, state: "failed", at: now(), reason: /unknown revision|ambiguous argument/i.test(head.err) ? "コミットがありません" : reasonOf(head.err, local) };
|
|
34
|
+
const status = await git(local, ["status", "--porcelain", "--", "."]);
|
|
35
|
+
return {
|
|
36
|
+
name: r.name,
|
|
37
|
+
state: "ok",
|
|
38
|
+
commit: head.out.trim(),
|
|
39
|
+
...(status.ok ? { dirty: status.out.trim() !== "" } : { reason: `未コミットの変更を確かめられません: ${reasonOf(status.err, local)}` }),
|
|
40
|
+
at: now(),
|
|
41
|
+
};
|
|
42
|
+
}
|
|
43
|
+
/** 登録された参照先を全部取る(並べて実行) */
|
|
44
|
+
export function captureRefs(refs) {
|
|
45
|
+
return Promise.all(refs.map((r) => captureRef(r)));
|
|
46
|
+
}
|
|
@@ -0,0 +1,76 @@
|
|
|
1
|
+
import { diagnoseRequest, diagnoseTask, isReviewTarget, reviewSummary } from "../shared/reviewCandidate.js";
|
|
2
|
+
import { hierarchyNow } from "../../../core/requestStatus.js";
|
|
3
|
+
/**
|
|
4
|
+
* 見直し候補の読み取り(規則は shared/reviewCandidate.ts)。読み込んだ値だけで診断し、ファイルは書かない・git も実行しない。
|
|
5
|
+
* アーカイブした要望・タスクは見ない
|
|
6
|
+
*/
|
|
7
|
+
const nowOf = (ctx) => ({ quality: ctx.ws.project.quality, qualityVersion: ctx.ws.project.qualityVersion });
|
|
8
|
+
/** タスクの診断(完了していなければ undefined) */
|
|
9
|
+
export function taskReview(ctx, task) {
|
|
10
|
+
return diagnoseTask(task, ctx.ws.requests.get(task.request), nowOf(ctx));
|
|
11
|
+
}
|
|
12
|
+
/** 要望自身の診断(対応済・完了済でなければ undefined) */
|
|
13
|
+
export function requestSelfReview(ctx, r) {
|
|
14
|
+
return diagnoseRequest(r, nowOf(ctx));
|
|
15
|
+
}
|
|
16
|
+
const isCandidate = (d) => d?.state === "candidate";
|
|
17
|
+
export function reviewMemo(ctx) {
|
|
18
|
+
const now = nowOf(ctx);
|
|
19
|
+
const tasks = new Map();
|
|
20
|
+
const requests = new Map();
|
|
21
|
+
return {
|
|
22
|
+
task: (t) => {
|
|
23
|
+
if (!tasks.has(t.ref))
|
|
24
|
+
tasks.set(t.ref, diagnoseTask(t, ctx.ws.requests.get(t.request), now));
|
|
25
|
+
return tasks.get(t.ref);
|
|
26
|
+
},
|
|
27
|
+
request: (r) => {
|
|
28
|
+
if (!requests.has(r.id))
|
|
29
|
+
requests.set(r.id, diagnoseRequest(r, now));
|
|
30
|
+
return requests.get(r.id);
|
|
31
|
+
},
|
|
32
|
+
};
|
|
33
|
+
}
|
|
34
|
+
/**
|
|
35
|
+
* 要望の概要(自身・自分のタスク・自分を除く配下)。配下は子孫の要望自身とそのタスクを1回ずつ数える。
|
|
36
|
+
* memo を渡すと診断を使い回す(進捗は全部の要望で1つの memo を使う)
|
|
37
|
+
*/
|
|
38
|
+
export function requestReviewCounts(ctx, r, h = hierarchyNow(ctx.ws), memo = reviewMemo(ctx)) {
|
|
39
|
+
const self = memo.request(r);
|
|
40
|
+
const tasksOf = (id) => ctx.ws.tasksOf(id).list().filter((t) => isCandidate(memo.task(t))).length;
|
|
41
|
+
let below = 0;
|
|
42
|
+
for (const d of h.descendants(r.id))
|
|
43
|
+
below += tasksOf(d.id) + (isCandidate(memo.request(d)) ? 1 : 0);
|
|
44
|
+
return { ...(self ? { self: reviewSummary(self) } : {}), tasks: tasksOf(r.id), below };
|
|
45
|
+
}
|
|
46
|
+
/** 要望の詳細に添える診断(自身・タスクごとの概要・配下の件数) */
|
|
47
|
+
export function requestReview(ctx, rid) {
|
|
48
|
+
const r = ctx.ws.requests.require(rid);
|
|
49
|
+
const self = requestSelfReview(ctx, r);
|
|
50
|
+
const tasks = Object.fromEntries(ctx.ws
|
|
51
|
+
.tasksOf(rid)
|
|
52
|
+
.list()
|
|
53
|
+
.flatMap((t) => {
|
|
54
|
+
const d = taskReview(ctx, t);
|
|
55
|
+
return d ? [[t.id, reviewSummary(d)]] : [];
|
|
56
|
+
}));
|
|
57
|
+
return { ...(self ? { self } : {}), tasks, counts: requestReviewCounts(ctx, r) };
|
|
58
|
+
}
|
|
59
|
+
/** 見直し候補の一覧(タスクと要望。完了済みも含む)。request を渡すとその要望だけ */
|
|
60
|
+
export function reviewCandidates(ctx, opts = {}) {
|
|
61
|
+
const requests = opts.request ? [ctx.ws.requests.require(opts.request)] : ctx.ws.requests.list();
|
|
62
|
+
const out = [];
|
|
63
|
+
for (const r of requests) {
|
|
64
|
+
const self = requestSelfReview(ctx, r);
|
|
65
|
+
if (isCandidate(self))
|
|
66
|
+
out.push(self);
|
|
67
|
+
for (const t of ctx.ws.tasksOf(r.id).list()) {
|
|
68
|
+
if (!isReviewTarget(t))
|
|
69
|
+
continue;
|
|
70
|
+
const d = taskReview(ctx, t);
|
|
71
|
+
if (isCandidate(d))
|
|
72
|
+
out.push(d);
|
|
73
|
+
}
|
|
74
|
+
}
|
|
75
|
+
return out;
|
|
76
|
+
}
|