@infodb/p3 0.11.0 → 0.12.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (101) hide show
  1. package/README.md +4 -1
  2. package/dist/web/assets/ImprovementDialog-kQaVBGWH.js +1 -0
  3. package/dist/web/assets/Outputs-_nU_p3nu.js +1 -0
  4. package/dist/web/assets/{RequestStatus-Bg1OLbRc.js → RequestStatus-RG-OVQYY.js} +1 -1
  5. package/dist/web/assets/{Tabs-DTmggzgg.js → Tabs-ew9i5SKX.js} +1 -1
  6. package/dist/web/assets/TagInput-BtlJTF7i.js +1 -0
  7. package/dist/web/assets/TaskDrawer-DW8GyJqI.js +6 -0
  8. package/dist/web/assets/_requestId-6Nb727dD.js +1 -0
  9. package/dist/web/assets/_requestId-BykTgPax.js +1 -0
  10. package/dist/web/assets/appCtx-CxDdXABS.js +1 -0
  11. package/dist/web/assets/archive-Ckh295Xe.js +1 -0
  12. package/dist/web/assets/board-BVAIjK-Y.js +1 -0
  13. package/dist/web/assets/done-BGfA-3MA.js +1 -0
  14. package/dist/web/assets/index-CgRU744I.css +2 -0
  15. package/dist/web/assets/index-DacQ0yl4.js +12 -0
  16. package/dist/web/assets/{new-9TKiNT4O.js → new-DVygWvVc.js} +1 -1
  17. package/dist/web/assets/outputs-B6xDsLZf.js +1 -0
  18. package/dist/web/assets/preload-helper-DyCqp21K.js +1 -0
  19. package/dist/web/assets/quality-Pu6EISAM.js +1 -0
  20. package/dist/web/assets/release-notes-CCpzyiNf.js +5 -0
  21. package/dist/web/assets/requestData-D5vBnuMh.js +1 -0
  22. package/dist/web/assets/routes-Q91zvNc0.js +4 -0
  23. package/dist/web/assets/settings-BzRgcmUm.js +1 -0
  24. package/dist/web/assets/taskReview-_WCgnQit.js +1 -0
  25. package/dist/web/assets/workTarget-C9c57JAO.js +30 -0
  26. package/dist/web/index.html +4 -4
  27. package/docs/architecture.md +315 -2
  28. package/docs/development.md +1 -1
  29. package/docs/how-to-use.md +184 -0
  30. package/docs/installation.md +5 -5
  31. package/lib/cli/args.js +45 -0
  32. package/lib/cli/help.js +36 -1
  33. package/lib/cli/main.js +27 -3
  34. package/lib/cli/output.js +9 -1
  35. package/lib/cli/preflightCommands.js +7 -1
  36. package/lib/cli/project.js +3 -0
  37. package/lib/cli/qualityCommands.js +163 -0
  38. package/lib/cli/readOnly.js +2 -0
  39. package/lib/cli/requestCommands.js +12 -0
  40. package/lib/cli/showView.js +69 -3
  41. package/lib/cli/taskCommands.js +312 -17
  42. package/lib/cli/taskReviewCommands.js +178 -0
  43. package/lib/core/context.js +4 -1
  44. package/lib/core/milestoneReview/material.js +11 -1
  45. package/lib/core/milestoneReview/mockReviewer.js +1 -0
  46. package/lib/core/milestoneReview/review.js +70 -6
  47. package/lib/core/milestoneReview/service.js +29 -93
  48. package/lib/core/milestoneReview/store.js +12 -62
  49. package/lib/core/ops.js +9 -2
  50. package/lib/core/preflight/carryover.js +1 -1
  51. package/lib/core/preflight/engine.js +6 -0
  52. package/lib/core/preflight/instructions.js +18 -1
  53. package/lib/core/preflight/mockEngine.js +4 -0
  54. package/lib/core/preflight/service.js +45 -4
  55. package/lib/core/projectRegistry.js +3 -3
  56. package/lib/core/quality.js +21 -0
  57. package/lib/core/qualityImprovement.js +221 -0
  58. package/lib/core/requestOps.js +97 -6
  59. package/lib/core/reviewRuns.js +205 -0
  60. package/lib/core/store/archivedTasks.js +74 -0
  61. package/lib/core/store/collection.js +12 -2
  62. package/lib/core/store/normalize.js +16 -1
  63. package/lib/core/store/preflightStore.js +9 -1
  64. package/lib/core/store/projectFile.js +10 -0
  65. package/lib/core/store/workspace.js +33 -3
  66. package/lib/core/taskReview/material.js +452 -0
  67. package/lib/core/taskReview/mockReviewer.js +30 -0
  68. package/lib/core/taskReview/paths.js +15 -0
  69. package/lib/core/taskReview/review.js +305 -0
  70. package/lib/core/taskReview/service.js +187 -0
  71. package/lib/core/taskReview/store.js +214 -0
  72. package/lib/server/api/manifest.js +55 -4
  73. package/lib/server/api/milestoneReviewRoutes.js +4 -3
  74. package/lib/server/api/routes.js +145 -17
  75. package/lib/server/api/taskReviewRoutes.js +66 -0
  76. package/lib/server/server.js +2 -2
  77. package/lib/shared/acceptance.js +378 -0
  78. package/lib/shared/milestoneReview.js +2 -1
  79. package/lib/shared/quality.js +391 -0
  80. package/lib/shared/qualityImprovement.js +1 -0
  81. package/lib/shared/qualityTemplates.js +31 -0
  82. package/lib/shared/taskBlock.js +142 -0
  83. package/lib/shared/taskReview.js +56 -0
  84. package/package.json +1 -1
  85. package/skills/p3/SKILL.md +31 -2
  86. package/dist/web/assets/Outputs-ddwte0jj.js +0 -1
  87. package/dist/web/assets/TagInput-BHAgjLP7.js +0 -1
  88. package/dist/web/assets/TaskDrawer-Dz_5c2NH.js +0 -3
  89. package/dist/web/assets/_requestId-D9-gtIcG.js +0 -1
  90. package/dist/web/assets/_requestId-DzCNYvqf.js +0 -30
  91. package/dist/web/assets/appCtx-Cm24VpAf.js +0 -1
  92. package/dist/web/assets/board-MCHcZ-PU.js +0 -1
  93. package/dist/web/assets/done-zq10Bt08.js +0 -1
  94. package/dist/web/assets/index-Ce0ndpne.js +0 -12
  95. package/dist/web/assets/index-D68mkSnw.css +0 -2
  96. package/dist/web/assets/preload-helper-FBLw7u7x.js +0 -1
  97. package/dist/web/assets/release-notes-hK5XezLW.js +0 -5
  98. package/dist/web/assets/requestData-BnN7mctX.js +0 -1
  99. package/dist/web/assets/routes-usHwrrA0.js +0 -3
  100. package/dist/web/assets/settings-BVZDnL6O.js +0 -1
  101. package/dist/web/assets/workTarget-Cijqq4yH.js +0 -1
@@ -0,0 +1,205 @@
1
+ import { readdir, readFile } from "node:fs/promises";
2
+ import { ownerState, systemProbe } from "./preflight/owner.js";
3
+ import { writeFileAtomic } from "./store/fsutil.js";
4
+ /**
5
+ * レビューの実行の記録の共通部分(マイルストーンレビュー・タスクの AI レビュー)。比較材料と結果の形は各レビューに残し、ここには
6
+ * 「保存の仕方」と「実行中の run の扱い」だけを置く。
7
+ *
8
+ * - JSON は tmp に書いてから rename する。無いのは not_found、読めないのは broken(一覧からも隠さない)
9
+ * - 状態は running → completed / failed / cancelled の一方向。終わった run は変えない(finished で断る。遅れて届いた結果も取り込まない)
10
+ * - 同じ対象(キー)で実行中の run は1つだけ。確かめるのも変えるのもキーごとのロックの中
11
+ * - 実行しているプロセスが死んだと確かめられた run だけ自動で失敗(crashed)にする。分からない run は人が明示して中断する
12
+ * - 取消は、このプロセスの run なら止め、ほかのプロセスの run なら要求を run.json に書く(所有者が見つけて止める)
13
+ */
14
+ /** 履歴の操作の失敗。not_found: 無い / broken: 読めない / bad_id: ID が使えない / exists: 既にある / finished: 終わった run */
15
+ export class ReviewStoreError extends Error {
16
+ code;
17
+ constructor(code, message) {
18
+ super(message);
19
+ this.code = code;
20
+ }
21
+ }
22
+ /** 取消・中断を受け付けない(終わっている・動いている所有者がいる) */
23
+ export class ReviewCancelRefused extends Error {
24
+ code;
25
+ constructor(code, message) {
26
+ super(message);
27
+ this.code = code;
28
+ }
29
+ }
30
+ export async function writeJson(path, v) {
31
+ await writeFileAtomic(path, `${JSON.stringify(v, null, 2)}\n`);
32
+ }
33
+ export async function readJson(path, label, check) {
34
+ let text;
35
+ try {
36
+ text = await readFile(path, "utf8");
37
+ }
38
+ catch (e) {
39
+ if (e.code === "ENOENT")
40
+ throw new ReviewStoreError("not_found", `レビューの記録がありません: ${label}`);
41
+ throw e;
42
+ }
43
+ try {
44
+ const v = JSON.parse(text);
45
+ check(v);
46
+ return v;
47
+ }
48
+ catch (e) {
49
+ throw new ReviewStoreError("broken", `レビューの記録を読めません: ${label}(${e.message})`);
50
+ }
51
+ }
52
+ /** フォルダの中のフォルダ(無ければ空。シンボリックリンクは含めない) */
53
+ export async function dirs(path) {
54
+ try {
55
+ return (await readdir(path, { withFileTypes: true })).filter((d) => d.isDirectory()).map((d) => d.name);
56
+ }
57
+ catch (e) {
58
+ if (e.code === "ENOENT")
59
+ return [];
60
+ throw e;
61
+ }
62
+ }
63
+ /** 開始の日時を run の ID にする形(YYYYMMDD-HHMMSS) */
64
+ export const runStamp = (now = new Date()) => now.toISOString().replace(/[-:]/g, "").replace("T", "-").slice(0, 15);
65
+ /** 開始の日時(このプロセスでは前より必ず後にする。一覧を開始の順に並べるので、同じミリ秒の開始でも順が分かるように) */
66
+ let lastStart = 0;
67
+ export function startedNow() {
68
+ lastStart = Math.max(Date.now(), lastStart + 1);
69
+ return new Date(lastStart).toISOString();
70
+ }
71
+ /**
72
+ * run.json の終わり・書き換えの規則(各ストアの finish / updateRunning の中身)。write は run.json を書く、writeResult は結果を書く
73
+ */
74
+ export async function finishRunFile(label, cur, patch, result, io) {
75
+ if (cur.status !== "running")
76
+ throw new ReviewStoreError("finished", `${label} は既に終わっています(${cur.status})`);
77
+ if (patch.status === "completed") {
78
+ if (result === undefined)
79
+ throw new Error("completed には結果が要ります");
80
+ await io.writeResult(result);
81
+ }
82
+ const next = { ...cur, ...patch, finishedAt: patch.finishedAt ?? new Date().toISOString() };
83
+ await io.writeRun(next);
84
+ return next;
85
+ }
86
+ export async function updateRunFile(label, cur, fn, writeRun) {
87
+ if (cur.status !== "running")
88
+ throw new ReviewStoreError("finished", `${label} は既に終わっています(${cur.status})`);
89
+ const next = fn(cur);
90
+ await writeRun(next);
91
+ return next;
92
+ }
93
+ /**
94
+ * 実行中の run の扱い(回復・二重の開始の確かめ・取消・ログの書き足しと取消の要求の見つけ方・終わりの書き方)。
95
+ * local: このプロセスで動いている run の ID
96
+ */
97
+ export class RunControl {
98
+ store;
99
+ local;
100
+ probe;
101
+ onChange;
102
+ constructor(store, local, probe = systemProbe, onChange = () => undefined) {
103
+ this.store = store;
104
+ this.local = local;
105
+ this.probe = probe;
106
+ this.onChange = onChange;
107
+ }
108
+ ownerOf(r) {
109
+ if (this.local.has(r.id))
110
+ return { state: "local" };
111
+ return ownerState(r.owner, this.probe);
112
+ }
113
+ /** 死んだと確かめられた所有者の run を失敗(crashed)にする(ロックの中で呼ぶ) */
114
+ async recoverLocked(key) {
115
+ for (const id of await this.store.runIds(key)) {
116
+ const r = await this.store.readRun(key, id).catch(() => undefined);
117
+ if (r?.status !== "running" || this.local.has(r.id))
118
+ continue;
119
+ const o = this.ownerOf(r);
120
+ if (o.state !== "dead")
121
+ continue;
122
+ const fin = await this.store.finish(key, id, { status: "failed", failure: "crashed", error: `実行していたプロセスが途中で終わりました(${o.reason})` });
123
+ this.onChange(key, fin);
124
+ }
125
+ }
126
+ /** 実行中の run(回復した後に残るもの。ロックの中で呼ぶ) */
127
+ async runningLocked(key) {
128
+ await this.recoverLocked(key);
129
+ for (const id of await this.store.runIds(key)) {
130
+ const r = await this.store.readRun(key, id).catch(() => undefined);
131
+ if (r?.status === "running")
132
+ return { run: r, owner: this.ownerOf(r) };
133
+ }
134
+ return undefined;
135
+ }
136
+ /**
137
+ * 取り消す。このプロセスの run は abortLocal で止め、ほかのプロセスの run は要求を書く。
138
+ * acknowledgeStopped: 人が「実行しているプロセスは止まっている」と確かめた。所有者が分からない run を記録の上で中断にする
139
+ * (動いていると確かめられる所有者がいれば断る。ほかの環境のプロセスを止めたとは限らない)
140
+ */
141
+ async cancel(key, run, by, opts) {
142
+ const isLocal = this.local.has(run);
143
+ const out = await this.store.withLock(key, async () => {
144
+ const cur = await this.store.readRun(key, run);
145
+ if (cur.status !== "running")
146
+ throw new ReviewCancelRefused("finished", `${opts.label} は既に終わっています(${cur.status})`);
147
+ const o = this.ownerOf(cur);
148
+ if (opts.acknowledgeStopped && !isLocal) {
149
+ if (o.state === "alive")
150
+ throw new ReviewCancelRefused("owner_alive", `${opts.label} を実行しているプロセスは動いています。--acknowledge-stopped ではなく取消を使ってください`);
151
+ const fin = await this.store.finish(key, run, {
152
+ status: "cancelled",
153
+ abandoned: { at: new Date().toISOString(), ...(by ? { by } : {}) },
154
+ error: "人が中断しました(ほかの環境で動いているプロセスを止めたとは限りません)",
155
+ });
156
+ return { run: fin, requested: false };
157
+ }
158
+ if (o.state === "dead") {
159
+ const fin = await this.store.finish(key, run, { status: "failed", failure: "crashed", error: `実行していたプロセスが途中で終わりました(${o.reason})` });
160
+ return { run: fin, requested: false };
161
+ }
162
+ const next = await this.store.updateRunning(key, run, (r) => ({ ...r, cancelRequested: { at: new Date().toISOString(), ...(by ? { by } : {}) } }));
163
+ return { run: next, requested: true };
164
+ });
165
+ opts.abortLocal?.();
166
+ this.onChange(key, out.run);
167
+ return out;
168
+ }
169
+ /** ほかのプロセスからの取消の要求を見つけ、ログを run.json に書き足す(止めるときは返した関数を呼ぶ) */
170
+ watch(key, run, log, abort, pollMs = 1000) {
171
+ let flushed = 0;
172
+ const timer = setInterval(() => {
173
+ void this.store
174
+ .withLock(key, async () => {
175
+ const cur = await this.store.readRun(key, run);
176
+ if (cur.status !== "running")
177
+ return abort.abort(new Error("ended"));
178
+ if (cur.cancelRequested)
179
+ abort.abort(new Error("cancelled"));
180
+ if (log.length !== flushed) {
181
+ flushed = log.length;
182
+ await this.store.updateRunning(key, run, (r) => ({ ...r, log: [...log] }));
183
+ }
184
+ })
185
+ .catch(() => undefined);
186
+ }, pollMs);
187
+ timer.unref?.();
188
+ return () => clearInterval(timer);
189
+ }
190
+ /** 終わりを書く(ロックの中で、まだ実行中かを確かめてから)。既に終わっていれば遅れて届いた結果を取り込まず、今の記録を返す */
191
+ async end(key, run, end, result) {
192
+ try {
193
+ const fin = await this.store.withLock(key, () => this.store.finish(key, run, end, end.status === "completed" ? result : undefined));
194
+ this.onChange(key, fin);
195
+ return fin;
196
+ }
197
+ catch (e) {
198
+ if (!(e instanceof ReviewStoreError && e.code === "finished"))
199
+ throw e;
200
+ const cur = await this.store.readRun(key, run);
201
+ this.onChange(key, cur);
202
+ return cur;
203
+ }
204
+ }
205
+ }
@@ -0,0 +1,74 @@
1
+ import { readdir } from "node:fs/promises";
2
+ import { join } from "node:path";
3
+ import { REQUEST_ID, TASK_ID, taskId } from "../../shared/refs.js";
4
+ import { fileLayout, MarkdownCollection, NotFoundError } from "./collection.js";
5
+ import { normalizeTaskIn, TASK_DERIVED, TASK_KEY_ORDER } from "./normalize.js";
6
+ /**
7
+ * アーカイブしたタスク(requests/<要望ID>/tasks/.archive/<ID>.md)を読むだけの道。
8
+ *
9
+ * - 通常のタスクのコレクション(Workspace.tasksOf)・索引・変更通知には触れない。読むたびにディスクを読み、キャッシュしない
10
+ * - ファイル・rev・状態・採番の予約(collection.ts の reserved)を変えない
11
+ * - 明示した要望の中だけを読む。要望 ID・タスク ID の形を確かめ、ほかの場所は読ませない
12
+ * - 通常の一覧・進捗・対応済の判定・依存・レビューやリリースノートの材料はこれを使わない(docs/architecture.md「アーカイブしたタスク」)
13
+ */
14
+ /** アーカイブのフォルダかファイルを読めない(無いのではない) */
15
+ export class ArchivedTaskReadError extends Error {
16
+ code = "archive_unreadable";
17
+ }
18
+ /** 要望が無ければ NotFoundError。読めない要望(壊れた request.md)でもアーカイブは読める */
19
+ function requestDir(ws, rid) {
20
+ if (!REQUEST_ID.test(rid) || (!ws.requests.get(rid) && !ws.requests.errors.has(rid)))
21
+ throw new NotFoundError(rid);
22
+ return join(ws.requestsDir, rid, "tasks", ".archive");
23
+ }
24
+ function reader(ws, rid) {
25
+ return new MarkdownCollection({
26
+ layout: fileLayout(requestDir(ws, rid), TASK_ID, taskId),
27
+ normalize: normalizeTaskIn(rid),
28
+ keyOrder: TASK_KEY_ORDER,
29
+ derived: TASK_DERIVED,
30
+ });
31
+ }
32
+ const mark = (t) => ({ ...t, archived: true });
33
+ /** 要望のアーカイブの一覧(ID の数値順)。フォルダが無ければ空。フォルダを読めなければ ArchivedTaskReadError */
34
+ export async function listArchivedTasks(ws, rid) {
35
+ const dir = requestDir(ws, rid);
36
+ let names;
37
+ try {
38
+ names = await readdir(dir);
39
+ }
40
+ catch (e) {
41
+ if (e.code === "ENOENT")
42
+ return { request: rid, tasks: [], errors: [] };
43
+ throw new ArchivedTaskReadError(`${rid} のアーカイブを読めません: ${e.message}`);
44
+ }
45
+ const ids = names
46
+ .filter((f) => f.endsWith(".md"))
47
+ .map((f) => f.slice(0, -3))
48
+ .filter((id) => TASK_ID.test(id))
49
+ .sort((a, b) => a.localeCompare(b, undefined, { numeric: true }));
50
+ const col = reader(ws, rid);
51
+ const tasks = [];
52
+ const errors = [];
53
+ for (const id of ids) {
54
+ const r = await col.peek(id);
55
+ if ("item" in r)
56
+ tasks.push(mark(r.item));
57
+ else if ("error" in r)
58
+ errors.push({ id, error: r.error });
59
+ // 一覧を作る間に消えたものは出さない
60
+ }
61
+ return { request: rid, tasks, errors };
62
+ }
63
+ /** アーカイブの1件。無ければ NotFoundError(<要望ID>/<ID>)、読めなければ ArchivedTaskReadError */
64
+ export async function getArchivedTask(ws, rid, tid) {
65
+ const col = reader(ws, rid);
66
+ if (!TASK_ID.test(tid))
67
+ throw new NotFoundError(`${rid}/${tid}`);
68
+ const r = await col.peek(tid);
69
+ if ("item" in r)
70
+ return mark(r.item);
71
+ if ("missing" in r)
72
+ throw new NotFoundError(`${rid}/${tid}`);
73
+ throw new ArchivedTaskReadError(`${rid}/${tid} のアーカイブを読めません: ${r.error}`);
74
+ }
@@ -100,6 +100,9 @@ export class MarkdownCollection {
100
100
  const item = this.opts.normalize(data, body, id);
101
101
  const known = new Set(["body", ...this.opts.keyOrder, ...(this.opts.derived ?? []), ...Object.keys(item)]);
102
102
  const extra = Object.fromEntries(Object.entries(data).filter(([k]) => !known.has(k)));
103
+ for (const k of this.opts.keepRaw?.(item) ?? [])
104
+ if (k in data)
105
+ extra[k] = data[k];
103
106
  return { item, extra };
104
107
  }
105
108
  catch (e) {
@@ -151,9 +154,10 @@ export class MarkdownCollection {
151
154
  const { body, ...rest } = item;
152
155
  const skip = new Set(["body", ...(this.opts.derived ?? [])]);
153
156
  const ordered = {};
157
+ // extra に知っているキーがあるのは keepRaw のとき(元の値のまま書く)
154
158
  for (const k of this.opts.keyOrder)
155
159
  if (!skip.has(k))
156
- ordered[k] = rest[k];
160
+ ordered[k] = k in extra ? extra[k] : rest[k];
157
161
  for (const [k, v] of Object.entries(rest))
158
162
  if (!(k in ordered) && !skip.has(k))
159
163
  ordered[k] = v;
@@ -196,17 +200,23 @@ export class MarkdownCollection {
196
200
  }
197
201
  /**
198
202
  * 部分更新。expectedRev を渡すと楽観ロック(AI が古い状態を元に上書きするのを防ぐ)。
203
+ * patch に関数を渡すと、直前に読み直した今の値から patch を作る(基準の操作のように、今の値に当てる変更)。関数が投げたら書かない
199
204
  */
200
205
  async update(id, patch, opts = {}) {
201
206
  // 外部での編集を取りこぼさないよう、更新の直前にディスクから読み直す。
202
207
  // この版が知らない項目(新しい版の p3 が書いた項目)は消さずに書き戻す(古い版の更新で親子などが消えないように)
203
208
  const r = await this.read(id);
204
209
  this.apply(id, r);
205
- const extra = "item" in r ? r.extra : {};
210
+ const extra = "item" in r ? { ...r.extra } : {};
206
211
  const cur = this.require(id);
207
212
  if (opts.expectedRev !== undefined && opts.expectedRev !== cur.rev) {
208
213
  throw new ConflictError(id, opts.expectedRev, cur.rev);
209
214
  }
215
+ if (typeof patch === "function")
216
+ patch = patch(cur);
217
+ // patch で書き換えるキーは、元の値を残す対象(keepRaw・知らない項目)から外す
218
+ for (const k of Object.keys(patch))
219
+ delete extra[k];
210
220
  const merged = {
211
221
  ...cur,
212
222
  ...patch,
@@ -1,3 +1,6 @@
1
+ import { ACCEPTANCE_KEYS, readAcceptance } from "../../shared/acceptance.js";
2
+ import { BLOCK_KEYS, readBlock } from "../../shared/taskBlock.js";
3
+ import { qualityVersion, readQuality } from "../../shared/quality.js";
1
4
  import { repoNameProblem } from "../../shared/repos.js";
2
5
  import { isPreflightRunner } from "../../shared/preflightRunner.js";
3
6
  import { isTaskStatus, RELATION_TYPES, REQUEST_STATUSES } from "../../shared/types.js";
@@ -38,6 +41,8 @@ export const normalizeTaskIn = (requestId) => (d, body, id) => ({
38
41
  doneAt: d.doneAt ? iso(d.doneAt) : undefined,
39
42
  checkedAt: d.checkedAt ? iso(d.checkedAt) : undefined,
40
43
  record: str(d.record)?.trim() || undefined,
44
+ ...readAcceptance(d),
45
+ ...readBlock(d),
41
46
  relations: normalizeRelations(d.relations),
42
47
  rev: num(d.rev) ?? 1,
43
48
  createdAt: iso(d.createdAt),
@@ -45,9 +50,13 @@ export const normalizeTaskIn = (requestId) => (d, body, id) => ({
45
50
  updatedBy: str(d.updatedBy),
46
51
  body,
47
52
  });
53
+ /** タスクのうちファイルに書かないキー(場所から決まるもの・読んだときの問題) */
54
+ export const TASK_DERIVED = ["request", "ref", "acceptanceProblems", "blockProblems"];
55
+ /** 基準・証拠が壊れていたら、関係のない更新ではファイルの元の値のまま書き戻す(shared/acceptance.ts) */
56
+ export const taskKeepRaw = (t) => [...(t.acceptanceProblems?.length ? ACCEPTANCE_KEYS : []), ...(t.blockProblems?.length ? BLOCK_KEYS : [])];
48
57
  export const TASK_KEY_ORDER = [
49
58
  "id", "title", "status", "repo", "labels", "areas", "outputs", "repoOutputs", "record",
50
- "relations", "rev", "createdAt", "startedAt", "doneAt", "checkedAt", "updatedAt", "updatedBy",
59
+ "acceptanceCriteria", "acceptanceEvidence", "acceptanceSeq", "block", "blockHistory", "relations", "rev", "createdAt", "startedAt", "doneAt", "checkedAt", "updatedAt", "updatedBy",
51
60
  ];
52
61
  export function normalizeRequest(d, body, id) {
53
62
  const status = str(d.status);
@@ -123,8 +132,14 @@ export function normalizeProject(d) {
123
132
  : [],
124
133
  branchPattern: str(d.branchPattern) ?? "req/{id}-{slug}",
125
134
  preflight: { instructions: str(preflight.instructions) ?? "", ...runnerOf(preflight.runner) },
135
+ ...qualityOf(d.quality, normalizeRepos(d.repos).map((r) => r.name)),
126
136
  };
127
137
  }
138
+ /** 品質基準(無い・読めない・読めるを分ける。読めない値もそのまま版に入れ、書き換えない) */
139
+ function qualityOf(raw, repoNames) {
140
+ const quality = readQuality(raw, repoNames);
141
+ return { quality, qualityVersion: qualityVersion(quality, raw) };
142
+ }
128
143
  /**
129
144
  * project.yaml の repos。名前をキーにした対応(推奨)か、name を持つ項目の並び。名前が使えない項目・重複は読まない
130
145
  * (書き戻すときも p3 repo で変えた項目のほかは触らないので、ファイルからは消えない)。
@@ -1,6 +1,12 @@
1
1
  import { readdir, readFile, mkdir, rm, stat } from "node:fs/promises";
2
2
  import { join } from "node:path";
3
+ import { readDraftCriteria } from "../../shared/acceptance.js";
3
4
  import { parseFrontmatter, stringifyFrontmatter } from "./frontmatter.js";
5
+ /** 案の受け入れ基準(無い古い案は何も足さない。読めない項目は acceptanceProblems に理由) */
6
+ function draftCriteriaOf(raw) {
7
+ const { criteria, problems } = readDraftCriteria(raw);
8
+ return { ...(criteria ? { acceptanceCriteria: criteria } : {}), ...(problems ? { acceptanceProblems: problems } : {}) };
9
+ }
4
10
  import { writeFileAtomic } from "./fsutil.js";
5
11
  /**
6
12
  * requests/<要望ID>/preflight/<RUN-ID>/
@@ -32,7 +38,8 @@ export class PreflightStore {
32
38
  await this.saveDraft(requestId, runId, d);
33
39
  }
34
40
  async saveDraft(requestId, runId, d) {
35
- const { description, ...meta } = d;
41
+ // 基準が読めない理由は書かない(読むたびに決まる)
42
+ const { description, acceptanceProblems: _p, ...meta } = d;
36
43
  await writeFileAtomic(join(this.runDir(requestId, runId), "drafts", `${d.key}.md`), stringifyFrontmatter({ ...meta, include: d.include }, description));
37
44
  }
38
45
  async loadDrafts(requestId, runId) {
@@ -50,6 +57,7 @@ export class PreflightStore {
50
57
  supersedes: Array.isArray(data.supersedes) ? data.supersedes.map(String) : [],
51
58
  include: data.include !== false,
52
59
  ...("repo" in data ? { repo: data.repo === null || data.repo === "" || data.repo === "none" ? null : String(data.repo) } : {}),
60
+ ...draftCriteriaOf(data.acceptanceCriteria),
53
61
  });
54
62
  }
55
63
  return drafts.sort((a, b) => a.key.localeCompare(b.key, undefined, { numeric: true }));
@@ -109,3 +109,13 @@ export async function writeRepoEntry(path, name, entry) {
109
109
  sortKeys(doc);
110
110
  await writeFileAtomic(path, doc.toString({ lineWidth: 0 }));
111
111
  }
112
+ /**
113
+ * project.yaml の quality だけを書き換える(ほかの項目・コメントは残す)。plain は qualityPlain の形。
114
+ * ロックと版の照合は呼ぶ側(Workspace.writeQuality)
115
+ */
116
+ export async function writeQualityFile(path, plain) {
117
+ const text = await readFile(path, "utf8").catch(() => "");
118
+ const doc = text.trim() ? YAML.parseDocument(text) : new YAML.Document({});
119
+ doc.set("quality", doc.createNode(plain));
120
+ await writeFileAtomic(path, doc.toString({ lineWidth: 0 }));
121
+ }
@@ -4,17 +4,19 @@ import { join } from "node:path";
4
4
  import YAML from "yaml";
5
5
  import { parseRef, REQUEST_ID, TASK_ID, taskId } from "../../shared/refs.js";
6
6
  import { milestoneGoalProblems, tidyMilestoneGoals } from "../../shared/milestoneGoals.js";
7
+ import { QualityInputError, qualityPlain } from "../../shared/quality.js";
7
8
  import { fileLayout, folderLayout, MarkdownCollection, NotFoundError } from "./collection.js";
8
9
  import { newRequestId, withFileLock } from "./fsutil.js";
9
- import { normalizeProject, normalizeRequest, normalizeTaskIn, REQUEST_KEY_ORDER, TASK_KEY_ORDER } from "./normalize.js";
10
+ import { normalizeProject, normalizeRequest, normalizeTaskIn, REQUEST_KEY_ORDER, TASK_DERIVED, TASK_KEY_ORDER, taskKeepRaw } from "./normalize.js";
10
11
  import { AttachmentStore } from "./attachments.js";
11
12
  import { DataWatcher } from "./dataWatcher.js";
12
13
  import { NoteStore } from "./noteStore.js";
13
14
  import { PreflightStore } from "./preflightStore.js";
14
- import { writeProjectFile } from "./projectFile.js";
15
+ import { writeProjectFile, writeQualityFile } from "./projectFile.js";
15
16
  import { resolveRefs } from "../repoRefs.js";
16
17
  import { RELEASE_NOTES_DIR, ReleaseNoteStore } from "../releaseNotes/store.js";
17
18
  import { MILESTONE_REVIEWS_DIR, MilestoneReviewStore } from "../milestoneReview/store.js";
19
+ import { TASK_REVIEWS_DIR, TaskReviewStore } from "../taskReview/store.js";
18
20
  /** 保存する並びの各項目で、purpose / goals のキーが無ければ同じ ID の今の値を残す */
19
21
  function keepGoals(next, cur) {
20
22
  return next.map((m) => {
@@ -78,6 +80,8 @@ export class Workspace {
78
80
  releaseNotes;
79
81
  /** マイルストーンレビューの履歴(milestoneReview/store.ts) */
80
82
  milestoneReviews;
83
+ /** タスクの AI レビューの履歴(requests/<要望ID>/task-reviews/) */
84
+ taskReviews;
81
85
  taskCollections = new Map();
82
86
  listeners = new Set();
83
87
  watcher;
@@ -96,6 +100,7 @@ export class Workspace {
96
100
  this.attachments = new AttachmentStore(this.requestsDir);
97
101
  this.releaseNotes = new ReleaseNoteStore(dataDir);
98
102
  this.milestoneReviews = new MilestoneReviewStore(dataDir);
103
+ this.taskReviews = new TaskReviewStore(this.requestsDir);
99
104
  }
100
105
  get requestsDir() {
101
106
  return join(this.dataDir, "requests");
@@ -204,7 +209,8 @@ export class Workspace {
204
209
  layout: fileLayout(join(this.requestsDir, requestId, "tasks"), TASK_ID, taskId),
205
210
  normalize: normalizeTaskIn(requestId),
206
211
  keyOrder: TASK_KEY_ORDER,
207
- derived: ["request", "ref"],
212
+ derived: TASK_DERIVED,
213
+ keepRaw: taskKeepRaw,
208
214
  beforeWrite: (prev, next) => stampStatus(prev, next),
209
215
  });
210
216
  this.taskCollections.set(requestId, col);
@@ -266,6 +272,24 @@ export class Workspace {
266
272
  return { ...cur, ...patch, milestones, preflight };
267
273
  }, opts);
268
274
  }
275
+ /**
276
+ * 品質基準を、ロックの中で読み直した最新の値から作り直して書く(project.yaml の quality だけ)。expectedVersion が今の版と違えば
277
+ * QualityInputError(quality_conflict)で何も書かない。make が投げたら何も書かない
278
+ */
279
+ async writeQuality(make, opts = {}) {
280
+ const path = join(this.dataDir, "project.yaml");
281
+ await withFileLock(join(this.dataDir, ".project.yaml.lock"), async () => {
282
+ await this.loadProject();
283
+ const now = this.project.qualityVersion;
284
+ if (opts.expectedVersion !== undefined && opts.expectedVersion !== now) {
285
+ throw new QualityInputError("quality_conflict", `品質基準が他で変わりました(版 ${opts.expectedVersion} → ${now})。最新を読み直してからやり直してください`);
286
+ }
287
+ await writeQualityFile(path, qualityPlain(make(this.project)));
288
+ await this.loadProject();
289
+ });
290
+ this.emit({ type: "changed", kind: "project" });
291
+ return this.project;
292
+ }
269
293
  /**
270
294
  * マイルストーンを、ロックの中で読んだ最新の並びから作り直して書く(CLI の milestone の操作。指定した項目のほかを巻き戻さない)。
271
295
  * fn が投げたら何も書かない
@@ -349,6 +373,12 @@ export class Workspace {
349
373
  }
350
374
  if (top !== "requests" || !rid || !REQUEST_ID.test(rid))
351
375
  return;
376
+ if (kind === TASK_REVIEWS_DIR) {
377
+ // タスクのレビューの履歴(ほかのプロセスの実行・取消)。ロックのフォルダ .locks は除く
378
+ if (file && !file.startsWith("."))
379
+ this.emit({ type: "task-review", request: rid, task: file });
380
+ return;
381
+ }
352
382
  if (kind === undefined || kind === "request.md") {
353
383
  // 要望の作成・削除(git pull でフォルダごと増減することもある)
354
384
  const known = !!this.requests.get(rid);