@infodb/p3 0.11.0 → 0.12.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (101) hide show
  1. package/README.md +4 -1
  2. package/dist/web/assets/ImprovementDialog-kQaVBGWH.js +1 -0
  3. package/dist/web/assets/Outputs-_nU_p3nu.js +1 -0
  4. package/dist/web/assets/{RequestStatus-Bg1OLbRc.js → RequestStatus-RG-OVQYY.js} +1 -1
  5. package/dist/web/assets/{Tabs-DTmggzgg.js → Tabs-ew9i5SKX.js} +1 -1
  6. package/dist/web/assets/TagInput-BtlJTF7i.js +1 -0
  7. package/dist/web/assets/TaskDrawer-DW8GyJqI.js +6 -0
  8. package/dist/web/assets/_requestId-6Nb727dD.js +1 -0
  9. package/dist/web/assets/_requestId-BykTgPax.js +1 -0
  10. package/dist/web/assets/appCtx-CxDdXABS.js +1 -0
  11. package/dist/web/assets/archive-Ckh295Xe.js +1 -0
  12. package/dist/web/assets/board-BVAIjK-Y.js +1 -0
  13. package/dist/web/assets/done-BGfA-3MA.js +1 -0
  14. package/dist/web/assets/index-CgRU744I.css +2 -0
  15. package/dist/web/assets/index-DacQ0yl4.js +12 -0
  16. package/dist/web/assets/{new-9TKiNT4O.js → new-DVygWvVc.js} +1 -1
  17. package/dist/web/assets/outputs-B6xDsLZf.js +1 -0
  18. package/dist/web/assets/preload-helper-DyCqp21K.js +1 -0
  19. package/dist/web/assets/quality-Pu6EISAM.js +1 -0
  20. package/dist/web/assets/release-notes-CCpzyiNf.js +5 -0
  21. package/dist/web/assets/requestData-D5vBnuMh.js +1 -0
  22. package/dist/web/assets/routes-Q91zvNc0.js +4 -0
  23. package/dist/web/assets/settings-BzRgcmUm.js +1 -0
  24. package/dist/web/assets/taskReview-_WCgnQit.js +1 -0
  25. package/dist/web/assets/workTarget-C9c57JAO.js +30 -0
  26. package/dist/web/index.html +4 -4
  27. package/docs/architecture.md +315 -2
  28. package/docs/development.md +1 -1
  29. package/docs/how-to-use.md +184 -0
  30. package/docs/installation.md +5 -5
  31. package/lib/cli/args.js +45 -0
  32. package/lib/cli/help.js +36 -1
  33. package/lib/cli/main.js +27 -3
  34. package/lib/cli/output.js +9 -1
  35. package/lib/cli/preflightCommands.js +7 -1
  36. package/lib/cli/project.js +3 -0
  37. package/lib/cli/qualityCommands.js +163 -0
  38. package/lib/cli/readOnly.js +2 -0
  39. package/lib/cli/requestCommands.js +12 -0
  40. package/lib/cli/showView.js +69 -3
  41. package/lib/cli/taskCommands.js +312 -17
  42. package/lib/cli/taskReviewCommands.js +178 -0
  43. package/lib/core/context.js +4 -1
  44. package/lib/core/milestoneReview/material.js +11 -1
  45. package/lib/core/milestoneReview/mockReviewer.js +1 -0
  46. package/lib/core/milestoneReview/review.js +70 -6
  47. package/lib/core/milestoneReview/service.js +29 -93
  48. package/lib/core/milestoneReview/store.js +12 -62
  49. package/lib/core/ops.js +9 -2
  50. package/lib/core/preflight/carryover.js +1 -1
  51. package/lib/core/preflight/engine.js +6 -0
  52. package/lib/core/preflight/instructions.js +18 -1
  53. package/lib/core/preflight/mockEngine.js +4 -0
  54. package/lib/core/preflight/service.js +45 -4
  55. package/lib/core/projectRegistry.js +3 -3
  56. package/lib/core/quality.js +21 -0
  57. package/lib/core/qualityImprovement.js +221 -0
  58. package/lib/core/requestOps.js +97 -6
  59. package/lib/core/reviewRuns.js +205 -0
  60. package/lib/core/store/archivedTasks.js +74 -0
  61. package/lib/core/store/collection.js +12 -2
  62. package/lib/core/store/normalize.js +16 -1
  63. package/lib/core/store/preflightStore.js +9 -1
  64. package/lib/core/store/projectFile.js +10 -0
  65. package/lib/core/store/workspace.js +33 -3
  66. package/lib/core/taskReview/material.js +452 -0
  67. package/lib/core/taskReview/mockReviewer.js +30 -0
  68. package/lib/core/taskReview/paths.js +15 -0
  69. package/lib/core/taskReview/review.js +305 -0
  70. package/lib/core/taskReview/service.js +187 -0
  71. package/lib/core/taskReview/store.js +214 -0
  72. package/lib/server/api/manifest.js +55 -4
  73. package/lib/server/api/milestoneReviewRoutes.js +4 -3
  74. package/lib/server/api/routes.js +145 -17
  75. package/lib/server/api/taskReviewRoutes.js +66 -0
  76. package/lib/server/server.js +2 -2
  77. package/lib/shared/acceptance.js +378 -0
  78. package/lib/shared/milestoneReview.js +2 -1
  79. package/lib/shared/quality.js +391 -0
  80. package/lib/shared/qualityImprovement.js +1 -0
  81. package/lib/shared/qualityTemplates.js +31 -0
  82. package/lib/shared/taskBlock.js +142 -0
  83. package/lib/shared/taskReview.js +56 -0
  84. package/package.json +1 -1
  85. package/skills/p3/SKILL.md +31 -2
  86. package/dist/web/assets/Outputs-ddwte0jj.js +0 -1
  87. package/dist/web/assets/TagInput-BHAgjLP7.js +0 -1
  88. package/dist/web/assets/TaskDrawer-Dz_5c2NH.js +0 -3
  89. package/dist/web/assets/_requestId-D9-gtIcG.js +0 -1
  90. package/dist/web/assets/_requestId-DzCNYvqf.js +0 -30
  91. package/dist/web/assets/appCtx-Cm24VpAf.js +0 -1
  92. package/dist/web/assets/board-MCHcZ-PU.js +0 -1
  93. package/dist/web/assets/done-zq10Bt08.js +0 -1
  94. package/dist/web/assets/index-Ce0ndpne.js +0 -12
  95. package/dist/web/assets/index-D68mkSnw.css +0 -2
  96. package/dist/web/assets/preload-helper-FBLw7u7x.js +0 -1
  97. package/dist/web/assets/release-notes-hK5XezLW.js +0 -5
  98. package/dist/web/assets/requestData-BnN7mctX.js +0 -1
  99. package/dist/web/assets/routes-usHwrrA0.js +0 -3
  100. package/dist/web/assets/settings-BVZDnL6O.js +0 -1
  101. package/dist/web/assets/workTarget-Cijqq4yH.js +0 -1
@@ -4,6 +4,8 @@ import { isAbsolute, join, relative } from "node:path";
4
4
  import { createHash, randomBytes } from "node:crypto";
5
5
  import {} from "../../shared/types.js";
6
6
  import { normalizeTaskId, REQUEST_ID } from "../../shared/refs.js";
7
+ import { AcceptanceInputError, applyAcceptanceOps, criteriaForTask, sameCriteria, tidyDraftCriteria } from "../../shared/acceptance.js";
8
+ import { qualityCriteria, qualitySnapshot } from "../../shared/quality.js";
7
9
  import { newRequestId, nowIso, withFileLock, writeFileAtomic } from "../store/fsutil.js";
8
10
  import { ConflictError, NotFoundError } from "../store/collection.js";
9
11
  import { supersedeCandidates } from "../supersede.js";
@@ -33,11 +35,11 @@ const failing = (name, message) => ({
33
35
  /** 同じ要望の Preflight が実行中(エンジンを使えないのとは別) */
34
36
  export class PreflightBusyError extends Error {
35
37
  }
36
- /** タスク案の題が、編集を始めたあとに外で変わった(409 code: rev_conflict。current に今の案) */
38
+ /** タスク案の題か受け入れ基準が、編集を始めたあとに外で変わった(409 code: rev_conflict。current に今の案) */
37
39
  export class DraftConflictError extends Error {
38
40
  current;
39
- constructor(current) {
40
- super(`${current.key} の題が他で変わりました(今の題: ${current.title})`);
41
+ constructor(current, what = "title") {
42
+ super(what === "title" ? `${current.key} の題が他で変わりました(今の題: ${current.title})` : `${current.key} の受け入れ基準が他で変わりました(読み直してから直してください)`);
41
43
  this.current = current;
42
44
  }
43
45
  }
@@ -481,6 +483,8 @@ export class PreflightService {
481
483
  ui: { status: "generating", targets: [], items: [], problems: [] },
482
484
  input,
483
485
  before: request.status,
486
+ // 品質基準も始めるときに固定する(実行中に設定が変わっても、評価とタスク化はこの版を使う)
487
+ quality: qualitySnapshot(this.ws.project.quality, this.ws.project.qualityVersion),
484
488
  };
485
489
  // 実行しているプロセスの記録(codex / mock)。手元のエージェントの run はプロセスを跨いで待つので記録しない
486
490
  const owner = engine === "local" ? undefined : currentOwner();
@@ -549,6 +553,7 @@ export class PreflightService {
549
553
  runDir: o.runDir,
550
554
  carryover: o.carried,
551
555
  attachments: o.run.attachments ?? [],
556
+ ...(o.run.quality ? { quality: o.run.quality } : {}),
552
557
  ...o.family,
553
558
  };
554
559
  }
@@ -633,6 +638,10 @@ export class PreflightService {
633
638
  async ingest(run, runDir, refs) {
634
639
  run.assessment = parseAssessment(await readFile(join(runDir, "assessment.json"), "utf8"), refs);
635
640
  run.drafts = await this.ws.preflight.loadDrafts(run.requestId, run.id);
641
+ // 読めない受け入れ基準は案に残し(その案はタスク化できない)、人が直せるよう知らせる
642
+ for (const d of run.drafts)
643
+ for (const p of d.acceptanceProblems ?? [])
644
+ this.log(run, { kind: "error", text: `${d.key} の受け入れ基準を読めません(案の詳細で直してください): ${p}` });
636
645
  // 子の案(分割の run): 確かめて、問題があれば残す(採用しない)
637
646
  const children = await this.ws.preflight.loadChildren(run.requestId, run.id);
638
647
  if (children) {
@@ -804,10 +813,21 @@ export class PreflightService {
804
813
  throw new Error(`${runId}/${key} not found`);
805
814
  if (opts.expectedTitle !== undefined && draft.title !== opts.expectedTitle)
806
815
  throw new DraftConflictError(draft);
816
+ // 基準を変えるときは、編集を始めたときの基準と今の基準を比べる(同じ題のまま他で基準が変わっても上書きしない)
817
+ if (opts.expectedCriteria !== undefined && !sameCriteria(draft.acceptanceCriteria, opts.expectedCriteria))
818
+ throw new DraftConflictError(draft, "criteria");
807
819
  // 作業先は作業先にできる参照先だけ(変える前に断る)
808
820
  if ("repo" in patch)
809
821
  checkRepoTarget(this.ws, patch.repo);
810
- const next = { ...draft, ...patch, key };
822
+ // 基準は並び全体の置き換え(id は残し、無い項目に振る。空の並びは基準なし)。直せば読めなかった理由も消える
823
+ const { acceptanceCriteria: rawCriteria, acceptanceProblems: _p, ...rest } = patch;
824
+ const criteria = rawCriteria !== undefined ? tidyDraftCriteria(rawCriteria) : undefined;
825
+ const next = {
826
+ ...draft,
827
+ ...rest,
828
+ key,
829
+ ...(rawCriteria !== undefined ? { acceptanceCriteria: criteria.length ? criteria : undefined, acceptanceProblems: undefined } : {}),
830
+ };
811
831
  await this.ws.preflight.saveDraft(requestId, runId, next);
812
832
  return next;
813
833
  }
@@ -1032,6 +1052,12 @@ export class PreflightService {
1032
1052
  const drafts = resuming ? run.drafts.filter((d) => d.key in run.materialization.created || d.include) : run.drafts.filter((d) => d.include);
1033
1053
  if (!drafts.length)
1034
1054
  throw new Error("採用したタスク案がありません");
1055
+ // 基準が読めない案はタスク化しない(まだ作っていない案だけ。直してからやり直す)
1056
+ const unreadable = drafts.filter((d) => d.acceptanceProblems?.length && !(resuming && d.key in run.materialization.created));
1057
+ if (unreadable.length) {
1058
+ throw new AcceptanceInputError(`受け入れ基準が読めないタスク案があります。直してからタスク化してください(p3 criteria <D> --req ${requestId} --run ${runId}、画面の案の詳細): ` +
1059
+ unreadable.map((d) => `${d.key}: ${d.acceptanceProblems.join(" / ")}`).join("; "));
1060
+ }
1035
1061
  // 作業先: 手で直した案も、変える前に確かめる。割り当てるブランチもここで決めて run に残す(やり直しでも同じ)
1036
1062
  for (const d of drafts)
1037
1063
  checkRepoTarget(this.ws, d.repo);
@@ -1075,6 +1101,8 @@ export class PreflightService {
1075
1101
  areas: d.areas,
1076
1102
  outputs: [],
1077
1103
  relations: supersedes(d),
1104
+ // 案の受け入れ基準を ID ごと写し、作業先に当てはまる品質基準(始めたときの版)を出典つきで足す(採用した案だけ。やり直しで作ったタスクは上書きしない)
1105
+ ...withQuality(criteriaForTask(d.acceptanceCriteria), run.quality, draftRepo(d)),
1078
1106
  body: `${d.description}\n\n${marker}`,
1079
1107
  }, actor));
1080
1108
  if (state.created[d.key] !== t.id) {
@@ -1212,9 +1240,22 @@ async function localProblems(ws, run, runDir) {
1212
1240
  const repo = repoTargetProblem(d.repo, ws.project);
1213
1241
  if (repo)
1214
1242
  problems.push(`${d.key}: ${repo}`);
1243
+ for (const p of d.acceptanceProblems ?? [])
1244
+ problems.push(`${d.key}: ${p}`);
1215
1245
  }
1216
1246
  return problems;
1217
1247
  }
1248
+ /**
1249
+ * 案の基準に、作業先に当てはまる品質基準を足す(作業先なしの案には足さない。同じ品質 ID は二重に足さない。上限を超えれば断る)
1250
+ */
1251
+ function withQuality(state, q, repo) {
1252
+ if (q?.state !== "set" || !repo)
1253
+ return state;
1254
+ const add = qualityCriteria({ standards: q.standards ?? [] }, q.version, { repo }).filter((c) => !(state.acceptanceCriteria ?? []).some((x) => x.quality?.id === c.quality.id));
1255
+ if (!add.length)
1256
+ return state;
1257
+ return applyAcceptanceOps(state, add.map((c) => ({ op: "add", text: c.text, quality: c.quality })), { now: new Date().toISOString() });
1258
+ }
1218
1259
  /** 固定した添付の画像を、現状(添付)の画面資料として足す(対象のタスク案は無し) */
1219
1260
  function withCurrent(ui, run) {
1220
1261
  const current = (run.attachments ?? [])
@@ -110,7 +110,7 @@ export class ProjectRegistry {
110
110
  e.ctx = undefined;
111
111
  const settle = Promise.all([
112
112
  ...all.map(async (ctx) => {
113
- await Promise.all([ctx.preflight.settle({ cancel: true }), ctx.releaseGenerator.settle({ cancel: true }), ctx.milestoneReview.settle({ cancel: true })]);
113
+ await Promise.all([ctx.preflight.settle({ cancel: true }), ctx.releaseGenerator.settle({ cancel: true }), ctx.milestoneReview.settle({ cancel: true }), ctx.taskReview.settle({ cancel: true })]);
114
114
  ctx.ws.close();
115
115
  }),
116
116
  ...this.retiring,
@@ -118,7 +118,7 @@ export class ProjectRegistry {
118
118
  const timedOut = await Promise.race([settle, new Promise((r) => setTimeout(() => r(true), opts.timeoutMs ?? 10_000).unref())]);
119
119
  for (const ctx of all)
120
120
  ctx.ws.close();
121
- return { pending: timedOut ? all.reduce((n, c) => n + c.preflight.running() + c.releaseGenerator.running() + c.milestoneReview.running(), 0) : 0 };
121
+ return { pending: timedOut ? all.reduce((n, c) => n + c.preflight.running() + c.releaseGenerator.running() + c.milestoneReview.running() + c.taskReview.running(), 0) : 0 };
122
122
  }
123
123
  async load() {
124
124
  let projects;
@@ -171,7 +171,7 @@ export class ProjectRegistry {
171
171
  void e.ctx?.then((ctx) => this.retire(ctx), () => undefined);
172
172
  }
173
173
  retire(ctx) {
174
- const p = Promise.all([ctx.preflight.settle(), ctx.releaseGenerator.settle(), ctx.milestoneReview.settle()]).then(() => ctx.ws.close());
174
+ const p = Promise.all([ctx.preflight.settle(), ctx.releaseGenerator.settle(), ctx.milestoneReview.settle(), ctx.taskReview.settle()]).then(() => ctx.ws.close());
175
175
  this.retiring.add(p);
176
176
  void p.finally(() => this.retiring.delete(p));
177
177
  }
@@ -0,0 +1,21 @@
1
+ import { applyQualityOps, templateDiffs } from "../shared/quality.js";
2
+ import { QUALITY_TEMPLATES } from "../shared/qualityTemplates.js";
3
+ export function qualityView(ws, templates = QUALITY_TEMPLATES) {
4
+ const quality = ws.project.quality ?? { state: "unset" };
5
+ return {
6
+ quality,
7
+ version: ws.project.qualityVersion ?? "",
8
+ diffs: quality.state === "set" ? templateDiffs(quality.config, templates) : [],
9
+ templates: templates.map((t) => ({ id: t.id, version: t.version, title: t.title, description: t.description, items: t.items.length })),
10
+ };
11
+ }
12
+ export function qualityTemplate(id, version, templates = QUALITY_TEMPLATES) {
13
+ const list = templates.filter((t) => t.id === id && (version === undefined || t.version === version));
14
+ return list.sort((a, b) => b.version - a.version)[0];
15
+ }
16
+ /** 操作を当てて保存する(expectedVersion: 編集を始めたときの版) */
17
+ export async function updateQuality(ws, ops, opts = {}) {
18
+ const templates = opts.templates ?? QUALITY_TEMPLATES;
19
+ await ws.writeQuality((cur) => applyQualityOps(cur.quality ?? { state: "unset" }, ops, { repoNames: cur.repos.map((r) => r.name), templates }), { expectedVersion: opts.expectedVersion });
20
+ return qualityView(ws, templates);
21
+ }
@@ -0,0 +1,221 @@
1
+ import { createHash, randomBytes } from "node:crypto";
2
+ import { readFile } from "node:fs/promises";
3
+ import { join } from "node:path";
4
+ import { checkLine } from "../shared/quality.js";
5
+ import { createRequest } from "./requestOps.js";
6
+ import { withFileLock, writeFileAtomic } from "./store/fsutil.js";
7
+ /**
8
+ * 品質の不足から改善要望を作る(CLI の p3 quality improve・API の /quality/improvements)。
9
+ *
10
+ * - 診断: 品質基準の設定(未設定・読めない・除外)、タスクのレビュー・マイルストーンレビューの1回分(違反・判断できない・除外)から、
11
+ * 不足を区別して出す(読むだけ)。検査が未実行だから未導入とは判定しない(判断できないのまま)。除外は不足に数えず、選べるだけ
12
+ * - 原稿: 人が選んだ不足だけで要望の題と本文の案を作る(品質 ID・版・元の run・指摘・根拠・目指す差・完了条件の案)。原稿は資料で、
13
+ * 中の文の指示は実行しない。表示・編集だけでは何も書かない
14
+ * - 登録: 明示したときだけ既存の createRequest で作る。登録の直前に診断の版(hash)を照らし、変わっていれば確かめ直してもらう
15
+ * - 重複と回復: 不足ごとの鍵(品質 ID・対象・不足の種類。run の違いでは増えない)と登録先を <data>/quality-improvements.json に残す。
16
+ * ロックの中で、先に予約(token)を書いてから、token のタグを付けた要望を作り、最後に登録先を書く。途中で落ちても、次の登録で
17
+ * タグから要望を見つけて台帳を直す(孤立・重複を残さない)。開いている登録先があれば案内し、閉じた要望からの作り直しは明示させる
18
+ */
19
+ export class ImprovementError extends Error {
20
+ code;
21
+ existing;
22
+ constructor(code, message, existing) {
23
+ super(message);
24
+ this.code = code;
25
+ this.existing = existing;
26
+ }
27
+ }
28
+ const KIND_LABEL = { unset: "品質基準が未設定", invalid: "品質基準が読めない", violated: "レビューで確かめた違反", undetermined: "レビューで判断できなかった", exempt: "理由つきの除外" };
29
+ function hashOf(source, findings) {
30
+ return createHash("sha256").update(JSON.stringify([source, findings.map((f) => [f.key, f.kind, f.version, f.reason, f.evidence])])).digest("hex").slice(0, 16);
31
+ }
32
+ /** 診断(読むだけ) */
33
+ export async function diagnoseQuality(ctx, source) {
34
+ const ws = ctx.ws;
35
+ const findings = [];
36
+ const notes = [];
37
+ const pushSettings = (state, version, problems) => {
38
+ if (state === "unset")
39
+ findings.push({ key: "quality:unset", kind: "unset", version, target: "project", reason: "プロジェクトの品質基準が未設定です(初めて作ったときの状態に任せています)", evidence: ["project.yaml"], suggested: true });
40
+ if (state === "invalid")
41
+ findings.push({ key: "quality:invalid", kind: "invalid", version, target: "project", reason: `project.yaml の品質基準が読めません: ${(problems ?? []).join(" / ")}`, evidence: ["project.yaml"], suggested: true });
42
+ };
43
+ if (source.type === "project") {
44
+ const q = ws.project.quality ?? { state: "unset" };
45
+ const version = ws.project.qualityVersion ?? "";
46
+ pushSettings(q.state, version, q.state === "invalid" ? q.problems : undefined);
47
+ if (q.state === "set") {
48
+ for (const s of q.config.standards.filter((x) => x.exempt)) {
49
+ findings.push({ key: `${s.id}:project:exempt`, kind: "exempt", quality: s.id, qualityText: s.text, check: checkLine(s.check), version, target: "project", reason: `適用から除外しています: ${s.exempt.reason}`, evidence: ["project.yaml"], suggested: false });
50
+ }
51
+ if (!q.config.standards.length)
52
+ notes.push("品質基準は意図して空です");
53
+ }
54
+ }
55
+ else if (source.type === "task-review") {
56
+ const key = ctx.taskReview.key(source.request, source.task);
57
+ const rec = await ws.taskReviews.get(key, source.run).catch(() => undefined);
58
+ if (!rec)
59
+ throw new ImprovementError("not_found", `タスクのレビューがありません: ${key}/${source.run}`);
60
+ const q = rec.input.quality;
61
+ const target = `task:${key}`;
62
+ if (!q)
63
+ notes.push("この記録は品質を評価していません(品質基準を材料に入れる前の記録です)");
64
+ else if (q.latest.state !== "set")
65
+ pushSettings(q.latest.state, q.latest.version, q.latest.problems);
66
+ else {
67
+ for (const r of rec.result?.quality ?? []) {
68
+ if (r.verdict !== "violated" && r.verdict !== "undetermined")
69
+ continue;
70
+ const s = q.applies.find((x) => x.id === r.standard);
71
+ findings.push({ key: `${r.standard}:${target}:${r.verdict}`, kind: r.verdict, quality: r.standard, qualityText: s?.text, check: s ? checkLine(s.check) : undefined, version: q.latest.version, target, reason: r.reason, evidence: r.evidence, suggested: r.verdict === "violated" });
72
+ }
73
+ for (const s of q.exempt)
74
+ findings.push({ key: `${s.id}:${target}:exempt`, kind: "exempt", quality: s.id, qualityText: s.text, version: q.latest.version, target, reason: `適用から除外しています: ${s.exempt?.reason ?? ""}`, evidence: [], suggested: false });
75
+ }
76
+ if (rec.run.status !== "completed")
77
+ notes.push(`このレビューは完了していません(${rec.run.status})`);
78
+ }
79
+ else {
80
+ const rec = await ws.milestoneReviews.get(source.milestone, source.run).catch(() => undefined);
81
+ if (!rec)
82
+ throw new ImprovementError("not_found", `マイルストーンレビューがありません: ${source.milestone}/${source.run}`);
83
+ const q = rec.input?.quality;
84
+ const target = `milestone:${source.milestone}`;
85
+ if (!q)
86
+ notes.push("この記録は品質を評価していません(品質基準を材料に入れる前の記録です)");
87
+ else if (q.state !== "set")
88
+ pushSettings(q.state, q.version, q.problems);
89
+ else {
90
+ for (const r of rec.result?.quality ?? []) {
91
+ if (r.verdict !== "violated" && r.verdict !== "undetermined")
92
+ continue;
93
+ const s = q.standards?.find((x) => x.id === r.standard);
94
+ findings.push({ key: `${r.standard}:${target}:${r.verdict}`, kind: r.verdict, quality: r.standard, qualityText: s?.text, check: s ? checkLine(s.check) : undefined, version: q.version, target, reason: `${r.regression ? "(品質の低下)" : ""}${r.reason}`, evidence: r.evidence, suggested: r.verdict === "violated" });
95
+ }
96
+ for (const s of (q.standards ?? []).filter((x) => x.exempt))
97
+ findings.push({ key: `${s.id}:${target}:exempt`, kind: "exempt", quality: s.id, qualityText: s.text, version: q.version, target, reason: `適用から除外しています: ${s.exempt.reason}`, evidence: [], suggested: false });
98
+ }
99
+ }
100
+ const ledger = await readLedger(ws.dataDir);
101
+ const registered = {};
102
+ for (const f of findings) {
103
+ const e = ledger.entries[f.key];
104
+ if (!e?.request)
105
+ continue;
106
+ const r = ws.requests.get(e.request);
107
+ registered[f.key] = { request: e.request, ...(r ? { title: r.title, status: r.status } : {}) };
108
+ }
109
+ return { source, findings, hash: hashOf(source, findings), registered, notes };
110
+ }
111
+ const sourceLine = (s) => s.type === "project" ? "プロジェクトの品質基準の設定" : s.type === "task-review" ? `タスクのレビュー ${s.request}/${s.task} の ${s.run}` : `マイルストーンレビュー ${s.milestone} の ${s.run}`;
112
+ /** 選んだ不足から要望の原稿を作る(読むだけ) */
113
+ export function improvementDraft(d, keys) {
114
+ const picked = d.findings.filter((f) => keys.includes(f.key));
115
+ if (!picked.length)
116
+ throw new ImprovementError("no_findings", "改善する不足を選んでください");
117
+ const one = picked.length === 1 ? picked[0] : undefined;
118
+ const title = one
119
+ ? one.kind === "unset"
120
+ ? "プロジェクトの品質基準を決める"
121
+ : one.kind === "invalid"
122
+ ? "プロジェクトの品質基準の設定を直す"
123
+ : one.kind === "exempt"
124
+ ? `品質基準 ${one.quality} の除外を見直す`
125
+ : `品質基準 ${one.quality} の${one.kind === "violated" ? "違反を直す" : "確認の方法を整える"}(${one.qualityText ?? ""})`
126
+ : `品質の改善(${picked.map((f) => f.quality ?? f.kind).join(", ")})`;
127
+ const items = picked.map((f) => [
128
+ `### ${f.quality ? `${f.quality} ${f.qualityText ?? ""}` : KIND_LABEL[f.kind]}`,
129
+ `- 種類: ${KIND_LABEL[f.kind]}(対象: ${f.target}・品質基準の版 ${f.version || "なし"})`,
130
+ ...(f.check ? [`- 確認の方法: ${f.check}`] : []),
131
+ `- 指摘: ${f.reason}`,
132
+ ...(f.evidence.length ? [`- 根拠: ${f.evidence.join(", ")}`] : []),
133
+ `- 目指す差: ${f.kind === "unset" ? "プロジェクトとして守る最低限の品質基準が明記されている" : f.kind === "invalid" ? "project.yaml の品質基準が読める" : f.kind === "exempt" ? "除外の理由が今も妥当か判断し、要るなら適用する" : f.kind === "violated" ? "この品質基準を満たす" : "この品質基準を満たしているか確かめられる(確認の方法・材料を整える)"}`,
134
+ ].join("\n"));
135
+ const body = [
136
+ "## 目的",
137
+ "プロジェクトの品質基準に対する不足を解消する。",
138
+ "",
139
+ "## 現状(診断)",
140
+ `出典: ${sourceLine(d.source)}`,
141
+ "",
142
+ ...items.flatMap((x) => [x, ""]),
143
+ "## 完了条件の案",
144
+ ...picked.map((f) => `- ${f.quality ? `${f.quality}: ` : ""}${f.kind === "violated" ? "違反を直し、確認の方法で確かめた結果(コマンド・コミット・範囲)を証拠に残す" : f.kind === "undetermined" ? "確かめられる状態にし、確かめた結果を証拠に残す" : f.kind === "unset" ? "品質基準を設定する(p3 quality / 設定の「品質基準」)" : f.kind === "invalid" ? "project.yaml の quality を直して読めるようにする" : "除外を続けるか適用するかを決めて設定に残す"}`),
145
+ "",
146
+ "## 注記",
147
+ "- この原稿は P3 が診断から作った資料です。P3 は検査を実行していません(判断できないは未導入という意味ではありません)。",
148
+ ].join("\n");
149
+ return { title, body };
150
+ }
151
+ const ledgerPath = (dataDir) => join(dataDir, "quality-improvements.json");
152
+ export const tokenTag = (token) => `quality-improvement:${token}`;
153
+ async function readLedger(dataDir) {
154
+ const text = await readFile(ledgerPath(dataDir), "utf8").catch(() => "");
155
+ if (!text)
156
+ return { version: 1, entries: {} };
157
+ try {
158
+ const v = JSON.parse(text);
159
+ return v && typeof v.entries === "object" ? v : { version: 1, entries: {} };
160
+ }
161
+ catch {
162
+ throw new ImprovementError("invalid", `quality-improvements.json が読めません(${ledgerPath(dataDir)})。直すか退けてからやり直してください`);
163
+ }
164
+ }
165
+ const writeLedger = (dataDir, l) => writeFileAtomic(ledgerPath(dataDir), `${JSON.stringify(l, null, 2)}\n`);
166
+ const CLOSED = ["done", "rejected"];
167
+ /**
168
+ * 明示して登録する。hash は原稿を作った診断の版。reopenClosed: 閉じた要望が登録先の不足から作り直す。
169
+ * 開いている登録先があれば existing(作らない)。途中で落ちた予約は、タグから要望を見つけて台帳を直す
170
+ */
171
+ export async function registerImprovement(ctx, input, actor) {
172
+ const title = input.title.trim();
173
+ if (!title)
174
+ throw new ImprovementError("invalid", "要望の題を書いてください");
175
+ return withFileLock(join(ctx.ws.dataDir, ".quality-improvements.lock"), async () => {
176
+ const d = await diagnoseQuality(ctx, input.source);
177
+ if (d.hash !== input.hash)
178
+ throw new ImprovementError("diagnosis_changed", "原稿を作った後で診断(品質基準・レビューの結果)が変わりました。もう一度確かめてから登録してください");
179
+ const unknown = input.keys.filter((k) => !d.findings.some((f) => f.key === k));
180
+ if (!input.keys.length)
181
+ throw new ImprovementError("no_findings", "改善する不足を選んでください");
182
+ if (unknown.length)
183
+ throw new ImprovementError("bad_key", `診断に無い不足です: ${unknown.join(", ")}`);
184
+ const ledger = await readLedger(ctx.ws.dataDir);
185
+ // 途中で落ちた予約: token のタグを付けた要望があれば台帳を直す
186
+ for (const k of input.keys) {
187
+ const e = ledger.entries[k];
188
+ if (e && !e.request) {
189
+ const found = ctx.ws.requests.list().find((r) => r.tags.includes(tokenTag(e.token)));
190
+ if (found)
191
+ ledger.entries[k] = { ...e, request: found.id, registeredAt: e.registeredAt ?? new Date().toISOString() };
192
+ }
193
+ }
194
+ await writeLedger(ctx.ws.dataDir, ledger);
195
+ const open = input.keys.filter((k) => {
196
+ const id = ledger.entries[k]?.request;
197
+ const r = id ? ctx.ws.requests.get(id) : undefined;
198
+ return r && !CLOSED.includes(r.status);
199
+ });
200
+ if (open.length) {
201
+ const id = ledger.entries[open[0]].request;
202
+ throw new ImprovementError("existing", `この不足には登録した要望があります: ${id}(${ctx.ws.requests.get(id)?.title ?? ""})`, { request: id, keys: open });
203
+ }
204
+ const closed = input.keys.filter((k) => ledger.entries[k]?.request && !open.includes(k));
205
+ if (closed.length && !input.reopenClosed) {
206
+ const id = ledger.entries[closed[0]].request;
207
+ throw new ImprovementError("closed_existing", `この不足は閉じた要望 ${id} で扱いました。作り直すなら明示してください(--reopen / 画面のチェック)`, { request: id, keys: closed });
208
+ }
209
+ // 予約 → 要望を作る(token のタグ)→ 登録先を書く
210
+ const token = randomBytes(6).toString("hex");
211
+ const now = new Date().toISOString();
212
+ for (const k of input.keys)
213
+ ledger.entries[k] = { token, reservedAt: now, source: input.source };
214
+ await writeLedger(ctx.ws.dataDir, ledger);
215
+ const r = await createRequest(ctx, { title, body: input.body, tags: [tokenTag(token)] }, actor);
216
+ for (const k of input.keys)
217
+ ledger.entries[k] = { ...ledger.entries[k], request: r.id, registeredAt: new Date().toISOString() };
218
+ await writeLedger(ctx.ws.dataDir, ledger);
219
+ return { request: r, keys: input.keys };
220
+ });
221
+ }
@@ -1,3 +1,6 @@
1
+ import { acceptanceChanged, applyAcceptanceOps } from "../shared/acceptance.js";
2
+ import { applyBlockOp, checkBlockedStatus } from "../shared/taskBlock.js";
3
+ import { qualityCriteria, standardHash, taskQualityDiff } from "../shared/quality.js";
1
4
  import { defaultRepo } from "../shared/workTarget.js";
2
5
  import { withArchiveCheck, withChildOrder, withNewChild, withParentChange } from "./hierarchy.js";
3
6
  import { checkStatusChange, reopenAncestors, reopenIfNeeded } from "./requestStatus.js";
@@ -13,6 +16,49 @@ import { checkRepoTarget, ensureWorkstreams } from "./workTargets.js";
13
16
  /** 入力が規則に合わない(何も書いていない)。CLI は使い方の誤り、API は 400 */
14
17
  export class OpRuleError extends Error {
15
18
  }
19
+ /** 品質基準を受け入れ基準に取り込む操作(未設定・読めない設定なら無し) */
20
+ export function qualityOpsFor(ctx, repo, choice) {
21
+ const q = ctx.ws.project.quality;
22
+ if (q?.state !== "set" || choice === "none")
23
+ return [];
24
+ if (choice === "auto" && !repo)
25
+ return [];
26
+ return qualityCriteria(q.config, ctx.ws.project.qualityVersion ?? "", { repo, ...(choice === "auto" ? {} : { ids: choice }) }).map((c) => ({ op: "add", text: c.text, quality: c.quality }));
27
+ }
28
+ /**
29
+ * 今の品質基準との差分から、明示して選んだものを受け入れ基準に取り込む(add は足す、change は文と出典を直す、remove・exempt は消す)。
30
+ * keys: "<kind>:<品質 ID>"(省くと edited 以外の全部)。書く直前に読み直した値に当てる。プロジェクトの設定を変えただけではタスクは変わらない
31
+ */
32
+ export async function importQuality(ctx, rid, tid, keys, opts = {}) {
33
+ const t = ctx.ws.tasksOf(rid).require(tid);
34
+ const diff = taskQualityDiff(t.acceptanceCriteria ?? [], ctx.ws.project.quality, t.repo).filter((d) => d.kind !== "edited");
35
+ const chosen = keys ? diff.filter((d) => keys.includes(`${d.kind}:${d.quality}`)) : diff;
36
+ if (keys) {
37
+ const unknown = keys.filter((k) => !diff.some((d) => `${d.kind}:${d.quality}` === k));
38
+ if (unknown.length)
39
+ throw new OpRuleError(`取り込める差分にありません: ${unknown.join(", ")}(今の差分は p3 criteria ${t.id} quality で見る)`);
40
+ }
41
+ if (!chosen.length)
42
+ throw new OpRuleError(`${t.ref} に取り込む品質基準の差分はありません`);
43
+ const q = ctx.ws.project.quality;
44
+ const version = ctx.ws.project.qualityVersion ?? "";
45
+ const config = q?.state === "set" ? q.config : { standards: [] };
46
+ const hashOf = (id) => standardHash(config.standards.find((s) => s.id === id));
47
+ const acceptance = chosen.map((d) => {
48
+ if (d.kind === "add")
49
+ return { op: "add", text: d.text, quality: { id: d.quality, hash: hashOf(d.quality), version } };
50
+ if (d.kind === "change")
51
+ return { op: "edit", id: d.criterion, text: d.text, quality: { id: d.quality, hash: hashOf(d.quality), version } };
52
+ return { op: "remove", id: d.criterion };
53
+ });
54
+ const r = await updateTask(ctx, rid, tid, { acceptance }, opts);
55
+ return { ...r, applied: chosen.map((d) => `${d.kind}:${d.quality}`) };
56
+ }
57
+ /** 書く必要が無い(更新の中から抜けるため。外には出さない) */
58
+ class NoChange extends Error {
59
+ }
60
+ /** 済みを外した理由(基準・証拠の中身が変わった) */
61
+ export const CHECK_CLEARED_BY_ACCEPTANCE = "受け入れ基準か証拠の中身が変わったため、人の「済み」を外しました(もう一度確かめてください)";
16
62
  function changed(ctx, kind, request, ref) {
17
63
  ctx.ws.emit({ type: "changed", kind, request, ref });
18
64
  }
@@ -72,25 +118,36 @@ async function afterTaskWrite(ctx, rid, task, repo, actor) {
72
118
  * タスクを作る。repo: 省くと作業先にできる参照先が1つならそれ(ほかは作業先なし)、null は作業先なし。
73
119
  * 作業先とリポジトリごとの成果物の参照先は、作業先にできるものだけ(書く前に断る)
74
120
  */
75
- export async function createTask(ctx, rid, input, actor) {
121
+ export async function createTask(ctx, rid, { criteria, quality, ...input }, actor) {
76
122
  ctx.ws.requests.require(rid);
77
123
  const repo = "repo" in input ? (input.repo ?? null) : defaultRepo(ctx.ws.project);
78
124
  checkRepoTarget(ctx.ws, repo);
79
125
  for (const o of input.repoOutputs ?? [])
80
126
  checkRepoTarget(ctx.ws, o.repo);
81
- const task = await ctx.ws.tasksOf(rid).create({ ...input, repo, status: input.status ?? "todo" }, actor);
127
+ // 受け入れ基準は文の並びで受け取り、ID(A1, A2, ...)はここで振る(基準・証拠をそのまま渡す道は持たない)
128
+ // 停止は作るときには付けない(作業中にしてから block で付ける)
129
+ const { acceptanceCriteria: _c, acceptanceEvidence: _e, acceptanceSeq: _s, acceptanceProblems: _p, block: _b, blockHistory: _bh, blockProblems: _bp, ...plain } = input;
130
+ // 品質基準: 作業先があれば当てはまるものを取り込む(auto)。作業先なしは明示したものだけ。none は取り込まない
131
+ const fromQuality = qualityOpsFor(ctx, repo, quality ?? "auto");
132
+ const ops = [...(criteria ?? []).map((text) => ({ op: "add", text })), ...fromQuality];
133
+ const acceptance = ops.length ? applyAcceptanceOps({}, ops, { now: new Date().toISOString(), actor }) : {};
134
+ const task = await ctx.ws.tasksOf(rid).create({ ...plain, ...acceptance, repo, status: input.status ?? "todo" }, actor);
82
135
  const { ancestorWarnings, ...after } = await afterTaskWrite(ctx, rid, task, repo, actor);
83
136
  return { task, warnings: ancestorWarnings, ...after };
84
137
  }
85
138
  /**
86
139
  * タスクを変える。checked: 人の「済み」を付ける / 外す(付けられるのは完了したタスクだけ)。
140
+ * acceptance: 受け入れ基準・証拠への操作(shared/acceptance.ts。書く直前に読み直した今の値に当て、規則に合わなければ何も書かない)。
141
+ * 済みのタスクの基準・証拠の中身が変わったら済みを外し、checkCleared に理由を返す(同じ値の再保存・成果物だけの追加では外さない)。
87
142
  * 置き換えられたタスクを作業中にすると warnings を返す(変更はする)
88
143
  */
89
144
  export async function updateTask(ctx, rid, tid, patch, opts = {}) {
90
145
  const col = ctx.ws.tasksOf(rid);
91
146
  const cur = col.require(tid);
92
- const { checked, ...rest } = patch;
93
- const next = { ...rest };
147
+ const { checked, acceptance, blockOp, ...rest } = patch;
148
+ // 基準・証拠は操作(acceptance)、停止は操作(blockOp)でだけ変える(値・履歴をそのまま書く道は持たない)
149
+ const { acceptanceCriteria: _c, acceptanceEvidence: _e, acceptanceSeq: _s, acceptanceProblems: _p, block: _b, blockHistory: _bh, blockProblems: _bp, ...plain } = rest;
150
+ const next = { ...plain };
94
151
  if ("repo" in patch) {
95
152
  checkRepoTarget(ctx.ws, patch.repo);
96
153
  next.repo = patch.repo ?? null;
@@ -103,9 +160,43 @@ export async function updateTask(ctx, rid, tid, patch, opts = {}) {
103
160
  next.checkedAt = checked ? new Date().toISOString() : undefined;
104
161
  }
105
162
  const warnings = startWarnings(ctx.ws, cur.ref, cur.status, next.status);
106
- const task = await col.update(tid, next, opts);
163
+ let checkCleared;
164
+ // 停止の操作だけで何も変わらない(同じ内容の付け直し・付いていない解除)なら書かない(rev を上げない)
165
+ const onlyBlock = !!blockOp && !acceptance?.length && Object.keys(next).length === 0;
166
+ let unchanged;
167
+ const write = () => col.update(tid, (fresh) => {
168
+ const now = new Date().toISOString();
169
+ let out = next;
170
+ // 停止: 書く直前に読み直した値と、更新した後の状態で確かめる(止まったままの移動・作業中でない付与は断る)
171
+ const status = next.status ?? fresh.status;
172
+ const blockTo = blockOp ? applyBlockOp(fresh, blockOp, { now, actor: opts.actor, status }) : undefined;
173
+ if (onlyBlock && !blockTo) {
174
+ unchanged = fresh;
175
+ throw new NoChange();
176
+ }
177
+ if (blockTo)
178
+ out = { ...out, ...blockTo };
179
+ checkBlockedStatus(fresh.status, status, blockTo ? blockTo.block : fresh.block, fresh.ref);
180
+ if (!acceptance?.length)
181
+ return out;
182
+ const changedTo = applyAcceptanceOps(fresh, acceptance, { now, actor: opts.actor });
183
+ if (!acceptanceChanged(fresh, changedTo))
184
+ return out;
185
+ // 済みの後に中身が変わった(同じ操作で済みを付け直すときは外さない)
186
+ const clear = !!fresh.checkedAt && !("checkedAt" in next);
187
+ if (clear)
188
+ checkCleared = CHECK_CLEARED_BY_ACCEPTANCE;
189
+ return { ...out, ...changedTo, ...(clear ? { checkedAt: undefined } : {}) };
190
+ }, opts);
191
+ const task = await write().catch((e) => {
192
+ if (e instanceof NoChange && unchanged)
193
+ return unchanged;
194
+ throw e;
195
+ });
196
+ if (unchanged && task === unchanged)
197
+ return { task, warnings };
107
198
  const { ancestorWarnings, ...after } = await afterTaskWrite(ctx, rid, task, patch.repo, opts.actor);
108
- return { task, warnings: [...warnings, ...ancestorWarnings], ...after };
199
+ return { task, warnings: [...warnings, ...ancestorWarnings], ...after, ...(checkCleared ? { checkCleared } : {}) };
109
200
  }
110
201
  /** タスクをアーカイブする(.archive/ へ移す。消さない) */
111
202
  export async function archiveTask(ctx, rid, tid) {