@in-the-loop-labs/pair-review 3.2.3 → 3.3.0

package/public/repo-settings.html

@@ -198,6 +198,22 @@ Examples:
                         </div>
                     </section>
 
+                    <!-- Provider Skill Discovery Section -->
+                    <section class="settings-section">
+                        <div class="section-header">
+                            <h2>Provider Skill Discovery</h2>
+                            <p class="section-description">Controls whether AI providers load environment-level skills automatically. Currently applies to Pi's skill auto-discovery. When disabled, Pi runs with <code>--no-skills</code>.</p>
+                        </div>
+                        <div class="form-group" style="max-width: 300px;">
+                            <label for="load-skills-select" class="settings-label">Load Skills</label>
+                            <select class="settings-select" id="load-skills-select">
+                                <option value="">Default (inherit from config)</option>
+                                <option value="1">Enabled</option>
+                                <option value="0">Disabled</option>
+                            </select>
+                        </div>
+                    </section>
+
                     <!-- Repository Location Section -->
                     <section class="settings-section" id="local-path-section">
                         <div class="section-header">
@@ -227,6 +243,19 @@ Examples:
                         </div>
                     </section>
 
+                    <!-- Worktrees Section -->
+                    <section class="settings-section" id="worktrees-section" style="display: none;">
+                        <div class="section-header">
+                            <h2>Worktrees</h2>
+                            <p class="section-description">
+                                Manage worktree directories used for reviewing pull requests in this repository.
+                            </p>
+                        </div>
+                        <div id="worktrees-content">
+                            <!-- Rendered dynamically by JS -->
+                        </div>
+                    </section>
+
                     <!-- Danger Zone -->
                     <section class="settings-section danger-zone">
                         <div class="section-header">

package/src/ai/analyzer.js

@@ -73,9 +73,10 @@ async function captureDiffSnapshot(analyzer, worktreePath, prMetadata, logPrefix
  * @param {Object|null} instructions - Instructions object { repoInstructions, requestInstructions }
  * @param {Function|null} progressCallback - Parent progress callback to wrap
  * @param {Object} db - Database instance
+ * @param {Object} providerOverrides - Per-call config overrides passed to createProvider (optional)
  * @returns {Object} { voiceAnalyzer, voiceKey, reviewerLabel, voiceRequestInstructions, voiceProgressCallback, voiceTier, voiceTimeout }
  */
-function buildVoiceContext(voice, idx, instructions, progressCallback, db) {
+function buildVoiceContext(voice, idx, instructions, progressCallback, db, providerOverrides = {}, providerOverridesMap = null) {
   const voiceKey = `${voice.provider}-${voice.model}${idx > 0 ? `-${idx}` : ''}`;
   const reviewerLabel = buildReviewerLabel(idx, voice);
 
@@ -87,13 +88,16 @@ function buildVoiceContext(voice, idx, instructions, progressCallback, db) {
       : voice.customInstructions;
   }
 
+  // Resolve per-voice overrides: prefer provider-specific from map, fall back to shared overrides
+  const effectiveOverrides = providerOverridesMap?.[voice.provider] || providerOverrides;
+
   const ProviderClass = getProviderClass(voice.provider);
   const isExecutable = ProviderClass?.isExecutable || false;
 
   // Only create Analyzer for native voices
-  const voiceAnalyzer = isExecutable ? null : new Analyzer(db, voice.model, voice.provider);
+  const voiceAnalyzer = isExecutable ? null : new Analyzer(db, voice.model, voice.provider, effectiveOverrides);
   // Create provider instance for executable voices (used directly)
-  const voiceProvider = isExecutable ? createProvider(voice.provider, voice.model) : null;
+  const voiceProvider = isExecutable ? createProvider(voice.provider, voice.model, effectiveOverrides) : null;
 
   const voiceTier = voice.tier || 'balanced';
   const voiceTimeout = voice.timeout || ProviderClass?.defaultTimeout || 600000;
@@ -272,12 +276,16 @@ class Analyzer {
    * @param {Object} database - Database instance
    * @param {string} model - Model to use (e.g., 'opus', 'gemini-2.5-pro')
    * @param {string} provider - Provider ID (e.g., 'claude', 'gemini'). Defaults to 'claude'.
+   * @param {Object} providerOverrides - Per-call config overrides passed to createProvider (optional)
+   * @param {Object|null} providerOverridesMap - Per-provider overrides map for council mode (provider ID → overrides)
    */
-  constructor(database, model = 'opus', provider = 'claude') {
+  constructor(database, model = 'opus', provider = 'claude', providerOverrides = {}, providerOverridesMap = null) {
     // Store model and provider for creating provider instances per level
     this.model = model;
     this.provider = provider;
     this.db = database;
+    this.providerOverrides = providerOverrides;
+    this.providerOverridesMap = providerOverridesMap;
     this.testContextCache = new Map(); // Cache test detection results per worktree
     this._worktreeManager = null; // Lazy-initialized for sparse-checkout queries
   }
@@ -1015,7 +1023,7 @@ Or simply ignore any changes to files matching these patterns in your analysis.
       }
 
       // Create provider instance for this level
-      const aiProvider = createProvider(this.provider, this.model);
+      const aiProvider = createProvider(this.provider, this.model, this.providerOverrides);
 
       const updateProgress = (step) => {
         const progress = `${lp}[Level 1] ${step}...`;
@@ -1975,7 +1983,7 @@ If you are unsure, use "NEW" - it is correct for the vast majority of suggestion
       }
 
       // Create provider instance for this level
-      const aiProvider = createProvider(this.provider, this.model);
+      const aiProvider = createProvider(this.provider, this.model, this.providerOverrides);
 
       const updateProgress = (step) => {
         const progress = `${lp}[Level 2] ${step}...`;
@@ -2085,7 +2093,7 @@ If you are unsure, use "NEW" - it is correct for the vast majority of suggestion
       }
 
       // Create provider instance for this level
-      const aiProvider = createProvider(this.provider, this.model);
+      const aiProvider = createProvider(this.provider, this.model, this.providerOverrides);
 
       const updateProgress = (step) => {
         const progress = `${lp}[Level 3] ${step}...`;
@@ -2655,7 +2663,7 @@ File-level suggestions should NOT have a line number. They apply to the entire f
       }
 
       // Create provider instance for consolidation (use overrides if provided)
-      const aiProvider = createProvider(providerOverride || this.provider, modelOverride || this.model);
+      const aiProvider = createProvider(providerOverride || this.provider, modelOverride || this.model, this.providerOverrides);
 
       // Build the consolidation prompt
       const prompt = this.buildOrchestrationPrompt(allSuggestions, prMetadata, customInstructions, worktreePath, tier, lp, { excludePrevious, dedupContext });
@@ -2932,7 +2940,7 @@ File-level suggestions should NOT have a line number. They apply to the entire f
     if (voices.length === 1) {
       const voice = voices[0];
       const { voiceAnalyzer, voiceProvider, isExecutable, voiceKey, reviewerLabel, voiceRequestInstructions, voiceProgressCallback, voiceTier, voiceTimeout } =
-        buildVoiceContext(voice, 0, instructions, progressCallback, this.db);
+        buildVoiceContext(voice, 0, instructions, progressCallback, this.db, this.providerOverrides, this.providerOverridesMap);
       logger.info(`[ReviewerCouncil] Single reviewer (${reviewerLabel}) — running directly on parent run, no child run`);
 
       // Report voice-centric progress structure
@@ -3034,7 +3042,7 @@ File-level suggestions should NOT have a line number. They apply to the entire f
     const commentRepo = new CommentRepository(this.db);
     const voicePromises = voices.map(async (voice, idx) => {
       const { voiceAnalyzer, voiceProvider, isExecutable, voiceKey, reviewerLabel, voiceRequestInstructions, voiceProgressCallback, voiceTier, voiceTimeout } =
-        buildVoiceContext(voice, idx, instructions, progressCallback, this.db);
+        buildVoiceContext(voice, idx, instructions, progressCallback, this.db, this.providerOverrides, this.providerOverridesMap);
       const childRunId = uuidv4();
 
       // Create child analysis run record
@@ -3271,7 +3279,7 @@ File-level suggestions should NOT have a line number. They apply to the entire f
 
       const consolidated = await this._crossVoiceConsolidate(
         voiceReviews, prMetadata, consolInstructions, worktreePath,
-        { provider: consolProvider, model: consolModel, tier: consolTier, timeout: consolConfig.timeout, analysisId, progressCallback, excludePrevious, dedupContext }
+        { provider: consolProvider, model: consolModel, tier: consolTier, timeout: consolConfig.timeout, analysisId, progressCallback, excludePrevious, dedupContext, providerOverrides: this.providerOverrides }
       );
 
       const finalSuggestions = this.validateAndFinalizeSuggestions(
@@ -3410,7 +3418,8 @@ File-level suggestions should NOT have a line number. They apply to the entire f
           tier,
           timeout: voice.timeout || VoiceProviderClass?.defaultTimeout || 600000,
           customInstructions: voiceInstructions,
-          voiceCustomInstructions: voice.customInstructions || null
+          voiceCustomInstructions: voice.customInstructions || null,
+          providerOverrides: this.providerOverridesMap?.[voice.provider] || this.providerOverrides
         });
       }
     }
@@ -3575,7 +3584,7 @@ File-level suggestions should NOT have a line number. They apply to the entire f
           }));
           const consolidated = await this._intraLevelConsolidate(
             level, voiceGroups, prMetadata, orchInstructions, worktreePath,
-            { provider: orchProvider, model: orchModel, tier: orchTier, timeout: orchConfig.timeout, analysisId, progressCallback, reviewerCount: successfulVoicesForLevel.length }
+            { provider: orchProvider, model: orchModel, tier: orchTier, timeout: orchConfig.timeout, analysisId, progressCallback, reviewerCount: successfulVoicesForLevel.length, providerOverrides: this.providerOverrides }
           );
           consolidatedPerLevel[level] = consolidated;
           // Report intra-level consolidation step as completed
@@ -3661,7 +3670,7 @@ File-level suggestions should NOT have a line number. They apply to the entire f
    * @private
    */
   async _executeCouncilVoice(task, context) {
-    const { voiceId, reviewerLabel, reviewerLogPrefix, level, provider, model, tier, timeout = 600000, customInstructions } = task;
+    const { voiceId, reviewerLabel, reviewerLogPrefix, level, provider, model, tier, timeout = 600000, customInstructions, providerOverrides } = task;
     const { reviewId, runId, worktreePath, prMetadata, generatedPatterns, validFiles, analysisId, progressCallback } = context;
     const displayLabel = reviewerLabel || voiceId;
 
@@ -3672,7 +3681,7 @@ File-level suggestions should NOT have a line number. They apply to the entire f
     }
 
     // Create provider instance for this voice
-    const aiProvider = createProvider(provider, model);
+    const aiProvider = createProvider(provider, model, providerOverrides || {});
 
     // Build prompt based on level
     let prompt;
@@ -3748,9 +3757,9 @@ File-level suggestions should NOT have a line number. They apply to the entire f
    * @private
    */
   async _intraLevelConsolidate(level, voiceGroups, prMetadata, customInstructions, worktreePath, orchConfig) {
-    const { provider, model, tier, timeout, analysisId, progressCallback, reviewerCount } = orchConfig;
+    const { provider, model, tier, timeout, analysisId, progressCallback, reviewerCount, providerOverrides } = orchConfig;
 
-    const aiProvider = createProvider(provider, model);
+    const aiProvider = createProvider(provider, model, providerOverrides || {});
 
     const isLocal = prMetadata.reviewType === 'local';
     const reviewDescription = isLocal
@@ -3916,9 +3925,9 @@ File-level suggestions should NOT have a line number. They apply to the entire f
    * @private
    */
   async _crossVoiceConsolidate(voiceReviews, prMetadata, customInstructions, worktreePath, config) {
-    const { provider, model, tier, timeout, analysisId, progressCallback, excludePrevious, dedupContext } = config;
+    const { provider, model, tier, timeout, analysisId, progressCallback, excludePrevious, dedupContext, providerOverrides } = config;
 
-    const aiProvider = createProvider(provider, model);
+    const aiProvider = createProvider(provider, model, providerOverrides || {});
 
     const voiceDescriptions = voiceReviews.map(v => {
       let desc = `### Reviewer: ${v.voiceKey}`;

package/src/ai/claude-cli.js

@@ -53,6 +53,8 @@ class ClaudeCLI {
       });
 
       const pid = claude.pid;
+      const fullCommand = this.useShell ? this.command : `${this.command} ${this.args.join(' ')}`;
+      logger.debug(`${levelPrefix} Claude CLI command: ${fullCommand}`);
       logger.info(`${levelPrefix} Spawned Claude CLI process: PID ${pid}`);
 
       let stdout = '';

package/src/ai/claude-provider.js

@@ -257,7 +257,8 @@ class ClaudeProvider extends AIProvider {
       logger.info(`${levelPrefix} Executing Claude CLI...`);
       logger.info(`${levelPrefix} Writing prompt: ${prompt.length} bytes`);
 
-      const claude = spawn(this.command, this.args, {
+      const spawnArgs = [...this.args];
+      const claude = spawn(this.command, spawnArgs, {
         cwd,
         env: {
           ...process.env,
@@ -268,6 +269,8 @@ class ClaudeProvider extends AIProvider {
       });
 
       const pid = claude.pid;
+      const fullCommand = this.useShell ? this.command : `${this.command} ${spawnArgs.join(' ')}`;
+      logger.debug(`${levelPrefix} Claude CLI command: ${fullCommand}`);
       logger.info(`${levelPrefix} Spawned Claude CLI process: PID ${pid}`);
 
       // Register process for cancellation tracking if analysisId provided

package/src/ai/provider.js

@@ -671,10 +671,11 @@ function getAllProvidersInfo() {
  * Create a provider instance
  * @param {string} providerId - Provider ID (e.g., 'claude', 'gemini')
  * @param {string} model - Model to use (optional, uses default if not specified)
+ * @param {Object} overrides - Per-call config overrides that supersede global providerConfigOverrides (optional)
  * @returns {AIProvider}
  * @throws {Error} If provider is not registered
  */
-function createProvider(providerId, model = null) {
+function createProvider(providerId, model = null, overrides = {}) {
   const ProviderClass = providerRegistry.get(providerId);
 
   if (!ProviderClass) {
@@ -683,7 +684,7 @@ function createProvider(providerId, model = null) {
   }
 
   // Get config overrides for this provider
-  const overrides = providerConfigOverrides.get(providerId);
+  const configOverrides = providerConfigOverrides.get(providerId);
 
   // Determine the actual model to use
   let actualModel = model;
@@ -691,8 +692,8 @@ function createProvider(providerId, model = null) {
     // Resolve default from merged models (config + built-in).
     // Checks both sources because some providers (e.g., Pi) define built-in
     // modes with default:true that aren't in config overrides.
-    if (overrides?.models || ProviderClass.getModels().length > 0) {
-      actualModel = resolveDefaultModel(mergeModels(ProviderClass.getModels(), overrides?.models));
+    if (configOverrides?.models || ProviderClass.getModels().length > 0) {
+      actualModel = resolveDefaultModel(mergeModels(ProviderClass.getModels(), configOverrides?.models));
     }
     // Fall back to provider's built-in default
     if (!actualModel) {
@@ -700,8 +701,8 @@ function createProvider(providerId, model = null) {
     }
   }
 
-  // Create provider instance with config overrides
-  return new ProviderClass(actualModel, { ...(overrides || {}), yolo: yoloMode });
+  // Create provider instance with config overrides, per-call overrides, and yolo mode
+  return new ProviderClass(actualModel, { ...(configOverrides || {}), ...overrides, yolo: yoloMode });
 }
 
 /**

package/src/chat/session-manager.js

@@ -43,7 +43,7 @@ class ChatSessionManager {
    * @param {string} [options.initialContext] - Initial context to prepend to the first user message
    * @returns {Promise<{id: number, status: string}>}
    */
-  async createSession({ provider, model, reviewId, contextCommentId, systemPrompt, cwd, initialContext }) {
+  async createSession({ provider, model, reviewId, contextCommentId, systemPrompt, cwd, initialContext, loadSkills }) {
     // Resolve provider definition once — used for model fallback and bridge construction
     const providerDef = getChatProvider(provider);
 
@@ -72,6 +72,7 @@ class ChatSessionManager {
       model: resolvedModel,
       cwd,
       systemPrompt,
+      loadSkills,
     }, providerDef);
 
     const listeners = {
@@ -413,9 +414,10 @@ class ChatSessionManager {
    * @param {Object} options
    * @param {string} [options.systemPrompt] - System prompt text
    * @param {string} [options.cwd] - Working directory for agent
+   * @param {boolean} [options.loadSkills] - Resolved load_skills override for the session
    * @returns {Promise<{id: number, status: string}>}
    */
-  async resumeSession(sessionId, { systemPrompt, cwd } = {}) {
+  async resumeSession(sessionId, { systemPrompt, cwd, loadSkills } = {}) {
     // Already active — return immediately
     if (this._sessions.has(sessionId)) {
       return { id: sessionId, status: 'active' };
@@ -459,6 +461,7 @@ class ChatSessionManager {
       model: row.model,
       cwd,
       systemPrompt,
+      loadSkills,
       ...resumeOptions,
     });
 
@@ -588,7 +591,7 @@ class ChatSessionManager {
       useShell: def?.useShell,
       tools: CHAT_TOOLS,
       extensions: appExtensions ? [taskExtensionDir] : [],
-      loadSkills: def?.load_skills,
+      loadSkills: options.loadSkills ?? def?.load_skills,
     });
   }