@in-the-loop-labs/pair-review 3.2.3 → 3.3.0

package/src/routes/worktrees.js

@@ -9,12 +9,14 @@
  */
 
 const express = require('express');
-const { query, queryOne, run, ReviewRepository } = require('../database');
+const { query, queryOne, run, ReviewRepository, WorktreeRepository, WorktreePoolRepository, AnalysisRunRepository, RepoSettingsRepository } = require('../database');
 const { setupPRReview } = require('../setup/pr-setup');
 const { GitHubApiError } = require('../github/client');
 const { GitWorktreeManager } = require('../git/worktree');
+const { activeAnalyses, reviewToAnalysisId, killProcesses, broadcastProgress } = require('./shared');
 const fs = require('fs').promises;
 const logger = require('../utils/logger');
+const { resolvePoolConfig } = require('../config');
 
 const router = express.Router();
 
@@ -64,6 +66,7 @@ router.post('/api/worktrees/create', async (req, res) => {
       prNumber: parsedPrNumber,
       githubToken,
       config,
+      poolLifecycle: req.app.get('poolLifecycle'),
       onProgress: (progress) => {
         logger.info(`[Setup] ${progress.step}: ${progress.message}`);
       }
@@ -173,12 +176,17 @@ router.get('/api/worktrees/recent', async (req, res) => {
           await fs.access(row.worktree_path);
           storageStatus = 'local';
         } catch {
-          // Worktree dir missing — clean up stale record asynchronously on first page
+          // Worktree dir missing — clean up stale record asynchronously on first page,
+          // but only if it's not a pool worktree (pool worktrees are managed separately)
           if (!before) {
             setImmediate(async () => {
               try {
-                await run(db, 'DELETE FROM worktrees WHERE id = ?', [row.worktree_id]);
-                logger.info(`Cleaned up stale worktree record ${row.worktree_id}`);
+                const poolRepo = new WorktreePoolRepository(db);
+                const isPool = await poolRepo.isPoolWorktree(row.worktree_id);
+                if (!isPool) {
+                  await run(db, 'DELETE FROM worktrees WHERE id = ?', [row.worktree_id]);
+                  logger.info(`Cleaned up stale worktree record ${row.worktree_id}`);
+                }
               } catch (err) {
                 logger.warn(`Failed to cleanup stale worktree: ${err.message}`);
               }
@@ -226,10 +234,11 @@ router.get('/api/worktrees/recent', async (req, res) => {
  *
  * @param {object} db - Database handle
  * @param {number} metadataId - pr_metadata.id
+ * @param {import('../git/worktree-pool-lifecycle').WorktreePoolLifecycle} [poolLifecycle] - Pool lifecycle manager (optional)
  * @returns {{ success: boolean, message: string }}
  * @throws {Error} if deletion fails
  */
-async function deleteReviewById(db, metadataId) {
+async function deleteReviewById(db, metadataId, poolLifecycle) {
   const metadata = await queryOne(db, `
     SELECT id, pr_number, repository FROM pr_metadata WHERE id = ?
   `, [metadataId]);
@@ -246,10 +255,17 @@ async function deleteReviewById(db, metadataId) {
     SELECT id, path FROM worktrees WHERE pr_number = ? AND repository = ? COLLATE NOCASE
   `, [prNumber, repository]);
 
+  // Check if this worktree belongs to the pool — pool worktrees are preserved
+  const poolRepo = poolLifecycle ? poolLifecycle.poolRepo : new WorktreePoolRepository(db);
+  const isPool = worktree ? await poolRepo.isPoolWorktree(worktree.id) : false;
+
   // Delete all associated database records in a transaction
   await run(db, 'BEGIN TRANSACTION');
   try {
-    await run(db, 'DELETE FROM worktrees WHERE pr_number = ? AND repository = ? COLLATE NOCASE', [prNumber, repository]);
+    // Pool worktrees: keep the worktrees row and pool entry intact
+    if (!isPool) {
+      await run(db, 'DELETE FROM worktrees WHERE pr_number = ? AND repository = ? COLLATE NOCASE', [prNumber, repository]);
+    }
     await run(db, 'DELETE FROM chat_sessions WHERE review_id IN (SELECT id FROM reviews WHERE pr_number = ? AND repository = ? COLLATE NOCASE)', [prNumber, repository]);
     await run(db, `
       DELETE FROM comments WHERE review_id IN (
@@ -270,7 +286,37 @@ async function deleteReviewById(db, metadataId) {
   }
 
   // Clean up worktree AFTER successful DB commit so rollback doesn't orphan data
-  if (worktree && worktree.path) {
+  // Pool worktrees: skip filesystem cleanup, mark as available instead
+  if (isPool) {
+    // Cancel any active analyses reading from this worktree before returning
+    // the slot to the pool.  Without this, a reclaimed worktree could have its
+    // filesystem switched out from under a still-running analysis subprocess.
+    const activeAnalysisIds = poolLifecycle ? poolLifecycle.getActiveAnalyses(worktree.id) : new Set();
+    if (activeAnalysisIds.size > 0) {
+      const analysisRunRepo = new AnalysisRunRepository(db);
+      for (const analysisId of activeAnalysisIds) {
+        killProcesses(analysisId);
+        const analysis = activeAnalyses.get(analysisId);
+        if (analysis) {
+          const cancelledStatus = { ...analysis, status: 'cancelled', cancelledAt: new Date().toISOString(), progress: 'Cancelled — review deleted' };
+          activeAnalyses.set(analysisId, cancelledStatus);
+          broadcastProgress(analysisId, cancelledStatus);
+          if (analysis.reviewId) reviewToAnalysisId.delete(analysis.reviewId);
+        }
+        if (analysis?.runId) {
+          try { await analysisRunRepo.update(analysis.runId, { status: 'cancelled' }); } catch { /* best effort */ }
+        }
+      }
+      logger.info(`Cancelled ${activeAnalysisIds.size} active analysis(es) on pool worktree ${worktree.id}`);
+    }
+
+    // Release all in-memory tracking and mark the slot available in DB so it
+    // cleanly returns to the pool.
+    if (poolLifecycle) {
+      await poolLifecycle.releaseForDeletion(worktree.id);
+    }
+    logger.info(`Pool worktree ${worktree.id} cleared and marked available after review deletion`);
+  } else if (worktree && worktree.path) {
     try {
       const worktreeManager = new GitWorktreeManager(db);
       await worktreeManager.cleanupWorktree(worktree.path);
@@ -302,7 +348,8 @@ router.delete('/api/worktrees/:id', async (req, res) => {
     }
 
     const db = req.app.get('db');
-    const result = await deleteReviewById(db, metadataId);
+    const poolLifecycle = req.app.get('poolLifecycle');
+    const result = await deleteReviewById(db, metadataId, poolLifecycle);
 
     if (!result.success) {
       return res.status(404).json({
@@ -357,12 +404,13 @@ router.post('/api/worktrees/bulk-delete', async (req, res) => {
     }
 
     const db = req.app.get('db');
+    const poolLifecycle = req.app.get('poolLifecycle');
     let deleted = 0;
     const errors = [];
 
     for (const id of parsedIds) {
       try {
-        const result = await deleteReviewById(db, id);
+        const result = await deleteReviewById(db, id, poolLifecycle);
         if (result.success) {
           deleted++;
         } else {
@@ -391,4 +439,241 @@ router.post('/api/worktrees/bulk-delete', async (req, res) => {
   }
 });
 
+/**
+ * Build a cancel-analyses callback for destroyPoolWorktree.
+ * Reuses the same pattern as deleteReviewById (lines 290-311).
+ */
+function buildCancelAnalysesFn(db) {
+  const analysisRunRepo = new AnalysisRunRepository(db);
+  return async (_worktreeId, analysisIdSet) => {
+    for (const analysisId of analysisIdSet) {
+      killProcesses(analysisId);
+      const analysis = activeAnalyses.get(analysisId);
+      if (analysis) {
+        const cancelledStatus = {
+          ...analysis,
+          status: 'cancelled',
+          cancelledAt: new Date().toISOString(),
+          progress: 'Cancelled — worktree deleted',
+        };
+        activeAnalyses.set(analysisId, cancelledStatus);
+        broadcastProgress(analysisId, cancelledStatus);
+        if (analysis.reviewId) reviewToAnalysisId.delete(analysis.reviewId);
+      }
+      if (analysis && analysis.runId) {
+        try { await analysisRunRepo.update(analysis.runId, { status: 'cancelled' }); } catch { /* best effort */ }
+      }
+    }
+  };
+}
+
+/**
+ * List all worktrees for a repository with pool configuration info.
+ */
+router.get('/api/repos/:owner/:repo/worktrees', async (req, res) => {
+  try {
+    const { owner, repo } = req.params;
+    const repository = `${owner}/${repo}`;
+    const db = req.app.get('db');
+    const config = req.app.get('config');
+
+    const worktreeRepo = new WorktreeRepository(db);
+    const poolRepo = new WorktreePoolRepository(db);
+    const repoSettingsRepo = new RepoSettingsRepository(db);
+
+    const repoSettings = await repoSettingsRepo.getRepoSettings(repository);
+    const { poolSize, poolFetchIntervalMinutes: fetchInterval } = resolvePoolConfig(config, repository, repoSettings);
+
+    const [allWorktrees, poolEntries] = await Promise.all([
+      worktreeRepo.findAllByRepository(repository),
+      poolRepo.findAllForRepo(repository),
+    ]);
+
+    const poolMap = new Map(poolEntries.map(p => [p.id, p]));
+
+    const worktrees = await Promise.all(allWorktrees.map(async (wt) => {
+      const poolEntry = poolMap.get(wt.id);
+      let diskExists = false;
+      if (wt.path) {
+        try {
+          await fs.access(wt.path);
+          diskExists = true;
+        } catch { /* missing */ }
+      }
+
+      return {
+        id: wt.id,
+        is_pool: !!poolEntry,
+        status: poolEntry ? poolEntry.status : 'active',
+        pr_number: poolEntry ? poolEntry.current_pr_number : wt.pr_number,
+        branch: wt.branch,
+        path: wt.path,
+        last_fetched_at: poolEntry ? poolEntry.last_fetched_at : null,
+        last_accessed_at: wt.last_accessed_at,
+        created_at: poolEntry ? poolEntry.created_at : wt.created_at,
+        disk_exists: diskExists,
+      };
+    }));
+
+    // Include pool entries that have no corresponding worktrees record
+    // (e.g. 'creating' placeholders)
+    for (const poolEntry of poolEntries) {
+      if (!allWorktrees.some(wt => wt.id === poolEntry.id)) {
+        worktrees.push({
+          id: poolEntry.id,
+          is_pool: true,
+          status: poolEntry.status,
+          pr_number: poolEntry.current_pr_number,
+          branch: null,
+          path: poolEntry.path,
+          last_fetched_at: poolEntry.last_fetched_at,
+          last_accessed_at: null,
+          created_at: poolEntry.created_at,
+          disk_exists: false,
+        });
+      }
+    }
+
+    res.json({
+      pool: {
+        configured: poolSize > 0,
+        size: poolSize,
+        fetch_interval_minutes: fetchInterval,
+        current_count: poolEntries.length,
+      },
+      worktrees,
+    });
+  } catch (error) {
+    logger.error('Error listing worktrees:', error);
+    res.status(500).json({ error: 'Failed to list worktrees: ' + error.message });
+  }
+});
+
+/**
+ * Delete a single worktree by ID (pool or non-pool).
+ * Removes from disk and database entirely.
+ */
+router.delete('/api/repos/:owner/:repo/worktrees/:worktreeId', async (req, res) => {
+  try {
+    const { worktreeId } = req.params;
+    const db = req.app.get('db');
+    const poolLifecycle = req.app.get('poolLifecycle');
+
+    const worktreeRepo = new WorktreeRepository(db);
+    const poolRepo = new WorktreePoolRepository(db);
+
+    const isPool = await poolRepo.isPoolWorktree(worktreeId);
+
+    if (isPool) {
+      if (!poolLifecycle) {
+        return res.status(500).json({ error: 'Pool lifecycle not available' });
+      }
+      await poolLifecycle.destroyPoolWorktree(worktreeId, {
+        cancelAnalyses: buildCancelAnalysesFn(db),
+      });
+    } else {
+      const record = await worktreeRepo.findById(worktreeId);
+      if (!record) {
+        return res.status(404).json({ error: 'Worktree not found' });
+      }
+      if (record.path) {
+        try {
+          const mgr = new GitWorktreeManager(db);
+          await mgr.cleanupWorktree(record.path);
+        } catch (err) {
+          logger.warn(`Could not clean up worktree ${worktreeId} from disk: ${err.message}`);
+        }
+      }
+      await worktreeRepo.delete(worktreeId);
+    }
+
+    logger.success(`Deleted worktree ${worktreeId} (pool: ${isPool})`);
+    res.json({ success: true, message: `Worktree ${worktreeId} deleted` });
+  } catch (error) {
+    if (error.message && error.message.startsWith('Cannot delete worktree')) {
+      return res.status(409).json({ error: error.message });
+    }
+    logger.error('Error deleting worktree:', error);
+    res.status(500).json({ error: 'Failed to delete worktree: ' + error.message });
+  }
+});
+
+/**
+ * Delete all worktrees for a repository.
+ * Removes each from disk and database. Partial failures reported per-ID.
+ */
+router.delete('/api/repos/:owner/:repo/worktrees', async (req, res) => {
+  try {
+    const { owner, repo } = req.params;
+    const repository = `${owner}/${repo}`;
+    const db = req.app.get('db');
+    const poolLifecycle = req.app.get('poolLifecycle');
+
+    const worktreeRepo = new WorktreeRepository(db);
+    const poolRepo = new WorktreePoolRepository(db);
+
+    const [allWorktrees, poolEntries] = await Promise.all([
+      worktreeRepo.findAllByRepository(repository),
+      poolRepo.findAllForRepo(repository),
+    ]);
+
+    const poolIds = new Set(poolEntries.map(p => p.id));
+    const cancelFn = buildCancelAnalysesFn(db);
+
+    let deleted = 0;
+    const errors = [];
+
+    for (const wt of allWorktrees) {
+      try {
+        if (poolIds.has(wt.id)) {
+          if (poolLifecycle) {
+            await poolLifecycle.destroyPoolWorktree(wt.id, { cancelAnalyses: cancelFn });
+          } else {
+            throw new Error('Pool lifecycle not available');
+          }
+        } else {
+          if (wt.path) {
+            try {
+              const mgr = new GitWorktreeManager(db);
+              await mgr.cleanupWorktree(wt.path);
+            } catch { /* best effort */ }
+          }
+          await worktreeRepo.delete(wt.id);
+        }
+        deleted++;
+      } catch (err) {
+        errors.push({ id: wt.id, error: err.message });
+      }
+    }
+
+    // Handle pool-only entries (no worktrees record)
+    for (const pe of poolEntries) {
+      if (!allWorktrees.some(wt => wt.id === pe.id)) {
+        try {
+          if (poolLifecycle) {
+            await poolLifecycle.destroyPoolWorktree(pe.id, { cancelAnalyses: cancelFn });
+          } else {
+            throw new Error('Pool lifecycle not available');
+          }
+          deleted++;
+        } catch (err) {
+          errors.push({ id: pe.id, error: err.message });
+        }
+      }
+    }
+
+    if (deleted > 0) logger.success(`Deleted ${deleted} worktree(s) for ${repository}`);
+
+    res.json({
+      success: deleted > 0 || errors.length === 0,
+      deleted,
+      failed: errors.length,
+      errors,
+    });
+  } catch (error) {
+    logger.error('Error deleting all worktrees:', error);
+    res.status(500).json({ error: 'Failed to delete worktrees: ' + error.message });
+  }
+});
+
 module.exports = router;

package/src/server.js

@@ -8,6 +8,7 @@ const { applyConfigOverrides, checkAllProviders } = require('./ai');
 const { checkAllChatProviders } = require('./chat/chat-providers');
 const logger = require('./utils/logger');
 const { attachWebSocket, closeAll: closeAllWS } = require('./ws');
+const { WorktreePoolLifecycle } = require('./git/worktree-pool-lifecycle');
 
 let db = null;
 let server = null;
@@ -86,8 +87,9 @@ function findAvailablePort(app, startPort, maxAttempts = 20) {
 /**
  * Start the Express server
  * @param {sqlite3.Database} [sharedDb] - Optional shared database instance
+ * @param {import('./git/worktree-pool-lifecycle').WorktreePoolLifecycle} [sharedPoolLifecycle] - Optional shared pool lifecycle instance
  */
-async function startServer(sharedDb = null) {
+async function startServer(sharedDb = null, sharedPoolLifecycle = null) {
   try {
     // Load configuration
     const { config } = await loadConfig();
@@ -251,7 +253,12 @@ async function startServer(sharedDb = null) {
           // When a user deletes a worktree, metadata is preserved but the
           // worktree record is removed. Without this check the route serves
           // pr.html for a missing worktree, causing 404s on file fetches.
-          const worktree = await queryOne(db, 'SELECT id FROM worktrees WHERE pr_number = ? AND repository = ? COLLATE NOCASE', [prNumber, repository]);
+          const worktree = await queryOne(db, `
+            SELECT w.id FROM worktrees w
+            LEFT JOIN worktree_pool wp ON w.id = wp.id
+            WHERE w.pr_number = ? AND w.repository = ? COLLATE NOCASE
+              AND (wp.id IS NULL OR wp.status = 'in_use')
+          `, [prNumber, repository]);
           if (worktree) {
             // Update last_accessed_at so the recent reviews list reflects actual access
             run(db, 'UPDATE pr_metadata SET last_accessed_at = ? WHERE id = ?', [new Date().toISOString(), existing.id]).catch(err => logger.warn(`Failed to update last_accessed_at: ${err.message}`));
@@ -297,6 +304,16 @@ async function startServer(sharedDb = null) {
     app.set('githubToken', githubToken);
     app.set('config', config);
 
+    // Create or reuse the worktree pool lifecycle instance.
+    // When called from main.js, the shared instance (already rehydrated) is
+    // passed in.  When running standalone, create and rehydrate a fresh one.
+    let poolLifecycle = sharedPoolLifecycle;
+    if (!poolLifecycle) {
+      poolLifecycle = new WorktreePoolLifecycle(db, config);
+      await poolLifecycle.resetAndRehydrate();
+    }
+    app.set('poolLifecycle', poolLifecycle);
+
     // API routes - split into focused modules
     // Order matters: more specific routes must be mounted before general ones
     // to ensure proper route matching
@@ -366,7 +383,7 @@ async function startServer(sharedDb = null) {
 
     server = app.listen(port, () => {
       console.log(`Server running on http://localhost:${port}`);
-      attachWebSocket(server);
+      attachWebSocket(server, db, poolLifecycle);
     });
 
     server.on('error', (error) => {