@impeccable/reviews 0.1.16 → 0.1.18

package/dist/ui/look.js

@@ -80,18 +80,29 @@ function balanced(text, max) {
 const said = (text, inner, st) => text.split('\n\n').flatMap((part, i) => [...(i ? [''] : []), ...balanced(part, Math.min(TEXT_WIDTH, inner)).map((line) => center(st.soft(line), inner))]);
 /** Wrapped text whose first line starts with `first` and the rest line up under it. */
 const hang = (text, width, first) => wrapTextWithAnsi(text, Math.max(10, width - first.length)).map((line, i) => (i ? ' '.repeat(first.length) : first) + line);
-/** An address cut into rows no wider than `width`, after a slash where one falls in the row's last two thirds, each linking to the whole of it, so any row opens it. */
-function urlRows(url, width, ink, st) {
+/** An address or a folder cut into rows no wider than `width` columns, after a slash where one falls in the row's last two thirds, so a name in it breaks only where it must. */
+function slashRows(text, width) {
     const size = Math.max(10, width);
     const rows = [];
-    for (let rest = url; rest;) {
-        const slash = rest.length > size ? rest.lastIndexOf('/', size - 1) + 1 : 0;
-        const cut = rest.length <= size ? rest.length : slash > size / 3 ? slash : size;
+    for (let rest = text; rest;) {
+        // The longest start of it that fits, by the columns its characters take, a wide one counting two.
+        let fit = 0;
+        for (let columns = 0; fit < rest.length;) {
+            const char = String.fromCodePoint(rest.codePointAt(fit));
+            if ((columns += visibleWidth(char)) > size)
+                break;
+            fit += char.length;
+        }
+        const head = rest.slice(0, Math.max(fit, 1));
+        const slash = fit < rest.length ? Math.max(head.lastIndexOf('/'), head.lastIndexOf('\\')) + 1 : 0;
+        const cut = fit >= rest.length ? rest.length : slash && visibleWidth(head.slice(0, slash)) > size / 3 ? slash : head.length;
         rows.push(rest.slice(0, cut));
         rest = rest.slice(cut);
     }
-    return rows.map((row) => st.link(url, ink(row)));
+    return rows;
 }
+/** An address cut into rows as slashRows cuts it, each linking to the whole of it, so any row opens it. */
+const urlRows = (url, width, ink, st) => slashRows(url, width).map((row) => st.link(url, ink(row)));
 /** A label, softer, over its address. */
 const linkLines = (label, url, inner, st) => [center(st.soft(label), inner), ...block(urlRows(url, ruleWidth(inner), st.full, st), inner)];
 /** The way to put a link on the clipboard, while it is not there yet. */
@@ -102,6 +113,8 @@ const pullAction = (url, copied, inner, st) => [
     copied ? center(st.soft('Copied to clipboard!'), inner) : copyWay(inner, st),
 ];
 /** What waits on the person, under the supporting text: two lines at most, the rest counted. */
+/** The hosts the run used, a line each under the result. */
+const usedLines = (outro, inner, st) => (outro.used ?? []).flatMap((line) => said(line, inner, st));
 function leftLines(todo, inner, st) {
     const shown = todo.length > 2 ? [todo[0], `${todo.length - 1} more in the report`] : todo;
     return shown.map((line) => center(st.soft(`→ ${line}`), inner));
@@ -244,12 +257,10 @@ function runPage(scene, f, inner, st) {
         const waiting = row(`waiting for ${scene.wait.host ? `${scene.wait.host}'s preview` : 'the preview'} · ${scene.wait.timer}`);
         return ink(visibleWidth(waiting) <= inner ? waiting : row(scene.wait.timer));
     });
-    const counted = scene.tasks.filter((t) => t.status !== 'skipped');
-    const skipped = scene.tasks.length - counted.length;
     const widest = Math.max(...lines.map((line) => visibleWidth(line)));
+    // No count over the list: the list shows each task's state itself.
     return {
         heading: 'Setting up',
-        text: said(`${counted.filter((t) => t.status === 'completed').length} of ${counted.length} done${skipped ? ` · ${skipped} skipped` : ''}`, inner, st),
         rule: divider(inner, st),
         action: block(lines, inner, widest),
         at: running >= 0 ? running : Math.max(0, scene.tasks.findIndex((t) => t.status === 'pending')),
@@ -261,7 +272,8 @@ function outroPage(scene, inner, st) {
     if (outro.link) {
         return {
             heading: outro.title,
-            text: [...said(outro.result, inner, st), ...leftLines(outro.todo, inner, st), ...outro.warnings.map((line) => center(st.soft(`! ${line}`), inner))],
+            // A warning is read whole: wrapped, where centered on one line it would be cut.
+            text: [...said(outro.result, inner, st), ...usedLines(outro, inner, st), ...leftLines(outro.todo, inner, st), ...outro.warnings.flatMap((line) => said(`! ${line}`, inner, st))],
             rule: divider(inner, st),
             action: pullAction(outro.link, scene.copied, inner, st),
             ways: scene.leaving ? undefined : [['Close', 'Enter']],
@@ -273,7 +285,7 @@ function outroPage(scene, inner, st) {
     const links = outro.links.flatMap((l) => linkLines(l.label, l.url, inner, st));
     return {
         heading: outro.title,
-        text: said(outro.result, inner, st),
+        text: [...said(outro.result, inner, st), ...usedLines(outro, inner, st)],
         rule: divider(inner, st),
         action: [...block(notes, inner), ...(notes.length && links.length ? [''] : []), ...links, ...(outro.links.length === 1 ? [scene.copied ? center(st.soft('Copied to clipboard!'), inner) : copyWay(inner, st)] : [])],
         ways: scene.leaving ? undefined : [['Close', 'Enter']],
@@ -299,7 +311,7 @@ function pageOf(f, inner) {
             const under = scene.note ?? (scene.copied ? 'Copied to clipboard!' : '');
             const link = block(urlRows(scene.link, ruleWidth(inner), st.soft, st), inner);
             // In the action, which scrolls and keeps every line, so a short terminal still shows which checkout this approves.
-            const checkout = scene.checkout && !scene.again ? [...balanced(scene.checkout.repository, Math.min(TEXT_WIDTH, inner)).map((line) => center(st.full(line), inner)), ...said(`in ${scene.checkout.folder}`, inner, st), ''] : [];
+            const checkout = scene.checkout && !scene.again ? [...balanced(scene.checkout.repository, Math.min(TEXT_WIDTH, inner)).map((line) => center(st.full(line), inner)), ...slashRows(`in ${scene.checkout.folder}`, Math.min(TEXT_WIDTH, inner)).map((line) => center(st.soft(line), inner)), ''] : [];
             return {
                 heading: scene.again ? 'Sign in again' : START.heading,
                 text: said(scene.again ? AGAIN[scene.again] : 'Sign in with GitHub in your browser, then approve this repository.', inner, st),

package/dist/ui/run-state.js

@@ -83,9 +83,4 @@ export class RunState {
             return { previous: this.current, current: `Still working… ${elapsed(silence)}` };
         return { previous: this.previous, current: this.current };
     }
-    /** Completed tasks out of all but the skipped ones. */
-    progress() {
-        const counted = this.tasks.filter((t) => t.status !== 'skipped');
-        return { completed: counted.filter((t) => t.status === 'completed').length, total: counted.length };
-    }
 }

package/dist/ui/screens.js

@@ -303,7 +303,7 @@ class Wizard {
             if (choices && question.picked.size)
                 return done({ skipped: false, values: choices.filter((_, i) => question.picked.has(i)).map((o) => o.value) });
             if (choices)
-                question.note = 'Pick at least one, or skip.';
+                question.note = q.skippable ? 'Pick at least one, or skip.' : 'Pick at least one.';
             else {
                 const value = question.field.getValue().trim();
                 if (value)
@@ -478,7 +478,7 @@ export function showRun(opts) {
 }
 /** The outro in plain lines, for the scrollback: what stays once the screen has gone. */
 function summary(o) {
-    return ['', `${OUTCOME[o.outcome]} ${o.title}. ${o.result}`, ...o.links.map((l) => `${l.label}: ${l.url}`), ...o.todo.map((line) => `→ ${line}`), ...o.warnings.map((warning) => `! ${warning}`)];
+    return ['', `${OUTCOME[o.outcome]} ${o.title}. ${o.result}`, ...(o.used ?? []), ...o.links.map((l) => `${l.label}: ${l.url}`), ...o.todo.map((line) => `→ ${line}`), ...o.warnings.map((warning) => `! ${warning}`)];
 }
 /** Opens `url` in the browser and puts it on the clipboard, true once it is there. Neither can fail the screen, which shows the link either way. */
 async function handOver(url, hand) {
@@ -493,9 +493,9 @@ export async function showPullRequest(url, hand) {
         return;
     const copied = await handOver(url, hand);
     await new Promise((resolve) => {
+        // The screen stays until the end screen takes its place, so no empty screen shows between the two.
         const done = () => {
             clearTimeout(timer);
-            screen.remove(view);
             resolve();
         };
         const timer = setTimeout(done, CLOSE_AFTER_MS).unref();
@@ -507,7 +507,7 @@ export async function showPullRequest(url, hand) {
 /** The last screen: what happened, what is left, any warnings and its pull request (handed over as it appears) or the links, until a key other than ↑↓ PgUp PgDn is pressed, or for 20 minutes. Its summary then stays in the scrollback. */
 export async function showOutro(outro, hand) {
     // What is left and why it stopped can be the model's words, which reach the scrollback after the clipboard holds the pull request.
-    const o = { ...outro, result: plainText(outro.result), todo: outro.todo.map(plainText), warnings: outro.warnings.map(plainText) };
+    const o = { ...outro, result: plainText(outro.result), todo: outro.todo.map(plainText), warnings: outro.warnings.map(plainText), ...(outro.used ? { used: outro.used.map(plainText) } : {}) };
     const screen = host();
     if (screen) {
         const copied = o.link && hand ? await handOver(o.link, hand) : false;

package/dist/vercel-bypass.js

@@ -182,6 +182,7 @@ export async function passVercelLogin(deps) {
             else {
                 // The project holds the secret from here on, whatever the reads below say: the screen says to copy it, never to make another.
                 held = made.made;
+                deps.made?.(made.made, project.name);
                 // Read back by its label, again for a few seconds while the settings do not list it yet.
                 let ours;
                 for (const end = Date.now() + wait.totalMs;;) {

package/dist/vercel.js

@@ -2,7 +2,7 @@ import { readFile } from 'node:fs/promises';
 import { join } from 'node:path';
 import { setTimeout as sleep } from 'node:timers/promises';
 import { folderOf, matchesBranch, TEST_DRIVE_BRANCH } from './host-previews.js';
-import { asLink, readLink } from './vercel-bypass.js';
+import { asLink, isBypassSecret, readLink, SECRET_NOTE } from './vercel-bypass.js';
 /** `vercel whoami`: the CLI prints the username, or says it has no credentials and exits 1. */
 export async function vercelStatus(vercel) {
     try {
@@ -147,7 +147,9 @@ export async function readLinkedProject(vercel, link) {
     // The live app: the production deployment's first alias, the project's own domain, as Vercel lists them (its automatic aliases follow). Its own hashed address is one build's, which the next production deployment leaves behind: never the before.
     const live = target && !failed(target) ? (Array.isArray(target.alias) ? target.alias : []).map(hostname).find(Boolean) : undefined;
     const root = folderOf(project.rootDirectory);
-    return { ...(root !== undefined ? { rootDirectory: root } : {}), ...(typeof project.name === 'string' && project.name ? { name: project.name } : {}), production: exists ? 'exists' : 'none', ...(typeof branch === 'string' && branch ? { productionBranch: branch } : {}), ...(live ? { productionUrl: `https://${live}` } : {}), protection: typeof protection === 'string' ? protection : null, previewsProtected, deploymentHosts: new Set(hosts), ...(repository ? { repository } : {}), ignoredBuildStep: typeof ignore === 'string' && ignore.trim().length > 0, githubDeployments: record(project.gitProviderOptions)?.createDeployments !== 'disabled' };
+    // As impeccable_vercel_bypass picks its secret: one for automation, labelled for Impeccable.
+    const labelled = Object.entries(record(project.protectionBypass) ?? {}).some(([value, meta]) => isBypassSecret(value) && record(meta)?.scope === 'automation-bypass' && record(meta)?.note === SECRET_NOTE);
+    return { ...(labelled ? { bypassLabelled: true } : {}), ...(root !== undefined ? { rootDirectory: root } : {}), ...(typeof project.name === 'string' && project.name ? { name: project.name } : {}), production: exists ? 'exists' : 'none', ...(typeof branch === 'string' && branch ? { productionBranch: branch } : {}), ...(live ? { productionUrl: `https://${live}` } : {}), protection: typeof protection === 'string' ? protection : null, previewsProtected, deploymentHosts: new Set(hosts), ...(repository ? { repository } : {}), ignoredBuildStep: typeof ignore === 'string' && ignore.trim().length > 0, githubDeployments: record(project.gitProviderOptions)?.createDeployments !== 'disabled' };
 }
 /**
  * The linked project as this repository's: read now, and connected to the repository on Vercel, which its Git link

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@impeccable/reviews",
-  "version": "0.1.16",
+  "version": "0.1.18",
   "description": "Set up a repository for Impeccable for PRs from your terminal.",
   "license": "SEE LICENSE IN LICENSE",
   "private": false,

package/dist/playbook/cases/static-site.md

@@ -1,16 +0,0 @@
-### When this applies
-
-The pages need no server from this repository: plain HTML, or a build that writes a complete static site. Pages that need SSR, API routes or a backend here follow server-previews; an external API they call does not change that. A build that writes only JavaScript, CSS or types is a library, not a site.
-
-### Steps
-
-1. **Find the output**: the folder the build writes the pages to (framework config, scripts), or, with no build, the folder that holds the real `index.html`. Done when you can name that folder and the build command, or that there is none.
-2. **Prove it** with impeccable_verify_preview in static mode. Done when it answers `verified: true` with the folder's `index.html` in `files`; a failure names its `stage`, which the report explains, and pull-requests' "No preview, no test drive" says how the run goes on without a proof. When it answers that this machine has no sandbox for the check (Linux, or `--no-sandbox`), the check is skipped: save the build the scripts name in step 3, and the preview job on the pull request proves it; put that under "What is not verified".
-3. **Save it** with impeccable_write to `preview`: `intendedMethod: "static-upload"`, `outputDir` and the commands you proved, clearing a saved command you did not prove; when the check was skipped on this machine, the build the scripts name is what you save, and the preview job proves it. Done when the answer's `keys` show each key stored or unchanged.
-
-### Reference
-
-- **No build**: `steps` is empty and the output is the page's folder, `.` for the checkout's root. Invent no manifest, build, runtime or server for plain HTML.
-- **A base path**: `<base>/index.html` must exist under the output folder; pass `basePath` to the check, and save it.
-- **A single-page app**: the write takes no `spa` key, and the entry check proves no deep link; report a route the preview cannot serve.
-- A verified result proves the entry files exist, nothing more: rendering, assets, deep links and external APIs go under "What is not verified".