@impeccable/reviews 0.1.16 → 0.1.18

package/dist/preflight.js

@@ -4,6 +4,7 @@ import { join, resolve } from 'node:path';
 import { parseArgs } from 'node:util';
 import { folderOf } from './host-previews.js';
 import { UserError } from './log.js';
+import { gitEnvironment } from './sandbox.js';
 export const EFFORTS = ['off', 'minimal', 'low', 'medium', 'high', 'xhigh', 'max'];
 /** The environment variable that names the folder to set up when --install-dir does not. */
 const INSTALL_DIR_ENV = 'IMPECCABLE_REVIEWS_INSTALL_DIR';
@@ -288,3 +289,58 @@ export function stateSaysNoFrontEnd(state, repo) {
     const mine = Array.isArray(repos) ? repos.find((r) => r?.name === repo) : undefined;
     return mine?.webSupport?.supported === false;
 }
+/** Whether a push put `branch` on origin: the remote-tracking ref a push records. */
+export function onOrigin(root, branch) {
+    try {
+        execFileSync('git', ['show-ref', '--verify', '--quiet', `refs/remotes/origin/${branch}`], { cwd: root, stdio: 'ignore', env: gitEnvironment() });
+        return true;
+    }
+    catch {
+        return false;
+    }
+}
+/** The branch the checkout is on; '' when HEAD is detached or git cannot say. */
+export function currentBranch(root) {
+    try {
+        return execFileSync('git', ['branch', '--show-current'], { cwd: root, encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'], env: gitEnvironment() }).trim();
+    }
+    catch {
+        return '';
+    }
+}
+/**
+ * The run makes its pull requests on branches of its own, and git leaves the checkout on the last it made: the end goes back
+ * to the branch the run started on (`start`), so what the person commits next does not land on the test drive. Only from one
+ * of the run's branches, and only with no change to a tracked file, which would go along; git refuses where an untracked
+ * file would be overwritten. Null when the checkout is back, or never left; else the line the done screen shows.
+ */
+export function backToStartBranch(root, start) {
+    const now = currentBranch(root);
+    if (now === start || !/^impeccable\/(?:setup|test-drive)(?:-\d+)?$/.test(now))
+        return null;
+    if (!start)
+        return `Your checkout is on ${now}, the branch the setup made.`;
+    const git = (args, input) => execFileSync('git', args, { cwd: root, encoding: 'utf8', input, stdio: [input === undefined ? 'ignore' : 'pipe', 'pipe', 'ignore'], timeout: 10_000, maxBuffer: 64 * 1024 * 1024, env: gitEnvironment() });
+    try {
+        // A content filter is a program git runs outside the sandbox as it reads or writes a file, from settings that may name a script in the checkout a sandboxed command could have changed: a checkout with any file a filter takes, here or on the start branch, is left to the person. Neither read runs one.
+        const paths = [...new Set([...git(['ls-files', '-z']).split('\0'), ...git(['diff', '--name-only', '-z', '--no-ext-diff', '--no-textconv', 'HEAD', start, '--']).split('\0')].filter(Boolean))].map((path) => `${path}\0`).join('');
+        const listed = git(['check-attr', '--stdin', '-z', 'filter'], paths).split('\0');
+        // path, attribute, value, ...
+        for (let i = 2; i < listed.length; i += 3)
+            if (!['unspecified', 'unset'].includes(listed[i]))
+                throw new Error('a content filter');
+        // The start branch's own .gitattributes files, read as they are there (check-attr --source needs git 2.40): any that names a filter counts.
+        const attributes = git(['ls-tree', '-r', '-z', '--name-only', start]).split('\0').filter((path) => path === '.gitattributes' || path.endsWith('/.gitattributes'));
+        if (attributes.some((path) => /\bfilter\b/.test(git(['cat-file', 'blob', `${start}:${path}`]))))
+            throw new Error('a content filter on the start branch');
+        if (git(['status', '--porcelain', '--untracked-files=no']).trim())
+            throw new Error('changes to tracked files');
+        // The closing -- makes git read the name as the branch, never as a path.
+        // An ignored file of the person's where the start branch tracks a file of that name stops the checkout, rather than being overwritten.
+        git(['-c', 'submodule.recurse=false', 'checkout', '-q', '--no-overwrite-ignore', start, '--']);
+        return null;
+    }
+    catch {
+        return `Your checkout is still on ${now}: git checkout ${start} takes it back to the branch you started on.`;
+    }
+}

package/dist/sandbox.js

@@ -281,7 +281,8 @@ function scrubbedGitConfig(root, home, log) {
         includes.push(...gitIncludes(list(['--file', file, '--no-includes'], { unread: (said) => log.write('git include not read', { file, said }) }), home));
     }
     const path = join(ownFolder(), `gitconfig-${randomBytes(6).toString('hex')}`);
-    writeFileSync(path, text, { mode: 0o600 });
+    // Last, so it holds over the person's own: a branch made from origin/<branch> sets up no tracking, which git would write to the config the sandbox keeps and print its refusal twice. The push -u, as the person, sets it.
+    writeFileSync(path, `${text}[branch]\n\tautoSetupMerge = false\n`, { mode: 0o600 });
     const execPath = execFileSync('git', ['--exec-path'], { encoding: 'utf8', stdio: ['ignore', 'pipe', 'ignore'], env }).trim();
     const programs = helpers.flatMap((name) => [...new Set([execPath, ...APPLE_GIT_CORE])].map((dir) => join(dir, `git-credential-${name}`))).filter(present);
     return { path, files: [...seen], helpers: programs };
@@ -616,10 +617,9 @@ export async function startSandbox(o) {
             }
         },
     };
-    const proven = "the preview job on the pull request proves a static site's build instead";
     return {
         warning: off && `${off[0].toUpperCase()}${off.slice(1)}, so the setup's commands run without a sandbox, with all your access.`,
-        noPreview: off ? `The local preview check, which needs a sandbox of its own, does not run either; ${proven}.` : platform === 'linux' ? `On Linux bubblewrap keeps the app from the local preview check, so the check does not run here; ${proven}.` : undefined,
+        noPreview: off ? `The local preview check, which needs a sandbox of its own, does not run either.` : platform === 'linux' ? `On Linux bubblewrap keeps the app from the local preview check, so the check does not run here.` : undefined,
         shell,
         finish: () => watched.settle(),
         preview(folder) {

package/dist/tools.js

@@ -10,9 +10,9 @@ import { defineTool } from '@earendil-works/pi-coding-agent';
 import { agreeToHostSetup, bindPreviewPullRequest, chooseHostTeam, chosenHostTeam, classifyPreviewCommand, endHostSetup, hostSetupAgreed, isSecretFile, linkedByRun, observePreviewAttempts, parseCommand, previewRetryState, settleVercelFirstDeployment, vercelProjectsAdded } from './fence.js';
 import { requestJson } from './http.js';
 import { appsLeftOut, focusCheckup, focusInstructions, focusState, severalApps } from './focus.js';
-import { APPS_QUESTION, cloudflareAccessPaste, cloudflareAccessReusable, HOST_QUESTIONS, HOST_SCREENS, HOST_SIGNED_IN, namedAppQuestion, sentTo, startedIn, vercelBypassPaste } from './host-questions.js';
+import { APPS_QUESTION, cloudflareAccessConsent, cloudflareAccessPaste, cloudflareAccessReusable, HOST_QUESTIONS, HOST_SCREENS, HOST_SIGNED_IN, namedAppQuestion, sentTo, startedIn, vercelBypassConsent, vercelBypassPaste } from './host-questions.js';
 import { enableNetlifyPreviews, folderOf } from './host-previews.js';
-import { checkoutNames, liveShaped, netlifySiteOf, previewHostName, provePreview, readHostedPreviews } from './hosted.js';
+import { checkoutNames, liveShaped, netlifySiteOf, previewHostName, provePreview, readHostedPreviews, readmeNamesApp, vercelDeploymentOf } from './hosted.js';
 import { cfRunner, cfStatus, CLOUDFLARE_APP_PAGE, connectCloudflareProject, enableCloudflarePreviews, pagesProject, pagesProjectName, readCloudflarePreviews } from './cloudflare.js';
 import { passCloudflareAccess } from './cloudflare-access.js';
 import { commandRunner, connectNetlifySite, liveSite, netlifyStatus, netlifyTeams, readNetlifyPreviews, waitForNetlifyAccess } from './netlify.js';
@@ -167,6 +167,22 @@ export function ending(report) {
 }
 /** Said once, here and in the report, when the host builds the previews and the repository needed no change. */
 export const nothingToMerge = (host) => `Nothing to merge: ${host} hosts your previews, so the repository needed no change.`;
+/** The last screen's line for each host, in the order first met: "Cloudflare: Acme's Account · project crewline", "Netlify: team Acme · site crewline", "Vercel: team acme · project crewline" (#360). */
+export function hostLines(used) {
+    const byHost = new Map();
+    for (const u of used) {
+        const entry = byHost.get(u.host) ?? { accounts: new Set(), projects: new Set() };
+        if (u.account)
+            entry.accounts.add(u.account);
+        entry.projects.add(u.project);
+        byHost.set(u.host, entry);
+    }
+    return [...byHost].map(([host, { accounts, projects }]) => {
+        const what = host === 'Netlify' ? 'site' : 'project';
+        const account = accounts.size ? `${host === 'Cloudflare' ? '' : 'team '}${[...accounts].join(', ')} · ` : '';
+        return `${host}: ${account}${projects.size > 1 ? `${what}s` : what} ${[...projects].join(', ')}`;
+    });
+}
 const PROGRESS = {
     type: 'object',
     additionalProperties: false,
@@ -229,6 +245,14 @@ const TEST_PR = {
 const APP_KEY_SHAPE = /^[A-Za-z0-9][A-Za-z0-9._-]{0,79}$/;
 /** The app a host tool reads for, on a repository with several apps: its previews are those of the project or site that builds the app's folder. */
 const APP_KEY = { type: 'string', minLength: 1, description: 'On a repository with several apps, the key of the app this is for, one the apps question picked: only the previews of the host project that builds that app\'s folder are read.' };
+const VERCEL_BYPASS = {
+    type: 'object',
+    additionalProperties: false,
+    properties: {
+        appKey: APP_KEY,
+        beforePush: { type: 'boolean', description: "True before the test drive's push on Vercel, where no preview met Vercel's login yet: reads whether the project's previews are protected and asks the consent now, before anything is pushed." },
+    },
+};
 const HOSTED_PREVIEWS = {
     type: 'object',
     additionalProperties: false,
@@ -1584,6 +1608,27 @@ export function createTools(ctx) {
     /** Whether any preview write with a method was taken this run, and the host's lock the last gated proof met: the last screen names it when no preview ever opened (#321), and Preview method is completed only once a method is saved (#322). */
     let methodSaved = false;
     let lastLock;
+    /** The host preview addresses a proof or a host's key opened, and the Cloudflare account and Netlify team of each project or site the host tools read, by host and project: the last screen names them (#360), and no tool's answer does. */
+    const usedPreviews = new Set();
+    const accountOf = new Map();
+    /** The Vercel project the bypass tool read for each address its secret opened, and its team where that is not the CLI's current scope. */
+    const vercelNamed = new Map();
+    /** What the last screen says the run used on each host, from the previews it opened. */
+    const hostsUsed = () => [...usedPreviews].flatMap((url) => {
+        const origin = new URL(url).origin;
+        const label = pagesProject(origin);
+        if (label)
+            return [{ host: 'Cloudflare', project: label, ...(accountOf.has(`cloudflare ${label}`) ? { account: accountOf.get(`cloudflare ${label}`) } : {}) }];
+        const site = netlifySiteOf(url);
+        if (site)
+            return [{ host: 'Netlify', project: site, ...(accountOf.has(`netlify ${site}`) ? { account: accountOf.get(`netlify ${site}`) } : {}) }];
+        const read = vercelNamed.get(origin);
+        const named = read?.project ?? listedApps.get(origin)?.name;
+        const vercel = vercelDeploymentOf(url, named);
+        const team = vercel?.team ?? read?.team;
+        const project = vercel?.project ?? named;
+        return project ? [{ host: 'Vercel', project, ...(team ? { account: team } : {}) }] : [];
+    });
     /**
      * A host's build, waited for on the screen as the task in progress, naming `host`, with the time so far: `read` again
      * every so often until `built` says the evidence is final, or the wait runs out. The status line names the host and what it builds.
@@ -1641,6 +1686,8 @@ export function createTools(ctx) {
     const bypassOrigins = new Map();
     /** What impeccable_vercel_bypass answered for a store, less the secret: a skip is asked once, so that answer stands. */
     const bypassOutcomes = new Map();
+    /** The stores whose consent was given before the test drive's push, each with the project it named (`<store>/<projectId>`): the call once the gate is met asks no second time for that project alone. */
+    const bypassConsented = new Set();
     /** The Netlify site password saved in this run, for the proof of that site's addresses to send; never for the model. It is one site's, so it goes only to that site's deploy previews. */
     let sitePassword;
     const passwordSites = new Set();
@@ -1659,6 +1706,8 @@ export function createTools(ctx) {
     let accessStored = false;
     /** What impeccable_cloudflare_access answered, less the token: a skip is asked once, so that answer stands. */
     let accessOutcome;
+    /** The Access applications, by id, the person said yes to a token for. */
+    const accessConsented = new Set();
     /** What each host's settings last said of its pull-request previews, as the evidence tools read them: the one fact impeccable_enable_previews acts on. */
     const previewFacts = new Map();
     /** What impeccable_enable_previews answered for a host: asked once, so that answer stands. */
@@ -1722,9 +1771,10 @@ export function createTools(ctx) {
         reportStatus(status);
     };
     /** A screen a tool puts up on its own: the web page shows the run waiting on it, as on the model's questions, until it is answered. */
-    const ask = async (screen) => {
+    /** A screen of the tool's own, which offers Skip unless `skippable` is false. */
+    const ask = async (screen, skippable = true) => {
         ctx.sync.update({ phase: 'waiting', question: { id: screen.id, prompt: screen.prompt } });
-        const answer = await askPerson({ ...screen, skippable: true });
+        const answer = await askPerson({ ...screen, skippable });
         ctx.sync.update({ phase: 'running', question: null });
         return answer;
     };
@@ -2234,12 +2284,16 @@ export function createTools(ctx) {
         const start = ctx.start ?? '';
         const here = start ? apps.filter((a) => a.folder && (start === a.folder || start.startsWith(`${a.folder}/`))).sort((a, b) => b.folder.length - a.folder.length)[0] : undefined;
         const hint = here ? startedIn(`${here.name}'s folder`) : start ? startedIn(start) : APPS_QUESTION.hint;
-        const answer = await ask({ ...APPS_QUESTION, hint, options: apps.map((a) => ({ label: `${a.name} · ${a.folder || '/'}`, value: a.key, selected: confirmedApps || a.enabled || a === here || a === named })) });
+        // Reached by Esc on the named app's screen ("Pick other apps"), the list has no Skip on Esc: a second Esc to go back would skip the apps (#324).
+        const answer = await ask({ ...APPS_QUESTION, hint, options: apps.map((a) => ({ label: `${a.name} · ${a.folder || '/'}`, value: a.key, selected: confirmedApps || a.enabled || a === here || a === named })) }, !named);
         if (answer.skipped) {
             pick(new Set(apps.filter((a) => a.enabled).map((a) => a.key)));
             return JSON.stringify({ skipped: true, on: [...pickedApps] });
         }
         const values = (answer.values ?? []).filter((value) => apps.some((a) => a.key === value));
+        // Nothing picked on the list the named app's screen opened, which has no Skip (a blank line in a piped run): the named app stands.
+        if (named && !values.length)
+            values.push(named.key);
         pick(new Set(values));
         return JSON.stringify({ values });
     }
@@ -2344,13 +2398,16 @@ export function createTools(ctx) {
             if (target.url.endsWith('/preview') && saved && 'beforeUrl' in saved && (typeof saved.beforeUrl !== 'string' || !URL.canParse(saved.beforeUrl) || !provenLive.has(new URL(saved.beforeUrl).origin))) {
                 return "Refused: beforeUrl is the live app's address that impeccable_prove_preview opened with this app in this run (the production address a host tool answered, or the one the README names), or a page on it; an address no key opens is not set, and a saved one is never cleared from here. Nothing was saved.";
             }
-            // One app's before is its own: the production address its own project or site answered, or one a file in its own folder names.
+            // One app's before is its own: the production address its own project or site answered, or one a file in its own folder names, or a line of the root README that names that app and no other (#367).
             if (appsRepo && target.url.endsWith('/preview') && saved && typeof saved.beforeUrl === 'string') {
                 const origin = new URL(saved.beforeUrl).origin;
                 const owner = liveApps.get(origin);
                 const folder = await appFolder(pi, String(saved.appKey));
-                if (owner !== undefined ? owner !== saved.appKey : folder === undefined || !(await checkoutNames(pi.cwd, origin, folder))) {
-                    return `Refused: ${origin} is not the live address of ${String(saved.appKey)}: it is another app's, or no file in that app's folder names it. Nothing was saved.`;
+                const app = knownApps?.find((a) => a.key === saved.appKey);
+                const named = async () => folder !== undefined && ((await checkoutNames(pi.cwd, origin, folder))
+                    || (app !== undefined && (await readmeNamesApp(pi.cwd, origin, app, (knownApps ?? []).filter((a) => a.key !== app.key)))));
+                if (owner !== undefined ? owner !== saved.appKey : !(await named())) {
+                    return `Refused: ${origin} is not the live address of ${String(saved.appKey)}: it is another app's, or neither a file in that app's folder nor a line of the root README that names that app (and no other) names it. Nothing was saved.`;
                 }
             }
             const testAccounts = target.url.endsWith('/test-accounts');
@@ -2384,8 +2441,6 @@ export function createTools(ctx) {
                 confirmedApps = true;
             if (target.url.endsWith('/preview') && response.ok) {
                 const keys = object(object(response.data)?.keys);
-                if (keys?.intendedMethod === 'stored' && object(p.body)?.intendedMethod === 'static-upload')
-                    retry.requireHistory = true;
                 if (object(p.body)?.intendedMethod === 'preview-deploy')
                     savedHost = provenHost;
                 if (saved?.appKey !== undefined)
@@ -2610,7 +2665,8 @@ export function createTools(ctx) {
                 return `Error: the report was refused (${res.status}: ${res.error}). Fix what it says and call impeccable_report again.`;
             }
             // Otherwise final: a completed write whose answer was lost may still have landed, so it is never taken back.
-            ctx.onReport({ markdown, left, testPr: drive, setupPr: ctx.sync.payload.setup_pr, ...(savedHost ? { hostedBy: savedHost } : {}), ...(apps ? { apps } : {}), methodSaved, ...(lastLock && !hostedPreviewProven ? { lock: lastLock } : {}) });
+            const hosts = hostLines(hostsUsed());
+            ctx.onReport({ markdown, left, testPr: drive, setupPr: ctx.sync.payload.setup_pr, ...(savedHost ? { hostedBy: savedHost } : {}), ...(apps ? { apps } : {}), methodSaved, ...(lastLock && !hostedPreviewProven ? { lock: lastLock } : {}), ...(hosts.length ? { hosts } : {}) });
             pi.shutdown();
             const saved = res?.ok ? 'Saved.' : `The web page did not take it (${res?.error ?? 'no answer'}).`;
             return { text: `${saved} The terminal shows the summary and the command exits.`, terminate: true };
@@ -2620,6 +2676,9 @@ export function createTools(ctx) {
             const refused = appRefusal(p.appKey, 'read') ?? lockRefusal(p.appKey, 'read');
             if (refused)
                 return refused;
+            // The bypass secret skipped: Vercel's login keeps the test drive's preview from the review, so there is none to wait for (#356).
+            if (branch !== undefined && bypassOutcomes.get(appsRepo ? p.appKey : '')?.status === 'skipped')
+                return "Refused: the person skipped the bypass secret, and Vercel's login stands in front of the previews, so the test drive's preview could not be reviewed: push and open no test drive, as preview-protection's step 3 says. Nothing was read.";
             // The fact, the live app and an app's project read the same projects: each `vercel api` call is made once.
             const reads = new Map();
             const vercel = (args) => {
@@ -2729,7 +2788,9 @@ export function createTools(ctx) {
             const directory = appKey !== undefined ? await appFolder(pi, appKey) : undefined;
             if (appKey !== undefined && directory === undefined)
                 return JSON.stringify({ appKey, sites: [], previews: [], unmatched: `The setup state names no folder for the app ${appKey}.` });
-            const read = () => (ctx.netlifyPreviewReader ?? readNetlifyPreviews)(ctx.owner, ctx.repo, pi.cwd, { signal, pull, ...(directory !== undefined ? { directory } : {}) });
+            // Each site's team is for the last screen alone.
+            const onTeams = (teams) => Object.entries(teams).forEach(([name, team]) => accountOf.set(`netlify ${name}`, team));
+            const read = () => (ctx.netlifyPreviewReader ?? readNetlifyPreviews)(ctx.owner, ctx.repo, pi.cwd, { signal, pull, onTeams, ...(directory !== undefined ? { directory } : {}) });
             // A pull request's preview is still building until Netlify's deploy of it is built or has failed.
             const states = ['success', 'ready', 'failure', 'error'];
             const final = (evidence) => Boolean(evidence.error) || evidence.previews.some((preview) => states.includes(preview.state ?? ''));
@@ -2780,7 +2841,9 @@ export function createTools(ctx) {
             const appProject = appKey !== undefined ? cloudflareApps.get(appKey) : undefined;
             if (appKey !== undefined && (pull !== undefined || branch !== undefined) && !appProject)
                 return `Refused: read impeccable_cloudflare_previews with appKey ${appKey} and no pull or branch first: it tells which Pages project builds that app.`;
-            const readAll = () => (ctx.cloudflarePreviewReader ?? readCloudflarePreviews)(ctx.owner, ctx.repo, pi.cwd, { signal, pull, branch, ...(directory !== undefined && pull === undefined && branch === undefined ? { directory } : {}), ...(appProject ? { project: appProject.project } : {}) });
+            // The name of the account the project was found in is for the last screen alone.
+            let accountName;
+            const readAll = () => (ctx.cloudflarePreviewReader ?? readCloudflarePreviews)(ctx.owner, ctx.repo, pi.cwd, { signal, pull, branch, onAccountName: (name) => (accountName = name), ...(directory !== undefined && pull === undefined && branch === undefined ? { directory } : {}), ...(appProject ? { project: appProject.project } : {}) });
             const read = async () => {
                 const evidence = await readAll();
                 return appProject ? { ...evidence, previews: evidence.previews.filter((preview) => pagesProject(preview.url) === appProject.label) } : evidence;
@@ -2795,6 +2858,10 @@ export function createTools(ctx) {
             const access = branch !== undefined && previewFacts.get('cloudflare')?.enabled === true && app?.repositories !== 'all' && !cloudflareEvidence?.previews.length ? { page: app?.page ?? CLOUDFLARE_APP_PAGE, now: app?.installed === false } : undefined;
             const waited = subject ? await awaitBuild('Cloudflare', `Waiting for Cloudflare Pages to build ${subject}`, read, final, () => 'https://dash.cloudflare.com/?to=/:account/workers-and-pages', signal, access) : await read();
             const evidence = subject ? { ...waited, ...(app ? { githubApp: app } : {}) } : waited;
+            // By the label the project's addresses carry.
+            const label = (evidence.production && pagesProject(evidence.production)) || evidence.project;
+            if (accountName && label && !evidence.unmatched)
+                accountOf.set(`cloudflare ${label}`, accountName);
             if (!subject)
                 cloudflareEvidence = evidence;
             if (!subject && appKey !== undefined && !evidence.unmatched && evidence.project) {
@@ -2852,6 +2919,8 @@ export function createTools(ctx) {
             hostedPreviewProven ||= proof.proven;
             if (proof.proven)
                 provenHost = previewHostName(url) ?? provenHost;
+            if (proof.proven)
+                usedPreviews.add(url);
             if (proof.proven && app)
                 proveApp(app.appKey, url);
             if (proof.proven && app)
@@ -2862,8 +2931,16 @@ export function createTools(ctx) {
                 lockPending.set(app.appKey, proof.gate);
                 provenApps.delete(app.appKey);
             }
-            if (proof.gate && Object.hasOwn(LOCKS, proof.gate))
+            if (proof.gate && Object.hasOwn(LOCKS, proof.gate)) {
                 lastLock = proof.gate;
+                // Pristine learns the lock from the session, proven past or not, for a preview it may never meet itself (#365): an app's on its summary, a repository of one app's beside them.
+                const met = { gate: lastLock, preview_host: new URL(url).hostname };
+                // The app is proven again only once something opens it, as `provenApps` has it.
+                if (app)
+                    noteApp(app.appKey, { ...met, preview_proven: false });
+                else if (!appsRepo)
+                    ctx.sync.update({ preview_gate: met });
+            }
             if (proof.proven)
                 provePattern(proof.pattern, app?.appKey);
             if (proof.gate === 'vercel-protection' || proof.gate === 'netlify-protection')
@@ -2951,7 +3028,7 @@ export function createTools(ctx) {
                 return `Refused: the Pages project ${fact.project} is connected to the repository, and its settings turn pull-request previews off: impeccable_enable_previews turns them on.`;
             const create = !fact;
             if (create && !evidence.worker && !evidence.project)
-                return 'Refused: nothing says the repository is set up for Cloudflare: no Pages project is built from it, the checkout names none, and no Worker is built from it. Set the preview up as the server-previews or static-site case says.';
+                return 'Refused: nothing says the repository is set up for Cloudflare: no Pages project is built from it, the checkout names none, and no Worker is built from it. Set the preview up as the server-previews case says.';
             const project = fact?.project || evidence.project || pagesProjectName(ctx.repo);
             const answer = (status, more) => {
                 connectOutcome = { status, project, created: create, ...more };
@@ -3009,23 +3086,40 @@ export function createTools(ctx) {
             noteProduction(answer.productionUrl, 'vercel', undefined, connectedApp);
             return JSON.stringify(answer);
         }),
-        tool('impeccable_vercel_bypass', "Vercel's login", 'Get past the Vercel login that impeccable_prove_preview met (gate "vercel-protection") in front of a preview Vercel made, the way Vercel documents for tools: a bypass secret of the Vercel project, sent to it in a header. It does the rest with the Vercel CLI signed in as the person: it reads the project this folder is linked to (.vercel/project.json; once this run\'s own vercel link wrote that file, only what it wrote counts), or, with no such file, the one Vercel lists as connected to this repository, so no vercel link is needed (where the CLI is signed out, the consent screen comes first and its yes signs it in, in the browser), and refuses unless that project is connected to this repository, shows Deployment Protection in its settings (a page that looks like Vercel\'s login is the deployment\'s own to serve, so with none set the sign-in is the app\'s own: prove a page a visitor opens without signing in) and made the preview\'s deployment (among its latest, or read by its address), since the secret goes only to a preview the linked project serves; then it finds the project\'s secret labelled "Impeccable reviews", or shows one screen asking to create one, or, when the CLI cannot, one screen taking a pasted one; opens the preview with it; and saves it for reviews. Answers {"status": …}: saved (the preview is proven, so the method may be saved; secret says whether it was created, existing or typed, and project which Vercel project holds it), skipped (the person skipped the screen; reason says what came before), refused (no secret opened the preview; reason says what the address answered) or save-failed (the setup API did not take it all; reason says how far it got: call it once more). No secret ever comes back.', NO_INPUT, async (_p, pi, signal) => {
-            if (gated?.gate !== 'vercel-protection' || !vercelMade.has(new URL(gated.url).origin))
-                return 'Refused: this is for a preview that Vercel made, listed by impeccable_hosted_previews, which impeccable_prove_preview answered with gate "vercel-protection". Prove one first.';
-            const at = gated;
-            if (at.app)
+        tool('impeccable_vercel_bypass', "Vercel's login", 'Get past the Vercel login that impeccable_prove_preview met (gate "vercel-protection") in front of a preview Vercel made, the way Vercel documents for tools: a bypass secret of the Vercel project, sent to it in a header. It does the rest with the Vercel CLI signed in as the person: it reads the project this folder is linked to (.vercel/project.json; once this run\'s own vercel link wrote that file, only what it wrote counts), or, with no such file, the one Vercel lists as connected to this repository, so no vercel link is needed (where the CLI is signed out, the consent screen comes first and its yes signs it in, in the browser), and refuses unless that project is connected to this repository, shows Deployment Protection in its settings (a page that looks like Vercel\'s login is the deployment\'s own to serve, so with none set the sign-in is the app\'s own: prove a page a visitor opens without signing in) and made the preview\'s deployment (among its latest, or read by its address), since the secret goes only to a preview the linked project serves; then it finds the project\'s secret labelled "Impeccable reviews", or shows one screen asking to create one, or, when the CLI cannot, one screen taking a pasted one; opens the preview with it; and saves it for reviews. Answers {"status": …}: saved (the preview is proven, so the method may be saved; secret says whether it was created, existing or typed, and project which Vercel project holds it), skipped (the person skipped the screen; reason says what came before), refused (no secret opened the preview; reason says what the address answered) or save-failed (the setup API did not take it all; reason says how far it got: call it once more). No secret ever comes back. With beforePush (and the app\'s appKey on a repository with several apps), before the test drive\'s push, where no preview met Vercel\'s login yet (#356): it reads the project the same way, and where its settings show Deployment Protection in front of the previews and it holds no secret labelled "Impeccable reviews", shows the consent screen now, naming the project and the app, so the person answers before anything is pushed; the secret is made on the yes once the test drive\'s preview meets the login, with no second question. Answers {"protected": false} (no lock: push), {"protected": true, "consent": "given" or "not-needed"} (push, and call this again without beforePush once the proof meets the gate), {"protected": "unknown", "reason": …} (the project could not be read: push, and the consent comes when the gate is met) or {"status": "skipped", …} (push no test drive; reason says why).', VERCEL_BYPASS, async (p, pi, signal) => {
+            const before = p.beforePush === true;
+            if (before) {
+                const refused = appRefusal(p.appKey, 'asked');
+                if (refused)
+                    return refused;
+            }
+            else if (gated?.gate !== 'vercel-protection' || !vercelMade.has(new URL(gated.url).origin))
+                return 'Refused: this is for a preview that Vercel made, listed by impeccable_hosted_previews, which impeccable_prove_preview answered with gate "vercel-protection". Prove one first, or call it with beforePush before the test drive\'s push.';
+            const at = before ? undefined : gated;
+            if (at?.app)
                 lockPending.delete(at.app.appKey);
-            const { origin, host } = new URL(at.url);
+            const vercel = (ctx.hostRunner ?? commandRunner)('vercel', pi.cwd, { signal });
+            // Before the push, the app's project as impeccable_hosted_previews reads it: the one that builds the app's folder (#281).
+            let app = at?.app;
+            if (before && appsRepo) {
+                const read = await vercelApp(pi, p.appKey, vercel);
+                if ('reason' in read)
+                    return JSON.stringify({ appKey: p.appKey, protected: 'unknown', reason: read.reason });
+                app = { appKey: p.appKey, link: read.link, name: read.name };
+            }
             // Where the setup API keeps the secret: the app's own on a repository with several apps, else the repository's.
-            const store = at.app?.appKey ?? '';
+            const store = app?.appKey ?? '';
             const asked = bypassOutcomes.get(store);
             if (asked?.status === 'skipped')
                 return JSON.stringify(asked);
+            /** What stops the tool before the project is vouched for: the address got nothing, or, before the push, the lock is not known yet and the gate's call asks. */
+            const nothing = (why) => (at ? `Refused: nothing was sent to ${at.url}. ${why}` : JSON.stringify({ ...(app ? { appKey: app.appKey } : {}), protected: 'unknown', reason: why }));
+            /** The consent screen, naming the project and the app once they are known (#358). */
+            const consentScreen = (project) => vercelBypassConsent(project ?? app?.name, app && appName(app.appKey));
             // Whose preview this is: a deployment status anyone with push access records gives any address, and the page there says nothing, so the project has to have
             // made the deployment before any secret of it goes there. That project is the app's own on a repository with several apps (#281), else the one the link file names,
             // else the one Vercel lists as connected to this repository (#310).
-            const vercel = (ctx.hostRunner ?? commandRunner)('vercel', pi.cwd, { signal });
-            const fileLink = at.app ? null : await readLink(pi.cwd);
+            const fileLink = app ? null : await readLink(pi.cwd);
             /** The consent screen's yes, given before Vercel's sign-in, stands for the secret: it is not asked again. */
             let consented = false;
             /**
@@ -3039,7 +3133,7 @@ export function createTools(ctx) {
                     bypassOutcomes.set(store, outcome);
                     return JSON.stringify(outcome);
                 };
-                if ((await ask(sentTo(HOST_SCREENS['vercel-bypass'], at.url))).skipped)
+                if ((await ask(consentScreen())).skipped)
                     return skip('The person skipped creating a bypass secret.');
                 consented = true;
                 const agreed = hostSetupAgreed(ctx.log, 'vercel');
@@ -3062,23 +3156,23 @@ export function createTools(ctx) {
             // A folder Vercel deploys from GitHub has no link file unless vercel link ran in it (the file is gitignored), so the project is found on Vercel by this repository,
             // with the CLI signed in as the person.
             let found;
-            if (!at.app && !fileLink) {
+            if (!app && !fileLink) {
                 const cli = (await vercelStatus(vercel)).cli;
                 const stop = cli === 'signed-out' ? await signIn() : null;
                 if (stop)
                     return stop;
                 const listed = cli === 'missing' ? { reason: 'The Vercel CLI is not installed here.' } : await vercelRepoProject(vercel, repository);
                 if ('reason' in listed)
-                    return `Refused: nothing was sent to ${at.url}. This folder is linked to no Vercel project (.vercel/project.json), and Vercel named none for this repository: ${listed.reason} A bypass secret goes only to a preview the repository's project serves.`;
+                    return nothing(`This folder is linked to no Vercel project (.vercel/project.json), and Vercel named none for this repository: ${listed.reason} A bypass secret goes only to a preview the repository's project serves.`);
                 found = listed;
             }
-            const link = at.app?.link ?? fileLink ?? found.link;
+            const link = app?.link ?? fileLink ?? found.link;
             // Once this run's own vercel link wrote the file, only that link counts, as impeccable_vercel_connect holds it: rewritten since, it would name another project of the person's. A project the person linked before the run has no such record, and the reads below vouch for it.
             // An app's project, and one found with no link file, are read from Vercel's list of this repository's projects, never from the file.
             const links = linkedByRun(ctx.log);
             const own = links.get(link.projectId);
             if (fileLink && [...links.values()].some((l) => l.orgId !== undefined) && own?.orgId !== link.orgId)
-                return `Refused: nothing was sent to ${at.url}. This folder's .vercel/project.json is not what this run's vercel link wrote (another project, or another team), and a bypass secret goes only to a preview the linked project serves.`;
+                return nothing("This folder's .vercel/project.json is not what this run's vercel link wrote (another project, or another team), and a bypass secret goes only to a preview the linked project serves.");
             let project = await readOwnProject(vercel, link, repository);
             // A linked project, or an app's, read nothing because the CLI is signed out: the same sign-in, then the read again.
             if ('reason' in project && !consented && (await vercelStatus(vercel)).cli === 'signed-out') {
@@ -3087,9 +3181,27 @@ export function createTools(ctx) {
                     return stop;
                 project = await readOwnProject(vercel, link, repository);
             }
-            const which = at.app ? 'The Vercel project that builds this app' : found ? 'The Vercel project connected to this repository' : 'The Vercel project this folder is linked to';
+            const which = app ? 'The Vercel project that builds this app' : found ? 'The Vercel project connected to this repository' : 'The Vercel project this folder is linked to';
             if ('reason' in project)
-                return `Refused: nothing was sent to ${at.url}. ${project.reason} A bypass secret goes only to a preview the linked project serves.`;
+                return nothing(`${project.reason} A bypass secret goes only to a preview the linked project serves.`);
+            if (!at) {
+                // Before the push: the project's settings say whether Vercel's login will stand in front of the test drive's preview, and the consent is asked now (#356).
+                const of = { ...(app ? { appKey: app.appKey } : {}), ...(project.name ? { project: project.name } : {}) };
+                if (!project.previewsProtected)
+                    return JSON.stringify({ ...of, protected: false });
+                // A secret this run saved for the same store and project, or one labelled for Impeccable, opens the test drive's preview with no question; a yes given already stands.
+                const held = bypassHeld.get(store);
+                if (project.bypassLabelled || held?.projectId === link.projectId)
+                    return JSON.stringify({ ...of, protected: true, consent: 'not-needed' });
+                if (consented || bypassConsented.has(`${store}/${link.projectId}`) || !(await ask(consentScreen(project.name))).skipped) {
+                    bypassConsented.add(`${store}/${link.projectId}`);
+                    return JSON.stringify({ ...of, protected: true, consent: 'given' });
+                }
+                const outcome = { status: 'skipped', ...of, protected: true, reason: `The person skipped creating a bypass secret before the test drive's push. Vercel's login stands in front of the previews of ${project.name ? `the Vercel project ${project.name}` : 'the Vercel project'}, so a test drive pushed now could not be reviewed. A secret made in the project's Settings → Deployment Protection → Protection Bypass for Automation, named "Impeccable reviews", and saved on the setup page lets reviews in.` };
+                bypassOutcomes.set(store, outcome);
+                return JSON.stringify(outcome);
+            }
+            const { origin, host } = new URL(at.url);
             // The page at the address is the deployment's to word, whatever host it is on, so the lock is told from the project's settings, read as the person: with none, no login of Vercel's stood in front.
             if (!project.previewsProtected && lastLock === 'vercel-protection')
                 lastLock = undefined;
@@ -3102,6 +3214,8 @@ export function createTools(ctx) {
                 bypassOrigins.set(origin, store);
                 hostedPreviewProven = true;
                 provenHost = 'Vercel';
+                usedPreviews.add(at.url);
+                vercelNamed.set(origin, { ...(project.name ? { project: project.name } : {}), ...(found?.scope ? { team: found.scope } : {}) });
                 if (at.app)
                     proveApp(at.app.appKey, at.url);
             };
@@ -3118,7 +3232,8 @@ export function createTools(ctx) {
                 link: async () => link,
                 // A project the folder is not linked to is named on the CLI's reads and makes, in its own team; the reads are held to its id all the same.
                 ...(at.app?.name ? { project: at.app.name } : found ? { project: found.name, ...(found.scope ? { scope: found.scope } : {}) } : {}),
-                consent: async () => consented || !(await ask(sentTo(HOST_SCREENS['vercel-bypass'], at.url))).skipped,
+                // A yes before the push stands for this secret: the gate's call asks no second time (#356).
+                consent: async () => consented || bypassConsented.has(`${store}/${link.projectId}`) || !(await ask(consentScreen(project.name))).skipped,
                 paste: async (stopped) => {
                     // This project's own settings page, under its own team (the one its ids name, as the CLI lists the person's teams): never another project of the account's.
                     (ctx.openBrowser ?? openBrowser)(await vercelPageFor(vercel, link, 'settings/deployment-protection', project.name));
@@ -3134,6 +3249,8 @@ export function createTools(ctx) {
                     return saved.failed;
                 },
                 remember: noteSensitiveAnswer,
+                // A secret the run made stays in the person's Vercel project, whatever comes after: the end screen says so, and where it is revoked (#335).
+                made: (held, name) => ctx.onKeyCreated?.(`Impeccable created a Vercel bypass secret${held === 'labelled' ? ', "Impeccable reviews",' : ' without a label'}${name ? ` on the ${name} project` : ''}. Revoke it under the project's Settings → Deployment Protection → Protection Bypass for Automation; reviews stop until a new one is saved.`),
             });
             const outcome = { ...told, ...(at.app ? { appKey: at.app.appKey } : {}), ...(told.status === 'saved' ? { proven: true } : {}) };
             bypassOutcomes.set(store, outcome);
@@ -3236,6 +3353,7 @@ export function createTools(ctx) {
                 // The site is public now: its previews open with nothing sent.
                 hostedPreviewProven = true;
                 provenHost = 'Netlify';
+                usedPreviews.add(at.url);
                 if (at.app)
                     proveApp(at.app.appKey, at.url);
                 provePattern(pattern, at.app?.appKey);
@@ -3247,6 +3365,7 @@ export function createTools(ctx) {
                 passwordSites.add(site);
                 hostedPreviewProven = true;
                 provenHost = 'Netlify';
+                usedPreviews.add(at.url);
                 if (at.app)
                     proveApp(at.app.appKey, at.url);
                 provePattern(pattern, at.app?.appKey);
@@ -3260,7 +3379,7 @@ export function createTools(ctx) {
             }
             return JSON.stringify(passwordOutcome);
         }),
-        tool('impeccable_cloudflare_access', 'Cloudflare Access', 'Get past the Cloudflare Access login that impeccable_prove_preview met (gate "cloudflare-access") in front of a Cloudflare Pages preview, the way Cloudflare documents for tools: a service token, sent in two headers, that a Service Auth policy of the Access application allows. It does the rest as the person: one screen asking to create the token, Cloudflare\'s sign-in in the browser where cf, Cloudflare\'s CLI, is not signed in here with Access (with a retry), then the token named "Impeccable reviews" created through cf and allowed in the policy of the application in front of the preview (an application whose policies are its own gets one screen asking to make them reusable first, and on its skip the paste screen says how to make the token by hand); one screen taking a Cloudflare API token only where that sign-in cannot create it; on a skip, or where that cannot be done, one screen taking a pasted client id and secret, only once an Access application in the person\'s accounts was read to cover the preview (none read: refused, with the reason, since the token goes to no other address). It opens the preview with the token and saves it for reviews. Answers {"status": …}: saved (the preview is proven, and pattern is the address pattern to save with the method; token says whether it was created or typed, application which Access application allows it, expires when a created one runs out, apiToken true when the person\'s Cloudflare API token created it), skipped (nothing was saved; reason says what stopped it), refused (no Access application of the person\'s covers the preview, or the typed token did not open it; reason says which) or save-failed (the setup API did not take it all; reason says how far it got: call it once more). No token ever comes back.', NO_INPUT, async (_p, pi, signal) => {
+        tool('impeccable_cloudflare_access', 'Cloudflare Access', 'Get past the Cloudflare Access login that impeccable_prove_preview met (gate "cloudflare-access") in front of a Cloudflare Pages preview, the way Cloudflare documents for tools: a service token, sent in two headers, that a Service Auth policy of the Access application allows. It does the rest as the person: one screen asking to create the token, naming the Access application in front of the preview and its Cloudflare account once cf, signed in here, found it (none found: refused, and nothing asked), Cloudflare\'s sign-in in the browser where cf, Cloudflare\'s CLI, is not signed in here with Access (with a retry), then the token named "Impeccable reviews" created through cf and allowed in the policy of the application in front of the preview (an application whose policies are its own gets one screen asking to make them reusable first, and on its skip the paste screen says how to make the token by hand); one screen taking a Cloudflare API token only where that sign-in cannot create it; on a skip, or where that cannot be done, one screen taking a pasted client id and secret, only once an Access application in the person\'s accounts was read to cover the preview (none read: refused, with the reason, since the token goes to no other address). It opens the preview with the token and saves it for reviews. Answers {"status": …}: saved (the preview is proven, and pattern is the address pattern to save with the method; token says whether it was created or typed, application which Access application allows it, expires when a created one runs out, apiToken true when the person\'s Cloudflare API token created it), skipped (nothing was saved; reason says what stopped it), refused (no Access application of the person\'s covers the preview, or the typed token did not open it; reason says which) or save-failed (the setup API did not take it all; reason says how far it got: call it once more). No token ever comes back.', NO_INPUT, async (_p, pi, signal) => {
             if (!accessGated)
                 return 'Refused: this is for a Cloudflare Pages preview impeccable_cloudflare_previews listed, which impeccable_prove_preview answered with gate "cloudflare-access". Prove one first.';
             const at = accessGated;
@@ -3298,7 +3417,15 @@ export function createTools(ctx) {
             else {
                 answer = await passCloudflareAccess({
                     url: at.url,
-                    consent: async () => !(await ask(sentTo(HOST_SCREENS['cloudflare-access'], at.url))).skipped,
+                    // Named once the Access application was found (#357), and asked once per application: a yes stands for another app's previews it covers.
+                    consent: async (found) => {
+                        if (found && accessConsented.has(found.id))
+                            return true;
+                        const yes = !(await ask(sentTo(found ? cloudflareAccessConsent(found, new URL(at.url).host, at.app && appName(at.app.appKey)) : HOST_SCREENS['cloudflare-access'], at.url))).skipped;
+                        if (yes && found)
+                            accessConsented.add(found.id);
+                        return yes;
+                    },
                     cf: cfRunner({ checkout: pi.cwd }, ctx.hostRunner),
                     login: cfRunner({ browser: true, timeoutMs: 300_000, checkout: pi.cwd }, ctx.hostRunner),
                     retry: async () => !(await ask(HOST_SCREENS['cloudflare-signin-retry'])).skipped,
@@ -3335,6 +3462,7 @@ export function createTools(ctx) {
             if (told.status === 'saved') {
                 hostedPreviewProven = true;
                 provenHost = 'Cloudflare Pages';
+                usedPreviews.add(at.url);
                 if (at.app)
                     proveApp(at.app.appKey, at.url);
                 provePattern(pattern, at.app?.appKey);