@hztxi/cesium-engine 25.0.7 → 26.2.1

package/Source/Scene/Picking.js

@@ -247,6 +247,7 @@ const scratchColorZero = new Color(0.0, 0.0, 0.0, 0.0);
  * height will default to the value of <code>width</code>
  * @param {BoundingRectangle} result The result rectangle
  * @returns {BoundingRectangle} The result rectangle
+ * @ignore
  */
 function computePickingDrawingBufferRectangle(
   drawingBufferHeight,
@@ -265,21 +266,31 @@ function computePickingDrawingBufferRectangle(
 /**
  * Setup needed before picking.
  *
+ * Exported for use by Snapping, which performs the same offscreen pick render
+ * but targets the snap framebuffer and flags the pass as a snapping pass.
+ *
  * @param {Scene} scene
  * @param {Cartesian2} windowPosition Window coordinates to perform picking on.
  * @param {BoundingRectangle} drawingBufferRectangle The output drawing buffer recangle.
  * @param {number} [width=3] Width of the pick rectangle.
  * @param {number} [height=3] Height of the pick rectangle.
+ * @param {object} [options] Object with the following properties:
+ * @param {PickFramebuffer|SnapFramebuffer} [options.framebuffer] The framebuffer to render into. Defaults to the view's pick framebuffer.
+ * @param {boolean} [options.snap=false] If <code>true</code>, mark the pass as a snapping pass (sets <code>frameState.passes.snap</code>).
+ *
+ * @private
  */
-function pickBegin(
+export function pickBegin(
   scene,
   windowPosition,
   drawingBufferRectangle,
   width,
   height,
+  options,
 ) {
   const { context, frameState, defaultView } = scene;
   const { viewport, pickFramebuffer } = defaultView;
+  const framebuffer = options?.framebuffer ?? pickFramebuffer;
 
   scene.view = defaultView;
 
@@ -316,13 +327,14 @@ function pickBegin(
   );
   frameState.invertClassification = false;
   frameState.passes.pick = true;
+  frameState.passes.snap = options?.snap ?? false;
   frameState.tilesetPassState = pickTilesetPassState;
 
   context.uniformState.update(frameState);
 
   scene.updateEnvironment();
 
-  passState = pickFramebuffer.begin(drawingBufferRectangle, viewport);
+  passState = framebuffer.begin(drawingBufferRectangle, viewport);
 
   scene.updateAndExecuteCommands(passState, scratchColorZero);
   scene.resolveFramebuffers(passState);
@@ -332,8 +344,10 @@ function pickBegin(
  * Teardown needed after picking.
  *
  * @param {Scene} scene
+ *
+ * @private
  */
-function pickEnd(scene) {
+export function pickEnd(scene) {
   const { context } = scene;
   context.endFrame();
 }
@@ -808,6 +822,7 @@ Picking.prototype.pickPosition = function (scene, windowPosition, result) {
  * @param {object[]} pickedAttributes
  * @param {object[]} pickedFeatures
  * @returns {boolean} whether picking should end
+ * @ignore
  */
 function addDrillPickedResults(
   pickedResults,
@@ -875,6 +890,7 @@ function addDrillPickedResults(
  * @param {function(number): object[]} pickCallback Pick callback to execute each iteration
  * @param {number} [limit=Number.MAX_VALUE] If supplied, stop drilling after collecting this many picks
  * @returns {object[]} List of picked results
+ * @ignore
  */
 function drillPick(pickCallback, limit) {
   // PERFORMANCE_IDEA: This function calls each primitive's update for each pass. Instead

package/Source/Scene/PlanarFillIdFramebuffer.js

@@ -0,0 +1,172 @@
+import defined from "../Core/defined.js";
+import destroyObject from "../Core/destroyObject.js";
+import PixelFormat from "../Core/PixelFormat.js";
+import Color from "../Core/Color.js";
+import PixelDatatype from "../Renderer/PixelDatatype.js";
+import FramebufferManager from "../Renderer/FramebufferManager.js";
+import ClearCommand from "../Renderer/ClearCommand.js";
+
+/**
+ * Creates and manages a framebuffer for the planar fill feature-ID pre-pass.
+ *
+ * During this pass, non-behind planar fill geometry writes its per-fragment
+ * feature ID into a screen-sized texture. Later, primitives with
+ * <code>behind: true</code> (BENTLEY_materials_planar_fill) sample this
+ * texture to check whether the pixel they are about to overwrite belongs to
+ * the same logical object (same feature ID). Only then do they apply an
+ * additional depth offset, pushing the fill behind its own object's edges
+ * and non-behind fills — but NOT behind other objects.
+ *
+ * Layout:
+ *   Color attachment 0 – R32F (single RED channel): encoded feature ID.
+ *   Depth-stencil attachment – shared with the main scene for correct depth testing.
+ *
+ * @alias PlanarFillIdFramebuffer
+ * @constructor
+ * @private
+ */
+function PlanarFillIdFramebuffer() {
+  this._framebufferManager = new FramebufferManager({
+    colorAttachmentsLength: 1,
+    createColorAttachments: true,
+    depthStencil: true,
+    supportsDepthTexture: true,
+    color: true,
+  });
+
+  this._framebuffer = undefined;
+  this._idTexture = undefined;
+  this._depthStencilTexture = undefined;
+
+  this._clearCommand = new ClearCommand({
+    color: new Color(0.0, 0.0, 0.0, 0.0),
+    depth: 1.0,
+    stencil: 0,
+    owner: this,
+  });
+}
+
+Object.defineProperties(PlanarFillIdFramebuffer.prototype, {
+  /**
+   * Gets the underlying framebuffer.
+   * @memberof PlanarFillIdFramebuffer.prototype
+   * @type {Framebuffer}
+   * @readonly
+   */
+  framebuffer: {
+    get: function () {
+      return this._framebuffer;
+    },
+  },
+
+  /**
+   * Gets the feature-ID texture (color attachment 0).
+   * @memberof PlanarFillIdFramebuffer.prototype
+   * @type {Texture}
+   * @readonly
+   */
+  idTexture: {
+    get: function () {
+      return this._idTexture;
+    },
+  },
+
+  /**
+   * Gets the depth-stencil texture.
+   * @memberof PlanarFillIdFramebuffer.prototype
+   * @type {Texture}
+   * @readonly
+   */
+  depthStencilTexture: {
+    get: function () {
+      return this._depthStencilTexture;
+    },
+  },
+});
+
+/**
+ * Updates (creates / resizes) the framebuffer to match the viewport.
+ *
+ * @param {Context} context
+ * @param {BoundingRectangle} viewport
+ * @param {boolean} hdr
+ * @returns {boolean} <code>true</code> if the framebuffer was recreated.
+ */
+PlanarFillIdFramebuffer.prototype.update = function (context, viewport, hdr) {
+  const width = viewport.width;
+  const height = viewport.height;
+
+  // Feature IDs are integers, so a 32-bit float channel provides plenty of range
+  // for feature IDs. A single RED channel (R32F) is used since only one value is
+  // stored per pixel. Rendering to R32F requires EXT_color_buffer_float, which is
+  // available in WebGL2 on all browsers CesiumJS supports; the UNSIGNED_BYTE fallback
+  // below only exists for stubbed WebGL contexts possibly used in tests.
+  const pixelDatatype = context.colorBufferFloat
+    ? PixelDatatype.FLOAT
+    : PixelDatatype.UNSIGNED_BYTE;
+
+  const changed = this._framebufferManager.update(
+    context,
+    width,
+    height,
+    1, // no MSAA
+    pixelDatatype,
+    PixelFormat.RED,
+  );
+
+  if (this._framebufferManager.framebuffer) {
+    this._framebuffer = this._framebufferManager.framebuffer;
+    this._idTexture = this._framebufferManager.getColorTexture(0);
+    this._depthStencilTexture =
+      this._framebufferManager.getDepthStencilTexture();
+  }
+
+  return changed;
+};
+
+/**
+ * Returns a ClearCommand that targets this framebuffer.
+ *
+ * @param {Color} [clearColor] Override the clear color (default: transparent black).
+ * @returns {ClearCommand}
+ */
+PlanarFillIdFramebuffer.prototype.getClearCommand = function (clearColor) {
+  this._clearCommand.framebuffer = this._framebuffer;
+  if (defined(clearColor)) {
+    Color.clone(clearColor, this._clearCommand.color);
+  }
+  return this._clearCommand;
+};
+
+/**
+ * Releases GPU resources without destroying this object; a later call to
+ * {@link PlanarFillIdFramebuffer#update} recreates them.
+ */
+PlanarFillIdFramebuffer.prototype.releaseResources = function () {
+  if (!defined(this._framebuffer)) {
+    return;
+  }
+  this._framebufferManager.destroy();
+  this._framebuffer = undefined;
+  this._idTexture = undefined;
+  this._depthStencilTexture = undefined;
+};
+
+/**
+ * @returns {boolean}
+ */
+PlanarFillIdFramebuffer.prototype.isDestroyed = function () {
+  return false;
+};
+
+/**
+ * Destroys WebGL resources.
+ */
+PlanarFillIdFramebuffer.prototype.destroy = function () {
+  this._framebufferManager =
+    this._framebufferManager && this._framebufferManager.destroy();
+  this._clearCommand = undefined;
+  return destroyObject(this);
+};
+
+export default PlanarFillIdFramebuffer;

package/Source/Scene/PntsParser.js

@@ -105,7 +105,6 @@ PntsParser.parse = function (arrayBuffer, byteOffset) {
       );
       // Copy the batchTableBinary section and let the underlying ArrayBuffer be freed
       batchTableBinary = new Uint8Array(batchTableBinary);
-      byteOffset += batchTableBinaryByteLength;
     }
   }
 
@@ -214,6 +213,7 @@ PntsParser.parse = function (arrayBuffer, byteOffset) {
  * a one-time warning will be printed.
  *
  * @param {object} parsedContent The parsed content
+ * @ignore
  */
 function removeInvalidBinaryBodyReferences(parsedContent) {
   const batchTableJson = parsedContent.batchTableJson;

package/Source/Scene/PolylineCollection.js

@@ -431,7 +431,8 @@ PolylineCollection.prototype.update = function (frameState) {
 
   const columbusRepeatWorlds =
     frameState.columbusRepeatWorlds === true &&
-    frameState.mode === SceneMode.COLUMBUS_VIEW;
+    (frameState.mode === SceneMode.SCENE2D ||
+      frameState.mode === SceneMode.COLUMBUS_VIEW);
   if (this._columbusRepeatWorlds !== columbusRepeatWorlds) {
     // Toggling repeat worlds changes whether polylines are split at the IDL,
     // which changes vertex buffer sizes; rebuild the vertex arrays.
@@ -1802,10 +1803,11 @@ PolylineBucket.prototype.getSegments = function (polyline, projection) {
 
   if (
     newPositions.length > 0 &&
-    this.mode === SceneMode.COLUMBUS_VIEW &&
+    (this.mode === SceneMode.SCENE2D ||
+      this.mode === SceneMode.COLUMBUS_VIEW) &&
     polyline._polylineCollection._columbusRepeatWorlds === true
   ) {
-    // Columbus repeat worlds: the IDL split is disabled in this mode, so lift
+    // Repeat worlds: the IDL split is disabled in this mode, so lift
     // consecutive projected u values onto the same world copy. The line stays
     // in the primary world; the scene renders the visible world copies by
     // shifting the camera, so a line crossing the seam needs no per-copy

package/Source/Scene/PostProcessStage.js

@@ -640,8 +640,10 @@ function createStageOutputTextureFunction(stage, name) {
 function updateUniformTextures(stage, context) {
   const texturesToRelease = stage._texturesToRelease;
   for (let i = 0; i < texturesToRelease.length; ++i) {
-    let texture = texturesToRelease[i];
-    texture = texture && texture.destroy();
+    const texture = texturesToRelease[i];
+    if (defined(texture)) {
+      texture.destroy();
+    }
   }
   texturesToRelease.length = 0;
 

package/Source/Scene/QuadtreePrimitive.js

@@ -1781,11 +1781,12 @@ function updateHeights(primitive, frameState) {
           );
 
           if (defined(position)) {
-            // Store the computed position in the cache for future reuse
+            // `pick` wrote into the module-level `scratchPosition`, so `position`
+            // aliases it — clone before caching or the next pick mutates every entry.
             tile.setPositionCacheEntry(
               data.positionCartographic,
               primitive.maximumScreenSpaceError,
-              position,
+              Cartesian3.clone(position),
             );
           }
         }

package/Source/Scene/ResourceCache.js

@@ -419,7 +419,7 @@ ResourceCache.getSpzLoader = function (options) {
 
   const cacheKey = ResourceCacheKey.getSpzCacheKey({
     gltf: gltf,
-    primitive: primitive,
+    spz: spz,
     gltfResource: gltfResource,
     baseResource: baseResource,
   });
@@ -453,13 +453,14 @@ ResourceCache.getSpzLoader = function (options) {
  * @param {number} [options.bufferViewId] The bufferView ID corresponding to the vertex buffer.
  * @param {object} [options.primitive] The primitive containing the Draco extension.
  * @param {object} [options.draco] The Draco extension object.
+ * @param {object} [options.spz] The SPZ extension object.
  * @param {string} [options.attributeSemantic] The attribute semantic, e.g. POSITION or NORMAL.
  * @param {number} [options.accessorId] The accessor ID.
  * @param {boolean} [options.asynchronous=true] Determines if WebGL resource creation will be spread out over several frames or block until all WebGL resources are created.
  * @param {boolean} [options.dequantize=false] Determines whether or not the vertex buffer will be dequantized on the CPU.
  * @param {boolean} [options.loadBuffer=false] Load vertex buffer as a GPU vertex buffer.
  * @param {boolean} [options.loadTypedArray=false] Load vertex buffer as a typed array.
- * @exception {DeveloperError} One of options.bufferViewId and options.draco must be defined.
+ * @exception {DeveloperError} Exactly one vertex buffer source must be effective: options.bufferViewId, options.spz, or options.draco for options.attributeSemantic.
  * @exception {DeveloperError} When options.draco is defined options.attributeSemantic must also be defined.
  * @exception {DeveloperError} When options.draco is defined options.accessorId must also be defined.
  *
@@ -503,9 +504,11 @@ ResourceCache.getVertexBufferLoader = function (options) {
   const hasAccessorId = defined(accessorId);
   const hasSpz = defined(spz);
 
-  if (hasBufferViewId === (hasDraco !== hasSpz)) {
+  const sourceCount =
+    Number(hasBufferViewId) + Number(hasDraco) + Number(hasSpz);
+  if (sourceCount !== 1) {
     throw new DeveloperError(
-      "One of options.bufferViewId, options.draco, or options.spz must be defined.",
+      "Exactly one vertex buffer source must be effective: options.bufferViewId, options.spz, or options.draco for options.attributeSemantic.",
     );
   }
 

package/Source/Scene/ResourceCacheKey.js

@@ -3,8 +3,8 @@ import Frozen from "../Core/Frozen.js";
 import defined from "../Core/defined.js";
 import DeveloperError from "../Core/DeveloperError.js";
 import getAbsoluteUri from "../Core/getAbsoluteUri.js";
+import findMeshoptExtension from "./findMeshoptExtension.js";
 import GltfLoaderUtil from "./GltfLoaderUtil.js";
-import hasExtension from "./hasExtension.js";
 
 /**
  * Compute cache keys for resources in {@link ResourceCache}.
@@ -22,8 +22,8 @@ function getExternalResourceCacheKey(resource) {
 function getBufferViewCacheKey(bufferView) {
   let { byteOffset, byteLength } = bufferView;
 
-  if (hasExtension(bufferView, "EXT_meshopt_compression")) {
-    const meshopt = bufferView.extensions.EXT_meshopt_compression;
+  const meshopt = findMeshoptExtension(bufferView);
+  if (defined(meshopt)) {
     byteOffset = meshopt.byteOffset ?? 0;
     byteLength = meshopt.byteLength;
   }
@@ -71,8 +71,8 @@ function getDracoCacheKey(gltf, draco, gltfResource, baseResource) {
   return `${bufferCacheKey}-range-${bufferViewCacheKey}`;
 }
 
-function getSpzCacheKey(gltf, primitive, gltfResource, baseResource) {
-  const bufferViewId = 0;
+function getSpzCacheKey(gltf, spz, gltfResource, baseResource) {
+  const bufferViewId = spz.bufferView;
   const bufferView = gltf.bufferViews[bufferViewId];
   const bufferId = bufferView.buffer;
   const buffer = gltf.buffers[bufferId];
@@ -247,8 +247,8 @@ ResourceCacheKey.getBufferViewCacheKey = function (options) {
   const bufferView = gltf.bufferViews[bufferViewId];
   let bufferId = bufferView.buffer;
   const buffer = gltf.buffers[bufferId];
-  if (hasExtension(bufferView, "EXT_meshopt_compression")) {
-    const meshopt = bufferView.extensions.EXT_meshopt_compression;
+  const meshopt = findMeshoptExtension(bufferView);
+  if (defined(meshopt)) {
     bufferId = meshopt.buffer;
   }
 
@@ -292,16 +292,16 @@ ResourceCacheKey.getDracoCacheKey = function (options) {
 
 ResourceCacheKey.getSpzCacheKey = function (options) {
   options = options ?? Frozen.EMPTY_OBJECT;
-  const { gltf, primitive, gltfResource, baseResource } = options;
+  const { gltf, spz, gltfResource, baseResource } = options;
 
   //>>includeStart('debug', pragmas.debug);
   Check.typeOf.object("options.gltf", gltf);
-  Check.typeOf.object("options.primitive", primitive);
+  Check.typeOf.object("options.spz", spz);
   Check.typeOf.object("options.gltfResource", gltfResource);
   Check.typeOf.object("options.baseResource", baseResource);
   //>>includeEnd('debug');
 
-  return `spz:${getSpzCacheKey(gltf, primitive, gltfResource, baseResource)}`;
+  return `spz:${getSpzCacheKey(gltf, spz, gltfResource, baseResource)}`;
 };
 /**
  * Gets the vertex buffer cache key.
@@ -313,11 +313,12 @@ ResourceCacheKey.getSpzCacheKey = function (options) {
  * @param {FrameState} options.frameState The frame state.
  * @param {number} [options.bufferViewId] The bufferView ID corresponding to the vertex buffer.
  * @param {object} [options.draco] The Draco extension object.
+ * @param {object} [options.spz] The SPZ extension object.
  * @param {string} [options.attributeSemantic] The attribute semantic, e.g. POSITION or NORMAL.
  * @param {boolean} [options.dequantize=false] Determines whether or not the vertex buffer will be dequantized on the CPU.
  * @param {boolean} [options.loadBuffer=false] Load vertex buffer as a GPU vertex buffer.
  * @param {boolean} [options.loadTypedArray=false] Load vertex buffer as a typed array.
- * @exception {DeveloperError} One of options.bufferViewId and options.draco must be defined.
+ * @exception {DeveloperError} Exactly one vertex buffer source must be effective: options.bufferViewId, options.spz, or options.draco for options.attributeSemantic.
  * @exception {DeveloperError} When options.draco is defined options.attributeSemantic must also be defined.
  *
  * @returns {string} The vertex buffer cache key.
@@ -350,9 +351,11 @@ ResourceCacheKey.getVertexBufferCacheKey = function (options) {
   const hasAttributeSemantic = defined(attributeSemantic);
   const hasSpz = defined(spz);
 
-  if (hasBufferViewId === (hasDraco !== hasSpz)) {
+  const sourceCount =
+    Number(hasBufferViewId) + Number(hasDraco) + Number(hasSpz);
+  if (sourceCount !== 1) {
     throw new DeveloperError(
-      "One of options.bufferViewId and options.draco must be defined.",
+      "Exactly one vertex buffer source must be effective: options.bufferViewId, options.spz, or options.draco for options.attributeSemantic.",
     );
   }
 
@@ -388,6 +391,11 @@ ResourceCacheKey.getVertexBufferCacheKey = function (options) {
     cacheKeySuffix += "-typed-array";
   }
 
+  if (defined(spz)) {
+    const spzCacheKey = getSpzCacheKey(gltf, spz, gltfResource, baseResource);
+    return `vertex-buffer:${spzCacheKey}-spz-${attributeSemantic}${cacheKeySuffix}`;
+  }
+
   if (defined(draco)) {
     const dracoCacheKey = getDracoCacheKey(
       gltf,
@@ -398,11 +406,6 @@ ResourceCacheKey.getVertexBufferCacheKey = function (options) {
     return `vertex-buffer:${dracoCacheKey}-draco-${attributeSemantic}${cacheKeySuffix}`;
   }
 
-  if (spz) {
-    const spzCacheKey = getSpzCacheKey(gltf, spz, gltfResource, baseResource);
-    return `vertex-buffer:${spzCacheKey}-spz-${attributeSemantic}${cacheKeySuffix}`;
-  }
-
   const bufferView = gltf.bufferViews[bufferViewId];
   const bufferId = bufferView.buffer;
   const buffer = gltf.buffers[bufferId];