@hybridlabor-api/aos 4.4.1 → 4.4.2-beta.0

package/bin/aos-uninstall.mjs

@@ -0,0 +1,227 @@
+#!/usr/bin/env node
+// Remove AOS from this machine.
+//
+//   aos-uninstall              what AOS installed; your data stays
+//   aos-uninstall --purge      also the memory store, wikis and credentials
+//   aos-uninstall --dry-run    list everything, delete nothing
+//   aos-uninstall --yes        skip the confirmations (CI only)
+//
+// The file-level install manifest records every path AOS wrote together with
+// the sha256 it wrote. That is what makes a precise uninstall possible: a file
+// still matching its recorded hash is ours and untouched, so it goes; a file
+// that differs was edited after installation and is backed up rather than
+// deleted; a file with no manifest entry was never ours and is not considered
+// at all.
+
+import { readFileSync, existsSync, rmSync, copyFileSync, readdirSync, statSync, writeFileSync } from 'node:fs';
+import { execFileSync } from 'node:child_process';
+import { createHash } from 'node:crypto';
+import { createInterface } from 'node:readline/promises';
+import os from 'node:os';
+import path from 'node:path';
+
+const HOME = os.homedir();
+const h = (...p) => path.join(HOME, ...p);
+const tilde = (p) => p.replace(HOME, '~');
+
+const PURGE = process.argv.includes('--purge');
+const DRY = process.argv.includes('--dry-run');
+const YES = process.argv.includes('--yes');
+
+const MANIFEST = h('.agents', '.bdb-install-manifest.json');
+
+// Machine-global state AOS creates but does not own the contents of. Removed
+// only under --purge, and each is named individually before anything happens —
+// losing a memory store to a flag nobody read would be unforgivable.
+const DATA_PATHS = [
+  { path: h('.MemBDB'), what: 'memB memory store — every memory on this machine' },
+  { path: h('.openwiki'), what: 'OpenWiki credentials, daemon config and the watch list' },
+  { path: h('.synapse'), what: 'Synapse logs and reports' },
+  { path: h('.memb'), what: 'memB WebUI logs' },
+  { path: h('.ao'), what: 'AO Orchestrator logs' },
+];
+
+const AGENTS = [
+  'com.bdb.memb.webui', 'com.bdb.synapse', 'com.bdb.openwiki.daemon',
+  'com.bdb.ao.daemon', 'com.bdb.agent-workspace', 'com.hybridlabor.bdb-remote',
+];
+
+const MODULE_DIRS = ['memB', 'bdb-synapse', 'bdb-os-remote', 'bdb-dev-creator-extension',
+  'bdb-dev-tool-installer',
+  'bdb-agent-orchestrator',      // AO
+  'bdb-os-agent-workspace',      // AO's archived predecessor, if still lying around
+].map((m) => h('.agents', m));
+
+const sha256 = (file) => {
+  try { return createHash('sha256').update(readFileSync(file)).digest('hex'); }
+  catch { return null; }
+};
+
+// --------------------------------------------------------------------- plan
+function plan() {
+  const manifest = (() => {
+    try { return JSON.parse(readFileSync(MANIFEST, 'utf8')); } catch { return null; }
+  })();
+
+  const ours = [];      // matches its recorded hash — delete
+  const edited = [];    // differs — back up, then delete
+  const gone = [];      // already absent
+
+  for (const [p, entry] of Object.entries(manifest || {})) {
+    if (!existsSync(p)) { gone.push(p); continue; }
+    (sha256(p) === entry.sha256 ? ours : edited).push(p);
+  }
+
+  const agents = AGENTS
+    .map((label) => ({ label, plist: h('Library', 'LaunchAgents', `${label}.plist`) }))
+    .filter((a) => existsSync(a.plist));
+
+  const modules = MODULE_DIRS.filter(existsSync);
+  const data = PURGE ? DATA_PATHS.filter((d) => existsSync(d.path)) : [];
+
+  return { manifest, ours, edited, gone, agents, modules, data };
+}
+
+function describe(p) {
+  const { manifest, ours, edited, gone, agents, modules, data } = p;
+
+  if (!manifest) {
+    console.log('Kein Installations-Manifest unter ' + tilde(MANIFEST) + '.');
+    console.log('Ohne das lässt sich nicht sagen, welche Datei von AOS stammt — es wird nichts gelöscht.');
+    console.log('Betroffen wären sonst: ~/.claude/skills, ~/.gemini/config/skills, ~/.codex/skills, ~/.agents/');
+    return false;
+  }
+
+  console.log(`\nManifest: ${Object.keys(manifest).length} Dateien erfasst`);
+  console.log(`  ${String(ours.length).padStart(5)}  unverändert seit der Installation → werden entfernt`);
+  console.log(`  ${String(edited.length).padStart(5)}  nach der Installation bearbeitet → erst .bak, dann entfernt`);
+  console.log(`  ${String(gone.length).padStart(5)}  bereits nicht mehr vorhanden`);
+
+  if (edited.length) {
+    console.log('\n  bearbeitet:');
+    for (const f of edited.slice(0, 8)) console.log(`    ${tilde(f)}`);
+    if (edited.length > 8) console.log(`    … und ${edited.length - 8} weitere`);
+  }
+
+  if (agents.length) {
+    console.log(`\nHintergrunddienste (${agents.length}): ${agents.map((a) => a.label).join(', ')}`);
+  }
+  if (modules.length) {
+    console.log('\nModule:');
+    for (const m of modules) console.log(`    ${tilde(m)}`);
+  }
+
+  console.log('\nBleibt erhalten:');
+  if (!PURGE) for (const d of DATA_PATHS.filter((d) => existsSync(d.path))) console.log(`    ${tilde(d.path).padEnd(18)} ${d.what}`);
+  console.log('    jede Datei ohne Manifest-Eintrag — eigene Skills, fremde Hooks, alles Selbstgeschriebene');
+
+  if (data.length) {
+    console.log('\n\x1b[31mWIRD GELÖSCHT (--purge):\x1b[0m');
+    for (const d of data) {
+      let size = '';
+      try { size = ` (${(dirSize(d.path) / 1e6).toFixed(1)} MB)`; } catch { /* unreadable */ }
+      console.log(`    \x1b[31m${tilde(d.path).padEnd(18)}\x1b[0m ${d.what}${size}`);
+    }
+  }
+  return true;
+}
+
+function dirSize(p) {
+  let total = 0;
+  const walk = (d) => {
+    for (const e of readdirSync(d, { withFileTypes: true })) {
+      const f = path.join(d, e.name);
+      try { e.isDirectory() ? walk(f) : (total += statSync(f).size); } catch { /* raced */ }
+    }
+  };
+  try { statSync(p).isDirectory() ? walk(p) : (total = statSync(p).size); } catch { /* gone */ }
+  return total;
+}
+
+// ------------------------------------------------------------------ execute
+function execute(p) {
+  const { ours, edited, agents, modules, data } = p;
+  const stamp = new Date().toISOString().replace(/[:.]/g, '').slice(0, 15);
+  let removed = 0, backed = 0;
+
+  for (const a of agents) {
+    try { execFileSync('launchctl', ['unload', a.plist], { stdio: 'ignore' }); } catch { /* not loaded */ }
+    try { rmSync(a.plist); } catch { /* already gone */ }
+  }
+  if (agents.length) console.log(`  ${agents.length} Dienste gestoppt und entfernt`);
+
+  for (const f of edited) {
+    try { copyFileSync(f, `${f}.${stamp}.bak`); backed++; } catch { /* unreadable */ }
+  }
+  for (const f of [...ours, ...edited]) {
+    try { rmSync(f); removed++; } catch { /* already gone */ }
+  }
+  console.log(`  ${removed} Dateien entfernt, ${backed} vorher gesichert`);
+
+  for (const m of modules) { try { rmSync(m, { recursive: true, force: true }); } catch { /* in use */ } }
+  if (modules.length) console.log(`  ${modules.length} Module entfernt`);
+
+  // Only the BDB hook entries leave settings.json; everything else in it is
+  // the user's and must survive an uninstall exactly as it survives an install.
+  const settings = h('.claude', 'settings.json');
+  if (existsSync(settings)) {
+    try {
+      const s = JSON.parse(readFileSync(settings, 'utf8'));
+      const bdb = ['go-gate.mjs', 'graph-gate.mjs', 'memb-inject.mjs'];
+      let touched = false;
+      for (const [event, entries] of Object.entries(s.hooks || {})) {
+        const kept = entries.filter((e) => !(e.hooks || []).some((x) => bdb.some((n) => String(x.command).includes(n))));
+        if (kept.length !== entries.length) { touched = true; s.hooks[event] = kept; }
+        if (!kept.length) delete s.hooks[event];
+      }
+      if (touched) {
+        writeFileSync(settings, JSON.stringify(s, null, 2) + '\n');
+        console.log('  BDB-Hooks aus settings.json entfernt, alles andere unverändert');
+      }
+    } catch { console.log('  settings.json nicht lesbar — von Hand prüfen'); }
+  }
+
+  for (const d of data) {
+    try { rmSync(d.path, { recursive: true, force: true }); console.log(`  \x1b[31mgelöscht:\x1b[0m ${tilde(d.path)}`); }
+    catch (e) { console.log(`  konnte ${tilde(d.path)} nicht löschen: ${e.message}`); }
+  }
+
+  for (const f of [MANIFEST, h('.agents', '.bdb-manifest.json')]) {
+    try { rmSync(f); } catch { /* already gone */ }
+  }
+}
+
+// ---------------------------------------------------------------------- main
+const ask = async (q) => {
+  const rl = createInterface({ input: process.stdin, output: process.stdout });
+  const a = (await rl.question(q)).trim();
+  rl.close();
+  return a;
+};
+
+const p = plan();
+console.log(PURGE ? '\x1b[31mAOS UNINSTALL — PURGE\x1b[0m' : 'AOS Uninstall');
+if (!describe(p)) process.exit(1);
+
+if (DRY) {
+  console.log('\n[dry-run] Es wurde nichts verändert.');
+  process.exit(0);
+}
+
+if (!YES) {
+  if ((await ask('\nFortfahren? [ja/nein] ')).toLowerCase() !== 'ja') {
+    console.log('Abgebrochen. Nichts verändert.');
+    process.exit(0);
+  }
+  if (PURGE) {
+    console.log('\n\x1b[31mDer zweite Schritt löscht das Gedächtnis und die Zugangsdaten unwiderruflich.\x1b[0m');
+    if ((await ask('Zum Bestätigen PURGE eingeben: ')).trim() !== 'PURGE') {
+      console.log('Abgebrochen. Nichts verändert.');
+      process.exit(0);
+    }
+  }
+}
+
+console.log('');
+execute(p);
+console.log('\nFertig. Neu einrichten mit: npx -y @hybridlabor-api/aos@latest');

package/docs/sessions/audit-2026-09-14-silent-failures.md

@@ -0,0 +1,114 @@
+# Audit 2026-09-13/14 — the "reports success, does nothing" family
+
+Every defect below was found in one session, and they are all the same shape:
+**a component reports a state it is not in.** Not crashes, not exceptions — a
+clean run, a green check, and nothing actually delivered. That is why they
+survived so many releases: the installer's own output said it worked.
+
+Read this before adding a check anywhere in this repo. The question that
+catches this family is not "does the check pass" but **"does the check measure
+the thing, or something the tool itself produced?"**
+
+Numbers here are measurements taken on one machine on 2026-09-13/14; they are
+evidence for the defect, not invariants.
+
+---
+
+## Fixed and tested
+
+| # | Defect | Why it was invisible |
+|---|---|---|
+| 1 | `runQuickUpdate()` delivered no harness files — hooks, dispatcher workflows, compiled subagents, `GEMINI.md` | Quick Update is what an existing install is offered. Everything `injectHarnessRules()` does was fresh-install-only, so machines kept first-install agent definitions forever. Fixed once for hooks in 4.4.1; the rest recurred one layer up |
+| 2 | `memb-inject.mjs` imported `node:sqlite` at top level, outside its own `try` | The file documents itself as fail-open. A top-level import that throws escapes the `try`, so a Node without unflagged `node:sqlite` got a hook error on every prompt |
+| 3 | The same hook read `project_id` from `$.metadata.project_id` | memB stores it at the payload top level. The lookup matched nothing, ever — the injected block rendered as `- None` and nobody read it as a bug |
+| 4 | `resolveFileConflict()` skipped files whose content it did not recognise | Only ever called for paths the payload owns, so "unknown content" almost always meant *our own older file*. Bootstrap adoption catches only byte-identical files, so anything changed in between froze permanently. 50 files on one machine, the oldest untouched since July |
+| 5 | `detectPlatforms()` tested for config directories | `syncSkillsToGlobalHarnesses()` and `universalHarnessSync()` create those directories. The detector read back evidence the installer had planted: 7 harnesses reported, 5 installed |
+| 6 | `tar -xzf` unpacked module updates over the installed tree | A merge, not a replacement. Files the new version dropped stayed forever while `package.json` reported the module current |
+| 7 | Seven call sites ignored `downloadOrUpdateModule()`'s `false` | A failed download fell through into venv setup and daemon registration, and the run still ended in a success banner |
+| 8 | A failed `npm view` was swallowed | Every module read "up to date" indefinitely on an offline or proxied machine, indistinguishable from a real answer |
+| 9 | The Agent Workspace printed its WebUI URL unconditionally | Directly under a warning that the port had not answered, and on Linux where no daemon is registered at all |
+| 10 | `--dry-run` created a venv | The global `fs.*` dry-run patch does not cover child processes; `uv venv` ran for real |
+| 11 | A second run overwrote the first `.bak` | Backups were not timestamped, so the recovery copy was destroyed by the act of recovering |
+| 12 | AO's LaunchAgent ran the binary with no subcommand | Bare `ao` prints help and exits; with `KeepAlive` launchd restarted it until throttled. On every machine that installed AO through AOS the daemon never ran — it only looked installed |
+| 13 | AO pointed at `@hybridlabor-api/bdb-os-agent-workspace` | That repository is archived and its last npm release predates the archiving, so installing it hands out the build with the CDC loop defect |
+| 14 | There was no uninstall | "Remove and reinstall cleanly" was not possible, which also makes a genuine fresh-install test impossible |
+| 15 | The OpenWiki daemon discovered nothing | `get_projects()` seeded a list with one entry and read it back unchanged forever. 31 wikis existed, 3 were refreshed, the oldest untouched since 23 July |
+| 16 | No repository had a `.openwikiignore` | OpenWiki's `load()` falls back to `parse("")` — with no file it loads **zero** rules and indexes `.venv`, build output and its own `.openwiki/` recursively. Measured on one repo: 33 of 145 graph nodes were junk, 0 false positives after applying the template |
+
+`tests/installer-e2e.sh` covers 18 of these against a throwaway `$HOME`. It is
+deliberately outside `npm test` — real network, minutes to run — and belongs
+before a release. The unit tests cover the logic; this covers whether the
+installer does anything at all.
+
+---
+
+## Found, not yet fixed
+
+**Operational data one publish away from the public package — corrected.**
+`mcps/bdb-remoteos-mcp/queue.db` holds 134 real approval rows and `npm pack`
+included it. The first reading of this was that it had already shipped. That
+was wrong, and the correction matters more than the original claim: the
+published tarballs for 4.2.0, 4.3.0, 4.4.0 and 4.4.1 were each downloaded and
+searched, and every one contains zero matches for `queue.db` and `.pyc`. The
+file has never been in git; it is created at runtime by the MCP, so a release
+built from a clean checkout cannot contain it. A release published from a
+development machine would have — which is exactly what 4.4.2 was going to be.
+
+So this was a near miss, not a leak, and the lesson is about the check rather
+than the defect: `npm pack --dry-run` on a working tree answers "what would
+ship from *here*", which is not the same question as "what did ship". Only the
+published tarball answers the second one. Both fixes stay: the negation inside
+`files` (`.npmignore` has no effect on a path `files` includes wholesale), and
+`.gitignore`, so neither the store nor its `-shm`/`-wal` siblings can enter
+either channel from any machine.
+
+**~46 MB that has never worked.** `tdmcp`, `touchdesigner-mcp` and `unreal_mcp`
+declare `main` as `dist/index.js`; `dist/` is in no tarball. It exists only if
+`npm run build` succeeds at install time, and that result is discarded — so the
+MCP config is written pointing at files that were never produced.
+
+**A smoke test that is theatre.** Four of the six Python MCP prewarm entries
+call `uv -m mcp_server --help` without the required `run` subcommand. They fail
+before `uv` reaches the script, `stdio` is `ignore`, and the result is
+discarded.
+
+**Hardcoded versions.** `bdb-os-remote` serves `1.0.0` from
+`src/server/sse-server.js:94,189` while its manifest says 2.0.1; memB serves
+`1.0.0` from `src/backend/server.py:36` against a manifest of 2.3.2.
+
+**AO is macOS-arm64 only on npm.** The package ships one prebuilt binary. The
+upstream project publishes every platform through GitHub Releases
+(`darwin-arm64`, `darwin-x64`, `linux-x64` as AppImage/deb/rpm, `win32-x64.exe`)
+and the fork's own `build-artifacts.yml` already produces them — only the path
+into the package is missing. Separately, `bin/ao.js`'s `findBinary()` returns
+the first path that *exists* without checking it can execute, so on Windows the
+shim dies with an exec-format error instead of printing the hint it means to.
+
+**12 of 187 skills are filler.** Three identical "Red Flags" lines appear in
+eleven skills, one identical sentence in ten. `synapse-integration-skill` is
+23 % unique content and 72 % identical to `bdb-dev-os-skill`. `bdbsaas-ops` is
+16 lines, marked retired, and carries no commands.
+
+---
+
+## What a check has to do here
+
+1. **Measure the thing, not a proxy.** A port that answers is not the right
+   process; a directory that exists is not an installed application; a
+   `package.json` version is not what the running service reports.
+2. **Never read back your own writes as evidence.** If the installer creates
+   the path, the path proves nothing.
+3. **Distinguish "checked, fine" from "could not check."** An offline
+   registry must not read as up to date.
+4. **A discarded return value is a swallowed failure.** `installStep()` only
+   catches throws; a function that signals failure by returning `false` needs
+   its result read.
+5. **Every code path, not just the fresh one.** Quick Update, `--project-harness`,
+   `-y`, `--dry-run` and the interactive path each need the step, or the step
+   does not exist for the people on that path.
+6. **Ask about the artefact people actually have.** A dry run on a working tree
+   describes a hypothetical release from that machine. What users installed is
+   the published tarball, and only downloading it answers that. This rule was
+   added after the `queue.db` finding above was reported as a live leak on the
+   strength of a local `npm pack --dry-run`, and turned out on inspection of
+   all four published versions never to have shipped.

package/docs/skills_table.md

@@ -199,9 +199,6 @@
 |------------|-------------|
 | `bdbmediastorm` | The ultimate creative-tech and show-control brainstorming engine. Orchestrates multi-agent ideation focused on signal flow, hardware constraints, protocols, and BDB MCP integrations. Now strictly governed by the 3 Core Godmodes (engineering, ui-ux, shipping). |
 | `bdbrainstorm` | Combines multi-agent brainstorming, the /grill-me slash command, and the 3 Core Godmodes (godmode-engineering, godmode-ui-ux, godmode-shipping) to force a comprehensive, multi-agent ideation and technical design workflow. |
-| `bdbsaas-ops` | Retired — superseded by bdbsaashost. Use /bdbsaashost instead; this skill's content was merged there (2026-09-05, plan production_artifacts/00_execution_plan.md item B2). |
-| `bdbsaashost` | Use when operating the BDB Multi-Cloud Fleet. Governs Primary Compute, GCP Identity, Oracle, FastMCP SSE Gateway, 4-Eyes Approvals, agent-sudo guardrails, Incus containers, and LLDAP/Authelia identity management. |
-| `bdbsaastraining` | Use when onboarding or training staff on the BDB SaaS Host Engine. Guides trainees via interactive workloads (WordPress, mail, agents) through SSH 2FA, Incus, and FastMCP guardrails, culminating in a PDF certificate. |
 | `github-repo` | Standards and workflows for writing, formatting, sanitizing, and publishing high-quality GitHub repositories, complementing openwiki-skill. |
 | `memb-ingest` | Deep scan and ingest project files (.md, .json, agent.md, .openwiki) and past conversation logs into the local memB vector memory engine. |