@griddo/ax 12.6.1 → 12.6.2

package/src/modules/Settings/SeoAnalyticsSettings/Analytics/index.tsx

@@ -1,76 +1,61 @@
-import { memo, useEffect, useState } from "react";
+import { useEffect, useState } from "react";
+import { connect } from "react-redux";
 
 import { Loading, MainWrapper, Nav } from "@ax/components";
 import { analyticsActions } from "@ax/containers/Analytics";
 import { appActions } from "@ax/containers/App";
 import { RouteLeavingGuard } from "@ax/guards";
 import { useModal } from "@ax/hooks";
-import { useAppDispatch, useAppSelector } from "@ax/store";
-import type { INavItem } from "@ax/types";
+import type { IAnalytics, INavItem, IRootState, ISite } from "@ax/types";
 
 import { Dimensions, Groups, ResetModal, ScriptCode, Warning } from "./atoms";
 
 import * as S from "./style";
 
 const Analytics = (props: IProps): JSX.Element => {
-	const { navItems, currentNavItem } = props;
-
-	const dispatch = useAppDispatch();
-	const isSaving = useAppSelector((state) => state.app.isSaving);
-	const isLoading = useAppSelector((state) => state.app.isLoading);
-	const analytics = useAppSelector((state) => state.analytics);
-	const site = useAppSelector((state) => state.sites.currentSiteInfo);
+	const {
+		navItems,
+		currentNavItem,
+		isSaving,
+		isLoading,
+		analytics,
+		getAnalytics,
+		setHistoryPush,
+		site,
+		updateScriptCode,
+		deleteScriptCode,
+	} = props;
 
 	const [showWarning, setShowWarning] = useState(false);
 	const [scriptCode, setScriptCode] = useState(analytics.scriptCode);
 	const [isDirty, setIsDirty] = useState(false);
-	const [hasLoaded, setHasLoaded] = useState(false);
 	const { isOpen, toggleModal } = useModal();
 
-	// biome-ignore lint/correctness/useExhaustiveDependencies: only on mount, as before
+	// biome-ignore lint/correctness/useExhaustiveDependencies: TODO: fix this
 	useEffect(() => {
-		const load = async () => {
-			try {
-				setHasLoaded(await dispatch(analyticsActions.getAnalytics(site?.id ?? null)).unwrap());
-			} catch {
-				setHasLoaded(false);
-			}
-		};
-		load();
+		const handleGetAnalytics = async () => await getAnalytics(site?.id);
+		handleGetAnalytics();
 	}, []);
 
-	// The Warning ("this site has no script code of its own, edit the global one") is a
-	// claim about the server, and `siteScriptCodeExists` is `false` both when the site has
-	// no override and when nothing has been fetched yet. Making the claim before the GET
-	// answers told a site that HAS its own script that it had none — and `getAnalytics`
-	// sets no loading flag, so nothing covered the gap. Hence the guard: until the GET
-	// succeeds the editor is the neutral state, and on failure the error modal is already up.
-	useEffect(() => {
-		if (!hasLoaded) return;
-		setShowWarning(!analytics.siteScriptCodeExists);
-	}, [hasLoaded, analytics.siteScriptCodeExists]);
-
 	useEffect(() => {
 		setScriptCode(analytics.scriptCode);
+		setShowWarning(!analytics.siteScriptCodeExists);
 		setIsDirty(false);
-	}, [analytics.scriptCode]);
+	}, [analytics.scriptCode, analytics.siteScriptCodeExists]);
 
 	useEffect(() => {
 		setIsDirty(scriptCode !== analytics.scriptCode);
 	}, [scriptCode, analytics.scriptCode]);
 
 	const handleSave = async () => {
-		// `.unwrap()` is what hands over handleRequest's boolean: the dispatch itself
-		// resolves to the fulfilled action, which would be truthy even on failure.
-		const isSaved =
-			!!site && (await dispatch(analyticsActions.updateScriptCode({ scriptCode, siteId: site.id })).unwrap());
+		const isSaved = !!site && (await updateScriptCode(scriptCode, site.id));
 		if (isSaved) setIsDirty(false);
 	};
 
-	const setRoute = (path: string) => dispatch(appActions.setHistoryPush(path));
+	const setRoute = (path: string) => setHistoryPush(path);
 
 	const handleReset = async () => {
-		await dispatch(analyticsActions.deleteScriptCode(site?.id ?? null));
+		await deleteScriptCode(site?.id);
 		isOpen && toggleModal();
 		setShowWarning(true);
 		setScriptCode(analytics.scriptCode);
@@ -121,7 +106,6 @@ const Analytics = (props: IProps): JSX.Element => {
 			<MainWrapper
 				backLink={false}
 				title="Analytics Settings"
-				screen="analytics-site"
 				rightButton={rightButtonProps}
 				rightLineButton={secondaryButtonProps}
 			>
@@ -135,10 +119,36 @@ const Analytics = (props: IProps): JSX.Element => {
 	);
 };
 
-interface IProps {
+const mapStateToProps = (state: IRootState) => ({
+	isSaving: state.app.isSaving,
+	isLoading: state.app.isLoading,
+	analytics: state.analytics,
+	site: state.sites.currentSiteInfo,
+});
+
+const mapDispatchToProps = {
+	setHistoryPush: appActions.setHistoryPush,
+	getAnalytics: analyticsActions.getAnalytics,
+	updateScriptCode: analyticsActions.updateScriptCode,
+	deleteScriptCode: analyticsActions.deleteScriptCode,
+};
+
+interface IAnalyticsProps {
 	navItems: INavItem[];
 	currentNavItem: INavItem;
+	isSaving: boolean;
+	isLoading: boolean;
+	analytics: IAnalytics;
+	site: ISite | null;
 }
 
-// `connect` memoised this screen implicitly; `memo` keeps that now it is gone.
-export default memo(Analytics);
+interface IDispatchProps {
+	getAnalytics(siteId?: number | null): Promise<void>;
+	setHistoryPush(path: string, isEditor?: boolean): void;
+	updateScriptCode(scriptCode: string, siteId?: number | null): Promise<boolean>;
+	deleteScriptCode(siteId?: number | null): Promise<boolean>;
+}
+
+type IProps = IAnalyticsProps & IDispatchProps;
+
+export default connect(mapStateToProps, mapDispatchToProps)(Analytics);

package/src/modules/Settings/Social/index.tsx

@@ -27,6 +27,7 @@
 //
 
 import { useEffect, useState } from "react";
+import { useDispatch, useSelector } from "react-redux";
 
 import { ErrorToast, FieldsBehavior, MainWrapper, Nav } from "@ax/components";
 import { appActions } from "@ax/containers/App";
@@ -34,10 +35,11 @@ import { socialActions } from "@ax/containers/Settings/Social";
 import { RouteLeavingGuard } from "@ax/guards";
 import { capitalize } from "@ax/helpers";
 import { useIsDirty } from "@ax/hooks";
-import { useAppDispatch, useAppSelector } from "@ax/store";
-import type { INavItem } from "@ax/types";
+import type { INavItem, IRootState } from "@ax/types";
 
 import { config } from "components";
+import type { AnyAction } from "redux";
+import type { ThunkDispatch } from "redux-thunk";
 
 import * as S from "./style";
 
@@ -62,12 +64,12 @@ const hardcodedSocials = [
 
 const Social = (props: IProps): JSX.Element => {
 	const { navItems, currentNavItem } = props;
-	const dispatch = useAppDispatch();
-	const isSaving = useAppSelector((state) => state.app.isSaving);
-	const socialInfo = useAppSelector((state) => state.social);
+	const dispatch = useDispatch<ThunkDispatch<IRootState, undefined, AnyAction>>();
+	const isSaving = useSelector((state: IRootState) => state.app.isSaving);
+	const socialInfo = useSelector((state: IRootState) => state.social);
 	const [socialForm, setSocialForm] = useState<Record<string, string>>({});
 	const [serverFields, setServerFields] = useState<Set<string>>(new Set());
-	const { isDirty, resetDirty } = useIsDirty(socialForm);
+	const { isDirty, resetDirty, setIsDirty } = useIsDirty(socialForm);
 
 	const socialFields = [
 		...instanceSocials.map((name) => ({ name, title: `${capitalize(name)} URL` })),
@@ -86,21 +88,14 @@ const Social = (props: IProps): JSX.Element => {
 		resetDirty();
 	}, [dispatch]);
 
-	// `resetDirty()`, not `setIsDirty(false)`: it also moves useIsDirty's baseline to the
-	// form being hydrated here. Leaving the redux-persist (ADR 0002) means `social` is
-	// empty on the first render and arrives with the GET, and useIsDirty snapshots the
-	// baseline during render — so the empty→loaded hop read as an edit and the screen
-	// landed dirty, arming the leave guard before the user touched anything.
 	useEffect(() => {
 		setSocialForm({ ...socialInfo });
 		setServerFields(new Set(Object.keys(socialInfo).filter((k) => !!socialInfo[k])));
-		resetDirty();
-	}, [socialInfo, resetDirty]);
+		setIsDirty(false);
+	}, [socialInfo, setIsDirty]);
 
 	const saveForm = async () => {
-		// `.unwrap()` is what hands over handleRequest's boolean: the dispatch itself
-		// resolves to the fulfilled action, which would be truthy even on failure.
-		const isSaved = await dispatch(socialActions.saveSocial(socialForm)).unwrap();
+		const isSaved = await dispatch(socialActions.saveSocial(socialForm));
 		if (isSaved) resetDirty();
 	};
 
@@ -127,7 +122,7 @@ const Social = (props: IProps): JSX.Element => {
 	return (
 		<>
 			<RouteLeavingGuard when={isDirty} action={setRoute} text={modalText} />
-			<MainWrapper backLink={false} title="Social" rightButton={rightButtonProps} screen="social">
+			<MainWrapper backLink={false} title="Social" rightButton={rightButtonProps}>
 				<S.Wrapper>
 					<Nav current={currentNavItem} items={navItems} onClick={handleMenuClick} />
 					<S.ContentWrapper>

package/src/modules/StructuredData/StructuredDataList/index.tsx

@@ -315,8 +315,7 @@ const StructuredDataList = (props: IProps): JSX.Element => {
 	// biome-ignore lint/correctness/useExhaustiveDependencies: TODO: fix this
 	useEffect(() => {
 		checkUserSession();
-		// `null` is the global scope: the RTK thunk takes exactly one argument.
-		getAnalytics(null);
+		getAnalytics();
 	}, []);
 
 	// biome-ignore lint/correctness/useExhaustiveDependencies: TODO: fix this
@@ -812,7 +811,7 @@ interface IDispatchProps {
 	deleteBulk(ids: number[]): Promise<boolean>;
 	restorePage(id: number | number[]): Promise<boolean>;
 	resetPageEditor(): Promise<void>;
-	getAnalytics(siteId: number | null): unknown;
+	getAnalytics(siteId?: number | null): Promise<void>;
 	setCurrentDataID(id: number | null): void;
 	resetCurrentSiteErrorPages: () => Promise<void>;
 	setContentFilters(contentFilters: Record<string, Record<string, IQueryValue[]>> | null): void;

package/src/types/index.tsx

@@ -1,7 +1,7 @@
-import type { IActivityLogState } from "@ax/containers/ActivityLog/slice";
-import type { IAnalyticsState } from "@ax/containers/Analytics/slice";
+import type { IActivityLogState } from "@ax/containers/ActivityLog/reducer";
+import type { IAnalyticsState } from "@ax/containers/Analytics/reducer";
 import type { IAppState } from "@ax/containers/App/reducer";
-import type { IDomainsState } from "@ax/containers/Domains/slice";
+import type { IDomainsState } from "@ax/containers/Domains/reducer";
 import type { IFileDriveState } from "@ax/containers/FileDrive/reducer";
 import type { IFormsState } from "@ax/containers/Forms/reducer";
 import type { IGalleryState } from "@ax/containers/Gallery/reducer";
@@ -9,9 +9,9 @@ import type { IIntegrationsState } from "@ax/containers/Integrations/reducer";
 import type { INavigationState } from "@ax/containers/Navigation/Defaults/reducer";
 import type { IMenuState } from "@ax/containers/Navigation/Menu/reducer";
 import type { IPageEditorState } from "@ax/containers/PageEditor/reducer";
-import type { IRedirectsState } from "@ax/containers/Redirects/slice";
+import type { IRedirectsState } from "@ax/containers/Redirects/reducer";
 import type { IDataPacksState } from "@ax/containers/Settings/DataPacks/reducer";
-import type { ILanguageState } from "@ax/containers/Settings/Languages/slice";
+import type { ILanguageState } from "@ax/containers/Settings/Languages/reducer";
 import type { ISitesState } from "@ax/containers/Sites/reducer";
 import type { IStructuredDataState } from "@ax/containers/StructuredData/reducer";
 import type { IUsersState } from "@ax/containers/Users/reducer";
@@ -261,6 +261,7 @@ export interface IHeadingField {
 }
 
 export interface IRootState {
+	router: any;
 	app: IAppState;
 	sites: ISitesState;
 	pageEditor: IPageEditorState;

package/tsconfig.paths.json

@@ -17,7 +17,6 @@
 			"@ax/routes/*": ["./src/routes/*"],
 			"@ax/types": ["./src/types"],
 			"@ax/schemas": ["./src/schemas"],
-			"@ax/store": ["./src/store"],
 			"@ax/themes/*": ["./src/themes/*"],
 			"@ax/constants": ["./src/constants"],
 			"@ax/constants/*": ["./src/constants/*"]

package/src/__tests__/modules/ActivityLog/ActivityLog.uc.test.tsx

@@ -1,132 +0,0 @@
-import { activityLogReducer } from "@ax/containers/ActivityLog";
-import { appReducer, type IAppState } from "@ax/containers/App/reducer";
-import {
-	type IStructuredDataState,
-	structuredDataReducer,
-} from "@ax/containers/StructuredData/reducer";
-import { parseTheme } from "@ax/helpers";
-import ActivityLog from "@ax/modules/ActivityLog";
-import history from "@ax/routes/history";
-import globalTheme from "@ax/themes/theme.json";
-
-import { configureStore, type Reducer, type UnknownAction } from "@reduxjs/toolkit";
-import axios from "axios";
-import { Router } from "react-router-dom";
-import { ThemeProvider } from "styled-components";
-import type { MockedFunction } from "vitest";
-
-import { act, cleanup, render, screen } from "../../../../config/tests/test-utils";
-
-/**
- * End-to-end test of the activity log on the real store — view, thunks, api layer and slice,
- * with only axios mocked (see the `## Profile` section of docs/gainup/README.md for why a
- * `redux-mock-store` test does not count as AC coverage).
- *
- * It covers the two things the store tests cannot see: that landing on the screen really does
- * ask the grouped-by-day endpoint for a hundred rows and paint them (AC1), and the empty state
- * (AC5), which is view logic living nowhere else.
- *
- * AC2 — switching to "Grouped by user" — is verified in `src/__tests__/store/activityLog.test.ts`
- * instead: the mode selector is a react-select, and driving its menu open in jsdom would test
- * the dropdown rather than the use case. The endpoint switch and the persisted `listMode` are
- * the parts that matter and they are pinned there.
- */
-vi.mock("axios");
-const mockedAxios = axios as MockedFunction<typeof axios>;
-
-const LOG_PAGE = {
-	totalItems: 1,
-	items: [
-		{
-			date: "10 Aug 2026",
-			items: [
-				{
-					id: 1,
-					user: { id: 3, name: "Ada Lovelace", image: null, email: "ada@example.edu", role: "admin" },
-					created: { hour: "09:41", date: "10 Aug 2026" },
-					site: null,
-					content: null,
-					contentType: null,
-					eventType: { id: 1, name: "Created page", internal_key: "CREATED_PAGE" },
-					ip: "10.0.0.1",
-				},
-			],
-		},
-	],
-};
-
-const makeStore = () =>
-	configureStore({
-		// Only what this screen reads. `app` and `structuredData` are still legacy, so they need
-		// the cast GlobalStore uses (docs/RTK-MIGRATION.md §8.3).
-		reducer: {
-			activityLog: activityLogReducer,
-			app: appReducer as Reducer<IAppState, UnknownAction>,
-			structuredData: structuredDataReducer as Reducer<IStructuredDataState, UnknownAction>,
-		},
-		middleware: (getDefault) => getDefault({ serializableCheck: false, immutableCheck: false }),
-	});
-
-const answer = (data: unknown) => ({ status: 200, data, statusText: "OK", headers: {}, config: {} });
-
-const logCalls = () =>
-	mockedAxios.mock.calls
-		.map(([config]) => config as { url?: string; method?: string })
-		.filter((config) => (config?.url ?? "").includes("/logs/activity-grouped-day"));
-
-const renderScreen = async (store: ReturnType<typeof makeStore>) => {
-	await act(async () => {
-		render(
-			<Router history={history}>
-				<ThemeProvider theme={parseTheme(globalTheme)}>
-					<ActivityLog />
-				</ThemeProvider>
-			</Router>,
-			{ store },
-		);
-	});
-};
-
-// The screen's filters and the structured-data refresh fetch their own lists on mount, so only
-// the log endpoint answers with a log page.
-const respondWith = (page: unknown) => {
-	mockedAxios.mockImplementation((async (config: { url?: string }) => {
-		const url = config?.url ?? "";
-		if (url.includes("/logs/activity-grouped-day")) return answer(page);
-		// The filter option lists want a bare array, not a paginated envelope.
-		return answer([]);
-	}) as never);
-};
-
-afterEach(() => {
-	vi.restoreAllMocks();
-	cleanup();
-});
-
-describe("[UC-AX-view-activity-log] the activity log screen end to end", () => {
-	it("AC1 · landing on the screen asks the grouped-by-day endpoint for a hundred rows and paints them", async () => {
-		respondWith(LOG_PAGE);
-		const store = makeStore();
-
-		await renderScreen(store);
-
-		const [request] = logCalls();
-		expect(request.url).toContain("page=1");
-		expect(request.url).toContain("itemsPerPage=100");
-		// Default ordering is DESC, which the endpoint expresses by the absence of `order`.
-		expect(request.url).not.toContain("order=");
-		expect(store.getState().activityLog.activityLog.totalItems).toBe(1);
-		expect(screen.getByText("Ada Lovelace")).toBeTruthy();
-		expect(screen.getByText("09:41")).toBeTruthy();
-	});
-
-	it("AC5 · an empty log shows the default empty state instead of a table", async () => {
-		respondWith({ totalItems: 0, items: [] });
-
-		await renderScreen(makeStore());
-
-		expect(logCalls()).toHaveLength(1);
-		expect(screen.getByText(/You will start to see the User Activity Log/)).toBeTruthy();
-		expect(screen.queryByText("Ada Lovelace")).toBeNull();
-	});
-});

package/src/__tests__/modules/Analytics/Analytics.uc.test.tsx

@@ -1,168 +0,0 @@
-import { Router } from "react-router-dom";
-
-// From the slice, not the `@ax/containers/Analytics` barrel: `Sites/actions` destructures
-// `analyticsActions` at module scope, so pulling the barrel in first from a test that also
-// mounts a screen loses the race with that cycle and the destructure sees `undefined`.
-import { analyticsReducer } from "@ax/containers/Analytics/slice";
-import { appInitialState, appReducer, type IAppState } from "@ax/containers/App/reducer";
-import { type ISitesState, sitesInitialState, sitesReducer } from "@ax/containers/Sites/reducer";
-import { parseTheme } from "@ax/helpers";
-import GlobalAnalytics from "@ax/modules/Analytics";
-import SiteAnalytics from "@ax/modules/Settings/SeoAnalyticsSettings/Analytics";
-import history from "@ax/routes/history";
-import globalTheme from "@ax/themes/theme.json";
-import type { IAnalytics, INavItem, ISite } from "@ax/types";
-
-import { configureStore, type Reducer, type UnknownAction } from "@reduxjs/toolkit";
-import axios from "axios";
-import { ThemeProvider } from "styled-components";
-import type { MockedFunction } from "vitest";
-
-import { act, cleanup, render, screen } from "../../../../config/tests/test-utils";
-
-/**
- * End-to-end tests of the two screens of the `analytics` area on the real store — view,
- * thunks, api layer and slice, with only axios mocked (see the `## Profile` section of
- * docs/gainup/README.md for why a `redux-mock-store` test does not count as AC coverage).
- *
- * They cover the half of AC5 and AC6 that lives only in the view, and both were written
- * against bugs the review of this migration found: the global screen landed dirty, so Save
- * was enabled and the leave guard armed on a screen the user had only looked at; and the
- * site screen claimed "this site has no script code of its own" for as long as the GET was
- * in flight, which is a statement about the server made before asking it.
- *
- * The in-flight window is the whole point of the second one, so its mock hands back a
- * promise this file resolves by hand: awaiting the render would skip the state under test.
- */
-vi.mock("axios");
-const mockedAxios = axios as MockedFunction<typeof axios>;
-
-const SITE_ID = 7;
-const ANALYTICS: IAnalytics = {
-	scriptCode: "<script>site-ga</script>",
-	siteScriptCodeExists: true,
-	dimensions: [],
-	groups: [],
-};
-
-const mockComponent = () => null;
-const NAV_ITEMS: INavItem[] = [{ title: "Analytics", path: "/sites/settings/analytics", component: mockComponent }];
-
-const okResponse = (data: unknown) => ({ status: 200, data, statusText: "OK", headers: {}, config: {} });
-
-const makeStore = () =>
-	configureStore({
-		// Only what these screens read. `app` and `sites` are still legacy, so they need the
-		// cast GlobalStore uses (docs/RTK-MIGRATION.md §8.3).
-		reducer: {
-			app: appReducer as Reducer<IAppState, UnknownAction>,
-			analytics: analyticsReducer,
-			sites: sitesReducer as Reducer<ISitesState, UnknownAction>,
-		},
-		middleware: (getDefault) => getDefault({ serializableCheck: false, immutableCheck: false }),
-		preloadedState: {
-			// `appInitialState.isLoading` is `true` and `getAnalytics` passes no loading flag,
-			// so a bare store would spin forever. `false` is the state any screen is actually
-			// reached in: the login and the boot fetches have already released the counter.
-			app: { ...appInitialState, isLoading: false },
-			sites: { ...sitesInitialState, currentSiteInfo: { id: SITE_ID } as ISite },
-		},
-	});
-
-const metricsCalls = (method: string) =>
-	mockedAxios.mock.calls
-		.map(([config]) => config as { url?: string; method?: string })
-		.filter((config) => config?.method === method && !!config?.url?.includes("/metrics"));
-
-const renderScreen = async (store: ReturnType<typeof makeStore>, ui: JSX.Element) => {
-	await act(async () => {
-		render(
-			<Router history={history}>
-				<ThemeProvider theme={parseTheme(globalTheme)}>{ui}</ThemeProvider>
-			</Router>,
-			{ store },
-		);
-	});
-};
-
-const siteScreen = <SiteAnalytics navItems={NAV_ITEMS} currentNavItem={NAV_ITEMS[0]} />;
-
-const button = (name: string) => screen.getByRole("button", { name });
-// The Warning panel's own button — it is what tells the site it has no override.
-const warning = () => screen.queryByRole("button", { name: "Define Site Analytics" });
-
-beforeEach(() => {
-	mockedAxios.mockImplementation((async () => okResponse(ANALYTICS)) as never);
-});
-
-afterEach(() => {
-	vi.restoreAllMocks();
-	cleanup();
-});
-
-describe("[UC-AX-configure-seo-analytics] the global Analytics screen end to end", () => {
-	it("AC6 · lands clean on the data it just fetched, so Save stays disabled", async () => {
-		const store = makeStore();
-
-		await renderScreen(store, <GlobalAnalytics />);
-
-		expect(metricsCalls("GET")).toHaveLength(1);
-		expect(store.getState().analytics.scriptCode).toBe(ANALYTICS.scriptCode);
-		// The empty→loaded hop is not an edit. useIsDirty snapshots its baseline during
-		// render, so without the resetDirty() in the hydration effect this reads "Save"
-		// enabled — and the leave guard fires on the way out of a screen nobody touched.
-		expect(button("Saved").hasAttribute("disabled")).toBe(true);
-	});
-});
-
-describe("[UC-AX-configure-seo-analytics] the site Analytics screen end to end", () => {
-	it("AC5 · does not claim the site has no script code of its own until the GET answers", async () => {
-		const store = makeStore();
-		let answerGet = () => {};
-		mockedAxios.mockImplementation(
-			(() =>
-				new Promise((resolve) => {
-					answerGet = () => resolve(okResponse(ANALYTICS));
-				})) as never,
-		);
-
-		await renderScreen(store, siteScreen);
-
-		// In flight: `siteScriptCodeExists` is still its initial `false`, which means "not
-		// asked yet", not "no override". Deciding here is what showed the Warning to a site
-		// that does have its own script.
-		expect(warning()).toBeNull();
-
-		await act(async () => {
-			answerGet();
-		});
-
-		expect(warning()).toBeNull();
-		expect(screen.getByDisplayValue(ANALYTICS.scriptCode)).toBeTruthy();
-	});
-
-	it("AC5 · shows the Warning once the server answers that the site has no script code", async () => {
-		const store = makeStore();
-		mockedAxios.mockImplementation((async () =>
-			okResponse({ ...ANALYTICS, siteScriptCodeExists: false, scriptCode: "" })) as never);
-
-		await renderScreen(store, siteScreen);
-
-		expect(warning()).toBeTruthy();
-	});
-
-	it("AC5 · a failed GET leaves the editor, not a claim about the site's script code", async () => {
-		const store = makeStore();
-		mockedAxios.mockImplementation((async () => ({
-			status: 500,
-			data: { message: "Server error" },
-			statusText: "Server Error",
-			headers: {},
-			config: {},
-		})) as never);
-
-		await renderScreen(store, siteScreen);
-
-		expect(warning()).toBeNull();
-	});
-});