@griddo/ax 12.6.1 → 12.6.2

package/src/__tests__/store/social.test.ts

@@ -1,165 +0,0 @@
-import { social } from "@ax/api";
-import { appActions } from "@ax/containers/App";
-import { socialActions, socialReducer } from "@ax/containers/Settings";
-import { type ISitesState, sitesInitialState, sitesReducer } from "@ax/containers/Sites/reducer";
-import type { ISite, ISocialState } from "@ax/types";
-
-import { configureStore, type Reducer, type UnknownAction } from "@reduxjs/toolkit";
-import type { MockInstance } from "vitest";
-
-/**
- * Characterisation tests for the `social` area — the per-site social profile URLs
- * behind `/sites/settings/social` (UC-AX-configure-social-networks).
- *
- * Written against the PUBLIC surface (the store and the exported action creators),
- * never against reducer internals or action type constants, so this file must keep
- * passing unchanged once the area becomes a slice. If it needs an edit, the shape
- * changed and that is a finding, not an adjustment.
- *
- * Two behaviours here are load-bearing and easy to lose in a rewrite:
- *
- *   - `setSocial` REPLACES the map, it does not merge — the opposite of its
- *     `analytics` sibling. The legacy reducer returned `{ ...payload }`, and the
- *     screen depends on it: "removing" a network means emptying its field and
- *     saving, so a key the server drops has to drop out of the store too.
- *   - the site is read from `sites.currentSiteInfo`, not passed in, which is why
- *     that reducer is mounted below. It is the seam this area has with `sites`.
- *
- * Going to the slice needed exactly two edits, and both are type-level or known:
- *
- *   - the two `expect(saved)` assertions gained `.unwrap()`. `dispatch(thunk())` used
- *     to resolve to `handleRequest`'s boolean; a createAsyncThunk resolves to the
- *     fulfilled action and hands the value over through `.unwrap()`. Same finding as
- *     Domains — docs/RTK-MIGRATION.md §5.
- *   - the casts that let a redux 4 reducer and action creator into an RTK store went
- *     away on their own (§8.3). `sites` still needs its own, being still legacy.
- *
- * Every request, resulting state and error-channel assertion below came over from the
- * legacy run untouched. No argument churn: both thunks already took exactly one
- * argument, so createAsyncThunk's single-argument rule cost nothing here.
- */
-
-const SITE_ID = 42;
-
-const SOCIALS: ISocialState = {
-	instagram: "https://instagram.com/griddo",
-	twitter: "https://x.com/griddo",
-};
-
-// Mirrors how GlobalStore mounts this area, minus persistence. `sites` is still
-// legacy, so it needs the cast GlobalStore uses — RTK types reducers against redux 5's
-// UnknownAction (docs/RTK-MIGRATION.md §8.3).
-const makeStore = () =>
-	configureStore({
-		reducer: {
-			social: socialReducer,
-			sites: sitesReducer as Reducer<ISitesState, UnknownAction>,
-		},
-		preloadedState: {
-			sites: { ...sitesInitialState, currentSiteInfo: { id: SITE_ID } as ISite },
-		},
-	});
-
-type Store = ReturnType<typeof makeStore>;
-const socialsOf = (store: Store) => store.getState().social;
-
-const ok = (data: ISocialState) => ({ status: 200, data });
-
-describe("[UC-AX-configure-social-networks] social state", () => {
-	let store: Store;
-	let handleError: MockInstance;
-
-	beforeEach(() => {
-		store = makeStore();
-		handleError = vi.spyOn(appActions, "handleError").mockReturnValue((() => undefined) as never);
-	});
-
-	afterEach(() => {
-		vi.restoreAllMocks();
-	});
-
-	it("AC2 · starts with no networks configured", () => {
-		expect(socialsOf(store)).toEqual({});
-	});
-
-	it("AC2 · setSocial replaces the whole map instead of merging onto it", () => {
-		store.dispatch(socialActions.setSocial(SOCIALS));
-
-		store.dispatch(socialActions.setSocial({ instagram: SOCIALS.instagram }));
-
-		// `twitter` is gone, not kept: the payload is the server's whole map.
-		expect(socialsOf(store)).toEqual({ instagram: SOCIALS.instagram });
-	});
-
-	it("AC2 · loading asks the current site for its networks and stores them", async () => {
-		const get = vi.spyOn(social, "getSocial").mockResolvedValue(ok(SOCIALS) as never);
-
-		await store.dispatch(socialActions.getSocial());
-
-		expect(get).toHaveBeenCalledWith(SITE_ID);
-		expect(socialsOf(store)).toEqual(SOCIALS);
-	});
-
-	it("AC2 · a failed load leaves the map untouched and logs instead of showing a toast", async () => {
-		store.dispatch(socialActions.setSocial(SOCIALS));
-		vi.spyOn(social, "getSocial").mockResolvedValue({ status: 500, data: {} } as never);
-		// Asserted rather than merely allowed: the read side's ONLY error channel is this
-		// console.log, so spying on it both pins the wart and keeps it out of the suite output.
-		const log = vi.spyOn(console, "log").mockImplementation(() => undefined);
-
-		await store.dispatch(socialActions.getSocial());
-
-		// The failure reaches the console and nothing else, so the screen keeps whatever it had.
-		// Documented as a wart in the UC: a failed load is invisible to the user.
-		expect(log).toHaveBeenCalledWith("Error en getSocial");
-		expect(handleError).not.toHaveBeenCalled();
-		expect(socialsOf(store)).toEqual(SOCIALS);
-	});
-});
-
-describe("[UC-AX-configure-social-networks] social writes", () => {
-	let store: Store;
-	let handleError: MockInstance;
-
-	beforeEach(() => {
-		store = makeStore();
-		handleError = vi.spyOn(appActions, "handleError").mockReturnValue((() => undefined) as never);
-	});
-
-	afterEach(() => {
-		vi.restoreAllMocks();
-	});
-
-	it("AC6 · saving puts the whole form to the current site and takes the response as the new state", async () => {
-		const update = vi.spyOn(social, "updateSocial").mockResolvedValue(ok(SOCIALS) as never);
-
-		const saved = await store.dispatch(socialActions.saveSocial(SOCIALS)).unwrap();
-
-		expect(update).toHaveBeenCalledWith(SITE_ID, SOCIALS);
-		expect(saved).toBe(true);
-		expect(socialsOf(store)).toEqual(SOCIALS);
-	});
-
-	it("AC6 · an emptied network goes out as an empty string — that is how one is removed", async () => {
-		const form = { ...SOCIALS, twitter: "" };
-		const update = vi.spyOn(social, "updateSocial").mockResolvedValue(ok(form) as never);
-
-		await store.dispatch(socialActions.saveSocial(form));
-
-		expect(update).toHaveBeenCalledWith(SITE_ID, form);
-		expect(socialsOf(store)).toEqual(form);
-	});
-
-	it("AC6 · a failed save routes through the error channel and reports it did not save", async () => {
-		const response = { status: 400, data: { message: "Invalid URL" } };
-		vi.spyOn(social, "updateSocial").mockResolvedValue(response as never);
-
-		const saved = await store.dispatch(socialActions.saveSocial(SOCIALS)).unwrap();
-
-		expect(handleError).toHaveBeenCalledWith(response);
-		// The screen keys `resetDirty()` off this boolean, so losing it means the form
-		// silently forgets unsaved changes.
-		expect(saved).toBe(false);
-		expect(socialsOf(store)).toEqual({});
-	});
-});

package/src/containers/ActivityLog/slice.ts

@@ -1,45 +0,0 @@
-import type { ILogItemsByDay, ILogItemsByUser } from "@ax/types";
-
-import { createSlice, type PayloadAction } from "@reduxjs/toolkit";
-
-/**
- * The `activityLog` area holds ONE page of the audit trail plus how it is grouped
- * (UC-AX-view-activity-log). There is a single slot for the page: switching between the
- * timeline and the grouped-by-user view overwrites it, which is why the screen refetches
- * whenever the mode changes.
- *
- * `activityLog` is a union because the two endpoints answer with differently shaped groups —
- * by day or by user — and the view picks its renderer off `listMode`, not off the data.
- *
- * Out of redux-persist since this migration (ADR 0002).
- */
-export interface IActivityLogState {
-	activityLog: ILogItemsByDay | ILogItemsByUser;
-	listMode: string;
-}
-
-export const initialState: IActivityLogState = {
-	activityLog: { totalItems: 0, items: [] },
-	listMode: "default",
-};
-
-const activityLogSlice = createSlice({
-	name: "activityLog",
-	initialState,
-	// The legacy reducer had both action types share one `return { ...state, ...payload }`
-	// branch, which worked because each payload carried exactly one key. One reducer per field
-	// says the same thing without the indirection.
-	reducers: {
-		setActivityLog(state, action: PayloadAction<ILogItemsByDay | ILogItemsByUser>) {
-			state.activityLog = action.payload;
-		},
-		setListMode(state, action: PayloadAction<string>) {
-			state.listMode = action.payload;
-		},
-	},
-});
-
-export const { setActivityLog, setListMode } = activityLogSlice.actions;
-
-export { initialState as activityLogInitialState };
-export const activityLogReducer = activityLogSlice.reducer;

package/src/containers/Analytics/slice.ts

@@ -1,48 +0,0 @@
-import type { IAnalytics, IDimension, IDimensionsGroup } from "@ax/types";
-
-import { createSlice, type PayloadAction } from "@reduxjs/toolkit";
-
-/**
- * The `analytics` area holds the tracking script and the Data Layer definition
- * (dimensions and their groups) of whatever scope is loaded — global or one site
- * (UC-AX-configure-seo-analytics). There is a single slot: loading a site
- * overwrites what global left, which is why the two settings screens reload on mount.
- *
- * STAYS in redux-persist, against the rule of ADR 0002: `AnalyticsField` (the page
- * editor's SEO/analytics field) reads `groups` from here and never fetches, so the
- * persist is what feeds it after a hard refresh. It decides which of two different
- * fields to render, so an empty `groups` is not a flash but the wrong editor. Leaves
- * when PageEditor migrates (wave 4).
- */
-export interface IAnalyticsState {
-	scriptCode: string;
-	siteScriptCodeExists: boolean;
-	dimensions: IDimension[];
-	groups: IDimensionsGroup[];
-}
-
-export const initialState: IAnalyticsState = {
-	scriptCode: "",
-	siteScriptCodeExists: false,
-	dimensions: [],
-	groups: [],
-};
-
-const analyticsSlice = createSlice({
-	name: "analytics",
-	initialState,
-	reducers: {
-		// MERGES, it does not replace: the legacy reducer spread the payload onto the
-		// state and `Sites/actions.tsx` dispatches this with whatever the site's
-		// metrics endpoint returned, which need not carry every field. Typed as a
-		// partial to say so out loud.
-		setAnalytics(state, action: PayloadAction<Partial<IAnalytics>>) {
-			Object.assign(state, action.payload);
-		},
-	},
-});
-
-export const { setAnalytics } = analyticsSlice.actions;
-
-export { initialState as analyticsInitialState };
-export const analyticsReducer = analyticsSlice.reducer;

package/src/containers/Analytics/thunks.ts

@@ -1,103 +0,0 @@
-import { analytics } from "@ax/api";
-import { appActions } from "@ax/containers/App";
-import { handleRequest } from "@ax/helpers";
-import type { IAnalytics } from "@ax/types";
-
-import { createAsyncThunk } from "@reduxjs/toolkit";
-import type { Dispatch } from "redux";
-
-import { setAnalytics } from "./slice";
-
-/**
- * Read and write side of UC-AX-configure-seo-analytics, as createAsyncThunk. They
- * keep calling `handleRequest` inside — see the Languages pilot and §5 of
- * docs/RTK-MIGRATION.md.
- *
- * `siteId` is `null` for the global scope, which the API spells `"global"`. The
- * legacy signatures made the argument optional; createAsyncThunk takes exactly one
- * argument, so the scope is now always explicit at the call site. That is the whole
- * of the churn this migration pushes onto the callers.
- */
-const onError = (response: unknown, dispatch: Dispatch, isMultiple = false, message?: string) =>
-	appActions.handleError(response, isMultiple, message)(dispatch);
-
-const scopeOf = (siteId: number | null) => siteId ?? "global";
-
-export const getAnalytics = createAsyncThunk("analytics/getAnalytics", async (siteId: number | null, { dispatch }) =>
-	handleRequest(
-		async () => analytics.getAnalytics(scopeOf(siteId)),
-		{
-			handleSuccess: (data: Partial<IAnalytics>) => dispatch(setAnalytics(data)),
-			handleError: (response: unknown) => onError(response, dispatch),
-		},
-		[],
-	)(dispatch),
-);
-
-interface IUpdateAnalyticsArgs {
-	analytics: IAnalytics;
-	siteId: number | null;
-}
-
-export const updateAnalytics = createAsyncThunk(
-	"analytics/updateAnalytics",
-	async ({ analytics: state, siteId }: IUpdateAnalyticsArgs, { dispatch }) => {
-		const { scriptCode, dimensions, groups } = state;
-		const scope = scopeOf(siteId);
-
-		return handleRequest(
-			// The three writes go out in PARALLEL and `handleRequest` treats the array
-			// of responses as a whole: any one of them failing fails the save.
-			async () =>
-				Promise.all([
-					analytics.updateScriptCode(scope, { scriptCode }),
-					analytics.createDimensions(scope, { dimensions }),
-					analytics.createDimensionsGroups(scope, { groups }),
-				]),
-			{
-				// Not awaited, as the legacy version did not await it either: the button
-				// stops saying "Saving" before the reload lands.
-				handleSuccess: () => dispatch(getAnalytics(siteId)),
-				handleError: (response: { data: { message?: string | string[] } }) => {
-					const { message } = response.data;
-					const isMultiple = Array.isArray(message) && message.length > 1;
-					const msg = isMultiple ? `The action failed due to ${message.length} errors.` : undefined;
-					onError(response, dispatch, isMultiple, msg);
-				},
-			},
-			[appActions.setIsSaving],
-		)(dispatch);
-	},
-);
-
-interface IUpdateScriptCodeArgs {
-	scriptCode: string;
-	siteId: number | null;
-}
-
-export const updateScriptCode = createAsyncThunk(
-	"analytics/updateScriptCode",
-	async ({ scriptCode, siteId }: IUpdateScriptCodeArgs, { dispatch }) =>
-		handleRequest(
-			async () => analytics.updateScriptCode(scopeOf(siteId), { scriptCode }),
-			{
-				handleSuccess: () => dispatch(getAnalytics(siteId)),
-				handleError: (response: unknown) => onError(response, dispatch),
-			},
-			[appActions.setIsSaving],
-		)(dispatch),
-);
-
-export const deleteScriptCode = createAsyncThunk(
-	"analytics/deleteScriptCode",
-	// No loading flag, as before: resetting to the global defaults shows no spinner.
-	async (siteId: number | null, { dispatch }) =>
-		handleRequest(
-			async () => analytics.deleteScriptCode(scopeOf(siteId)),
-			{
-				handleSuccess: () => dispatch(getAnalytics(siteId)),
-				handleError: (response: unknown) => onError(response, dispatch),
-			},
-			[],
-		)(dispatch),
-);

package/src/containers/Domains/slice.ts

@@ -1,37 +0,0 @@
-import type { IDomainRobot } from "@ax/types";
-
-import { createSlice, type PayloadAction } from "@reduxjs/toolkit";
-
-/**
- * The `domains` area holds the robots.txt of every domain (UC-AX-configure-seo-analytics,
- * `/settings/robots`). Despite the name it is not a domain manager: the list of
- * domains a site has is read through `sites`, and this slice only carries what the
- * robots.txt editor renders.
- *
- * Out of redux-persist since this migration (ADR 0002): the screen calls
- * `getDomainsRobots()` on mount, so the persisted copy was never read.
- */
-export interface IDomainsState {
-	robots: IDomainRobot[];
-}
-
-export const initialState: IDomainsState = {
-	robots: [],
-};
-
-const domainsSlice = createSlice({
-	name: "domains",
-	initialState,
-	reducers: {
-		// The legacy action wrapped the list in `{ robots }` to spread it onto the
-		// state; as a reducer the payload is just the list.
-		setDomainsRobots(state, action: PayloadAction<IDomainRobot[]>) {
-			state.robots = action.payload;
-		},
-	},
-});
-
-export const { setDomainsRobots } = domainsSlice.actions;
-
-export { initialState as domainsInitialState };
-export const domainsReducer = domainsSlice.reducer;

package/src/containers/Domains/thunks.ts

@@ -1,60 +0,0 @@
-import { domains } from "@ax/api";
-import { appActions } from "@ax/containers/App";
-import { handleRequest } from "@ax/helpers";
-import type { IDomainRobot } from "@ax/types";
-
-import { createAsyncThunk } from "@reduxjs/toolkit";
-import type { Dispatch } from "redux";
-
-import { setDomainsRobots } from "./slice";
-
-/**
- * Read and write side of the robots.txt editor, as createAsyncThunk.
- *
- * They keep calling `handleRequest` inside for the same reason the Languages
- * pilot does: that helper owns the loading-flag and error-channel conventions of
- * the whole codebase (152 call-sites) and replacing it is a cross-cutting job,
- * not this area's — see docs/RTK-MIGRATION.md §5.
- *
- * What does change: the legacy versions wrapped everything in a `try/catch` whose
- * body was `console.log(e)`, swallowing failures. createAsyncThunk turns a throw
- * into a `rejected` action instead, so the failure is observable.
- */
-// Called through the namespace rather than destructured at module scope: a
-// destructured reference is frozen at import time and cannot be spied on, which
-// would make the reload-after-save behaviour untestable.
-const onError = (response: unknown, dispatch: Dispatch, isMultiple = false, message?: string) =>
-	appActions.handleError(response, isMultiple, message)(dispatch);
-
-export const getDomainsRobots = createAsyncThunk<boolean, void>(
-	"domains/getDomainsRobots",
-	async (_arg, { dispatch }) =>
-		handleRequest(
-			async () => domains.getDomainsRobots(),
-			{
-				handleSuccess: (robots: IDomainRobot[]) => dispatch(setDomainsRobots(robots)),
-				handleError: (response: unknown) => onError(response, dispatch),
-			},
-			[appActions.setIsLoading],
-		)(dispatch),
-);
-
-export const updateDomainsRobots = createAsyncThunk(
-	"domains/updateDomainsRobots",
-	async (robots: IDomainRobot[], { dispatch }) =>
-		handleRequest(
-			async () => domains.updateDomainsRobots(robots),
-			{
-				// Reloading from the server is what makes `computedContent` (the
-				// inherited rules, read-only) reflect the content just saved.
-				handleSuccess: () => dispatch(getDomainsRobots()),
-				handleError: (response: { data: { message?: string | string[] } }) => {
-					const { message } = response.data;
-					const isMultiple = Array.isArray(message) && message.length > 1;
-					const msg = isMultiple ? `The action failed due to ${message.length} errors.` : undefined;
-					onError(response, dispatch, isMultiple, msg);
-				},
-			},
-			[appActions.setIsSaving],
-		)(dispatch),
-);

package/src/containers/Redirects/slice.ts

@@ -1,60 +0,0 @@
-import type { IRedirect } from "@ax/types";
-
-import { createSlice, type PayloadAction } from "@reduxjs/toolkit";
-
-/**
- * The `redirects` area holds ONE page of the redirect catalogue plus the result of the
- * last CSV import check (UC-AX-manage-redirects). Paging, searching and filtering live in
- * the view, so the list is whatever page was asked for last and `totalItems` is what the
- * pager counts with.
- *
- * The four setters stay internal to the area: nothing outside dispatches them — the legacy
- * `actions.tsx` did not export them either — so the barrel keeps them private and the
- * public surface is just the five thunks.
- *
- * Out of redux-persist since this migration (ADR 0002).
- */
-export interface IRedirectsState {
-	redirects: IRedirect[];
-	totalItems: number;
-	totalImports: number;
-	imports: null | {
-		error: IRedirect[];
-		existing: IRedirect[];
-		ok: IRedirect[];
-	};
-}
-
-export const initialState: IRedirectsState = {
-	redirects: [],
-	totalItems: 0,
-	totalImports: 0,
-	imports: null,
-};
-
-const redirectsSlice = createSlice({
-	name: "redirects",
-	initialState,
-	// The legacy reducer had all four action types share one `return { ...state, ...payload }`
-	// branch, which worked because each payload carried exactly one key. One reducer per
-	// field says the same thing without the indirection.
-	reducers: {
-		setRedirects(state, action: PayloadAction<IRedirect[]>) {
-			state.redirects = action.payload;
-		},
-		setTotalItems(state, action: PayloadAction<number>) {
-			state.totalItems = action.payload;
-		},
-		setImports(state, action: PayloadAction<IRedirectsState["imports"]>) {
-			state.imports = action.payload;
-		},
-		setTotalImports(state, action: PayloadAction<number>) {
-			state.totalImports = action.payload;
-		},
-	},
-});
-
-export const { setRedirects, setTotalItems, setImports, setTotalImports } = redirectsSlice.actions;
-
-export { initialState as redirectsInitialState };
-export const redirectsReducer = redirectsSlice.reducer;