@graphty/graph-io 0.3.29 → 0.3.31

package/src/formats/obo/exporter.ts

@@ -150,8 +150,8 @@ export const OBO_LOSS = Object.freeze({
      */
     ROLE_ASSUMED: ROLE_ASSUMED_CODE,
     /**
-     * An attribute with a role (for example, the label) is written where the format keeps that role, and reads back under the
-     * name the format's importer gives it.
+     * The node label column is written as each node's `name` and reads back as the column `name`. An edge label has no slot:
+     * it is written as a qualifier (W_ROLE_DROPPED and W_OBO_EDGE_COLUMN_AS_QUALIFIER), never under a new name.
      */
     COLUMN_NAME_CHANGED: LOSS.COLUMN_NAME_CHANGED,
     /**

package/src/formats/pajek/exporter.ts

@@ -17,7 +17,7 @@ import { type Column, GraphFormatError, type GraphSnapshot } from "@graphty/grap
 import { pairFolding } from "../../common/direction.js";
 import { isPajekLabel, quotePajekLabel } from "../../common/escape.js";
 import { capabilities, checkCapabilities, LOSS, type SanitizedIds, sanitizeIds } from "../../common/export.js";
-import { formatDecimal, formatF32, formatInteger, idText } from "../../common/format.js";
+import { formatDecimal, formatF32, formatInteger, formatNumber, idText } from "../../common/format.js";
 import { canonicalId } from "../../common/ids.js";
 import { resolveExportOptions } from "../../common/options.js";
 import { agree, plural } from "../../common/plural.js";
@@ -586,10 +586,11 @@ function coordinatesText(column: Column, i: number, writeZ: boolean): string | n
     }
     const dtype = column.dtype as "f32" | "f64" | "i32" | "u32" | "u8";
     const vector = column.value(i) as ArrayLike<number>;
-    const x = numberText(vector[0], dtype);
-    const y = numberText(vector[1], dtype);
+    // the importer reads coordinates by position, so the shortest text of each is enough
+    const x = formatNumber(vector[0], dtype);
+    const y = formatNumber(vector[1], dtype);
     if (column.meta.components === 3 && writeZ) {
-        return `${x} ${y} ${numberText(vector[2], dtype)}`;
+        return `${x} ${y} ${formatNumber(vector[2], dtype)}`;
     }
     return `${x} ${y}`;
 }

package/src/formats/pajek/importer.ts

@@ -46,7 +46,6 @@ import {
     UNKNOWN_ENCODING_CODE,
 } from "../../common/codes.js";
 import { DirectionResolver, type EdgeKind } from "../../common/direction.js";
-import { survivesF32 } from "../../common/format.js";
 import { coerceIdText, ID_MERGED_CODE, IdCoercer } from "../../common/ids.js";
 import { LineReader, throwIfAborted } from "../../common/input.js";
 import {
@@ -292,14 +291,14 @@ function spellsDecl(): ColumnDecl {
 }
 
 /**
- * The position column declaration (design section 5.2: f32 x 3, role position, units "file").
+ * The position column declaration (design section 5.2: f64 x 3, role position, units "file").
  * @param sourceDims - 2 or 3, the coordinate count of the first vertex line with coordinates
  * @returns a fresh declaration
  */
 function positionDecl(sourceDims: number): ColumnDecl {
     return {
         name: POSITION_COLUMN,
-        dtype: "f32",
+        dtype: "f64",
         components: 3,
         nullable: true,
         role: "position",
@@ -1183,7 +1182,7 @@ class PajekParser {
     }
 
     /**
-     * Write a vertex's coordinates into the position column (f32 x 3), declared on first use.
+     * Write a vertex's coordinates into the position column (f64 x 3), declared on first use.
      * @param index - the node index
      * @param dims - 2 or 3, the coordinates the line gave
      * @param point - x, y, z (0 when absent)
@@ -1202,15 +1201,6 @@ class PajekParser {
                 { line, element: String(k) },
             );
         }
-        if (!point.every(survivesF32)) {
-            this.report.warnOnce(
-                "precision",
-                PAJEK_ISSUE.PRECISION,
-                `vertex ${k} has a coordinate the f32 position column rounds (warned once)`,
-                { line, element: String(k) },
-                `${PAJEK_ISSUE.PRECISION}:position`,
-            );
-        }
         this.sink.setNodeValue(this.positionHandle, index, point);
     }
 

package/src/formats/pajek/syntax.ts

@@ -15,7 +15,7 @@
 export const LABEL_COLUMN = "label";
 
 /**
- * The node column holding the vertex coordinates (role position, f32 x 3, units "file").
+ * The node column holding the vertex coordinates (role position, f64 x 3, units "file").
  * @category Plugin helpers
  */
 export const POSITION_COLUMN = "position";

package/src/formats/xgmml/constants.ts

@@ -108,7 +108,7 @@ export const LABEL_COLUMN = "label";
 export const EDGE_ID_COLUMN = "id";
 
 /**
- * The node position (f32 x3, role position, y up).
+ * The node position (f64 x3, role position, y up).
  * @category Plugin helpers
  */
 export const POSITION_COLUMN = "position";

package/src/formats/xgmml/emit.ts

@@ -1430,7 +1430,7 @@ class Positions {
         if (this.values.size > 0) {
             const handle = this.emitter.declare("node", {
                 name: POSITION_COLUMN,
-                dtype: "f32",
+                dtype: "f64",
                 components: 3,
                 role: "position",
                 nullable: true,

package/src/formats/xgmml/exporter.ts

@@ -538,7 +538,7 @@ function planExport(snapshot: GraphSnapshot, options: ResolvedExportOptions, esc
     const notes = checkCapabilities(snapshot, CAPABILITIES, options, {
         roles: SLOT_ROLES,
         roleNames: ROLE_NAMES,
-        positionDtype: "f32",
+        positionDtype: "f64",
     }).filter((n) => n.code !== LOSS.JSON);
     const note: NoteFn = (code, message, column = null, count = null): void => {
         notes.push(Object.freeze({ code, message, column, count }));
@@ -986,10 +986,11 @@ function coordsOf(plan: Plan, zColumn: Column | null, node: number): [string, st
     const xyz = cellOf(plan.position, node);
     if (xyz !== null) {
         const [x, y, z] = Array.from(xyz as ArrayLike<number>);
+        const fmt = plan.position?.dtype === "f32" ? formatF32 : formatF64;
         if (Number.isFinite(x) && Number.isFinite(y)) {
-            out.push(["x", formatF32(x)], ["y", formatF32(y === 0 ? 0 : -y)]);
+            out.push(["x", fmt(x)], ["y", fmt(y === 0 ? 0 : -y)]);
             if (zColumn === null && z !== undefined && z !== 0 && Number.isFinite(z)) {
-                out.push(["z", formatF32(z)]);
+                out.push(["z", fmt(z)]);
             }
         }
     }