@gotgenes/pi-permission-system 18.1.1 → 18.2.0

package/test/tool-preview-formatter.test.ts

@@ -1,458 +0,0 @@
-import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";
-
-import type { ToolInputFormatterLookup } from "#src/tool-input-formatter-registry";
-
-// Mock logging collaborator before importing the module under test.
-vi.mock("../src/logging.js", () => ({
-  safeJsonStringify: vi.fn((value: unknown) => JSON.stringify(value)),
-}));
-
-import { safeJsonStringify } from "#src/logging";
-import {
-  TOOL_INPUT_LOG_PREVIEW_MAX_LENGTH,
-  TOOL_INPUT_PREVIEW_MAX_LENGTH,
-  TOOL_TEXT_SUMMARY_MAX_LENGTH,
-} from "#src/tool-input-preview";
-import {
-  resolveToolPreviewLimits,
-  ToolPreviewFormatter,
-  type ToolPreviewFormatterOptions,
-} from "#src/tool-preview-formatter";
-import type { PermissionCheckResult } from "#src/types";
-
-const mockedStringify = vi.mocked(safeJsonStringify);
-
-function makeFormatter(
-  overrides: Partial<ToolPreviewFormatterOptions> = {},
-): ToolPreviewFormatter {
-  return new ToolPreviewFormatter({
-    toolInputPreviewMaxLength: TOOL_INPUT_PREVIEW_MAX_LENGTH,
-    toolTextSummaryMaxLength: TOOL_TEXT_SUMMARY_MAX_LENGTH,
-    toolInputLogPreviewMaxLength: TOOL_INPUT_LOG_PREVIEW_MAX_LENGTH,
-    ...overrides,
-  });
-}
-
-function makeResult(
-  toolName: string,
-  overrides: Partial<PermissionCheckResult> = {},
-): PermissionCheckResult {
-  return {
-    toolName,
-    state: "allow",
-    source: "tool",
-    origin: "builtin",
-    ...overrides,
-  };
-}
-
-beforeEach(() => {
-  mockedStringify.mockReset();
-});
-
-afterEach(() => {
-  vi.restoreAllMocks();
-});
-
-// ── sanitizeInlineText ────────────────────────────────────────────────────
-
-describe("ToolPreviewFormatter.sanitizeInlineText", () => {
-  test("collapses whitespace and trims", () => {
-    const f = makeFormatter();
-    expect(f.sanitizeInlineText("  hello   world  ")).toBe("hello world");
-  });
-
-  test("returns 'empty text' for blank string", () => {
-    const f = makeFormatter();
-    expect(f.sanitizeInlineText("")).toBe("empty text");
-    expect(f.sanitizeInlineText("   ")).toBe("empty text");
-  });
-
-  test("truncates at constructor toolTextSummaryMaxLength", () => {
-    const f = makeFormatter({ toolTextSummaryMaxLength: 5 });
-    const result = f.sanitizeInlineText("hello world");
-    expect(result).toBe("hello…");
-  });
-
-  test("explicit maxLength override takes precedence over constructor default", () => {
-    const f = makeFormatter({ toolTextSummaryMaxLength: 80 });
-    const result = f.sanitizeInlineText("hello world", 5);
-    expect(result).toBe("hello…");
-  });
-});
-
-// ── formatJsonInputForPrompt ──────────────────────────────────────────────
-
-describe("ToolPreviewFormatter.formatJsonInputForPrompt", () => {
-  test("returns empty string when serialization yields empty", () => {
-    mockedStringify.mockReturnValue(undefined);
-    const f = makeFormatter();
-    expect(f.formatJsonInputForPrompt({})).toBe("");
-  });
-
-  test("returns prefixed JSON with 'with input' prefix", () => {
-    mockedStringify.mockReturnValue('{"k":"v"}');
-    const f = makeFormatter();
-    expect(f.formatJsonInputForPrompt({ k: "v" })).toBe('with input {"k":"v"}');
-  });
-
-  test("truncates at constructor toolInputPreviewMaxLength", () => {
-    const longJson = `"${"x".repeat(20)}"`;
-    mockedStringify.mockReturnValue(longJson);
-    const f = makeFormatter({ toolInputPreviewMaxLength: 10 });
-    const result = f.formatJsonInputForPrompt({});
-    // "with input " + 10 chars + ellipsis
-    const preview = result.slice("with input ".length);
-    expect(preview.length).toBe(11); // 10 + 1 for "…"
-    expect(preview.endsWith("…")).toBe(true);
-  });
-
-  test("does not truncate when within toolInputPreviewMaxLength", () => {
-    mockedStringify.mockReturnValue('{"k":"v"}');
-    const f = makeFormatter({ toolInputPreviewMaxLength: 200 });
-    expect(f.formatJsonInputForPrompt({ k: "v" })).toBe('with input {"k":"v"}');
-  });
-});
-
-// ── formatSearchInputForPrompt ────────────────────────────────────────────
-
-describe("ToolPreviewFormatter.formatSearchInputForPrompt", () => {
-  test("includes pattern and path", () => {
-    const f = makeFormatter();
-    const result = f.formatSearchInputForPrompt("grep", {
-      pattern: "TODO",
-      path: "/src",
-    });
-    expect(result).toContain("pattern 'TODO'");
-    expect(result).toContain("path '/src'");
-  });
-
-  test("truncates pattern at toolTextSummaryMaxLength", () => {
-    const f = makeFormatter({ toolTextSummaryMaxLength: 5 });
-    const result = f.formatSearchInputForPrompt("grep", {
-      pattern: "abcdefgh",
-    });
-    expect(result).toContain("abcde…");
-  });
-
-  test("uses 'current working directory' for find/grep/ls without path", () => {
-    const f = makeFormatter();
-    for (const toolName of ["find", "grep", "ls"]) {
-      const result = f.formatSearchInputForPrompt(toolName, {});
-      expect(result).toContain("current working directory");
-    }
-  });
-
-  test("returns empty string for unknown tool with no input", () => {
-    const f = makeFormatter();
-    expect(f.formatSearchInputForPrompt("other", {})).toBe("");
-  });
-});
-
-// ── formatToolInputForPrompt ──────────────────────────────────────────────
-
-describe("ToolPreviewFormatter.formatToolInputForPrompt", () => {
-  test("dispatches 'edit' to standalone formatEditInputForPrompt", () => {
-    mockedStringify.mockReturnValue(undefined);
-    const f = makeFormatter();
-    const result = f.formatToolInputForPrompt("edit", {
-      path: "/foo.ts",
-      edits: [],
-    });
-    expect(result).toContain("for '/foo.ts'");
-  });
-
-  test("dispatches 'write' to standalone formatWriteInputForPrompt", () => {
-    const f = makeFormatter();
-    const result = f.formatToolInputForPrompt("write", {
-      path: "/out.ts",
-      content: "hi",
-    });
-    expect(result).toContain("for '/out.ts'");
-  });
-
-  test("dispatches 'read' to standalone formatReadInputForPrompt", () => {
-    const f = makeFormatter();
-    const result = f.formatToolInputForPrompt("read", { path: "/src/x.ts" });
-    expect(result).toContain("path '/src/x.ts'");
-  });
-
-  test("dispatches 'find'/'grep'/'ls' to formatSearchInputForPrompt", () => {
-    const f = makeFormatter();
-    for (const tool of ["find", "grep", "ls"]) {
-      const result = f.formatToolInputForPrompt(tool, {});
-      expect(result).toContain("current working directory");
-    }
-  });
-
-  test("falls back to formatJsonInputForPrompt for unknown tools", () => {
-    mockedStringify.mockReturnValue('{"x":1}');
-    const f = makeFormatter();
-    const result = f.formatToolInputForPrompt("unknown", { x: 1 });
-    expect(result).toContain('{"x":1}');
-  });
-
-  test("unknown tool truncates at constructor toolInputPreviewMaxLength", () => {
-    const longJson = `{"k":"${"x".repeat(50)}"}`;
-    mockedStringify.mockReturnValue(longJson);
-    const f = makeFormatter({ toolInputPreviewMaxLength: 10 });
-    const result = f.formatToolInputForPrompt("custom", {});
-    const preview = result.slice("with input ".length);
-    expect(preview.endsWith("…")).toBe(true);
-    expect(preview.length).toBe(11); // 10 + "…"
-  });
-});
-
-// ── formatToolInputForPrompt (custom formatter seam) ───────────────────────
-
-describe("ToolPreviewFormatter.formatToolInputForPrompt — custom formatter seam", () => {
-  function makeLookup(
-    toolName: string,
-    result: string | undefined,
-  ): ToolInputFormatterLookup {
-    return {
-      get: (name) => (name === toolName ? () => result : undefined),
-    };
-  }
-
-  test("uses a custom formatter's string result verbatim, bypassing the switch", () => {
-    const lookup = makeLookup("my-tool", "custom preview");
-    const f = new ToolPreviewFormatter(
-      {
-        toolInputPreviewMaxLength: TOOL_INPUT_PREVIEW_MAX_LENGTH,
-        toolTextSummaryMaxLength: TOOL_TEXT_SUMMARY_MAX_LENGTH,
-        toolInputLogPreviewMaxLength: TOOL_INPUT_LOG_PREVIEW_MAX_LENGTH,
-      },
-      lookup,
-    );
-    expect(f.formatToolInputForPrompt("my-tool", {})).toBe("custom preview");
-  });
-
-  test("falls through to the built-in switch when custom formatter returns undefined", () => {
-    mockedStringify.mockReturnValue('{"x":1}');
-    const lookup = makeLookup("unknown-tool", undefined);
-    const f = new ToolPreviewFormatter(
-      {
-        toolInputPreviewMaxLength: TOOL_INPUT_PREVIEW_MAX_LENGTH,
-        toolTextSummaryMaxLength: TOOL_TEXT_SUMMARY_MAX_LENGTH,
-        toolInputLogPreviewMaxLength: TOOL_INPUT_LOG_PREVIEW_MAX_LENGTH,
-      },
-      lookup,
-    );
-    // Falls through to JSON default for unknown tools
-    expect(f.formatToolInputForPrompt("unknown-tool", { x: 1 })).toContain(
-      '{"x":1}',
-    );
-  });
-
-  test("custom formatter for a built-in tool overrides the built-in preview", () => {
-    const lookup = makeLookup("read", "custom read summary");
-    const f = new ToolPreviewFormatter(
-      {
-        toolInputPreviewMaxLength: TOOL_INPUT_PREVIEW_MAX_LENGTH,
-        toolTextSummaryMaxLength: TOOL_TEXT_SUMMARY_MAX_LENGTH,
-        toolInputLogPreviewMaxLength: TOOL_INPUT_LOG_PREVIEW_MAX_LENGTH,
-      },
-      lookup,
-    );
-    // Would normally use formatReadInputForPrompt; custom overrides it
-    expect(f.formatToolInputForPrompt("read", { path: "/foo.ts" })).toBe(
-      "custom read summary",
-    );
-  });
-
-  test("absent lookup preserves current behaviour for all tool types", () => {
-    const f = new ToolPreviewFormatter({
-      toolInputPreviewMaxLength: TOOL_INPUT_PREVIEW_MAX_LENGTH,
-      toolTextSummaryMaxLength: TOOL_TEXT_SUMMARY_MAX_LENGTH,
-      toolInputLogPreviewMaxLength: TOOL_INPUT_LOG_PREVIEW_MAX_LENGTH,
-    });
-    // Built-in path still works
-    expect(f.formatToolInputForPrompt("read", { path: "/foo.ts" })).toContain(
-      "/foo.ts",
-    );
-  });
-});
-
-// ── formatGenericToolInputForLog ──────────────────────────────────────────
-
-describe("ToolPreviewFormatter.formatGenericToolInputForLog", () => {
-  test("returns undefined when serialization yields empty string", () => {
-    mockedStringify.mockReturnValue(undefined);
-    const f = makeFormatter();
-    expect(f.formatGenericToolInputForLog({})).toBeUndefined();
-  });
-
-  test("returns prefixed input preview", () => {
-    mockedStringify.mockReturnValue('{"k":"v"}');
-    const f = makeFormatter();
-    expect(f.formatGenericToolInputForLog({ k: "v" })).toBe('input {"k":"v"}');
-  });
-
-  test("truncates at constructor toolInputLogPreviewMaxLength", () => {
-    const longJson = `{"k":"${"x".repeat(50)}"}`;
-    mockedStringify.mockReturnValue(longJson);
-    const f = makeFormatter({ toolInputLogPreviewMaxLength: 10 });
-    const result = f.formatGenericToolInputForLog({});
-    expect(result).toBeDefined();
-    const preview = result!.slice("input ".length);
-    expect(preview.length).toBe(11); // 10 + "…"
-    expect(preview.endsWith("…")).toBe(true);
-  });
-});
-
-// ── getToolInputPreviewForLog ─────────────────────────────────────────────
-
-describe("ToolPreviewFormatter.getToolInputPreviewForLog", () => {
-  const pathBearingTools = new Set(["read", "write", "edit"]);
-
-  test("returns undefined for bash tool", () => {
-    const f = makeFormatter();
-    expect(
-      f.getToolInputPreviewForLog(
-        makeResult("bash"),
-        { command: "ls" },
-        pathBearingTools,
-      ),
-    ).toBeUndefined();
-  });
-
-  test("returns undefined for mcp tool", () => {
-    const f = makeFormatter();
-    expect(
-      f.getToolInputPreviewForLog(makeResult("mcp"), {}, pathBearingTools),
-    ).toBeUndefined();
-  });
-
-  test("returns undefined for mcp source", () => {
-    const f = makeFormatter();
-    const result = makeResult("some-server:some-tool", { source: "mcp" });
-    expect(
-      f.getToolInputPreviewForLog(result, {}, pathBearingTools),
-    ).toBeUndefined();
-  });
-
-  test("returns path-based preview for path-bearing tools", () => {
-    const f = makeFormatter();
-    const preview = f.getToolInputPreviewForLog(
-      makeResult("read"),
-      { path: "/src/foo.ts" },
-      pathBearingTools,
-    );
-    expect(preview).toContain("/src/foo.ts");
-  });
-
-  test("truncates path preview at toolInputLogPreviewMaxLength", () => {
-    const f = makeFormatter({ toolInputLogPreviewMaxLength: 15 });
-    const longPath = `/src/${"a".repeat(50)}.ts`;
-    const preview = f.getToolInputPreviewForLog(
-      makeResult("read"),
-      { path: longPath },
-      pathBearingTools,
-    );
-    expect(preview).toBeDefined();
-    expect(preview!.length).toBeLessThanOrEqual(16); // 15 + "…"
-  });
-
-  test("returns generic JSON preview for non-path-bearing tools", () => {
-    mockedStringify.mockReturnValue('{"n":1}');
-    const f = makeFormatter();
-    const preview = f.getToolInputPreviewForLog(
-      makeResult("task"),
-      { n: 1 },
-      pathBearingTools,
-    );
-    expect(preview).toContain('{"n":1}');
-  });
-});
-
-// ── getPermissionLogContext ───────────────────────────────────────────────
-
-describe("ToolPreviewFormatter.getPermissionLogContext", () => {
-  const pathBearingTools = new Set(["read", "write", "edit"]);
-
-  test("returns command, target, toolInputPreview, and origin fields", () => {
-    const f = makeFormatter();
-    const result = makeResult("bash", { command: "ls -la" });
-    const ctx = f.getPermissionLogContext(result, {}, pathBearingTools);
-    expect(ctx.command).toBe("ls -la");
-    expect(ctx.target).toBeUndefined();
-    expect(ctx.toolInputPreview).toBeUndefined();
-  });
-
-  test("includes toolInputPreview for non-bash path-bearing tools", () => {
-    const f = makeFormatter();
-    const result = makeResult("read");
-    const ctx = f.getPermissionLogContext(
-      result,
-      { path: "/foo.ts" },
-      pathBearingTools,
-    );
-    expect(ctx.toolInputPreview).toContain("/foo.ts");
-  });
-
-  test("includes origin from check result", () => {
-    const f = makeFormatter();
-    const result = makeResult("read", { origin: "project" });
-    const ctx = f.getPermissionLogContext(result, {}, pathBearingTools);
-    expect(ctx.origin).toBe("project");
-  });
-
-  test("toolInputPreview respects toolInputLogPreviewMaxLength", () => {
-    const f = makeFormatter({ toolInputLogPreviewMaxLength: 15 });
-    const longPath = `/src/${"a".repeat(50)}.ts`;
-    const ctx = f.getPermissionLogContext(
-      makeResult("read"),
-      { path: longPath },
-      pathBearingTools,
-    );
-    expect(ctx.toolInputPreview).toBeDefined();
-    expect(ctx.toolInputPreview!.length).toBeLessThanOrEqual(16);
-  });
-});
-
-// ── resolveToolPreviewLimits ───────────────────────────────────────────────
-
-describe("resolveToolPreviewLimits", () => {
-  test("uses configured toolInputPreviewMaxLength when provided", () => {
-    const opts = resolveToolPreviewLimits({ toolInputPreviewMaxLength: 400 });
-    expect(opts.toolInputPreviewMaxLength).toBe(400);
-  });
-
-  test("falls back to TOOL_INPUT_PREVIEW_MAX_LENGTH when toolInputPreviewMaxLength is absent", () => {
-    const opts = resolveToolPreviewLimits({});
-    expect(opts.toolInputPreviewMaxLength).toBe(TOOL_INPUT_PREVIEW_MAX_LENGTH);
-  });
-
-  test("uses configured toolTextSummaryMaxLength when provided", () => {
-    const opts = resolveToolPreviewLimits({ toolTextSummaryMaxLength: 120 });
-    expect(opts.toolTextSummaryMaxLength).toBe(120);
-  });
-
-  test("falls back to TOOL_TEXT_SUMMARY_MAX_LENGTH when toolTextSummaryMaxLength is absent", () => {
-    const opts = resolveToolPreviewLimits({});
-    expect(opts.toolTextSummaryMaxLength).toBe(TOOL_TEXT_SUMMARY_MAX_LENGTH);
-  });
-
-  test("always sets toolInputLogPreviewMaxLength to TOOL_INPUT_LOG_PREVIEW_MAX_LENGTH", () => {
-    const opts = resolveToolPreviewLimits({
-      toolInputPreviewMaxLength: 999,
-      toolTextSummaryMaxLength: 999,
-    });
-    expect(opts.toolInputLogPreviewMaxLength).toBe(
-      TOOL_INPUT_LOG_PREVIEW_MAX_LENGTH,
-    );
-  });
-
-  test("returns all three options when both fields are configured", () => {
-    const opts = resolveToolPreviewLimits({
-      toolInputPreviewMaxLength: 400,
-      toolTextSummaryMaxLength: 120,
-    });
-    expect(opts).toEqual({
-      toolInputPreviewMaxLength: 400,
-      toolTextSummaryMaxLength: 120,
-      toolInputLogPreviewMaxLength: TOOL_INPUT_LOG_PREVIEW_MAX_LENGTH,
-    });
-  });
-});

package/test/tool-registry.test.ts

@@ -1,197 +0,0 @@
-import { afterEach, describe, expect, test, vi } from "vitest";
-
-import {
-  checkRequestedToolRegistration,
-  getToolNameFromValue,
-} from "#src/tool-registry";
-
-afterEach(() => {
-  vi.restoreAllMocks();
-});
-
-describe("getToolNameFromValue", () => {
-  test("returns string value directly", () => {
-    expect(getToolNameFromValue("read")).toBe("read");
-  });
-
-  test("returns null for empty string", () => {
-    expect(getToolNameFromValue("")).toBeNull();
-  });
-
-  test("returns null for whitespace-only string", () => {
-    expect(getToolNameFromValue("   ")).toBeNull();
-  });
-
-  test("returns null for null", () => {
-    expect(getToolNameFromValue(null)).toBeNull();
-  });
-
-  test("returns null for undefined", () => {
-    expect(getToolNameFromValue(undefined)).toBeNull();
-  });
-
-  test("extracts toolName from object", () => {
-    expect(getToolNameFromValue({ toolName: "write" })).toBe("write");
-  });
-
-  test("extracts name from object", () => {
-    expect(getToolNameFromValue({ name: "edit" })).toBe("edit");
-  });
-
-  test("extracts tool from object", () => {
-    expect(getToolNameFromValue({ tool: "bash" })).toBe("bash");
-  });
-
-  test("prefers toolName over name over tool", () => {
-    expect(
-      getToolNameFromValue({
-        toolName: "first",
-        name: "second",
-        tool: "third",
-      }),
-    ).toBe("first");
-  });
-
-  test("falls back to name when toolName is empty", () => {
-    expect(getToolNameFromValue({ toolName: "", name: "edit" })).toBe("edit");
-  });
-
-  test("returns null for object with no recognised keys", () => {
-    expect(getToolNameFromValue({ unknown: "read" })).toBeNull();
-  });
-
-  test("returns null for number input", () => {
-    expect(getToolNameFromValue(42)).toBeNull();
-  });
-});
-
-describe("checkRequestedToolRegistration", () => {
-  test("returns missing-tool-name for null requested name", () => {
-    const result = checkRequestedToolRegistration(null, []);
-    expect(result.status).toBe("missing-tool-name");
-  });
-
-  test("returns missing-tool-name for whitespace-only requested name", () => {
-    const result = checkRequestedToolRegistration("   ", []);
-    expect(result.status).toBe("missing-tool-name");
-  });
-
-  test("returns registered when tool name matches a string entry", () => {
-    const result = checkRequestedToolRegistration("read", ["read", "write"]);
-    expect(result.status).toBe("registered");
-    if (result.status === "registered") {
-      expect(result.requestedToolName).toBe("read");
-      expect(result.normalizedToolName).toBe("read");
-    }
-  });
-
-  test("returns registered when tool name matches an object entry by name", () => {
-    const result = checkRequestedToolRegistration("edit", [{ name: "edit" }]);
-    expect(result.status).toBe("registered");
-  });
-
-  test("returns registered when tool name matches an object entry by toolName", () => {
-    const result = checkRequestedToolRegistration("bash", [
-      { toolName: "bash" },
-    ]);
-    expect(result.status).toBe("registered");
-  });
-
-  test("returns unregistered when tool is not in the list", () => {
-    const result = checkRequestedToolRegistration("ghost", ["read", "write"]);
-    expect(result.status).toBe("unregistered");
-    if (result.status === "unregistered") {
-      expect(result.requestedToolName).toBe("ghost");
-      expect(result.availableToolNames).toContain("read");
-      expect(result.availableToolNames).toContain("write");
-    }
-  });
-
-  test("available tool names are sorted alphabetically", () => {
-    const result = checkRequestedToolRegistration("ghost", [
-      "write",
-      "read",
-      "edit",
-    ]);
-    if (result.status === "unregistered") {
-      expect(result.availableToolNames).toEqual(["edit", "read", "write"]);
-    }
-  });
-
-  test("resolves alias: requested alias maps to registered canonical name", () => {
-    const aliases = { Execute: "bash" };
-    const result = checkRequestedToolRegistration("Execute", ["bash"], aliases);
-    expect(result.status).toBe("registered");
-    if (result.status === "registered") {
-      expect(result.normalizedToolName).toBe("bash");
-    }
-  });
-
-  test("resolves alias: registered canonical is found via reverse alias lookup", () => {
-    // "bash" is registered; alias maps "Execute" → "bash"
-    // requesting "bash" directly should still resolve via the alias table
-    const aliases = { Execute: "bash" };
-    const result = checkRequestedToolRegistration("bash", ["bash"], aliases);
-    expect(result.status).toBe("registered");
-  });
-
-  test("returns unregistered with empty availableToolNames for empty tool list", () => {
-    const result = checkRequestedToolRegistration("read", []);
-    expect(result.status).toBe("unregistered");
-    if (result.status === "unregistered") {
-      expect(result.availableToolNames).toEqual([]);
-    }
-  });
-
-  test("skips tool list entries that yield no name", () => {
-    const result = checkRequestedToolRegistration("read", [
-      null,
-      {},
-      { unrelated: "x" },
-      "read",
-    ]);
-    expect(result.status).toBe("registered");
-  });
-});
-
-// ---------------------------------------------------------------------------
-// Moved from permission-system.test.ts catch-all (#342)
-// ---------------------------------------------------------------------------
-
-test("Tool registry resolves event tool names from string and object payloads", () => {
-  expect(getToolNameFromValue("  read  ")).toBe("read");
-  expect(getToolNameFromValue({ toolName: "write" })).toBe("write");
-  expect(getToolNameFromValue({ name: "find" })).toBe("find");
-  expect(getToolNameFromValue({ tool: "grep" })).toBe("grep");
-  expect(getToolNameFromValue({})).toBe(null);
-});
-
-test("Tool registry blocks unregistered tools and handles aliases", () => {
-  const registeredTools = [
-    { toolName: "mcp" },
-    { toolName: "read" },
-    { toolName: "bash" },
-  ];
-
-  const unknownCheck = checkRequestedToolRegistration(
-    "third_party_tool",
-    registeredTools,
-  );
-  expect(unknownCheck.status).toBe("unregistered");
-  if (unknownCheck.status === "unregistered") {
-    expect(unknownCheck.availableToolNames).toEqual(["bash", "mcp", "read"]);
-  }
-
-  const aliasCheck = checkRequestedToolRegistration(
-    "legacy_read",
-    registeredTools,
-    { legacy_read: "read" },
-  );
-  expect(aliasCheck.status).toBe("registered");
-
-  const missingNameCheck = checkRequestedToolRegistration(
-    "   ",
-    registeredTools,
-  );
-  expect(missingNameCheck.status).toBe("missing-tool-name");
-});