@gotgenes/pi-permission-system 18.1.1 → 18.2.0

package/test/permissions-service.test.ts

@@ -1,192 +0,0 @@
-import { beforeEach, describe, expect, it, type Mock, vi } from "vitest";
-import type { AccessIntent } from "#src/access-intent/access-intent";
-import { PathNormalizer } from "#src/path-normalizer";
-import { LocalPermissionsService } from "#src/permissions-service";
-import type { ToolAccessExtractorRegistrar } from "#src/tool-access-extractor-registry";
-import type {
-  ToolInputFormatter,
-  ToolInputFormatterRegistrar,
-} from "#src/tool-input-formatter-registry";
-import type { PermissionCheckResult, PermissionState } from "#src/types";
-
-import { makeCheckResult } from "#test/helpers/handler-fixtures";
-
-// Mock node:fs so realpathSync (the canonical alias) is controllable.
-const realpathSync = vi.hoisted(() =>
-  vi.fn<(path: string) => string>((p) => p),
-);
-vi.mock("node:fs", () => ({
-  realpathSync,
-  default: { realpathSync },
-}));
-
-// ── helpers ────────────────────────────────────────────────────────────────
-
-interface FakeResolver {
-  resolve: Mock<(intent: AccessIntent) => PermissionCheckResult>;
-  getToolPermission: Mock<
-    (toolName: string, agentName?: string) => PermissionState
-  >;
-}
-
-function makeResolver(): FakeResolver {
-  return {
-    resolve: vi
-      .fn<(intent: AccessIntent) => PermissionCheckResult>()
-      .mockReturnValue(makeCheckResult()),
-    getToolPermission: vi
-      .fn<(toolName: string, agentName?: string) => PermissionState>()
-      .mockReturnValue("ask"),
-  };
-}
-
-function makeFormatterRegistry(): ToolInputFormatterRegistrar {
-  return {
-    register: vi
-      .fn<ToolInputFormatterRegistrar["register"]>()
-      .mockReturnValue(vi.fn()),
-  };
-}
-
-function makeAccessExtractorRegistry(): ToolAccessExtractorRegistrar {
-  return {
-    register: vi
-      .fn<ToolAccessExtractorRegistrar["register"]>()
-      .mockReturnValue(vi.fn()),
-  };
-}
-
-function makeService(overrides?: {
-  resolver?: FakeResolver;
-  formatterRegistry?: ToolInputFormatterRegistrar;
-  accessExtractorRegistry?: ToolAccessExtractorRegistrar;
-}) {
-  const resolver = overrides?.resolver ?? makeResolver();
-  // The published service always answers against the parent session's cwd.
-  const session = { getPathNormalizer: () => normalizer };
-  const formatterRegistry =
-    overrides?.formatterRegistry ?? makeFormatterRegistry();
-  const accessExtractorRegistry =
-    overrides?.accessExtractorRegistry ?? makeAccessExtractorRegistry();
-  const service = new LocalPermissionsService(
-    resolver,
-    session,
-    formatterRegistry,
-    accessExtractorRegistry,
-  );
-  return { service, resolver, formatterRegistry, accessExtractorRegistry };
-}
-
-const normalizer = new PathNormalizer("linux", "/test/project");
-
-// ── tests ──────────────────────────────────────────────────────────────────
-
-beforeEach(() => {
-  realpathSync.mockReset();
-  realpathSync.mockImplementation((p: string) => p);
-});
-
-describe("checkPermission", () => {
-  it("resolves a non-path surface through a tool intent", () => {
-    const { service, resolver } = makeService();
-    service.checkPermission("bash", "echo hi", "my-agent");
-    expect(resolver.resolve).toHaveBeenCalledWith({
-      kind: "tool",
-      surface: "bash",
-      input: { command: "echo hi" },
-      agentName: "my-agent",
-    });
-  });
-
-  it("resolves an external_directory path query through an access-path intent matching the canonical alias", () => {
-    realpathSync.mockImplementation((p: string) =>
-      p === "/test/project/link" ? "/test/project/real" : p,
-    );
-    const { service, resolver } = makeService();
-    service.checkPermission("external_directory", "link");
-    expect(resolver.resolve).toHaveBeenCalledTimes(1);
-    const intent = resolver.resolve.mock.calls[0][0];
-    expect(intent.kind).toBe("access-path");
-    if (intent.kind === "access-path") {
-      expect(intent.surface).toBe("external_directory");
-      expect(intent.path.matchValues()).toContain("/test/project/real");
-    }
-  });
-
-  it("resolves a path-bearing tool query (read) through an access-path intent", () => {
-    const { service, resolver } = makeService();
-    service.checkPermission("read", "/test/project/.env");
-    const intent = resolver.resolve.mock.calls[0][0];
-    expect(intent.kind).toBe("access-path");
-    if (intent.kind === "access-path") {
-      expect(intent.surface).toBe("read");
-      expect(intent.path.value()).toBe("/test/project/.env");
-    }
-  });
-
-  it("falls back to a tool intent for a value-less path query", () => {
-    const { service, resolver } = makeService();
-    service.checkPermission("path");
-    const intent = resolver.resolve.mock.calls[0][0];
-    expect(intent.kind).toBe("tool");
-  });
-
-  it("returns the result from resolver.resolve", () => {
-    const expected = makeCheckResult({ state: "deny", toolName: "bash" });
-    const resolver = makeResolver();
-    resolver.resolve.mockReturnValue(expected);
-    const { service } = makeService({ resolver });
-    const result = service.checkPermission("bash", "rm -rf /");
-    expect(result).toBe(expected);
-  });
-});
-
-describe("getToolPermission", () => {
-  it("delegates to resolver.getToolPermission", () => {
-    const resolver = makeResolver();
-    resolver.getToolPermission.mockReturnValue("deny");
-    const { service } = makeService({ resolver });
-    const result = service.getToolPermission("write", "my-agent");
-    expect(resolver.getToolPermission).toHaveBeenCalledWith(
-      "write",
-      "my-agent",
-    );
-    expect(result).toBe("deny");
-  });
-
-  it("omits agentName when not provided", () => {
-    const { service, resolver } = makeService();
-    service.getToolPermission("read");
-    expect(resolver.getToolPermission).toHaveBeenCalledWith("read", undefined);
-  });
-});
-
-describe("registerToolInputFormatter", () => {
-  it("delegates to formatterRegistry.register and returns the unsubscribe function", () => {
-    const unsub = vi.fn();
-    const { service, formatterRegistry } = makeService();
-    vi.mocked(formatterRegistry.register).mockReturnValue(unsub);
-    const formatter: ToolInputFormatter = vi.fn();
-    const result = service.registerToolInputFormatter("my-tool", formatter);
-    expect(formatterRegistry.register).toHaveBeenCalledWith(
-      "my-tool",
-      formatter,
-    );
-    expect(result).toBe(unsub);
-  });
-});
-
-describe("registerToolAccessExtractor", () => {
-  it("delegates to accessExtractorRegistry.register and returns the unsubscribe function", () => {
-    const unsub = vi.fn();
-    const { service, accessExtractorRegistry } = makeService();
-    vi.mocked(accessExtractorRegistry.register).mockReturnValue(unsub);
-    const extractor = vi.fn();
-    const result = service.registerToolAccessExtractor("ffgrep", extractor);
-    expect(accessExtractorRegistry.register).toHaveBeenCalledWith(
-      "ffgrep",
-      extractor,
-    );
-    expect(result).toBe(unsub);
-  });
-});

package/test/pi-infrastructure-read.test.ts

@@ -1,432 +0,0 @@
-import { homedir } from "node:os";
-import { join } from "node:path";
-import { beforeEach, describe, expect, test, vi } from "vitest";
-
-// Hoisted stub so the vi.mock factory can reference it.
-const { mockSpawnSync } = vi.hoisted(() => ({
-  mockSpawnSync: vi.fn(),
-}));
-
-// Mock node:child_process so tests that exercise the subprocess fallback path
-// don't actually invoke npm.  Default: subprocess fails (non-zero exit), so
-// tests focused on the walk-up strategy continue to expect null.
-vi.mock("node:child_process", () => ({
-  spawnSync: mockSpawnSync,
-  default: { spawnSync: mockSpawnSync },
-}));
-
-import { discoverGlobalNodeModulesRoot } from "#src/node-modules-discovery";
-import { isPiInfrastructureRead } from "#src/pi-infrastructure-read";
-
-// ── discoverGlobalNodeModulesRoot ──────────────────────────────────────────
-
-describe("discoverGlobalNodeModulesRoot", () => {
-  beforeEach(() => {
-    // Default: subprocess fails, so walk-up-focused tests see null for URLs
-    // with no node_modules ancestor.
-    mockSpawnSync.mockReset();
-    mockSpawnSync.mockReturnValue({ status: 1, stdout: "" });
-  });
-
-  test("returns the node_modules dir when the file is inside one", () => {
-    const url =
-      "file:///opt/homebrew/lib/node_modules/pi-permission-system/dist/external-directory.js";
-    expect(discoverGlobalNodeModulesRoot(url)).toBe(
-      "/opt/homebrew/lib/node_modules",
-    );
-  });
-
-  test("returns node_modules for a deeply nested file", () => {
-    const url =
-      "file:///home/user/.nvm/versions/node/v20/lib/node_modules/pi-permission-system/src/external-directory.js";
-    expect(discoverGlobalNodeModulesRoot(url)).toBe(
-      "/home/user/.nvm/versions/node/v20/lib/node_modules",
-    );
-  });
-
-  test("returns node_modules for a bun global install path", () => {
-    const url =
-      "file:///home/user/.bun/install/global/node_modules/pi-permission-system/dist/external-directory.js";
-    expect(discoverGlobalNodeModulesRoot(url)).toBe(
-      "/home/user/.bun/install/global/node_modules",
-    );
-  });
-
-  test("returns the innermost (closest-to-file) node_modules ancestor", () => {
-    // The walk-up algorithm stops at the first node_modules dir it encounters,
-    // which is the innermost one when the file is inside a nested install.
-    // In practice this never happens for a real global install — the extension
-    // is always directly at <global_root>/node_modules/pi-permission-system/…
-    const url =
-      "file:///opt/lib/node_modules/some-pkg/node_modules/pi-permission-system/dist/index.js";
-    expect(discoverGlobalNodeModulesRoot(url)).toBe(
-      "/opt/lib/node_modules/some-pkg/node_modules",
-    );
-  });
-
-  test("returns null when the file is not inside any node_modules directory", () => {
-    const url =
-      "file:///home/user/development/pi-permission-system/dist/external-directory.js";
-    expect(discoverGlobalNodeModulesRoot(url)).toBeNull();
-  });
-
-  test("returns null for a root-level file", () => {
-    const url = "file:///external-directory.js";
-    expect(discoverGlobalNodeModulesRoot(url)).toBeNull();
-  });
-
-  test("returns null for an invalid URL", () => {
-    expect(discoverGlobalNodeModulesRoot("not-a-url")).toBeNull();
-  });
-
-  test("works with the real import.meta.url of this extension (smoke test)", () => {
-    // The extension IS installed inside a node_modules tree when running in CI
-    // or global install. In a local dev checkout the result may be null — that's
-    // the documented graceful-degradation path.
-    const result = discoverGlobalNodeModulesRoot();
-    expect(result === null || result.endsWith("node_modules")).toBe(true);
-  });
-
-  test("the discovered path includes the pi-permission-system package directory", () => {
-    const url =
-      "file:///opt/homebrew/lib/node_modules/pi-permission-system/dist/external-directory.js";
-    const root = discoverGlobalNodeModulesRoot(url);
-    expect(root).not.toBeNull();
-    expect(join(root!, "pi-permission-system")).toBe(
-      "/opt/homebrew/lib/node_modules/pi-permission-system",
-    );
-  });
-});
-
-// ── isPiInfrastructureRead ─────────────────────────────────────────────────
-
-const INFRA_DIRS = [
-  "/home/user/.pi/agent",
-  "/home/user/.pi/agent/git",
-  "/opt/homebrew/lib/node_modules",
-];
-const CWD = "/home/user/project";
-
-describe("isPiInfrastructureRead", () => {
-  // ── read tools allowed for infra paths ──────────────────────────────────
-
-  test("allows 'read' tool for a file inside agentDir", () => {
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        "/home/user/.pi/agent/extensions/pi-permission-system/config.json",
-        INFRA_DIRS,
-        CWD,
-        "linux",
-      ),
-    ).toBe(true);
-  });
-
-  test("allows 'find' tool for a path inside node_modules infra dir", () => {
-    expect(
-      isPiInfrastructureRead(
-        "find",
-        "/opt/homebrew/lib/node_modules/pi-ask-user/skills",
-        INFRA_DIRS,
-        CWD,
-        "linux",
-      ),
-    ).toBe(true);
-  });
-
-  test("allows 'grep' tool for a path inside agentDir/git", () => {
-    expect(
-      isPiInfrastructureRead(
-        "grep",
-        "/home/user/.pi/agent/git/some-package/README.md",
-        INFRA_DIRS,
-        CWD,
-        "linux",
-      ),
-    ).toBe(true);
-  });
-
-  test("allows 'ls' tool for a path inside node_modules infra dir", () => {
-    expect(
-      isPiInfrastructureRead(
-        "ls",
-        "/opt/homebrew/lib/node_modules/pi-permission-system",
-        INFRA_DIRS,
-        CWD,
-        "linux",
-      ),
-    ).toBe(true);
-  });
-
-  // ── write tools never allowed even for infra paths ───────────────────────
-
-  test("blocks 'write' tool for a file inside agentDir", () => {
-    expect(
-      isPiInfrastructureRead(
-        "write",
-        "/home/user/.pi/agent/extensions/pi-permission-system/config.json",
-        INFRA_DIRS,
-        CWD,
-        "linux",
-      ),
-    ).toBe(false);
-  });
-
-  test("blocks 'edit' tool for a file inside node_modules", () => {
-    expect(
-      isPiInfrastructureRead(
-        "edit",
-        "/opt/homebrew/lib/node_modules/pi-ask-user/skills/ask-user/SKILL.md",
-        INFRA_DIRS,
-        CWD,
-        "linux",
-      ),
-    ).toBe(false);
-  });
-
-  test("blocks 'bash' tool regardless of path", () => {
-    expect(
-      isPiInfrastructureRead(
-        "bash",
-        "/opt/homebrew/lib/node_modules/pi-ask-user/SKILL.md",
-        INFRA_DIRS,
-        CWD,
-        "linux",
-      ),
-    ).toBe(false);
-  });
-
-  // ── non-infra paths not allowed ──────────────────────────────────────────
-
-  test("does not allow 'read' for a path outside all infra dirs", () => {
-    expect(
-      isPiInfrastructureRead("read", "/etc/passwd", INFRA_DIRS, CWD, "linux"),
-    ).toBe(false);
-  });
-
-  test("does not allow 'read' for a path only partially matching an infra dir prefix", () => {
-    // /home/user/.pi/agent-other should not match /home/user/.pi/agent
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        "/home/user/.pi/agent-other/config.json",
-        INFRA_DIRS,
-        CWD,
-        "linux",
-      ),
-    ).toBe(false);
-  });
-
-  // ── project-local Pi packages (.pi/npm, .pi/git) ─────────────────────────
-
-  test("allows 'read' for a path inside project-local .pi/npm/", () => {
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        `${CWD}/.pi/npm/node_modules/some-skill/SKILL.md`,
-        INFRA_DIRS,
-        CWD,
-        "linux",
-      ),
-    ).toBe(true);
-  });
-
-  test("allows 'read' for a path inside project-local .pi/git/", () => {
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        `${CWD}/.pi/git/github.com/org/skill-repo/SKILL.md`,
-        INFRA_DIRS,
-        CWD,
-        "linux",
-      ),
-    ).toBe(true);
-  });
-
-  test("blocks 'write' for a path inside project-local .pi/npm/", () => {
-    expect(
-      isPiInfrastructureRead(
-        "write",
-        `${CWD}/.pi/npm/node_modules/some-skill/SKILL.md`,
-        INFRA_DIRS,
-        CWD,
-        "linux",
-      ),
-    ).toBe(false);
-  });
-
-  // ── empty / edge cases ───────────────────────────────────────────────────
-
-  test("returns false when infrastructureDirs is empty and path is not project-local", () => {
-    expect(
-      isPiInfrastructureRead("read", "/etc/passwd", [], CWD, "linux"),
-    ).toBe(false);
-  });
-
-  test("returns false when infrastructureDirs is empty but path IS project-local .pi/npm", () => {
-    // Project-local paths are checked separately from the dirs array.
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        `${CWD}/.pi/npm/node_modules/x/SKILL.md`,
-        [],
-        CWD,
-        "linux",
-      ),
-    ).toBe(true);
-  });
-});
-
-// ── isPiInfrastructureRead — glob patterns ─────────────────────────────────
-
-describe("isPiInfrastructureRead with glob patterns", () => {
-  test("glob entry matches a versioned nested path", () => {
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        "/opt/homebrew/Cellar/pi-coding-agent/0.74.0/libexec/lib/node_modules/@earendil-works/pi-coding-agent/SKILL.md",
-        ["/opt/homebrew/*/@earendil-works/pi-coding-agent/*"],
-        CWD,
-        "linux",
-      ),
-    ).toBe(true);
-  });
-
-  test("** behaves the same as * (matches across path separators)", () => {
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        "/opt/homebrew/Cellar/pi-coding-agent/0.74.0/libexec/lib/node_modules/@earendil-works/pi-coding-agent/SKILL.md",
-        ["/opt/homebrew/**/@earendil-works/pi-coding-agent/**"],
-        CWD,
-        "linux",
-      ),
-    ).toBe(true);
-  });
-
-  test("glob entry does not match an unrelated path", () => {
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        "/etc/passwd",
-        ["/opt/homebrew/*/@earendil-works/pi-coding-agent/*"],
-        CWD,
-        "linux",
-      ),
-    ).toBe(false);
-  });
-
-  test("? matches exactly one character", () => {
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        "/opt/homebrew/X/file.md",
-        ["/opt/homebrew/?/file.md"],
-        CWD,
-        "linux",
-      ),
-    ).toBe(true);
-  });
-
-  test("? does not match multiple characters", () => {
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        "/opt/homebrew/abc/file.md",
-        ["/opt/homebrew/?/file.md"],
-        CWD,
-        "linux",
-      ),
-    ).toBe(false);
-  });
-
-  test("mixed array of plain dirs and glob patterns — both branches work", () => {
-    const dirs = [
-      "/home/user/.pi/agent",
-      "/opt/homebrew/*/@earendil-works/pi-coding-agent/*",
-    ];
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        "/home/user/.pi/agent/config.json",
-        dirs,
-        CWD,
-        "linux",
-      ),
-    ).toBe(true);
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        "/opt/homebrew/Cellar/pi-coding-agent/0.74.0/libexec/lib/node_modules/@earendil-works/pi-coding-agent/SKILL.md",
-        dirs,
-        CWD,
-        "linux",
-      ),
-    ).toBe(true);
-  });
-
-  test("plain entry with ~ prefix matches after home expansion", () => {
-    const home = homedir();
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        `${home}/.pi/agent/config.json`,
-        ["~/.pi/agent"],
-        CWD,
-        "linux",
-      ),
-    ).toBe(true);
-  });
-
-  test("write tool with a glob-matching path is still rejected", () => {
-    expect(
-      isPiInfrastructureRead(
-        "write",
-        "/opt/homebrew/Cellar/pi-coding-agent/0.74.0/libexec/lib/node_modules/@earendil-works/pi-coding-agent/SKILL.md",
-        ["/opt/homebrew/**/@earendil-works/pi-coding-agent/**"],
-        CWD,
-        "linux",
-      ),
-    ).toBe(false);
-  });
-});
-
-// ── isPiInfrastructureRead — win32 case-insensitive matching ───────────────
-
-describe("isPiInfrastructureRead on win32", () => {
-  test("plain infra dir matches a case-different path", () => {
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        "c:\\users\\foo\\.pi\\agent\\config.json",
-        ["C:\\Users\\Foo\\.pi\\agent"],
-        "C:\\proj",
-        "win32",
-      ),
-    ).toBe(true);
-  });
-
-  test("glob infra dir matches case-insensitively", () => {
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        "c:\\users\\foo\\npm\\node_modules\\@earendil-works\\pi-coding-agent\\skill.md",
-        ["C:\\Users\\Foo\\**\\pi-coding-agent\\**"],
-        "C:\\proj",
-        "win32",
-      ),
-    ).toBe(true);
-  });
-
-  test("rejects a path outside every infra dir", () => {
-    expect(
-      isPiInfrastructureRead(
-        "read",
-        "c:\\windows\\system32\\drivers\\etc\\hosts",
-        ["C:\\Users\\Foo\\.pi\\agent"],
-        "C:\\proj",
-        "win32",
-      ),
-    ).toBe(false);
-  });
-});