@google/gemini-cli 0.11.0-preview.0 → 0.12.0-nightly.20251023.c4c0c0d1

package/dist/src/config/extension.test.js

@@ -7,14 +7,16 @@ import { vi } from 'vitest';
 import * as fs from 'node:fs';
 import * as os from 'node:os';
 import * as path from 'node:path';
-import { createHash } from 'node:crypto';
-import { EXTENSIONS_CONFIG_FILENAME, ExtensionStorage, INSTALL_METADATA_FILENAME, INSTALL_WARNING_MESSAGE, disableExtension, enableExtension, installOrUpdateExtension, loadExtension, loadExtensionConfig, loadExtensions, uninstallExtension, hashValue, } from './extension.js';
-import { GEMINI_DIR, ExtensionUninstallEvent, ExtensionDisableEvent, ExtensionEnableEvent, } from '@google/gemini-cli-core';
-import { SettingScope } from './settings.js';
+import { ExtensionUninstallEvent, ExtensionDisableEvent, ExtensionEnableEvent, } from '@google/gemini-cli-core';
+import { loadSettings, SettingScope } from './settings.js';
 import { isWorkspaceTrusted } from './trustedFolders.js';
 import { createExtension } from '../test-utils/createExtension.js';
 import { ExtensionEnablementManager } from './extensions/extensionEnablement.js';
 import { join } from 'node:path';
+import { EXTENSIONS_CONFIG_FILENAME, EXTENSIONS_DIRECTORY_NAME, INSTALL_METADATA_FILENAME, } from './extensions/variables.js';
+import { hashValue, ExtensionManager } from './extension-manager.js';
+import { ExtensionStorage } from './extensions/storage.js';
+import { INSTALL_WARNING_MESSAGE } from './extensions/consent.js';
 const mockGit = {
     clone: vi.fn(),
     getRemotes: vi.fn(),
@@ -81,15 +83,21 @@ vi.mock('child_process', async (importOriginal) => {
         execSync: vi.fn(),
     };
 });
-const EXTENSIONS_DIRECTORY_NAME = path.join(GEMINI_DIR, 'extensions');
 describe('extension tests', () => {
     let tempHomeDir;
     let tempWorkspaceDir;
     let userExtensionsDir;
+    let extensionManager;
+    let mockRequestConsent;
+    let mockPromptForSettings;
     beforeEach(() => {
         tempHomeDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gemini-cli-test-home-'));
         tempWorkspaceDir = fs.mkdtempSync(path.join(tempHomeDir, 'gemini-cli-test-workspace-'));
         userExtensionsDir = path.join(tempHomeDir, EXTENSIONS_DIRECTORY_NAME);
+        mockRequestConsent = vi.fn();
+        mockRequestConsent.mockResolvedValue(true);
+        mockPromptForSettings = vi.fn();
+        mockPromptForSettings.mockResolvedValue('');
         fs.mkdirSync(userExtensionsDir, { recursive: true });
         vi.mocked(os.homedir).mockReturnValue(tempHomeDir);
         vi.mocked(isWorkspaceTrusted).mockReturnValue({
@@ -97,6 +105,12 @@ describe('extension tests', () => {
             source: undefined,
         });
         vi.spyOn(process, 'cwd').mockReturnValue(tempWorkspaceDir);
+        extensionManager = new ExtensionManager({
+            workspaceDir: tempWorkspaceDir,
+            requestConsent: mockRequestConsent,
+            requestSetting: mockPromptForSettings,
+            loadedSettings: loadSettings(tempWorkspaceDir),
+        });
     });
     afterEach(() => {
         fs.rmSync(tempHomeDir, { recursive: true, force: true });
@@ -112,7 +126,7 @@ describe('extension tests', () => {
                 name: 'test-extension',
                 version: '1.0.0',
             });
-            const extensions = loadExtensions(new ExtensionEnablementManager());
+            const extensions = extensionManager.loadExtensions();
             expect(extensions).toHaveLength(1);
             expect(extensions[0].path).toBe(extensionDir);
             expect(extensions[0].name).toBe('test-extension');
@@ -129,7 +143,7 @@ describe('extension tests', () => {
                 name: 'ext2',
                 version: '2.0.0',
             });
-            const extensions = loadExtensions(new ExtensionEnablementManager());
+            const extensions = extensionManager.loadExtensions();
             expect(extensions).toHaveLength(2);
             const ext1 = extensions.find((e) => e.name === 'ext1');
             const ext2 = extensions.find((e) => e.name === 'ext2');
@@ -146,7 +160,7 @@ describe('extension tests', () => {
                 addContextFile: false,
                 contextFileName: 'my-context-file.md',
             });
-            const extensions = loadExtensions(new ExtensionEnablementManager());
+            const extensions = extensionManager.loadExtensions();
             expect(extensions).toHaveLength(1);
             const ext1 = extensions.find((e) => e.name === 'ext1');
             expect(ext1?.contextFiles).toEqual([
@@ -164,9 +178,8 @@ describe('extension tests', () => {
                 name: 'enabled-extension',
                 version: '2.0.0',
             });
-            const manager = new ExtensionEnablementManager();
-            disableExtension('disabled-extension', SettingScope.User, manager, tempWorkspaceDir);
-            const extensions = loadExtensions(manager);
+            extensionManager.disableExtension('disabled-extension', SettingScope.User);
+            const extensions = extensionManager.loadExtensions();
             expect(extensions).toHaveLength(2);
             expect(extensions[0].name).toBe('disabled-extension');
             expect(extensions[0].isActive).toBe(false);
@@ -186,7 +199,7 @@ describe('extension tests', () => {
                     },
                 },
             });
-            const extensions = loadExtensions(new ExtensionEnablementManager());
+            const extensions = extensionManager.loadExtensions();
             expect(extensions).toHaveLength(1);
             const expectedCwd = path.join(userExtensionsDir, 'test-extension', 'server');
             expect(extensions[0].mcpServers?.['test-server'].cwd).toBe(expectedCwd);
@@ -199,12 +212,12 @@ describe('extension tests', () => {
                 contextFileName: 'context.md',
             });
             fs.writeFileSync(path.join(sourceExtDir, 'context.md'), 'linked context');
-            const extensionName = await installOrUpdateExtension({
+            const extensionName = await extensionManager.installOrUpdateExtension({
                 source: sourceExtDir,
                 type: 'link',
-            }, async (_) => true);
+            });
             expect(extensionName).toEqual('my-linked-extension');
-            const extensions = loadExtensions(new ExtensionEnablementManager());
+            const extensions = extensionManager.loadExtensions();
             expect(extensions).toHaveLength(1);
             const linkedExt = extensions[0];
             expect(linkedExt.name).toBe('my-linked-extension');
@@ -243,7 +256,7 @@ describe('extension tests', () => {
                     },
                 };
                 fs.writeFileSync(configPath, JSON.stringify(extensionConfig));
-                const extensions = loadExtensions(new ExtensionEnablementManager());
+                const extensions = extensionManager.loadExtensions();
                 expect(extensions).toHaveLength(1);
                 const extension = extensions[0];
                 expect(extension.name).toBe('test-extension');
@@ -260,6 +273,32 @@ describe('extension tests', () => {
                 delete process.env['TEST_DB_URL'];
             }
         });
+        it('should resolve environment variables from an extension .env file', () => {
+            const extDir = createExtension({
+                extensionsDir: userExtensionsDir,
+                name: 'test-extension',
+                version: '1.0.0',
+                mcpServers: {
+                    'test-server': {
+                        command: 'node',
+                        args: ['server.js'],
+                        env: {
+                            API_KEY: '$MY_API_KEY',
+                            STATIC_VALUE: 'no-substitution',
+                        },
+                    },
+                },
+            });
+            const envFilePath = path.join(extDir, '.env');
+            fs.writeFileSync(envFilePath, 'MY_API_KEY=test-key-from-file\n');
+            const extensions = extensionManager.loadExtensions();
+            expect(extensions).toHaveLength(1);
+            const extension = extensions[0];
+            const serverConfig = extension.mcpServers['test-server'];
+            expect(serverConfig.env).toBeDefined();
+            expect(serverConfig.env['API_KEY']).toBe('test-key-from-file');
+            expect(serverConfig.env['STATIC_VALUE']).toBe('no-substitution');
+        });
         it('should handle missing environment variables gracefully', () => {
             const userExtensionsDir = path.join(tempHomeDir, EXTENSIONS_DIRECTORY_NAME);
             fs.mkdirSync(userExtensionsDir, { recursive: true });
@@ -280,7 +319,7 @@ describe('extension tests', () => {
                 },
             };
             fs.writeFileSync(path.join(extDir, EXTENSIONS_CONFIG_FILENAME), JSON.stringify(extensionConfig));
-            const extensions = loadExtensions(new ExtensionEnablementManager());
+            const extensions = extensionManager.loadExtensions();
             expect(extensions).toHaveLength(1);
             const extension = extensions[0];
             const serverConfig = extension.mcpServers['test-server'];
@@ -303,7 +342,7 @@ describe('extension tests', () => {
             fs.mkdirSync(badExtDir);
             const badConfigPath = path.join(badExtDir, EXTENSIONS_CONFIG_FILENAME);
             fs.writeFileSync(badConfigPath, '{ "name": "bad-ext"'); // Malformed
-            const extensions = loadExtensions(new ExtensionEnablementManager());
+            const extensions = extensionManager.loadExtensions();
             expect(extensions).toHaveLength(1);
             expect(extensions[0].name).toBe('good-ext');
             expect(consoleSpy).toHaveBeenCalledOnce();
@@ -325,7 +364,7 @@ describe('extension tests', () => {
             fs.mkdirSync(badExtDir);
             const badConfigPath = path.join(badExtDir, EXTENSIONS_CONFIG_FILENAME);
             fs.writeFileSync(badConfigPath, JSON.stringify({ version: '1.0.0' }));
-            const extensions = loadExtensions(new ExtensionEnablementManager());
+            const extensions = extensionManager.loadExtensions();
             expect(extensions).toHaveLength(1);
             expect(extensions[0].name).toBe('good-ext');
             expect(consoleSpy).toHaveBeenCalledOnce();
@@ -345,7 +384,7 @@ describe('extension tests', () => {
                     },
                 },
             });
-            const extensions = loadExtensions(new ExtensionEnablementManager());
+            const extensions = extensionManager.loadExtensions();
             expect(extensions).toHaveLength(1);
             expect(extensions[0].mcpServers?.['test-server'].trust).toBeUndefined();
         });
@@ -358,11 +397,7 @@ describe('extension tests', () => {
                 name: 'bad_name',
                 version: '1.0.0',
             });
-            const extension = loadExtension({
-                extensionDir: badExtDir,
-                workspaceDir: tempWorkspaceDir,
-                extensionEnablementManager: new ExtensionEnablementManager(),
-            });
+            const extension = extensionManager.loadExtension(badExtDir);
             expect(extension).toBeNull();
             expect(consoleSpy).toHaveBeenCalledWith(expect.stringContaining('Invalid extension name: "bad_name"'));
             consoleSpy.mockRestore();
@@ -378,15 +413,8 @@ describe('extension tests', () => {
                         source: 'http://somehost.com/foo/bar',
                     },
                 });
-                const extension = loadExtension({
-                    extensionDir,
-                    workspaceDir: tempWorkspaceDir,
-                    extensionEnablementManager: new ExtensionEnablementManager(),
-                });
-                const expectedHash = createHash('sha256')
-                    .update('http://somehost.com/foo/bar')
-                    .digest('hex');
-                expect(extension?.id).toBe(expectedHash);
+                const extension = extensionManager.loadExtension(extensionDir);
+                expect(extension?.id).toBe(hashValue('http://somehost.com/foo/bar'));
             });
             it('should generate id from owner/repo for github http urls', () => {
                 const extensionDir = createExtension({
@@ -398,15 +426,8 @@ describe('extension tests', () => {
                         source: 'http://github.com/foo/bar',
                     },
                 });
-                const extension = loadExtension({
-                    extensionDir,
-                    workspaceDir: tempWorkspaceDir,
-                    extensionEnablementManager: new ExtensionEnablementManager(),
-                });
-                const expectedHash = createHash('sha256')
-                    .update('https://github.com/foo/bar')
-                    .digest('hex');
-                expect(extension?.id).toBe(expectedHash);
+                const extension = extensionManager.loadExtension(extensionDir);
+                expect(extension?.id).toBe(hashValue('https://github.com/foo/bar'));
             });
             it('should generate id from owner/repo for github ssh urls', () => {
                 const extensionDir = createExtension({
@@ -418,15 +439,8 @@ describe('extension tests', () => {
                         source: 'git@github.com:foo/bar',
                     },
                 });
-                const extension = loadExtension({
-                    extensionDir,
-                    workspaceDir: tempWorkspaceDir,
-                    extensionEnablementManager: new ExtensionEnablementManager(),
-                });
-                const expectedHash = createHash('sha256')
-                    .update('https://github.com/foo/bar')
-                    .digest('hex');
-                expect(extension?.id).toBe(expectedHash);
+                const extension = extensionManager.loadExtension(extensionDir);
+                expect(extension?.id).toBe(hashValue('https://github.com/foo/bar'));
             });
             it('should generate id from source for github-release extension', () => {
                 const extensionDir = createExtension({
@@ -438,15 +452,8 @@ describe('extension tests', () => {
                         source: 'https://github.com/foo/bar',
                     },
                 });
-                const extension = loadExtension({
-                    extensionDir,
-                    workspaceDir: tempWorkspaceDir,
-                    extensionEnablementManager: new ExtensionEnablementManager(),
-                });
-                const expectedHash = createHash('sha256')
-                    .update('https://github.com/foo/bar')
-                    .digest('hex');
-                expect(extension?.id).toBe(expectedHash);
+                const extension = extensionManager.loadExtension(extensionDir);
+                expect(extension?.id).toBe(hashValue('https://github.com/foo/bar'));
             });
             it('should generate id from the original source for local extension', () => {
                 const extensionDir = createExtension({
@@ -458,15 +465,8 @@ describe('extension tests', () => {
                         source: '/some/path',
                     },
                 });
-                const extension = loadExtension({
-                    extensionDir,
-                    workspaceDir: tempWorkspaceDir,
-                    extensionEnablementManager: new ExtensionEnablementManager(),
-                });
-                const expectedHash = createHash('sha256')
-                    .update('/some/path')
-                    .digest('hex');
-                expect(extension?.id).toBe(expectedHash);
+                const extension = extensionManager.loadExtension(extensionDir);
+                expect(extension?.id).toBe(hashValue('/some/path'));
             });
             it('should generate id from the original source for linked extensions', async () => {
                 const extDevelopmentDir = path.join(tempHomeDir, 'local_extensions');
@@ -475,19 +475,12 @@ describe('extension tests', () => {
                     name: 'link-ext-name',
                     version: '1.0.0',
                 });
-                const extensionName = await installOrUpdateExtension({
+                const extensionName = await extensionManager.installOrUpdateExtension({
                     type: 'link',
                     source: actualExtensionDir,
-                }, async () => true, tempWorkspaceDir);
-                const extension = loadExtension({
-                    extensionDir: new ExtensionStorage(extensionName).getExtensionDir(),
-                    workspaceDir: tempWorkspaceDir,
-                    extensionEnablementManager: new ExtensionEnablementManager(),
                 });
-                const expectedHash = createHash('sha256')
-                    .update(actualExtensionDir)
-                    .digest('hex');
-                expect(extension?.id).toBe(expectedHash);
+                const extension = extensionManager.loadExtension(new ExtensionStorage(extensionName).getExtensionDir());
+                expect(extension?.id).toBe(hashValue(actualExtensionDir));
             });
             it('should generate id from name for extension with no install metadata', () => {
                 const extensionDir = createExtension({
@@ -495,15 +488,8 @@ describe('extension tests', () => {
                     name: 'no-meta-name',
                     version: '1.0.0',
                 });
-                const extension = loadExtension({
-                    extensionDir,
-                    workspaceDir: tempWorkspaceDir,
-                    extensionEnablementManager: new ExtensionEnablementManager(),
-                });
-                const expectedHash = createHash('sha256')
-                    .update('no-meta-name')
-                    .digest('hex');
-                expect(extension?.id).toBe(expectedHash);
+                const extension = extensionManager.loadExtension(extensionDir);
+                expect(extension?.id).toBe(hashValue('no-meta-name'));
             });
         });
     });
@@ -516,7 +502,10 @@ describe('extension tests', () => {
             });
             const targetExtDir = path.join(userExtensionsDir, 'my-local-extension');
             const metadataPath = path.join(targetExtDir, INSTALL_METADATA_FILENAME);
-            await installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, async (_) => true);
+            await extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'local',
+            });
             expect(fs.existsSync(targetExtDir)).toBe(true);
             expect(fs.existsSync(metadataPath)).toBe(true);
             const metadata = JSON.parse(fs.readFileSync(metadataPath, 'utf-8'));
@@ -532,14 +521,23 @@ describe('extension tests', () => {
                 name: 'my-local-extension',
                 version: '1.0.0',
             });
-            await installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, async (_) => true);
-            await expect(installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, async (_) => true)).rejects.toThrow('Extension "my-local-extension" is already installed. Please uninstall it first.');
+            await extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'local',
+            });
+            await expect(extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'local',
+            })).rejects.toThrow('Extension "my-local-extension" is already installed. Please uninstall it first.');
         });
         it('should throw an error and cleanup if gemini-extension.json is missing', async () => {
             const sourceExtDir = path.join(tempHomeDir, 'bad-extension');
             fs.mkdirSync(sourceExtDir, { recursive: true });
             const configPath = path.join(sourceExtDir, EXTENSIONS_CONFIG_FILENAME);
-            await expect(installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, async (_) => true)).rejects.toThrow(`Configuration file not found at ${configPath}`);
+            await expect(extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'local',
+            })).rejects.toThrow(`Configuration file not found at ${configPath}`);
             const targetExtDir = path.join(userExtensionsDir, 'bad-extension');
             expect(fs.existsSync(targetExtDir)).toBe(false);
         });
@@ -548,7 +546,10 @@ describe('extension tests', () => {
             fs.mkdirSync(sourceExtDir, { recursive: true });
             const configPath = path.join(sourceExtDir, EXTENSIONS_CONFIG_FILENAME);
             fs.writeFileSync(configPath, '{ "name": "bad-json", "version": "1.0.0"'); // Malformed JSON
-            await expect(installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, async (_) => true)).rejects.toThrow(new RegExp(`^Failed to load extension config from ${configPath.replace(/\\/g, '\\\\')}`));
+            await expect(extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'local',
+            })).rejects.toThrow(new RegExp(`^Failed to load extension config from ${configPath.replace(/\\/g, '\\\\')}`));
         });
         it('should throw an error for missing name in gemini-extension.json', async () => {
             const sourceExtDir = createExtension({
@@ -559,7 +560,10 @@ describe('extension tests', () => {
             const configPath = path.join(sourceExtDir, EXTENSIONS_CONFIG_FILENAME);
             // Overwrite with invalid config
             fs.writeFileSync(configPath, JSON.stringify({ version: '1.0.0' }));
-            await expect(installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, async (_) => true)).rejects.toThrow(`Invalid configuration in ${configPath}: missing "name"`);
+            await expect(extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'local',
+            })).rejects.toThrow(`Invalid configuration in ${configPath}: missing "name"`);
         });
         it('should install an extension from a git URL', async () => {
             const gitUrl = 'https://somehost.com/somerepo.git';
@@ -578,7 +582,10 @@ describe('extension tests', () => {
                 failureReason: 'no release data',
                 type: 'github-release',
             });
-            await installOrUpdateExtension({ source: gitUrl, type: 'git' }, async (_) => true);
+            await extensionManager.installOrUpdateExtension({
+                source: gitUrl,
+                type: 'git',
+            });
             expect(fs.existsSync(targetExtDir)).toBe(true);
             expect(fs.existsSync(metadataPath)).toBe(true);
             const metadata = JSON.parse(fs.readFileSync(metadataPath, 'utf-8'));
@@ -596,7 +603,10 @@ describe('extension tests', () => {
             const targetExtDir = path.join(userExtensionsDir, 'my-linked-extension');
             const metadataPath = path.join(targetExtDir, INSTALL_METADATA_FILENAME);
             const configPath = path.join(targetExtDir, EXTENSIONS_CONFIG_FILENAME);
-            await installOrUpdateExtension({ source: sourceExtDir, type: 'link' }, async (_) => true);
+            await extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'link',
+            });
             expect(fs.existsSync(targetExtDir)).toBe(true);
             expect(fs.existsSync(metadataPath)).toBe(true);
             expect(fs.existsSync(configPath)).toBe(false);
@@ -616,13 +626,16 @@ describe('extension tests', () => {
                     version: '1.1.0',
                 });
                 if (isUpdate) {
-                    await installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, async (_) => true);
+                    await extensionManager.installOrUpdateExtension({
+                        source: sourceExtDir,
+                        type: 'local',
+                    });
                 }
                 // Clears out any calls to mocks from the above function calls.
                 vi.clearAllMocks();
             });
             it(`should log an ${isUpdate ? 'update' : 'install'} event to clearcut on success`, async () => {
-                await installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, async (_) => true, undefined, isUpdate
+                await extensionManager.installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, isUpdate
                     ? {
                         name: 'my-local-extension',
                         version: '1.0.0',
@@ -640,7 +653,7 @@ describe('extension tests', () => {
             it(`should ${isUpdate ? 'not ' : ''} alter the extension enablement configuration`, async () => {
                 const enablementManager = new ExtensionEnablementManager();
                 enablementManager.enable('my-local-extension', true, '/some/scope');
-                await installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, async (_) => true, undefined, isUpdate
+                await extensionManager.installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, isUpdate
                     ? {
                         name: 'my-local-extension',
                         version: '1.0.0',
@@ -673,9 +686,10 @@ describe('extension tests', () => {
                     },
                 },
             });
-            const mockRequestConsent = vi.fn();
-            mockRequestConsent.mockResolvedValue(true);
-            await expect(installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, mockRequestConsent)).resolves.toBe('my-local-extension');
+            await expect(extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'local',
+            })).resolves.toBe('my-local-extension');
             expect(mockRequestConsent).toHaveBeenCalledWith(`Installing extension "my-local-extension".
 ${INSTALL_WARNING_MESSAGE}
 This extension will run the following MCP servers:
@@ -694,7 +708,10 @@ This extension will run the following MCP servers:
                     },
                 },
             });
-            await expect(installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, async () => true)).resolves.toBe('my-local-extension');
+            await expect(extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'local',
+            })).resolves.toBe('my-local-extension');
         });
         it('should cancel installation if user declines prompt for local extension with mcp servers', async () => {
             const sourceExtDir = createExtension({
@@ -708,7 +725,11 @@ This extension will run the following MCP servers:
                     },
                 },
             });
-            await expect(installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, async () => false)).rejects.toThrow('Installation cancelled for "my-local-extension".');
+            mockRequestConsent.mockResolvedValue(false);
+            await expect(extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'local',
+            })).rejects.toThrow('Installation cancelled for "my-local-extension".');
         });
         it('should save the autoUpdate flag to the install metadata', async () => {
             const sourceExtDir = createExtension({
@@ -718,11 +739,11 @@ This extension will run the following MCP servers:
             });
             const targetExtDir = path.join(userExtensionsDir, 'my-local-extension');
             const metadataPath = path.join(targetExtDir, INSTALL_METADATA_FILENAME);
-            await installOrUpdateExtension({
+            await extensionManager.installOrUpdateExtension({
                 source: sourceExtDir,
                 type: 'local',
                 autoUpdate: true,
-            }, async (_) => true);
+            });
             expect(fs.existsSync(targetExtDir)).toBe(true);
             expect(fs.existsSync(metadataPath)).toBe(true);
             const metadata = JSON.parse(fs.readFileSync(metadataPath, 'utf-8'));
@@ -745,18 +766,151 @@ This extension will run the following MCP servers:
                     },
                 },
             });
-            const mockRequestConsent = vi.fn();
-            // Install it and force consent first.
-            await installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, async () => true);
+            // Install it with hard coded consent first.
+            await extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'local',
+            });
+            expect(mockRequestConsent).toHaveBeenCalledOnce();
             // Now update it without changing anything.
-            await expect(installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, mockRequestConsent, process.cwd(), 
+            await expect(extensionManager.installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, 
             // Provide its own existing config as the previous config.
-            await loadExtensionConfig({
-                extensionDir: sourceExtDir,
-                workspaceDir: process.cwd(),
-                extensionEnablementManager: new ExtensionEnablementManager(),
-            }))).resolves.toBe('my-local-extension');
-            expect(mockRequestConsent).not.toHaveBeenCalled();
+            await extensionManager.loadExtensionConfig(sourceExtDir))).resolves.toBe('my-local-extension');
+            // Still only called once
+            expect(mockRequestConsent).toHaveBeenCalledOnce();
+        });
+        it('should prompt for settings if promptForSettings', async () => {
+            const sourceExtDir = createExtension({
+                extensionsDir: tempHomeDir,
+                name: 'my-local-extension',
+                version: '1.0.0',
+                settings: [
+                    {
+                        name: 'API Key',
+                        description: 'Your API key for the service.',
+                        envVar: 'MY_API_KEY',
+                    },
+                ],
+            });
+            await extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'local',
+            });
+            expect(mockPromptForSettings).toHaveBeenCalled();
+        });
+        it('should not prompt for settings if promptForSettings is false', async () => {
+            const sourceExtDir = createExtension({
+                extensionsDir: tempHomeDir,
+                name: 'my-local-extension',
+                version: '1.0.0',
+                settings: [
+                    {
+                        name: 'API Key',
+                        description: 'Your API key for the service.',
+                        envVar: 'MY_API_KEY',
+                    },
+                ],
+            });
+            extensionManager = new ExtensionManager({
+                workspaceDir: tempWorkspaceDir,
+                requestConsent: mockRequestConsent,
+                requestSetting: null,
+                loadedSettings: loadSettings(tempWorkspaceDir),
+            });
+            await extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'local',
+            });
+        });
+        it('should only prompt for new settings on update, and preserve old settings', async () => {
+            // 1. Create and install the "old" version of the extension.
+            const oldSourceExtDir = createExtension({
+                extensionsDir: tempHomeDir, // Create it in a temp location first
+                name: 'my-local-extension',
+                version: '1.0.0',
+                settings: [
+                    {
+                        name: 'API Key',
+                        description: 'Your API key for the service.',
+                        envVar: 'MY_API_KEY',
+                    },
+                ],
+            });
+            mockPromptForSettings.mockResolvedValueOnce('old-api-key');
+            // Install it so it exists in the userExtensionsDir
+            await extensionManager.installOrUpdateExtension({
+                source: oldSourceExtDir,
+                type: 'local',
+            });
+            const envPath = new ExtensionStorage('my-local-extension').getEnvFilePath();
+            expect(fs.existsSync(envPath)).toBe(true);
+            let envContent = fs.readFileSync(envPath, 'utf-8');
+            expect(envContent).toContain('MY_API_KEY=old-api-key');
+            expect(mockPromptForSettings).toHaveBeenCalledTimes(1);
+            // 2. Create the "new" version of the extension in a new source directory.
+            const newSourceExtDir = createExtension({
+                extensionsDir: path.join(tempHomeDir, 'new-source'), // Another temp location
+                name: 'my-local-extension', // Same name
+                version: '1.1.0', // New version
+                settings: [
+                    {
+                        name: 'API Key',
+                        description: 'Your API key for the service.',
+                        envVar: 'MY_API_KEY',
+                    },
+                    {
+                        name: 'New Setting',
+                        description: 'A new setting.',
+                        envVar: 'NEW_SETTING',
+                    },
+                ],
+            });
+            const previousExtensionConfig = extensionManager.loadExtensionConfig(path.join(userExtensionsDir, 'my-local-extension'));
+            mockPromptForSettings.mockResolvedValueOnce('new-setting-value');
+            // 3. Call installOrUpdateExtension to perform the update.
+            await extensionManager.installOrUpdateExtension({ source: newSourceExtDir, type: 'local' }, previousExtensionConfig);
+            expect(mockPromptForSettings).toHaveBeenCalledTimes(2);
+            expect(mockPromptForSettings).toHaveBeenCalledWith(expect.objectContaining({ name: 'New Setting' }));
+            expect(fs.existsSync(envPath)).toBe(true);
+            envContent = fs.readFileSync(envPath, 'utf-8');
+            expect(envContent).toContain('MY_API_KEY=old-api-key');
+            expect(envContent).toContain('NEW_SETTING=new-setting-value');
+        });
+        it('should fail auto-update if settings have changed', async () => {
+            // 1. Install initial version with autoUpdate: true
+            const oldSourceExtDir = createExtension({
+                extensionsDir: tempHomeDir,
+                name: 'my-auto-update-ext',
+                version: '1.0.0',
+                settings: [
+                    {
+                        name: 'OLD_SETTING',
+                        envVar: 'OLD_SETTING',
+                        description: 'An old setting',
+                    },
+                ],
+            });
+            await extensionManager.installOrUpdateExtension({
+                source: oldSourceExtDir,
+                type: 'local',
+                autoUpdate: true,
+            });
+            // 2. Create new version with different settings
+            const newSourceExtDir = createExtension({
+                extensionsDir: tempHomeDir,
+                name: 'my-auto-update-ext',
+                version: '1.1.0',
+                settings: [
+                    {
+                        name: 'NEW_SETTING',
+                        envVar: 'NEW_SETTING',
+                        description: 'A new setting',
+                    },
+                ],
+            });
+            const previousExtensionConfig = extensionManager.loadExtensionConfig(path.join(userExtensionsDir, 'my-auto-update-ext'));
+            // 3. Attempt to update and assert it fails
+            await expect(extensionManager.installOrUpdateExtension({ source: newSourceExtDir, type: 'local', autoUpdate: true }, previousExtensionConfig)).rejects.toThrow('Extension "my-auto-update-ext" has settings changes and cannot be auto-updated. Please update manually.');
         });
         it('should throw an error for invalid extension names', async () => {
             const sourceExtDir = createExtension({
@@ -764,7 +918,10 @@ This extension will run the following MCP servers:
                 name: 'bad_name',
                 version: '1.0.0',
             });
-            await expect(installOrUpdateExtension({ source: sourceExtDir, type: 'local' }, async (_) => true)).rejects.toThrow('Invalid extension name: "bad_name"');
+            await expect(extensionManager.installOrUpdateExtension({
+                source: sourceExtDir,
+                type: 'local',
+            })).rejects.toThrow('Invalid extension name: "bad_name"');
         });
         describe('installing from github', () => {
             const gitUrl = 'https://github.com/google/gemini-test-extension.git';
@@ -797,7 +954,10 @@ This extension will run the following MCP servers:
                     version: '1.0.0',
                 });
                 vi.spyOn(ExtensionStorage, 'createTmpDir').mockResolvedValue(join(tempDir, extensionName));
-                await installOrUpdateExtension({ source: gitUrl, type: 'github-release' }, async () => true);
+                await extensionManager.installOrUpdateExtension({
+                    source: gitUrl,
+                    type: 'github-release',
+                });
                 expect(fs.existsSync(targetExtDir)).toBe(true);
                 const metadataPath = path.join(targetExtDir, INSTALL_METADATA_FILENAME);
                 expect(fs.existsSync(metadataPath)).toBe(true);
@@ -815,13 +975,11 @@ This extension will run the following MCP servers:
                     errorMessage: 'download failed',
                     type: 'github-release',
                 });
-                const requestConsent = vi.fn().mockResolvedValue(true);
-                await installOrUpdateExtension({ source: gitUrl, type: 'github-release' }, // Use github-release to force consent
-                requestConsent);
+                await extensionManager.installOrUpdateExtension({ source: gitUrl, type: 'github-release' });
                 // It gets called once to ask for a git clone, and once to consent to
                 // the actual extension features.
-                expect(requestConsent).toHaveBeenCalledTimes(2);
-                expect(requestConsent).toHaveBeenCalledWith(expect.stringContaining('Would you like to attempt to install via "git clone" instead?'));
+                expect(mockRequestConsent).toHaveBeenCalledTimes(2);
+                expect(mockRequestConsent).toHaveBeenCalledWith(expect.stringContaining('Would you like to attempt to install via "git clone" instead?'));
                 expect(mockGit.clone).toHaveBeenCalled();
                 const metadataPath = path.join(userExtensionsDir, extensionName, INSTALL_METADATA_FILENAME);
                 const metadata = JSON.parse(fs.readFileSync(metadataPath, 'utf-8'));
@@ -833,9 +991,12 @@ This extension will run the following MCP servers:
                     errorMessage: 'download failed',
                     type: 'github-release',
                 });
-                const requestConsent = vi.fn().mockResolvedValue(false);
-                await expect(installOrUpdateExtension({ source: gitUrl, type: 'github-release' }, requestConsent)).rejects.toThrow(`Failed to install extension ${gitUrl}: download failed`);
-                expect(requestConsent).toHaveBeenCalledExactlyOnceWith(expect.stringContaining('Would you like to attempt to install via "git clone" instead?'));
+                mockRequestConsent.mockResolvedValue(false);
+                await expect(extensionManager.installOrUpdateExtension({
+                    source: gitUrl,
+                    type: 'github-release',
+                })).rejects.toThrow(`Failed to install extension ${gitUrl}: download failed`);
+                expect(mockRequestConsent).toHaveBeenCalledExactlyOnceWith(expect.stringContaining('Would you like to attempt to install via "git clone" instead?'));
                 expect(mockGit.clone).not.toHaveBeenCalled();
             });
             it('should fallback to git clone without consent if no release data is found on first install', async () => {
@@ -844,11 +1005,13 @@ This extension will run the following MCP servers:
                     failureReason: 'no release data',
                     type: 'github-release',
                 });
-                const requestConsent = vi.fn().mockResolvedValue(true);
-                await installOrUpdateExtension({ source: gitUrl, type: 'git' }, requestConsent);
+                await extensionManager.installOrUpdateExtension({
+                    source: gitUrl,
+                    type: 'git',
+                });
                 // We should not see the request to use git clone, this is a repo that
                 // has no github releases so it is the only install method.
-                expect(requestConsent).toHaveBeenCalledExactlyOnceWith(expect.stringContaining('Installing extension "gemini-test-extension"'));
+                expect(mockRequestConsent).toHaveBeenCalledExactlyOnceWith(expect.stringContaining('Installing extension "gemini-test-extension"'));
                 expect(mockGit.clone).toHaveBeenCalled();
                 const metadataPath = path.join(userExtensionsDir, extensionName, INSTALL_METADATA_FILENAME);
                 const metadata = JSON.parse(fs.readFileSync(metadataPath, 'utf-8'));
@@ -861,10 +1024,8 @@ This extension will run the following MCP servers:
                     errorMessage: 'No release data found',
                     type: 'github-release',
                 });
-                const requestConsent = vi.fn().mockResolvedValue(true);
-                await installOrUpdateExtension({ source: gitUrl, type: 'github-release' }, // Note the type
-                requestConsent);
-                expect(requestConsent).toHaveBeenCalledWith(expect.stringContaining('Would you like to attempt to install via "git clone" instead?'));
+                await extensionManager.installOrUpdateExtension({ source: gitUrl, type: 'github-release' });
+                expect(mockRequestConsent).toHaveBeenCalledWith(expect.stringContaining('Would you like to attempt to install via "git clone" instead?'));
                 expect(mockGit.clone).toHaveBeenCalled();
             });
         });
@@ -876,7 +1037,7 @@ This extension will run the following MCP servers:
                 name: 'my-local-extension',
                 version: '1.0.0',
             });
-            await uninstallExtension('my-local-extension', false);
+            await extensionManager.uninstallExtension('my-local-extension', false);
             expect(fs.existsSync(sourceExtDir)).toBe(false);
         });
         it('should uninstall an extension by name and retain existing extensions', async () => {
@@ -890,13 +1051,13 @@ This extension will run the following MCP servers:
                 name: 'other-extension',
                 version: '1.0.0',
             });
-            await uninstallExtension('my-local-extension', false);
+            await extensionManager.uninstallExtension('my-local-extension', false);
             expect(fs.existsSync(sourceExtDir)).toBe(false);
-            expect(loadExtensions(new ExtensionEnablementManager())).toHaveLength(1);
+            expect(extensionManager.loadExtensions()).toHaveLength(1);
             expect(fs.existsSync(otherExtDir)).toBe(true);
         });
         it('should throw an error if the extension does not exist', async () => {
-            await expect(uninstallExtension('nonexistent-extension', false)).rejects.toThrow('Extension not found.');
+            await expect(extensionManager.uninstallExtension('nonexistent-extension', false)).rejects.toThrow('Extension not found.');
         });
         describe.each([true, false])('with isUpdate: %s', (isUpdate) => {
             it(`should ${isUpdate ? 'not ' : ''}log uninstall event`, async () => {
@@ -909,7 +1070,7 @@ This extension will run the following MCP servers:
                         type: 'local',
                     },
                 });
-                await uninstallExtension('my-local-extension', isUpdate);
+                await extensionManager.uninstallExtension('my-local-extension', isUpdate);
                 if (isUpdate) {
                     expect(mockLogExtensionUninstall).not.toHaveBeenCalled();
                     expect(ExtensionUninstallEvent).not.toHaveBeenCalled();
@@ -927,7 +1088,7 @@ This extension will run the following MCP servers:
                 });
                 const enablementManager = new ExtensionEnablementManager();
                 enablementManager.enable('test-extension', true, '/some/scope');
-                await uninstallExtension('test-extension', isUpdate);
+                await extensionManager.uninstallExtension('test-extension', isUpdate);
                 const config = enablementManager.readConfig()['test-extension'];
                 if (isUpdate) {
                     expect(config).not.toBeUndefined();
@@ -949,7 +1110,7 @@ This extension will run the following MCP servers:
                     type: 'git',
                 },
             });
-            await uninstallExtension(gitUrl, false);
+            await extensionManager.uninstallExtension(gitUrl, false);
             expect(fs.existsSync(sourceExtDir)).toBe(false);
             expect(mockLogExtensionUninstall).toHaveBeenCalled();
             expect(ExtensionUninstallEvent).toHaveBeenCalledWith(hashValue('gemini-sql-extension'), hashValue('https://github.com/google/gemini-sql-extension'), 'success');
@@ -961,7 +1122,7 @@ This extension will run the following MCP servers:
                 version: '1.0.0',
                 // No installMetadata provided
             });
-            await expect(uninstallExtension('https://github.com/google/no-metadata-extension', false)).rejects.toThrow('Extension not found.');
+            await expect(extensionManager.uninstallExtension('https://github.com/google/no-metadata-extension', false)).rejects.toThrow('Extension not found.');
         });
     });
     describe('disableExtension', () => {
@@ -971,7 +1132,7 @@ This extension will run the following MCP servers:
                 name: 'my-extension',
                 version: '1.0.0',
             });
-            disableExtension('my-extension', SettingScope.User, new ExtensionEnablementManager());
+            extensionManager.disableExtension('my-extension', SettingScope.User);
             expect(isEnabled({
                 name: 'my-extension',
                 enabledForPath: tempWorkspaceDir,
@@ -983,7 +1144,7 @@ This extension will run the following MCP servers:
                 name: 'my-extension',
                 version: '1.0.0',
             });
-            disableExtension('my-extension', SettingScope.Workspace, new ExtensionEnablementManager(), tempWorkspaceDir);
+            extensionManager.disableExtension('my-extension', SettingScope.Workspace);
             expect(isEnabled({
                 name: 'my-extension',
                 enabledForPath: tempHomeDir,
@@ -999,15 +1160,15 @@ This extension will run the following MCP servers:
                 name: 'my-extension',
                 version: '1.0.0',
             });
-            disableExtension('my-extension', SettingScope.User, new ExtensionEnablementManager());
-            disableExtension('my-extension', SettingScope.User, new ExtensionEnablementManager());
+            extensionManager.disableExtension('my-extension', SettingScope.User);
+            extensionManager.disableExtension('my-extension', SettingScope.User);
             expect(isEnabled({
                 name: 'my-extension',
                 enabledForPath: tempWorkspaceDir,
             })).toBe(false);
         });
         it('should throw an error if you request system scope', () => {
-            expect(() => disableExtension('my-extension', SettingScope.System, new ExtensionEnablementManager())).toThrow('System and SystemDefaults scopes are not supported.');
+            expect(() => extensionManager.disableExtension('my-extension', SettingScope.System)).toThrow('System and SystemDefaults scopes are not supported.');
         });
         it('should log a disable event', () => {
             createExtension({
@@ -1019,7 +1180,7 @@ This extension will run the following MCP servers:
                     type: 'local',
                 },
             });
-            disableExtension('ext1', SettingScope.Workspace, new ExtensionEnablementManager());
+            extensionManager.disableExtension('ext1', SettingScope.Workspace);
             expect(mockLogExtensionDisable).toHaveBeenCalled();
             expect(ExtensionDisableEvent).toHaveBeenCalledWith(hashValue('ext1'), hashValue(userExtensionsDir), SettingScope.Workspace);
         });
@@ -1029,8 +1190,7 @@ This extension will run the following MCP servers:
             vi.restoreAllMocks();
         });
         const getActiveExtensions = () => {
-            const manager = new ExtensionEnablementManager();
-            const extensions = loadExtensions(manager);
+            const extensions = extensionManager.loadExtensions();
             return extensions.filter((e) => e.isActive);
         };
         it('should enable an extension at the user scope', () => {
@@ -1039,11 +1199,10 @@ This extension will run the following MCP servers:
                 name: 'ext1',
                 version: '1.0.0',
             });
-            const extensionEnablementManager = new ExtensionEnablementManager();
-            disableExtension('ext1', SettingScope.User, extensionEnablementManager);
+            extensionManager.disableExtension('ext1', SettingScope.User);
             let activeExtensions = getActiveExtensions();
             expect(activeExtensions).toHaveLength(0);
-            enableExtension('ext1', SettingScope.User, extensionEnablementManager);
+            extensionManager.enableExtension('ext1', SettingScope.User);
             activeExtensions = getActiveExtensions();
             expect(activeExtensions).toHaveLength(1);
             expect(activeExtensions[0].name).toBe('ext1');
@@ -1054,11 +1213,10 @@ This extension will run the following MCP servers:
                 name: 'ext1',
                 version: '1.0.0',
             });
-            const extensionEnablementManager = new ExtensionEnablementManager();
-            disableExtension('ext1', SettingScope.Workspace, extensionEnablementManager);
+            extensionManager.disableExtension('ext1', SettingScope.Workspace);
             let activeExtensions = getActiveExtensions();
             expect(activeExtensions).toHaveLength(0);
-            enableExtension('ext1', SettingScope.Workspace, extensionEnablementManager);
+            extensionManager.enableExtension('ext1', SettingScope.Workspace);
             activeExtensions = getActiveExtensions();
             expect(activeExtensions).toHaveLength(1);
             expect(activeExtensions[0].name).toBe('ext1');
@@ -1073,9 +1231,8 @@ This extension will run the following MCP servers:
                     type: 'local',
                 },
             });
-            const extensionEnablementManager = new ExtensionEnablementManager();
-            disableExtension('ext1', SettingScope.Workspace, extensionEnablementManager);
-            enableExtension('ext1', SettingScope.Workspace, extensionEnablementManager);
+            extensionManager.disableExtension('ext1', SettingScope.Workspace);
+            extensionManager.enableExtension('ext1', SettingScope.Workspace);
             expect(mockLogExtensionEnable).toHaveBeenCalled();
             expect(ExtensionEnableEvent).toHaveBeenCalledWith(hashValue('ext1'), hashValue(userExtensionsDir), SettingScope.Workspace);
         });