@gnsx/three 0.186.5 → 0.186.7

package/src/renderers/common/RenderPipeline.js

@@ -4,6 +4,9 @@ import { vec4, renderOutput, context } from '../../nodes/TSL.js';
 import { NoToneMapping } from '../../constants.js';
 import QuadMesh from '../../renderers/common/QuadMesh.js';
 import { warnOnce } from '../../utils.js';
+// WITH_GENESYS
+import { debugViewAccumulates, debugViewSkipsToneMapping } from '../../nodes/display/ComplexityDebug.js';
+// !WITH_GENESYS
 
 /**
  * This module is responsible to manage the rendering pipeline setups in apps.
@@ -139,7 +142,12 @@ class RenderPipeline {
 		const outputColorSpace = renderer.outputColorSpace;
 
 		renderer.toneMapping = NoToneMapping;
-		renderer.outputColorSpace = ColorManagement.workingColorSpace;
+
+		// WITH_GENESYS
+		// Accumulating views colorize in the renderer's output pass, which must still encode the color space.
+		if ( debugViewAccumulates( renderer.debug.view ) !== true ) renderer.outputColorSpace = ColorManagement.workingColorSpace;
+		// !WITH_GENESYS
+		// renderer.outputColorSpace = ColorManagement.workingColorSpace;
 
 		//
 
@@ -215,19 +223,40 @@ class RenderPipeline {
 	 */
 	_update() {
 
-		if ( this._toneMapping !== this.renderer.toneMapping ) {
+		// WITH_GENESYS
+		// Debug views drawn without tone mapping must match the direct path. An accumulating
+		// view copies the raw ratio here, and the renderer's output pass colorizes it.
+		const view = this.renderer.debug.view;
+		const toneMapping = debugViewSkipsToneMapping( view ) ? NoToneMapping : this.renderer.toneMapping;
+		const outputColorSpace = debugViewAccumulates( view ) ? ColorManagement.workingColorSpace : this.renderer.outputColorSpace;
+
+		if ( this._toneMapping !== toneMapping ) {
 
-			this._toneMapping = this.renderer.toneMapping;
+			this._toneMapping = toneMapping;
 			this.needsUpdate = true;
 
 		}
 
-		if ( this._outputColorSpace !== this.renderer.outputColorSpace ) {
+		if ( this._outputColorSpace !== outputColorSpace ) {
 
-			this._outputColorSpace = this.renderer.outputColorSpace;
+			this._outputColorSpace = outputColorSpace;
 			this.needsUpdate = true;
 
 		}
+		// !WITH_GENESYS
+		// if ( this._toneMapping !== this.renderer.toneMapping ) {
+		//
+		// 	this._toneMapping = this.renderer.toneMapping;
+		// 	this.needsUpdate = true;
+		//
+		// }
+		//
+		// if ( this._outputColorSpace !== this.renderer.outputColorSpace ) {
+		//
+		// 	this._outputColorSpace = this.renderer.outputColorSpace;
+		// 	this.needsUpdate = true;
+		//
+		// }
 
 		if ( this.needsUpdate === true ) {
 

package/src/renderers/common/Renderer.js

@@ -30,15 +30,16 @@ import { Matrix4 } from '../../math/Matrix4.js';
 import { Vector2 } from '../../math/Vector2.js';
 import { Vector4 } from '../../math/Vector4.js';
 import { RenderTarget } from '../../core/RenderTarget.js';
-import { DoubleSide, BackSide, FrontSide, SRGBColorSpace, NoToneMapping, LinearFilter, HalfFloatType, RGBAFormat, PCFShadowMap, PCFSoftShadowMap, VSMShadowMap, RenderObjectRefreshType } from '../../constants.js';
+import { DoubleSide, BackSide, FrontSide, EqualDepth, SRGBColorSpace, NoToneMapping, LinearFilter, HalfFloatType, RGBAFormat, PCFShadowMap, PCFSoftShadowMap, VSMShadowMap, RenderObjectRefreshType } from '../../constants.js';
 
 import { float, vec3, vec4, Fn } from '../../nodes/tsl/TSLCore.js';
 // WITH_GENESYS
 import { detachRendererReference } from '../../nodes/accessors/RendererReferenceNode.js';
 import { toneMappingExposure } from '../../nodes/display/ToneMappingNode.js';
 import { ProfilerService } from '../../profiler/ProfilerService.js';
-import { DEBUG_VIEW_LIGHTING_COMPLEXITY, DEBUG_VIEW_NONE, DEBUG_VIEW_QUAD_OVERDRAW, DEBUG_VIEW_SHADER_COMPLEXITY, DEBUG_VIEW_SHADER_COMPLEXITY_AND_QUADS, DEFAULT_QUAD_OVERDRAW_BUDGET, DEFAULT_SHADER_COMPLEXITY_BUDGET, debugViewAccumulates } from '../../nodes/display/ComplexityDebug.js';
-import { DEBUG_VIEW_BUFFER, DEFAULT_BUFFER } from '../../nodes/display/BufferDebug.js';
+import { DEBUG_VIEW_NONE, DEFAULT_QUAD_OVERDRAW_BUDGET, DEFAULT_SHADER_COMPLEXITY_BUDGET, debugViewAccumulates, debugViewSkipsToneMapping } from '../../nodes/display/ComplexityDebug.js';
+import { DEBUG_VIEW_DOUBLE_SIDE, meshCanHideOwnBack } from '../../nodes/display/DoubleSideDebug.js';
+import { DEFAULT_BUFFER } from '../../nodes/display/BufferDebug.js';
 // !WITH_GENESYS
 import { reference } from '../../nodes/accessors/ReferenceNode.js';
 import { highpModelNormalViewMatrix, highpModelViewMatrix } from '../../nodes/accessors/ModelNode.js';
@@ -745,7 +746,7 @@ class Renderer {
 		 * @property {?Function} onNodeBuilderCreated - A callback function that is executed after a node builder has been created and before it is built.
 		 * @property {?Function} onShaderError - A callback function that is executed when a shader error happens. Only supported with WebGL 2 right now.
 		 * @property {Function} getShaderAsync - Allows the get the raw shader code for the given scene, camera and 3D object.
-		 * @property {string} view - Debug view. `shaderComplexity`, `lightingComplexity`, `quadOverdraw`, and `shaderComplexityAndQuads` replace the shaded color with a heatmap. `shaderComplexityAndQuads` multiplies the shader cost by the overdraw count. `bufferVisualization` shows one material channel. `lightingOnly` and `detailLighting` light a flat gray surface. `drawCall` lights each submitted draw with its own diffuse color.
+		 * @property {string} view - Debug view. `shaderComplexity`, `lightingComplexity`, `overdraw`, and `shaderComplexityAndOverdraw` replace the shaded color with a heatmap. `shaderComplexityAndOverdraw` multiplies the shader cost by the overdraw count. `bufferVisualization` shows one material channel. `lightingOnly` and `detailLighting` light a flat gray surface. `drawCall` lights each submitted draw with its own diffuse color. `frontBackFace` draws both windings and tints the side facing the camera. `shadowCaster` lights a mesh green when it casts shadows and gray when it does not. `doubleSide` lights a single-sided surface gray, a visible double-sided back face blue, and a hidden double-sided back face red.
 		 * @property {string} buffer - Channel drawn by `bufferVisualization`: `baseColor`, `worldNormal`, `roughness`, `metallic`, `ambientOcclusion`, or `emissive`.
 		 * @property {number} shaderComplexityBudget - Proxy budget that fills the shader-complexity ramp.
 		 * @property {number} quadOverdrawBudget - Overlapping fragments that fill the quad-overdraw ramp.
@@ -768,6 +769,8 @@ class Renderer {
 			buffer: DEFAULT_BUFFER,
 			shaderComplexityBudget: DEFAULT_SHADER_COMPLEXITY_BUDGET,
 			quadOverdrawBudget: DEFAULT_QUAD_OVERDRAW_BUDGET,
+			doubleSideHidden: false,
+			doubleSideBack: false,
 			// !WITH_GENESYS
 			getShaderAsync: async ( scene, camera, object ) => {
 
@@ -1988,6 +1991,10 @@ class Renderer {
 		if ( this.opaque === true && opaqueObjects.length > 0 ) this._renderObjects( opaqueObjects, camera, sceneRef, lightsNode );
 		if ( this.transparent === true && transparentObjects.length > 0 ) this._renderTransparents( transparentObjects, transparentDoublePassObjects, camera, sceneRef, lightsNode );
 
+		// WITH_GENESYS
+		this._renderDoubleSideHidden( opaqueObjects, transparentObjects, camera, sceneRef, lightsNode );
+		// !WITH_GENESYS
+
 		// finish render pass
 
 		this.backend.finishRender( renderContext );
@@ -2705,7 +2712,8 @@ class Renderer {
 
 		// WITH_GENESYS
 		// Accumulating views write a scalar into an intermediate target, then the output pass colorizes it.
-		return useToneMapping || useColorSpace || debugViewAccumulates( this.debug.view );
+		// Only screen output needs one. An off-screen target, such as a scene pass, already is the target.
+		return useToneMapping || useColorSpace || ( debugViewAccumulates( this.debug.view ) && this.isOutputTarget );
 		// !WITH_GENESYS
 		// return useToneMapping || useColorSpace;
 
@@ -2759,9 +2767,7 @@ class Renderer {
 	get currentToneMapping() {
 
 		// WITH_GENESYS
-		const view = this.debug.view;
-
-		if ( view === DEBUG_VIEW_SHADER_COMPLEXITY || view === DEBUG_VIEW_SHADER_COMPLEXITY_AND_QUADS || view === DEBUG_VIEW_LIGHTING_COMPLEXITY || view === DEBUG_VIEW_QUAD_OVERDRAW || view === DEBUG_VIEW_BUFFER ) {
+		if ( debugViewSkipsToneMapping( this.debug.view ) ) {
 
 			return NoToneMapping;
 
@@ -3559,6 +3565,82 @@ class Renderer {
 
 	}
 
+	// WITH_GENESYS
+	/**
+	 * Paints a double-sided mesh red where its own front face is the nearest surface and the
+	 * mesh has faces pointing the other way. A different mesh in front keeps its own color.
+	 * A flat card has no opposing faces, so it stays gray or blue. A shadow pass is left alone.
+	 *
+	 * @private
+	 * @param {Array<Object>} opaqueObjects - The opaque render list.
+	 * @param {Array<Object>} transparentObjects - The transparent render list.
+	 * @param {Camera} camera - The camera.
+	 * @param {Scene} scene - The scene.
+	 * @param {LightsNode} lightsNode - The current lights node.
+	 */
+	_renderDoubleSideHidden( opaqueObjects, transparentObjects, camera, scene, lightsNode ) {
+
+		if ( this.debug.view !== DEBUG_VIEW_DOUBLE_SIDE ) return;
+
+		if ( scene.overrideMaterial !== null && scene.overrideMaterial.isShadowPassMaterial === true ) return;
+
+		const list = [];
+		const saved = new Map();
+
+		const collect = ( objects ) => {
+
+			for ( let i = 0, l = objects.length; i < l; i ++ ) {
+
+				const entry = objects[ i ];
+				const material = entry.material;
+				const geometry = entry.object.geometry;
+
+				if ( entry.object.isMesh !== true || material.side !== DoubleSide || material.isShadowPassMaterial === true ) continue;
+
+				if ( geometry === undefined || meshCanHideOwnBack( geometry ) !== true ) continue;
+
+				list.push( entry );
+
+				if ( saved.has( material ) ) continue;
+
+				saved.set( material, {
+					side: material.side,
+					depthFunc: material.depthFunc,
+					depthWrite: material.depthWrite
+				} );
+
+			}
+
+		};
+
+		collect( opaqueObjects );
+		collect( transparentObjects );
+
+		if ( list.length === 0 ) return;
+
+		for ( const material of saved.keys() ) {
+
+			material.side = FrontSide;
+			material.depthFunc = EqualDepth;
+			material.depthWrite = false;
+
+		}
+
+		this.debug.doubleSideHidden = true;
+		this._renderObjects( list, camera, scene, lightsNode, 'doubleSideHidden' );
+		this.debug.doubleSideHidden = false;
+
+		for ( const [ material, state ] of saved ) {
+
+			material.side = state.side;
+			material.depthFunc = state.depthFunc;
+			material.depthWrite = state.depthWrite;
+
+		}
+
+	}
+	// !WITH_GENESYS
+
 	/**
 	 * Renders the transparent objects from the given render lists.
 	 *

package/src/renderers/common/nodes/NodeManager.js

@@ -10,7 +10,7 @@ import { builtin } from '../../../nodes/accessors/BuiltinNode.js';
 import { CubeUVReflectionMapping, EquirectangularReflectionMapping, EquirectangularRefractionMapping, NoToneMapping } from '../../../constants.js';
 // WITH_GENESYS
 import { vec4 } from '../../../nodes/tsl/TSLCore.js';
-import { colorizeQuadOverdraw, colorizeShaderComplexity, DEBUG_VIEW_QUAD_OVERDRAW, DEBUG_VIEW_SHADER_COMPLEXITY, DEBUG_VIEW_SHADER_COMPLEXITY_AND_QUADS, SHADER_COMPLEXITY_QUAD_COUNT_SCALE } from '../../../nodes/display/ComplexityDebug.js';
+import { colorizeQuadOverdraw, colorizeShaderComplexity, DEBUG_VIEW_OVERDRAW, DEBUG_VIEW_SHADER_COMPLEXITY, DEBUG_VIEW_SHADER_COMPLEXITY_AND_OVERDRAW, SHADER_COMPLEXITY_QUAD_COUNT_SCALE } from '../../../nodes/display/ComplexityDebug.js';
 // !WITH_GENESYS
 import { hashArray } from '../../../nodes/core/NodeUtils.js';
 import { error } from '../../../utils.js';
@@ -1035,9 +1035,9 @@ class NodeManager extends DataMap {
 		}
 
 		// WITH_GENESYS
-		if ( renderer.debug.view === DEBUG_VIEW_SHADER_COMPLEXITY || renderer.debug.view === DEBUG_VIEW_SHADER_COMPLEXITY_AND_QUADS ) {
+		if ( renderer.debug.view === DEBUG_VIEW_SHADER_COMPLEXITY || renderer.debug.view === DEBUG_VIEW_SHADER_COMPLEXITY_AND_OVERDRAW ) {
 
-			const complexity = renderer.debug.view === DEBUG_VIEW_SHADER_COMPLEXITY_AND_QUADS
+			const complexity = renderer.debug.view === DEBUG_VIEW_SHADER_COMPLEXITY_AND_OVERDRAW
 				? sampled.r.mul( sampled.g ).mul( SHADER_COMPLEXITY_QUAD_COUNT_SCALE )
 				: sampled.r;
 
@@ -1045,7 +1045,7 @@ class NodeManager extends DataMap {
 
 		}
 
-		if ( renderer.debug.view === DEBUG_VIEW_QUAD_OVERDRAW ) {
+		if ( renderer.debug.view === DEBUG_VIEW_OVERDRAW ) {
 
 			return vec4( colorizeQuadOverdraw( sampled.r ), 1 ).renderOutput( NoToneMapping, renderer.currentColorSpace );
 

package/src/renderers/webgl-fallback/WebGLBackend.js

@@ -1124,11 +1124,17 @@ class WebGLBackend extends Backend {
 
 		const frontFaceCW = ( object.isMesh && object.matrixWorld.determinantAffine() < 0 );
 
-		state.setMaterial( material, frontFaceCW, hardwareClippingPlanes );
+		// WITH_GENESYS
+		state.setMaterial( material, frontFaceCW, hardwareClippingPlanes, object );
+		// !WITH_GENESYS
+		// state.setMaterial( material, frontFaceCW, hardwareClippingPlanes );
 
 		if ( context.mrt !== null && context.textures !== null ) {
 
-			state.setMRTBlending( context.textures, context.mrt, material );
+			// WITH_GENESYS
+			state.setMRTBlending( context.textures, context.mrt, material, object );
+			// !WITH_GENESYS
+			// state.setMRTBlending( context.textures, context.mrt, material );
 
 		}
 

package/src/renderers/webgl-fallback/utils/WebGLState.js

@@ -12,7 +12,8 @@ import { Color } from '../../../math/Color.js';
 import { Vector4 } from '../../../math/Vector4.js';
 import { error, ReversedDepthFuncs, warnOnce } from '../../../utils.js';
 // WITH_GENESYS
-import { debugViewAccumulates } from '../../../nodes/display/ComplexityDebug.js';
+import { debugDrawAccumulates, debugDrawReplacesCost } from '../../../nodes/display/ComplexityDebug.js';
+import { DEBUG_VIEW_FRONT_BACK_FACE } from '../../../nodes/display/FrontBackFaceDebug.js';
 // !WITH_GENESYS
 
 let equationToGL, factorToGL;
@@ -288,7 +289,7 @@ class WebGLState {
 
 	}
 
-	setMRTBlending( textures, mrt, material ) {
+	setMRTBlending( textures, mrt, material, object = null ) {
 
 		const gl = this.gl;
 		const drawBuffersIndexedExt = this.backend.drawBuffersIndexedExt;
@@ -301,6 +302,24 @@ class WebGLState {
 
 		}
 
+		// WITH_GENESYS
+		// Every attachment matches the single-target path. Opaque material blending would replace a sum that should add.
+		if ( debugDrawAccumulates( this.backend.renderer, material, object ) ) {
+
+			const dst = debugDrawReplacesCost( this.backend.renderer.debug.view, material ) ? gl.ZERO : gl.ONE;
+
+			for ( let i = 0; i < textures.length; i ++ ) {
+
+				drawBuffersIndexedExt.blendEquationSeparateiOES( i, gl.FUNC_ADD, gl.FUNC_ADD );
+				drawBuffersIndexedExt.blendFuncSeparateiOES( i, gl.ONE, dst, gl.ONE, gl.ZERO );
+
+			}
+
+			return;
+
+		}
+		// !WITH_GENESYS
+
 		for ( let i = 0; i < textures.length; i ++ ) {
 
 			const texture = textures[ i ];
@@ -923,14 +942,22 @@ class WebGLState {
 	 * @param {Material} material - The material to configure the state for.
 	 * @param {number} frontFaceCW - Whether the front faces are counter-clockwise or not.
 	 * @param {number} hardwareClippingPlanes - The number of hardware clipping planes.
+	 * @param {?Object3D} [object=null] - The object being drawn. Used by the accumulating debug views.
 	 */
-	setMaterial( material, frontFaceCW, hardwareClippingPlanes ) {
+	setMaterial( material, frontFaceCW, hardwareClippingPlanes, object = null ) {
 
 		const { gl } = this;
 
-		material.side === DoubleSide
+		// WITH_GENESYS
+		const drawBothSides = material.side === DoubleSide || ( this.backend.renderer.debug.view === DEBUG_VIEW_FRONT_BACK_FACE && material.isShadowPassMaterial !== true );
+
+		drawBothSides
 			? this.disable( gl.CULL_FACE )
 			: this.enable( gl.CULL_FACE );
+		// !WITH_GENESYS
+		// material.side === DoubleSide
+		// 	? this.disable( gl.CULL_FACE )
+		// 	: this.enable( gl.CULL_FACE );
 
 		let flipSided = ( material.side === BackSide );
 		if ( frontFaceCW ) flipSided = ! flipSided;
@@ -938,10 +965,13 @@ class WebGLState {
 		this.setFlipSided( flipSided );
 
 		// WITH_GENESYS
-		// WebGL has no cached render pipeline. One+One is applied on each draw instead.
-		if ( debugViewAccumulates( this.backend.renderer.debug.view ) && material.isShadowPassMaterial !== true && this.backend.renderer.isOutputTarget !== true ) {
+		// WebGL has no cached render pipeline. The accumulate blend is applied on each draw instead.
+		// Alpha is replaced so it stays coverage, as in a shaded pass, for later compositing.
+		if ( debugDrawAccumulates( this.backend.renderer, material, object ) ) {
+
+			const dstFactor = debugDrawReplacesCost( this.backend.renderer.debug.view, material ) ? ZeroFactor : OneFactor;
 
-			this.setBlending( AdditiveBlending, AddEquation, OneFactor, OneFactor, AddEquation, OneFactor, OneFactor, material.blendColor, material.blendAlpha, true );
+			this.setBlending( CustomBlending, AddEquation, OneFactor, dstFactor, AddEquation, OneFactor, ZeroFactor, material.blendColor, material.blendAlpha, true );
 
 		} else if ( material.blending === NormalBlending && material.transparent === false ) {
 

package/src/renderers/webgpu/utils/WebGPUPipelineUtils.js

@@ -16,7 +16,8 @@ import {
 
 import { error, ReversedDepthFuncs, warn, warnOnce } from '../../../utils.js';
 // WITH_GENESYS
-import { debugViewAccumulates } from '../../../nodes/display/ComplexityDebug.js';
+import { debugDrawAccumulates, debugDrawReplacesCost } from '../../../nodes/display/ComplexityDebug.js';
+import { DEBUG_VIEW_FRONT_BACK_FACE } from '../../../nodes/display/FrontBackFaceDebug.js';
 // !WITH_GENESYS
 
 import GPUComputePipelineDescriptor from '../descriptors/GPUComputePipelineDescriptor.js';
@@ -110,18 +111,22 @@ class WebGPUPipelineUtils {
 		}
 
 		// WITH_GENESYS
-		// Accumulate shader cost with One+One. Opaque materials normally disable blending.
-		if ( debugViewAccumulates( backend.renderer.debug.view ) && material.isShadowPassMaterial !== true && backend.renderer.isOutputTarget !== true ) {
+		// Quad overdraw and translucent shader complexity add. Opaque shader complexity replaces
+		// the stored cost, so the nearest surface wins without a depth pre-pass.
+		// Alpha is replaced so it stays coverage, as in a shaded pass, for later compositing.
+		if ( debugDrawAccumulates( backend.renderer, material, object ) ) {
+
+			const replaceCost = debugDrawReplacesCost( backend.renderer.debug.view, material );
 
 			materialBlending = {
 				color: {
 					srcFactor: GPUBlendFactor.One,
-					dstFactor: GPUBlendFactor.One,
+					dstFactor: replaceCost ? GPUBlendFactor.Zero : GPUBlendFactor.One,
 					operation: GPUBlendOperation.Add
 				},
 				alpha: {
 					srcFactor: GPUBlendFactor.One,
-					dstFactor: GPUBlendFactor.One,
+					dstFactor: GPUBlendFactor.Zero,
 					operation: GPUBlendOperation.Add
 				}
 			};
@@ -942,7 +947,12 @@ class WebGPUPipelineUtils {
 
 		//
 
-		descriptor.cullMode = ( material.side === DoubleSide ) ? GPUCullMode.None : GPUCullMode.Back;
+		// WITH_GENESYS
+		// Front/back face draws both windings. Depth still hides a face behind the shell.
+		const drawBothSides = material.side === DoubleSide || ( this.backend.renderer.debug.view === DEBUG_VIEW_FRONT_BACK_FACE && material.isShadowPassMaterial !== true );
+		descriptor.cullMode = drawBothSides ? GPUCullMode.None : GPUCullMode.Back;
+		// !WITH_GENESYS
+		// descriptor.cullMode = ( material.side === DoubleSide ) ? GPUCullMode.None : GPUCullMode.Back;
 
 		return descriptor;