@gloom-sh/terminal 0.19.1 → 0.19.3

package/src/plugins/builtin/chart-composer/headless-schema.ts

@@ -3,6 +3,7 @@ import { isSubMinuteInterval, subMinuteDataMessage } from "../../../cli/known-ga
 import { CHART_BAR_SIZE_PRESETS, parseChartBarSize } from "../../../time-series/resolution";
 import { FINANCIAL_PERIOD_OPTION, FINANCIAL_PERIOD_COUNT_OPTION, HISTORY_RANGE_VALUES, RETURN_RANGE_VALUES } from "../shared/headless-options";
 import { DATE_OPTION_EXAMPLES } from "../../../utils/calendar-date";
+import { PRICE_WINDOW_FROM_HELP, PRICE_WINDOW_TO_HELP } from "../../../utils/price-window";
 
 type PaneSchema = Pick<HeadlessPaneDefinition, "argument" | "options" | "discovery">;
 
@@ -51,6 +52,11 @@ export const paneSchemas = {
         values: [{ value: "auto" }, ...BAR_SIZES],
         normalize: (value) => normalizeBarSize(value, true),
       },
+      {
+        key: "exchange",
+        description: "Exchange for every ticker that names none: fn G BDI --exchange TSX is fn G BDI:TSX.",
+        type: "string",
+      },
     ],
     discovery: {
       id: "chart-composer",
@@ -138,6 +144,10 @@ export const paneSchemas = {
         ],
         defaultValue: "percent",
       },
+      // A window of dates, measured from the close before it as RETURN is: --from 2026-10-19 compares since the 16th's close.
+      { key: "from", type: "string", placeholder: "year|date", description: `${PRICE_WINDOW_FROM_HELP}; the returns are measured from the last close the tickers share before it, as RETURN measures`,
+        example: "--from 2019-12-31", replaces: ["rangePreset"] },
+      { key: "to", type: "string", placeholder: "year|date", description: PRICE_WINDOW_TO_HELP },
       {
         key: "totalReturn",
         description: "Reinvest each cash distribution at its ex-date close, so the returns are total returns, not price returns.",

package/src/plugins/builtin/chart-composer/headless.ts

@@ -31,9 +31,12 @@ import type { TickerFinancials, PricePoint, Quote } from "../../../types/financi
 import { chartQuoteOverrideKeyForTarget, getLiveChartQuoteTargets } from "../../../time-series/live-quotes";
 import { createChartSeriesResolver } from "../../../capabilities";
 import { loadFuturesContractTerms, loadFuturesPriceUnit } from "../../../market-data/futures-contract";
-import { isUsListingExchange, parsePublicTickerKey, publicTickerKey } from "../../../utils/exchanges";
+import { canonicalExchange, isKnownExchangeCode, isUsListingExchange, parsePublicTickerKey, publicTickerKey } from "../../../utils/exchanges";
 import { zonedDateTimeParts } from "../../../utils/zoned-date-time";
 import { futuresSessionOpenMinute } from "../../../market-data/market/trading-sessions";
+import { isAlwaysOpenExchange, isRegularSessionTime } from "../../../market-data/market/freshness";
+import { isRoundTheClockCoin } from "../../../utils/crypto-pair";
+import { isCurrencyPairListing } from "../../../utils/fx-market-hours";
 import { cleanFloat32Price } from "../../../cli/history-rows";
 import { parseChartSpec } from "./chart-spec";
 import { paneSchemas } from "./headless-schema";
@@ -46,7 +49,8 @@ import { loadFundFacts } from "../sec/fund-facts";
 import { comparedFundTickers, loadDailyObjectives, mayDrawDailyObjective, withLeverageOverlay } from "./leverage-overlay";
 import { classifyInstrumentType } from "../../../tickers/instrument-kind";
 import { priceComparisonEndsIntraday, type PriceComparison } from "../../../time-series/price-comparison";
-import { LATEST_INTRADAY_TEXT } from "../../../market-data/market/period-return";
+import { LATEST_INTRADAY_TEXT, periodDayText } from "../../../market-data/market/period-return";
+import { CLOSING_PRINT_PENDING_TEXT, newestClosedSession, newestSessionClose, withOfficialCloses } from "../../../time-series/official-close";
 
 export interface ChartPaneModel extends HeadlessSeriesResult {
   /** The renderer consumes the full model; generic reports project series and metadata. */
@@ -368,10 +372,19 @@ function chartFreshness(
   const coarsest = resolutions.reduce((worst, resolution) => (
     order.indexOf(resolution!) > order.indexOf(worst!) ? resolution : worst
   ), resolutions[0]);
+  const closedDay = closedPriceBarDay(series);
+  // A window that ended before today (`--to 2026-10-23`) is the history asked for, which no later close makes stale:
+  // `daily closes through Fri 23 Oct`.
+  const windowEnd = spec.viewport.dateWindow?.end;
+  if (windowEnd && /^\d{4}-\d{2}-\d{2}$/.test(windowEnd) && windowEnd < new Date().toISOString().slice(0, 10)) {
+    const through = closedDay ?? series.flatMap((entry) => entry.points.at(-1)?.date ?? []).map((date) => new Date(date).toISOString().slice(0, 10)).sort().at(-1);
+    const basis = coarsest === "1d" ? "daily closes" : coarsest === "1wk" ? "weekly closes" : coarsest === "1mo" ? "monthly closes" : "intraday bars";
+    return { status: "not-a-feed", basis: through ? `${basis} through ${periodDayText(through, new Date().getUTCFullYear())}` : basis,
+      ...(through && closedDay ? { asOf: through } : {}), oldest: null };
+  }
   const forming = formingPriceBar(series);
   // A history: its first bars are not stale data, so the line dates it by the bar still forming alone.
   if (forming) return { ...barHistoryFreshness(coarsest), periodToDate: forming, oldest: null };
-  const closedDay = closedPriceBarDay(series);
   // A comparison whose newest point is a session still trading is not a day's closes.
   const basis = coarsest === "1d" && priceComparisonEndsIntraday(comparison) ? { basis: LATEST_INTRADAY_TEXT } : {};
   // Daily bars are dated by the time of the newest point: a closed session's day, or when a session still trading was last quoted.
@@ -600,30 +613,34 @@ export function argumentWithListing(argument: string, symbol: string, key: strin
 }
 
 /**
- * A FRED series id typed where a ticker goes (`fn G DFII10`), as the chart of
- * FRED:DFII10: the catalog lists it, no listing answers to it, and the quote
- * source says it is not a ticker. A real ticker of the same letters, read as
- * a listing or quoted, still charts as the ticker; null then, and for any
- * other series.
+ * A catalog series typed where a ticker goes, as its chart: a FRED series id
+ * (`fn G DFII10` is FRED:DFII10), or a word a series lists as an alias
+ * (`fn G hashrate` is CAP:bitcoin:hashrate), when the catalog lists it, no
+ * listing answers to it, and the quote source says it is not a ticker. A
+ * real ticker of the same letters, read as a listing or quoted, still charts
+ * as the ticker; null then, and for any other symbol.
  */
-export async function bareFredSeries(
+export async function bareCatalogSeries(
   series: ChartSeriesSpec,
   readListing: () => Promise<unknown>,
-  context: Pick<HeadlessPaneContext, "marketData" | "catalogSeriesName">,
+  context: Pick<HeadlessPaneContext, "marketData" | "catalogSeriesName" | "catalogSeriesNamed">,
 ): Promise<ChartSeriesSpec | null> {
   const { source } = series;
   if (source.kind !== "security" || source.instrument.exchange || source.instrument.instrument || source.fieldId !== CHART_FIELD_IDS.price) return null;
   const id = source.instrument.symbol.trim().toUpperCase();
   const expression = `FRED:${id}`;
-  const label = /^[A-Z0-9]+$/.test(id)
+  const fredLabel = /^[A-Z0-9]+$/.test(id)
     ? context.catalogSeriesName?.(expression) ?? getSharedRegistry()?.series?.findByExpression(expression)?.definition.name
     : undefined;
+  const named = fredLabel ? undefined : context.catalogSeriesNamed?.(id);
+  const parsed = named ? parseSeriesExpression(named.expression) : null;
+  const label = fredLabel ?? (parsed ? named?.name : undefined);
   if (!label || await readListing()) return null;
   const failure = await Promise.resolve().then(() => context.marketData.getQuote(id, ""))
     .then((quote) => quote ? null : `Not a ticker: ${id}.`, (error: unknown) => error instanceof Error ? error.message : String(error));
   if (!failure || !notATickerSymbol(failure)) return null;
-  const fred = buildSeriesSpec({ kind: "economic", provider: "fred", seriesId: id, label }, 0);
-  return { ...fred, id: series.id, transform: series.transform, axis: series.axis, panelId: series.panelId };
+  const spec = parsed ? buildSeriesSpec({ ...parsed, label }, 0) : buildSeriesSpec({ kind: "economic", provider: "fred", seriesId: id, label }, 0);
+  return { ...spec, id: series.id, transform: series.transform, axis: series.axis, panelId: series.panelId };
 }
 
 /**
@@ -646,14 +663,28 @@ async function possibleFundTickers(spec: ChartSpec, context: HeadlessPaneContext
   });
 }
 
+/**
+ * `--exchange TSX`: every ticker series that names no venue, on that one, as
+ * `BDI:TSX` would be. A code the app does not know fails before any request.
+ */
+function onExchange(spec: ChartSpec, exchange: string): ChartSpec {
+  const code = exchange.trim().toUpperCase();
+  if (!isKnownExchangeCode(code)) throw new Error(`Unknown exchange "${exchange.trim()}". Write a venue code such as TSX, LSE or XETRA, or name it in the series: BDI:TSX.`);
+  return { ...spec, series: spec.series.map((series) => series.source.kind !== "security" || series.source.instrument.exchange || series.source.instrument.instrument
+    ? series
+    : { ...series, source: { ...series.source, instrument: { ...series.source.instrument, exchange: canonicalExchange(code) } } }) };
+}
+
 export function chartHeadless(template: keyof typeof paneSchemas): HeadlessPaneDefinition<"series"> {
   return {
     ...paneSchemas[template],
     shape: "series",
     async load(args, context) {
       const intradayHistories: ChartPaneModel["snapshot"]["intradayHistories"] = [];
-      const saved = parseChartSpec(context.settings?.chartSpec);
-      if (!saved) throw new Error("The chart specification is invalid.");
+      const closingPrintsPending: string[] = [];
+      const stored = parseChartSpec(context.settings?.chartSpec);
+      if (!stored) throw new Error("The chart specification is invalid.");
+      const saved = typeof args.options.exchange === "string" ? onExchange(stored, args.options.exchange) : stored;
       // A leveraged or inverse fund compared with anything draws its daily objective beside it.
       const parsed = template === "comparison-chart-pane" && mayDrawDailyObjective(saved)
         ? withLeverageOverlay(saved, await loadDailyObjectives(
@@ -680,9 +711,9 @@ export function chartHeadless(template: keyof typeof paneSchemas): HeadlessPaneD
         series: await Promise.all(parsed.series.map(async (series) => {
           if (series.source.kind !== "security" || series.source.instrument.exchange) return series;
           const { symbol } = series.source.instrument;
-          // A FRED id no ticker answers to (DFII10) is its FRED series; an intraday chart has none.
-          const fred = template === "graph-intraday-price-pane" ? null : await bareFredSeries(series, () => readListing(symbol), context);
-          if (fred) return fred;
+          // A FRED id (DFII10) or a series alias (hashrate) no ticker answers to is that series; an intraday chart has none.
+          const catalog = template === "graph-intraday-price-pane" ? null : await bareCatalogSeries(series, () => readListing(symbol), context);
+          if (catalog) return catalog;
           if (!reads.has(symbol)) reads.set(symbol, readSeriesListing(symbol));
           const instrument = await reads.get(symbol)!;
           return instrument ? { ...series, source: { ...series.source, instrument: { ...series.source.instrument, ...instrument } } } : series;
@@ -709,6 +740,37 @@ export function chartHeadless(template: keyof typeof paneSchemas): HeadlessPaneD
           ...await loadIntradayWindow({ provider: context.marketData, symbol: target.symbol, exchange: target.exchange ?? "", request, context: { brokerId: target.brokerId, brokerInstanceId: target.brokerInstanceId, instrument: target.instrument } }),
         })));
         context.signal.throwIfAborted();
+        // Once a session has closed, its last bar ends on the official close (the closing auction's print), as
+        // `history` and CMP give it, not on the last trade before it; until the quote has that close, the footer says so.
+        await Promise.all(histories.map(async (history) => {
+          // A future settles rather than closing on an auction print, and a coin or a currency pair has no session
+          // to close: their bars stay as traded, and no quote is read for them.
+          if (!history.points.length || futuresSessionOpenMinute(history.symbol, history.exchange) != null
+            || isRoundTheClockCoin(history.symbol, history.exchange) || isCurrencyPairListing(history.symbol, history.exchange)) return;
+          const now = Date.now();
+          const known = history.exchange || history.quote?.listingExchangeName || history.quote?.exchangeName || undefined;
+          if (known && isAlwaysOpenExchange(known)) return;
+          // While the session trades, no session of the chart has closed since its bars were read.
+          if (history.quote?.marketState === "REGULAR" || (known && isRegularSessionTime(known, now) === true)) return;
+          if (known && !newestClosedSession(history.points, { venue: known, now })) return;
+          // A captured shot's source can have no quotes: its bars are drawn as captured.
+          const quote = history.quote ?? (typeof context.marketData.getQuote === "function"
+            ? await Promise.resolve(context.marketData.getQuote(history.symbol, history.exchange,
+              { brokerId: history.target.brokerId, brokerInstanceId: history.target.brokerInstanceId, instrument: history.target.instrument }))
+              .catch(logFailure("chart-composer.headless", "Read the official close of an intraday chart failed", null))
+            : null);
+          const venue = known || quote?.listingExchangeName || quote?.exchangeName || undefined;
+          const newest = newestClosedSession(history.points, { venue, now });
+          const decided = newest ? newestSessionClose(quote, { ...newest, venue }) : null;
+          if (!newest || !decided) return;
+          if ("pending" in decided) {
+            closingPrintsPending.push(history.symbol);
+            return;
+          }
+          const closes = new Map([[newest.date, decided.close]]);
+          history.points = withOfficialCloses(history.points, closes, { venue, now });
+          history.bufferedPoints = withOfficialCloses(history.bufferedPoints, closes, { venue, now });
+        }));
         intradayHistories.push(...histories);
         const starts = histories.flatMap(({ start }) => start ? [start.getTime()] : []);
         const ends = histories.flatMap(({ end }) => end ? [end.getTime()] : []);
@@ -725,9 +787,11 @@ export function chartHeadless(template: keyof typeof paneSchemas): HeadlessPaneD
         }, context.marketData) };
       }
       const model = await loadChartPaneModel(spec, context);
-      // A bare coin ticker charted as another listing (ETH, the Grayscale fund) says where the coin is, as `quote` does.
-      const coinNotes = (await Promise.all(listings.values())).flatMap((read) => read?.coinNote ?? []);
-      if (coinNotes.length) model.warnings = [...model.warnings ?? [], ...coinNotes];
+      // What became of the company that had a bare symbol (GOGL), and a bare coin ticker charted as another listing
+      // (ETH, the Grayscale fund), are said as `quote` says them.
+      const readListings = await Promise.all(listings.values());
+      const listingNotes = [...readListings.flatMap((read) => read?.successorNote ?? []), ...readListings.flatMap((read) => read?.coinNote ?? [])];
+      if (listingNotes.length) model.warnings = [...model.warnings ?? [], ...listingNotes];
       if (template === "graph-intraday-price-pane" && !intradayHistories.length && model.chart.viewport) {
         const { start, end } = model.chart.viewport;
         for (const { target, data } of [
@@ -782,6 +846,9 @@ export function chartHeadless(template: keyof typeof paneSchemas): HeadlessPaneD
         model.metadata = { ...model.metadata, resolution: dropped.drop };
       }
       model.freshness = chartFreshness(model.series, model.spec, model.chart.priceComparison, chartQuoteTimes(model));
+      if (closingPrintsPending.length) {
+        model.freshness = { ...model.freshness, note: [model.freshness.note, CLOSING_PRINT_PENDING_TEXT].filter(Boolean).join(", ") };
+      }
       const priceDomainFailures = intradayHistories.flatMap(({ symbol, exchange, priceDomainFailure }) =>
         priceDomainFailure ? [{ symbol, exchange, ...priceDomainFailure }] : []);
       if (priceDomainFailures.length) {

package/src/plugins/builtin/chart-composer/index.tsx

@@ -11,7 +11,6 @@ import { canonicalExchange, parsePublicTickerKey, publicTickerKey } from "../../
 import { tickerInstrumentLabel } from "../../../tickers/instrument-label";
 import type { ChartSpec } from "../../../time-series/types";
 import { ChartComposerPane, ChartComposerResearchTab } from "./pane";
-import { DataCatalogPane } from "./data-catalog-pane";
 import { listFieldSeries } from "./field-series";
 import { registeredSeriesName } from "./series-expression";
 import {
@@ -404,7 +403,7 @@ const chartComposerTemplates: PaneTemplateDef[] = [
       "positioning",
     ],
     shortcut: { prefix: "CAT", argPlaceholder: "query", argKind: "text", argOptional: true },
-    reportFreshness: { status: "not-a-feed", basis: "series catalog" },
+    reportFreshness: { status: "not-a-feed", basis: "series catalog", local: true },
     canCreate: () => true,
     createInstance: (_context, options) => {
       const query = options?.arg?.trim() ?? options?.values?.query?.trim() ?? "";
@@ -525,7 +524,7 @@ export const chartComposerModule: PluginModule = {
     id: DATA_CATALOG_PANE_ID,
     name: "Data Catalog",
     icon: "C",
-    component: DataCatalogPane,
+    get component(): typeof import("./data-catalog-pane").DataCatalogPane { const { DataCatalogPane } = require("./data-catalog-pane"); return DataCatalogPane; },
     defaultPosition: "right",
     defaultMode: "floating",
     defaultFloatingSize: { width: 110, height: 32 },

package/src/plugins/builtin/chart-composer/pane.tsx

@@ -20,6 +20,7 @@ import {
   type MultiSelectRowAction,
 } from "../../../components/ui";
 import { CompositeChart } from "../../../components/chart/composite";
+import { savedCopyFooterInfo } from "../../../components/layout/pane/footer";
 import { useChartViewReset, useChartViewResetListener } from "../../../components/chart/core/view-reset";
 import { formatCompositeDatasetDate } from "../../../components/chart/composite/format";
 import type { CompositeChartLevels, CompositeLevelEdit } from "../../../components/chart/composite/levels";
@@ -140,7 +141,10 @@ import { alertInstrument, syncAlertQuoteStream } from "../alerts/live";
 import { getSharedMarketDataCoordinator } from "../../../market-data/coordinator";
 import { useOptionChartRange } from "./option-range";
 import { getActiveQuoteDisplay } from "../../../market-data/market/status";
-import { resolveEntryData } from "../../../market-data/selectors";
+import { buildQuoteKey, resolveEntryData } from "../../../market-data/selectors";
+import { useQuoteEntries } from "../../../market-data/hooks";
+import { usePlanAccess } from "../../../api-client/plan-access";
+import { useQuoteDelayFooter } from "../shared/cloud-upgrade";
 import { editPriceLevels, parsePriceLevels, PRICE_LEVELS_KEY, priceLevelTickerKey } from "./price-levels";
 import { canonicalExchange } from "../../../utils/exchanges";
 import { resolveInstrumentForPane } from "../../../core/state/app/instrument";
@@ -217,6 +221,8 @@ interface ChartComposerSurfaceProps {
   onCapture?: (capturing: boolean) => void;
   /** The legend names each series' company; a ticker's own research tab already does. */
   nameSeries?: boolean;
+  /** The footer's delayed clock; a ticker's research tab says it in its quote footer instead. */
+  delayFooter?: boolean;
 }
 
 const QUICK_ADD_CAPTURE = "quick-add";
@@ -306,6 +312,7 @@ function ChartComposerSurface({
   footerId,
   onCapture,
   nameSeries = true,
+  delayFooter = true,
 }: ChartComposerSurfaceProps) {
   const trade = useResearchTrading();
   const dialog = useDialog();
@@ -1116,9 +1123,28 @@ function ChartComposerSurface({
     }
     return newest > end ? formatCompositeDatasetDate(new Date(newest), end) : null;
   }, [activeRuntimeViewport, plottedSeries, spec, viewport]);
+  // A series a failed refresh left on a saved copy says when that copy was saved, as every pane does.
+  const savedAt = resolution.savedAt;
+  // Signed out or free, a market series' latest bars are built from delayed quotes.
+  const marketInstruments = useMemo(() => (delayFooter ? spec.series.flatMap((entry) => (
+    entry.source.kind === "security" && isMarketFieldId(entry.source.fieldId) ? [entry.source.instrument] : []
+  )) : []), [delayFooter, spec.series]);
+  const marketQuotes = useQuoteEntries(marketInstruments);
+  // Signed out no stream feeds a chart's quotes: without Pro the chart reads them once to know which are late.
+  const { hasProAccess } = usePlanAccess();
+  const marketQuoteKey = marketInstruments.map(buildQuoteKey).join("\u001f");
+  useEffect(() => {
+    const coordinator = getSharedMarketDataCoordinator();
+    if (hasProAccess || !coordinator) return;
+    for (const instrument of marketInstruments) {
+      void coordinator.loadQuote(instrument).catch(logFailure("chart-composer.pane", "Loading a chart quote failed"));
+    }
+  }, [hasProAccess, marketQuoteKey]);
+  const quoteDelay = useQuoteDelayFooter(Array.from(marketQuotes.values(), resolveEntryData), "chart-delay");
   usePaneFooter(footerId, () => ({
     info: [
       ...(delistingKey ? [{ id: "delisted", parts: [{ text: delistingKey, tone: "warning" as const }] }] : []),
+      ...savedCopyFooterInfo([savedAt]),
       ...(loading
         ? [{ id: "loading", parts: [{ text: "loading", tone: "muted" as const }] }]
         : pickingAnchor
@@ -1126,6 +1152,7 @@ function ChartComposerSurface({
           : newestBeyondView
             ? [{ id: "newest", asOf: true, parts: [{ text: `newest ${newestBeyondView}`, tone: "muted" as const }] }]
             : []),
+      ...(quoteDelay ? [quoteDelay] : []),
     ],
     hints: [
       // One key opens the ticket, which chooses Buy or Sell; [s]eries keeps its key with trading on.
@@ -1136,7 +1163,7 @@ function ChartComposerSurface({
       { id: "resolution", key: "b", label: "ars", title: "Bar Size", onPress: footerResolution },
       ...(anchorable ? [{ id: "vwap-anchor", key: "v", label: "wap anchor", title: "Anchor VWAP", onPress: footerAnchor }] : []),
     ],
-  }), [delistingKey, loading, pickingAnchor, newestBeyondView, footerSeries, openIndicators, indicatorsDisabled, openFormulas, formulasDisabled, footerResolution, anchorable, footerAnchor, trade]);
+  }), [delistingKey, savedAt, loading, pickingAnchor, newestBeyondView, quoteDelay, footerSeries, openIndicators, indicatorsDisabled, openFormulas, formulasDisabled, footerResolution, anchorable, footerAnchor, trade]);
 
   // A fixed window (a GIP session) highlights no range, so the bar names it.
   const dateWindowLabel = useMemo(() => {
@@ -1472,6 +1499,7 @@ export function ChartComposerResearchTab({ focused, width, height, onCapture }:
       footerId="chart-composer:research"
       onCapture={onCapture}
       nameSeries={false}
+      delayFooter={false}
     />
   );
 }

package/src/plugins/builtin/chart-composer/series-expression.ts

@@ -8,8 +8,8 @@ import {
   listTimeSeriesFields,
 } from "../../../time-series/field-catalog";
 import {
-  CANONICAL_EXCHANGE_ALIASES,
   canonicalExchange,
+  isKnownExchangeCode,
   publicTickerKey,
 } from "../../../utils/exchanges";
 import { MAX_CHART_COMPOSER_SERIES } from "./chart-spec";
@@ -73,7 +73,8 @@ export function normalizeInstrument(
   if (parts.length !== 2) return null;
   const symbol = normalizeBaseSymbol(parts[0]!);
   const exchangeToken = parts[1]!.trim().toUpperCase();
-  const knownExchange = Object.prototype.hasOwnProperty.call(CANONICAL_EXCHANGE_ALIASES, exchangeToken);
+  // Every venue the app names, as a listing's key writes it (BDI:NEO, Cboe Canada), not only the spellings it reads as another.
+  const knownExchange = isKnownExchangeCode(exchangeToken);
   if (!symbol || !/^[A-Z0-9._-]{1,24}$/.test(exchangeToken) || (!knownExchange && !allowUnknownExchange)) {
     return null;
   }

package/src/plugins/builtin/chart-composer/session-range.ts

@@ -4,6 +4,7 @@ import { cleanFloat32Price } from "../../../cli/history-rows";
 import { exportNumber } from "../../../cli/report-tables";
 import { publicTickerKey } from "../../../utils/exchanges";
 import { formatUtcTime } from "../../../utils/utc-time";
+import { pricePointWicks } from "../../../utils/price-history-integrity";
 
 interface SessionExtreme {
   price: number;
@@ -26,8 +27,10 @@ function sessionRange(points: readonly PricePoint[]): SessionRange | null {
   for (const point of points) {
     const at = point.date;
     if (!(at instanceof Date) || !Number.isFinite(at.getTime())) continue;
-    const pointLow = finitePositive(point.low) ?? finitePositive(point.close);
-    const pointHigh = finitePositive(point.high) ?? finitePositive(point.close);
+    // A wick too far from the bar's body to have traded is not a price the bars traded.
+    const wicks = pricePointWicks(point);
+    const pointLow = finitePositive(wicks.low) ?? finitePositive(point.close);
+    const pointHigh = finitePositive(wicks.high) ?? finitePositive(point.close);
     if (pointLow != null && (!low || pointLow < low.price)) low = { price: pointLow, at };
     if (pointHigh != null && (!high || pointHigh > high.price)) high = { price: pointHigh, at };
   }

package/src/plugins/builtin/chart-composer/studies.ts

@@ -1,7 +1,7 @@
 import type { ChartSpec, ChartStudyKind, ChartStudySpec, ResolvedSeries } from "../../../time-series/types";
 import { observationDate } from "../../../time-series/price-comparison";
 import { zonedWallClockToUtcMs } from "../../../utils/zoned-date-time";
-import { DEFAULT_PROFILE_ROWS, vwapAnchors, withVwapAnchors } from "../../../time-series/studies";
+import { DEFAULT_PROFILE_ROWS, vwapAnchors, withVwapAnchors } from "../../../time-series/studies/vwap";
 import { reconcilePanels } from "./chart-spec-edit";
 import { CHART_FIELD_IDS } from "./series-expression";
 

package/src/plugins/builtin/chat/controller/index.ts

@@ -916,7 +916,7 @@ export class ChatController {
     const channel = this.ensureChannelState(channelId);
     mergeChatMessages({
       channel,
-      currentUserId: this.session.user?.id,
+      currentUser: this.session.user,
       messages,
       options,
       viewActive: this.appActive && channel.focusedViewCount > 0,

package/src/plugins/builtin/chat/controller/messages.ts

@@ -1,5 +1,6 @@
 import type { ChatAttachment, ChatMessage } from "../../../../api-client";
 import { toTimestampMillis } from "../../../../utils/timestamp";
+import { isGloomWire } from "../ghost-user";
 import type { ChannelRuntimeState, MergeMessagesOptions } from "./state";
 import { PENDING_RECONCILE_WINDOW_MS } from "./state";
 import { chatMessageMentionsUsername, compareMessages, normalizeChatUsername } from "./utils";
@@ -186,16 +187,26 @@ function getMentionMessages(messages: ChatMessage[], user: CurrentChatUser): Cha
 
 interface MergeChatMessagesOptions {
   channel: ChannelRuntimeState;
-  currentUserId?: string | null;
+  currentUser?: CurrentChatUser;
   messages: ChatMessage[];
   options?: MergeMessagesOptions;
   viewActive: boolean;
   markViewed: (persist?: boolean) => void;
 }
 
+/**
+ * New messages from others count as unread, as the server counts them: a
+ * Gloom Wire post only when it mentions you.
+ */
+function countUnread(messages: ChatMessage[], user: CurrentChatUser): number {
+  const fromPeople = messages.filter((message) => !isGloomWire(message.user));
+  const wireMentions = getMentionMessages(messages.filter((message) => isGloomWire(message.user)), user);
+  return fromPeople.length + wireMentions.length;
+}
+
 export function mergeChatMessages({
   channel,
-  currentUserId,
+  currentUser,
   messages,
   options,
   viewActive,
@@ -203,11 +214,11 @@ export function mergeChatMessages({
 }: MergeChatMessagesOptions): void {
   reconcilePendingMessages(channel, messages);
   const freshIncoming = mergeStoredMessages(channel, messages)
-    .filter((message) => message.user.id !== currentUserId);
+    .filter((message) => message.user.id !== currentUser?.id);
   if (viewActive) {
     markViewed(false);
   } else if (freshIncoming.length > 0 && options?.countUnread !== false) {
-    channel.unreadCount += freshIncoming.length;
+    channel.unreadCount += countUnread(freshIncoming, currentUser);
   }
 }
 

package/src/plugins/builtin/chat/ghost-user.ts

@@ -16,6 +16,14 @@ export function isManagedBot(user: Pick<ChatUserSummary, "accountType"> | null |
   return user?.accountType === "managed_llm";
 }
 
+/** Gloom Wire: the account that posts headlines, the day's calendar and pull requests into the topic channels. */
+const GLOOM_WIRE_USER_ID = "managed-llm-gloomwire";
+
+/** A Gloom Wire post: there to read, so unread only when it mentions you. */
+export function isGloomWire(user: Pick<ChatUserSummary, "id"> | null | undefined): boolean {
+  return user?.id === GLOOM_WIRE_USER_ID;
+}
+
 /**
  * A reply quotes its author by name only, so whether that author is a managed
  * assistant comes from the users the pane has seen. A quoted announcement is

package/src/plugins/builtin/chat/index.tsx

@@ -16,11 +16,9 @@ import { CHAT_KEEP_CONVERSATION_VALUE, createChatSearchProvider } from "./comman
 import { chatController } from "./controller";
 import { buildChatConversations, selectChatConversations } from "./conversations";
 import { pickChatPaneToReuse } from "./pane-state";
-import { ChatPane } from "./pane";
 import { chatSidebarStore } from "./sidebar-store";
 import { chatHandlePromptStore } from "./handle-prompt";
 import { ChatStatusWidget } from "./status-widget";
-import { UnreadInboxPane } from "./unread-inbox-pane";
 import { installPaneChatSharing } from "./share/flow";
 import { attachChatPaneLinkPanes } from "./pane-links/previews";
 import { attachChatCommands, cachedChatFunctions, chatFunctionsChanged } from "./pane-links/commands";
@@ -62,9 +60,10 @@ let disposeUnreadBadge: (() => void) | undefined;
 export const chatModule: PluginModule = {
   panes: [{
     id: "chat",
+    reportFreshness: { local: true },
     name: "Chat",
     icon: "C",
-    component: ChatPane,
+    get component(): typeof import("./pane").ChatPane { const { ChatPane } = require("./pane"); return ChatPane; },
     defaultPosition: "right",
     defaultMode: "floating",
     defaultFloatingSize: { width: 80, height: 30 },
@@ -79,12 +78,12 @@ export const chatModule: PluginModule = {
     },
   }, {
     id: UNREAD_INBOX_PANE_ID,
-    reportFreshness: { status: "not-a-feed", basis: "chat messages and missed alerts" },
+    reportFreshness: { status: "not-a-feed", basis: "chat messages and missed alerts", local: true },
     name: "Unread",
     // Mentions and replies from every conversation, DMs included.
     personalData: "messages",
     icon: "U",
-    component: UnreadInboxPane,
+    get component(): typeof import("./unread-inbox-pane").UnreadInboxPane { const { UnreadInboxPane } = require("./unread-inbox-pane"); return UnreadInboxPane; },
     defaultPosition: "right",
     defaultMode: "floating",
     defaultFloatingSize: { width: 88, height: 16 },
@@ -96,6 +95,7 @@ export const chatModule: PluginModule = {
     description: "Open the floating chat window for a channel",
     keywords: ["new", "chat", "pane", "message"],
     shortcut: { prefix: "CHAT", argPlaceholder: "channel", argKind: "text" },
+    catalogSettings: {},
     createInstance: async (context, options) => {
       const rawArg = options?.arg?.trim() ?? "";
       // The command bar's New DM keeps the open pane on its conversation.

package/src/plugins/builtin/clinical-trials/index.tsx

@@ -1,6 +1,5 @@
 import type { GloomPlugin, PaneTemplateCreateOptions } from "../../../types/plugin";
 import { normalizeTrialFilters, TRIAL_REPORT_OPTIONS, ALL } from "./model";
-import { TrialsPane } from "./pane";
 import { CLINICAL_TRIALS_PANE_ID, CLINICAL_TRIALS_PLUGIN_ID } from "./types";
 
 function createTrialsPaneInstance(options?: PaneTemplateCreateOptions) {
@@ -40,7 +39,7 @@ export const clinicalTrialsPlugin: GloomPlugin = {
       reportOptions: TRIAL_REPORT_OPTIONS,
       name: "Trials",
       icon: "C",
-      component: TrialsPane,
+      get component(): typeof import("./pane").TrialsPane { const { TrialsPane } = require("./pane"); return TrialsPane; },
       defaultPosition: "right",
       defaultMode: "floating",
       defaultFloatingSize: { width: 100, height: 30 },

package/src/plugins/builtin/cloud/company-picker.tsx

@@ -189,7 +189,7 @@ function LogoTile({ symbol, assetCategory, size }: { symbol: string; assetCatego
     return <Box alignItems="center" justifyContent="center" style={tile}>{letter}</Box>;
   }
   return (
-    <ImageSurface src={src} alt={symbol} objectFit="contain" alignItems="center" justifyContent="center" style={tile}>
+    <ImageSurface src={src} alt={symbol} objectFit="contain" fallbackWhileLoading alignItems="center" justifyContent="center" style={tile}>
       {letter}
     </ImageSurface>
   );

package/src/plugins/builtin/cloud/index.tsx

@@ -1,4 +1,3 @@
-import { buildoutModule } from "../buildout";
 import { createGloomberbCloudPlugin } from "./plugin";
 
-export const gloomberbCloudPlugin = createGloomberbCloudPlugin([buildoutModule]);
+export const gloomberbCloudPlugin = createGloomberbCloudPlugin();

package/src/plugins/builtin/cloud/plugin.tsx

@@ -2,6 +2,7 @@ import type { GloomPlugin } from "../../../types/plugin";
 import { apiClient } from "../../../api-client";
 import { createGloomberbCloudCapabilities, createGloomberbCloudProvider } from "../../../sources/gloomberb-cloud";
 import { accountManagementModule } from "../account-management";
+import { buildoutModule } from "../buildout";
 import { chatModule } from "../chat";
 import {
   CONGRESS_TRADES_PANE_ID,
@@ -88,8 +89,10 @@ const askgModule: PluginModule = {
   },
   panes: [{
     id: ASKG_PANE_ID,
-    reportFreshness: { status: "not-a-feed", basis: "generated answer" },
+    reportFreshness: { status: "not-a-feed", basis: "generated answer", local: true },
     reportLockNote: askgLockNote,
+    // Without a session the wall is all there is, so `fn ASKG` prints it at once.
+    signInWall: true,
     name: "Ask Gloom",
     personalData: "messages",
     icon: "K",
@@ -177,8 +180,7 @@ const congressTradesModule: PluginModule = {
   }],
 };
 
-/** The desktop and browser builds differ only in the modules they add here. */
-export function createGloomberbCloudPlugin(extraModules: readonly PluginModule[] = []): GloomPlugin {
+export function createGloomberbCloudPlugin(): GloomPlugin {
   return composeBuiltinPlugin({
     id: "gloomberb-cloud",
     name: "Gloom Cloud",
@@ -195,7 +197,7 @@ export function createGloomberbCloudPlugin(extraModules: readonly PluginModule[]
       cloudAccountModule,
       askgModule,
       terminalRelayModule,
-      ...extraModules,
+      buildoutModule,
       congressTradesModule,
       cloudTweetsModule,
     ],

package/src/plugins/builtin/cloud/team/module.tsx

@@ -24,7 +24,7 @@ export const teamModule: PluginModule = {
   capabilities: [createCloudTeamCapability(), createCloudViewsCapability()],
   panes: [{
     id: TEAM_PANE_ID,
-    reportFreshness: { status: "not-a-feed", basis: "account data" },
+    reportFreshness: { status: "not-a-feed", basis: "account data", local: true },
     name: "Team",
     icon: "T",
     personalData: "account",

package/src/plugins/builtin/cloud/thesis/module.tsx

@@ -12,7 +12,7 @@ import { ThesisTickerTab } from "./ticker-tab";
 export const thesisModule: PluginModule = {
   panes: [{
     id: THESIS_PANE_ID,
-    reportFreshness: { source: "Your theses", status: "not-a-feed", basis: "your theses" },
+    reportFreshness: { source: "Your theses", status: "not-a-feed", basis: "your theses", local: true },
     name: "Theses",
     personalData: "holdings",
     icon: "Θ",