@gajae-code/coding-agent 0.6.4 → 0.6.5

package/src/extensibility/custom-commands/bundled/review/index.ts

@@ -1,456 +0,0 @@
-/**
- * /review command - Interactive code review launcher
- *
- * Provides a menu to select review mode:
- * 1. Review against a base branch (PR style)
- * 2. Review uncommitted changes
- * 3. Review a specific commit
- * 4. Custom review instructions
- *
- * Runs git diff upfront, parses results, filters noise, and provides
- * rich context for the orchestrating agent to distribute work across
- * multiple reviewer agents based on diff weight and locality.
- */
-import { prompt } from "@gajae-code/utils";
-import type { CustomCommand, CustomCommandAPI } from "../../../../extensibility/custom-commands/types";
-import type { HookCommandContext } from "../../../../extensibility/hooks/types";
-import reviewRequestTemplate from "../../../../prompts/review-request.md" with { type: "text" };
-import * as git from "../../../../utils/git";
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Types
-// ─────────────────────────────────────────────────────────────────────────────
-
-interface FileDiff {
-	path: string;
-	linesAdded: number;
-	linesRemoved: number;
-	hunks: string;
-}
-
-interface DiffStats {
-	files: FileDiff[];
-	totalAdded: number;
-	totalRemoved: number;
-	excluded: { path: string; reason: string; linesAdded: number; linesRemoved: number }[];
-}
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Exclusion patterns for noise files
-// ─────────────────────────────────────────────────────────────────────────────
-
-const EXCLUDED_PATTERNS: { pattern: RegExp; reason: string }[] = [
-	// Lock files
-	{ pattern: /\.lock$/, reason: "lock file" },
-	{ pattern: /-lock\.(json|yaml|yml)$/, reason: "lock file" },
-	{ pattern: /package-lock\.json$/, reason: "lock file" },
-	{ pattern: /yarn\.lock$/, reason: "lock file" },
-	{ pattern: /pnpm-lock\.yaml$/, reason: "lock file" },
-	{ pattern: /Cargo\.lock$/, reason: "lock file" },
-	{ pattern: /Gemfile\.lock$/, reason: "lock file" },
-	{ pattern: /poetry\.lock$/, reason: "lock file" },
-	{ pattern: /composer\.lock$/, reason: "lock file" },
-	{ pattern: /flake\.lock$/, reason: "lock file" },
-
-	// Generated/build artifacts
-	{ pattern: /\.min\.(js|css)$/, reason: "minified" },
-	{ pattern: /\.generated\./, reason: "generated" },
-	{ pattern: /\.snap$/, reason: "snapshot" },
-	{ pattern: /\.map$/, reason: "source map" },
-	{ pattern: /^dist\//, reason: "build output" },
-	{ pattern: /^build\//, reason: "build output" },
-	{ pattern: /^out\//, reason: "build output" },
-	{ pattern: /node_modules\//, reason: "vendor" },
-	{ pattern: /vendor\//, reason: "vendor" },
-
-	// Binary/assets (usually shown as binary in diff anyway)
-	{ pattern: /\.(png|jpg|jpeg|gif|ico|webp|avif)$/i, reason: "image" },
-	{ pattern: /\.(woff|woff2|ttf|eot|otf)$/i, reason: "font" },
-	{ pattern: /\.(pdf|zip|tar|gz|rar|7z)$/i, reason: "binary" },
-];
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Diff parsing
-// ─────────────────────────────────────────────────────────────────────────────
-
-/**
- * Check if a file path should be excluded from review.
- * Returns the exclusion reason if excluded, undefined otherwise.
- */
-function getExclusionReason(path: string): string | undefined {
-	for (const { pattern, reason } of EXCLUDED_PATTERNS) {
-		if (pattern.test(path)) return reason;
-	}
-	return undefined;
-}
-
-/**
- * Parse unified diff output into per-file stats.
- * Splits on file boundaries, counts +/- lines, and filters excluded files.
- */
-function parseDiff(diffOutput: string): DiffStats {
-	const files: FileDiff[] = [];
-	const excluded: DiffStats["excluded"] = [];
-	let totalAdded = 0;
-	let totalRemoved = 0;
-
-	// Split by file boundary: "diff --git a/... b/..."
-	const fileChunks = diffOutput.split(/^diff --git /m).filter(Boolean);
-
-	for (const chunk of fileChunks) {
-		// Extract file path from "a/path b/path" line
-		const headerMatch = chunk.match(/^a\/(.+?) b\/(.+)/);
-		if (!headerMatch) continue;
-
-		const path = headerMatch[2];
-
-		// Count added/removed lines (lines starting with + or - but not ++ or --)
-		let linesAdded = 0;
-		let linesRemoved = 0;
-
-		const lines = chunk.split("\n");
-		for (const line of lines) {
-			if (line.startsWith("+") && !line.startsWith("+++")) {
-				linesAdded++;
-			} else if (line.startsWith("-") && !line.startsWith("---")) {
-				linesRemoved++;
-			}
-		}
-
-		const exclusionReason = getExclusionReason(path);
-		if (exclusionReason) {
-			excluded.push({ path, reason: exclusionReason, linesAdded, linesRemoved });
-		} else {
-			files.push({
-				path,
-				linesAdded,
-				linesRemoved,
-				hunks: `diff --git ${chunk}`,
-			});
-			totalAdded += linesAdded;
-			totalRemoved += linesRemoved;
-		}
-	}
-
-	return { files, totalAdded, totalRemoved, excluded };
-}
-
-/**
- * Get file extension for display purposes.
- */
-function getFileExt(path: string): string {
-	const match = path.match(/\.([^.]+)$/);
-	return match ? match[1] : "";
-}
-
-/**
- * Determine recommended number of reviewer agents based on diff weight.
- * Uses total lines changed as the primary metric.
- */
-function getRecommendedAgentCount(stats: DiffStats): number {
-	const totalLines = stats.totalAdded + stats.totalRemoved;
-	const fileCount = stats.files.length;
-
-	// Heuristics:
-	// - Tiny (<100 lines or 1-2 files): 1 agent
-	// - Small (<500 lines): 1-2 agents
-	// - Medium (<2000 lines): 2-4 agents
-	// - Large (<5000 lines): 4-8 agents
-	// - Huge (>5000 lines): 8-16 agents
-
-	if (totalLines < 100 || fileCount <= 2) return 1;
-	if (totalLines < 500) return Math.min(2, fileCount);
-	if (totalLines < 2000) return Math.min(4, Math.ceil(fileCount / 3));
-	if (totalLines < 5000) return Math.min(8, Math.ceil(fileCount / 2));
-	return Math.min(16, fileCount);
-}
-
-/**
- * Extract first N lines of actual diff content (excluding headers) for preview.
- */
-function getDiffPreview(hunks: string, maxLines: number): string {
-	const lines = hunks.split("\n");
-	const contentLines: string[] = [];
-
-	for (const line of lines) {
-		// Skip diff headers, keep actual content
-		if (
-			line.startsWith("diff --git") ||
-			line.startsWith("index ") ||
-			line.startsWith("---") ||
-			line.startsWith("+++") ||
-			line.startsWith("@@")
-		) {
-			continue;
-		}
-		contentLines.push(line);
-		if (contentLines.length >= maxLines) break;
-	}
-
-	return contentLines.join("\n");
-}
-
-// Thresholds for diff inclusion
-const MAX_DIFF_CHARS = 50_000; // Don't include diff above this
-const MAX_FILES_FOR_INLINE_DIFF = 20; // Don't include diff if more files than this
-
-/**
- * Build the full review prompt with diff stats and distribution guidance.
- */
-function buildReviewPrompt(mode: string, stats: DiffStats, rawDiff: string, additionalInstructions?: string): string {
-	const agentCount = getRecommendedAgentCount(stats);
-	const skipDiff = rawDiff.length > MAX_DIFF_CHARS || stats.files.length > MAX_FILES_FOR_INLINE_DIFF;
-	const totalLines = stats.totalAdded + stats.totalRemoved;
-	const linesPerFile = skipDiff ? Math.max(5, Math.floor(100 / stats.files.length)) : 0;
-
-	const filesWithExt = stats.files.map(f => ({
-		...f,
-		ext: getFileExt(f.path),
-		hunksPreview: skipDiff ? getDiffPreview(f.hunks, linesPerFile) : "",
-	}));
-
-	return prompt.render(reviewRequestTemplate, {
-		mode,
-		files: filesWithExt,
-		excluded: stats.excluded,
-		totalAdded: stats.totalAdded,
-		totalRemoved: stats.totalRemoved,
-		totalLines,
-		agentCount,
-		multiAgent: agentCount > 1,
-		skipDiff,
-		rawDiff: rawDiff.trim(),
-		linesPerFile,
-		additionalInstructions,
-	});
-}
-
-export class ReviewCommand implements CustomCommand {
-	name = "review";
-	description = "Launch interactive code review";
-
-	constructor(private api: CustomCommandAPI) {}
-
-	async execute(args: string[], ctx: HookCommandContext): Promise<string | undefined> {
-		if (!ctx.hasUI) {
-			const base = "Use the Task tool to run the 'reviewer' agent to review recent code changes.";
-			return args.length > 0 ? `${base} Focus: ${args.join(" ")}` : base;
-		}
-
-		// Inline args act as additional instructions appended to the generated prompt.
-		// When present, skip option 4 (editor) — the args already provide the instructions.
-		const extraInstructions = args.length > 0 ? args.join(" ") : undefined;
-
-		const menuItems = extraInstructions
-			? [
-					"1. Review against a base branch (PR Style)",
-					"2. Review uncommitted changes",
-					"3. Review a specific commit",
-				]
-			: [
-					"1. Review against a base branch (PR Style)",
-					"2. Review uncommitted changes",
-					"3. Review a specific commit",
-					"4. Custom review instructions",
-				];
-
-		const mode = await ctx.ui.select("Review Mode", menuItems);
-
-		if (!mode) return undefined;
-
-		const modeNum = parseInt(mode[0], 10);
-
-		switch (modeNum) {
-			case 1: {
-				// PR-style review against base branch
-				const branches = await getGitBranches(this.api);
-				if (branches.length === 0) {
-					ctx.ui.notify("No git branches found", "error");
-					return undefined;
-				}
-
-				const baseBranch = await ctx.ui.select("Select base branch to compare against", branches);
-				if (!baseBranch) return undefined;
-
-				const currentBranch = await getCurrentBranch(this.api);
-				let diffText: string;
-				try {
-					diffText = await git.diff(this.api.cwd, { base: `${baseBranch}...${currentBranch}` });
-				} catch (err) {
-					ctx.ui.notify(`Failed to get diff: ${err instanceof Error ? err.message : String(err)}`, "error");
-					return undefined;
-				}
-
-				if (!diffText.trim()) {
-					ctx.ui.notify(`No changes between ${baseBranch} and ${currentBranch}`, "warning");
-					return undefined;
-				}
-
-				const stats = parseDiff(diffText);
-				if (stats.files.length === 0) {
-					ctx.ui.notify("No reviewable files (all changes filtered out)", "warning");
-					return undefined;
-				}
-
-				return buildReviewPrompt(
-					`Reviewing changes between \`${baseBranch}\` and \`${currentBranch}\` (PR-style)`,
-					stats,
-					diffText,
-					extraInstructions,
-				);
-			}
-
-			case 2: {
-				// Uncommitted changes - combine staged and unstaged
-				const status = await getGitStatus(this.api);
-				if (!status.trim()) {
-					ctx.ui.notify("No uncommitted changes found", "warning");
-					return undefined;
-				}
-
-				let unstagedDiff: string;
-				let stagedDiff: string;
-				try {
-					[unstagedDiff, stagedDiff] = await Promise.all([
-						git.diff(this.api.cwd),
-						git.diff(this.api.cwd, { cached: true }),
-					]);
-				} catch (err) {
-					ctx.ui.notify(`Failed to get diff: ${err instanceof Error ? err.message : String(err)}`, "error");
-					return undefined;
-				}
-
-				const combinedDiff = [unstagedDiff, stagedDiff].filter(Boolean).join("\n");
-
-				if (!combinedDiff.trim()) {
-					ctx.ui.notify("No diff content found", "warning");
-					return undefined;
-				}
-
-				const stats = parseDiff(combinedDiff);
-				if (stats.files.length === 0) {
-					ctx.ui.notify("No reviewable files (all changes filtered out)", "warning");
-					return undefined;
-				}
-
-				return buildReviewPrompt(
-					"Reviewing uncommitted changes (staged + unstaged)",
-					stats,
-					combinedDiff,
-					extraInstructions,
-				);
-			}
-
-			case 3: {
-				// Specific commit
-				const commits = await getRecentCommits(this.api, 20);
-				if (commits.length === 0) {
-					ctx.ui.notify("No commits found", "error");
-					return undefined;
-				}
-
-				const selected = await ctx.ui.select("Select commit to review", commits);
-				if (!selected) return undefined;
-
-				// Extract commit hash from selection (format: "abc1234 message")
-				const hash = selected.split(" ")[0];
-
-				let diffText: string;
-				try {
-					diffText = await git.show(this.api.cwd, hash, { format: "" });
-				} catch (err) {
-					ctx.ui.notify(`Failed to get commit: ${err instanceof Error ? err.message : String(err)}`, "error");
-					return undefined;
-				}
-
-				if (!diffText.trim()) {
-					ctx.ui.notify("Commit has no diff content", "warning");
-					return undefined;
-				}
-
-				const stats = parseDiff(diffText);
-				if (stats.files.length === 0) {
-					ctx.ui.notify("No reviewable files in commit (all changes filtered out)", "warning");
-					return undefined;
-				}
-
-				return buildReviewPrompt(`Reviewing commit \`${hash}\``, stats, diffText, extraInstructions);
-			}
-
-			case 4: {
-				// Custom instructions - still uses the old approach since user provides context
-				const instructions = await ctx.ui.editor("Enter custom review instructions", "Review the following:\n\n");
-				if (!instructions?.trim()) return undefined;
-
-				// For custom, we still try to get current diff for context
-				let diffText: string | undefined;
-				try {
-					diffText = await git.diff(this.api.cwd, { base: "HEAD" });
-				} catch {
-					diffText = undefined;
-				}
-				const reviewDiff = diffText?.trim();
-
-				if (reviewDiff) {
-					const stats = parseDiff(reviewDiff);
-					// Even if all files filtered, include the custom instructions
-					return buildReviewPrompt(
-						`Custom review: ${instructions.split("\n")[0].slice(0, 60)}…`,
-						stats,
-						reviewDiff,
-						instructions,
-					);
-				}
-
-				// No diff available, just pass instructions
-				return `## Code Review Request
-
-### Mode
-Custom review instructions
-
-### Instructions
-
-${instructions}
-
-Use the Task tool with \`agent: "reviewer"\` to execute this review.`;
-			}
-
-			default:
-				return undefined;
-		}
-	}
-}
-
-async function getGitBranches(api: CustomCommandAPI): Promise<string[]> {
-	try {
-		return await git.branch.list(api.cwd, { all: true });
-	} catch {
-		return [];
-	}
-}
-
-async function getCurrentBranch(api: CustomCommandAPI): Promise<string> {
-	try {
-		return (await git.branch.current(api.cwd)) ?? "HEAD";
-	} catch {
-		return "HEAD";
-	}
-}
-
-async function getGitStatus(api: CustomCommandAPI): Promise<string> {
-	try {
-		return await git.status(api.cwd);
-	} catch {
-		return "";
-	}
-}
-
-async function getRecentCommits(api: CustomCommandAPI, count: number): Promise<string[]> {
-	try {
-		return await git.log.onelines(api.cwd, count);
-	} catch {
-		return [];
-	}
-}
-
-export default ReviewCommand;

package/src/prompts/agents/explore.md

@@ -1,58 +0,0 @@
----
-name: explore
-description: Fast read-only codebase scout returning compressed context for handoff
-tools: read, search, find, web_search
-model: pi/default
-thinking-level: med
-output:
-  properties:
-    summary:
-      metadata:
-        description: Brief summary of findings and conclusions
-      type: string
-    files:
-      metadata:
-        description: Files examined with relevant code references
-      elements:
-        properties:
-          path:
-            metadata:
-              description: Project-relative path or paths to the most relevant code reference(s), optionally suffixed with line ranges like `:12-34` when relevant
-            type: string
-          description:
-            metadata:
-              description: Section contents
-            type: string
-    architecture:
-      metadata:
-        description: Brief explanation of how pieces connect
-      type: string
-hide: true
----
-
-Investigate the codebase rapidly. Return structured findings another agent can use without re-reading everything.
-
-<directives>
-- You MUST use tools for broad pattern matching / code search as much as possible.
-- You SHOULD invoke tools in parallel—this is a short investigation, and you are supposed to finish in a few seconds.
-- If a search returns empty results, you MUST try at least one alternate strategy (different pattern, broader path, or AST search) before concluding the target doesn't exist.
-</directives>
-
-<thoroughness>
-You MUST infer the thoroughness from the task; default to medium:
-- **Quick**: Targeted lookups, key files only
-- **Medium**: Follow imports, read critical sections
-- **Thorough**: Trace all dependencies, check tests/types.
-</thoroughness>
-
-<procedure>
-1. Locate relevant code using tools.
-2. Read key sections (You NEVER read full files unless they're tiny)
-3. Identify types/interfaces/key functions.
-4. Note dependencies between files.
-</procedure>
-
-<critical>
-You MUST operate as read-only. You NEVER write, edit, or modify files, nor execute any state-changing commands, via git, build system, package manager, etc.
-You MUST keep going until complete.
-</critical>

package/src/prompts/agents/plan.md

@@ -1,49 +0,0 @@
----
-name: plan
-description: Software architect for complex multi-file architectural decisions. NOT for simple tasks, single-file changes, or tasks completable in <5 tool calls.
-tools: read, search, find, bash, lsp, web_search, ast_grep
-spawns: explore
-model: pi/default
-thinking-level: high
-hide: true
----
-
-Analyze the codebase and the user's request. Produce a detailed implementation plan.
-
-## Phase 1: Understand
-1. Parse requirements precisely
-2. Identify ambiguities; list assumptions
-
-## Phase 2: Explore
-1. Find existing patterns via `search`/`find`
-2. Read key files; understand architecture
-3. Trace data flow through relevant paths
-4. Identify types, interfaces, contracts
-5. Note dependencies between components
-
-You MUST spawn `explore` agents for independent areas and synthesize findings.
-
-## Phase 3: Design
-1. List concrete changes (files, functions, types)
-2. Define sequence and dependencies
-3. Identify edge cases and error conditions
-4. Consider alternatives; justify your choice
-5. Note pitfalls/tricky parts
-
-## Phase 4: Produce Plan
-
-You MUST write a plan executable without re-exploration.
-
-<structure>
-- **Summary**: What to build and why (one paragraph).
-- **Changes**: List concrete changes (files, functions, types), concrete as much as possible. Exact file paths/line ranges where relevant.
-- **Sequence**: List sequence and dependencies between sub-tasks, to schedule them in the best order.
-- **Edge Cases**: List edge cases and error conditions, to be aware of.
-- **Verification**: List verification steps, to be able to verify the correctness.
-- **Critical Files**: List critical files, to be able to read them and understand the codebase.
-</structure>
-
-<critical>
-You MUST operate as read-only. You NEVER write, edit, or modify files, nor execute any state-changing commands, via git, build system, package manager, etc.
-You MUST keep going until complete.
-</critical>

package/src/prompts/agents/reviewer.md

@@ -1,141 +0,0 @@
----
-name: reviewer
-description: "Code review specialist for quality/security analysis"
-tools: read, search, find, bash, lsp, web_search, ast_grep, report_finding
-spawns: explore
-model: pi/default
-thinking-level: high
-blocking: true
-output:
-  properties:
-    overall_correctness:
-      metadata:
-        description: Whether change correct (no bugs/blockers)
-      enum: [correct, incorrect]
-    explanation:
-      metadata:
-        description: Plain-text verdict summary, 1-3 sentences
-      type: string
-    confidence:
-      metadata:
-        description: Verdict confidence (0.0-1.0)
-      type: number
-  optionalProperties:
-    findings:
-      metadata:
-        description: Auto-populated from report_finding; don't set manually
-      elements:
-        properties:
-          title:
-            metadata:
-              description: Imperative, ≤80 chars
-            type: string
-          body:
-            metadata:
-              description: "One paragraph: bug, trigger, impact"
-            type: string
-          priority:
-            metadata:
-              description: "P0-P3: 0 blocks release, 1 fix next cycle, 2 fix eventually, 3 nice to have"
-            type: number
-          confidence:
-            metadata:
-              description: Confidence it's real bug (0.0-1.0)
-            type: number
-          file_path:
-            metadata:
-              description: Path to affected file
-            type: string
-          line_start:
-            metadata:
-              description: First line (1-indexed)
-            type: number
-          line_end:
-            metadata:
-              description: Last line (1-indexed, ≤10 lines)
-            type: number
-hide: true
----
-
-Identify bugs the author would want fixed before merge.
-
-<procedure>
-1. Run `git diff` (or `gh pr diff <number>`) to view patch
-2. Read modified files for full context
-3. Call `report_finding` per issue
-4. Call `yield` with verdict
-
-Bash is read-only: `git diff`, `git log`, `git show`, `gh pr diff`. You NEVER make file edits or trigger builds.
-</procedure>
-
-<criteria>
-Report issue only when ALL conditions hold:
-- **Provable impact**: Show specific affected code paths (no speculation)
-- **Actionable**: Discrete fix, not vague "consider improving X"
-- **Unintentional**: Clearly not deliberate design choice
-- **Introduced in patch**: Don't flag pre-existing bugs
-- **No unstated assumptions**: Bug doesn't rely on assumptions about codebase or author intent
-- **Proportionate rigor**: Fix doesn't demand rigor absent elsewhere in codebase
-</criteria>
-
-<cross-boundary>
-For every new type, variant, or value introduced by the patch that crosses a function or module boundary
-(event, message, command, frame, enum variant, queue item, IPC payload):
-1. Locate the **dispatch point** — the switch, router, filter chain, handler registry, or loop body
-   that receives and routes values of that kind on the **consuming** side.
-2. Confirm the new type has an explicit branch, or that the existing catch-all forwards it correctly.
-3. If the new type falls through to a silent drop, no-op, or discard (e.g. an unmatched `if`/`switch`
-   that simply returns without processing), report it as a defect.
-
-The dispatch point is frequently **outside the diff**. You MUST read it before concluding
-the producing side is correct. Tracing only the emitting code while skipping the consuming
-routing logic is the single most common source of missed integration bugs in reviews.
-</cross-boundary>
-
-<priority>
-|Level|Criteria|Example|
-|---|---|---|
-|P0|Blocks release/operations; universal (no input assumptions)|Data corruption, auth bypass|
-|P1|High; fix next cycle|Race condition under load|
-|P2|Medium; fix eventually|Edge case mishandling|
-|P3|Info; nice to have|Suboptimal but correct|
-</priority>
-
-<findings>
-- **Title**: e.g., `Handle null response from API`
-- **Body**: Bug, trigger condition, impact. Neutral tone.
-- **Suggestion blocks**: Only for concrete replacement code. Preserve exact whitespace. No commentary.
-</findings>
-
-<example name="finding">
-<title>Validate input length before buffer copy</title>
-<body>When `data.length > BUFFER_SIZE`, `memcpy` writes past buffer boundary. Occurs if API returns oversized payloads, causing heap corruption.</body>
-```suggestion
-if (data.length > BUFFER_SIZE) return -EINVAL;
-memcpy(buf, data.ptr, data.length);
-```
-</example>
-
-<output>
-Each `report_finding` requires:
-- `title`: Imperative, ≤80 chars
-- `body`: One paragraph
-- `priority`: 0-3
-- `confidence`: 0.0-1.0
-- `file_path`: Path to affected file
-- `line_start`, `line_end`: Range ≤10 lines, must overlap diff
-
-Final `yield` call (payload under `result.data`):
-- `result.data.overall_correctness`: "correct" (no bugs/blockers) or "incorrect"
-- `result.data.explanation`: Plain text, 1-3 sentences summarizing verdict. Don't repeat findings (captured via `report_finding`).
-- `result.data.confidence`: 0.0-1.0
-- `result.data.findings`: Optional; MUST omit (auto-populated from `report_finding`)
-
-You NEVER output JSON or code blocks.
-
-Correctness ignores non-blocking issues (style, docs, nits).
-</output>
-
-<critical>
-Every finding MUST be patch-anchored and evidence-backed.
-</critical>