@gajae-code/coding-agent 0.6.4 → 0.6.5

package/src/task/index.ts

@@ -55,7 +55,7 @@ import { assertNoRawTaskFields, buildTaskReceipt, buildTaskRoiSummary } from "./
 import { renderResult, renderCall as renderTaskCall } from "./render";
 import { reconcileSpawnRoi } from "./roi-reconciliation";
 import { getTaskSimpleModeCapabilities, type TaskSimpleMode } from "./simple-mode";
-import { DEFAULT_SPAWN_THRESHOLD, evaluateReviewerExploreGate, evaluateSpawnGate } from "./spawn-gate";
+import { DEFAULT_SPAWN_THRESHOLD, evaluateSpawnGate } from "./spawn-gate";
 import {
 	applyNestedPatches,
 	captureBaseline,
@@ -359,7 +359,6 @@ export class TaskTool implements AgentTool<TaskToolSchemaInstance, TaskToolDetai
 	readonly renderResult = renderResult;
 	readonly #discoveredAgents: AgentDefinition[];
 	readonly #blockedAgent: string | undefined;
-	readonly #spawningAgentType: string | undefined;
 
 	get parameters(): TaskToolSchemaInstance {
 		const isolationEnabled = this.session.settings.get("task.isolation.mode") !== "none";
@@ -391,7 +390,6 @@ export class TaskTool implements AgentTool<TaskToolSchemaInstance, TaskToolDetai
 		discoveredAgents: AgentDefinition[],
 	) {
 		this.#blockedAgent = $env.PI_BLOCKED_AGENT;
-		this.#spawningAgentType = session.currentAgentType;
 		this.#discoveredAgents = discoveredAgents;
 	}
 
@@ -478,23 +476,6 @@ export class TaskTool implements AgentTool<TaskToolSchemaInstance, TaskToolDetai
 			};
 		}
 
-		const reviewerExploreDecision = evaluateReviewerExploreGate({
-			spawningAgentType: this.#spawningAgentType,
-			targetAgent: params.agent,
-			plan: params.spawnPlan,
-		});
-		if (reviewerExploreDecision.outcome === "rejected") {
-			return {
-				content: [
-					{
-						type: "text",
-						text: `Task spawn gate rejected reviewer->explore: ${reviewerExploreDecision.reason}. Provide spawnPlan fields: ${reviewerExploreDecision.missingFields.join(", ")}.`,
-					},
-				],
-				details: { projectAgentsDir: null, results: [], totalDurationMs: 0 },
-			};
-		}
-
 		const manager = AsyncJobManager.instance();
 		if (!manager) {
 			return {
@@ -1083,27 +1064,6 @@ export class TaskTool implements AgentTool<TaskToolSchemaInstance, TaskToolDetai
 			};
 		}
 
-		const reviewerExploreDecision = evaluateReviewerExploreGate({
-			spawningAgentType: this.#spawningAgentType,
-			targetAgent: agentName,
-			plan: params.spawnPlan,
-		});
-		if (reviewerExploreDecision.outcome === "rejected") {
-			return {
-				content: [
-					{
-						type: "text",
-						text: `Task spawn gate rejected reviewer->explore: ${reviewerExploreDecision.reason}. Provide spawnPlan fields: ${reviewerExploreDecision.missingFields.join(", ")}.`,
-					},
-				],
-				details: {
-					projectAgentsDir,
-					results: [],
-					totalDurationMs: Date.now() - startTime,
-				},
-			};
-		}
-
 		let repoRoot: string | null = null;
 		let baseline: WorktreeBaseline | null = null;
 		if (isIsolated) {

package/src/task/spawn-gate.ts

@@ -1,7 +1,7 @@
 /** The hard, locked batch threshold enforced by the runtime gate. */
 export const DEFAULT_SPAWN_THRESHOLD = 4;
 
-/** The justification a large batch or reviewer-spawned explorer must supply to pass the hard gate. */
+/** The justification a large batch must supply to pass the hard gate. */
 export interface SpawnPlanReceipt {
 	whyParallel: string;
 	whyNotLocal: string;
@@ -17,15 +17,6 @@ export interface SpawnGateRequest {
 	plan?: SpawnPlanReceipt;
 }
 
-export interface ReviewerExploreGateRequest {
-	/** Agent type/name doing the spawning, when known. */
-	spawningAgentType?: string | null;
-	/** Target agent type/name requested by the task call. */
-	targetAgent: string;
-	/** The spawn-plan receipt, when provided. */
-	plan?: SpawnPlanReceipt;
-}
-
 export type SpawnGateOutcome = "allowed" | "rejected";
 
 export interface SpawnGateDecision {
@@ -102,31 +93,3 @@ export function decide(childCount: number, threshold: number, plan: SpawnPlanRec
 export function evaluateSpawnGate(request: SpawnGateRequest): SpawnGateDecision {
 	return decide(request.childCount, DEFAULT_SPAWN_THRESHOLD, request.plan);
 }
-
-export function evaluateReviewerExploreGate(request: ReviewerExploreGateRequest): SpawnGateDecision {
-	if (request.spawningAgentType !== "reviewer" || request.targetAgent !== "explore") {
-		return {
-			outcome: "allowed",
-			reason: "reviewer->explore gate does not apply",
-			planRequired: false,
-			missingFields: [],
-		};
-	}
-
-	const missingFields = findMissingPlanFields(request.plan);
-	if (missingFields.length > 0) {
-		return {
-			outcome: "rejected",
-			reason: `reviewer->explore spawn requires a complete spawn-plan receipt (${missingFields.join(", ")})`,
-			planRequired: true,
-			missingFields,
-		};
-	}
-
-	return {
-		outcome: "allowed",
-		reason: "reviewer->explore spawn has a complete spawn-plan receipt",
-		planRequired: true,
-		missingFields: [],
-	};
-}

package/src/task/types.ts

@@ -72,7 +72,7 @@ const spawnPlanSchema = z
 		expectedReceiptShape: z.string(),
 		maxInlineTokens: z.number(),
 	})
-	.describe("justification required before spawning more than four tasks or reviewer-spawned explore tasks");
+	.describe("justification required before spawning more than four tasks");
 
 const createTaskItemSchema = (_contextEnabled: boolean) =>
 	z.object({

package/src/tools/ask.ts

@@ -34,7 +34,7 @@ import {
 	renderDeepInterviewAskQuestion,
 } from "../deep-interview/render-middleware";
 import type { RenderResultOptions } from "../extensibility/custom-tools/types";
-import { appendOrMergeDeepInterviewRound } from "../gjc-runtime/deep-interview-recorder";
+import { appendOrMergeDeepInterviewRound, syncDeepInterviewRecorderHud } from "../gjc-runtime/deep-interview-recorder";
 import { deepInterviewStatePath } from "../gjc-runtime/deep-interview-runtime";
 import { gateAnswerToResult, questionToGate } from "../modes/shared/agent-wire/deep-interview-gate";
 import { getMarkdownTheme, type Theme, theme } from "../modes/theme/theme";
@@ -104,6 +104,30 @@ export interface AskToolDetails {
 const OTHER_OPTION = "Other (type your own)";
 const RECOMMENDED_SUFFIX = " (Recommended)";
 const DEEP_INTERVIEW_SELECTOR_SCROLL_TITLE_ROWS = Number.MAX_SAFE_INTEGER;
+const DEEP_INTERVIEW_RECORDER_AWAIT_TIMEOUT_MS = 250;
+
+function errorMessage(error: unknown): string {
+	return error instanceof Error ? error.message : String(error);
+}
+
+async function awaitDeepInterviewRecorderPersistence(persistence: Promise<void>): Promise<void> {
+	let timeout: ReturnType<typeof setTimeout> | undefined;
+	try {
+		await Promise.race([
+			persistence,
+			new Promise<never>((_resolve, reject) => {
+				timeout = setTimeout(
+					() => reject(new Error(`timed out after ${DEEP_INTERVIEW_RECORDER_AWAIT_TIMEOUT_MS}ms`)),
+					DEEP_INTERVIEW_RECORDER_AWAIT_TIMEOUT_MS,
+				);
+			}),
+		]);
+	} catch (error) {
+		logger.warn(`ask: deep-interview round recording failed: ${errorMessage(error)}`);
+	} finally {
+		if (timeout) clearTimeout(timeout);
+	}
+}
 
 function getDoneOptionLabel(): string {
 	return `${theme.status.success} Done selecting`;
@@ -481,11 +505,11 @@ export class AskTool implements AgentTool<typeof askSchema, AskToolDetails> {
 	): Promise<void> {
 		const meta = q.deepInterview;
 		if (!meta) return;
-		try {
-			const cwd = this.session.cwd;
-			const sessionId = this.session.getSessionId?.() ?? undefined;
-			const statePath = deepInterviewStatePath(cwd, sessionId);
-			await appendOrMergeDeepInterviewRound(
+		const cwd = this.session.cwd;
+		const sessionId = this.session.getSessionId?.() ?? undefined;
+		const statePath = deepInterviewStatePath(cwd, sessionId);
+		await awaitDeepInterviewRecorderPersistence(
+			appendOrMergeDeepInterviewRound(
 				cwd,
 				statePath,
 				{
@@ -500,12 +524,10 @@ export class AskTool implements AgentTool<typeof askSchema, AskToolDetails> {
 					customInput,
 				},
 				{ sessionId },
-			);
-		} catch (error) {
-			logger.warn(
-				`ask: deep-interview round recording failed: ${error instanceof Error ? error.message : String(error)}`,
-			);
-		}
+			).then(async () => {
+				await syncDeepInterviewRecorderHud(cwd, statePath, sessionId);
+			}),
+		);
 	}
 
 	async execute(

package/src/tools/computer.ts

@@ -6,6 +6,7 @@ import type { ImageContent } from "@gajae-code/ai";
 import { prompt } from "@gajae-code/utils";
 import * as z from "zod/v4";
 import computerDescription from "../prompts/tools/computer.md" with { type: "text" };
+import { resizeImage } from "../utils/image-resize";
 import type { ToolSession } from "./index";
 import type { OutputMeta } from "./output-meta";
 import { ToolAbortError, ToolError, throwIfAborted } from "./tool-errors";
@@ -174,6 +175,11 @@ let platformOverrideForTests: NodeJS.Platform | undefined;
 let archOverrideForTests: NodeJS.Architecture | undefined;
 const screenshotFallbackDirs = new WeakMap<ToolSession, Promise<string>>();
 
+const COMPUTER_INLINE_SCREENSHOT_MAX_WIDTH = 1568;
+const COMPUTER_INLINE_SCREENSHOT_MAX_HEIGHT = 1568;
+const COMPUTER_INLINE_SCREENSHOT_PROVIDER_MAX_BYTES = 5 * 1024 * 1024;
+const COMPUTER_INLINE_SCREENSHOT_JPEG_QUALITY = 70;
+
 export function setComputerControllerFactoryForTests(factory: ComputerControllerFactory | undefined): void {
 	controllerFactory = factory ?? createNativeComputerController;
 }
@@ -278,6 +284,9 @@ export class ComputerTool implements AgentTool<typeof computerSchema, ComputerTo
 				if (batchResult.failedStep) {
 					details.code = batchResult.failedStep.code;
 					details.message = batchResult.failedStep.message;
+					if (batchResult.screenshotSource !== undefined) {
+						await persistScreenshotFallback(batchResult.screenshotSource, details.screenshot, this.session);
+					}
 					await writeComputerAuditLog(this.session, details);
 					return {
 						...toolResult(details).text(`${details.code}: ${details.message}`).done(),
@@ -285,11 +294,11 @@ export class ComputerTool implements AgentTool<typeof computerSchema, ComputerTo
 					};
 				}
 				details.message = describeComputerSuccess(details);
-				const image = imageContentFromNativeResult(batchResult.screenshotSource);
 				if (batchResult.screenshotSource !== undefined) {
 					await persistScreenshotFallback(batchResult.screenshotSource, details.screenshot, this.session);
 					details.message = describeComputerSuccess(details);
 				}
+				const image = await inlineImageContentFromNativeResult(batchResult.screenshotSource, details, this.session);
 				await writeComputerAuditLog(this.session, details);
 				return image
 					? toolResult(details)
@@ -302,11 +311,11 @@ export class ComputerTool implements AgentTool<typeof computerSchema, ComputerTo
 			if (screenshot) details.screenshot = screenshot;
 			details.status = "success";
 			details.message = describeComputerSuccess(details);
-			const image = imageContentFromNativeResult(result);
 			if (screenshot) {
 				await persistScreenshotFallback(result, details.screenshot, this.session);
 				details.message = describeComputerSuccess(details);
 			}
+			const image = await inlineImageContentFromNativeResult(result, details, this.session);
 			await writeComputerAuditLog(this.session, details);
 			return image
 				? toolResult(details)
@@ -472,7 +481,7 @@ function normalizeScreenshot(value: unknown): ComputerScreenshotDetails | undefi
 	};
 }
 
-function imageContentFromNativeResult(value: unknown): ImageContent | undefined {
+function fullResolutionImageContentFromNativeResult(value: unknown): ImageContent | undefined {
 	const candidate =
 		value && typeof value === "object" && "screenshot" in value
 			? (value as { screenshot?: unknown }).screenshot
@@ -483,13 +492,42 @@ function imageContentFromNativeResult(value: unknown): ImageContent | undefined
 	return data ? { type: "image", data, mimeType: "image/png" } : undefined;
 }
 
+async function inlineImageContentFromNativeResult(
+	value: unknown,
+	details: ComputerToolDetails,
+	session: ToolSession,
+): Promise<ImageContent | undefined> {
+	const image = fullResolutionImageContentFromNativeResult(value);
+	if (!image) return undefined;
+	const maxBytes = getInlineScreenshotMaxBytes(session);
+	const originalBytes = Buffer.byteLength(image.data, "base64");
+	if (originalBytes <= maxBytes) return image;
+
+	try {
+		const resized = await resizeImage(image, {
+			maxWidth: COMPUTER_INLINE_SCREENSHOT_MAX_WIDTH,
+			maxHeight: COMPUTER_INLINE_SCREENSHOT_MAX_HEIGHT,
+			maxBytes,
+			jpegQuality: COMPUTER_INLINE_SCREENSHOT_JPEG_QUALITY,
+		});
+		if (resized.buffer.length <= maxBytes) {
+			return { type: "image", data: resized.data, mimeType: resized.mimeType };
+		}
+	} catch {
+		// Keep the action successful and rely on the full-resolution artifact path below.
+	}
+
+	details.message = `${details.message} Inline screenshot omitted because it could not be bounded below ${formatByteCount(maxBytes)}; use the saved screenshot artifact instead.`;
+	return undefined;
+}
+
 async function persistScreenshotFallback(
 	value: unknown,
 	screenshot: ComputerScreenshotDetails | undefined,
 	session: ToolSession,
 ): Promise<void> {
 	if (!screenshot || screenshot.path) return;
-	const image = imageContentFromNativeResult(value);
+	const image = fullResolutionImageContentFromNativeResult(value);
 	if (!image) return;
 	const dir = await getScreenshotFallbackDir(session);
 	const filePath = path.join(dir, `computer-${Date.now()}-${Math.random().toString(36).slice(2)}.png`);
@@ -526,6 +564,22 @@ function getPngByteLength(png: NativeScreenshot["png"]): number | undefined {
 	return png.byteLength;
 }
 
+function getInlineScreenshotMaxBytes(session: Pick<ToolSession, "settings">): number {
+	const configured = Number(session.settings.get("computer.screenshotMaxBytes"));
+	const finiteConfigured =
+		Number.isFinite(configured) && configured > 0
+			? Math.floor(configured)
+			: COMPUTER_INLINE_SCREENSHOT_PROVIDER_MAX_BYTES;
+	return Math.min(finiteConfigured, COMPUTER_INLINE_SCREENSHOT_PROVIDER_MAX_BYTES);
+}
+
+function formatByteCount(bytes: number): string {
+	if (bytes < 1024) return `${bytes} bytes`;
+	const kib = bytes / 1024;
+	if (kib < 1024) return `${Math.round(kib)} KiB`;
+	return `${(kib / 1024).toFixed(1)} MiB`;
+}
+
 function mapComputerError(error: unknown, hotkey?: string): { code: string; message: string } {
 	if (error instanceof Error && (error.name === "AbortError" || error.name === "TimeoutError")) {
 		return {

package/dist/types/extensibility/custom-commands/bundled/review/index.d.ts

@@ -1,10 +0,0 @@
-import type { CustomCommand, CustomCommandAPI } from "../../../../extensibility/custom-commands/types";
-import type { HookCommandContext } from "../../../../extensibility/hooks/types";
-export declare class ReviewCommand implements CustomCommand {
-    private api;
-    name: string;
-    description: string;
-    constructor(api: CustomCommandAPI);
-    execute(args: string[], ctx: HookCommandContext): Promise<string | undefined>;
-}
-export default ReviewCommand;