@futdevpro/dynamo-eslint 1.15.25 → 1.20.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (146) hide show
  1. package/.c8rc.json +26 -26
  2. package/.cursor/rules/__assistant_guide.mdc +30 -30
  3. package/.cursor/rules/__main.mdc +64 -64
  4. package/.cursor/rules/_ag_backend-structure.mdc +85 -85
  5. package/.cursor/rules/_ag_backend.mdc +16 -16
  6. package/.cursor/rules/_ag_debug.mdc +7 -7
  7. package/.cursor/rules/_ag_documentation_writing_rules.mdc +372 -372
  8. package/.cursor/rules/_ag_file-refactoring.mdc +113 -113
  9. package/.cursor/rules/_ag_fixes_rules.mdc +5 -5
  10. package/.cursor/rules/_ag_frontend-structure.mdc +86 -86
  11. package/.cursor/rules/_ag_frontend.mdc +39 -39
  12. package/.cursor/rules/_ag_import-rules.mdc +44 -44
  13. package/.cursor/rules/_ag_naming.mdc +115 -115
  14. package/.cursor/rules/_ag_running_commands.mdc +4 -4
  15. package/.cursor/rules/_ag_server-controller.mdc +5 -5
  16. package/.cursor/rules/_ag_should-be.mdc +6 -6
  17. package/.cursor/rules/_ag_swearing.mdc +47 -47
  18. package/.cursor/rules/ai_development_guide.md +60 -60
  19. package/.cursor/rules/ai_directives.md +114 -114
  20. package/.cursor/rules/cursor-rules.md +160 -160
  21. package/.cursor/rules/default-command.mdc +464 -464
  22. package/.cursor/rules/error_code_pattern.md +39 -39
  23. package/.cursor/rules/saved rule mcp server use.md +15 -15
  24. package/.dynamo/pipeline.cicd.config.json +184 -184
  25. package/.dynamo/version-bump.config.json +5 -5
  26. package/.eslintrc.json +4 -4
  27. package/.github/workflows/main.yml +436 -436
  28. package/.husky/pre-commit +2 -2
  29. package/.vscode/settings.json +11 -11
  30. package/README.md +312 -315
  31. package/__documentations/2026-04-18-ccap-review-integration.md +173 -173
  32. package/__documentations/2026-08-18-bfr-ctm-005-eslint9-validator-report.md +45 -0
  33. package/__documentations/2026-08-22-angular-20-phase2-release.md +79 -0
  34. package/build/configs/base.d.ts +1 -2
  35. package/build/configs/base.d.ts.map +1 -1
  36. package/build/configs/base.js +3 -4
  37. package/build/configs/base.js.map +1 -1
  38. package/build/configs/ngx.d.ts +1 -3
  39. package/build/configs/ngx.d.ts.map +1 -1
  40. package/build/configs/ngx.js +4 -7
  41. package/build/configs/ngx.js.map +1 -1
  42. package/build/plugin/index.d.ts +24 -24
  43. package/build/plugin/rules/no-getter-logic.js +1 -1
  44. package/build/plugin/rules/no-getter-logic.js.map +1 -1
  45. package/build/plugin/rules/prefer-enum-over-string-union.js +7 -7
  46. package/build/plugin/rules/prefer-enum-over-string-union.js.map +1 -1
  47. package/build/plugin/rules/prefer-interface-over-duplicate-types.js +2 -2
  48. package/build/plugin/rules/prefer-interface-over-duplicate-types.js.map +1 -1
  49. package/build/plugin/rules/require-jsdoc-description.js +7 -7
  50. package/build/plugin/rules/require-jsdoc-description.js.map +1 -1
  51. package/build/scripts/dynamo-fix.js +1 -1
  52. package/build/scripts/dynamo-fix.js.map +1 -1
  53. package/build/scripts/fix-return-types.d.ts.map +1 -1
  54. package/build/scripts/fix-return-types.js.map +1 -1
  55. package/build/scripts/validate-imports.js +51 -27
  56. package/build/scripts/validate-imports.js.map +1 -1
  57. package/build/scripts/validate-naming.js +49 -10
  58. package/build/scripts/validate-naming.js.map +1 -1
  59. package/eslint.config.js +15 -15
  60. package/package.json +27 -28
  61. package/pnpm-workspace.yaml +2 -0
  62. package/samples/.vscode/settings.json +13 -13
  63. package/samples/base/.eslintrc.json +6 -6
  64. package/samples/base/eslint.config.js +3 -3
  65. package/samples/fsm/.eslintrc.json +4 -4
  66. package/samples/fsm/eslint.config.js +3 -3
  67. package/samples/ngx/.eslintrc.json +6 -6
  68. package/samples/ngx/eslint.config.js +3 -3
  69. package/samples/ngx-package/.eslintrc.json +4 -4
  70. package/samples/ngx-package/eslint.config.js +3 -3
  71. package/samples/nts/.eslintrc.json +6 -6
  72. package/samples/nts/eslint.config.js +3 -3
  73. package/samples/nts-package/.eslintrc.json +4 -4
  74. package/samples/nts-package/eslint.config.js +3 -3
  75. package/samples/package.json.example +22 -26
  76. package/samples/poc-sample.ts +38 -38
  77. package/samples/poc-violations.ts +54 -54
  78. package/scripts/run-coverage-tests.js +24 -24
  79. package/spec/support/helpers/ts-node-helper.js +9 -9
  80. package/spec/support/jasmine.coverage.json +23 -23
  81. package/spec/support/jasmine.json +24 -24
  82. package/src/configs/angular20-compatibility.spec.ts +62 -0
  83. package/src/configs/base.ts +156 -157
  84. package/src/configs/fsm.ts +10 -10
  85. package/src/configs/ngx-package.ts +10 -10
  86. package/src/configs/ngx.ts +92 -95
  87. package/src/configs/nts-package.ts +20 -20
  88. package/src/configs/nts.ts +34 -34
  89. package/src/index.ts +4 -4
  90. package/src/plugin/index.ts +86 -86
  91. package/src/plugin/rules/angular/angular-for-track-logic.spec.ts +44 -44
  92. package/src/plugin/rules/angular/angular-for-track-logic.ts +88 -88
  93. package/src/plugin/rules/angular/effect-signal-loop.spec.ts +89 -89
  94. package/src/plugin/rules/angular/effect-signal-loop.ts +125 -125
  95. package/src/plugin/rules/angular/no-async-ngoninit.spec.ts +50 -50
  96. package/src/plugin/rules/angular/no-async-ngoninit.ts +43 -43
  97. package/src/plugin/rules/angular/no-component-direct-api.spec.ts +78 -78
  98. package/src/plugin/rules/angular/no-component-direct-api.ts +82 -82
  99. package/src/plugin/rules/angular/no-method-call-in-template.spec.ts +63 -63
  100. package/src/plugin/rules/angular/no-method-call-in-template.ts +89 -89
  101. package/src/plugin/rules/angular/no-ngfor-directive.spec.ts +44 -44
  102. package/src/plugin/rules/angular/no-ngfor-directive.ts +62 -62
  103. package/src/plugin/rules/angular/no-ngif-directive.spec.ts +44 -44
  104. package/src/plugin/rules/angular/no-ngif-directive.ts +62 -62
  105. package/src/plugin/rules/explicit-types.spec.ts +190 -190
  106. package/src/plugin/rules/explicit-types.ts +186 -186
  107. package/src/plugin/rules/import/import-order.spec.ts +219 -219
  108. package/src/plugin/rules/import/import-order.ts +197 -197
  109. package/src/plugin/rules/import/no-import-type.spec.ts +69 -69
  110. package/src/plugin/rules/import/no-import-type.ts +46 -46
  111. package/src/plugin/rules/import/no-js-import.spec.ts +82 -82
  112. package/src/plugin/rules/import/no-js-import.ts +45 -45
  113. package/src/plugin/rules/naming-patterns.spec.ts +189 -189
  114. package/src/plugin/rules/naming-patterns.ts +426 -426
  115. package/src/plugin/rules/no-getter-logic.spec.ts +591 -591
  116. package/src/plugin/rules/no-getter-logic.ts +220 -220
  117. package/src/plugin/rules/prefer-enum-over-string-union.spec.ts +583 -583
  118. package/src/plugin/rules/prefer-enum-over-string-union.ts +333 -334
  119. package/src/plugin/rules/prefer-interface-over-duplicate-types.spec.ts +404 -404
  120. package/src/plugin/rules/prefer-interface-over-duplicate-types.ts +314 -314
  121. package/src/plugin/rules/require-jsdoc-description.spec.ts +779 -779
  122. package/src/plugin/rules/require-jsdoc-description.ts +572 -572
  123. package/src/plugin/rules/require-test-description-prefix.spec.ts +459 -459
  124. package/src/plugin/rules/require-test-description-prefix.ts +154 -154
  125. package/src/plugin/rules/ts/data-model-extends.spec.ts +84 -84
  126. package/src/plugin/rules/ts/data-model-extends.ts +100 -100
  127. package/src/plugin/rules/ts/no-any-type.spec.ts +28 -28
  128. package/src/plugin/rules/ts/no-any-type.ts +36 -36
  129. package/src/plugin/rules/ts/no-as-cast.spec.ts +51 -51
  130. package/src/plugin/rules/ts/no-as-cast.ts +51 -51
  131. package/src/plugin/rules/ts/no-dynamic-imports.spec.ts +54 -54
  132. package/src/plugin/rules/ts/no-dynamic-imports.ts +49 -49
  133. package/src/plugin/rules/ts/no-native-browser-dialogs.spec.ts +54 -54
  134. package/src/plugin/rules/ts/no-native-browser-dialogs.ts +84 -84
  135. package/src/plugin/rules/ts/no-plain-function-export.spec.ts +72 -72
  136. package/src/plugin/rules/ts/no-plain-function-export.ts +73 -73
  137. package/src/plugin/rules/ts/one-export-per-file.spec.ts +64 -64
  138. package/src/plugin/rules/ts/one-export-per-file.ts +77 -77
  139. package/src/scripts/dynamo-fix.ts +172 -172
  140. package/src/scripts/eslintrc-audit.ts +116 -116
  141. package/src/scripts/fix-return-types.spec.ts +65 -65
  142. package/src/scripts/fix-return-types.ts +286 -285
  143. package/src/scripts/validate-imports.ts +288 -257
  144. package/src/scripts/validate-naming.ts +209 -183
  145. package/src/scripts/validator-cli.integration.spec.ts +99 -0
  146. package/tsconfig.json +31 -31
@@ -1,404 +1,404 @@
1
- import preferInterfaceRule from './prefer-interface-over-duplicate-types';
2
-
3
- describe('| prefer-interface-over-duplicate-types', () => {
4
- it('| should be a valid ESLint rule', () => {
5
- expect(preferInterfaceRule.meta?.type).toBe('suggestion');
6
- expect(preferInterfaceRule.meta?.docs?.description).toContain('Suggest creating interfaces');
7
- // BFR-ADVENTOR-009 (2. lépcső): a forrás-megőrző fixer VISSZAKAPCSOLVA auto-fix-re (érvényes kódot ad).
8
- expect(preferInterfaceRule.meta?.fixable).toBe('code');
9
- });
10
-
11
- it('| should have create function that returns visitor object', () => {
12
- const mockContext = {
13
- report: () => {},
14
- options: [{ threshold: 3 }],
15
- sourceCode: {
16
- getText: () => '',
17
- getScope: () => ({ variables: [] }),
18
- ast: { body: [] },
19
- },
20
- } as any;
21
-
22
- const result = preferInterfaceRule.create(mockContext);
23
-
24
- expect(typeof result).toBe('object');
25
- expect(typeof result.TSTypeLiteral).toBe('function');
26
- expect(typeof result['Program:exit']).toBe('function');
27
- });
28
-
29
- it('| should not report when object type is used less than threshold', () => {
30
- let reportCalled = false;
31
- const mockContext = {
32
- report: (options: any) => {
33
- reportCalled = true;
34
- },
35
- options: [{ threshold: 3 }],
36
- sourceCode: {
37
- getText: () => '{ name: string; age: number }',
38
- getScope: () => ({ variables: [] }),
39
- ast: { body: [] },
40
- },
41
- } as any;
42
-
43
- const rule = preferInterfaceRule.create(mockContext);
44
-
45
- // Simulate 2 usages (below threshold of 3)
46
- const mockNode1 = {
47
- type: 'TSTypeLiteral',
48
- members: [
49
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
50
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
51
- ],
52
- } as any;
53
-
54
- const mockNode2 = {
55
- type: 'TSTypeLiteral',
56
- members: [
57
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
58
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
59
- ],
60
- } as any;
61
-
62
- rule.TSTypeLiteral(mockNode1);
63
- rule.TSTypeLiteral(mockNode2);
64
- rule['Program:exit']({} as any);
65
-
66
- expect(reportCalled).toBe(false);
67
- });
68
-
69
- it('| should report when object type is used at or above threshold', () => {
70
- let reportCalled = false;
71
- const mockContext = {
72
- report: (options: any) => {
73
- reportCalled = true;
74
- expect(options.messageId).toBe('preferInterface');
75
- expect(options.data.count).toBe('3');
76
- expect(options.data.interfaceName).toContain('Interface');
77
- },
78
- options: [{ threshold: 3 }],
79
- sourceCode: {
80
- getText: () => '{ name: string; age: number }',
81
- getScope: () => ({ variables: [] }),
82
- ast: { body: [] },
83
- },
84
- } as any;
85
-
86
- const rule = preferInterfaceRule.create(mockContext);
87
-
88
- // Simulate 3 usages (at threshold)
89
- const mockNode = {
90
- type: 'TSTypeLiteral',
91
- members: [
92
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
93
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
94
- ],
95
- } as any;
96
-
97
- rule.TSTypeLiteral(mockNode);
98
- rule.TSTypeLiteral(mockNode);
99
- rule.TSTypeLiteral(mockNode);
100
- rule['Program:exit']({} as any);
101
-
102
- expect(reportCalled).toBe(true);
103
- });
104
-
105
- it('| should handle custom threshold', () => {
106
- let reportCalled = false;
107
- const mockContext = {
108
- report: (options: any) => {
109
- reportCalled = true;
110
- expect(options.data.count).toBe('2');
111
- },
112
- options: [{ threshold: 2 }],
113
- sourceCode: {
114
- getText: () => '{ name: string }',
115
- getScope: () => ({ variables: [] }),
116
- ast: { body: [] },
117
- },
118
- } as any;
119
-
120
- const rule = preferInterfaceRule.create(mockContext);
121
-
122
- const mockNode = {
123
- type: 'TSTypeLiteral',
124
- members: [
125
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
126
- ],
127
- } as any;
128
-
129
- rule.TSTypeLiteral(mockNode);
130
- rule.TSTypeLiteral(mockNode);
131
- rule['Program:exit']({} as any);
132
-
133
- expect(reportCalled).toBe(true);
134
- });
135
-
136
- it('| should handle structural equivalence (different property order)', () => {
137
- let reportCalled = false;
138
- const mockContext = {
139
- report: (options: any) => {
140
- reportCalled = true;
141
- expect(options.data.count).toBe('2');
142
- },
143
- options: [{ threshold: 2 }],
144
- sourceCode: {
145
- getText: () => '',
146
- getScope: () => ({ variables: [] }),
147
- ast: { body: [] },
148
- },
149
- } as any;
150
-
151
- const rule = preferInterfaceRule.create(mockContext);
152
-
153
- // First object: { name: string, age: number }
154
- const mockNode1 = {
155
- type: 'TSTypeLiteral',
156
- members: [
157
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
158
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
159
- ],
160
- } as any;
161
-
162
- // Second object: { age: number, name: string } (different order)
163
- const mockNode2 = {
164
- type: 'TSTypeLiteral',
165
- members: [
166
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
167
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
168
- ],
169
- } as any;
170
-
171
- rule.TSTypeLiteral(mockNode1);
172
- rule.TSTypeLiteral(mockNode2);
173
- rule['Program:exit']({} as any);
174
-
175
- expect(reportCalled).toBe(true);
176
- });
177
-
178
- it('| should handle optional properties', () => {
179
- let reportCalled = false;
180
- const mockContext = {
181
- report: (options: any) => {
182
- reportCalled = true;
183
- expect(options.data.count).toBe('2');
184
- },
185
- options: [{ threshold: 2 }],
186
- sourceCode: {
187
- getText: () => '',
188
- getScope: () => ({ variables: [] }),
189
- ast: { body: [] },
190
- },
191
- } as any;
192
-
193
- const rule = preferInterfaceRule.create(mockContext);
194
-
195
- const mockNode = {
196
- type: 'TSTypeLiteral',
197
- members: [
198
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } }, optional: true },
199
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
200
- ],
201
- } as any;
202
-
203
- rule.TSTypeLiteral(mockNode);
204
- rule.TSTypeLiteral(mockNode);
205
- rule['Program:exit']({} as any);
206
-
207
- expect(reportCalled).toBe(true);
208
- });
209
-
210
- it('| should handle readonly properties', () => {
211
- let reportCalled = false;
212
- const mockContext = {
213
- report: (options: any) => {
214
- reportCalled = true;
215
- expect(options.data.count).toBe('2');
216
- },
217
- options: [{ threshold: 2 }],
218
- sourceCode: {
219
- getText: () => '',
220
- getScope: () => ({ variables: [] }),
221
- ast: { body: [] },
222
- },
223
- } as any;
224
-
225
- const rule = preferInterfaceRule.create(mockContext);
226
-
227
- const mockNode = {
228
- type: 'TSTypeLiteral',
229
- members: [
230
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } }, readonly: true },
231
- { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
232
- ],
233
- } as any;
234
-
235
- rule.TSTypeLiteral(mockNode);
236
- rule.TSTypeLiteral(mockNode);
237
- rule['Program:exit']({} as any);
238
-
239
- expect(reportCalled).toBe(true);
240
- });
241
-
242
- it('| auto-fix a FORRÁS-SZÖVEGBŐL épít (BFR-ADVENTOR-009 2. lépcső: komplex típus megőrizve, nem `reference`)', () => {
243
- // egy komplex property-t szimulálunk: a member getText-je egy function-type — a régi lossy fixer
244
- // ezt `reference`/`complex`-re redukálta (érvénytelen TS); az új fixer EXAKT megőrzi.
245
- const complexMember: any = {
246
- type: 'TSPropertySignature', key: { name: 'onError' },
247
- };
248
- const numberMember: any = {
249
- type: 'TSPropertySignature', key: { name: 'count' },
250
- };
251
- const memberTexts: Map<any, string> = new Map([
252
- [ complexMember, 'onError: (e: Error) => void' ],
253
- [ numberMember, 'count: number' ],
254
- ]);
255
-
256
- let insertedText: string = '';
257
- const mockFixer: any = {
258
- insertTextAfterRange: (_range: unknown, text: string): unknown => { insertedText = text; return {}; },
259
- replaceText: (): unknown => ({}),
260
- };
261
-
262
- const mockContext = {
263
- report: (options: any) => {
264
- expect(typeof options.fix).toBe('function'); // auto-fix VISSZA (nem suggestion)
265
- options.fix(mockFixer);
266
- },
267
- options: [{ threshold: 2 }],
268
- sourceCode: {
269
- // a body-generátor a member-node getText-jét használja; a normalizáló getTypeString nem fut a fixerben
270
- getText: (n: any): string => memberTexts.get(n) ?? '{ onError: fn; count: number }',
271
- getScope: () => ({ variables: [] }),
272
- ast: { body: [] },
273
- },
274
- } as any;
275
-
276
- const rule = preferInterfaceRule.create(mockContext);
277
-
278
- const mockNode = {
279
- type: 'TSTypeLiteral',
280
- members: [
281
- { ...complexMember, typeAnnotation: { typeAnnotation: { type: 'TSFunctionType' } } },
282
- { ...numberMember, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
283
- ],
284
- } as any;
285
- // a getText a fenti two member-referenciákat kapja — a mockNode.members MÁSOK, ezért a getText-map
286
- // kulcsait használjuk a mockNode.members-ként:
287
- mockNode.members = [ complexMember, numberMember ];
288
-
289
- rule.TSTypeLiteral(mockNode);
290
- rule.TSTypeLiteral(mockNode);
291
- rule['Program:exit']({} as any);
292
-
293
- // a generált interface a MEGŐRZÖTT function-type-ot tartalmazza, NEM `reference`/`complex`-et
294
- expect(insertedText).toContain('onError: (e: Error) => void;');
295
- expect(insertedText).toContain('count: number;');
296
- expect(insertedText).not.toContain('reference');
297
- expect(insertedText).not.toContain('complex');
298
- });
299
-
300
- it('| should handle default threshold when no options provided', () => {
301
- let reportCalled = false;
302
- const mockContext = {
303
- report: (options: any) => {
304
- reportCalled = true;
305
- expect(options.data.count).toBe('3');
306
- },
307
- options: [],
308
- sourceCode: {
309
- getText: () => '',
310
- getScope: () => ({ variables: [] }),
311
- ast: { body: [] },
312
- },
313
- } as any;
314
-
315
- const rule = preferInterfaceRule.create(mockContext);
316
-
317
- const mockNode = {
318
- type: 'TSTypeLiteral',
319
- members: [
320
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
321
- ],
322
- } as any;
323
-
324
- rule.TSTypeLiteral(mockNode);
325
- rule.TSTypeLiteral(mockNode);
326
- rule.TSTypeLiteral(mockNode);
327
- rule['Program:exit']({} as any);
328
-
329
- expect(reportCalled).toBe(true);
330
- });
331
-
332
- it('| should handle complex nested types', () => {
333
- let reportCalled = false;
334
- const mockContext = {
335
- report: (options: any) => {
336
- reportCalled = true;
337
- expect(options.data.count).toBe('2');
338
- },
339
- options: [{ threshold: 2 }],
340
- sourceCode: {
341
- getText: () => '',
342
- getScope: () => ({ variables: [] }),
343
- ast: { body: [] },
344
- },
345
- } as any;
346
-
347
- const rule = preferInterfaceRule.create(mockContext);
348
-
349
- const mockNode = {
350
- type: 'TSTypeLiteral',
351
- members: [
352
- {
353
- type: 'TSPropertySignature',
354
- key: { name: 'user' },
355
- typeAnnotation: {
356
- typeAnnotation: {
357
- type: 'TSTypeLiteral',
358
- members: [
359
- { type: 'TSPropertySignature', key: { name: 'id' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
360
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
361
- ],
362
- },
363
- },
364
- },
365
- ],
366
- } as any;
367
-
368
- rule.TSTypeLiteral(mockNode);
369
- rule.TSTypeLiteral(mockNode);
370
- rule['Program:exit']({} as any);
371
-
372
- expect(reportCalled).toBe(true);
373
- });
374
-
375
- it('| should handle error cases gracefully', () => {
376
- const mockContext = {
377
- report: () => {},
378
- options: [{ threshold: 2 }],
379
- sourceCode: {
380
- getText: () => '',
381
- getScope: () => {
382
- throw new Error('Scope error');
383
- },
384
- ast: { body: [] },
385
- },
386
- } as any;
387
-
388
- const rule = preferInterfaceRule.create(mockContext);
389
-
390
- const mockNode = {
391
- type: 'TSTypeLiteral',
392
- members: [
393
- { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
394
- ],
395
- } as any;
396
-
397
- // Should not throw error
398
- expect(() => {
399
- rule.TSTypeLiteral(mockNode);
400
- rule.TSTypeLiteral(mockNode);
401
- rule['Program:exit']({} as any);
402
- }).not.toThrow();
403
- });
404
- });
1
+ import preferInterfaceRule from './prefer-interface-over-duplicate-types';
2
+
3
+ describe('| prefer-interface-over-duplicate-types', () => {
4
+ it('| should be a valid ESLint rule', () => {
5
+ expect(preferInterfaceRule.meta?.type).toBe('suggestion');
6
+ expect(preferInterfaceRule.meta?.docs?.description).toContain('Suggest creating interfaces');
7
+ // BFR-ADVENTOR-009 (2. lépcső): a forrás-megőrző fixer VISSZAKAPCSOLVA auto-fix-re (érvényes kódot ad).
8
+ expect(preferInterfaceRule.meta?.fixable).toBe('code');
9
+ });
10
+
11
+ it('| should have create function that returns visitor object', () => {
12
+ const mockContext = {
13
+ report: () => {},
14
+ options: [{ threshold: 3 }],
15
+ sourceCode: {
16
+ getText: () => '',
17
+ getScope: () => ({ variables: [] }),
18
+ ast: { body: [] },
19
+ },
20
+ } as any;
21
+
22
+ const result = preferInterfaceRule.create(mockContext);
23
+
24
+ expect(typeof result).toBe('object');
25
+ expect(typeof result.TSTypeLiteral).toBe('function');
26
+ expect(typeof result['Program:exit']).toBe('function');
27
+ });
28
+
29
+ it('| should not report when object type is used less than threshold', () => {
30
+ let reportCalled = false;
31
+ const mockContext = {
32
+ report: (options: any) => {
33
+ reportCalled = true;
34
+ },
35
+ options: [{ threshold: 3 }],
36
+ sourceCode: {
37
+ getText: () => '{ name: string; age: number }',
38
+ getScope: () => ({ variables: [] }),
39
+ ast: { body: [] },
40
+ },
41
+ } as any;
42
+
43
+ const rule = preferInterfaceRule.create(mockContext);
44
+
45
+ // Simulate 2 usages (below threshold of 3)
46
+ const mockNode1 = {
47
+ type: 'TSTypeLiteral',
48
+ members: [
49
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
50
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
51
+ ],
52
+ } as any;
53
+
54
+ const mockNode2 = {
55
+ type: 'TSTypeLiteral',
56
+ members: [
57
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
58
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
59
+ ],
60
+ } as any;
61
+
62
+ rule.TSTypeLiteral(mockNode1, undefined, undefined);
63
+ rule.TSTypeLiteral(mockNode2, undefined, undefined);
64
+ rule['Program:exit']({} as any);
65
+
66
+ expect(reportCalled).toBe(false);
67
+ });
68
+
69
+ it('| should report when object type is used at or above threshold', () => {
70
+ let reportCalled = false;
71
+ const mockContext = {
72
+ report: (options: any) => {
73
+ reportCalled = true;
74
+ expect(options.messageId).toBe('preferInterface');
75
+ expect(options.data.count).toBe('3');
76
+ expect(options.data.interfaceName).toContain('Interface');
77
+ },
78
+ options: [{ threshold: 3 }],
79
+ sourceCode: {
80
+ getText: () => '{ name: string; age: number }',
81
+ getScope: () => ({ variables: [] }),
82
+ ast: { body: [] },
83
+ },
84
+ } as any;
85
+
86
+ const rule = preferInterfaceRule.create(mockContext);
87
+
88
+ // Simulate 3 usages (at threshold)
89
+ const mockNode = {
90
+ type: 'TSTypeLiteral',
91
+ members: [
92
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
93
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
94
+ ],
95
+ } as any;
96
+
97
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
98
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
99
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
100
+ rule['Program:exit']({} as any);
101
+
102
+ expect(reportCalled).toBe(true);
103
+ });
104
+
105
+ it('| should handle custom threshold', () => {
106
+ let reportCalled = false;
107
+ const mockContext = {
108
+ report: (options: any) => {
109
+ reportCalled = true;
110
+ expect(options.data.count).toBe('2');
111
+ },
112
+ options: [{ threshold: 2 }],
113
+ sourceCode: {
114
+ getText: () => '{ name: string }',
115
+ getScope: () => ({ variables: [] }),
116
+ ast: { body: [] },
117
+ },
118
+ } as any;
119
+
120
+ const rule = preferInterfaceRule.create(mockContext);
121
+
122
+ const mockNode = {
123
+ type: 'TSTypeLiteral',
124
+ members: [
125
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
126
+ ],
127
+ } as any;
128
+
129
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
130
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
131
+ rule['Program:exit']({} as any);
132
+
133
+ expect(reportCalled).toBe(true);
134
+ });
135
+
136
+ it('| should handle structural equivalence (different property order)', () => {
137
+ let reportCalled = false;
138
+ const mockContext = {
139
+ report: (options: any) => {
140
+ reportCalled = true;
141
+ expect(options.data.count).toBe('2');
142
+ },
143
+ options: [{ threshold: 2 }],
144
+ sourceCode: {
145
+ getText: () => '',
146
+ getScope: () => ({ variables: [] }),
147
+ ast: { body: [] },
148
+ },
149
+ } as any;
150
+
151
+ const rule = preferInterfaceRule.create(mockContext);
152
+
153
+ // First object: { name: string, age: number }
154
+ const mockNode1 = {
155
+ type: 'TSTypeLiteral',
156
+ members: [
157
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
158
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
159
+ ],
160
+ } as any;
161
+
162
+ // Second object: { age: number, name: string } (different order)
163
+ const mockNode2 = {
164
+ type: 'TSTypeLiteral',
165
+ members: [
166
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
167
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
168
+ ],
169
+ } as any;
170
+
171
+ rule.TSTypeLiteral(mockNode1, undefined, undefined);
172
+ rule.TSTypeLiteral(mockNode2, undefined, undefined);
173
+ rule['Program:exit']({} as any);
174
+
175
+ expect(reportCalled).toBe(true);
176
+ });
177
+
178
+ it('| should handle optional properties', () => {
179
+ let reportCalled = false;
180
+ const mockContext = {
181
+ report: (options: any) => {
182
+ reportCalled = true;
183
+ expect(options.data.count).toBe('2');
184
+ },
185
+ options: [{ threshold: 2 }],
186
+ sourceCode: {
187
+ getText: () => '',
188
+ getScope: () => ({ variables: [] }),
189
+ ast: { body: [] },
190
+ },
191
+ } as any;
192
+
193
+ const rule = preferInterfaceRule.create(mockContext);
194
+
195
+ const mockNode = {
196
+ type: 'TSTypeLiteral',
197
+ members: [
198
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } }, optional: true },
199
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
200
+ ],
201
+ } as any;
202
+
203
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
204
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
205
+ rule['Program:exit']({} as any);
206
+
207
+ expect(reportCalled).toBe(true);
208
+ });
209
+
210
+ it('| should handle readonly properties', () => {
211
+ let reportCalled = false;
212
+ const mockContext = {
213
+ report: (options: any) => {
214
+ reportCalled = true;
215
+ expect(options.data.count).toBe('2');
216
+ },
217
+ options: [{ threshold: 2 }],
218
+ sourceCode: {
219
+ getText: () => '',
220
+ getScope: () => ({ variables: [] }),
221
+ ast: { body: [] },
222
+ },
223
+ } as any;
224
+
225
+ const rule = preferInterfaceRule.create(mockContext);
226
+
227
+ const mockNode = {
228
+ type: 'TSTypeLiteral',
229
+ members: [
230
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } }, readonly: true },
231
+ { type: 'TSPropertySignature', key: { name: 'age' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
232
+ ],
233
+ } as any;
234
+
235
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
236
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
237
+ rule['Program:exit']({} as any);
238
+
239
+ expect(reportCalled).toBe(true);
240
+ });
241
+
242
+ it('| auto-fix a FORRÁS-SZÖVEGBŐL épít (BFR-ADVENTOR-009 2. lépcső: komplex típus megőrizve, nem `reference`)', () => {
243
+ // egy komplex property-t szimulálunk: a member getText-je egy function-type — a régi lossy fixer
244
+ // ezt `reference`/`complex`-re redukálta (érvénytelen TS); az új fixer EXAKT megőrzi.
245
+ const complexMember: any = {
246
+ type: 'TSPropertySignature', key: { name: 'onError' },
247
+ };
248
+ const numberMember: any = {
249
+ type: 'TSPropertySignature', key: { name: 'count' },
250
+ };
251
+ const memberTexts: Map<any, string> = new Map([
252
+ [ complexMember, 'onError: (e: Error) => void' ],
253
+ [ numberMember, 'count: number' ],
254
+ ]);
255
+
256
+ let insertedText: string = '';
257
+ const mockFixer: any = {
258
+ insertTextAfterRange: (_range: unknown, text: string): unknown => { insertedText = text; return {}; },
259
+ replaceText: (): unknown => ({}),
260
+ };
261
+
262
+ const mockContext = {
263
+ report: (options: any) => {
264
+ expect(typeof options.fix).toBe('function'); // auto-fix VISSZA (nem suggestion)
265
+ options.fix(mockFixer);
266
+ },
267
+ options: [{ threshold: 2 }],
268
+ sourceCode: {
269
+ // a body-generátor a member-node getText-jét használja; a normalizáló getTypeString nem fut a fixerben
270
+ getText: (n: any): string => memberTexts.get(n) ?? '{ onError: fn; count: number }',
271
+ getScope: () => ({ variables: [] }),
272
+ ast: { body: [] },
273
+ },
274
+ } as any;
275
+
276
+ const rule = preferInterfaceRule.create(mockContext);
277
+
278
+ const mockNode = {
279
+ type: 'TSTypeLiteral',
280
+ members: [
281
+ { ...complexMember, typeAnnotation: { typeAnnotation: { type: 'TSFunctionType' } } },
282
+ { ...numberMember, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
283
+ ],
284
+ } as any;
285
+ // a getText a fenti two member-referenciákat kapja — a mockNode.members MÁSOK, ezért a getText-map
286
+ // kulcsait használjuk a mockNode.members-ként:
287
+ mockNode.members = [ complexMember, numberMember ];
288
+
289
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
290
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
291
+ rule['Program:exit']({} as any);
292
+
293
+ // a generált interface a MEGŐRZÖTT function-type-ot tartalmazza, NEM `reference`/`complex`-et
294
+ expect(insertedText).toContain('onError: (e: Error) => void;');
295
+ expect(insertedText).toContain('count: number;');
296
+ expect(insertedText).not.toContain('reference');
297
+ expect(insertedText).not.toContain('complex');
298
+ });
299
+
300
+ it('| should handle default threshold when no options provided', () => {
301
+ let reportCalled = false;
302
+ const mockContext = {
303
+ report: (options: any) => {
304
+ reportCalled = true;
305
+ expect(options.data.count).toBe('3');
306
+ },
307
+ options: [],
308
+ sourceCode: {
309
+ getText: () => '',
310
+ getScope: () => ({ variables: [] }),
311
+ ast: { body: [] },
312
+ },
313
+ } as any;
314
+
315
+ const rule = preferInterfaceRule.create(mockContext);
316
+
317
+ const mockNode = {
318
+ type: 'TSTypeLiteral',
319
+ members: [
320
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
321
+ ],
322
+ } as any;
323
+
324
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
325
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
326
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
327
+ rule['Program:exit']({} as any);
328
+
329
+ expect(reportCalled).toBe(true);
330
+ });
331
+
332
+ it('| should handle complex nested types', () => {
333
+ let reportCalled = false;
334
+ const mockContext = {
335
+ report: (options: any) => {
336
+ reportCalled = true;
337
+ expect(options.data.count).toBe('2');
338
+ },
339
+ options: [{ threshold: 2 }],
340
+ sourceCode: {
341
+ getText: () => '',
342
+ getScope: () => ({ variables: [] }),
343
+ ast: { body: [] },
344
+ },
345
+ } as any;
346
+
347
+ const rule = preferInterfaceRule.create(mockContext);
348
+
349
+ const mockNode = {
350
+ type: 'TSTypeLiteral',
351
+ members: [
352
+ {
353
+ type: 'TSPropertySignature',
354
+ key: { name: 'user' },
355
+ typeAnnotation: {
356
+ typeAnnotation: {
357
+ type: 'TSTypeLiteral',
358
+ members: [
359
+ { type: 'TSPropertySignature', key: { name: 'id' }, typeAnnotation: { typeAnnotation: { type: 'TSNumberKeyword' } } },
360
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
361
+ ],
362
+ },
363
+ },
364
+ },
365
+ ],
366
+ } as any;
367
+
368
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
369
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
370
+ rule['Program:exit']({} as any);
371
+
372
+ expect(reportCalled).toBe(true);
373
+ });
374
+
375
+ it('| should handle error cases gracefully', () => {
376
+ const mockContext = {
377
+ report: () => {},
378
+ options: [{ threshold: 2 }],
379
+ sourceCode: {
380
+ getText: () => '',
381
+ getScope: () => {
382
+ throw new Error('Scope error');
383
+ },
384
+ ast: { body: [] },
385
+ },
386
+ } as any;
387
+
388
+ const rule = preferInterfaceRule.create(mockContext);
389
+
390
+ const mockNode = {
391
+ type: 'TSTypeLiteral',
392
+ members: [
393
+ { type: 'TSPropertySignature', key: { name: 'name' }, typeAnnotation: { typeAnnotation: { type: 'TSStringKeyword' } } },
394
+ ],
395
+ } as any;
396
+
397
+ // Should not throw error
398
+ expect(() => {
399
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
400
+ rule.TSTypeLiteral(mockNode, undefined, undefined);
401
+ rule['Program:exit']({} as any);
402
+ }).not.toThrow();
403
+ });
404
+ });