@futdevpro/dynamo-eslint 1.15.25 → 1.20.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.c8rc.json +26 -26
- package/.cursor/rules/__assistant_guide.mdc +30 -30
- package/.cursor/rules/__main.mdc +64 -64
- package/.cursor/rules/_ag_backend-structure.mdc +85 -85
- package/.cursor/rules/_ag_backend.mdc +16 -16
- package/.cursor/rules/_ag_debug.mdc +7 -7
- package/.cursor/rules/_ag_documentation_writing_rules.mdc +372 -372
- package/.cursor/rules/_ag_file-refactoring.mdc +113 -113
- package/.cursor/rules/_ag_fixes_rules.mdc +5 -5
- package/.cursor/rules/_ag_frontend-structure.mdc +86 -86
- package/.cursor/rules/_ag_frontend.mdc +39 -39
- package/.cursor/rules/_ag_import-rules.mdc +44 -44
- package/.cursor/rules/_ag_naming.mdc +115 -115
- package/.cursor/rules/_ag_running_commands.mdc +4 -4
- package/.cursor/rules/_ag_server-controller.mdc +5 -5
- package/.cursor/rules/_ag_should-be.mdc +6 -6
- package/.cursor/rules/_ag_swearing.mdc +47 -47
- package/.cursor/rules/ai_development_guide.md +60 -60
- package/.cursor/rules/ai_directives.md +114 -114
- package/.cursor/rules/cursor-rules.md +160 -160
- package/.cursor/rules/default-command.mdc +464 -464
- package/.cursor/rules/error_code_pattern.md +39 -39
- package/.cursor/rules/saved rule mcp server use.md +15 -15
- package/.dynamo/pipeline.cicd.config.json +184 -184
- package/.dynamo/version-bump.config.json +5 -5
- package/.eslintrc.json +4 -4
- package/.github/workflows/main.yml +436 -436
- package/.husky/pre-commit +2 -2
- package/.vscode/settings.json +11 -11
- package/README.md +312 -315
- package/__documentations/2026-04-18-ccap-review-integration.md +173 -173
- package/__documentations/2026-08-18-bfr-ctm-005-eslint9-validator-report.md +45 -0
- package/__documentations/2026-08-22-angular-20-phase2-release.md +79 -0
- package/build/configs/base.d.ts +1 -2
- package/build/configs/base.d.ts.map +1 -1
- package/build/configs/base.js +3 -4
- package/build/configs/base.js.map +1 -1
- package/build/configs/ngx.d.ts +1 -3
- package/build/configs/ngx.d.ts.map +1 -1
- package/build/configs/ngx.js +4 -7
- package/build/configs/ngx.js.map +1 -1
- package/build/plugin/index.d.ts +24 -24
- package/build/plugin/rules/no-getter-logic.js +1 -1
- package/build/plugin/rules/no-getter-logic.js.map +1 -1
- package/build/plugin/rules/prefer-enum-over-string-union.js +7 -7
- package/build/plugin/rules/prefer-enum-over-string-union.js.map +1 -1
- package/build/plugin/rules/prefer-interface-over-duplicate-types.js +2 -2
- package/build/plugin/rules/prefer-interface-over-duplicate-types.js.map +1 -1
- package/build/plugin/rules/require-jsdoc-description.js +7 -7
- package/build/plugin/rules/require-jsdoc-description.js.map +1 -1
- package/build/scripts/dynamo-fix.js +1 -1
- package/build/scripts/dynamo-fix.js.map +1 -1
- package/build/scripts/fix-return-types.d.ts.map +1 -1
- package/build/scripts/fix-return-types.js.map +1 -1
- package/build/scripts/validate-imports.js +51 -27
- package/build/scripts/validate-imports.js.map +1 -1
- package/build/scripts/validate-naming.js +49 -10
- package/build/scripts/validate-naming.js.map +1 -1
- package/eslint.config.js +15 -15
- package/package.json +27 -28
- package/pnpm-workspace.yaml +2 -0
- package/samples/.vscode/settings.json +13 -13
- package/samples/base/.eslintrc.json +6 -6
- package/samples/base/eslint.config.js +3 -3
- package/samples/fsm/.eslintrc.json +4 -4
- package/samples/fsm/eslint.config.js +3 -3
- package/samples/ngx/.eslintrc.json +6 -6
- package/samples/ngx/eslint.config.js +3 -3
- package/samples/ngx-package/.eslintrc.json +4 -4
- package/samples/ngx-package/eslint.config.js +3 -3
- package/samples/nts/.eslintrc.json +6 -6
- package/samples/nts/eslint.config.js +3 -3
- package/samples/nts-package/.eslintrc.json +4 -4
- package/samples/nts-package/eslint.config.js +3 -3
- package/samples/package.json.example +22 -26
- package/samples/poc-sample.ts +38 -38
- package/samples/poc-violations.ts +54 -54
- package/scripts/run-coverage-tests.js +24 -24
- package/spec/support/helpers/ts-node-helper.js +9 -9
- package/spec/support/jasmine.coverage.json +23 -23
- package/spec/support/jasmine.json +24 -24
- package/src/configs/angular20-compatibility.spec.ts +62 -0
- package/src/configs/base.ts +156 -157
- package/src/configs/fsm.ts +10 -10
- package/src/configs/ngx-package.ts +10 -10
- package/src/configs/ngx.ts +92 -95
- package/src/configs/nts-package.ts +20 -20
- package/src/configs/nts.ts +34 -34
- package/src/index.ts +4 -4
- package/src/plugin/index.ts +86 -86
- package/src/plugin/rules/angular/angular-for-track-logic.spec.ts +44 -44
- package/src/plugin/rules/angular/angular-for-track-logic.ts +88 -88
- package/src/plugin/rules/angular/effect-signal-loop.spec.ts +89 -89
- package/src/plugin/rules/angular/effect-signal-loop.ts +125 -125
- package/src/plugin/rules/angular/no-async-ngoninit.spec.ts +50 -50
- package/src/plugin/rules/angular/no-async-ngoninit.ts +43 -43
- package/src/plugin/rules/angular/no-component-direct-api.spec.ts +78 -78
- package/src/plugin/rules/angular/no-component-direct-api.ts +82 -82
- package/src/plugin/rules/angular/no-method-call-in-template.spec.ts +63 -63
- package/src/plugin/rules/angular/no-method-call-in-template.ts +89 -89
- package/src/plugin/rules/angular/no-ngfor-directive.spec.ts +44 -44
- package/src/plugin/rules/angular/no-ngfor-directive.ts +62 -62
- package/src/plugin/rules/angular/no-ngif-directive.spec.ts +44 -44
- package/src/plugin/rules/angular/no-ngif-directive.ts +62 -62
- package/src/plugin/rules/explicit-types.spec.ts +190 -190
- package/src/plugin/rules/explicit-types.ts +186 -186
- package/src/plugin/rules/import/import-order.spec.ts +219 -219
- package/src/plugin/rules/import/import-order.ts +197 -197
- package/src/plugin/rules/import/no-import-type.spec.ts +69 -69
- package/src/plugin/rules/import/no-import-type.ts +46 -46
- package/src/plugin/rules/import/no-js-import.spec.ts +82 -82
- package/src/plugin/rules/import/no-js-import.ts +45 -45
- package/src/plugin/rules/naming-patterns.spec.ts +189 -189
- package/src/plugin/rules/naming-patterns.ts +426 -426
- package/src/plugin/rules/no-getter-logic.spec.ts +591 -591
- package/src/plugin/rules/no-getter-logic.ts +220 -220
- package/src/plugin/rules/prefer-enum-over-string-union.spec.ts +583 -583
- package/src/plugin/rules/prefer-enum-over-string-union.ts +333 -334
- package/src/plugin/rules/prefer-interface-over-duplicate-types.spec.ts +404 -404
- package/src/plugin/rules/prefer-interface-over-duplicate-types.ts +314 -314
- package/src/plugin/rules/require-jsdoc-description.spec.ts +779 -779
- package/src/plugin/rules/require-jsdoc-description.ts +572 -572
- package/src/plugin/rules/require-test-description-prefix.spec.ts +459 -459
- package/src/plugin/rules/require-test-description-prefix.ts +154 -154
- package/src/plugin/rules/ts/data-model-extends.spec.ts +84 -84
- package/src/plugin/rules/ts/data-model-extends.ts +100 -100
- package/src/plugin/rules/ts/no-any-type.spec.ts +28 -28
- package/src/plugin/rules/ts/no-any-type.ts +36 -36
- package/src/plugin/rules/ts/no-as-cast.spec.ts +51 -51
- package/src/plugin/rules/ts/no-as-cast.ts +51 -51
- package/src/plugin/rules/ts/no-dynamic-imports.spec.ts +54 -54
- package/src/plugin/rules/ts/no-dynamic-imports.ts +49 -49
- package/src/plugin/rules/ts/no-native-browser-dialogs.spec.ts +54 -54
- package/src/plugin/rules/ts/no-native-browser-dialogs.ts +84 -84
- package/src/plugin/rules/ts/no-plain-function-export.spec.ts +72 -72
- package/src/plugin/rules/ts/no-plain-function-export.ts +73 -73
- package/src/plugin/rules/ts/one-export-per-file.spec.ts +64 -64
- package/src/plugin/rules/ts/one-export-per-file.ts +77 -77
- package/src/scripts/dynamo-fix.ts +172 -172
- package/src/scripts/eslintrc-audit.ts +116 -116
- package/src/scripts/fix-return-types.spec.ts +65 -65
- package/src/scripts/fix-return-types.ts +286 -285
- package/src/scripts/validate-imports.ts +288 -257
- package/src/scripts/validate-naming.ts +209 -183
- package/src/scripts/validator-cli.integration.spec.ts +99 -0
- package/tsconfig.json +31 -31
|
@@ -1,89 +1,89 @@
|
|
|
1
|
-
import { Rule } from 'eslint';
|
|
2
|
-
|
|
3
|
-
/**
|
|
4
|
-
* Interpoláció metódushívás regex: `{{ ... method() ... }}`. Signal hívás (`_$()`) kizárva.
|
|
5
|
-
* Capture group 1: a hívott metódus neve.
|
|
6
|
-
*/
|
|
7
|
-
const INTERPOLATION_CALL_REGEX: RegExp =
|
|
8
|
-
/\{\{[^}]*\b([a-zA-Z_$][a-zA-Z0-9_$]*(?<!_\$))\s*\([^)]*\)[^}]*\}\}/g;
|
|
9
|
-
|
|
10
|
-
/**
|
|
11
|
-
* Property binding metódushívás regex: `[attr]="method()"`. Esemény binding `(event)="..."` kizárva.
|
|
12
|
-
*/
|
|
13
|
-
const PROPERTY_BINDING_CALL_REGEX: RegExp =
|
|
14
|
-
/\[[^\]]+\]="[^"]*\b[a-zA-Z_$][a-zA-Z0-9_$]*(?<!_\$)\s*\([^)]*\)[^"]*"/g;
|
|
15
|
-
|
|
16
|
-
/**
|
|
17
|
-
* Angular block (`@if`, `@switch`, `@case`, `@else if`) metódushívás regex.
|
|
18
|
-
*/
|
|
19
|
-
const BLOCK_CALL_REGEX: RegExp =
|
|
20
|
-
/@(?:if|switch|case|else if)\s*\([^)]*\b[a-zA-Z_$][a-zA-Z0-9_$]*(?<!_\$)\s*\([^)]*\)/g;
|
|
21
|
-
|
|
22
|
-
/**
|
|
23
|
-
* Adott offset alapján a sor és oszlop kiszámítása az alap szövegből.
|
|
24
|
-
*/
|
|
25
|
-
function computeLoc(text: string, index: number): { line: number; column: number } {
|
|
26
|
-
const before: string = text.substring(0, index);
|
|
27
|
-
const newlineMatches: RegExpMatchArray | null = before.match(/\n/g);
|
|
28
|
-
const line: number = (newlineMatches ? newlineMatches.length : 0) + 1;
|
|
29
|
-
const lastNewline: number = before.lastIndexOf('\n');
|
|
30
|
-
const column: number = lastNewline === -1 ? index : index - lastNewline - 1;
|
|
31
|
-
return { line: line, column: column };
|
|
32
|
-
}
|
|
33
|
-
|
|
34
|
-
/**
|
|
35
|
-
* No-method-call-in-template szabály: Angular template-ekben tilos metódust hívni
|
|
36
|
-
* adat megjelenítéshez. Megengedett: signal `mySignal_$()` és esemény `(click)="handler()"`.
|
|
37
|
-
* CCAP "no-method-call-in-template" review ESLint port (template parser source-text scan).
|
|
38
|
-
*/
|
|
39
|
-
const rule: Rule.RuleModule = {
|
|
40
|
-
meta: {
|
|
41
|
-
type: 'suggestion',
|
|
42
|
-
docs: {
|
|
43
|
-
description:
|
|
44
|
-
'Forbid method calls in Angular templates for data display; '
|
|
45
|
-
+ 'use signals / computed / pipes instead. Event bindings `(click)="..."` allowed.',
|
|
46
|
-
recommended: true,
|
|
47
|
-
},
|
|
48
|
-
schema: [],
|
|
49
|
-
messages: {
|
|
50
|
-
interpolationCall: 'Metódushívás interpolációban: `{{ method() }}`. Használj signal-t vagy pipe-ot.',
|
|
51
|
-
propertyBindingCall: 'Metódushívás property bindingban. Használj signal-t vagy computed-t.',
|
|
52
|
-
blockCall: 'Metódushívás Angular block direktívában (`@if` / `@switch`). Használj signal-t vagy computed-t.',
|
|
53
|
-
},
|
|
54
|
-
},
|
|
55
|
-
create(context: Rule.RuleContext): Rule.RuleListener {
|
|
56
|
-
const filename: string = context.filename ?? '';
|
|
57
|
-
if (!filename.endsWith('.html')) {
|
|
58
|
-
return {};
|
|
59
|
-
}
|
|
60
|
-
const text: string = context.sourceCode.text ?? '';
|
|
61
|
-
|
|
62
|
-
function reportMatches(regex: RegExp, messageId: string): void {
|
|
63
|
-
const localRegex: RegExp = new RegExp(regex.source, 'g');
|
|
64
|
-
let match: RegExpExecArray | null = localRegex.exec(text);
|
|
65
|
-
while (match !== null) {
|
|
66
|
-
const loc: { line: number; column: number } = computeLoc(text, match.index);
|
|
67
|
-
context.report({
|
|
68
|
-
loc: { start: loc, end: { line: loc.line, column: loc.column + match[0].length } },
|
|
69
|
-
messageId: messageId,
|
|
70
|
-
});
|
|
71
|
-
match = localRegex.exec(text);
|
|
72
|
-
}
|
|
73
|
-
}
|
|
74
|
-
|
|
75
|
-
return {
|
|
76
|
-
Program(): void {
|
|
77
|
-
try {
|
|
78
|
-
reportMatches(INTERPOLATION_CALL_REGEX, 'interpolationCall');
|
|
79
|
-
reportMatches(PROPERTY_BINDING_CALL_REGEX, 'propertyBindingCall');
|
|
80
|
-
reportMatches(BLOCK_CALL_REGEX, 'blockCall');
|
|
81
|
-
} catch (error) {
|
|
82
|
-
console.error('[no-method-call-in-template] Error in Program visitor:', error);
|
|
83
|
-
}
|
|
84
|
-
},
|
|
85
|
-
};
|
|
86
|
-
},
|
|
87
|
-
};
|
|
88
|
-
|
|
89
|
-
export default rule;
|
|
1
|
+
import { Rule } from 'eslint';
|
|
2
|
+
|
|
3
|
+
/**
|
|
4
|
+
* Interpoláció metódushívás regex: `{{ ... method() ... }}`. Signal hívás (`_$()`) kizárva.
|
|
5
|
+
* Capture group 1: a hívott metódus neve.
|
|
6
|
+
*/
|
|
7
|
+
const INTERPOLATION_CALL_REGEX: RegExp =
|
|
8
|
+
/\{\{[^}]*\b([a-zA-Z_$][a-zA-Z0-9_$]*(?<!_\$))\s*\([^)]*\)[^}]*\}\}/g;
|
|
9
|
+
|
|
10
|
+
/**
|
|
11
|
+
* Property binding metódushívás regex: `[attr]="method()"`. Esemény binding `(event)="..."` kizárva.
|
|
12
|
+
*/
|
|
13
|
+
const PROPERTY_BINDING_CALL_REGEX: RegExp =
|
|
14
|
+
/\[[^\]]+\]="[^"]*\b[a-zA-Z_$][a-zA-Z0-9_$]*(?<!_\$)\s*\([^)]*\)[^"]*"/g;
|
|
15
|
+
|
|
16
|
+
/**
|
|
17
|
+
* Angular block (`@if`, `@switch`, `@case`, `@else if`) metódushívás regex.
|
|
18
|
+
*/
|
|
19
|
+
const BLOCK_CALL_REGEX: RegExp =
|
|
20
|
+
/@(?:if|switch|case|else if)\s*\([^)]*\b[a-zA-Z_$][a-zA-Z0-9_$]*(?<!_\$)\s*\([^)]*\)/g;
|
|
21
|
+
|
|
22
|
+
/**
|
|
23
|
+
* Adott offset alapján a sor és oszlop kiszámítása az alap szövegből.
|
|
24
|
+
*/
|
|
25
|
+
function computeLoc(text: string, index: number): { line: number; column: number } {
|
|
26
|
+
const before: string = text.substring(0, index);
|
|
27
|
+
const newlineMatches: RegExpMatchArray | null = before.match(/\n/g);
|
|
28
|
+
const line: number = (newlineMatches ? newlineMatches.length : 0) + 1;
|
|
29
|
+
const lastNewline: number = before.lastIndexOf('\n');
|
|
30
|
+
const column: number = lastNewline === -1 ? index : index - lastNewline - 1;
|
|
31
|
+
return { line: line, column: column };
|
|
32
|
+
}
|
|
33
|
+
|
|
34
|
+
/**
|
|
35
|
+
* No-method-call-in-template szabály: Angular template-ekben tilos metódust hívni
|
|
36
|
+
* adat megjelenítéshez. Megengedett: signal `mySignal_$()` és esemény `(click)="handler()"`.
|
|
37
|
+
* CCAP "no-method-call-in-template" review ESLint port (template parser source-text scan).
|
|
38
|
+
*/
|
|
39
|
+
const rule: Rule.RuleModule = {
|
|
40
|
+
meta: {
|
|
41
|
+
type: 'suggestion',
|
|
42
|
+
docs: {
|
|
43
|
+
description:
|
|
44
|
+
'Forbid method calls in Angular templates for data display; '
|
|
45
|
+
+ 'use signals / computed / pipes instead. Event bindings `(click)="..."` allowed.',
|
|
46
|
+
recommended: true,
|
|
47
|
+
},
|
|
48
|
+
schema: [],
|
|
49
|
+
messages: {
|
|
50
|
+
interpolationCall: 'Metódushívás interpolációban: `{{ method() }}`. Használj signal-t vagy pipe-ot.',
|
|
51
|
+
propertyBindingCall: 'Metódushívás property bindingban. Használj signal-t vagy computed-t.',
|
|
52
|
+
blockCall: 'Metódushívás Angular block direktívában (`@if` / `@switch`). Használj signal-t vagy computed-t.',
|
|
53
|
+
},
|
|
54
|
+
},
|
|
55
|
+
create(context: Rule.RuleContext): Rule.RuleListener {
|
|
56
|
+
const filename: string = context.filename ?? '';
|
|
57
|
+
if (!filename.endsWith('.html')) {
|
|
58
|
+
return {};
|
|
59
|
+
}
|
|
60
|
+
const text: string = context.sourceCode.text ?? '';
|
|
61
|
+
|
|
62
|
+
function reportMatches(regex: RegExp, messageId: string): void {
|
|
63
|
+
const localRegex: RegExp = new RegExp(regex.source, 'g');
|
|
64
|
+
let match: RegExpExecArray | null = localRegex.exec(text);
|
|
65
|
+
while (match !== null) {
|
|
66
|
+
const loc: { line: number; column: number } = computeLoc(text, match.index);
|
|
67
|
+
context.report({
|
|
68
|
+
loc: { start: loc, end: { line: loc.line, column: loc.column + match[0].length } },
|
|
69
|
+
messageId: messageId,
|
|
70
|
+
});
|
|
71
|
+
match = localRegex.exec(text);
|
|
72
|
+
}
|
|
73
|
+
}
|
|
74
|
+
|
|
75
|
+
return {
|
|
76
|
+
Program(): void {
|
|
77
|
+
try {
|
|
78
|
+
reportMatches(INTERPOLATION_CALL_REGEX, 'interpolationCall');
|
|
79
|
+
reportMatches(PROPERTY_BINDING_CALL_REGEX, 'propertyBindingCall');
|
|
80
|
+
reportMatches(BLOCK_CALL_REGEX, 'blockCall');
|
|
81
|
+
} catch (error) {
|
|
82
|
+
console.error('[no-method-call-in-template] Error in Program visitor:', error);
|
|
83
|
+
}
|
|
84
|
+
},
|
|
85
|
+
};
|
|
86
|
+
},
|
|
87
|
+
};
|
|
88
|
+
|
|
89
|
+
export default rule;
|
|
@@ -1,44 +1,44 @@
|
|
|
1
|
-
import noNgForDirectiveRule from './no-ngfor-directive';
|
|
2
|
-
|
|
3
|
-
describe('| no-ngfor-directive', () => {
|
|
4
|
-
it('| should be a valid ESLint rule', () => {
|
|
5
|
-
expect(noNgForDirectiveRule.meta?.type).toBe('suggestion');
|
|
6
|
-
expect(noNgForDirectiveRule.meta?.messages?.noNgFor).toBeDefined();
|
|
7
|
-
});
|
|
8
|
-
|
|
9
|
-
it('| should skip non-html files', () => {
|
|
10
|
-
const mockContext: any = { filename: '/x/foo.ts', report: () => {}, options: [], sourceCode: { text: '' } };
|
|
11
|
-
const result: any = noNgForDirectiveRule.create(mockContext);
|
|
12
|
-
expect(result.Program).toBeUndefined();
|
|
13
|
-
});
|
|
14
|
-
|
|
15
|
-
it('| should report `*ngFor`', () => {
|
|
16
|
-
let reportCount: number = 0;
|
|
17
|
-
const mockContext: any = {
|
|
18
|
-
filename: '/x/list.component.html',
|
|
19
|
-
report: (options: any): void => {
|
|
20
|
-
if (options.messageId === 'noNgFor') {
|
|
21
|
-
reportCount += 1;
|
|
22
|
-
}
|
|
23
|
-
},
|
|
24
|
-
options: [],
|
|
25
|
-
sourceCode: { text: '<div *ngFor="let item of items">X</div>' },
|
|
26
|
-
};
|
|
27
|
-
const rule: any = noNgForDirectiveRule.create(mockContext);
|
|
28
|
-
rule.Program();
|
|
29
|
-
expect(reportCount).toBeGreaterThan(0);
|
|
30
|
-
});
|
|
31
|
-
|
|
32
|
-
it('| should NOT report `@for` block', () => {
|
|
33
|
-
let reportCount: number = 0;
|
|
34
|
-
const mockContext: any = {
|
|
35
|
-
filename: '/x/list.component.html',
|
|
36
|
-
report: (): void => { reportCount += 1; },
|
|
37
|
-
options: [],
|
|
38
|
-
sourceCode: { text: '@for (item of items; track item.id) { <div>X</div> }' },
|
|
39
|
-
};
|
|
40
|
-
const rule: any = noNgForDirectiveRule.create(mockContext);
|
|
41
|
-
rule.Program();
|
|
42
|
-
expect(reportCount).toBe(0);
|
|
43
|
-
});
|
|
44
|
-
});
|
|
1
|
+
import noNgForDirectiveRule from './no-ngfor-directive';
|
|
2
|
+
|
|
3
|
+
describe('| no-ngfor-directive', () => {
|
|
4
|
+
it('| should be a valid ESLint rule', () => {
|
|
5
|
+
expect(noNgForDirectiveRule.meta?.type).toBe('suggestion');
|
|
6
|
+
expect(noNgForDirectiveRule.meta?.messages?.noNgFor).toBeDefined();
|
|
7
|
+
});
|
|
8
|
+
|
|
9
|
+
it('| should skip non-html files', () => {
|
|
10
|
+
const mockContext: any = { filename: '/x/foo.ts', report: () => {}, options: [], sourceCode: { text: '' } };
|
|
11
|
+
const result: any = noNgForDirectiveRule.create(mockContext);
|
|
12
|
+
expect(result.Program).toBeUndefined();
|
|
13
|
+
});
|
|
14
|
+
|
|
15
|
+
it('| should report `*ngFor`', () => {
|
|
16
|
+
let reportCount: number = 0;
|
|
17
|
+
const mockContext: any = {
|
|
18
|
+
filename: '/x/list.component.html',
|
|
19
|
+
report: (options: any): void => {
|
|
20
|
+
if (options.messageId === 'noNgFor') {
|
|
21
|
+
reportCount += 1;
|
|
22
|
+
}
|
|
23
|
+
},
|
|
24
|
+
options: [],
|
|
25
|
+
sourceCode: { text: '<div *ngFor="let item of items">X</div>' },
|
|
26
|
+
};
|
|
27
|
+
const rule: any = noNgForDirectiveRule.create(mockContext);
|
|
28
|
+
rule.Program();
|
|
29
|
+
expect(reportCount).toBeGreaterThan(0);
|
|
30
|
+
});
|
|
31
|
+
|
|
32
|
+
it('| should NOT report `@for` block', () => {
|
|
33
|
+
let reportCount: number = 0;
|
|
34
|
+
const mockContext: any = {
|
|
35
|
+
filename: '/x/list.component.html',
|
|
36
|
+
report: (): void => { reportCount += 1; },
|
|
37
|
+
options: [],
|
|
38
|
+
sourceCode: { text: '@for (item of items; track item.id) { <div>X</div> }' },
|
|
39
|
+
};
|
|
40
|
+
const rule: any = noNgForDirectiveRule.create(mockContext);
|
|
41
|
+
rule.Program();
|
|
42
|
+
expect(reportCount).toBe(0);
|
|
43
|
+
});
|
|
44
|
+
});
|
|
@@ -1,62 +1,62 @@
|
|
|
1
|
-
import { Rule } from 'eslint';
|
|
2
|
-
|
|
3
|
-
/** `*ngFor` használat detektálása HTML template-ekben. */
|
|
4
|
-
const NGFOR_REGEX: RegExp = /\*ngFor/g;
|
|
5
|
-
|
|
6
|
-
/**
|
|
7
|
-
* Adott offset alapján a sor és oszlop kiszámítása az alap szövegből.
|
|
8
|
-
*/
|
|
9
|
-
function computeLoc(text: string, index: number): { line: number; column: number } {
|
|
10
|
-
const before: string = text.substring(0, index);
|
|
11
|
-
const newlineMatches: RegExpMatchArray | null = before.match(/\n/g);
|
|
12
|
-
const line: number = (newlineMatches ? newlineMatches.length : 0) + 1;
|
|
13
|
-
const lastNewline: number = before.lastIndexOf('\n');
|
|
14
|
-
const column: number = lastNewline === -1 ? index : index - lastNewline - 1;
|
|
15
|
-
return { line: line, column: column };
|
|
16
|
-
}
|
|
17
|
-
|
|
18
|
-
/**
|
|
19
|
-
* No-ngFor-directive szabály: Angular template-ekben `*ngFor` helyett `@for` szintaxist használj.
|
|
20
|
-
* CCAP "no-ngfor-directive" review ESLint template-text-scan portja.
|
|
21
|
-
*/
|
|
22
|
-
const rule: Rule.RuleModule = {
|
|
23
|
-
meta: {
|
|
24
|
-
type: 'suggestion',
|
|
25
|
-
docs: {
|
|
26
|
-
description: 'Forbid `*ngFor` directive in Angular templates; use `@for` block syntax instead.',
|
|
27
|
-
recommended: true,
|
|
28
|
-
},
|
|
29
|
-
schema: [],
|
|
30
|
-
messages: {
|
|
31
|
-
noNgFor: '`*ngFor` direktíva tilos. Használj `@for` block szintaxist.',
|
|
32
|
-
},
|
|
33
|
-
},
|
|
34
|
-
create(context: Rule.RuleContext): Rule.RuleListener {
|
|
35
|
-
const filename: string = context.filename ?? '';
|
|
36
|
-
if (!filename.endsWith('.html')) {
|
|
37
|
-
return {};
|
|
38
|
-
}
|
|
39
|
-
const text: string = context.sourceCode.text ?? '';
|
|
40
|
-
|
|
41
|
-
return {
|
|
42
|
-
Program(): void {
|
|
43
|
-
try {
|
|
44
|
-
const localRegex: RegExp = new RegExp(NGFOR_REGEX.source, 'g');
|
|
45
|
-
let match: RegExpExecArray | null = localRegex.exec(text);
|
|
46
|
-
while (match !== null) {
|
|
47
|
-
const loc: { line: number; column: number } = computeLoc(text, match.index);
|
|
48
|
-
context.report({
|
|
49
|
-
loc: { start: loc, end: { line: loc.line, column: loc.column + match[0].length } },
|
|
50
|
-
messageId: 'noNgFor',
|
|
51
|
-
});
|
|
52
|
-
match = localRegex.exec(text);
|
|
53
|
-
}
|
|
54
|
-
} catch (error) {
|
|
55
|
-
console.error('[no-ngfor-directive] Error in Program visitor:', error);
|
|
56
|
-
}
|
|
57
|
-
},
|
|
58
|
-
};
|
|
59
|
-
},
|
|
60
|
-
};
|
|
61
|
-
|
|
62
|
-
export default rule;
|
|
1
|
+
import { Rule } from 'eslint';
|
|
2
|
+
|
|
3
|
+
/** `*ngFor` használat detektálása HTML template-ekben. */
|
|
4
|
+
const NGFOR_REGEX: RegExp = /\*ngFor/g;
|
|
5
|
+
|
|
6
|
+
/**
|
|
7
|
+
* Adott offset alapján a sor és oszlop kiszámítása az alap szövegből.
|
|
8
|
+
*/
|
|
9
|
+
function computeLoc(text: string, index: number): { line: number; column: number } {
|
|
10
|
+
const before: string = text.substring(0, index);
|
|
11
|
+
const newlineMatches: RegExpMatchArray | null = before.match(/\n/g);
|
|
12
|
+
const line: number = (newlineMatches ? newlineMatches.length : 0) + 1;
|
|
13
|
+
const lastNewline: number = before.lastIndexOf('\n');
|
|
14
|
+
const column: number = lastNewline === -1 ? index : index - lastNewline - 1;
|
|
15
|
+
return { line: line, column: column };
|
|
16
|
+
}
|
|
17
|
+
|
|
18
|
+
/**
|
|
19
|
+
* No-ngFor-directive szabály: Angular template-ekben `*ngFor` helyett `@for` szintaxist használj.
|
|
20
|
+
* CCAP "no-ngfor-directive" review ESLint template-text-scan portja.
|
|
21
|
+
*/
|
|
22
|
+
const rule: Rule.RuleModule = {
|
|
23
|
+
meta: {
|
|
24
|
+
type: 'suggestion',
|
|
25
|
+
docs: {
|
|
26
|
+
description: 'Forbid `*ngFor` directive in Angular templates; use `@for` block syntax instead.',
|
|
27
|
+
recommended: true,
|
|
28
|
+
},
|
|
29
|
+
schema: [],
|
|
30
|
+
messages: {
|
|
31
|
+
noNgFor: '`*ngFor` direktíva tilos. Használj `@for` block szintaxist.',
|
|
32
|
+
},
|
|
33
|
+
},
|
|
34
|
+
create(context: Rule.RuleContext): Rule.RuleListener {
|
|
35
|
+
const filename: string = context.filename ?? '';
|
|
36
|
+
if (!filename.endsWith('.html')) {
|
|
37
|
+
return {};
|
|
38
|
+
}
|
|
39
|
+
const text: string = context.sourceCode.text ?? '';
|
|
40
|
+
|
|
41
|
+
return {
|
|
42
|
+
Program(): void {
|
|
43
|
+
try {
|
|
44
|
+
const localRegex: RegExp = new RegExp(NGFOR_REGEX.source, 'g');
|
|
45
|
+
let match: RegExpExecArray | null = localRegex.exec(text);
|
|
46
|
+
while (match !== null) {
|
|
47
|
+
const loc: { line: number; column: number } = computeLoc(text, match.index);
|
|
48
|
+
context.report({
|
|
49
|
+
loc: { start: loc, end: { line: loc.line, column: loc.column + match[0].length } },
|
|
50
|
+
messageId: 'noNgFor',
|
|
51
|
+
});
|
|
52
|
+
match = localRegex.exec(text);
|
|
53
|
+
}
|
|
54
|
+
} catch (error) {
|
|
55
|
+
console.error('[no-ngfor-directive] Error in Program visitor:', error);
|
|
56
|
+
}
|
|
57
|
+
},
|
|
58
|
+
};
|
|
59
|
+
},
|
|
60
|
+
};
|
|
61
|
+
|
|
62
|
+
export default rule;
|
|
@@ -1,44 +1,44 @@
|
|
|
1
|
-
import noNgIfDirectiveRule from './no-ngif-directive';
|
|
2
|
-
|
|
3
|
-
describe('| no-ngif-directive', () => {
|
|
4
|
-
it('| should be a valid ESLint rule', () => {
|
|
5
|
-
expect(noNgIfDirectiveRule.meta?.type).toBe('suggestion');
|
|
6
|
-
expect(noNgIfDirectiveRule.meta?.messages?.noNgIf).toBeDefined();
|
|
7
|
-
});
|
|
8
|
-
|
|
9
|
-
it('| should skip non-html files', () => {
|
|
10
|
-
const mockContext: any = { filename: '/x/foo.ts', report: () => {}, options: [], sourceCode: { text: '' } };
|
|
11
|
-
const result: any = noNgIfDirectiveRule.create(mockContext);
|
|
12
|
-
expect(result.Program).toBeUndefined();
|
|
13
|
-
});
|
|
14
|
-
|
|
15
|
-
it('| should report `*ngIf`', () => {
|
|
16
|
-
let reportCount: number = 0;
|
|
17
|
-
const mockContext: any = {
|
|
18
|
-
filename: '/x/user.component.html',
|
|
19
|
-
report: (options: any): void => {
|
|
20
|
-
if (options.messageId === 'noNgIf') {
|
|
21
|
-
reportCount += 1;
|
|
22
|
-
}
|
|
23
|
-
},
|
|
24
|
-
options: [],
|
|
25
|
-
sourceCode: { text: '<div *ngIf="condition">X</div>' },
|
|
26
|
-
};
|
|
27
|
-
const rule: any = noNgIfDirectiveRule.create(mockContext);
|
|
28
|
-
rule.Program();
|
|
29
|
-
expect(reportCount).toBeGreaterThan(0);
|
|
30
|
-
});
|
|
31
|
-
|
|
32
|
-
it('| should NOT report `@if` block', () => {
|
|
33
|
-
let reportCount: number = 0;
|
|
34
|
-
const mockContext: any = {
|
|
35
|
-
filename: '/x/user.component.html',
|
|
36
|
-
report: (): void => { reportCount += 1; },
|
|
37
|
-
options: [],
|
|
38
|
-
sourceCode: { text: '@if (condition) { <div>X</div> }' },
|
|
39
|
-
};
|
|
40
|
-
const rule: any = noNgIfDirectiveRule.create(mockContext);
|
|
41
|
-
rule.Program();
|
|
42
|
-
expect(reportCount).toBe(0);
|
|
43
|
-
});
|
|
44
|
-
});
|
|
1
|
+
import noNgIfDirectiveRule from './no-ngif-directive';
|
|
2
|
+
|
|
3
|
+
describe('| no-ngif-directive', () => {
|
|
4
|
+
it('| should be a valid ESLint rule', () => {
|
|
5
|
+
expect(noNgIfDirectiveRule.meta?.type).toBe('suggestion');
|
|
6
|
+
expect(noNgIfDirectiveRule.meta?.messages?.noNgIf).toBeDefined();
|
|
7
|
+
});
|
|
8
|
+
|
|
9
|
+
it('| should skip non-html files', () => {
|
|
10
|
+
const mockContext: any = { filename: '/x/foo.ts', report: () => {}, options: [], sourceCode: { text: '' } };
|
|
11
|
+
const result: any = noNgIfDirectiveRule.create(mockContext);
|
|
12
|
+
expect(result.Program).toBeUndefined();
|
|
13
|
+
});
|
|
14
|
+
|
|
15
|
+
it('| should report `*ngIf`', () => {
|
|
16
|
+
let reportCount: number = 0;
|
|
17
|
+
const mockContext: any = {
|
|
18
|
+
filename: '/x/user.component.html',
|
|
19
|
+
report: (options: any): void => {
|
|
20
|
+
if (options.messageId === 'noNgIf') {
|
|
21
|
+
reportCount += 1;
|
|
22
|
+
}
|
|
23
|
+
},
|
|
24
|
+
options: [],
|
|
25
|
+
sourceCode: { text: '<div *ngIf="condition">X</div>' },
|
|
26
|
+
};
|
|
27
|
+
const rule: any = noNgIfDirectiveRule.create(mockContext);
|
|
28
|
+
rule.Program();
|
|
29
|
+
expect(reportCount).toBeGreaterThan(0);
|
|
30
|
+
});
|
|
31
|
+
|
|
32
|
+
it('| should NOT report `@if` block', () => {
|
|
33
|
+
let reportCount: number = 0;
|
|
34
|
+
const mockContext: any = {
|
|
35
|
+
filename: '/x/user.component.html',
|
|
36
|
+
report: (): void => { reportCount += 1; },
|
|
37
|
+
options: [],
|
|
38
|
+
sourceCode: { text: '@if (condition) { <div>X</div> }' },
|
|
39
|
+
};
|
|
40
|
+
const rule: any = noNgIfDirectiveRule.create(mockContext);
|
|
41
|
+
rule.Program();
|
|
42
|
+
expect(reportCount).toBe(0);
|
|
43
|
+
});
|
|
44
|
+
});
|
|
@@ -1,62 +1,62 @@
|
|
|
1
|
-
import { Rule } from 'eslint';
|
|
2
|
-
|
|
3
|
-
/** `*ngIf` használat detektálása HTML template-ekben. */
|
|
4
|
-
const NGIF_REGEX: RegExp = /\*ngIf/g;
|
|
5
|
-
|
|
6
|
-
/**
|
|
7
|
-
* Adott offset alapján a sor és oszlop kiszámítása az alap szövegből.
|
|
8
|
-
*/
|
|
9
|
-
function computeLoc(text: string, index: number): { line: number; column: number } {
|
|
10
|
-
const before: string = text.substring(0, index);
|
|
11
|
-
const newlineMatches: RegExpMatchArray | null = before.match(/\n/g);
|
|
12
|
-
const line: number = (newlineMatches ? newlineMatches.length : 0) + 1;
|
|
13
|
-
const lastNewline: number = before.lastIndexOf('\n');
|
|
14
|
-
const column: number = lastNewline === -1 ? index : index - lastNewline - 1;
|
|
15
|
-
return { line: line, column: column };
|
|
16
|
-
}
|
|
17
|
-
|
|
18
|
-
/**
|
|
19
|
-
* No-ngIf-directive szabály: Angular template-ekben `*ngIf` helyett `@if` szintaxist használj.
|
|
20
|
-
* CCAP "no-ngif-directive" review ESLint template-text-scan portja.
|
|
21
|
-
*/
|
|
22
|
-
const rule: Rule.RuleModule = {
|
|
23
|
-
meta: {
|
|
24
|
-
type: 'suggestion',
|
|
25
|
-
docs: {
|
|
26
|
-
description: 'Forbid `*ngIf` directive in Angular templates; use `@if` block syntax instead.',
|
|
27
|
-
recommended: true,
|
|
28
|
-
},
|
|
29
|
-
schema: [],
|
|
30
|
-
messages: {
|
|
31
|
-
noNgIf: '`*ngIf` direktíva tilos. Használj `@if` block szintaxist.',
|
|
32
|
-
},
|
|
33
|
-
},
|
|
34
|
-
create(context: Rule.RuleContext): Rule.RuleListener {
|
|
35
|
-
const filename: string = context.filename ?? '';
|
|
36
|
-
if (!filename.endsWith('.html')) {
|
|
37
|
-
return {};
|
|
38
|
-
}
|
|
39
|
-
const text: string = context.sourceCode.text ?? '';
|
|
40
|
-
|
|
41
|
-
return {
|
|
42
|
-
Program(): void {
|
|
43
|
-
try {
|
|
44
|
-
const localRegex: RegExp = new RegExp(NGIF_REGEX.source, 'g');
|
|
45
|
-
let match: RegExpExecArray | null = localRegex.exec(text);
|
|
46
|
-
while (match !== null) {
|
|
47
|
-
const loc: { line: number; column: number } = computeLoc(text, match.index);
|
|
48
|
-
context.report({
|
|
49
|
-
loc: { start: loc, end: { line: loc.line, column: loc.column + match[0].length } },
|
|
50
|
-
messageId: 'noNgIf',
|
|
51
|
-
});
|
|
52
|
-
match = localRegex.exec(text);
|
|
53
|
-
}
|
|
54
|
-
} catch (error) {
|
|
55
|
-
console.error('[no-ngif-directive] Error in Program visitor:', error);
|
|
56
|
-
}
|
|
57
|
-
},
|
|
58
|
-
};
|
|
59
|
-
},
|
|
60
|
-
};
|
|
61
|
-
|
|
62
|
-
export default rule;
|
|
1
|
+
import { Rule } from 'eslint';
|
|
2
|
+
|
|
3
|
+
/** `*ngIf` használat detektálása HTML template-ekben. */
|
|
4
|
+
const NGIF_REGEX: RegExp = /\*ngIf/g;
|
|
5
|
+
|
|
6
|
+
/**
|
|
7
|
+
* Adott offset alapján a sor és oszlop kiszámítása az alap szövegből.
|
|
8
|
+
*/
|
|
9
|
+
function computeLoc(text: string, index: number): { line: number; column: number } {
|
|
10
|
+
const before: string = text.substring(0, index);
|
|
11
|
+
const newlineMatches: RegExpMatchArray | null = before.match(/\n/g);
|
|
12
|
+
const line: number = (newlineMatches ? newlineMatches.length : 0) + 1;
|
|
13
|
+
const lastNewline: number = before.lastIndexOf('\n');
|
|
14
|
+
const column: number = lastNewline === -1 ? index : index - lastNewline - 1;
|
|
15
|
+
return { line: line, column: column };
|
|
16
|
+
}
|
|
17
|
+
|
|
18
|
+
/**
|
|
19
|
+
* No-ngIf-directive szabály: Angular template-ekben `*ngIf` helyett `@if` szintaxist használj.
|
|
20
|
+
* CCAP "no-ngif-directive" review ESLint template-text-scan portja.
|
|
21
|
+
*/
|
|
22
|
+
const rule: Rule.RuleModule = {
|
|
23
|
+
meta: {
|
|
24
|
+
type: 'suggestion',
|
|
25
|
+
docs: {
|
|
26
|
+
description: 'Forbid `*ngIf` directive in Angular templates; use `@if` block syntax instead.',
|
|
27
|
+
recommended: true,
|
|
28
|
+
},
|
|
29
|
+
schema: [],
|
|
30
|
+
messages: {
|
|
31
|
+
noNgIf: '`*ngIf` direktíva tilos. Használj `@if` block szintaxist.',
|
|
32
|
+
},
|
|
33
|
+
},
|
|
34
|
+
create(context: Rule.RuleContext): Rule.RuleListener {
|
|
35
|
+
const filename: string = context.filename ?? '';
|
|
36
|
+
if (!filename.endsWith('.html')) {
|
|
37
|
+
return {};
|
|
38
|
+
}
|
|
39
|
+
const text: string = context.sourceCode.text ?? '';
|
|
40
|
+
|
|
41
|
+
return {
|
|
42
|
+
Program(): void {
|
|
43
|
+
try {
|
|
44
|
+
const localRegex: RegExp = new RegExp(NGIF_REGEX.source, 'g');
|
|
45
|
+
let match: RegExpExecArray | null = localRegex.exec(text);
|
|
46
|
+
while (match !== null) {
|
|
47
|
+
const loc: { line: number; column: number } = computeLoc(text, match.index);
|
|
48
|
+
context.report({
|
|
49
|
+
loc: { start: loc, end: { line: loc.line, column: loc.column + match[0].length } },
|
|
50
|
+
messageId: 'noNgIf',
|
|
51
|
+
});
|
|
52
|
+
match = localRegex.exec(text);
|
|
53
|
+
}
|
|
54
|
+
} catch (error) {
|
|
55
|
+
console.error('[no-ngif-directive] Error in Program visitor:', error);
|
|
56
|
+
}
|
|
57
|
+
},
|
|
58
|
+
};
|
|
59
|
+
},
|
|
60
|
+
};
|
|
61
|
+
|
|
62
|
+
export default rule;
|