@fullstacksjs/eslint-config 10.11.1 → 11.0.0

package/registerOpts.js

@@ -1,20 +0,0 @@
-const { hasDep, isEsm } = require('./utils');
-
-/** @param { import('./init').Options } opts */
-const defaultOptions = {
-  esm: isEsm(),
-  cypress: hasDep('cypress'),
-  graphql: hasDep('graphql'),
-  react: hasDep('react'),
-  next: hasDep('next'),
-  storybook: hasDep('@storybook/react'),
-  test: hasDep('jest') || hasDep('vitest'),
-  typescript: hasDep('typescript'),
-  tailwind: hasDep('tailwindcss'),
-  prettier: hasDep('prettier'),
-  disableExpensiveRules: false,
-  import: true,
-  node: true,
-};
-
-global.fullstacksjs = defaultOptions;

package/storybook.js

@@ -1,31 +0,0 @@
-/** @type { import('eslint').Linter.Config } */
-module.exports = {
-  overrides: [
-    {
-      files: ['**/*.stories.+(ts|tsx|js|jsx|mjs|cjs|mdx)', '**/*.story.+(ts|tsx|js|jsx|mjs|cjs|mdx)'],
-      plugins: ['storybook'],
-      rules: {
-        'storybook/await-interactions': 'error',
-        'storybook/context-in-play-function': 'error',
-        'storybook/default-exports': 'error',
-        'storybook/hierarchy-separator': 'warn',
-        'storybook/no-redundant-story-name': 'warn',
-        'storybook/no-uninstalled-addons': 'error',
-        'storybook/prefer-pascal-case': 'warn',
-        'storybook/story-exports': 'error',
-        'storybook/use-storybook-expect': 'error',
-        'storybook/use-storybook-testing-library': 'error',
-
-        'storybook/csf-component': 'warn',
-        'storybook/no-stories-of': 'warn',
-        'storybook/no-title-property-in-meta': 'off',
-        'storybook/meta-inline-properties': 'off',
-
-        // Conflicts
-        '@typescript-eslint/no-confusing-void-expression': 'off',
-        'react/jsx-no-useless-fragment': 'off',
-        'react-hooks/rules-of-hooks': 'off',
-      },
-    },
-  ],
-};

package/strict.js

@@ -1,15 +0,0 @@
-/** @type { import('eslint').Linter.Config } */
-module.exports = {
-  rules: {
-    'no-console': 'warn',
-    'fp/no-delete': 'error',
-    'fp/no-get-set': 'error',
-    'fp/no-mutating-methods': 'error',
-    'fp/no-mutation': ['error', { commonjs: true, allowThis: true, exceptions: [{ property: 'propTypes' }, { property: 'defaultProps' }] }],
-    'fp/no-nil': 'error',
-    'fp/no-this': 'error',
-    'fp/no-throw': 'error',
-    'fp/no-unused-expression': ['error', { allowUseStrict: true }],
-    '@typescript-eslint/no-non-null-assertion': 'warn',
-  },
-};

package/tailwind.js

@@ -1,15 +0,0 @@
-/**
- * @type { import('eslint').Linter.Config }
- */
-module.exports = {
-  plugins: ['tailwindcss'],
-  rules: {
-    'tailwindcss/classnames-order': 'warn',
-    'tailwindcss/enforces-negative-arbitrary-values': 'warn',
-    'tailwindcss/enforces-shorthand': 'warn',
-    'tailwindcss/migration-from-tailwind-2': 'warn',
-    'tailwindcss/no-arbitrary-value': 'off',
-    'tailwindcss/no-custom-classname': 'warn',
-    'tailwindcss/no-contradicting-classname': 'error',
-  },
-};

package/test.js

@@ -1,40 +0,0 @@
-/**
- * @type { import('eslint').Linter.Config }
- */
-module.exports = {
-  rules: {
-    'jest/prefer-hooks-in-order': 'warn',
-    'jest/no-disabled-tests': 'error',
-    'jest/no-duplicate-hooks': 'error',
-    'jest/no-focused-tests': 'error',
-    'jest/no-identical-title': 'error',
-    'jest/prefer-comparison-matcher': 'error',
-    'jest/prefer-equality-matcher': 'error',
-    'jest/max-expects': ['off', { max: 5 }],
-
-    // formatting
-    'jest-formatting/padding-around-after-all-blocks': 'warn',
-    'jest-formatting/padding-around-after-each-blocks': 'warn',
-    'jest-formatting/padding-around-all': 'warn',
-    'jest-formatting/padding-around-before-all-blocks': 'warn',
-    'jest-formatting/padding-around-before-each-blocks': 'warn',
-    'jest-formatting/padding-around-describe-blocks': 'warn',
-    'jest-formatting/padding-around-expect-groups': 'warn',
-    'jest-formatting/padding-around-test-blocks': 'warn',
-
-    'max-lines-per-function': 'off',
-    'fp/no-let': 'off',
-    'fp/no-loops': 'off',
-    'no-sparse-arrays': 'off',
-
-    ...(global.fullstacksjs?.react && {
-      'react/jsx-no-constructed-context-values': 'off',
-    }),
-    ...(global.fullstacksjs?.typescript && {
-      '@typescript-eslint/method-signature-style': 'off',
-      '@typescript-eslint/no-namespace ': 'off',
-      '@typescript-eslint/unbound-method': 'off',
-      '@typescript-eslint/no-empty-function': 'off',
-    }),
-  },
-};

package/typecheck.js

@@ -1,89 +0,0 @@
-const expensiveRules = require('./expensive-rules');
-
-/** @type { import('eslint').Linter.Config } */
-module.exports = {
-  overrides: [
-    {
-      files: ['*.ts', '*.tsx'],
-      rules: {
-        '@typescript-eslint/await-thenable': 'error',
-        '@typescript-eslint/consistent-return': 'off',
-        '@typescript-eslint/consistent-type-exports': 'warn',
-        '@typescript-eslint/dot-notation': [
-          'warn',
-          {
-            allowPrivateClassPropertyAccess: false,
-            allowProtectedClassPropertyAccess: false,
-            allowIndexSignaturePropertyAccess: true,
-          },
-        ],
-        '@typescript-eslint/no-confusing-void-expression': ['off', { ignoreArrowShorthand: true, ignoreVoidOperator: true }], // Annoying and conflict with @typescript-eslint/no-meaningless-void-operator
-        '@typescript-eslint/no-duplicate-type-constituents': 'warn',
-        '@typescript-eslint/no-floating-promises': expensiveRules(['error', { ignoreVoid: true }]),
-        '@typescript-eslint/no-for-in-array': 'error',
-        '@typescript-eslint/no-implied-eval': 'error',
-        '@typescript-eslint/no-meaningless-void-operator': ['warn', { checkNever: false }],
-        '@typescript-eslint/no-misused-promises': expensiveRules(['warn', { checksVoidReturn: { attributes: false } }]),
-        '@typescript-eslint/no-mixed-enums': 'error',
-        '@typescript-eslint/no-redundant-type-constituents': 'warn',
-        '@typescript-eslint/no-throw-literal': ['warn', { allowThrowingUnknown: false }],
-        '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
-        '@typescript-eslint/no-unsafe-enum-comparison': 'warn',
-        '@typescript-eslint/no-unnecessary-condition': [
-          'warn',
-          {
-            allowConstantLoopConditions: false,
-            allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing: false,
-          },
-        ],
-        '@typescript-eslint/no-unnecessary-qualifier': 'error',
-        '@typescript-eslint/no-unnecessary-type-arguments': 'error',
-        '@typescript-eslint/no-unnecessary-type-assertion': 'error',
-        '@typescript-eslint/no-unsafe-unary-minus': 'error',
-        '@typescript-eslint/no-useless-template-literals': 'warn',
-        '@typescript-eslint/non-nullable-type-assertion-style': 'warn',
-        '@typescript-eslint/prefer-includes': 'warn',
-        '@typescript-eslint/prefer-optional-chain': 'warn',
-        '@typescript-eslint/prefer-reduce-type-parameter': 'warn',
-        '@typescript-eslint/prefer-nullish-coalescing': [
-          'warn',
-          {
-            ignoreConditionalTests: false,
-            ignoreTernaryTests: false,
-            ignoreMixedLogicalExpressions: false,
-            allowRuleToRunWithoutStrictNullChecksIKnowWhatIAmDoing: false,
-          },
-        ],
-        '@typescript-eslint/prefer-regexp-exec': 'warn',
-        '@typescript-eslint/prefer-promise-reject-errors': 'warn',
-        '@typescript-eslint/prefer-return-this-type': 'warn',
-        '@typescript-eslint/prefer-string-starts-ends-with': 'warn',
-        '@typescript-eslint/restrict-template-expressions': [
-          'warn',
-          { allowNumber: true, allowBoolean: false, allowAny: false, allowNullish: false, allowRegExp: false, allowNever: false },
-        ],
-        '@typescript-eslint/require-array-sort-compare': ['error', { ignoreStringArrays: true }],
-        '@typescript-eslint/require-await': 'error',
-        '@typescript-eslint/return-await': 'error',
-        '@typescript-eslint/switch-exhaustiveness-check': 'error',
-        '@typescript-eslint/unbound-method': ['error', { ignoreStatic: true }],
-        '@typescript-eslint/naming-convention': [
-          'warn',
-          ...require('./naming-convention'),
-          // force use is/should/has for boolean variables
-          {
-            selector: 'variable',
-            types: ['boolean'],
-            format: ['PascalCase'],
-            prefix: ['is', 'should', 'has', 'can', 'did', 'will', 'enable', 'loading'],
-          },
-        ],
-
-        // collisions
-        'dot-notation': 'off',
-        'prefer-promise-reject-errors': 'off',
-        'consistent-return': 'off',
-      },
-    },
-  ],
-};

package/typescript.js

@@ -1,169 +0,0 @@
-/** @type { import('eslint').Linter.Config } */
-module.exports = {
-  overrides: [
-    {
-      files: ['*.ts', '*.tsx'],
-      parser: '@typescript-eslint/parser',
-      plugins: ['@typescript-eslint/eslint-plugin'],
-      extends: ['plugin:@typescript-eslint/recommended'],
-      settings: {
-        'import/parsers': {
-          '@typescript-eslint/parser': ['.ts', '.tsx'],
-        },
-        'import/resolver': {
-          node: {
-            extensions: ['.js', '.jsx', '.ts', '.tsx', '.d.ts', '.json', '.mjs'],
-          },
-        },
-      },
-      rules: {
-        '@typescript-eslint/adjacent-overload-signatures': 'error',
-        '@typescript-eslint/array-type': 'error',
-        '@typescript-eslint/ban-ts-comment': [
-          'error',
-          {
-            'ts-expect-error': 'allow-with-description',
-            'ts-ignore': 'allow-with-description',
-            'ts-nocheck': 'allow-with-description',
-            'ts-check': 'allow-with-description',
-            'minimumDescriptionLength': 3,
-          },
-        ],
-        '@typescript-eslint/ban-tslint-comment': 'off',
-        '@typescript-eslint/ban-types': 'error',
-        '@typescript-eslint/camelcase': 'off',
-        '@typescript-eslint/class-literal-property-style': ['error', 'getters'],
-        '@typescript-eslint/consistent-generic-constructors': ['warn', 'constructor'],
-        '@typescript-eslint/consistent-indexed-object-style': 'off',
-        '@typescript-eslint/consistent-type-assertions': 'error',
-        '@typescript-eslint/consistent-type-definitions': ['error', 'interface'],
-        '@typescript-eslint/consistent-type-imports': [
-          'warn',
-          { prefer: 'type-imports', disallowTypeAnnotations: false, fixStyle: 'separate-type-imports' },
-        ],
-        '@typescript-eslint/default-param-last': 'warn',
-        '@typescript-eslint/explicit-function-return-type': 'off',
-        '@typescript-eslint/explicit-member-accessibility': 'off',
-        '@typescript-eslint/explicit-module-boundary-types': 'off',
-        '@typescript-eslint/generic-type-naming': 'off',
-        '@typescript-eslint/init-declarations': 'off',
-        '@typescript-eslint/lines-between-class-members': ['warn', 'always', { exceptAfterSingleLine: true }],
-        '@typescript-eslint/member-naming': 'off',
-        '@typescript-eslint/member-ordering': 'off',
-        '@typescript-eslint/method-signature-style': ['warn', 'property'],
-        '@typescript-eslint/naming-convention': ['warn', ...require('./naming-convention')],
-        '@typescript-eslint/no-array-constructor': 'error',
-        '@typescript-eslint/no-base-to-string': 'off', // false negative
-        '@typescript-eslint/no-confusing-non-null-assertion': 'error',
-        '@typescript-eslint/no-dupe-class-members': 'error',
-        '@typescript-eslint/no-duplicate-enum-values': 'error',
-        '@typescript-eslint/no-dynamic-delete': 'error',
-        '@typescript-eslint/no-empty-function': 'error',
-        '@typescript-eslint/no-empty-interface': 'off', // Annoying with auto-fix on save.
-        '@typescript-eslint/no-explicit-any': 'off',
-        '@typescript-eslint/no-extra-non-null-assertion': 'error',
-        '@typescript-eslint/no-extraneous-class': ['warn', { allowWithDecorator: true }],
-        '@typescript-eslint/no-import-type-side-effects': 'warn',
-        '@typescript-eslint/no-inferrable-types': 'off',
-        '@typescript-eslint/no-invalid-this': ['error', { capIsConstructor: false }],
-        '@typescript-eslint/no-invalid-void-type': 'error',
-        '@typescript-eslint/no-loop-func': 'error',
-        '@typescript-eslint/no-loss-of-precision': 'error',
-        '@typescript-eslint/no-magic-numbers': ['off', { ignoreEnums: true }], // Not good enough yet
-        '@typescript-eslint/no-misused-new': 'error',
-        '@typescript-eslint/no-namespace': 'error',
-        '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error',
-        '@typescript-eslint/no-non-null-asserted-optional-chain': 'error',
-        '@typescript-eslint/no-non-null-assertion': 'off',
-        '@typescript-eslint/no-redeclare': ['off', { ignoreDeclarationMerge: true }], // useful in FP.
-        '@typescript-eslint/no-require-imports': 'error',
-        '@typescript-eslint/no-restricted-imports': 'off',
-        '@typescript-eslint/no-shadow': 'error',
-        '@typescript-eslint/no-this-alias': 'error',
-        '@typescript-eslint/no-type-alias': 'off',
-        '@typescript-eslint/no-unnecessary-type-constraint': 'warn',
-        '@typescript-eslint/no-unsafe-argument': 'off',
-        '@typescript-eslint/no-unsafe-assignment': 'off',
-        '@typescript-eslint/no-unsafe-call': 'off',
-        '@typescript-eslint/no-unsafe-declaration-merging': 'warn',
-        '@typescript-eslint/no-unsafe-member-access': 'off',
-        '@typescript-eslint/no-unsafe-return': 'off',
-        '@typescript-eslint/no-untyped-public-signature': 'off',
-        '@typescript-eslint/no-unused-expressions': 'error',
-        '@typescript-eslint/no-unused-vars-experimental': 'off', // Why two rules?
-        '@typescript-eslint/no-unused-vars': [
-          'warn',
-          { argsIgnorePattern: '^_', varsIgnorePattern: '^([iI]gnore(d)?)|(_+)', args: 'after-used', ignoreRestSiblings: true },
-        ],
-        '@typescript-eslint/no-use-before-define': ['error', { functions: false, classes: true }],
-        '@typescript-eslint/no-useless-constructor': 'error',
-        '@typescript-eslint/no-useless-empty-export': 'warn',
-        '@typescript-eslint/no-var-requires': 'error',
-        '@typescript-eslint/object-curly-spacing': 'warn',
-        '@typescript-eslint/parameter-properties': 'off',
-        '@typescript-eslint/padding-line-between-statements': [
-          'warn',
-          {
-            blankLine: 'always',
-            prev: '*',
-            next: ['class', 'for', 'while', 'switch', 'do', 'directive', 'function', 'iife', 'block-like'],
-          },
-          { blankLine: 'always', prev: ['block-like', 'block'], next: ['return'] },
-          { blankLine: 'always', prev: ['block-like'], next: ['const', 'let', 'var'] },
-          { blankLine: 'always', prev: ['const', 'let', 'var'], next: ['type', 'interface'] },
-          { blankLine: 'always', prev: ['multiline-const', 'multiline-let', 'multiline-var'], next: ['if'] },
-        ],
-        '@typescript-eslint/prefer-as-const': 'warn',
-        '@typescript-eslint/prefer-enum-initializers': 'off',
-        '@typescript-eslint/prefer-for-of': 'warn',
-        '@typescript-eslint/prefer-function-type': 'warn',
-        '@typescript-eslint/prefer-literal-enum-member': ['error', { allowBitwiseExpressions: true }],
-        '@typescript-eslint/prefer-namespace-keyword': 'error',
-        '@typescript-eslint/prefer-readonly-parameter-types': [
-          'off',
-          { checkParameterProperties: true, ignoreInferredTypes: false, treatMethodsAsReadonly: true },
-        ], // I'm not sure...
-        '@typescript-eslint/prefer-readonly': 'off',
-        '@typescript-eslint/prefer-readonlysemi': 'off', // Annoying with auto-fix on save.
-        '@typescript-eslint/prefer-ts-expect-error': 'off',
-        '@typescript-eslint/promise-function-async': 'off',
-        '@typescript-eslint/restrict-plus-operands': 'off',
-        '@typescript-eslint/sort-type-constituents': [
-          'warn',
-          {
-            checkIntersections: true,
-            checkUnions: true,
-            groupOrder: [
-              'named',
-              'keyword',
-              'operator',
-              'literal',
-              'function',
-              'import',
-              'conditional',
-              'object',
-              'tuple',
-              'intersection',
-              'union',
-              'nullish',
-            ],
-          },
-        ],
-        '@typescript-eslint/strict-boolean-expressions': 'off', // Annoying
-        '@typescript-eslint/space-before-blocks': 'off',
-
-        '@typescript-eslint/triple-slash-reference': 'error',
-        '@typescript-eslint/typedef': ['error', { parameter: false, arrowParameter: false, variableDeclaration: false }],
-        '@typescript-eslint/unified-signatures': 'error',
-        '@typescript-eslint/key-spacing': 'off',
-
-        // open issues
-        'react/jsx-no-useless-fragment': 'off', // Need useless-fragment for JSX return type
-        'import/named': 'off',
-        'import/namespace': 'off',
-        'import/default': 'off',
-        'import/no-named-as-default-member': 'off',
-      },
-    },
-  ],
-};

package/utils.js

@@ -1,21 +0,0 @@
-const readPkgUp = require('read-pkg-up');
-const fs = require('node:fs');
-
-const { packageJson } = readPkgUp.sync({
-  cwd: fs.realpathSync(process.cwd()),
-});
-
-const hasProperty = (obj, prop) => typeof obj === 'object' && Reflect.has(obj, prop);
-
-const hasDep = dep => {
-  const types = ['peerDependencies', 'dependencies', 'devDependencies', 'optionalDependencies'];
-  return types.some(type => hasProperty(packageJson[type], dep));
-};
-
-const isEsm = () => {
-  return packageJson.type === 'module';
-};
-
-module.exports.hasDep = hasDep;
-module.exports.isEsm = isEsm;
-module.exports.exts = '+(js|jsx|mjs|cjs|ts|tsx|mts|cts)';