@fullstacksjs/eslint-config 10.11.1 → 11.0.0

package/LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2021 FullstacksJS
+Copyright (c) 2024 FullstacksJS
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

package/README.md

@@ -53,15 +53,17 @@ When auto module detection is turned on, the configuration reads the metadata fr
 
 ```typescript
 interface Modules {
-    auto?: boolean; // Auto module detection
     react?: boolean; // controls react, react-hooks, jsx/a11y plugins
     typescript?: { // controls typescript plugin
-      parserProject?: boolean | string[] | string; // controls parserOptions.project
-      resolverProject?: string[] | string // controls settings['import/resolver'].typescript.project
+      projects?: boolean | string[] | string; // controls parserOptions.project
     };
     node?: boolean; // controls node plugin
     strict?: boolean; // controls strict plugin
-    import?: boolean; // controls import plugin
+    import?: {
+      projects?: string[] | string // controls settings['import/resolver'].typescript.project
+      internalRegExp?: string;
+      lifetime?: number;
+    }; // controls import plugin
     esm?: boolean; // controls esm plugin
     graphql?: boolean; // controls graphql plugin
     test?: boolean; // controls jest/vitest plugin

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fullstacksjs/eslint-config",
-  "version": "10.11.1",
+  "version": "11.0.0",
   "license": "MIT",
   "author": "fullstacks <fullstacksjs@gmail.com>",
   "description": "fullstacks eslint config",
@@ -12,85 +12,62 @@
     "registry": "https://registry.npmjs.org"
   },
   "files": [
-    "base.js",
-    "cypress.js",
-    "esm.js",
-    "fp.js",
-    "graphql.js",
-    "import.js",
-    "index.d.ts",
-    "init.d.ts",
-    "init.js",
-    "jest.js",
-    "naming-convention.js",
-    "next.js",
-    "node.js",
-    "packages.js",
-    "prettier.js",
-    "expensive-rules.js",
-    "promise.js",
-    "react.js",
-    "registerOpts.js",
-    "storybook.js",
-    "strict.js",
-    "tailwind.js",
-    "test.js",
-    "typecheck.js",
-    "typescript.js",
-    "utils.js"
+    "src"
   ],
   "scripts": {
     "lint": "eslint .",
     "spell": "cspell ./* --no-progress",
-    "test": "./tests/test",
+    "test": "echo 0",
     "prepublishOnly": "pinst --disable",
     "postpublish": "pinst --enable",
     "pre-commit": "npm run test && lint-staged"
   },
-  "main": "index.js",
+  "main": "src/index.js",
   "dependencies": {
     "@graphql-eslint/eslint-plugin": "3.20.1",
-    "@typescript-eslint/eslint-plugin": "7.1.0",
-    "@typescript-eslint/parser": "7.1.0",
+    "typescript-eslint": "rc-v8",
     "deepmerge": "4.3.1",
-    "eslint-config-next": "14.1.1",
-    "eslint-config-prettier": "9.1.0",
     "eslint-import-resolver-typescript": "3.6.1",
-    "eslint-plugin-cypress": "2.15.1",
-    "eslint-plugin-fp": "2.3.0",
-    "eslint-plugin-import": "2.29.1",
-    "eslint-plugin-jest": "27.9.0",
+    "eslint-plugin-cypress": "3.3.0",
+    "eslint-plugin-functional": "6.5.1",
+    "eslint-plugin-import-x": "0.5.1",
+    "eslint-plugin-jest": "28.6.0",
     "eslint-plugin-jest-formatting": "3.1.0",
     "eslint-plugin-jsx-a11y": "6.8.0",
-    "eslint-plugin-node": "11.1.0",
+    "eslint-plugin-n": "17.8.1",
     "eslint-plugin-prettier": "5.1.3",
-    "eslint-plugin-promise": "6.1.1",
-    "eslint-plugin-react": "7.33.2",
-    "eslint-plugin-react-hooks": "4.6.0",
-    "eslint-plugin-simple-import-sort": "12.0.0",
+    "eslint-plugin-promise": "6.2.0",
+    "eslint-plugin-react": "7.34.2",
+    "eslint-plugin-react-hooks": "4.6.2",
     "eslint-plugin-storybook": "0.8.0",
-    "eslint-plugin-tailwindcss": "3.14.3",
-    "read-pkg-up": "7.0.1"
+    "eslint-plugin-tailwindcss": "3.17.3",
+    "eslint-plugin-vitest": "0.5.4",
+    "globals": "15.4.0"
   },
   "devDependencies": {
+    "@eslint/eslintrc": "3.1.0",
+    "@eslint/js": "9.4.0",
     "@semantic-release/github": "9.2.6",
     "@semantic-release/npm": "11.0.3",
     "@semantic-release/release-notes-generator": "12.1.0",
-    "cspell": "8.5.0",
-    "eslint": "8.57.0",
+    "@types/eslint": "8.56.10",
+    "cspell": "8.8.4",
+    "eslint": "9.4.0",
     "eslint-find-rules": "4.1.0",
     "husky": "9.0.11",
-    "lint-staged": "15.2.2",
+    "jest": "29.7.0",
+    "lint-staged": "15.2.5",
+    "local-pkg": "0.5.0",
     "np": "10.0.0",
     "npm-run-all": "4.1.5",
     "pinst": "3.0.0",
-    "prettier": "3.2.5",
+    "prettier": "3.3.1",
     "semantic-release": "23.0.2",
-    "typescript": "5.3.3"
+    "typescript": "5.4.5"
   },
   "peerDependencies": {
     "cypress": ">=8",
-    "eslint": ">=7",
+    "eslint": ">=9",
     "graphql": ">=15",
     "prettier": "3",
     "react": ">=16",

package/src/index.js

@@ -0,0 +1,86 @@
+const merge = require('deepmerge');
+const { isPackageExists } = require('local-pkg');
+const base = require('./modules/base');
+const cypress = require('./modules/cypress');
+const ignores = require('./modules/ignores');
+const imports = require('./modules/imports');
+const prettier = require('./modules/prettier');
+const tailwind = require('./modules/tailwind');
+// const graphql = require('./modules/graphql');
+const fp = require('./modules/fp');
+const node = require('./modules/node');
+const tests = require('./modules/tests');
+const jest = require('./modules/jest');
+const vitest = require('./modules/vitest');
+// const next = require('./modules/next');
+const strict = require('./modules/strict');
+const react = require('./modules/react');
+const storybook = require('./modules/storybook');
+const typescript = require('./modules/typescript');
+
+const testPackages = ['jest', 'vitest', 'cypress', 'playwright'];
+
+/** @type {import('./init').Options} */
+const defaultOptions = {
+  disableExpensiveRules: false,
+  fp: true,
+  esm: false,
+  node: false,
+  strict: false,
+  import: {},
+  test: testPackages.some(p => isPackageExists(p)),
+  react: isPackageExists('react'),
+  jest: isPackageExists('jest'),
+  vitest: isPackageExists('vitest'),
+  next: isPackageExists('next'),
+  tailwind: isPackageExists('tailwindcss'),
+  graphql: isPackageExists('graphql'),
+  cypress: isPackageExists('cypress'),
+  storybook: isPackageExists('storybook'),
+  prettier: isPackageExists('prettier'),
+  typescript: isPackageExists('typescript') ? { projects: true } : false,
+  unocss: isPackageExists('unocss'),
+};
+
+/**
+ * Initialize eslint config
+ *
+ * @param {import('./init').Options} initOptions
+ * @param {...(import('eslint').Linter.FlatConfig)} extend
+ * @returns {import('eslint').Linter.FlatConfig[]}
+ */
+function init(initOptions, ...extend) {
+  const options = merge(defaultOptions, initOptions);
+  if (options.typescript === true) {
+    options.typescript = {};
+  }
+  if (options.import === true) {
+    options.import = {};
+  }
+
+  const rules = [ignores(), base()];
+
+  if (options.fp) rules.push(fp(options));
+  if (options.import) rules.push(imports(options));
+  if (options.tailwind) rules.push(tailwind(options));
+  if (options.test) rules.push(tests(options));
+  if (options.node) rules.push(node(options));
+  if (options.jest) rules.push(jest(options));
+  if (options.vitest) rules.push(vitest(options));
+  if (options.cypress) rules.push(cypress(options));
+  if (options.react) rules.push(react(options));
+  if (options.storybook) rules.push(storybook(options));
+  if (options.typescript) rules.push(typescript(options));
+
+  // ISSUE: Waiting for FlatConfig support https://github.com/dimaMachina/graphql-eslint/issues/2178
+  // if (false && options.graphql) rules.push(graphql(options));
+  // ISSUE: Waiting for FlatConfig support https://github.com/vercel/next/issues/64409#issuecomment-2057325722
+  // if (false && options.next) rules.push(next(options));
+
+  if (options.strict) rules.push(strict(options));
+  if (options.prettier) rules.push(prettier(options));
+
+  return rules.concat(extend);
+}
+
+module.exports.init = init;

package/src/init.d.ts

@@ -0,0 +1,21 @@
+export interface Options {
+  react?: boolean;
+  next?: boolean;
+  tailwind?: boolean;
+  node?: boolean;
+  strict?: boolean;
+  import?: boolean | { internalRegExp?: string; lifetime?: number; projects?: string[] | string };
+  esm?: boolean;
+  fp?: boolean;
+  graphql?: boolean;
+  test?: boolean;
+  jest?: boolean;
+  vitest?: boolean;
+  cypress?: boolean;
+  storybook?: boolean;
+  prettier?: boolean;
+  typescript?: { projects: string[] | string };
+  disableExpensiveRules?: boolean;
+}
+
+export declare const init: (opts: Options) => import('eslint').Linter.FlatConfig[];

package/src/modules/base.js

@@ -0,0 +1,187 @@
+const globals = require('globals');
+const { strict } = require('../utils/conditions');
+
+/**
+ * @param {{strict?: boolean}} options
+ * @return { import('eslint').Linter.FlatConfig }
+ */
+function base(options = {}) {
+  return {
+    languageOptions: {
+      ecmaVersion: 'latest',
+      sourceType: 'module',
+      globals: {
+        ...globals.browser,
+        ...globals.node,
+        ...globals.es2024,
+      },
+      parserOptions: {
+        ecmaFeatures: {
+          jsx: true,
+        },
+      },
+    },
+
+    rules: {
+      'accessor-pairs': 'error',
+      'array-callback-return': 'error',
+      'block-scoped-var': 'error',
+      'camelcase': ['warn', { properties: 'always' }],
+      'complexity': ['error', 14],
+      'constructor-super': 'error',
+      'default-case-last': 'error',
+      'default-case': 'error',
+      'default-param-last': 'warn',
+      'dot-notation': 'error',
+      'eqeqeq': ['error', 'smart'],
+      'for-direction': 'error',
+      'func-name-matching': 'error',
+      'func-names': 'error',
+      'getter-return': ['error', { allowImplicit: true }],
+      'guard-for-in': 'error',
+      'max-depth': ['error', 4],
+      'max-lines-per-function': ['error', 150],
+      'max-lines': ['error', { max: 2500, skipBlankLines: false, skipComments: false }],
+      'max-nested-callbacks': ['error', 7],
+      'max-params': ['error', 7],
+      'max-statements': ['error', 40],
+      'no-alert': 'error',
+      'no-array-constructor': 'error',
+      'no-await-in-loop': 'error',
+      'no-bitwise': 'error',
+      'no-caller': 'error',
+      'no-case-declarations': 'error',
+      'no-class-assign': 'error',
+      'no-compare-neg-zero': 'error',
+      'no-cond-assign': 'error',
+      'no-const-assign': 'error',
+      'no-constant-binary-expression': 'warn',
+      'no-constant-condition': 'error',
+      'no-constructor-return': 'error',
+      'no-control-regex': 'error',
+      'no-debugger': 'error',
+      'no-delete-var': 'error',
+      'no-div-regex': 'error',
+      'no-dupe-args': 'error',
+      'no-dupe-class-members': 'error',
+      'no-dupe-else-if': 'error',
+      'no-dupe-keys': 'error',
+      'no-duplicate-case': 'error',
+      'no-empty-character-class': 'error',
+      'no-empty-pattern': 'error',
+      'no-empty-static-block': 'warn',
+      'no-empty': 'error',
+      'no-eval': 'error',
+      'no-ex-assign': 'error',
+      'no-extend-native': 'error',
+      'no-extra-bind': 'error',
+      'no-extra-label': 'error',
+      'no-fallthrough': 'error',
+      'no-floating-decimal': 'error',
+      'no-func-assign': 'error',
+      'no-global-assign': 'error',
+      'no-implicit-globals': 'error',
+      'no-implied-eval': 'error',
+      'no-import-assign': 'error',
+      'no-inner-declarations': 'error',
+      'no-invalid-regexp': 'error',
+      'no-invalid-this': 'warn',
+      'no-irregular-whitespace': 'error',
+      'no-iterator': 'error',
+      'no-label-var': 'error',
+      'no-labels': 'error',
+      'no-lone-blocks': 'error',
+      'no-lonely-if': 'error',
+      'no-loop-func': 'error',
+      'no-loss-of-precision': 'warn',
+      'no-multi-assign': 'error',
+      'no-multi-str': 'error',
+      'no-new-func': 'error',
+      'no-new-native-nonconstructor': 'error',
+      'no-new-wrappers': 'error',
+      'no-new': 'error',
+      'no-nonoctal-decimal-escape': 'error',
+      'no-obj-calls': 'error',
+      'no-object-constructor': 'error',
+      'no-octal-escape': 'error',
+      'no-octal': 'error',
+      'no-promise-executor-return': 'error',
+      'no-proto': 'error',
+      'no-redeclare': 'error',
+      'no-regex-spaces': 'error',
+      'no-restricted-globals': ['error', { name: 'event', message: 'Use local parameter instead.' }],
+      'no-restricted-syntax': ['error', 'WithStatement'],
+      'no-return-assign': 'error',
+      'no-return-await': 'error',
+      'no-script-url': 'error',
+      'no-self-assign': 'error',
+      'no-self-compare': 'error',
+      'no-sequences': 'error',
+      'no-setter-return': 'error',
+      'no-shadow-restricted-names': 'error',
+      'no-shadow': 'error',
+      'no-sparse-arrays': 'error',
+      'no-this-before-super': 'error',
+      'no-throw-literal': 'error',
+      'no-undef-init': 'error',
+      'no-undef': 'error',
+      'no-unexpected-multiline': 'error',
+      'no-unmodified-loop-condition': 'error',
+      'no-unneeded-ternary': 'error',
+      'no-unreachable-loop': 'error',
+      'no-unreachable': 'error',
+      'no-unsafe-finally': 'error',
+      'no-unsafe-negation': 'error',
+      'no-unsafe-optional-chaining': 'error',
+      'no-unused-labels': 'error',
+      'no-unused-private-class-members': 'warn',
+      'no-unused-vars': [
+        'error',
+        { argsIgnorePattern: '^_', varsIgnorePattern: '^ignore(d)?', args: 'after-used', ignoreRestSiblings: true },
+      ],
+      'no-use-before-define': ['error', 'nofunc'],
+      'no-useless-backreference': 'error',
+      'no-useless-call': 'error',
+      'no-useless-catch': 'error',
+      'no-useless-computed-key': 'error',
+      'no-useless-concat': 'error',
+      'no-useless-constructor': 'error',
+      'no-useless-escape': 'error',
+      'no-useless-rename': 'error',
+      'no-useless-return': 'error',
+      'no-var': 'warn',
+      'no-warning-comments': ['warn', { terms: ['fixme'], location: 'anywhere' }],
+      'object-shorthand': ['error', 'properties'],
+      'one-var': ['error', { uninitialized: 'never', initialized: 'never' }],
+      'prefer-arrow-callback': ['warn', { allowNamedFunctions: true, allowUnboundThis: true }],
+      'prefer-const': 'warn',
+      'prefer-exponentiation-operator': 'warn',
+      'prefer-numeric-literals': 'error',
+      'prefer-object-has-own': 'warn',
+      'prefer-rest-params': 'error',
+      'prefer-spread': 'error',
+      'prefer-template': 'error',
+      'radix': 'error',
+      'require-await': 'error',
+      'require-yield': 'error',
+      'strict': 'error',
+      'symbol-description': 'error',
+      'use-isnan': 'error',
+      'valid-typeof': 'error',
+      'vars-on-top': 'error',
+      'yoda': 'error',
+
+      'require-atomic-updates': 'warn',
+      'no-async-promise-executor': 'warn',
+      'grouped-accessor-pairs': 'warn',
+      'no-extra-boolean-cast': 'warn',
+      'no-param-reassign': 'warn',
+      'prefer-regex-literals': ['warn', { disallowRedundantWrapping: true }],
+
+      'no-console': strict(options, 'off'),
+      'no-empty-function': strict(options, 'off'),
+    },
+  };
+}
+
+module.exports = base;

package/src/modules/cypress.js

@@ -0,0 +1,23 @@
+const plugin = require('eslint-plugin-cypress/flat');
+const { globs } = require('../utils/globs');
+
+/** @return { import('eslint').Linter.FlatConfig } */
+function cypress() {
+  return {
+    files: globs.e2e,
+    plugins: { cypress: plugin },
+    rules: {
+      'cypress/assertion-before-screenshot': 'warn',
+      'cypress/no-assigning-return-values': 'error',
+      'cypress/no-async-tests': 'error',
+      'cypress/no-force': 'warn',
+      'cypress/no-pause': 'error',
+      'cypress/no-unnecessary-waiting': 'error',
+      'cypress/require-data-selectors': 'off',
+      'cypress/unsafe-to-chain-command': 'error',
+      '@typescript-eslint/no-namespace': 'off',
+    },
+  };
+}
+
+module.exports = cypress;

package/{esm.js → src/modules/esm.js}

@@ -1,4 +1,4 @@
-/** @type { import('eslint').Linter.Config } */
+/** @type { import('eslint').Linter.FlatConfig } */
 module.exports = {
   rules: {
     ...(global.fullstacksjs?.import && { 'import/extensions': ['error', { mjs: 'ignorePackages' }] }),

package/src/modules/fp.js

@@ -0,0 +1,16 @@
+const plugin = require('eslint-plugin-functional/flat');
+
+/** @return { import('eslint').Linter.FlatConfig } */
+function fp() {
+  return {
+    plugins: { functional: plugin },
+    rules: {
+      'functional/functional-parameters': 'off',
+      'functional/no-let': ['error', { allowInForLoopInit: true }],
+      'functional/no-loop-statements': 'error',
+      'functional/immutable-data': ['error', { ignoreClasses: true, ignoreImmediateMutation: true, ignoreNonConstDeclarations: true }],
+    },
+  };
+}
+
+module.exports = fp;

package/src/modules/graphql.js

@@ -0,0 +1,84 @@
+const plugin = require('@graphql-eslint/eslint-plugin');
+const globs = require('../utils/globs');
+
+plugin.configs['schema-recommended'].parser;
+
+/** @return { import('eslint').Linter.FlatConfig } */
+function graphql() {
+  return {
+    files: globs.globs.graphql,
+    plugins: { graphql: plugin },
+    languageOptions: {
+      parser: plugin.configs['schema-recommended'].parser,
+    },
+    rules: {
+      '@graphql-eslint/alphabetize': ['warn', { fields: ['ObjectTypeDefinition'] }],
+      '@graphql-eslint/description-style': 'warn',
+      '@graphql-eslint/executable-definitions': 'off',
+      '@graphql-eslint/fields-on-correct-type': 'warn',
+      '@graphql-eslint/fragments-on-composite-type': 'warn',
+      '@graphql-eslint/input-name': 'warn',
+      '@graphql-eslint/known-argument-names': 'warn',
+      '@graphql-eslint/known-directives': 'warn',
+      '@graphql-eslint/known-fragment-names': 'warn',
+      '@graphql-eslint/known-type-names': 'warn',
+      '@graphql-eslint/lone-anonymous-operation': 'warn',
+      '@graphql-eslint/lone-executable-definition': 'off',
+      '@graphql-eslint/lone-schema-definition': 'warn',
+      '@graphql-eslint/match-document-filename': ['warn', { query: 'camelCase', mutation: 'camelCase', subscription: 'camelCase' }],
+      '@graphql-eslint/naming-convention': 'warn',
+      '@graphql-eslint/no-anonymous-operations': 'warn',
+      '@graphql-eslint/no-case-insensitive-enum-values-duplicates': 'warn',
+      '@graphql-eslint/no-deprecated': 'warn',
+      '@graphql-eslint/no-duplicate-fields': 'warn',
+      '@graphql-eslint/no-fragment-cycles': 'warn',
+      '@graphql-eslint/no-hashtag-description': 'warn',
+      '@graphql-eslint/no-one-place-fragments': 'off',
+      '@graphql-eslint/no-root-type': 'off',
+      '@graphql-eslint/no-scalar-result-type-on-mutation': 'warn',
+      '@graphql-eslint/no-typename-prefix': 'warn',
+      '@graphql-eslint/no-undefined-variables': 'warn',
+      '@graphql-eslint/no-unreachable-types': 'warn',
+      '@graphql-eslint/no-unused-fields': 'warn',
+      '@graphql-eslint/no-unused-fragments': 'warn',
+      '@graphql-eslint/no-unused-variables': 'warn',
+      '@graphql-eslint/one-field-subscriptions': 'warn',
+      '@graphql-eslint/overlapping-fields-can-be-merged': 'warn',
+      '@graphql-eslint/possible-fragment-spread': 'warn',
+      '@graphql-eslint/possible-type-extension': 'warn',
+      '@graphql-eslint/provided-required-arguments': 'warn',
+      '@graphql-eslint/relay-arguments': 'warn',
+      '@graphql-eslint/relay-connection-types': 'warn',
+      '@graphql-eslint/relay-edge-types': 'warn',
+      '@graphql-eslint/relay-page-info': 'warn',
+      '@graphql-eslint/require-deprecation-date': 'warn',
+      '@graphql-eslint/require-deprecation-reason': 'warn',
+      '@graphql-eslint/require-description': 'off',
+      '@graphql-eslint/require-field-of-type-query-in-mutation-result': 'warn',
+      '@graphql-eslint/require-id-when-available': 'warn',
+      '@graphql-eslint/require-import-fragment': 'off',
+      '@graphql-eslint/require-nullable-fields-with-oneof': 'warn',
+      '@graphql-eslint/require-nullable-result-in-root': 'off',
+      '@graphql-eslint/require-type-pattern-with-oneof': 'warn',
+      '@graphql-eslint/scalar-leafs': 'warn',
+      '@graphql-eslint/selection-set-depth': 'off',
+      '@graphql-eslint/strict-id-in-types': 'warn',
+      '@graphql-eslint/unique-argument-names': 'warn',
+      '@graphql-eslint/unique-directive-names-per-location': 'warn',
+      '@graphql-eslint/unique-directive-names': 'warn',
+      '@graphql-eslint/unique-enum-value-names': 'warn',
+      '@graphql-eslint/unique-field-definition-names': 'warn',
+      '@graphql-eslint/unique-fragment-name': 'warn',
+      '@graphql-eslint/unique-input-field-names': 'warn',
+      '@graphql-eslint/unique-operation-name': 'warn',
+      '@graphql-eslint/unique-operation-types': 'warn',
+      '@graphql-eslint/unique-type-names': 'warn',
+      '@graphql-eslint/unique-variable-names': 'warn',
+      '@graphql-eslint/value-literals-of-correct-type': 'warn',
+      '@graphql-eslint/variables-are-input-types': 'warn',
+      '@graphql-eslint/variables-in-allowed-position': 'warn',
+    },
+  };
+}
+
+module.exports = graphql;

package/src/modules/ignores.js

@@ -0,0 +1,39 @@
+/** @return { import('eslint').Linter.FlatConfig } */
+function ignores() {
+  return {
+    name: 'fullstacksjs/ignores',
+    ignores: [
+      '**/node_modules',
+      '**/dist',
+      '**/package-lock.json',
+      '**/yarn.lock',
+      '**/pnpm-lock.yaml',
+      '**/bun.lockb',
+
+      '**/output',
+      '**/coverage',
+      '**/temp',
+      '**/.temp',
+      '**/tmp',
+      '**/.tmp',
+      '**/.nx',
+      '**/.history',
+      '**/.vitepress/cache',
+      '**/.nuxt',
+      '**/.next',
+      '**/.vercel',
+      '**/.changeset',
+      '**/.idea',
+      '**/.cache',
+      '**/.output',
+      '**/.vite-inspect',
+      '**/.yarn',
+      '**/LICENSE*',
+      '**/*.min.*',
+
+      '**/__snapshots__',
+    ],
+  };
+}
+
+module.exports = ignores;