@fro.bot/systematic 2.0.3 → 2.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/agents/research/learnings-researcher.md +27 -26
- package/agents/review/api-contract-reviewer.md +1 -1
- package/agents/review/correctness-reviewer.md +1 -1
- package/agents/review/data-migrations-reviewer.md +1 -1
- package/agents/review/dhh-rails-reviewer.md +31 -52
- package/agents/review/julik-frontend-races-reviewer.md +27 -200
- package/agents/review/kieran-python-reviewer.md +29 -116
- package/agents/review/kieran-rails-reviewer.md +29 -98
- package/agents/review/kieran-typescript-reviewer.md +29 -107
- package/agents/review/maintainability-reviewer.md +1 -1
- package/agents/review/performance-reviewer.md +1 -1
- package/agents/review/reliability-reviewer.md +1 -1
- package/agents/review/security-reviewer.md +1 -1
- package/agents/review/testing-reviewer.md +1 -1
- package/agents/workflow/pr-comment-resolver.md +99 -50
- package/dist/index.js +9 -0
- package/dist/lib/config-handler.d.ts +2 -0
- package/package.json +1 -1
- package/skills/ce-compound/SKILL.md +100 -27
- package/skills/ce-compound-refresh/SKILL.md +172 -74
- package/skills/ce-review/SKILL.md +379 -418
- package/skills/ce-work/SKILL.md +5 -4
- package/skills/ce-work-beta/SKILL.md +6 -5
- package/skills/claude-permissions-optimizer/scripts/extract-commands.mjs +9 -159
- package/skills/claude-permissions-optimizer/scripts/normalize.mjs +151 -0
- package/skills/git-worktree/scripts/worktree-manager.sh +163 -0
- package/skills/lfg/SKILL.md +2 -2
- package/skills/orchestrating-swarms/SKILL.md +1 -1
- package/skills/setup/SKILL.md +8 -137
- package/skills/slfg/SKILL.md +8 -4
- package/skills/test-browser/SKILL.md +2 -2
- package/skills/test-xcode/SKILL.md +2 -2
package/skills/setup/SKILL.md
CHANGED
|
@@ -1,151 +1,22 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: setup
|
|
3
|
-
description: Configure
|
|
3
|
+
description: Configure project-level settings for systematic workflows. Currently a placeholder — review agent selection is handled automatically by ce:review.
|
|
4
4
|
disable-model-invocation: true
|
|
5
5
|
---
|
|
6
6
|
|
|
7
7
|
# Systematic Setup
|
|
8
8
|
|
|
9
|
-
|
|
9
|
+
Project-level configuration for systematic workflows.
|
|
10
10
|
|
|
11
|
-
|
|
11
|
+
## Current State
|
|
12
12
|
|
|
13
|
-
|
|
13
|
+
Review agent selection is handled automatically by the `ce:review` skill, which uses intelligent tiered selection based on diff content. No per-project configuration is needed for code reviews.
|
|
14
14
|
|
|
15
|
-
|
|
15
|
+
If this skill is invoked, inform the user:
|
|
16
16
|
|
|
17
|
-
|
|
17
|
+
> Review agent configuration is no longer needed — `ce:review` automatically selects the right reviewers based on your diff. Project-specific review context (e.g., "we serve 10k req/s" or "watch for N+1 queries") belongs in your project's AGENTS.md or AGENTS.md, where all agents already read it.
|
|
18
18
|
|
|
19
|
-
|
|
20
|
-
Settings file already exists. What would you like to do?
|
|
19
|
+
## Future Use
|
|
21
20
|
|
|
22
|
-
|
|
23
|
-
2. View current - Show the file contents, then stop
|
|
24
|
-
3. Cancel - Keep current settings
|
|
25
|
-
```
|
|
26
|
-
|
|
27
|
-
If "View current": read and display the file, then stop.
|
|
28
|
-
If "Cancel": stop.
|
|
29
|
-
|
|
30
|
-
## Step 2: Detect and Ask
|
|
31
|
-
|
|
32
|
-
Auto-detect the project stack:
|
|
33
|
-
|
|
34
|
-
```bash
|
|
35
|
-
test -f Gemfile && test -f config/routes.rb && echo "rails" || \
|
|
36
|
-
test -f Gemfile && echo "ruby" || \
|
|
37
|
-
test -f tsconfig.json && echo "typescript" || \
|
|
38
|
-
test -f package.json && echo "javascript" || \
|
|
39
|
-
test -f pyproject.toml && echo "python" || \
|
|
40
|
-
test -f requirements.txt && echo "python" || \
|
|
41
|
-
echo "general"
|
|
42
|
-
```
|
|
43
|
-
|
|
44
|
-
Ask:
|
|
45
|
-
|
|
46
|
-
```
|
|
47
|
-
Detected {type} project. How would you like to configure?
|
|
48
|
-
|
|
49
|
-
1. Auto-configure (Recommended) - Use smart defaults for {type}. Done in one click.
|
|
50
|
-
2. Customize - Choose stack, focus areas, and review depth.
|
|
51
|
-
```
|
|
52
|
-
|
|
53
|
-
### If Auto-configure → Skip to Step 4 with defaults:
|
|
54
|
-
|
|
55
|
-
- **Rails:** `[kieran-rails-reviewer, dhh-rails-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle]`
|
|
56
|
-
- **Python:** `[kieran-python-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle]`
|
|
57
|
-
- **TypeScript:** `[kieran-typescript-reviewer, code-simplicity-reviewer, security-sentinel, performance-oracle]`
|
|
58
|
-
- **General:** `[code-simplicity-reviewer, security-sentinel, performance-oracle, architecture-strategist]`
|
|
59
|
-
|
|
60
|
-
### If Customize → Step 3
|
|
61
|
-
|
|
62
|
-
## Step 3: Customize (3 questions)
|
|
63
|
-
|
|
64
|
-
**a. Stack** — confirm or override:
|
|
65
|
-
|
|
66
|
-
```
|
|
67
|
-
Which stack should we optimize for?
|
|
68
|
-
|
|
69
|
-
1. {detected_type} (Recommended) - Auto-detected from project files
|
|
70
|
-
2. Rails - Ruby on Rails, adds DHH-style and Rails-specific reviewers
|
|
71
|
-
3. Python - Adds Pythonic pattern reviewer
|
|
72
|
-
4. TypeScript - Adds type safety reviewer
|
|
73
|
-
```
|
|
74
|
-
|
|
75
|
-
Only show options that differ from the detected type.
|
|
76
|
-
|
|
77
|
-
**b. Focus areas** — multiSelect (user picks one or more):
|
|
78
|
-
|
|
79
|
-
```
|
|
80
|
-
Which review areas matter most? (comma-separated, e.g. 1, 3)
|
|
81
|
-
|
|
82
|
-
1. Security - Vulnerability scanning, auth, input validation (security-sentinel)
|
|
83
|
-
2. Performance - N+1 queries, memory leaks, complexity (performance-oracle)
|
|
84
|
-
3. Architecture - Design patterns, SOLID, separation of concerns (architecture-strategist)
|
|
85
|
-
4. Code simplicity - Over-engineering, YAGNI violations (code-simplicity-reviewer)
|
|
86
|
-
```
|
|
87
|
-
|
|
88
|
-
**c. Depth:**
|
|
89
|
-
|
|
90
|
-
```
|
|
91
|
-
How thorough should reviews be?
|
|
92
|
-
|
|
93
|
-
1. Thorough (Recommended) - Stack reviewers + all selected focus agents.
|
|
94
|
-
2. Fast - Stack reviewers + code simplicity only. Less context, quicker.
|
|
95
|
-
3. Comprehensive - All above + git history, data integrity, agent-native checks.
|
|
96
|
-
```
|
|
97
|
-
|
|
98
|
-
## Step 4: Build Agent List and Write File
|
|
99
|
-
|
|
100
|
-
**Stack-specific agents:**
|
|
101
|
-
- Rails → `kieran-rails-reviewer, dhh-rails-reviewer`
|
|
102
|
-
- Python → `kieran-python-reviewer`
|
|
103
|
-
- TypeScript → `kieran-typescript-reviewer`
|
|
104
|
-
- General → (none)
|
|
105
|
-
|
|
106
|
-
**Focus area agents:**
|
|
107
|
-
- Security → `security-sentinel`
|
|
108
|
-
- Performance → `performance-oracle`
|
|
109
|
-
- Architecture → `architecture-strategist`
|
|
110
|
-
- Code simplicity → `code-simplicity-reviewer`
|
|
111
|
-
|
|
112
|
-
**Depth:**
|
|
113
|
-
- Thorough: stack + selected focus areas
|
|
114
|
-
- Fast: stack + `code-simplicity-reviewer` only
|
|
115
|
-
- Comprehensive: all above + `git-history-analyzer, data-integrity-guardian, agent-native-reviewer`
|
|
116
|
-
|
|
117
|
-
**Plan review agents:** stack-specific reviewer + `code-simplicity-reviewer`.
|
|
118
|
-
|
|
119
|
-
Write `systematic.local.md`:
|
|
120
|
-
|
|
121
|
-
```markdown
|
|
122
|
-
---
|
|
123
|
-
review_agents: [{computed agent list}]
|
|
124
|
-
plan_review_agents: [{computed plan agent list}]
|
|
125
|
-
---
|
|
126
|
-
|
|
127
|
-
# Review Context
|
|
128
|
-
|
|
129
|
-
Add project-specific review instructions here.
|
|
130
|
-
These notes are passed to all review agents during ce:review and ce:work.
|
|
131
|
-
|
|
132
|
-
Examples:
|
|
133
|
-
- "We use Turbo Frames heavily — check for frame-busting issues"
|
|
134
|
-
- "Our API is public — extra scrutiny on input validation"
|
|
135
|
-
- "Performance-critical: we serve 10k req/s on this endpoint"
|
|
136
|
-
```
|
|
137
|
-
|
|
138
|
-
## Step 5: Confirm
|
|
139
|
-
|
|
140
|
-
```
|
|
141
|
-
Saved to systematic.local.md
|
|
142
|
-
|
|
143
|
-
Stack: {type}
|
|
144
|
-
Review depth: {depth}
|
|
145
|
-
Agents: {count} configured
|
|
146
|
-
{agent list, one per line}
|
|
147
|
-
|
|
148
|
-
Tip: Edit the "Review Context" section to add project-specific instructions.
|
|
149
|
-
Re-run this setup anytime to reconfigure.
|
|
150
|
-
```
|
|
21
|
+
This skill is reserved for future project-level configuration needs beyond review agent selection.
|
|
151
22
|
|
package/skills/slfg/SKILL.md
CHANGED
|
@@ -21,16 +21,20 @@ Swarm-enabled LFG. Run these steps in order, parallelizing where indicated. Do n
|
|
|
21
21
|
|
|
22
22
|
After work completes, launch steps 5 and 6 as **parallel swarm agents** (both only need code to be written):
|
|
23
23
|
|
|
24
|
-
5. `/ce:review` — spawn as background Task agent
|
|
24
|
+
5. `/ce:review mode:report-only` — spawn as background Task agent
|
|
25
25
|
6. `/systematic:test-browser` — spawn as background Task agent
|
|
26
26
|
|
|
27
27
|
Wait for both to complete before continuing.
|
|
28
28
|
|
|
29
|
+
## Autofix Phase
|
|
30
|
+
|
|
31
|
+
7. `/ce:review mode:autofix` — run sequentially after the parallel phase so it can safely mutate the checkout, apply `safe_auto` fixes, and emit residual todos for step 8
|
|
32
|
+
|
|
29
33
|
## Finalize Phase
|
|
30
34
|
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
35
|
+
8. `/systematic:todo-resolve` — resolve findings, compound on learnings, clean up completed todos
|
|
36
|
+
9. `/systematic:feature-video` — record the final walkthrough and add to PR
|
|
37
|
+
10. Output `<promise>DONE</promise>` when video is in PR
|
|
34
38
|
|
|
35
39
|
Start with step 1 now.
|
|
36
40
|
|
|
@@ -225,12 +225,12 @@ When a test fails:
|
|
|
225
225
|
|
|
226
226
|
How to proceed?
|
|
227
227
|
1. Fix now - I'll help debug and fix
|
|
228
|
-
2. Create todo - Add a todo for later (using the
|
|
228
|
+
2. Create todo - Add a todo for later (using the todo-create skill)
|
|
229
229
|
3. Skip - Continue testing other pages
|
|
230
230
|
```
|
|
231
231
|
|
|
232
232
|
3. **If "Fix now":** investigate, propose a fix, apply, re-run the failing test
|
|
233
|
-
4. **If "Create todo":** load the `
|
|
233
|
+
4. **If "Create todo":** load the `todo-create` skill and create a todo with priority p1 and description `browser-test-{description}`, continue
|
|
234
234
|
5. **If "Skip":** log as skipped, continue
|
|
235
235
|
|
|
236
236
|
### 10. Test Summary
|
|
@@ -139,12 +139,12 @@ When a test fails:
|
|
|
139
139
|
|
|
140
140
|
How to proceed?
|
|
141
141
|
1. Fix now - I'll help debug and fix
|
|
142
|
-
2. Create todo - Add a todo for later (using the
|
|
142
|
+
2. Create todo - Add a todo for later (using the todo-create skill)
|
|
143
143
|
3. Skip - Continue testing other screens
|
|
144
144
|
```
|
|
145
145
|
|
|
146
146
|
3. **If "Fix now":** investigate, propose a fix, rebuild and retest
|
|
147
|
-
4. **If "Create todo":** load the `
|
|
147
|
+
4. **If "Create todo":** load the `todo-create` skill and create a todo with priority p1 and description `xcode-{description}`, continue
|
|
148
148
|
5. **If "Skip":** log as skipped, continue
|
|
149
149
|
|
|
150
150
|
### 8. Test Summary
|