@fro.bot/systematic 2.0.3 → 2.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (32) hide show
  1. package/agents/research/learnings-researcher.md +27 -26
  2. package/agents/review/api-contract-reviewer.md +1 -1
  3. package/agents/review/correctness-reviewer.md +1 -1
  4. package/agents/review/data-migrations-reviewer.md +1 -1
  5. package/agents/review/dhh-rails-reviewer.md +31 -52
  6. package/agents/review/julik-frontend-races-reviewer.md +27 -200
  7. package/agents/review/kieran-python-reviewer.md +29 -116
  8. package/agents/review/kieran-rails-reviewer.md +29 -98
  9. package/agents/review/kieran-typescript-reviewer.md +29 -107
  10. package/agents/review/maintainability-reviewer.md +1 -1
  11. package/agents/review/performance-reviewer.md +1 -1
  12. package/agents/review/reliability-reviewer.md +1 -1
  13. package/agents/review/security-reviewer.md +1 -1
  14. package/agents/review/testing-reviewer.md +1 -1
  15. package/agents/workflow/pr-comment-resolver.md +99 -50
  16. package/dist/index.js +9 -0
  17. package/dist/lib/config-handler.d.ts +2 -0
  18. package/package.json +1 -1
  19. package/skills/ce-compound/SKILL.md +100 -27
  20. package/skills/ce-compound-refresh/SKILL.md +172 -74
  21. package/skills/ce-review/SKILL.md +379 -418
  22. package/skills/ce-work/SKILL.md +5 -4
  23. package/skills/ce-work-beta/SKILL.md +6 -5
  24. package/skills/claude-permissions-optimizer/scripts/extract-commands.mjs +9 -159
  25. package/skills/claude-permissions-optimizer/scripts/normalize.mjs +151 -0
  26. package/skills/git-worktree/scripts/worktree-manager.sh +163 -0
  27. package/skills/lfg/SKILL.md +2 -2
  28. package/skills/orchestrating-swarms/SKILL.md +1 -1
  29. package/skills/setup/SKILL.md +8 -137
  30. package/skills/slfg/SKILL.md +8 -4
  31. package/skills/test-browser/SKILL.md +2 -2
  32. package/skills/test-xcode/SKILL.md +2 -2
@@ -1,559 +1,520 @@
1
1
  ---
2
2
  name: ce:review
3
- description: Perform exhaustive code reviews using multi-agent analysis, ultra-thinking, and worktrees
4
- argument-hint: '[PR number, GitHub URL, branch name, or latest] [--serial]'
3
+ description: Structured code review using tiered persona agents, confidence-gated findings, and a merge/dedup pipeline. Use when reviewing code changes before creating a PR.
4
+ argument-hint: '[mode:autofix|mode:report-only] [PR number, GitHub URL, or branch name]'
5
5
  ---
6
6
 
7
- # Review Command
7
+ # Code Review
8
8
 
9
- <command_purpose> Perform exhaustive code reviews using multi-agent analysis, ultra-thinking, and Git worktrees for deep local inspection. </command_purpose>
9
+ Reviews code changes using dynamically selected reviewer personas. Spawns parallel sub-agents that return structured JSON, then merges and deduplicates findings into a single report.
10
10
 
11
- ## Introduction
11
+ ## When to Use
12
12
 
13
- <role>Senior Code Review Architect with expertise in security, performance, architecture, and quality assurance</role>
13
+ - Before creating a PR
14
+ - After completing a task during iterative implementation
15
+ - When feedback is needed on any code changes
16
+ - Can be invoked standalone
17
+ - Can run as a read-only or autofix review step inside larger workflows
14
18
 
15
- ## Prerequisites
19
+ ## Mode Detection
16
20
 
17
- <requirements>
18
- - Git repository with GitHub CLI (`gh`) installed and authenticated
19
- - Clean main/master branch
20
- - Proper permissions to create worktrees and access the repository
21
- - For document reviews: Path to a markdown file or document
22
- </requirements>
21
+ Check `$ARGUMENTS` for `mode:autofix` or `mode:report-only`. If either token is present, strip it from the remaining arguments before interpreting the rest as the PR number, GitHub URL, or branch name.
23
22
 
24
- ## Main Tasks
23
+ | Mode | When | Behavior |
24
+ |------|------|----------|
25
+ | **Interactive** (default) | No mode token present | Review, present findings, ask for policy decisions when needed, and optionally continue into fix/push/PR next steps |
26
+ | **Autofix** | `mode:autofix` in arguments | No user interaction. Review, apply only policy-allowed `safe_auto` fixes, re-review in bounded rounds, write a run artifact, and emit residual downstream work when needed |
27
+ | **Report-only** | `mode:report-only` in arguments | Strictly read-only. Review and report only, then stop with no edits, artifacts, todos, commits, pushes, or PR actions |
25
28
 
26
- ### 1. Determine Review Target & Setup (ALWAYS FIRST)
29
+ ### Autofix mode rules
27
30
 
28
- <review_target> #$ARGUMENTS </review_target>
31
+ - **Skip all user questions.** Never pause for approval or clarification once scope has been established.
32
+ - **Apply only `safe_auto -> review-fixer` findings.** Leave `gated_auto`, `manual`, `human`, and `release` work unresolved.
33
+ - **Write a run artifact** under `.context/systematic/ce-review/<run-id>/` summarizing findings, applied fixes, residual actionable work, and advisory outputs.
34
+ - **Create durable todo files only for unresolved actionable findings** whose final owner is `downstream-resolver`. Load the `todo-create` skill for the canonical directory path and naming convention.
35
+ - **Never commit, push, or create a PR** from autofix mode. Parent workflows own those decisions.
29
36
 
30
- <thinking>
31
- First, I need to determine the review target type and set up the code for analysis.
32
- </thinking>
37
+ ### Report-only mode rules
33
38
 
34
- #### Immediate Actions
39
+ - **Skip all user questions.** Infer intent conservatively if the diff metadata is thin.
40
+ - **Never edit files or externalize work.** Do not write `.context/systematic/ce-review/<run-id>/`, do not create todo files, and do not commit, push, or create a PR.
41
+ - **Safe for parallel read-only verification.** `mode:report-only` is the only mode that is safe to run concurrently with browser testing on the same checkout.
42
+ - **Do not switch the shared checkout.** If the caller passes an explicit PR or branch target, `mode:report-only` must run in an isolated checkout/worktree or stop instead of running `gh pr checkout` / `git checkout`.
43
+ - **Do not overlap mutating review with browser testing on the same checkout.** If a future orchestrator wants fixes, run the mutating review phase after browser testing or in an isolated checkout/worktree.
35
44
 
36
- <task_list>
45
+ ## Severity Scale
37
46
 
38
- - [ ] Determine review type: PR number (numeric), GitHub URL, file path (.md), or empty (current branch)
39
- - [ ] Check current git branch
40
- - [ ] If ALREADY on the target branch (PR branch, requested branch name, or the branch already checked out for review) → proceed with analysis on current branch
41
- - [ ] If DIFFERENT branch than the review target → offer to use worktree: "Use git-worktree skill for isolated Call `skill: git-worktree` with branch name"
42
- - [ ] Fetch PR metadata using `gh pr view --json` for title, body, files, linked issues
43
- - [ ] Set up language-specific analysis tools
44
- - [ ] Prepare security scanning environment
45
- - [ ] Make sure we are on the branch we are reviewing. Use gh pr checkout to switch to the branch or manually checkout the branch.
47
+ All reviewers use P0-P3:
46
48
 
47
- Ensure that the code is ready for analysis (either in worktree or on current branch). ONLY then proceed to the next step.
49
+ | Level | Meaning | Action |
50
+ |-------|---------|--------|
51
+ | **P0** | Critical breakage, exploitable vulnerability, data loss/corruption | Must fix before merge |
52
+ | **P1** | High-impact defect likely hit in normal usage, breaking contract | Should fix |
53
+ | **P2** | Moderate issue with meaningful downside (edge case, perf regression, maintainability trap) | Fix if straightforward |
54
+ | **P3** | Low-impact, narrow scope, minor improvement | User's discretion |
48
55
 
49
- </task_list>
56
+ ## Action Routing
50
57
 
51
- #### Protected Artifacts
58
+ Severity answers **urgency**. Routing answers **who acts next** and **whether this skill may mutate the checkout**.
52
59
 
53
- <protected_artifacts>
54
- The following paths are systematic pipeline artifacts and must never be flagged for deletion, removal, or gitignore by any review agent:
60
+ | `autofix_class` | Default owner | Meaning |
61
+ |-----------------|---------------|---------|
62
+ | `safe_auto` | `review-fixer` | Local, deterministic fix suitable for the in-skill fixer when the current mode allows mutation |
63
+ | `gated_auto` | `downstream-resolver` or `human` | Concrete fix exists, but it changes behavior, contracts, permissions, or another sensitive boundary that should not be auto-applied by default |
64
+ | `manual` | `downstream-resolver` or `human` | Actionable work that should be handed off rather than fixed in-skill |
65
+ | `advisory` | `human` or `release` | Report-only output such as learnings, rollout notes, or residual risk |
55
66
 
56
- - `docs/brainstorms/*-requirements.md` — Requirements documents created by `/ce:brainstorm`. These are the product-definition artifacts that planning depends on.
57
- - `docs/plans/*.md` — Plan files created by `/ce:plan`. These are living documents that track implementation progress (checkboxes are checked off by `/ce:work`).
58
- - `docs/solutions/*.md` — Solution documents created during the pipeline.
67
+ Routing rules:
59
68
 
60
- If a review agent flags any file in these directories for cleanup or removal, discard that finding during synthesis. Do not create a todo for it.
61
- </protected_artifacts>
69
+ - **Synthesis owns the final route.** Persona-provided routing metadata is input, not the last word.
70
+ - **Choose the more conservative route on disagreement.** A merged finding may move from `safe_auto` to `gated_auto` or `manual`, but never the other way without stronger evidence.
71
+ - **Only `safe_auto -> review-fixer` enters the in-skill fixer queue automatically.**
72
+ - **`requires_verification: true` means a fix is not complete without targeted tests, a focused re-review, or operational validation.**
62
73
 
63
- #### Load Review Agents
74
+ ## Reviewers
64
75
 
65
- Read `systematic.local.md` in the project root. If found, use `review_agents` from YAML frontmatter. If the markdown body contains review context, pass it to each agent as additional instructions.
76
+ 13 reviewer personas in layered conditionals, plus CE-specific agents. See [persona-catalog.md](./references/persona-catalog.md) for the full catalog.
66
77
 
67
- If no settings file exists, invoke the `setup` skill to create one. Then read the newly created file and continue.
78
+ **Always-on (every review):**
68
79
 
69
- #### Choose Execution Mode
80
+ | Agent | Focus |
81
+ |-------|-------|
82
+ | `systematic:review:correctness-reviewer` | Logic errors, edge cases, state bugs, error propagation |
83
+ | `systematic:review:testing-reviewer` | Coverage gaps, weak assertions, brittle tests |
84
+ | `systematic:review:maintainability-reviewer` | Coupling, complexity, naming, dead code, abstraction debt |
85
+ | `systematic:review:agent-native-reviewer` | Verify new features are agent-accessible |
86
+ | `systematic:research:learnings-researcher` | Search docs/solutions/ for past issues related to this PR |
70
87
 
71
- <execution_mode>
88
+ **Cross-cutting conditional (selected per diff):**
72
89
 
73
- Before launching review agents, check for context constraints:
90
+ | Agent | Select when diff touches... |
91
+ |-------|---------------------------|
92
+ | `systematic:review:security-reviewer` | Auth, public endpoints, user input, permissions |
93
+ | `systematic:review:performance-reviewer` | DB queries, data transforms, caching, async |
94
+ | `systematic:review:api-contract-reviewer` | Routes, serializers, type signatures, versioning |
95
+ | `systematic:review:data-migrations-reviewer` | Migrations, schema changes, backfills |
96
+ | `systematic:review:reliability-reviewer` | Error handling, retries, timeouts, background jobs |
74
97
 
75
- **If `--serial` flag is passed OR conversation is in a long session:**
98
+ **Stack-specific conditional (selected per diff):**
76
99
 
77
- Run agents ONE AT A TIME in sequence. Wait for each agent to complete before starting the next. This uses less context but takes longer.
100
+ | Agent | Select when diff touches... |
101
+ |-------|---------------------------|
102
+ | `systematic:review:dhh-rails-reviewer` | Rails architecture, service objects, session/auth choices, or Hotwire-vs-SPA boundaries |
103
+ | `systematic:review:kieran-rails-reviewer` | Rails application code where conventions, naming, and maintainability are in play |
104
+ | `systematic:review:kieran-python-reviewer` | Python modules, endpoints, scripts, or services |
105
+ | `systematic:review:kieran-typescript-reviewer` | TypeScript components, services, hooks, utilities, or shared types |
106
+ | `systematic:review:julik-frontend-races-reviewer` | Stimulus/Turbo controllers, DOM events, timers, animations, or async UI flows |
78
107
 
79
- **Default (parallel):**
108
+ **CE conditional (migration-specific):**
80
109
 
81
- Run all agents simultaneously for speed. If you hit context limits, retry with `--serial` flag.
110
+ | Agent | Select when diff includes migration files |
111
+ |-------|------------------------------------------|
112
+ | `systematic:review:schema-drift-detector` | Cross-references schema.rb against included migrations |
113
+ | `systematic:review:deployment-verification-agent` | Produces deployment checklist with SQL verification queries |
82
114
 
83
- **Auto-detect:** If more than 5 review agents are configured, automatically switch to serial mode and inform the user:
84
- "Running review agents in serial mode (6+ agents configured). Use --parallel to override."
115
+ ## Review Scope
85
116
 
86
- </execution_mode>
117
+ Every review spawns all 3 always-on personas plus the 2 CE always-on agents, then adds whichever cross-cutting and stack-specific conditionals fit the diff. The model naturally right-sizes: a small config change triggers 0 conditionals = 5 reviewers. A Rails auth feature might trigger security + reliability + kieran-rails + dhh-rails = 9 reviewers.
87
118
 
88
- #### Parallel Agents to review the PR
119
+ ## Protected Artifacts
89
120
 
90
- <parallel_tasks>
121
+ The following paths are systematic pipeline artifacts and must never be flagged for deletion, removal, or gitignore by any reviewer:
91
122
 
92
- **Parallel mode (default for ≤5 agents):**
123
+ - `docs/brainstorms/*` -- requirements documents created by ce:brainstorm
124
+ - `docs/plans/*.md` -- plan files created by ce:plan (living documents with progress checkboxes)
125
+ - `docs/solutions/*.md` -- solution documents created during the pipeline
93
126
 
94
- Run all configured review agents in parallel using task tool. For each agent in the `review_agents` list:
127
+ If a reviewer flags any file in these directories for cleanup or removal, discard that finding during synthesis.
95
128
 
96
- ```
97
- Task {agent-name}(PR content + review context from settings body)
98
- ```
99
-
100
- **Serial mode (--serial flag, or auto for 6+ agents):**
101
-
102
- Run configured review agents ONE AT A TIME. For each agent in the `review_agents` list, wait for it to complete before starting the next:
103
-
104
- ```
105
- For each agent in review_agents:
106
- 1. Task {agent-name}(PR content + review context)
107
- 2. Wait for completion
108
- 3. Collect findings
109
- 4. Proceed to next agent
110
- ```
111
-
112
- Always run these last regardless of mode:
113
- - task systematic:review:agent-native-reviewer(PR content) - Verify new features are agent-accessible
114
- - task systematic:research:learnings-researcher(PR content) - Search docs/solutions/ for past issues related to this PR's modules and patterns
115
-
116
- </parallel_tasks>
117
-
118
- #### Conditional Agents (Run if applicable)
119
-
120
- <conditional_agents>
121
-
122
- These agents are run ONLY when the PR matches specific criteria. Check the PR files list to determine if they apply:
123
-
124
- **MIGRATIONS: If PR contains database migrations, schema.rb, or data backfills:**
125
-
126
- - task systematic:review:schema-drift-detector(PR content) - Detects unrelated schema.rb changes by cross-referencing against included migrations (run FIRST)
127
- - task systematic:review:data-migration-expert(PR content) - Validates ID mappings match production, checks for swapped values, verifies rollback safety
128
- - task systematic:review:deployment-verification-agent(PR content) - Creates Go/No-Go deployment checklist with SQL verification queries
129
-
130
- **When to run:**
131
- - PR includes files matching `db/migrate/*.rb` or `db/schema.rb`
132
- - PR modifies columns that store IDs, enums, or mappings
133
- - PR includes data backfill scripts or rake tasks
134
- - PR title/body mentions: migration, backfill, data transformation, ID mapping
135
-
136
- **What these agents check:**
137
- - `schema-drift-detector`: Cross-references schema.rb changes against PR migrations to catch unrelated columns/indexes from local database state
138
- - `data-migration-expert`: Verifies hard-coded mappings match production reality (prevents swapped IDs), checks for orphaned associations, validates dual-write patterns
139
- - `deployment-verification-agent`: Produces executable pre/post-deploy checklists with SQL queries, rollback procedures, and monitoring plans
140
-
141
- </conditional_agents>
142
-
143
- ### 2. Ultra-Thinking Deep Dive Phases
144
-
145
- <ultrathink_instruction> For each phase below, spend maximum cognitive effort. Think step by step. Consider all angles. Question assumptions. And bring all reviews in a synthesis to the user.</ultrathink_instruction>
129
+ ## How to Run
146
130
 
147
- <deliverable>
148
- Complete system context map with component interactions
149
- </deliverable>
131
+ ### Stage 1: Determine scope
150
132
 
151
- #### Phase 1: Stakeholder Perspective Analysis
133
+ Compute the diff range, file list, and diff. Minimize permission prompts by combining into as few commands as possible.
152
134
 
153
- <thinking_prompt> ULTRA-THINK: Put yourself in each stakeholder's shoes. What matters to them? What are their pain points? </thinking_prompt>
135
+ **If a PR number or GitHub URL is provided as an argument:**
154
136
 
155
- <stakeholder_perspectives>
137
+ If `mode:report-only` is active, do **not** run `gh pr checkout <number-or-url>` on the shared checkout. Tell the caller: "mode:report-only cannot switch the shared checkout to review a PR target. Run it from an isolated worktree/checkout for that PR, or run report-only with no target argument on the already checked out branch." Stop here unless the review is already running in an isolated checkout.
156
138
 
157
- 1. **Developer Perspective** <questions>
139
+ First, verify the worktree is clean before switching branches:
158
140
 
159
- - How easy is this to understand and modify?
160
- - Are the APIs intuitive?
161
- - Is debugging straightforward?
162
- - Can I test this easily? </questions>
163
-
164
- 2. **Operations Perspective** <questions>
165
-
166
- - How do I deploy this safely?
167
- - What metrics and logs are available?
168
- - How do I troubleshoot issues?
169
- - What are the resource requirements? </questions>
170
-
171
- 3. **End User Perspective** <questions>
172
-
173
- - Is the feature intuitive?
174
- - Are error messages helpful?
175
- - Is performance acceptable?
176
- - Does it solve my problem? </questions>
177
-
178
- 4. **Security Team Perspective** <questions>
179
-
180
- - What's the attack surface?
181
- - Are there compliance requirements?
182
- - How is data protected?
183
- - What are the audit capabilities? </questions>
184
-
185
- 5. **Business Perspective** <questions>
186
- - What's the ROI?
187
- - Are there legal/compliance risks?
188
- - How does this affect time-to-market?
189
- - What's the total cost of ownership? </questions> </stakeholder_perspectives>
190
-
191
- #### Phase 2: Scenario Exploration
192
-
193
- <thinking_prompt> ULTRA-THINK: Explore edge cases and failure scenarios. What could go wrong? How does the system behave under stress? </thinking_prompt>
194
-
195
- <scenario_checklist>
196
-
197
- - [ ] **Happy Path**: Normal operation with valid inputs
198
- - [ ] **Invalid Inputs**: Null, empty, malformed data
199
- - [ ] **Boundary Conditions**: Min/max values, empty collections
200
- - [ ] **Concurrent Access**: Race conditions, deadlocks
201
- - [ ] **Scale Testing**: 10x, 100x, 1000x normal load
202
- - [ ] **Network Issues**: Timeouts, partial failures
203
- - [ ] **Resource Exhaustion**: Memory, disk, connections
204
- - [ ] **Security Attacks**: Injection, overflow, DoS
205
- - [ ] **Data Corruption**: Partial writes, inconsistency
206
- - [ ] **Cascading Failures**: Downstream service issues </scenario_checklist>
207
-
208
- ### 3. Multi-Angle Review Perspectives
141
+ ```
142
+ git status --porcelain
143
+ ```
209
144
 
210
- #### Technical Excellence Angle
145
+ If the output is non-empty, inform the user: "You have uncommitted changes on the current branch. Stash or commit them before reviewing a PR, or use standalone mode (no argument) to review the current branch as-is." Do not proceed with checkout until the worktree is clean.
211
146
 
212
- - Code craftsmanship evaluation
213
- - Engineering best practices
214
- - Technical documentation quality
215
- - Tooling and automation assessment
147
+ Then check out the PR branch so persona agents can read the actual code (not the current checkout):
216
148
 
217
- #### Business Value Angle
149
+ ```
150
+ gh pr checkout <number-or-url>
151
+ ```
218
152
 
219
- - Feature completeness validation
220
- - Performance impact on users
221
- - Cost-benefit analysis
222
- - Time-to-market considerations
153
+ Then fetch PR metadata. Capture the base branch name and the PR base repository identity, not just the branch name:
223
154
 
224
- #### Risk Management Angle
155
+ ```
156
+ gh pr view <number-or-url> --json title,body,baseRefName,headRefName,url
157
+ ```
225
158
 
226
- - Security risk assessment
227
- - Operational risk evaluation
228
- - Compliance risk verification
229
- - Technical debt accumulation
159
+ Use the repository portion of the returned PR URL as `<base-repo>` (for example, `marcusrbrown/systematic` from `https://github.com/marcusrbrown/systematic/pull/348`).
230
160
 
231
- #### Team Dynamics Angle
161
+ Then compute a local diff against the PR's base branch so re-reviews also include local fix commits and uncommitted edits. Substitute the PR base branch from metadata (shown here as `<base>`) and the PR base repository identity derived from the PR URL (shown here as `<base-repo>`). Resolve the base ref from the PR's actual base repository, not by assuming `origin` points at that repo:
232
162
 
233
- - Code review etiquette
234
- - Knowledge sharing effectiveness
235
- - Collaboration patterns
236
- - Mentoring opportunities
163
+ ```
164
+ PR_BASE_REMOTE=$(git remote -v | awk 'index($2, "github.com:<base-repo>") || index($2, "github.com/<base-repo>") {print $1; exit}')
165
+ if [ -n "$PR_BASE_REMOTE" ]; then PR_BASE_REMOTE_REF="$PR_BASE_REMOTE/<base>"; else PR_BASE_REMOTE_REF=""; fi
166
+ PR_BASE_REF=$(git rev-parse --verify "$PR_BASE_REMOTE_REF" 2>/dev/null || git rev-parse --verify <base> 2>/dev/null || true)
167
+ if [ -z "$PR_BASE_REF" ]; then
168
+ if [ -n "$PR_BASE_REMOTE_REF" ]; then
169
+ git fetch --no-tags "$PR_BASE_REMOTE" <base>:refs/remotes/"$PR_BASE_REMOTE"/<base> 2>/dev/null || git fetch --no-tags "$PR_BASE_REMOTE" <base> 2>/dev/null || true
170
+ PR_BASE_REF=$(git rev-parse --verify "$PR_BASE_REMOTE_REF" 2>/dev/null || git rev-parse --verify <base> 2>/dev/null || true)
171
+ else
172
+ if git fetch --no-tags https://github.com/<base-repo>.git <base> 2>/dev/null; then
173
+ PR_BASE_REF=$(git rev-parse --verify FETCH_HEAD 2>/dev/null || true)
174
+ fi
175
+ if [ -z "$PR_BASE_REF" ]; then PR_BASE_REF=$(git rev-parse --verify <base> 2>/dev/null || true); fi
176
+ fi
177
+ fi
178
+ if [ -n "$PR_BASE_REF" ]; then BASE=$(git merge-base HEAD "$PR_BASE_REF" 2>/dev/null) || BASE=""; else BASE=""; fi
179
+ ```
237
180
 
238
- ### 4. Simplification and Minimalism Review
181
+ ```
182
+ if [ -n "$BASE" ]; then echo "BASE:$BASE" && echo "FILES:" && git diff --name-only $BASE && echo "DIFF:" && git diff -U10 $BASE && echo "UNTRACKED:" && git ls-files --others --exclude-standard; else echo "ERROR: Unable to resolve PR base branch <base> locally. Fetch the base branch and rerun so the review scope stays aligned with the PR."; fi
183
+ ```
239
184
 
240
- Run the task systematic:review:code-simplicity-reviewer() to see if we can simplify the code.
185
+ Extract PR title/body, base branch, and PR URL from `gh pr view`, then extract the base marker, file list, diff content, and `UNTRACKED:` list from the local command. Do not use `gh pr diff` as the review scope after checkout -- it only reflects the remote PR state and will miss local fix commits until they are pushed. If the base ref still cannot be resolved from the PR's actual base repository after the fetch attempt, stop instead of falling back to `git diff HEAD`; a PR review without the PR base branch is incomplete.
241
186
 
242
- ### 5. Findings Synthesis and Todo Creation Using file-todos Skill
187
+ **If a branch name is provided as an argument:**
243
188
 
244
- <critical_requirement> ALL findings MUST be stored as todo files using the file-todos skill. Load the `file-todos` skill for the canonical directory path, naming convention, and template. Create todo files immediately after synthesis - do NOT present findings for user approval first. </critical_requirement>
189
+ Check out the named branch, then diff it against the base branch. Substitute the provided branch name (shown here as `<branch>`).
245
190
 
246
- #### Step 1: Synthesize All Findings
191
+ If `mode:report-only` is active, do **not** run `git checkout <branch>` on the shared checkout. Tell the caller: "mode:report-only cannot switch the shared checkout to review another branch. Run it from an isolated worktree/checkout for `<branch>`, or run report-only on the current checkout with no target argument." Stop here unless the review is already running in an isolated checkout.
247
192
 
248
- <thinking>
249
- Consolidate all agent reports into a categorized list of findings.
250
- Remove duplicates, prioritize by severity and impact.
251
- </thinking>
193
+ First, verify the worktree is clean before switching branches:
252
194
 
253
- <synthesis_tasks>
195
+ ```
196
+ git status --porcelain
197
+ ```
254
198
 
255
- - [ ] Collect findings from all parallel agents
256
- - [ ] Surface learnings-researcher results: if past solutions are relevant, flag them as "Known Pattern" with links to docs/solutions/ files
257
- - [ ] Discard any findings that recommend deleting or gitignoring files in `docs/brainstorms/`, `docs/plans/`, or `docs/solutions/` (see Protected Artifacts above)
258
- - [ ] Categorize by type: security, performance, architecture, quality, etc.
259
- - [ ] Assign severity levels: 🔴 CRITICAL (P1), 🟡 IMPORTANT (P2), 🔵 NICE-TO-HAVE (P3)
260
- - [ ] Remove duplicate or overlapping findings
261
- - [ ] Estimate effort for each finding (Small/Medium/Large)
199
+ If the output is non-empty, inform the user: "You have uncommitted changes on the current branch. Stash or commit them before reviewing another branch, or provide a PR number instead." Do not proceed with checkout until the worktree is clean.
262
200
 
263
- </synthesis_tasks>
201
+ ```
202
+ git checkout <branch>
203
+ ```
264
204
 
265
- #### Step 2: Create Todo Files Using file-todos Skill
205
+ Then detect the review base branch before computing the merge-base. When the branch has an open PR, resolve the base ref from the PR's actual base repository (not just `origin`), mirroring the PR-mode logic for fork safety. Fall back to `origin/HEAD`, GitHub metadata, then common branch names:
266
206
 
267
- <critical_instruction> Use the file-todos skill to create todo files for ALL findings immediately. Do NOT present findings one-by-one asking for user approval. Create all todo files in parallel using the skill, then summarize results to user. </critical_instruction>
207
+ ```
208
+ REVIEW_BASE_BRANCH=""
209
+ PR_BASE_REPO=""
210
+ if command -v gh >/dev/null 2>&1; then
211
+ PR_META=$(gh pr view --json baseRefName,url 2>/dev/null || true)
212
+ if [ -n "$PR_META" ]; then
213
+ REVIEW_BASE_BRANCH=$(echo "$PR_META" | jq -r '.baseRefName // empty')
214
+ PR_BASE_REPO=$(echo "$PR_META" | jq -r '.url // empty' | sed -n 's#https://github.com/\([^/]*/[^/]*\)/pull/.*#\1#p')
215
+ fi
216
+ fi
217
+ if [ -z "$REVIEW_BASE_BRANCH" ]; then REVIEW_BASE_BRANCH=$(git symbolic-ref --quiet --short refs/remotes/origin/HEAD 2>/dev/null | sed 's#^origin/##'); fi
218
+ if [ -z "$REVIEW_BASE_BRANCH" ] && command -v gh >/dev/null 2>&1; then REVIEW_BASE_BRANCH=$(gh repo view --json defaultBranchRef --jq '.defaultBranchRef.name' 2>/dev/null); fi
219
+ if [ -z "$REVIEW_BASE_BRANCH" ]; then
220
+ for candidate in main master develop trunk; do
221
+ if git rev-parse --verify "origin/$candidate" >/dev/null 2>&1 || git rev-parse --verify "$candidate" >/dev/null 2>&1; then
222
+ REVIEW_BASE_BRANCH="$candidate"
223
+ break
224
+ fi
225
+ done
226
+ fi
227
+ if [ -n "$REVIEW_BASE_BRANCH" ]; then
228
+ if [ -n "$PR_BASE_REPO" ]; then
229
+ PR_BASE_REMOTE=$(git remote -v | awk "index(\$2, \"github.com:$PR_BASE_REPO\") || index(\$2, \"github.com/$PR_BASE_REPO\") {print \$1; exit}")
230
+ if [ -n "$PR_BASE_REMOTE" ]; then
231
+ git rev-parse --verify "$PR_BASE_REMOTE/$REVIEW_BASE_BRANCH" >/dev/null 2>&1 || git fetch --no-tags "$PR_BASE_REMOTE" "$REVIEW_BASE_BRANCH" 2>/dev/null || true
232
+ BASE_REF=$(git rev-parse --verify "$PR_BASE_REMOTE/$REVIEW_BASE_BRANCH" 2>/dev/null || true)
233
+ fi
234
+ fi
235
+ if [ -z "$BASE_REF" ]; then
236
+ git rev-parse --verify "origin/$REVIEW_BASE_BRANCH" >/dev/null 2>&1 || git fetch --no-tags origin "$REVIEW_BASE_BRANCH" 2>/dev/null || true
237
+ BASE_REF=$(git rev-parse --verify "origin/$REVIEW_BASE_BRANCH" 2>/dev/null || git rev-parse --verify "$REVIEW_BASE_BRANCH" 2>/dev/null || true)
238
+ fi
239
+ if [ -n "$BASE_REF" ]; then BASE=$(git merge-base HEAD "$BASE_REF" 2>/dev/null) || BASE=""; else BASE=""; fi
240
+ else BASE=""; fi
241
+ ```
268
242
 
269
- **Implementation Options:**
243
+ ```
244
+ if [ -n "$BASE" ]; then echo "BASE:$BASE" && echo "FILES:" && git diff --name-only $BASE && echo "DIFF:" && git diff -U10 $BASE && echo "UNTRACKED:" && git ls-files --others --exclude-standard; else echo "ERROR: Unable to resolve review base branch locally. Fetch the base branch and rerun, or provide a PR number so the review scope can be determined from PR metadata."; fi
245
+ ```
270
246
 
271
- **Option A: Direct File Creation (Fast)**
247
+ If the branch has an open PR, the detection above uses the PR's base repository to resolve the merge-base, which handles fork workflows correctly. You may still fetch additional PR metadata with `gh pr view` for title, body, and linked issues, but do not fail if no PR exists. If the base branch still cannot be resolved after the detection and fetch attempts, stop instead of falling back to `git diff HEAD`; a branch review without the base branch would only show uncommitted changes and silently miss all committed work.
272
248
 
273
- - Create todo files directly using write tool
274
- - All findings in parallel for speed
275
- - Use standard template from the `file-todos` skill's [todo-template.md](../file-todos/assets/todo-template.md)
276
- - Follow naming convention: `{issue_id}-pending-{priority}-{description}.md`
249
+ **If no argument (standalone on current branch):**
277
250
 
278
- **Option B: Sub-Agents in Parallel (Recommended for Scale)** For large PRs with 15+ findings, use sub-agents to create finding files in parallel:
251
+ Detect the review base branch before computing the merge-base. When the current branch has an open PR, resolve the base ref from the PR's actual base repository (not just `origin`), mirroring the PR-mode logic for fork safety. Fall back to `origin/HEAD`, GitHub metadata, then common branch names:
279
252
 
280
- ```bash
281
- # Launch multiple finding-creator agents in parallel
282
- task() - Create todos for first finding
283
- task() - Create todos for second finding
284
- task() - Create todos for third finding
285
- etc. for each finding.
253
+ ```
254
+ REVIEW_BASE_BRANCH=""
255
+ PR_BASE_REPO=""
256
+ if command -v gh >/dev/null 2>&1; then
257
+ PR_META=$(gh pr view --json baseRefName,url 2>/dev/null || true)
258
+ if [ -n "$PR_META" ]; then
259
+ REVIEW_BASE_BRANCH=$(echo "$PR_META" | jq -r '.baseRefName // empty')
260
+ PR_BASE_REPO=$(echo "$PR_META" | jq -r '.url // empty' | sed -n 's#https://github.com/\([^/]*/[^/]*\)/pull/.*#\1#p')
261
+ fi
262
+ fi
263
+ if [ -z "$REVIEW_BASE_BRANCH" ]; then REVIEW_BASE_BRANCH=$(git symbolic-ref --quiet --short refs/remotes/origin/HEAD 2>/dev/null | sed 's#^origin/##'); fi
264
+ if [ -z "$REVIEW_BASE_BRANCH" ] && command -v gh >/dev/null 2>&1; then REVIEW_BASE_BRANCH=$(gh repo view --json defaultBranchRef --jq '.defaultBranchRef.name' 2>/dev/null); fi
265
+ if [ -z "$REVIEW_BASE_BRANCH" ]; then
266
+ for candidate in main master develop trunk; do
267
+ if git rev-parse --verify "origin/$candidate" >/dev/null 2>&1 || git rev-parse --verify "$candidate" >/dev/null 2>&1; then
268
+ REVIEW_BASE_BRANCH="$candidate"
269
+ break
270
+ fi
271
+ done
272
+ fi
273
+ if [ -n "$REVIEW_BASE_BRANCH" ]; then
274
+ if [ -n "$PR_BASE_REPO" ]; then
275
+ PR_BASE_REMOTE=$(git remote -v | awk "index(\$2, \"github.com:$PR_BASE_REPO\") || index(\$2, \"github.com/$PR_BASE_REPO\") {print \$1; exit}")
276
+ if [ -n "$PR_BASE_REMOTE" ]; then
277
+ git rev-parse --verify "$PR_BASE_REMOTE/$REVIEW_BASE_BRANCH" >/dev/null 2>&1 || git fetch --no-tags "$PR_BASE_REMOTE" "$REVIEW_BASE_BRANCH" 2>/dev/null || true
278
+ BASE_REF=$(git rev-parse --verify "$PR_BASE_REMOTE/$REVIEW_BASE_BRANCH" 2>/dev/null || true)
279
+ fi
280
+ fi
281
+ if [ -z "$BASE_REF" ]; then
282
+ git rev-parse --verify "origin/$REVIEW_BASE_BRANCH" >/dev/null 2>&1 || git fetch --no-tags origin "$REVIEW_BASE_BRANCH" 2>/dev/null || true
283
+ BASE_REF=$(git rev-parse --verify "origin/$REVIEW_BASE_BRANCH" 2>/dev/null || git rev-parse --verify "$REVIEW_BASE_BRANCH" 2>/dev/null || true)
284
+ fi
285
+ if [ -n "$BASE_REF" ]; then BASE=$(git merge-base HEAD "$BASE_REF" 2>/dev/null) || BASE=""; else BASE=""; fi
286
+ else BASE=""; fi
286
287
  ```
287
288
 
288
- Sub-agents can:
289
-
290
- - Process multiple findings simultaneously
291
- - Write detailed todo files with all sections filled
292
- - Organize findings by severity
293
- - Create comprehensive Proposed Solutions
294
- - Add acceptance criteria and work logs
295
- - Complete much faster than sequential processing
289
+ ```
290
+ if [ -n "$BASE" ]; then echo "BASE:$BASE" && echo "FILES:" && git diff --name-only $BASE && echo "DIFF:" && git diff -U10 $BASE && echo "UNTRACKED:" && git ls-files --others --exclude-standard; else echo "ERROR: Unable to resolve review base branch locally. Fetch the base branch and rerun, or provide a PR number so the review scope can be determined from PR metadata."; fi
291
+ ```
296
292
 
297
- **Execution Strategy:**
293
+ Parse: `BASE:` = merge-base SHA, `FILES:` = file list, `DIFF:` = diff, `UNTRACKED:` = files excluded from review scope because they are not staged. Using `git diff $BASE` (without `..HEAD`) diffs the merge-base against the working tree, which includes committed, staged, and unstaged changes together. If the base branch cannot be resolved after the detection and fetch attempts, stop instead of falling back to `git diff HEAD`; a standalone review without the base branch would only show uncommitted changes and silently miss all committed work on the branch.
298
294
 
299
- 1. Synthesize all findings into categories (P1/P2/P3)
300
- 2. Group findings by severity
301
- 3. Launch 3 parallel sub-agents (one per severity level)
302
- 4. Each sub-agent creates its batch of todos using the file-todos skill
303
- 5. Consolidate results and present summary
295
+ **Untracked file handling:** Always inspect the `UNTRACKED:` list, even when `FILES:`/`DIFF:` are non-empty. Untracked files are outside review scope until staged. If the list is non-empty, tell the user which files are excluded. If any of them should be reviewed, stop and tell the user to `git add` them first and rerun. Only continue when the user is intentionally reviewing tracked changes only.
304
296
 
305
- **Process (Using file-todos Skill):**
297
+ ### Stage 2: Intent discovery
306
298
 
307
- 1. For each finding:
299
+ Understand what the change is trying to accomplish. The source of intent depends on which Stage 1 path was taken:
308
300
 
309
- - Determine severity (P1/P2/P3)
310
- - Write detailed Problem Statement and Findings
311
- - Create 2-3 Proposed Solutions with pros/cons/effort/risk
312
- - Estimate effort (Small/Medium/Large)
313
- - Add acceptance criteria and work log
301
+ **PR/URL mode:** Use the PR title, body, and linked issues from `gh pr view` metadata. Supplement with commit messages from the PR if the body is sparse.
314
302
 
315
- 2. Use file-todos skill for structured todo management:
303
+ **Branch mode:** Run `git log --oneline ${BASE}..<branch>` using the resolved merge-base from Stage 1.
316
304
 
317
- ```bash
318
- skill: file-todos
319
- ```
305
+ **Standalone (current branch):** Run:
320
306
 
321
- The skill provides:
307
+ ```
308
+ echo "BRANCH:" && git rev-parse --abbrev-ref HEAD && echo "COMMITS:" && git log --oneline ${BASE}..HEAD
309
+ ```
322
310
 
323
- - Template location: the `file-todos` skill's [todo-template.md](../file-todos/assets/todo-template.md)
324
- - Naming convention: `{issue_id}-{status}-{priority}-{description}.md`
325
- - YAML frontmatter structure: status, priority, issue_id, tags, dependencies
326
- - All required sections: Problem Statement, Findings, Solutions, etc.
311
+ Combined with conversation context (plan section summary, PR description, caller-provided description), write a 2-3 line intent summary:
327
312
 
328
- 3. Create todo files in parallel:
313
+ ```
314
+ Intent: Simplify tax calculation by replacing the multi-tier rate lookup
315
+ with a flat-rate computation. Must not regress edge cases in tax-exempt handling.
316
+ ```
329
317
 
330
- ```bash
331
- {next_id}-pending-{priority}-{description}.md
332
- ```
318
+ Pass this to every reviewer in their spawn prompt. Intent shapes *how hard each reviewer looks*, not which reviewers are selected.
333
319
 
334
- 4. Examples:
320
+ **When intent is ambiguous:**
335
321
 
336
- ```
337
- 001-pending-p1-path-traversal-vulnerability.md
338
- 002-pending-p1-api-response-validation.md
339
- 003-pending-p2-concurrency-limit.md
340
- 004-pending-p3-unused-parameter.md
341
- ```
322
+ - **Interactive mode:** Ask one question using the platform's interactive question tool (question in OpenCode, request_user_input in Codex): "What is the primary goal of these changes?" Do not spawn reviewers until intent is established.
323
+ - **Autofix/report-only modes:** Infer intent conservatively from the branch name, diff, PR metadata, and caller context. Note the uncertainty in Coverage or Verdict reasoning instead of blocking.
342
324
 
343
- 5. Follow template structure from file-todos skill: the `file-todos` skill's [todo-template.md](../file-todos/assets/todo-template.md)
325
+ ### Stage 3: Select reviewers
344
326
 
345
- **Todo File Structure (from template):**
327
+ Read the diff and file list from Stage 1. The 3 always-on personas and 2 CE always-on agents are automatic. For each cross-cutting and stack-specific conditional persona in [persona-catalog.md](./references/persona-catalog.md), decide whether the diff warrants it. This is agent judgment, not keyword matching.
346
328
 
347
- Each todo must include:
329
+ Stack-specific personas are additive. A Rails UI change may warrant `kieran-rails` plus `julik-frontend-races`; a TypeScript API diff may warrant `kieran-typescript` plus `api-contract` and `reliability`.
348
330
 
349
- - **YAML frontmatter**: status, priority, issue_id, tags, dependencies
350
- - **Problem Statement**: What's broken/missing, why it matters
351
- - **Findings**: Discoveries from agents with evidence/location
352
- - **Proposed Solutions**: 2-3 options, each with pros/cons/effort/risk
353
- - **Recommended Action**: (Filled during triage, leave blank initially)
354
- - **Technical Details**: Affected files, components, database changes
355
- - **Acceptance Criteria**: Testable checklist items
356
- - **Work Log**: Dated record with actions and learnings
357
- - **Resources**: Links to PR, issues, documentation, similar patterns
331
+ For CE conditional agents, check if the diff includes files matching `db/migrate/*.rb`, `db/schema.rb`, or data backfill scripts.
358
332
 
359
- **File naming convention:**
333
+ Announce the team before spawning:
360
334
 
361
335
  ```
362
- {issue_id}-{status}-{priority}-{description}.md
363
-
364
- Examples:
365
- - 001-pending-p1-security-vulnerability.md
366
- - 002-pending-p2-performance-optimization.md
367
- - 003-pending-p3-code-cleanup.md
336
+ Review team:
337
+ - correctness (always)
338
+ - testing (always)
339
+ - maintainability (always)
340
+ - agent-native-reviewer (always)
341
+ - learnings-researcher (always)
342
+ - security -- new endpoint in routes.rb accepts user-provided redirect URL
343
+ - kieran-rails -- controller and Turbo flow changed in app/controllers and app/views
344
+ - dhh-rails -- diff adds service objects around ordinary Rails CRUD
345
+ - data-migrations -- adds migration 20260303_add_index_to_orders
346
+ - schema-drift-detector -- migration files present
368
347
  ```
369
348
 
370
- **Status values:**
371
-
372
- - `pending` - New findings, needs triage/decision
373
- - `ready` - Approved by manager, ready to work
374
- - `complete` - Work finished
375
-
376
- **Priority values:**
377
-
378
- - `p1` - Critical (blocks merge, security/data issues)
379
- - `p2` - Important (should fix, architectural/performance)
380
- - `p3` - Nice-to-have (enhancements, cleanup)
381
-
382
- **Tagging:** Always add `code-review` tag, plus: `security`, `performance`, `architecture`, `rails`, `quality`, etc.
383
-
384
- #### Step 3: Summary Report
385
-
386
- After creating all todo files, present comprehensive summary:
387
-
388
- ````markdown
389
- ## ✅ Code Review Complete
349
+ This is progress reporting, not a blocking confirmation.
390
350
 
391
- **Review Target:** PR #XXXX - [PR Title] **Branch:** [branch-name]
351
+ ### Stage 4: Spawn sub-agents
392
352
 
393
- ### Findings Summary:
353
+ Spawn each selected persona reviewer as a parallel sub-agent using the template in [subagent-template.md](./references/subagent-template.md). Each persona sub-agent receives:
394
354
 
395
- - **Total Findings:** [X]
396
- - **🔴 CRITICAL (P1):** [count] - BLOCKS MERGE
397
- - **🟡 IMPORTANT (P2):** [count] - Should Fix
398
- - **🔵 NICE-TO-HAVE (P3):** [count] - Enhancements
355
+ 1. Their persona file content (identity, failure modes, calibration, suppress conditions)
356
+ 2. Shared diff-scope rules from [diff-scope.md](./references/diff-scope.md)
357
+ 3. The JSON output contract from [findings-schema.json](./references/findings-schema.json)
358
+ 4. Review context: intent summary, file list, diff
399
359
 
400
- ### Created Todo Files:
360
+ Persona sub-agents are **read-only**: they review and return structured JSON. They do not edit files or propose refactors.
401
361
 
402
- **P1 - Critical (BLOCKS MERGE):**
362
+ Read-only here means **non-mutating**, not "no shell access." Reviewer sub-agents may use non-mutating inspection commands when needed to gather evidence or verify scope, including read-oriented `git` / `gh` usage such as `git diff`, `git show`, `git blame`, `git log`, and `gh pr view`. They must not edit files, change branches, commit, push, create PRs, or otherwise mutate the checkout or repository state.
403
363
 
404
- - `001-pending-p1-{finding}.md` - {description}
405
- - `002-pending-p1-{finding}.md` - {description}
364
+ Each persona sub-agent returns JSON matching [findings-schema.json](./references/findings-schema.json):
406
365
 
407
- **P2 - Important:**
366
+ ```json
367
+ {
368
+ "reviewer": "security",
369
+ "findings": [...],
370
+ "residual_risks": [...],
371
+ "testing_gaps": [...]
372
+ }
373
+ ```
408
374
 
409
- - `003-pending-p2-{finding}.md` - {description}
410
- - `004-pending-p2-{finding}.md` - {description}
375
+ **CE always-on agents** (agent-native-reviewer, learnings-researcher) are dispatched as standard Agent calls in parallel with the persona agents. Give them the same review context bundle the personas receive: entry mode, any PR metadata gathered in Stage 1, intent summary, review base branch name when known, `BASE:` marker, file list, diff, and `UNTRACKED:` scope notes. Do not invoke them with a generic "review this" prompt. Their output is unstructured and synthesized separately in Stage 6.
411
376
 
412
- **P3 - Nice-to-Have:**
377
+ **CE conditional agents** (schema-drift-detector, deployment-verification-agent) are also dispatched as standard Agent calls when applicable. Pass the same review context bundle plus the applicability reason (for example, which migration files triggered the agent). For schema-drift-detector specifically, pass the resolved review base branch explicitly so it never assumes `main`. Their output is unstructured and must be preserved for Stage 6 synthesis just like the CE always-on agents.
413
378
 
414
- - `005-pending-p3-{finding}.md` - {description}
379
+ ### Stage 5: Merge findings
415
380
 
416
- ### Review Agents Used:
381
+ Convert multiple reviewer JSON payloads into one deduplicated, confidence-gated finding set.
417
382
 
418
- - kieran-rails-reviewer
419
- - security-sentinel
420
- - performance-oracle
421
- - architecture-strategist
422
- - agent-native-reviewer
423
- - [other agents]
383
+ 1. **Validate.** Check each output against the schema. Drop malformed findings (missing required fields). Record the drop count.
384
+ 2. **Confidence gate.** Suppress findings below 0.60 confidence. Record the suppressed count. This matches the persona instructions: findings below 0.60 are noise and should not survive synthesis.
385
+ 3. **Deduplicate.** Compute fingerprint: `normalize(file) + line_bucket(line, +/-3) + normalize(title)`. When fingerprints match, merge: keep highest severity, keep highest confidence with strongest evidence, union evidence, note which reviewers flagged it.
386
+ 4. **Separate pre-existing.** Pull out findings with `pre_existing: true` into a separate list.
387
+ 5. **Normalize routing.** For each merged finding, set the final `autofix_class`, `owner`, and `requires_verification`. If reviewers disagree, keep the most conservative route. Synthesis may narrow a finding from `safe_auto` to `gated_auto` or `manual`, but must not widen it without new evidence.
388
+ 6. **Partition the work.** Build three sets:
389
+ - in-skill fixer queue: only `safe_auto -> review-fixer`
390
+ - residual actionable queue: unresolved `gated_auto` or `manual` findings whose owner is `downstream-resolver`
391
+ - report-only queue: `advisory` findings plus anything owned by `human` or `release`
392
+ 7. **Sort.** Order by severity (P0 first) -> confidence (descending) -> file path -> line number.
393
+ 8. **Collect coverage data.** Union residual_risks and testing_gaps across reviewers.
394
+ 9. **Preserve CE agent artifacts.** Keep the learnings, agent-native, schema-drift, and deployment-verification outputs alongside the merged finding set. Do not drop unstructured agent output just because it does not match the persona JSON schema.
424
395
 
425
- ### Next Steps:
396
+ ### Stage 6: Synthesize and present
426
397
 
427
- 1. **Address P1 Findings**: CRITICAL - must be fixed before merge
398
+ Assemble the final report using the template in [review-output-template.md](./references/review-output-template.md):
428
399
 
429
- - Review each P1 todo in detail
430
- - Implement fixes or request exemption
431
- - Verify fixes before merging PR
400
+ 1. **Header.** Scope, intent, mode, reviewer team with per-conditional justifications.
401
+ 2. **Findings.** Grouped by severity (P0, P1, P2, P3). Each finding shows file, issue, reviewer(s), confidence, and synthesized route.
402
+ 3. **Applied Fixes.** Include only if a fix phase ran in this invocation.
403
+ 4. **Residual Actionable Work.** Include when unresolved actionable findings were handed off or should be handed off.
404
+ 5. **Pre-existing.** Separate section, does not count toward verdict.
405
+ 6. **Learnings & Past Solutions.** Surface learnings-researcher results: if past solutions are relevant, flag them as "Known Pattern" with links to docs/solutions/ files.
406
+ 7. **Agent-Native Gaps.** Surface agent-native-reviewer results. Omit section if no gaps found.
407
+ 8. **Schema Drift Check.** If schema-drift-detector ran, summarize whether drift was found. If drift exists, list the unrelated schema objects and the required cleanup command. If clean, say so briefly.
408
+ 9. **Deployment Notes.** If deployment-verification-agent ran, surface the key Go/No-Go items: blocking pre-deploy checks, the most important verification queries, rollback caveats, and monitoring focus areas. Keep the checklist actionable rather than dropping it into Coverage.
409
+ 10. **Coverage.** Suppressed count, residual risks, testing gaps, failed/timed-out reviewers, and any intent uncertainty carried by non-interactive modes.
410
+ 11. **Verdict.** Ready to merge / Ready with fixes / Not ready. Fix order if applicable.
432
411
 
433
- 2. **Triage All Todos**:
434
- ```bash
435
- ls .context/systematic/todos/*-pending-*.md todos/*-pending-*.md 2>/dev/null # View all pending todos
436
- /triage # Use slash command for interactive triage
437
- ```
412
+ Do not include time estimates.
438
413
 
439
- 3. **Work on Approved Todos**:
414
+ ## Quality Gates
440
415
 
441
- ```bash
442
- /resolve-todo-parallel # Fix all approved items efficiently
443
- ```
416
+ Before delivering the review, verify:
444
417
 
445
- 4. **Track Progress**:
446
- - Rename file when status changes: pending ready complete
447
- - Update Work Log as you work
448
- - Commit review findings and status updates
418
+ 1. **Every finding is actionable.** Re-read each finding. If it says "consider", "might want to", or "could be improved" without a concrete fix, rewrite it with a specific action. Vague findings waste engineering time.
419
+ 2. **No false positives from skimming.** For each finding, verify the surrounding code was actually read. Check that the "bug" isn't handled elsewhere in the same function, that the "unused import" isn't used in a type annotation, that the "missing null check" isn't guarded by the caller.
420
+ 3. **Severity is calibrated.** A style nit is never P0. A SQL injection is never P3. Re-check every severity assignment.
421
+ 4. **Line numbers are accurate.** Verify each cited line number against the file content. A finding pointing to the wrong line is worse than no finding.
422
+ 5. **Protected artifacts are respected.** Discard any findings that recommend deleting or gitignoring files in `docs/brainstorms/`, `docs/plans/`, or `docs/solutions/`.
423
+ 6. **Findings don't duplicate linter output.** Don't flag things the project's linter/formatter would catch (missing semicolons, wrong indentation). Focus on semantic issues.
449
424
 
450
- ### Severity Breakdown:
425
+ ## Language-Aware Conditionals
451
426
 
452
- **🔴 P1 (Critical - Blocks Merge):**
427
+ This skill uses stack-specific reviewer agents when the diff clearly warrants them. Keep those agents opinionated. They are not generic language checkers; they add a distinct review lens on top of the always-on and cross-cutting personas.
453
428
 
454
- - Security vulnerabilities
455
- - Data corruption risks
456
- - Breaking changes
457
- - Critical architectural issues
429
+ Do not spawn them mechanically from file extensions alone. The trigger is meaningful changed behavior, architecture, or UI state in that stack.
458
430
 
459
- **🟡 P2 (Important - Should Fix):**
431
+ ## After Review
460
432
 
461
- - Performance issues
462
- - Significant architectural concerns
463
- - Major code quality problems
464
- - Reliability issues
433
+ ### Mode-Driven Post-Review Flow
465
434
 
466
- **🔵 P3 (Nice-to-Have):**
435
+ After presenting findings and verdict (Stage 6), route the next steps by mode. Review and synthesis stay the same in every mode; only mutation and handoff behavior changes.
467
436
 
468
- - Minor improvements
469
- - Code cleanup
470
- - Optimization opportunities
471
- - Documentation updates
472
- ````
437
+ #### Step 1: Build the action sets
473
438
 
474
- ### 6. End-to-End Testing (Optional)
439
+ - **Clean review** means zero findings after suppression and pre-existing separation. Skip the fix/handoff phase when the review is clean.
440
+ - **Fixer queue:** final findings routed to `safe_auto -> review-fixer`.
441
+ - **Residual actionable queue:** unresolved `gated_auto` or `manual` findings whose final owner is `downstream-resolver`.
442
+ - **Report-only queue:** `advisory` findings and any outputs owned by `human` or `release`.
443
+ - **Never convert advisory-only outputs into fix work or todos.** Deployment notes, residual risks, and release-owned items stay in the report.
475
444
 
476
- <detect_project_type>
445
+ #### Step 2: Choose policy by mode
477
446
 
478
- **First, detect the project type from PR files:**
447
+ **Interactive mode**
479
448
 
480
- | Indicator | Project Type |
481
- |-----------|--------------|
482
- | `*.xcodeproj`, `*.xcworkspace`, `Package.swift` (iOS) | iOS/macOS |
483
- | `Gemfile`, `package.json`, `app/views/*`, `*.html.*` | Web |
484
- | Both iOS files AND web files | Hybrid (test both) |
449
+ - Ask a single policy question only when actionable work exists.
450
+ - Recommended default:
485
451
 
486
- </detect_project_type>
452
+ ```
453
+ What should I do with the actionable findings?
454
+ 1. Apply safe_auto fixes and leave the rest as residual work (Recommended)
455
+ 2. Apply safe_auto fixes only
456
+ 3. Review report only
457
+ ```
487
458
 
488
- <offer_testing>
459
+ - Tailor the prompt to the actual action sets. If the fixer queue is empty, do not offer "Apply safe_auto fixes" options. Ask whether to externalize the residual actionable work or keep the review report-only instead.
460
+ - Only include `gated_auto` findings in the fixer queue after the user explicitly approves the specific items. Do not widen the queue based on severity alone.
489
461
 
490
- After presenting the Summary Report, offer appropriate testing based on project type:
462
+ **Autofix mode**
491
463
 
492
- **For Web Projects:**
493
- ```markdown
494
- **"Want to run browser tests on the affected pages?"**
495
- 1. Yes - run `/test-browser`
496
- 2. No - skip
497
- ```
464
+ - Ask no questions.
465
+ - Apply only the `safe_auto -> review-fixer` queue.
466
+ - Leave `gated_auto`, `manual`, `human`, and `release` items unresolved.
467
+ - Prepare residual work only for unresolved actionable findings whose final owner is `downstream-resolver`.
498
468
 
499
- **For iOS Projects:**
500
- ```markdown
501
- **"Want to run Xcode simulator tests on the app?"**
502
- 1. Yes - run `/xcode-test`
503
- 2. No - skip
504
- ```
469
+ **Report-only mode**
505
470
 
506
- **For Hybrid Projects (e.g., Rails + Hotwire Native):**
507
- ```markdown
508
- **"Want to run end-to-end tests?"**
509
- 1. Web only - run `/test-browser`
510
- 2. iOS only - run `/xcode-test`
511
- 3. Both - run both commands
512
- 4. No - skip
513
- ```
471
+ - Ask no questions.
472
+ - Do not build a fixer queue.
473
+ - Do not create residual todos or `.context` artifacts.
474
+ - Stop after Stage 6. Everything remains in the report.
514
475
 
515
- </offer_testing>
476
+ #### Step 3: Apply fixes with one fixer and bounded rounds
516
477
 
517
- #### If User Accepts Web Testing
478
+ - Spawn exactly one fixer subagent for the current fixer queue in the current checkout. That fixer applies all approved changes and runs the relevant targeted tests in one pass against a consistent tree.
479
+ - Do not fan out multiple fixers against the same checkout. Parallel fixers require isolated worktrees/branches and deliberate mergeback.
480
+ - Re-review only the changed scope after fixes land.
481
+ - Bound the loop with `max_rounds: 2`. If issues remain after the second round, stop and hand them off as residual work or report them as unresolved.
482
+ - If any applied finding has `requires_verification: true`, the round is incomplete until the targeted verification runs.
483
+ - Do not start a mutating review round concurrently with browser testing on the same checkout. Future orchestrators that want both must either run `mode:report-only` during the parallel phase or isolate the mutating review in its own checkout/worktree.
518
484
 
519
- Spawn a subagent to run browser tests (preserves main context):
485
+ #### Step 4: Emit artifacts and downstream handoff
520
486
 
521
- ```
522
- Task general-purpose("Run /test-browser for PR #[number]. Test all affected pages, check for console errors, handle failures by creating todos and fixing.")
523
- ```
524
-
525
- The subagent will:
526
- 1. Identify pages affected by the PR
527
- 2. Navigate to each page and capture snapshots (using Playwright MCP or agent-browser CLI)
528
- 3. Check for console errors
529
- 4. Test critical interactions
530
- 5. Pause for human verification on OAuth/email/payment flows
531
- 6. Create P1 todos for any failures
532
- 7. Fix and retry until all tests pass
487
+ - In interactive and autofix modes, write a per-run artifact under `.context/systematic/ce-review/<run-id>/` containing:
488
+ - synthesized findings
489
+ - applied fixes
490
+ - residual actionable work
491
+ - advisory-only outputs
492
+ - In autofix mode, create durable todo files only for unresolved actionable findings whose final owner is `downstream-resolver`. Load the `todo-create` skill for the canonical directory path, naming convention, YAML frontmatter structure, and template. Each todo should map the finding's severity to the todo priority (`P0`/`P1` -> `p1`, `P2` -> `p2`, `P3` -> `p3`) and set `status: ready` since these findings have already been triaged by synthesis.
493
+ - Do not create todos for `advisory` findings, `owner: human`, `owner: release`, or protected-artifact cleanup suggestions.
494
+ - If only advisory outputs remain, create no todos.
495
+ - Interactive mode may offer to externalize residual actionable work after fixes, but it is not required to finish the review.
533
496
 
534
- **Standalone:** `/test-browser [PR number]`
497
+ #### Step 5: Final next steps
535
498
 
536
- #### If User Accepts iOS Testing
499
+ **Interactive mode only:** after the fix-review cycle completes (clean verdict or the user chose to stop), offer next steps based on the entry mode. Reuse the resolved review base/default branch from Stage 1 when known; do not hard-code only `main`/`master`.
537
500
 
538
- Spawn a subagent to run Xcode tests (preserves main context):
501
+ - **PR mode (entered via PR number/URL):**
502
+ - **Push fixes** -- push commits to the existing PR branch
503
+ - **Exit** -- done for now
504
+ - **Branch mode (feature branch with no PR, and not the resolved review base/default branch):**
505
+ - **Create a PR (Recommended)** -- push and open a pull request
506
+ - **Continue without PR** -- stay on the branch
507
+ - **Exit** -- done for now
508
+ - **On the resolved review base/default branch:**
509
+ - **Continue** -- proceed with next steps
510
+ - **Exit** -- done for now
539
511
 
540
- ```
541
- Task general-purpose("Run /xcode-test for scheme [name]. Build for simulator, install, launch, take screenshots, check for crashes.")
542
- ```
512
+ If "Create a PR": first publish the branch with `git push --set-upstream origin HEAD`, then use `gh pr create` with a title and summary derived from the branch changes.
513
+ If "Push fixes": push the branch with `git push` to update the existing PR.
543
514
 
544
- The subagent will:
545
- 1. Verify XcodeBuildMCP is installed
546
- 2. Discover project and schemes
547
- 3. Build for iOS Simulator
548
- 4. Install and launch app
549
- 5. Take screenshots of key screens
550
- 6. Capture console logs for errors
551
- 7. Pause for human verification (Sign in with Apple, push, IAP)
552
- 8. Create P1 todos for any failures
553
- 9. Fix and retry until all tests pass
515
+ **Autofix and report-only modes:** stop after the report, artifact emission, and residual-work handoff. Do not commit, push, or create a PR.
554
516
 
555
- **Standalone:** `/xcode-test [scheme]`
517
+ ## Fallback
556
518
 
557
- ### Important: P1 Findings Block Merge
519
+ If the platform doesn't support parallel sub-agents, run reviewers sequentially. Everything else (stages, output format, merge pipeline) stays the same.
558
520
 
559
- Any **🔴 P1 (CRITICAL)** findings must be addressed before merging the PR. Present these prominently and ensure they're resolved before accepting the PR.