@fresh-editor/fresh-editor 0.3.0 → 0.3.2

package/CHANGELOG.md

@@ -1,5 +1,123 @@
 # Release Notes
 
+## 0.3.2
+
+### Features
+
+* **Live Diff plugin** (experimental): Unified-diff overlay rendered live in the editable buffer. If your file is unmodified in the editor, it updates as the file changes on disk when auto-revert kicks in - great for watching an agent edit your file. Opt-in via `Live Diff: Toggle (Global)` / `Live Diff: Toggle (Buffer)`. Reference selectable per buffer: `vs HEAD` / `vs Disk` / `vs Branch...` / `vs Default Branch`.
+
+* **New Startup section in Settings** (open Settings and search "Startup") groups everything that fires on launch:
+    - **Blank-workspace flow** (#1753) — *Auto Create Empty Buffer On Last Buffer Close* (Editor) and *Auto Open On Last Buffer Close* (File Explorer). With both off, closing the last buffer leaves a truly blank pane (no `[No Name]`, no gutter, no `~`); buffer-specific status-bar items and menu entries are suppressed, and a subdued centered hint shows the keys to escape (`Ctrl+P` / `Ctrl+O` / `Ctrl+E`).
+    - *Skip Session Restore When Files Passed* — `fresh src/main.rs` opens just that file; bare `fresh` and `fresh some/dir` still restore. Hot-exit recovery still runs. `--restore` overrides.
+    - *Restore Previous Session* (existing, moved into Startup).
+
+* **File explorer side** (thanks @paveloparev!): *Side* under File Explorer in Settings — left or right.
+
+* **Prompt Line now hidden by default**: *Show Prompt Line* now defaults off — the prompt line only appears while a prompt is active. Turn it back on via Settings.
+
+* **Mark mode preserved through Go to Line** so you can extend selections across the jump. Use **Set Mark** command followed by **Goto Line** to start a selection and extend it to the target line.
+
+* **Copy File Path commands**: New commands: "Copy File Path" and "Copy Relative File Path" to copy current buffer's path to your clipboard. Also available by right-clicking on a tab name.
+
+* **CLI Help Localization**: The `--help` output is now fully localized using runtime i18n lookups.
+
+* **Relative +/- Goto Line**: Infers absolute vs relative jumps from a leading sign (e.g., `:+10` jumps 10 lines down, `:10` jumps to line 10).
+
+* **Rust Toolchain Update**: Updated to Rust 1.95 in `rust-toolchain.toml` to fix compatibility issues with newer LLVM/clang versions on systems like Arch Linux (#1782).
+
+### Improvements
+
+* **Plugin loading deferred off the boot critical path** — another ~225 ms saved. Same load order, same hooks, just async.
+
+* **Popup focus**: LSP popups that auto-show on file open (status popup, hover, signature help, plugin Text overlays) no longer steal the next keystroke. They show unfocused with an `[Alt+T to focus]` hint; user-invoked popups (Completion, code actions, status-bar `{remote}`, LSP-status menu) still grab focus on show. Settings / Menu / Prompt modals take precedence over unfocused buffer popups for `Esc` / `popup_focus`.
+
+* **Status Bar visual integration** (#1711): The "Palette: Ctrl+P" hint and "LSP (on)" indicator now blend into the status bar by default. Built-in themes have been updated with coherent prominent colors for these indicators.
+
+* **Prompt interaction and scrolling** (#1660):
+    - Minimal scrolling: the suggestion list no longer recenters the selection on every move, preventing "row jumping" during navigation.
+    - Clicks no longer cause accidental list shifts; double-click correctly confirms selections.
+    - Preview-on-click supported for "Reload with encoding".
+
+* **Global Menu Bar**: "Toggle Menu Bar" state is now persisted globally across all workspaces.
+
+* **Windows integration**: High-quality app icon applied to the running window; app manifest and version info embedded in the binary.
+
+### Bug Fixes
+
+* **Windows subprocesses**: Transient console windows are now hidden when spawning subprocesses (e.g., formatters, linters).
+
+* **Terminal CWD**: Fixed shell spawning failure on Windows when the current directory has a `\\?\` UNC prefix.
+
+* **Live Diff stability**: Fixed crashes on surrogate-pair content (emojis) and corrected gutter rendering for empty lines inside added blocks.
+
+### Under the Hood
+
+* **Syntax Highlight Caching**: New multi-phase caching system (memoised scope lookups and whole-file cache for small files) significantly reduces CPU usage during rendering.
+
+## 0.3.1
+
+### Features
+
+* **Animations framework**: tab-switch slide; cursor-jump trail animation. Disable it via Settings UI. Animations available to plugins via API.
+
+* **Flash plugin** (label-jump, à la flash.nvim): bundled plugin — type a pattern, press the displayed label to jump, even across split panes.
+
+* **Devcontainer fixes**: See below
+
+### Improvements
+
+* **Relative-numbers go-to negative** (thanks @paveloparev!): `g<-N>` jumps N lines up in relative-numbers mode.
+
+* **Racket language support**: `.rkt` / `.rktd` / `.rktl` / `.scrbl` highlight out of the box; LSP via `racket-langserver`.
+
+* **`{remote}` indicator default-on**: rendered on bottom-left for fresh installs (`F6` default keybinding, palette command).
+
+* **Quick Open keybindings** (thanks @paveloparev!): `Ctrl+'` for files, `Ctrl+;` for buffers. Some terminals don't like passing these keys, you can rebind in the Keybinding UI (future version will probably change the default shortcuts to be more terminal-friendly across platforms).
+
+* **Completion popup rebindable** (#1705): Allow modifying key bindings for the non-lsp completions popup.
+
+* **Better scrolling** on markdown preview buffers and very-long-line buffers via a new two-tier line-wrap cache.
+
+* **LSP**:
+    - Stuck request no longer blocks others (#1679): per-server handlers on independent tokio tasks + 30 s timeout. R `languageserver` 0.3.17 no longer wedges completion / signature help.
+    - Empty-server completion fallback to buffer-word completions.
+    - Failure-stub log so "View Log" works after a failed spawn.
+
+* **Devcontainer** spec-conformance + UX:
+    - Lifecycle `cwd = remoteWorkspaceFolder`; object-form entries run in parallel and continue past failures; `remoteEnv` propagated; `shutdownAction: stopContainer` honoured on Detach; `userEnvProbe` captured and merged; `remoteUser` falls back per spec.
+    - Lifecycle stdout/stderr surface in the panel; `Show *` commands reuse a single panel; build log split reused not stacked; parse errors surface (and `Open Config` stays registered); `onAutoForward: notify` toasts; state-relevant commands gated by authority; no re-prompt after restart.
+    - **Devcontainer Goto-Definition across host / container**: LSP URIs translate at the boundary; container-only paths (e.g. `flask/app.py` under the venv) are fetched into a buffer.
+
+* **File explorer preview** no longer loses focus to LSP popups in the editor pane.
+
+* **Plugin types**: `tsconfig.json` for `tsc --noEmit` in CI; `editor.on(fn)` infers payload types from `HookEventMap`; `HookArgs` derives serde.
+
+* **Conceal substitution** now emits the replacement glyph for whitespace tokens (Space / Newline / Break).
+
+### Bug Fixes
+
+* **`plugins/` folder in your project no longer hides bundled commands** (#1722): Fresh stops scanning the working directory for plugins.
+
+* **Scroll & viewport**:
+    - Mouse-wheel / PageDown / scrollbar-drag now reach EOF on word-wrapped buffers, including compose-mode markdown ending in a table. Within-line scroll re-clamps; gutter calc unified.
+    - Search wrap-around Down-arrow stall: stale `scrolled_up_in_wrap` cleared on recenter.
+
+* **Non-ASCII truncation panics** (#1715, #1718): settings search/preview/description/changelog, file-browser sort-arrow header, status-bar `truncate_path`, shell `truncate_command`, map-input value previews. Text search inside rows with multi-byte glyphs no longer panics either.
+
+* **`setLayoutHints`** binds `compose_width` to the buffer, not whichever buffer is active.
+
+### Under the Hood
+
+* **Line-wrap cache** (`LineWrapCache` + tier-2 `VisualRowIndex`) becomes the single source of truth — `wrap_line` / `WrappedSegment` deleted; scroll math, cursor position, and scrollbar thumb share one pipeline.
+
+* **Marker-tree `remove_in_range`** for `SoftBreakManager` / `ConcealManager` / `OverlayManager`: O(log N + k), proptest invariants.
+
+* **`LspUri` newtype** enforces host / container URI translation at the type level.
+
+* **Refactors**: `handle_mouse_click` (764 lines) → 14 helpers; `real_main` decomposed; `plugin_dispatch` match arms extracted; `quickjs_backend` ID-allocation boilerplate collapsed; `FromJs` impls into a macro; mouse multi-click + scroll dispatch deduped.
+
+* **Test infrastructure**: fake `devcontainer` / `docker` / `pylsp` CLIs drive e2es without real binaries; plugin fixtures load from `<config_dir>/plugins/` instead of the cwd; animations default off in tests.
+
 ## 0.3.0
 
 This version brings major features and many quality-of-life improvements and bug fixes:
@@ -27,8 +145,8 @@ And more (see below). A large version is more likely to contain regression bugs,
     - Build log streams into a workspace split; failed attaches offer Retry / Show Logs / Detach via a recovery popup.
     - `initializeCommand` runs on attach.
 
-* **`init.ts`**: Fresh now auto-loads `~/.config/fresh/init.ts`! Allows you to run plugin code on startup, which complements the purely declarative config system with imperative, environment-aware logic. Use command palette `init: Edit` to generate a template with some examples. Use `init: Reload` to run it after editing. Use `--no-init` / `--safe` to skip loading.  
-    - Tip: *Enable LSP* when editing `init.ts` to get help and completions. 
+* **`init.ts`**: Fresh now auto-loads `~/.config/fresh/init.ts`! Allows you to run plugin code on startup, which complements the purely declarative config system with imperative, environment-aware logic. Use command palette `init: Edit` to generate a template with some examples. Use `init: Reload` to run it after editing. Use `--no-init` / `--safe` to skip loading.
+    - Tip: *Enable LSP* when editing `init.ts` to get help and completions.
     - Example (for the Dashboard plugin):
     ```typescript
     // in your init.ts file:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@fresh-editor/fresh-editor",
-  "version": "0.3.0",
+  "version": "0.3.2",
   "description": "A modern terminal-based text editor with plugin support",
   "repository": {
     "type": "git",

package/plugins/astro-lsp.ts

@@ -35,7 +35,7 @@ const INSTALL_COMMANDS = {
 
 let astroLspError: { serverCommand: string; message: string } | null = null;
 
-function on_astro_lsp_server_error(data: LspServerErrorData): void {
+editor.on("lsp_server_error", (data) => {
   if (data.language !== "astro") {
     return;
   }
@@ -54,11 +54,9 @@ function on_astro_lsp_server_error(data: LspServerErrorData): void {
   } else {
     editor.setStatus(`Astro LSP error: ${data.message}`);
   }
-}
-registerHandler("on_astro_lsp_server_error", on_astro_lsp_server_error);
-editor.on("lsp_server_error", "on_astro_lsp_server_error");
+});
 
-function on_astro_lsp_status_clicked(data: LspStatusClickedData): void {
+editor.on("lsp_status_clicked", (data) => {
   if (data.language !== "astro" || !astroLspError) {
     return;
   }
@@ -76,11 +74,9 @@ function on_astro_lsp_status_clicked(data: LspStatusClickedData): void {
       { id: "dismiss", label: "Dismiss (ESC)" },
     ],
   });
-}
-registerHandler("on_astro_lsp_status_clicked", on_astro_lsp_status_clicked);
-editor.on("lsp_status_clicked", "on_astro_lsp_status_clicked");
+});
 
-function on_astro_lsp_action_result(data: ActionPopupResultData): void {
+editor.on("action_popup_result", (data) => {
   if (data.popup_id !== "astro-lsp-help") {
     return;
   }
@@ -111,8 +107,6 @@ function on_astro_lsp_action_result(data: ActionPopupResultData): void {
     default:
       editor.debug(`astro-lsp: Unknown action: ${data.action_id}`);
   }
-}
-registerHandler("on_astro_lsp_action_result", on_astro_lsp_action_result);
-editor.on("action_popup_result", "on_astro_lsp_action_result");
+});
 
 editor.debug("astro-lsp: Plugin loaded");

package/plugins/audit_mode.ts

@@ -54,6 +54,7 @@ interface Hunk {
   oldRange: { start: number; end: number };  // old file line range
   type: 'add' | 'remove' | 'modify';
   lines: string[];
+  status?: string;
   contextHeader: string;
   byteOffset: number; // Position in the virtual buffer
   gitStatus?: 'staged' | 'unstaged' | 'untracked';
@@ -2462,48 +2463,9 @@ function review_discard_file() {
 }
 registerHandler("review_discard_file", review_discard_file);
 
-async function on_review_discard_hunk_confirm(args: { prompt_type: string; input: string; selected_index: number | null }): Promise<boolean> {
-    if (args.prompt_type !== "review-discard-hunk-confirm") return true;
-    const response = args.input.trim().toLowerCase();
-    if (response === "discard" || args.selected_index === 0) {
-        const hunk = getHunkAtDiffCursor();
-        if (hunk && hunk.file) {
-            const patch = buildHunkPatch(hunk.file, hunk);
-            const ok = await applyHunkPatch(patch, ["--reverse"]);
-            if (ok) {
-                editor.setStatus(editor.t("status.hunk_discarded") || "Hunk discarded");
-                await refreshMagitData();
-            }
-        }
-    } else {
-        editor.setStatus("Discard cancelled");
-    }
-    return false;
-}
-registerHandler("on_review_discard_hunk_confirm", on_review_discard_hunk_confirm);
 
-async function on_review_discard_confirm(args: { prompt_type: string; input: string; selected_index: number | null }): Promise<boolean> {
-    if (args.prompt_type !== "review-discard-confirm") return true;
 
-    const response = args.input.trim().toLowerCase();
-    if (response === "discard" || args.selected_index === 0) {
-        const f = pendingDiscardFile;
-        if (f) {
-            if (f.category === 'untracked') {
-                await editor.spawnProcess("rm", ["--", f.path]);
-            } else {
-                await editor.spawnProcess("git", ["checkout", "--", f.path]);
-            }
-            await refreshMagitData();
-            editor.setStatus(`Discarded: ${f.path}`);
-        }
-    } else {
-        editor.setStatus("Discard cancelled");
-    }
-    pendingDiscardFile = null;
-    return false;
-}
-registerHandler("on_review_discard_confirm", on_review_discard_confirm);
+
 
 /**
  * Refresh file list and diffs using the new git status approach, then re-render.
@@ -3456,28 +3418,15 @@ async function review_delete_comment() {
 }
 registerHandler("review_delete_comment", review_delete_comment);
 
-function on_review_delete_comment_confirm(args: { prompt_type: string; input: string; selected_index: number | null }): boolean {
-    if (args.prompt_type !== "review-delete-comment-confirm") return true;
-    const response = args.input.trim().toLowerCase();
-    if ((response === "delete" || args.selected_index === 0) && pendingDeleteCommentId) {
-        if (pendingDeleteCommentId === '__note__') {
-            state.note = '';
-        } else {
-            state.comments = state.comments.filter(c => c.id !== pendingDeleteCommentId);
-        }
-        persistReview();
-        updateMagitDisplay();
-        editor.setStatus("Deleted");
-    } else {
-        editor.setStatus("Delete cancelled");
-    }
-    pendingDeleteCommentId = null;
-    return false;
-}
-registerHandler("on_review_delete_comment_confirm", on_review_delete_comment_confirm);
+
 
 // Prompt event handlers
-function on_review_prompt_confirm(args: { prompt_type: string; input: string }): boolean {
+
+
+
+
+// Register prompt event handlers
+editor.on("prompt_confirmed", (args) => {
     if (args.prompt_type !== "review-comment") {
         return true;
     }
@@ -3540,38 +3489,47 @@ function on_review_prompt_confirm(args: { prompt_type: string; input: string }):
     }
     pendingCommentInfo = null;
     return true;
-}
-registerHandler("on_review_prompt_confirm", on_review_prompt_confirm);
+});
+editor.on("prompt_confirmed", async (args) => {
+    if (args.prompt_type !== "review-discard-confirm") return true;
 
-function on_review_prompt_cancel(args: { prompt_type: string }): boolean {
-    if (args.prompt_type === "review-comment") {
-        pendingCommentInfo = null;
-        editingCommentId = null;
-        editor.setStatus(editor.t("status.comment_cancelled"));
+    const response = args.input.trim().toLowerCase();
+    if (response === "discard" || args.selected_index === 0) {
+        const f = pendingDiscardFile;
+        if (f) {
+            if (f.category === 'untracked') {
+                await editor.spawnProcess("rm", ["--", f.path]);
+            } else {
+                await editor.spawnProcess("git", ["checkout", "--", f.path]);
+            }
+            await refreshMagitData();
+            editor.setStatus(`Discarded: ${f.path}`);
+        }
+    } else {
+        editor.setStatus("Discard cancelled");
     }
-    return true;
-}
-registerHandler("on_review_prompt_cancel", on_review_prompt_cancel);
-
-// Register prompt event handlers
-editor.on("prompt_confirmed", "on_review_prompt_confirm");
-editor.on("prompt_confirmed", "on_review_discard_confirm");
-editor.on("prompt_confirmed", "on_review_discard_hunk_confirm");
-editor.on("prompt_confirmed", "on_review_edit_note_confirm");
-editor.on("prompt_confirmed", "on_review_delete_comment_confirm");
-editor.on("prompt_cancelled", "on_review_prompt_cancel");
-
-async function review_edit_note() {
-    const label = editor.t("prompt.overall_comment") || "Note: ";
-    if (state.note) {
-        editor.startPromptWithInitial(label, "review-edit-note", state.note);
+    pendingDiscardFile = null;
+    return false;
+});
+editor.on("prompt_confirmed", async (args) => {
+    if (args.prompt_type !== "review-discard-hunk-confirm") return true;
+    const response = args.input.trim().toLowerCase();
+    if (response === "discard" || args.selected_index === 0) {
+        const hunk = getHunkAtDiffCursor();
+        if (hunk && hunk.file) {
+            const patch = buildHunkPatch(hunk.file, hunk);
+            const ok = await applyHunkPatch(patch, ["--reverse"]);
+            if (ok) {
+                editor.setStatus(editor.t("status.hunk_discarded") || "Hunk discarded");
+                await refreshMagitData();
+            }
+        }
     } else {
-        editor.startPrompt(label, "review-edit-note");
+        editor.setStatus("Discard cancelled");
     }
-}
-registerHandler("review_edit_note", review_edit_note);
-
-function on_review_edit_note_confirm(args: { prompt_type: string; input: string }): boolean {
+    return false;
+});
+editor.on("prompt_confirmed", (args) => {
     if (args.prompt_type !== "review-edit-note") return true;
     if (args.input && args.input.trim()) {
         state.note = args.input.trim();
@@ -3585,8 +3543,45 @@ function on_review_edit_note_confirm(args: { prompt_type: string; input: string
         }
     }
     return true;
+});
+editor.on("prompt_confirmed", (args) => {
+    if (args.prompt_type !== "review-delete-comment-confirm") return true;
+    const response = args.input.trim().toLowerCase();
+    if ((response === "delete" || args.selected_index === 0) && pendingDeleteCommentId) {
+        if (pendingDeleteCommentId === '__note__') {
+            state.note = '';
+        } else {
+            state.comments = state.comments.filter(c => c.id !== pendingDeleteCommentId);
+        }
+        persistReview();
+        updateMagitDisplay();
+        editor.setStatus("Deleted");
+    } else {
+        editor.setStatus("Delete cancelled");
+    }
+    pendingDeleteCommentId = null;
+    return false;
+});
+editor.on("prompt_cancelled", (args) => {
+    if (args.prompt_type === "review-comment") {
+        pendingCommentInfo = null;
+        editingCommentId = null;
+        editor.setStatus(editor.t("status.comment_cancelled"));
+    }
+    return true;
+});
+
+async function review_edit_note() {
+    const label = editor.t("prompt.overall_comment") || "Note: ";
+    if (state.note) {
+        editor.startPromptWithInitial(label, "review-edit-note", state.note);
+    } else {
+        editor.startPrompt(label, "review-edit-note");
+    }
 }
-registerHandler("on_review_edit_note_confirm", on_review_edit_note_confirm);
+registerHandler("review_edit_note", review_edit_note);
+
+
 
 async function review_export_session() {
     const cwd = editor.getCwd();
@@ -3736,15 +3731,15 @@ async function openReviewPanels(groupName: string): Promise<boolean> {
 
     updateMagitDisplay();
 
-    editor.focusBufferGroupPanel(state.groupId, "diff");
+    editor.focusBufferGroupPanel(state.groupId!, "diff");
 
-    editor.on("resize", "onReviewDiffResize");
+    editor.on("resize", onReviewDiffResize);
     updateReviewStatus();
-    editor.on("buffer_activated", "on_review_buffer_activated");
-    editor.on("buffer_closed", "on_review_buffer_closed");
-    editor.on("cursor_moved", "on_review_cursor_moved");
-    editor.on("viewport_changed", "on_review_viewport_changed");
-    editor.on("mouse_click", "on_review_mouse_click");
+    editor.on("buffer_activated", on_review_buffer_activated);
+    editor.on("buffer_closed", on_review_buffer_closed);
+    editor.on("cursor_moved", on_review_cursor_moved);
+    editor.on("viewport_changed", on_review_viewport_changed);
+    editor.on("mouse_click", on_review_mouse_click);
     return true;
 }
 
@@ -3820,12 +3815,12 @@ function stop_review_diff() {
     }
     state.reviewBufferId = null;
     editor.setContext("review-mode", false);
-    editor.off("resize", "onReviewDiffResize");
-    editor.off("buffer_activated", "on_review_buffer_activated");
-    editor.off("buffer_closed", "on_review_buffer_closed");
-    editor.off("cursor_moved", "on_review_cursor_moved");
-    editor.off("viewport_changed", "on_review_viewport_changed");
-    editor.off("mouse_click", "on_review_mouse_click");
+    editor.off("resize", onReviewDiffResize);
+    editor.off("buffer_activated", on_review_buffer_activated);
+    editor.off("buffer_closed", on_review_buffer_closed);
+    editor.off("cursor_moved", on_review_cursor_moved);
+    editor.off("viewport_changed", on_review_viewport_changed);
+    editor.off("mouse_click", on_review_mouse_click);
     editor.setStatus(editor.t("status.stopped"));
 }
 registerHandler("stop_review_diff", stop_review_diff);
@@ -3968,7 +3963,8 @@ async function start_review_range(): Promise<void> {
 }
 registerHandler("start_review_range", start_review_range);
 
-function on_review_range_confirm(args: { prompt_type: string; input: string }): boolean {
+
+editor.on("prompt_confirmed", (args) => {
     if (args.prompt_type !== "review-range") return true;
     const range = parseRangeInput(args.input);
     if (!range) {
@@ -3979,9 +3975,7 @@ function on_review_range_confirm(args: { prompt_type: string; input: string }):
     // can return immediately.
     bootstrapRangeReview(range);
     return true;
-}
-registerHandler("on_review_range_confirm", on_review_range_confirm);
-editor.on("prompt_confirmed", "on_review_range_confirm");
+});
 
 async function bootstrapRangeReview(range: ReviewRange): Promise<void> {
     editor.setStatus(editor.t("status.generating") || "Generating diff…");
@@ -4607,7 +4601,7 @@ async function start_review_branch(): Promise<void> {
     if (branchState.groupId !== null) {
         editor.focusBufferGroupPanel(branchState.groupId, "log");
     }
-    editor.on("cursor_moved", "on_review_branch_cursor_moved");
+    editor.on("cursor_moved", on_review_branch_cursor_moved);
 
     editor.setStatus(
         editor.t("status.review_branch_ready", {
@@ -4621,7 +4615,7 @@ registerHandler("start_review_branch", start_review_branch);
 function stop_review_branch(): void {
     if (!branchState.isOpen) return;
     if (branchState.groupId !== null) editor.closeBufferGroup(branchState.groupId);
-    editor.off("cursor_moved", "on_review_branch_cursor_moved");
+    editor.off("cursor_moved", on_review_branch_cursor_moved);
     branchState.isOpen = false;
     branchState.groupId = null;
     branchState.logBufferId = null;
@@ -4717,7 +4711,9 @@ editor.registerCommand("%cmd.export_markdown", "%cmd.export_markdown_desc", "rev
 editor.registerCommand("%cmd.export_json", "%cmd.export_json_desc", "review_export_json", "review-mode");
 
 // Handler for when buffers are closed - cleans up scroll sync groups and composite buffers
-function on_buffer_closed(data: any) {
+
+
+editor.on("buffer_closed", (data) => {
     // If one of the diff view buffers is closed, clean up the scroll sync group
     if (activeSideBySideState) {
         if (data.buffer_id === activeSideBySideState.oldBufferId ||
@@ -4744,10 +4740,7 @@ function on_buffer_closed(data: any) {
             activeCompositeDiffState = null;
         }
     }
-}
-registerHandler("on_buffer_closed", on_buffer_closed);
-
-editor.on("buffer_closed", "on_buffer_closed");
+});
 
 editor.defineMode("review-mode", [
     // Native cursor motion in the unified diff stream.

package/plugins/bash-lsp.ts

@@ -49,7 +49,10 @@ let bashLspError: { serverCommand: string; message: string } | null = null;
 /**
  * Handle LSP server errors for Bash
  */
-function on_bash_lsp_server_error(data: LspServerErrorData): void {
+
+
+// Register hook for LSP server errors
+editor.on("lsp_server_error", (data) => {
   // Only handle Bash language errors
   if (data.language !== "bash") {
     return;
@@ -71,18 +74,15 @@ function on_bash_lsp_server_error(data: LspServerErrorData): void {
   } else {
     editor.setStatus(`Bash LSP error: ${data.message}`);
   }
-}
-registerHandler("on_bash_lsp_server_error", on_bash_lsp_server_error);
-
-// Register hook for LSP server errors
-editor.on("lsp_server_error", "on_bash_lsp_server_error");
+});
 
 /**
  * Handle status bar click when there's a Bash LSP error
  */
-function on_bash_lsp_status_clicked(
-  data: LspStatusClickedData
-): void {
+
+
+// Register hook for status bar clicks
+editor.on("lsp_status_clicked", (data) => {
   // Only handle Bash language clicks when there's an error
   if (data.language !== "bash" || !bashLspError) {
     return;
@@ -103,18 +103,15 @@ function on_bash_lsp_status_clicked(
       { id: "dismiss", label: "Dismiss (ESC)" },
     ],
   });
-}
-registerHandler("on_bash_lsp_status_clicked", on_bash_lsp_status_clicked);
-
-// Register hook for status bar clicks
-editor.on("lsp_status_clicked", "on_bash_lsp_status_clicked");
+});
 
 /**
  * Handle action popup results for Bash LSP help
  */
-function on_bash_lsp_action_result(
-  data: ActionPopupResultData
-): void {
+
+
+// Register hook for action popup results
+editor.on("action_popup_result", (data) => {
   // Only handle our popup
   if (data.popup_id !== "bash-lsp-help") {
     return;
@@ -152,10 +149,6 @@ function on_bash_lsp_action_result(
     default:
       editor.debug(`bash-lsp: Unknown action: ${data.action_id}`);
   }
-}
-registerHandler("on_bash_lsp_action_result", on_bash_lsp_action_result);
-
-// Register hook for action popup results
-editor.on("action_popup_result", "on_bash_lsp_action_result");
+});
 
 editor.debug("bash-lsp: Plugin loaded");

package/plugins/clangd-lsp.ts

@@ -54,9 +54,10 @@ let clangdLspError: {
 /**
  * Handle LSP server errors for C/C++
  */
-function on_clangd_lsp_server_error(
-  data: LspServerErrorData
-): void {
+
+
+// Register hook for LSP server errors
+editor.on("lsp_server_error", (data) => {
   // Only handle C/C++ language errors
   if (!HANDLED_LANGUAGES.includes(data.language)) {
     return;
@@ -79,18 +80,15 @@ function on_clangd_lsp_server_error(
   } else {
     editor.setStatus(`C/C++ LSP error: ${data.message}`);
   }
-}
-registerHandler("on_clangd_lsp_server_error", on_clangd_lsp_server_error);
-
-// Register hook for LSP server errors
-editor.on("lsp_server_error", "on_clangd_lsp_server_error");
+});
 
 /**
  * Handle status bar click when there's a C/C++ LSP error
  */
-function on_clangd_lsp_status_clicked(
-  data: LspStatusClickedData
-): void {
+
+
+// Register hook for status bar clicks
+editor.on("lsp_status_clicked", (data) => {
   // Only handle C/C++ language clicks when there's an error
   if (!HANDLED_LANGUAGES.includes(data.language) || !clangdLspError) {
     return;
@@ -111,18 +109,15 @@ function on_clangd_lsp_status_clicked(
       { id: "dismiss", label: "Dismiss (ESC)" },
     ],
   });
-}
-registerHandler("on_clangd_lsp_status_clicked", on_clangd_lsp_status_clicked);
-
-// Register hook for status bar clicks
-editor.on("lsp_status_clicked", "on_clangd_lsp_status_clicked");
+});
 
 /**
  * Handle action popup results for C/C++ LSP help
  */
-function on_clangd_lsp_action_result(
-  data: ActionPopupResultData
-): void {
+
+
+// Register hook for action popup results
+editor.on("action_popup_result", (data) => {
   // Only handle our popup
   if (data.popup_id !== "clangd-lsp-help") {
     return;
@@ -162,10 +157,6 @@ function on_clangd_lsp_action_result(
     default:
       editor.debug(`clangd-lsp: Unknown action: ${data.action_id}`);
   }
-}
-registerHandler("on_clangd_lsp_action_result", on_clangd_lsp_action_result);
-
-// Register hook for action popup results
-editor.on("action_popup_result", "on_clangd_lsp_action_result");
+});
 
 editor.debug("clangd-lsp: Plugin loaded");