@fprad0/skill-master-mcp 0.0.12 → 1.0.1

package/bin/skill-master-doctor.mjs

@@ -1,228 +1,239 @@
-#!/usr/bin/env node
-import { spawnSync } from 'node:child_process';
-import { existsSync, readFileSync } from 'node:fs';
-import os from 'node:os';
-import path from 'node:path';
-import { fileURLToPath } from 'node:url';
-import {
-  assessCodexConfigContent,
-  assessMcpServerConfig,
-  defaultClientConfigPaths,
-} from './lib/client-config.mjs';
-
-const here = path.dirname(fileURLToPath(import.meta.url));
-const rootDir = path.resolve(here, '..');
-const args = process.argv.slice(2);
-const has = (flag) => args.includes(flag);
-
-if (has('--help') || has('-h')) {
-  console.log(`Skill Master Doctor
-
-Uso:
-  skill-master-doctor
-  skill-master-doctor --strict
-
-Valida pacote, binarios, skills globais e registro MCP em Codex, Claude,
-Claude Code, Gemini e Antigravity. Nao publica versoes e nao altera configuracoes.
-
-O registro recomendado usa Node absoluto + bin/skill-master.mjs absoluto para
-evitar falhas de PATH em apps desktop no Windows, Linux e macOS.
-`);
-  process.exit(0);
-}
-
-const REQUIRED_GLOBAL_SKILLS = [
-  'catholic-moral-discernment',
-  'ai-ethics-human-dignity',
-  'professional-boundary-triage',
-  'broad-domain-router',
-  'language-quality-pt-en-fr',
-  'math-science-reasoning',
-  'philosophy-sociology-discernment',
-  'engineering-systems-master',
-  'source-authority-reviewer',
-  'release-ethics-gate',
-  'mcp-client-readiness',
-  'terminal-menu-operations',
-  'terminal-pixel-art-tui',
-  'senior-master-code-optimizer',
-  'typescript-senior-master-engineering',
-  'python-senior-master-engineering',
-  'javascript-senior-master-engineering',
-  'go-senior-master-engineering',
-  'sql-senior-master-engineering',
-  'json-senior-master-engineering',
-  'ruby-senior-master-engineering',
-  'react-senior-master-engineering',
-  'html-senior-master-engineering',
-  'css-senior-master-engineering',
-  'csharp-senior-master-engineering',
-];
-
-const REQUIRED_BINS = [
-  'skill-master-menu',
-  'skill-master-mcp',
-  'skill-master-update',
-  'skill-master-bootstrap-global',
-  'skill-master-install-global-skills',
-  'skill-master-install-project-skills',
-  'skill-master-register-clients',
-  'skill-master-doctor',
-];
-
-function readJson(filePath) {
-  if (!existsSync(filePath)) return { present: false, invalid: false, value: null };
-  try {
-    const raw = readFileSync(filePath, 'utf8').trim();
-    return { present: true, invalid: false, value: raw ? JSON.parse(raw) : {} };
-  } catch {
-    return { present: true, invalid: true, value: null };
-  }
-}
-
-function commandExists(command) {
-  const lookup = process.platform === 'win32' ? 'where' : 'command';
-  const lookupArgs = process.platform === 'win32' ? [command] : ['-v', command];
-  const result = spawnSync(lookup, lookupArgs, { shell: process.platform !== 'win32', stdio: 'ignore' });
-  return result.status === 0;
-}
-
-function claudeCodeState() {
-  if (!commandExists('claude')) {
-    return {
-      filePath: 'claude CLI',
-      present: false,
-      configured: true,
-      optionalMissing: true,
-      mode: 'cli-missing',
-      command: null,
-    };
-  }
-
-  const result = spawnSync('claude', ['mcp', 'list'], {
-    encoding: 'utf8',
-    timeout: 10000,
-    stdio: ['ignore', 'pipe', 'pipe'],
-  });
-  const output = `${result.stdout ?? ''}${result.stderr ?? ''}`;
-  const configured = /skill[-_]master/i.test(output);
-
-  return {
-    filePath: 'claude mcp list',
-    present: true,
-    configured,
-    mode: configured ? 'claude-cli' : result.status === 0 ? 'missing' : 'list-failed',
-    command: configured ? 'claude mcp list' : output.trim() || null,
-  };
-}
-
-function jsonClientState(filePath) {
-  const parsed = readJson(filePath);
-  if (parsed.invalid) {
-    return {
-      filePath,
-      present: true,
-      configured: false,
-      mode: 'invalid-json',
-      command: null,
-    };
-  }
-
-  const server = parsed.value?.mcpServers?.skill_master;
-  const assessment = assessMcpServerConfig(server);
-  return {
-    filePath,
-    present: parsed.present,
-    configured: assessment.robust,
-    mode: assessment.mode,
-    command: assessment.command,
-  };
-}
-
-function codexState(filePath) {
-  if (!existsSync(filePath)) {
-    return { filePath, present: false, configured: false, mode: 'missing', command: null };
-  }
-
-  const content = readFileSync(filePath, 'utf8');
-  const assessment = assessCodexConfigContent(content);
-  return {
-    filePath,
-    present: true,
-    configured: assessment.robust,
-    mode: assessment.mode,
-    command: assessment.command,
-  };
-}
-
-function resultLine(ok, label, detail) {
-  const marker = ok ? 'OK' : 'NO';
-  return `[${marker}] ${label}${detail ? ` - ${detail}` : ''}`;
-}
-
-const packageJsonState = readJson(path.join(rootDir, 'package.json'));
-const packageJson = packageJsonState.value;
-const globalSkillsRoot = path.join(process.env.CODEX_HOME ?? path.join(os.homedir(), '.codex'), 'skills');
-const installedSkills = REQUIRED_GLOBAL_SKILLS.filter((skill) => existsSync(path.join(globalSkillsRoot, skill, 'SKILL.md')));
-const missingSkills = REQUIRED_GLOBAL_SKILLS.filter((skill) => !installedSkills.includes(skill));
-
-const clientPaths = defaultClientConfigPaths();
-const clients = [
-  ['Codex', codexState(clientPaths.codex)],
-  ['Claude Desktop', jsonClientState(clientPaths.claude)],
-  ['Claude Code', claudeCodeState()],
-  ['Gemini CLI', jsonClientState(clientPaths.gemini)],
-  ['Antigravity', jsonClientState(clientPaths.antigravity)],
-];
-
-const binResults = REQUIRED_BINS.map((bin) => [bin, commandExists(bin)]);
-const allBinsOk = binResults.every(([, ok]) => ok);
-const allSkillsOk = missingSkills.length === 0;
-const allClientsOk = clients.every(([, state]) => state.configured);
-const packageOk = packageJson?.name === '@fprad0/skill-master-mcp';
-
-console.log('Skill Master Doctor');
-console.log(`- Root: ${rootDir}`);
-console.log(`- Package: ${packageJson?.name ?? 'unknown'}@${packageJson?.version ?? 'unknown'}`);
-console.log('');
-
-console.log(resultLine(packageOk, 'Pacote local reconhecido', packageOk ? packageJson.version : 'package.json inesperado'));
-console.log(resultLine(allBinsOk, 'Binarios globais no PATH', binResults.filter(([, ok]) => !ok).map(([bin]) => bin).join(', ') || 'todos encontrados'));
-for (const [bin, ok] of binResults) {
-  console.log(`  ${resultLine(ok, bin)}`);
-}
-
-console.log('');
-console.log(resultLine(allSkillsOk, `Skills globais ${installedSkills.length}/${REQUIRED_GLOBAL_SKILLS.length}`, missingSkills.join(', ') || 'todas instaladas'));
-console.log(`- Skills root: ${globalSkillsRoot}`);
-
-console.log('');
-for (const [name, state] of clients) {
-  const label = state.optionalMissing ? `${name} opcional` : `${name} configurado`;
-  const detail = state.configured
-    ? state.optionalMissing
-      ? `CLI nao encontrado; pule se voce nao usa Claude Code neste computador`
-      : `${state.mode} em ${state.filePath}`
-    : state.present
-      ? `presente, mas mode=${state.mode} command=${state.command ?? 'nao encontrado'} em ${state.filePath}`
-      : `ausente em ${state.filePath}`;
-  console.log(resultLine(state.configured, label, detail));
-}
-
-const ready = packageOk && allBinsOk && allSkillsOk && allClientsOk;
-console.log('');
-console.log(resultLine(ready, 'Readiness global', ready ? 'pronto' : 'requer acao'));
-
-if (!ready) {
-  console.log('');
-  console.log('Proximo comando recomendado:');
-  console.log('  skill-master-register-clients --apply-all --force');
-  console.log('  skill-master-register-clients --apply-claude-code --claude-code-scope user');
-  console.log('  skill-master-menu --run bootstrap-global --yes');
-  console.log('');
-  console.log('Depois reinicie Codex, Claude Desktop, Claude Code, Gemini e Antigravity.');
-}
-
-if (has('--strict') && !ready) {
-  process.exitCode = 1;
-}
+#!/usr/bin/env node
+import { existsSync, readFileSync } from 'node:fs';
+import os from 'node:os';
+import path from 'node:path';
+import process from 'node:process';
+import { fileURLToPath } from 'node:url';
+import {
+  assessCodexConfigContent,
+  assessMcpServerConfig,
+  defaultClientConfigPaths,
+} from './lib/client-config.mjs';
+import { diagnoseReadiness, recommendedActionsForDiagnosis } from './lib/doctor-core.mjs';
+import { resolveClaudeCodeCommand, runCapturedCommand } from './lib/register-clients-core.mjs';
+
+const here = path.dirname(fileURLToPath(import.meta.url));
+const rootDir = path.resolve(here, '..');
+const args = process.argv.slice(2);
+const has = (flag) => args.includes(flag);
+
+if (has('--help') || has('-h')) {
+  console.log(`Skill Master Doctor
+
+Uso:
+  skill-master-doctor
+  skill-master-doctor --strict
+
+Valida pacote, binarios, skills globais e registro MCP em Codex, Claude,
+Claude Code, Gemini e Antigravity. Nao publica versoes e nao altera configuracoes.
+
+O registro recomendado usa Node absoluto + bin/skill-master.mjs absoluto para
+evitar falhas de PATH em apps desktop no Windows, Linux e macOS.
+`);
+  process.exit(0);
+}
+
+const REQUIRED_GLOBAL_SKILLS = [
+  'catholic-moral-discernment',
+  'ai-ethics-human-dignity',
+  'professional-boundary-triage',
+  'broad-domain-router',
+  'language-quality-pt-en-fr',
+  'math-science-reasoning',
+  'philosophy-sociology-discernment',
+  'engineering-systems-master',
+  'source-authority-reviewer',
+  'release-ethics-gate',
+  'mcp-client-readiness',
+  'terminal-menu-operations',
+  'terminal-pixel-art-tui',
+  'senior-master-code-optimizer',
+  'typescript-senior-master-engineering',
+  'python-senior-master-engineering',
+  'javascript-senior-master-engineering',
+  'go-senior-master-engineering',
+  'sql-senior-master-engineering',
+  'json-senior-master-engineering',
+  'ruby-senior-master-engineering',
+  'react-senior-master-engineering',
+  'html-senior-master-engineering',
+  'css-senior-master-engineering',
+  'csharp-senior-master-engineering',
+];
+
+const REQUIRED_BINS = [
+  'skill-master-menu',
+  'skill-master-mcp',
+  'skill-master-update',
+  'skill-master-bootstrap-global',
+  'skill-master-install-global-skills',
+  'skill-master-install-project-skills',
+  'skill-master-register-clients',
+  'skill-master-doctor',
+];
+
+function readJson(filePath) {
+  if (!existsSync(filePath)) return { present: false, invalid: false, value: null };
+  try {
+    const raw = readFileSync(filePath, 'utf8').trim();
+    return { present: true, invalid: false, value: raw ? JSON.parse(raw) : {} };
+  } catch {
+    return { present: true, invalid: true, value: null };
+  }
+}
+
+function commandExists(command) {
+  const lookup = process.platform === 'win32' ? 'where' : 'which';
+  const result = runCapturedCommand(lookup, [command]);
+  return result.status === 0;
+}
+
+function claudeCodeState() {
+  const resolved = resolveClaudeCodeCommand('claude', {
+    platform: process.platform,
+  });
+
+  if (!resolved.found || !resolved.command) {
+    return {
+      filePath: 'claude CLI',
+      present: false,
+      configured: false,
+      optionalMissing: true,
+      mode: 'cli-missing',
+      command: null,
+    };
+  }
+
+  const result = runCapturedCommand(resolved.command, ['mcp', 'list'], {
+    env: process.env,
+  });
+  const output = `${result.stdout ?? ''}${result.stderr ?? ''}`;
+  const configured = /skill[-_]master/i.test(output);
+
+  return {
+    filePath: resolved.command,
+    present: true,
+    configured,
+    mode: configured ? 'claude-cli' : result.status === 0 ? 'missing' : 'list-failed',
+    command: configured ? 'claude mcp list' : output.trim() || null,
+  };
+}
+
+function jsonClientState(filePath) {
+  const parsed = readJson(filePath);
+  if (parsed.invalid) {
+    return {
+      filePath,
+      present: true,
+      configured: false,
+      mode: 'invalid-json',
+      command: null,
+    };
+  }
+
+  const server = parsed.value?.mcpServers?.skill_master;
+  const assessment = assessMcpServerConfig(server);
+  return {
+    filePath,
+    present: parsed.present,
+    configured: assessment.robust,
+    mode: assessment.mode,
+    command: assessment.command,
+  };
+}
+
+function codexState(filePath) {
+  if (!existsSync(filePath)) {
+    return { filePath, present: false, configured: false, mode: 'missing', command: null };
+  }
+
+  const content = readFileSync(filePath, 'utf8');
+  const assessment = assessCodexConfigContent(content);
+  return {
+    filePath,
+    present: true,
+    configured: assessment.robust,
+    mode: assessment.mode,
+    command: assessment.command,
+  };
+}
+
+function resultLine(ok, label, detail) {
+  const marker = ok ? 'OK' : 'NO';
+  return `[${marker}] ${label}${detail ? ` - ${detail}` : ''}`;
+}
+
+const packageJsonState = readJson(path.join(rootDir, 'package.json'));
+const packageJson = packageJsonState.value;
+const globalSkillsRoot = path.join(process.env.CODEX_HOME ?? path.join(os.homedir(), '.codex'), 'skills');
+const installedSkills = REQUIRED_GLOBAL_SKILLS.filter((skill) => existsSync(path.join(globalSkillsRoot, skill, 'SKILL.md')));
+const missingSkills = REQUIRED_GLOBAL_SKILLS.filter((skill) => !installedSkills.includes(skill));
+
+const clientPaths = defaultClientConfigPaths();
+const clients = [
+  ['Codex', codexState(clientPaths.codex)],
+  ['Claude Desktop', jsonClientState(clientPaths.claude)],
+  ['Claude Code', claudeCodeState()],
+  ['Gemini CLI', jsonClientState(clientPaths.gemini)],
+  ['Antigravity', jsonClientState(clientPaths.antigravity)],
+];
+
+const binResults = REQUIRED_BINS.map((bin) => [bin, commandExists(bin)]);
+const allBinsOk = binResults.every(([, ok]) => ok);
+const allSkillsOk = missingSkills.length === 0;
+const packageOk = packageJson?.name === '@fprad0/skill-master-mcp';
+const diagnosis = diagnoseReadiness({
+  packageOk,
+  packageJson,
+  binResults,
+  missingSkills,
+  clients,
+});
+const recommendedActions = recommendedActionsForDiagnosis(diagnosis, clients);
+
+console.log('Skill Master Doctor');
+console.log(`- Root: ${rootDir}`);
+console.log(`- Package: ${packageJson?.name ?? 'unknown'}@${packageJson?.version ?? 'unknown'}`);
+console.log('');
+
+console.log(resultLine(packageOk, 'Pacote local reconhecido', packageOk ? packageJson.version : 'package.json inesperado'));
+console.log(resultLine(allBinsOk, 'Binarios globais no PATH', binResults.filter(([, ok]) => !ok).map(([bin]) => bin).join(', ') || 'todos encontrados'));
+for (const [bin, ok] of binResults) {
+  console.log(`  ${resultLine(ok, bin)}`);
+}
+
+console.log('');
+console.log(resultLine(allSkillsOk, `Skills globais ${installedSkills.length}/${REQUIRED_GLOBAL_SKILLS.length}`, missingSkills.join(', ') || 'todas instaladas'));
+console.log(`- Skills root: ${globalSkillsRoot}`);
+
+console.log('');
+for (const [name, state] of clients) {
+  const label = state.optionalMissing ? `${name} opcional` : `${name} configurado`;
+  const detail = state.configured
+    ? state.optionalMissing
+      ? `CLI nao encontrado; pule se voce nao usa Claude Code neste computador`
+      : `${state.mode} em ${state.filePath}`
+    : state.present
+      ? `presente, mas mode=${state.mode} command=${state.command ?? 'nao encontrado'} em ${state.filePath}`
+      : `ausente em ${state.filePath}`;
+  console.log(resultLine(state.configured, label, detail));
+}
+
+console.log('');
+console.log(resultLine(diagnosis.ready, 'Readiness global', diagnosis.ready ? 'pronto' : diagnosis.mode));
+
+if (!diagnosis.ready) {
+  console.log('');
+  console.log(`Falha dominante: ${diagnosis.dominantFailure}`);
+  console.log('');
+  console.log('Proximo comando recomendado:');
+  for (const action of recommendedActions) {
+    console.log(`  ${action}`);
+  }
+  console.log('');
+  console.log('Depois reinicie Codex, Claude Desktop, Claude Code, Gemini e Antigravity quando aplicar a correcao recomendada.');
+}
+
+if (has('--strict') && !diagnosis.ready) {
+  process.exitCode = 1;
+}

package/bin/skill-master-eval-activation.mjs

@@ -1,32 +1,32 @@
-#!/usr/bin/env node
-
-import { runActivationEvals } from '../dist/activation-evals.js';
-
-const report = runActivationEvals();
-const asJson = process.argv.includes('--json');
-
-if (asJson) {
-  console.log(JSON.stringify(report, null, 2));
-} else {
-  console.log('Skill Master Activation Evals');
-  console.log(`- Generated at: ${report.generatedAt}`);
-  console.log(`- Total: ${report.total}`);
-  console.log(`- Passed: ${report.passed}`);
-  console.log(`- Failed: ${report.failed}`);
-  console.log(`- Accuracy: ${(report.accuracy * 100).toFixed(1)}%`);
-  console.log(`- False positives: ${report.falsePositives}`);
-  console.log(`- False negatives: ${report.falseNegatives}`);
-  console.log(`- Correct blocks: ${report.correctBlocks}`);
-  console.log(`- Recommendation: ${report.recommendation}`);
-
-  const failed = report.results.filter((result) => !result.passed);
-  if (failed.length > 0) {
-    console.log('');
-    console.log('Failed cases:');
-    for (const result of failed) {
-      console.log(`- ${result.case.id}: ${result.findings.join('; ')}`);
-    }
-  }
-}
-
-process.exitCode = report.recommendation === 'balanced-ready' ? 0 : 1;
+#!/usr/bin/env node
+
+import { runActivationEvals } from '../dist/activation-evals.js';
+
+const report = runActivationEvals();
+const asJson = process.argv.includes('--json');
+
+if (asJson) {
+  console.log(JSON.stringify(report, null, 2));
+} else {
+  console.log('Skill Master Activation Evals');
+  console.log(`- Generated at: ${report.generatedAt}`);
+  console.log(`- Total: ${report.total}`);
+  console.log(`- Passed: ${report.passed}`);
+  console.log(`- Failed: ${report.failed}`);
+  console.log(`- Accuracy: ${(report.accuracy * 100).toFixed(1)}%`);
+  console.log(`- False positives: ${report.falsePositives}`);
+  console.log(`- False negatives: ${report.falseNegatives}`);
+  console.log(`- Correct blocks: ${report.correctBlocks}`);
+  console.log(`- Recommendation: ${report.recommendation}`);
+
+  const failed = report.results.filter((result) => !result.passed);
+  if (failed.length > 0) {
+    console.log('');
+    console.log('Failed cases:');
+    for (const result of failed) {
+      console.log(`- ${result.case.id}: ${result.findings.join('; ')}`);
+    }
+  }
+}
+
+process.exitCode = report.recommendation === 'balanced-ready' ? 0 : 1;