@fprad0/skill-master-mcp 0.0.12 → 1.0.1

package/scripts/verify-menu-actions.mjs

@@ -1,117 +1,122 @@
-#!/usr/bin/env node
-
-import { dirname, join } from 'node:path';
-import { fileURLToPath } from 'node:url';
-import {
-  buildMenuCommands,
-  resolveActionKey,
-} from '../bin/lib/menu-core.mjs';
-
-const here = dirname(fileURLToPath(import.meta.url));
-const rootDir = dirname(here);
-const currentFile = join(rootDir, 'bin', 'skill-master-menu.mjs');
-
-const REQUIRED_ACTIONS = [
-  'status',
-  'doctor',
-  'check',
-  'build',
-  'publicNpm',
-  'updateGlobal',
-  'privateRegistry',
+#!/usr/bin/env node
+
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
+import {
+  buildMenuCommands,
+  resolveActionKey,
+} from '../bin/lib/menu-core.mjs';
+
+const here = dirname(fileURLToPath(import.meta.url));
+const rootDir = dirname(here);
+const currentFile = join(rootDir, 'bin', 'skill-master-menu.mjs');
+
+const REQUIRED_ACTIONS = [
+  'status',
+  'doctor',
+  'check',
+  'build',
+  'publicNpm',
+  'updateGlobal',
+  'privateRegistry',
+  'activationStatus',
+  'activationBalanced',
+  'activationAlwaysOn',
+  'installGlobalSkills',
+  'installProjectSkills',
+  'bootstrapGlobal',
+  'registerClients',
+  'promptRecommendation',
+  'successNotifications',
+  'studySkills',
+  'approvalPackage',
+  'markLearnedStudy',
+  'rejectLearnedSkill',
+  'activateLearnedLocal',
+  'activateLearnedGlobal',
+  'notionSummary',
+];
+
+const CONFIRMATION_REQUIRED = [
+  'updateGlobal',
+  'privateRegistry',
+  'activationAlwaysOn',
+  'installGlobalSkills',
+  'installProjectSkills',
+  'bootstrapGlobal',
+  'registerClients',
+  'rejectLearnedSkill',
+  'activateLearnedLocal',
+  'activateLearnedGlobal',
+];
+
+const READ_ONLY_ACTIONS = [
+  'status',
+  'doctor',
+  'publicNpm',
   'activationStatus',
-  'activationBalanced',
-  'activationAlwaysOn',
-  'installGlobalSkills',
-  'installProjectSkills',
-  'bootstrapGlobal',
-  'registerClients',
-  'promptRecommendation',
   'successNotifications',
   'studySkills',
-  'approvalPackage',
-  'markLearnedStudy',
-  'rejectLearnedSkill',
-  'activateLearnedLocal',
-  'activateLearnedGlobal',
   'notionSummary',
 ];
 
-const CONFIRMATION_REQUIRED = [
-  'updateGlobal',
-  'privateRegistry',
-  'activationAlwaysOn',
-  'installGlobalSkills',
-  'installProjectSkills',
-  'bootstrapGlobal',
-  'registerClients',
-  'rejectLearnedSkill',
-  'activateLearnedLocal',
-  'activateLearnedGlobal',
-];
-
-const READ_ONLY_ACTIONS = [
-  'status',
-  'doctor',
-  'publicNpm',
-  'activationStatus',
-  'successNotifications',
-  'studySkills',
+const WRITES_LOCAL_ACTIONS = [
   'approvalPackage',
-  'notionSummary',
+  'activateLearnedLocal',
 ];
-
-const commands = buildMenuCommands({
-  rootDir,
-  currentFile,
-  nodeExecPath: process.execPath,
-});
-
-const byKey = new Map(commands.map((command) => [command.key, command]));
-const failures = [];
-
-for (const key of REQUIRED_ACTIONS) {
-  if (!byKey.has(key)) failures.push(`missing action: ${key}`);
-}
-
-for (const key of CONFIRMATION_REQUIRED) {
-  const command = byKey.get(key);
-  if (command && !command.confirmMessage) failures.push(`missing confirmation: ${key}`);
-}
-
-for (const command of commands) {
-  if (!command.command) failures.push(`missing command executable: ${command.key}`);
-  if (!Array.isArray(command.args)) failures.push(`args must be array: ${command.key}`);
-  for (const alias of command.aliases ?? []) {
-    if (resolveActionKey(alias, commands) !== command.key) failures.push(`alias does not resolve: ${command.key}:${alias}`);
-  }
-}
-
-for (const key of READ_ONLY_ACTIONS) {
-  const command = byKey.get(key);
-  if (!command) continue;
-  if (command.confirmMessage) failures.push(`read-only action unexpectedly asks confirmation: ${key}`);
-}
-
-console.log('Skill Master menu action verification');
-console.log(`- Actions: ${commands.length}`);
-console.log(`- Required actions: ${REQUIRED_ACTIONS.length}`);
+
+const commands = buildMenuCommands({
+  rootDir,
+  currentFile,
+  nodeExecPath: process.execPath,
+});
+
+const byKey = new Map(commands.map((command) => [command.key, command]));
+const failures = [];
+
+for (const key of REQUIRED_ACTIONS) {
+  if (!byKey.has(key)) failures.push(`missing action: ${key}`);
+}
+
+for (const key of CONFIRMATION_REQUIRED) {
+  const command = byKey.get(key);
+  if (command && !command.confirmMessage) failures.push(`missing confirmation: ${key}`);
+}
+
+for (const command of commands) {
+  if (!command.command) failures.push(`missing command executable: ${command.key}`);
+  if (!Array.isArray(command.args)) failures.push(`args must be array: ${command.key}`);
+  for (const alias of command.aliases ?? []) {
+    if (resolveActionKey(alias, commands) !== command.key) failures.push(`alias does not resolve: ${command.key}:${alias}`);
+  }
+}
+
+for (const key of READ_ONLY_ACTIONS) {
+  const command = byKey.get(key);
+  if (!command) continue;
+  if (command.confirmMessage) failures.push(`read-only action unexpectedly asks confirmation: ${key}`);
+}
+
+console.log('Skill Master menu action verification');
+console.log(`- Actions: ${commands.length}`);
+console.log(`- Required actions: ${REQUIRED_ACTIONS.length}`);
 console.log(`- Read-only smoke candidates: ${READ_ONLY_ACTIONS.join(', ')}`);
+console.log(`- Local write actions: ${WRITES_LOCAL_ACTIONS.join(', ')}`);
 console.log(`- Confirmation protected: ${CONFIRMATION_REQUIRED.join(', ')}`);
-console.log('');
-
-for (const command of commands) {
-  const protection = command.confirmMessage ? 'confirm' : 'direct';
-  const disabled = command.disabledReason ? 'disabled' : 'enabled';
-  console.log(`- ${command.key}: ${disabled}, ${protection}, aliases=${command.aliases.join('|') || '-'}`);
-}
-
-if (failures.length) {
-  console.log('');
-  console.log('Failures:');
-  for (const failure of failures) console.log(`- ${failure}`);
-  process.exitCode = 1;
-} else {
-  console.log('');
-  console.log('Menu action matrix OK.');
-}
+console.log('');
+
+for (const command of commands) {
+  const protection = command.confirmMessage ? 'confirm' : 'direct';
+  const disabled = command.disabledReason ? 'disabled' : 'enabled';
+  console.log(`- ${command.key}: ${disabled}, ${protection}, aliases=${command.aliases.join('|') || '-'}`);
+}
+
+if (failures.length) {
+  console.log('');
+  console.log('Failures:');
+  for (const failure of failures) console.log(`- ${failure}`);
+  process.exitCode = 1;
+} else {
+  console.log('');
+  console.log('Menu action matrix OK.');
+}

package/scripts/verify-menu-visual.mjs

@@ -0,0 +1,90 @@
+#!/usr/bin/env node
+
+import { readFileSync } from 'node:fs';
+import { dirname, join, resolve } from 'node:path';
+import { fileURLToPath } from 'node:url';
+import {
+  buildMenuCommands,
+  formatCyberMenuFrame,
+  formatRunningActionFrame,
+  formatSkillMasterDnaHeroFrame,
+  getMenuStatus,
+} from '../bin/lib/menu-core.mjs';
+
+const here = dirname(fileURLToPath(import.meta.url));
+const rootDir = resolve(here, '..');
+const packageJson = JSON.parse(readFileSync(join(rootDir, 'package.json'), 'utf8'));
+const commands = buildMenuCommands({
+  rootDir,
+  currentFile: join(rootDir, 'bin', 'skill-master-menu.mjs'),
+  nodeExecPath: process.execPath,
+});
+const liveStatus = getMenuStatus(rootDir);
+const status = {
+  ...liveStatus,
+  semver: packageJson.version,
+  manifestSemver: packageJson.version,
+  versionText: '',
+  globalReadiness: {
+    ...liveStatus.globalReadiness,
+    ready: true,
+    mode: 'ready',
+    missing: [],
+    installed: Array.from(
+      { length: liveStatus.globalReadiness.required },
+      (_, index) => liveStatus.globalReadiness.installed[index] ?? `skill-${index + 1}`,
+    ),
+    codex: { present: true, kind: 'absolute-node', globalCommand: true },
+    claude: { present: true, kind: 'absolute-node', globalCommand: true },
+    gemini: { present: true, kind: 'absolute-node', globalCommand: true },
+    antigravity: { present: true, kind: 'absolute-node', globalCommand: true },
+  },
+};
+
+function stripAnsi(text) {
+  return String(text).replace(/\x1b\[[0-9;?]*[ -/]*[@-~]/g, '');
+}
+
+function assert(condition, message) {
+  if (!condition) throw new Error(message);
+}
+
+function assertMaxWidth(frame, width, label) {
+  for (const [index, line] of stripAnsi(frame).split('\n').entries()) {
+    assert(line.length <= width, `${label} line ${index + 1} exceeds ${width}: ${line.length}`);
+  }
+}
+
+function assertNoHeavyUnicode(frame, label) {
+  const plain = stripAnsi(frame);
+  assert(!/[┏┓┗┛╭╮╰╯╔╗╚╝┌┐└┘╾╼╴╶─═╍│▌▐▰▱█░▁▂▃▄▅▆▇·◢\u2800-\u28ff]/u.test(plain), `${label} contains premium Unicode in ASCII mode`);
+}
+
+const large = formatCyberMenuFrame(status, commands, 1, 8, { columns: 120, rows: 32, useColor: false });
+const compact = formatCyberMenuFrame(status, commands, 20, 8, { columns: 96, rows: 24, useColor: false });
+const running = formatRunningActionFrame(status, commands.find((command) => command.key === 'doctor'), 5, { columns: 120, rows: 28, useColor: false });
+const hero = formatSkillMasterDnaHeroFrame(status, 5, { columns: 120, rows: 32, useColor: false });
+const ascii = formatCyberMenuFrame(status, commands, 1, 8, { columns: 96, rows: 24, useColor: false, ascii: true });
+
+assertMaxWidth(large, 120, 'large');
+assertMaxWidth(compact, 96, 'compact');
+assertMaxWidth(running, 120, 'running');
+assertMaxWidth(hero, 120, 'dna-hero');
+assertMaxWidth(ascii, 96, 'ascii');
+
+assert(large.includes('DNA CYBER HELIX'), 'large frame missing DNA CYBER HELIX');
+assert(large.includes('luminous fine helix'), 'large frame missing fine helix subtitle');
+assert(hero.includes('SKILL_MASTER DNA ONLINE'), 'hero frame missing online title');
+assert(hero.includes('DNA'), 'hero frame missing DNA label');
+assert(hero.includes('ONLINE'), 'hero frame missing ONLINE state');
+assert(compact.includes('DETAIL FOCUS'), 'compact frame missing details panel');
+assert(compact.includes('DNA-CORE'), 'compact frame missing DNA panel');
+assert(running.includes('SKILL_MASTER WORKFLOW ONLINE'), 'running frame missing running title');
+assertNoHeavyUnicode(ascii, 'ascii frame');
+
+for (const frame of [large, compact, running, hero, ascii]) {
+  assert(!frame.includes('0.0.12'), 'visual frame contains stale 0.0.12 version');
+  assert(!frame.includes('stable frame'), 'visual frame leaked old stable frame text');
+}
+
+console.log('verify-menu-visual: ok');

package/sources.json

@@ -1,11 +1,11 @@
-{
-  "localRoots": [
-    "%USERPROFILE%/.codex/skills",
-    "%USERPROFILE%/.agents/skills"
-  ],
-  "workspaceRoots": [
-    ".codex/skills",
-    ".agents/skills"
-  ],
-  "webSources": []
-}
+{
+  "localRoots": [
+    "%USERPROFILE%/.codex/skills",
+    "%USERPROFILE%/.agents/skills"
+  ],
+  "workspaceRoots": [
+    ".codex/skills",
+    ".agents/skills"
+  ],
+  "webSources": []
+}