@forwardimpact/pathway 0.25.15 → 0.25.21

package/src/formatters/level/dom.js

@@ -35,14 +35,98 @@ import { createJsonLdScript, levelToJsonLd } from "../json-ld.js";
  * @param {boolean} [options.showBackLink=true] - Whether to show back navigation link
  * @returns {HTMLElement}
  */
+/**
+ * Create a proficiency row for the base skill table
+ * @param {string} label
+ * @param {string} badgeClass
+ * @param {string|undefined} proficiency
+ * @returns {HTMLElement}
+ */
+function createProficiencyRow(label, badgeClass, proficiency) {
+  return tr(
+    {},
+    td({}, span({ className: `badge ${badgeClass}` }, label)),
+    td(
+      {},
+      proficiency
+        ? createLevelDots(
+            SKILL_PROFICIENCY_ORDER.indexOf(proficiency),
+            SKILL_PROFICIENCY_ORDER.length,
+          )
+        : span({ className: "text-muted" }, "—"),
+    ),
+  );
+}
+
+/**
+ * Create the base skill proficiencies and behaviour maturity section
+ * @param {Object} view
+ * @returns {HTMLElement}
+ */
+function createBaseProfileSection(view) {
+  const profs = view.baseSkillProficiencies || {};
+  return div(
+    { className: "detail-section" },
+    div(
+      { className: "content-columns" },
+      div(
+        { className: "column" },
+        heading2({ className: "section-title" }, "Base Skill Proficiencies"),
+        table(
+          { className: "level-table" },
+          thead({}, tr({}, th({}, "Type"), th({}, "Level"))),
+          tbody(
+            {},
+            createProficiencyRow("Primary", "badge-primary", profs.primary),
+            createProficiencyRow(
+              "Secondary",
+              "badge-secondary",
+              profs.secondary,
+            ),
+            createProficiencyRow("Broad", "badge-broad", profs.broad),
+          ),
+        ),
+      ),
+      div(
+        { className: "column" },
+        heading2({ className: "section-title" }, "Base Behaviour Maturity"),
+        view.baseBehaviourMaturity
+          ? table(
+              { className: "level-table" },
+              thead({}, tr({}, th({}, "Maturity"), th({}, "Level"))),
+              tbody(
+                {},
+                tr(
+                  {},
+                  td(
+                    {},
+                    view.baseBehaviourMaturity.charAt(0).toUpperCase() +
+                      view.baseBehaviourMaturity.slice(1),
+                  ),
+                  td(
+                    {},
+                    createLevelDots(
+                      BEHAVIOUR_MATURITY_ORDER.indexOf(
+                        view.baseBehaviourMaturity,
+                      ),
+                      BEHAVIOUR_MATURITY_ORDER.length,
+                    ),
+                  ),
+                ),
+              ),
+            )
+          : p({ className: "text-muted" }, "—"),
+      ),
+    ),
+  );
+}
+
 export function levelToDOM(level, { framework, showBackLink = true } = {}) {
   const view = prepareLevelDetail(level);
   const emoji = framework ? getConceptEmoji(framework, "level") : "📊";
   return div(
     { className: "detail-page level-detail" },
-    // JSON-LD structured data
     createJsonLdScript(levelToJsonLd(level)),
-    // Header
     div(
       { className: "page-header" },
       showBackLink ? createBackLink("/level", "← Back to Levels") : null,
@@ -68,7 +152,6 @@ export function levelToDOM(level, { framework, showBackLink = true } = {}) {
         : null,
     ),
 
-    // Titles section
     view.professionalTitle || view.managementTitle
       ? div(
           { className: "detail-section" },
@@ -93,7 +176,6 @@ export function levelToDOM(level, { framework, showBackLink = true } = {}) {
         )
       : null,
 
-    // Expectations
     view.expectations && Object.keys(view.expectations).length > 0
       ? div(
           { className: "detail-section" },
@@ -111,103 +193,6 @@ export function levelToDOM(level, { framework, showBackLink = true } = {}) {
         )
       : null,
 
-    // Base Skill Proficiencies and Base Behaviour Maturity in two columns
-    div(
-      { className: "detail-section" },
-      div(
-        { className: "content-columns" },
-        // Base Skill Proficiencies column
-        div(
-          { className: "column" },
-          heading2({ className: "section-title" }, "Base Skill Proficiencies"),
-          table(
-            { className: "level-table" },
-            thead({}, tr({}, th({}, "Type"), th({}, "Level"))),
-            tbody(
-              {},
-              tr(
-                {},
-                td({}, span({ className: "badge badge-primary" }, "Primary")),
-                td(
-                  {},
-                  view.baseSkillProficiencies?.primary
-                    ? createLevelDots(
-                        SKILL_PROFICIENCY_ORDER.indexOf(
-                          view.baseSkillProficiencies.primary,
-                        ),
-                        SKILL_PROFICIENCY_ORDER.length,
-                      )
-                    : span({ className: "text-muted" }, "—"),
-                ),
-              ),
-              tr(
-                {},
-                td(
-                  {},
-                  span({ className: "badge badge-secondary" }, "Secondary"),
-                ),
-                td(
-                  {},
-                  view.baseSkillProficiencies?.secondary
-                    ? createLevelDots(
-                        SKILL_PROFICIENCY_ORDER.indexOf(
-                          view.baseSkillProficiencies.secondary,
-                        ),
-                        SKILL_PROFICIENCY_ORDER.length,
-                      )
-                    : span({ className: "text-muted" }, "—"),
-                ),
-              ),
-              tr(
-                {},
-                td({}, span({ className: "badge badge-broad" }, "Broad")),
-                td(
-                  {},
-                  view.baseSkillProficiencies?.broad
-                    ? createLevelDots(
-                        SKILL_PROFICIENCY_ORDER.indexOf(
-                          view.baseSkillProficiencies.broad,
-                        ),
-                        SKILL_PROFICIENCY_ORDER.length,
-                      )
-                    : span({ className: "text-muted" }, "—"),
-                ),
-              ),
-            ),
-          ),
-        ),
-        // Base Behaviour Maturity column
-        div(
-          { className: "column" },
-          heading2({ className: "section-title" }, "Base Behaviour Maturity"),
-          view.baseBehaviourMaturity
-            ? table(
-                { className: "level-table" },
-                thead({}, tr({}, th({}, "Maturity"), th({}, "Level"))),
-                tbody(
-                  {},
-                  tr(
-                    {},
-                    td(
-                      {},
-                      view.baseBehaviourMaturity.charAt(0).toUpperCase() +
-                        view.baseBehaviourMaturity.slice(1),
-                    ),
-                    td(
-                      {},
-                      createLevelDots(
-                        BEHAVIOUR_MATURITY_ORDER.indexOf(
-                          view.baseBehaviourMaturity,
-                        ),
-                        BEHAVIOUR_MATURITY_ORDER.length,
-                      ),
-                    ),
-                  ),
-                ),
-              )
-            : p({ className: "text-muted" }, "—"),
-        ),
-      ),
-    ),
+    createBaseProfileSection(view),
   );
 }

package/src/formatters/questions/markdown.js

@@ -223,10 +223,43 @@ function formatTable(view) {
 }
 
 /**
- * Format single source deep dive
- * @param {Object} view - Questions view
- * @returns {string}
+ * Format a single question's detail lines
+ * @param {string[]} lines
+ * @param {Object} q - Flattened question
  */
+function formatQuestionDetail(lines, q) {
+  lines.push(`  • [${q.id}] ${q.text}`);
+  lines.push(`    Duration: ${q.expectedDurationMinutes} min`);
+  if (q.context) {
+    lines.push(`    Context: ${q.context}`);
+  }
+  if (q.simulationPrompts && q.simulationPrompts.length > 0) {
+    lines.push("    Steer the simulation:");
+    for (const prompt of q.simulationPrompts) {
+      lines.push(`      - ${prompt}`);
+    }
+  }
+  if (q.decompositionPrompts && q.decompositionPrompts.length > 0) {
+    lines.push("    Guide candidate thinking:");
+    for (const prompt of q.decompositionPrompts) {
+      lines.push(`      - ${prompt}`);
+    }
+  }
+  if (q.lookingFor.length > 0) {
+    lines.push("    Looking for:");
+    for (const item of q.lookingFor) {
+      lines.push(`      - ${item}`);
+    }
+  }
+  if (q.followUps.length > 0) {
+    lines.push("    Follow-ups:");
+    for (const fu of q.followUps) {
+      lines.push(`      → ${fu}`);
+    }
+  }
+  lines.push("");
+}
+
 function formatSingleSource(view) {
   const lines = [];
   const { questions, stats } = view;
@@ -259,36 +292,7 @@ function formatSingleSource(view) {
 
     lines.push(level.toUpperCase());
     for (const q of byLevel[level]) {
-      lines.push(`  • [${q.id}] ${q.text}`);
-      lines.push(`    Duration: ${q.expectedDurationMinutes} min`);
-      if (q.context) {
-        lines.push(`    Context: ${q.context}`);
-      }
-      if (q.simulationPrompts && q.simulationPrompts.length > 0) {
-        lines.push("    Steer the simulation:");
-        for (const prompt of q.simulationPrompts) {
-          lines.push(`      - ${prompt}`);
-        }
-      }
-      if (q.decompositionPrompts && q.decompositionPrompts.length > 0) {
-        lines.push("    Guide candidate thinking:");
-        for (const prompt of q.decompositionPrompts) {
-          lines.push(`      - ${prompt}`);
-        }
-      }
-      if (q.lookingFor.length > 0) {
-        lines.push("    Looking for:");
-        for (const item of q.lookingFor) {
-          lines.push(`      - ${item}`);
-        }
-      }
-      if (q.followUps.length > 0) {
-        lines.push("    Follow-ups:");
-        for (const fu of q.followUps) {
-          lines.push(`      → ${fu}`);
-        }
-      }
-      lines.push("");
+      formatQuestionDetail(lines, q);
     }
   }
 

package/src/formatters/questions/shared.js

@@ -111,6 +111,119 @@ function getSkillCapability(skillId, skills) {
  */
 const ROLE_TYPES = ["professionalQuestions", "managementQuestions"];
 
+/**
+ * Check whether skill questions should be included given the current filter
+ * @param {string} skillId
+ * @param {Array} skills
+ * @param {QuestionsFilter} filter
+ * @returns {boolean}
+ */
+function shouldIncludeSkill(skillId, skills, filter) {
+  if (filter.skills && !filter.skills.includes(skillId)) return false;
+  if (filter.behaviours) return false;
+  if (filter.maturity) return false;
+  if (filter.capability) {
+    const capability = getSkillCapability(skillId, skills);
+    if (capability !== filter.capability) return false;
+  }
+  return true;
+}
+
+/**
+ * Check whether behaviour questions should be included given the current filter
+ * @param {string} behaviourId
+ * @param {QuestionsFilter} filter
+ * @returns {boolean}
+ */
+function shouldIncludeBehaviour(behaviourId, filter) {
+  if (filter.behaviours && !filter.behaviours.includes(behaviourId))
+    return false;
+  if (filter.capability) return false;
+  if (filter.skills) return false;
+  if (filter.level) return false;
+  return true;
+}
+
+/**
+ * Flatten skill questions from a single skill entry
+ * @param {string} skillId
+ * @param {Object} roleTypes
+ * @param {Array} skills
+ * @param {QuestionsFilter} filter
+ * @param {FlattenedQuestion[]} out
+ */
+function flattenSkillQuestions(skillId, roleTypes, skills, filter, out) {
+  const skillName = getSkillName(skillId, skills);
+
+  for (const roleType of ROLE_TYPES) {
+    const levels = roleTypes[roleType];
+    if (!levels) continue;
+
+    for (const [level, levelQuestions] of Object.entries(levels)) {
+      if (filter.level && level !== filter.level) continue;
+
+      for (const q of levelQuestions) {
+        out.push({
+          source: skillId,
+          sourceName: skillName,
+          sourceType: "skill",
+          level,
+          id: q.id,
+          text: q.text,
+          lookingFor: q.lookingFor || [],
+          expectedDurationMinutes: q.expectedDurationMinutes || 5,
+          followUps: q.followUps || [],
+          context: q.context || null,
+          decompositionPrompts: q.decompositionPrompts || [],
+        });
+      }
+    }
+  }
+}
+
+/**
+ * Flatten behaviour questions from a single behaviour entry
+ * @param {string} behaviourId
+ * @param {Object} roleTypes
+ * @param {Array} behaviours
+ * @param {QuestionsFilter} filter
+ * @param {FlattenedQuestion[]} out
+ */
+function flattenBehaviourQuestions(
+  behaviourId,
+  roleTypes,
+  behaviours,
+  filter,
+  out,
+) {
+  const behaviourName = getBehaviourName(behaviourId, behaviours);
+
+  for (const roleType of ROLE_TYPES) {
+    const maturities = roleTypes[roleType];
+    if (!maturities) continue;
+
+    for (const [maturity, maturityQuestions] of Object.entries(maturities)) {
+      if (filter.maturity && maturity !== filter.maturity) continue;
+
+      for (const q of maturityQuestions) {
+        out.push({
+          source: behaviourId,
+          sourceName: behaviourName,
+          sourceType: "behaviour",
+          level: maturity,
+          id: q.id,
+          text: q.text,
+          lookingFor: q.lookingFor || [],
+          expectedDurationMinutes: q.expectedDurationMinutes || 5,
+          followUps: q.followUps || [],
+          context: q.context || null,
+          simulationPrompts: q.simulationPrompts || [],
+        });
+      }
+    }
+  }
+}
+
 /**
  * Flatten all questions from question bank
  * @param {Object} questionBank
@@ -122,84 +235,43 @@ const ROLE_TYPES = ["professionalQuestions", "managementQuestions"];
 export function flattenQuestions(questionBank, skills, behaviours, filter) {
   const questions = [];
 
-  // Process skill questions
   for (const [skillId, roleTypes] of Object.entries(
     questionBank.skillProficiencies || {},
   )) {
-    const skillName = getSkillName(skillId, skills);
-    const capability = getSkillCapability(skillId, skills);
-
-    if (filter.skills && !filter.skills.includes(skillId)) continue;
-    if (filter.behaviours) continue;
-    if (filter.capability && capability !== filter.capability) continue;
-    if (filter.maturity) continue;
-
-    for (const roleType of ROLE_TYPES) {
-      const levels = roleTypes[roleType];
-      if (!levels) continue;
-
-      for (const [level, levelQuestions] of Object.entries(levels)) {
-        if (filter.level && level !== filter.level) continue;
-
-        for (const q of levelQuestions) {
-          questions.push({
-            source: skillId,
-            sourceName: skillName,
-            sourceType: "skill",
-            level,
-            id: q.id,
-            text: q.text,
-            lookingFor: q.lookingFor || [],
-            expectedDurationMinutes: q.expectedDurationMinutes || 5,
-            followUps: q.followUps || [],
-            context: q.context || null,
-            decompositionPrompts: q.decompositionPrompts || [],
-          });
-        }
-      }
-    }
+    if (!shouldIncludeSkill(skillId, skills, filter)) continue;
+    flattenSkillQuestions(skillId, roleTypes, skills, filter, questions);
   }
 
-  // Process behaviour questions
   for (const [behaviourId, roleTypes] of Object.entries(
     questionBank.behaviourMaturities || {},
   )) {
-    const behaviourName = getBehaviourName(behaviourId, behaviours);
-
-    if (filter.behaviours && !filter.behaviours.includes(behaviourId)) continue;
-    if (filter.capability) continue;
-    if (filter.skills) continue;
-    if (filter.level) continue;
-
-    for (const roleType of ROLE_TYPES) {
-      const maturities = roleTypes[roleType];
-      if (!maturities) continue;
-
-      for (const [maturity, maturityQuestions] of Object.entries(maturities)) {
-        if (filter.maturity && maturity !== filter.maturity) continue;
-
-        for (const q of maturityQuestions) {
-          questions.push({
-            source: behaviourId,
-            sourceName: behaviourName,
-            sourceType: "behaviour",
-            level: maturity,
-            id: q.id,
-            text: q.text,
-            lookingFor: q.lookingFor || [],
-            expectedDurationMinutes: q.expectedDurationMinutes || 5,
-            followUps: q.followUps || [],
-            context: q.context || null,
-            simulationPrompts: q.simulationPrompts || [],
-          });
-        }
-      }
-    }
+    if (!shouldIncludeBehaviour(behaviourId, filter)) continue;
+    flattenBehaviourQuestions(
+      behaviourId,
+      roleTypes,
+      behaviours,
+      filter,
+      questions,
+    );
   }
 
   return questions;
 }
 
+/**
+ * Count questions across role types for a given level/maturity
+ * @param {Object} roleTypes - Role type map
+ * @param {string} levelKey - Level or maturity key
+ * @returns {number}
+ */
+function countQuestionsForLevel(roleTypes, levelKey) {
+  let count = 0;
+  for (const roleType of ROLE_TYPES) {
+    count += (roleTypes[roleType]?.[levelKey] || []).length;
+  }
+  return count;
+}
+
 /**
  * Calculate question statistics
  * @param {FlattenedQuestion[]} questions
@@ -222,11 +294,7 @@ export function calculateStats(questions, questionBank) {
   )) {
     skillStats[skillId] = {};
     for (const level of SKILL_PROFICIENCIES) {
-      let count = 0;
-      for (const roleType of ROLE_TYPES) {
-        count += (roleTypes[roleType]?.[level] || []).length;
-      }
-      skillStats[skillId][level] = count;
+      skillStats[skillId][level] = countQuestionsForLevel(roleTypes, level);
     }
     skillStats[skillId].total = Object.values(skillStats[skillId]).reduce(
       (a, b) => a + b,
@@ -240,11 +308,10 @@ export function calculateStats(questions, questionBank) {
   )) {
     behaviourStats[behaviourId] = {};
     for (const maturity of BEHAVIOUR_MATURITIES) {
-      let count = 0;
-      for (const roleType of ROLE_TYPES) {
-        count += (roleTypes[roleType]?.[maturity] || []).length;
-      }
-      behaviourStats[behaviourId][maturity] = count;
+      behaviourStats[behaviourId][maturity] = countQuestionsForLevel(
+        roleTypes,
+        maturity,
+      );
     }
     behaviourStats[behaviourId].total = Object.values(
       behaviourStats[behaviourId],