@forwardimpact/pathway 0.25.15 → 0.25.21

package/src/formatters/interview/markdown.js

@@ -5,6 +5,91 @@
 import { formatLevel } from "../../lib/render.js";
 import { getConceptEmoji } from "@forwardimpact/map/levels";
 
+/**
+ * Append follow-ups to lines
+ * @param {string[]} lines
+ * @param {Object} q - Question object
+ */
+function appendFollowUps(lines, q) {
+  if (q.followUps.length > 0) {
+    lines.push("", "**Follow-ups:**");
+    for (const followUp of q.followUps) {
+      lines.push(`  → ${followUp}`);
+    }
+  }
+}
+
+/**
+ * Append looking-for items to lines
+ * @param {string[]} lines
+ * @param {Object} q - Question object
+ */
+function appendLookingFor(lines, q) {
+  if (q.lookingFor && q.lookingFor.length > 0) {
+    lines.push("", "**What to look for:**");
+    for (const item of q.lookingFor) {
+      lines.push(`- ${item}`);
+    }
+  }
+}
+
+/**
+ * Format skill question sections
+ * @param {string[]} lines
+ * @param {Array} sections
+ * @param {string} emoji
+ */
+function formatSkillSections(lines, sections, emoji) {
+  if (sections.length === 0) return;
+  lines.push(`## ${emoji} Skill Questions`, "");
+  for (const section of sections) {
+    lines.push(`### ${section.name} (${formatLevel(section.level)})`, "");
+    for (const q of section.questions) {
+      lines.push(`**Q**: ${q.question}`);
+      appendFollowUps(lines, q);
+      appendLookingFor(lines, q);
+      lines.push("");
+    }
+  }
+}
+
+/**
+ * Format scenario-based question sections (capability or behaviour)
+ * @param {string[]} lines
+ * @param {Array} sections
+ * @param {string} heading
+ * @param {string} promptsKey - Key for guided prompts
+ * @param {string} promptsLabel - Display label for prompts
+ */
+function formatScenarioSections(
+  lines,
+  sections,
+  heading,
+  promptsKey,
+  promptsLabel,
+) {
+  if (sections.length === 0) return;
+  lines.push(`## ${heading}`, "");
+  for (const section of sections) {
+    lines.push(`### ${section.name} (${formatLevel(section.level)})`, "");
+    for (const q of section.questions) {
+      lines.push(`**Scenario**: ${q.question}`);
+      if (q.context) {
+        lines.push(`> ${q.context}`);
+      }
+      if (q[promptsKey] && q[promptsKey].length > 0) {
+        lines.push("", `**${promptsLabel}:**`);
+        for (const prompt of q[promptsKey]) {
+          lines.push(`- ${prompt}`);
+        }
+      }
+      appendFollowUps(lines, q);
+      appendLookingFor(lines, q);
+      lines.push("");
+    }
+  }
+}
+
 /**
  * Format interview detail as markdown
  * @param {Object} view - Interview detail view from presenter
@@ -24,102 +109,29 @@ export function interviewToMarkdown(view, { framework } = {}) {
     "",
   ];
 
-  // Group sections by type
   const skillSections = view.sections.filter((s) => s.type === "skill");
   const behaviourSections = view.sections.filter((s) => s.type === "behaviour");
   const capabilitySections = view.sections.filter(
     (s) => s.type === "capability",
   );
 
-  // Skill questions
-  if (skillSections.length > 0) {
-    lines.push(`## ${skillEmoji} Skill Questions`, "");
-    for (const section of skillSections) {
-      lines.push(`### ${section.name} (${formatLevel(section.level)})`, "");
-      for (const q of section.questions) {
-        lines.push(`**Q**: ${q.question}`);
-        if (q.followUps.length > 0) {
-          lines.push("", "**Follow-ups:**");
-          for (const followUp of q.followUps) {
-            lines.push(`  → ${followUp}`);
-          }
-        }
-        if (q.lookingFor && q.lookingFor.length > 0) {
-          lines.push("", "**What to look for:**");
-          for (const item of q.lookingFor) {
-            lines.push(`- ${item}`);
-          }
-        }
-        lines.push("");
-      }
-    }
-  }
+  formatSkillSections(lines, skillSections, skillEmoji);
 
-  // Capability decomposition questions
-  if (capabilitySections.length > 0) {
-    lines.push(`## 🧩 Decomposition Questions`, "");
-    for (const section of capabilitySections) {
-      lines.push(`### ${section.name} (${formatLevel(section.level)})`, "");
-      for (const q of section.questions) {
-        lines.push(`**Scenario**: ${q.question}`);
-        if (q.context) {
-          lines.push(`> ${q.context}`);
-        }
-        if (q.decompositionPrompts && q.decompositionPrompts.length > 0) {
-          lines.push("", "**Guide the candidate through:**");
-          for (const prompt of q.decompositionPrompts) {
-            lines.push(`- ${prompt}`);
-          }
-        }
-        if (q.followUps.length > 0) {
-          lines.push("", "**Follow-ups:**");
-          for (const followUp of q.followUps) {
-            lines.push(`  → ${followUp}`);
-          }
-        }
-        if (q.lookingFor && q.lookingFor.length > 0) {
-          lines.push("", "**What to look for:**");
-          for (const item of q.lookingFor) {
-            lines.push(`- ${item}`);
-          }
-        }
-        lines.push("");
-      }
-    }
-  }
+  formatScenarioSections(
+    lines,
+    capabilitySections,
+    "🧩 Decomposition Questions",
+    "decompositionPrompts",
+    "Guide the candidate through",
+  );
 
-  // Behaviour stakeholder simulation questions
-  if (behaviourSections.length > 0) {
-    lines.push(`## ${behaviourEmoji} Stakeholder Simulation`, "");
-    for (const section of behaviourSections) {
-      lines.push(`### ${section.name} (${formatLevel(section.level)})`, "");
-      for (const q of section.questions) {
-        lines.push(`**Scenario**: ${q.question}`);
-        if (q.context) {
-          lines.push(`> ${q.context}`);
-        }
-        if (q.simulationPrompts && q.simulationPrompts.length > 0) {
-          lines.push("", "**Steer the simulation:**");
-          for (const prompt of q.simulationPrompts) {
-            lines.push(`- ${prompt}`);
-          }
-        }
-        if (q.followUps.length > 0) {
-          lines.push("", "**Follow-ups:**");
-          for (const followUp of q.followUps) {
-            lines.push(`  → ${followUp}`);
-          }
-        }
-        if (q.lookingFor && q.lookingFor.length > 0) {
-          lines.push("", "**What to look for:**");
-          for (const item of q.lookingFor) {
-            lines.push(`- ${item}`);
-          }
-        }
-        lines.push("");
-      }
-    }
-  }
+  formatScenarioSections(
+    lines,
+    behaviourSections,
+    `${behaviourEmoji} Stakeholder Simulation`,
+    "simulationPrompts",
+    "Steer the simulation",
+  );
 
   return lines.join("\n");
 }

package/src/formatters/job/description.js

@@ -13,6 +13,80 @@ import Mustache from "mustache";
 import { BEHAVIOUR_MATURITY_ORDER } from "@forwardimpact/map/levels";
 import { trimValue, trimFields } from "../shared.js";
 
+/**
+ * Build expectations paragraph from job expectations
+ * @param {Object|undefined} expectations
+ * @returns {string}
+ */
+function buildExpectationsParagraph(expectations) {
+  if (!expectations) return "";
+  const exp = expectations;
+  const sentences = [];
+
+  if (exp.impactScope) {
+    sentences.push(`This role encompasses ${exp.impactScope.toLowerCase()}.`);
+  }
+  if (exp.autonomyExpectation) {
+    let autonomySentence = `You will ${exp.autonomyExpectation.toLowerCase()}`;
+    if (exp.influenceScope) {
+      autonomySentence +=
+        `, ${exp.influenceScope.toLowerCase()}` +
+        (exp.influenceScope.endsWith(".") ? "" : ".");
+    } else {
+      autonomySentence += exp.autonomyExpectation.endsWith(".") ? "" : ".";
+    }
+    sentences.push(autonomySentence);
+  } else if (exp.influenceScope) {
+    sentences.push(
+      exp.influenceScope + (exp.influenceScope.endsWith(".") ? "" : "."),
+    );
+  }
+  if (exp.complexityHandled) {
+    sentences.push(`You will handle ${exp.complexityHandled.toLowerCase()}.`);
+  }
+  return sentences.length > 0 ? sentences.join(" ") : "";
+}
+
+/**
+ * Build capability skill sections at the highest proficiency
+ * @param {Object} job
+ * @returns {Array}
+ */
+function buildCapabilitySkills(job) {
+  const derivedResponsibilities = job.derivedResponsibilities || [];
+  if (derivedResponsibilities.length === 0) return [];
+
+  const highestProficiency = derivedResponsibilities[0].proficiency;
+  const topResponsibilities = derivedResponsibilities.filter(
+    (r) => r.proficiency === highestProficiency,
+  );
+
+  const skillsByCapability = {};
+  for (const skill of job.skillMatrix) {
+    if (skill.proficiency !== highestProficiency) continue;
+    if (!skillsByCapability[skill.capability]) {
+      skillsByCapability[skill.capability] = [];
+    }
+    skillsByCapability[skill.capability].push(skill);
+  }
+
+  return topResponsibilities
+    .filter((r) => skillsByCapability[r.capability]?.length > 0)
+    .map((r) => {
+      const skills = [...skillsByCapability[r.capability]].sort((a, b) =>
+        (a.skillName || "").localeCompare(b.skillName || ""),
+      );
+      return {
+        capabilityHeading: r.capabilityName.toUpperCase(),
+        responsibilityDescription: r.responsibility,
+        skills: skills.map((s) => ({
+          skillName: s.skillName,
+          proficiencyDescription: s.proficiencyDescription || "",
+        })),
+      };
+    });
+}
+
 /**
  * Prepare job data for template rendering
  * @param {Object} params
@@ -29,42 +103,7 @@ function prepareJobDescriptionData({ job, discipline, level, track }) {
   roleSummary = roleSummary.replace(/\{roleTitle\}/g, roleTitle);
   roleSummary = roleSummary.replace(/\{specialization\}/g, specialization);
 
-  // Build expectations paragraph
-  let expectationsParagraph = "";
-  if (job.expectations) {
-    const exp = job.expectations;
-    const expectationSentences = [];
-
-    if (exp.impactScope) {
-      expectationSentences.push(
-        `This role encompasses ${exp.impactScope.toLowerCase()}.`,
-      );
-    }
-    if (exp.autonomyExpectation) {
-      let autonomySentence = `You will ${exp.autonomyExpectation.toLowerCase()}`;
-      if (exp.influenceScope) {
-        autonomySentence +=
-          `, ${exp.influenceScope.toLowerCase()}` +
-          (exp.influenceScope.endsWith(".") ? "" : ".");
-      } else {
-        autonomySentence += exp.autonomyExpectation.endsWith(".") ? "" : ".";
-      }
-      expectationSentences.push(autonomySentence);
-    } else if (exp.influenceScope) {
-      expectationSentences.push(
-        exp.influenceScope + (exp.influenceScope.endsWith(".") ? "" : "."),
-      );
-    }
-    if (exp.complexityHandled) {
-      expectationSentences.push(
-        `You will handle ${exp.complexityHandled.toLowerCase()}.`,
-      );
-    }
-
-    if (expectationSentences.length > 0) {
-      expectationsParagraph = expectationSentences.join(" ");
-    }
-  }
+  const expectationsParagraph = buildExpectationsParagraph(job.expectations);
 
   // Sort behaviours by maturity level (highest first)
   const sortedBehaviours = [...job.behaviourProfile].sort((a, b) => {
@@ -76,45 +115,7 @@ function prepareJobDescriptionData({ job, discipline, level, track }) {
     return indexB - indexA;
   });
 
-  // Build capability skill sections at the highest skill proficiency
-  let capabilitySkills = [];
-  const derivedResponsibilities = job.derivedResponsibilities || [];
-  if (derivedResponsibilities.length > 0) {
-    // derivedResponsibilities is sorted: highest proficiency first, then by skill count
-    const highestProficiency = derivedResponsibilities[0].proficiency;
-
-    // Filter responsibilities to only the highest proficiency
-    const topResponsibilities = derivedResponsibilities.filter(
-      (r) => r.proficiency === highestProficiency,
-    );
-
-    // Group skill matrix entries by capability at the highest level
-    const skillsByCapability = {};
-    for (const skill of job.skillMatrix) {
-      if (skill.proficiency !== highestProficiency) continue;
-      if (!skillsByCapability[skill.capability]) {
-        skillsByCapability[skill.capability] = [];
-      }
-      skillsByCapability[skill.capability].push(skill);
-    }
-
-    // Build capability sections in skill count order
-    capabilitySkills = topResponsibilities
-      .filter((r) => skillsByCapability[r.capability]?.length > 0)
-      .map((r) => {
-        const skills = [...skillsByCapability[r.capability]].sort((a, b) =>
-          (a.skillName || "").localeCompare(b.skillName || ""),
-        );
-        return {
-          capabilityHeading: r.capabilityName.toUpperCase(),
-          responsibilityDescription: r.responsibility,
-          skills: skills.map((s) => ({
-            skillName: s.skillName,
-            proficiencyDescription: s.proficiencyDescription || "",
-          })),
-        };
-      });
-  }
+  const capabilitySkills = buildCapabilitySkills(job);
 
   // Build qualification summary with placeholder replacement
   const qualificationSummary =

package/src/formatters/job/dom.js

@@ -33,6 +33,107 @@ import { createToolkitTable } from "../toolkit/dom.js";
  * @param {string} [options.jobTemplate] - Mustache template for job description
  * @returns {HTMLElement}
  */
+/**
+ * Build a job data object from a view for template rendering
+ * @param {Object} view
+ * @returns {Object}
+ */
+function buildJobFromView(view) {
+  return {
+    title: view.title,
+    skillMatrix: view.skillMatrix,
+    behaviourProfile: view.behaviourProfile,
+    expectations: view.expectations,
+    derivedResponsibilities: view.derivedResponsibilities,
+  };
+}
+
+/**
+ * Create the tables section for a job detail view
+ * @param {Object} view
+ * @returns {HTMLElement}
+ */
+function createJobTablesSection(view) {
+  return div(
+    { className: "job-tables-section" },
+    createDetailSection({
+      title: "Behaviour Profile",
+      content: createBehaviourProfile(view.behaviourProfile),
+    }),
+    createDetailSection({
+      title: "Skill Matrix",
+      content: createSkillMatrix(view.skillMatrix, {
+        capabilityOrder: view.capabilityOrder,
+      }),
+    }),
+    view.toolkit && view.toolkit.length > 0
+      ? createDetailSection({
+          title: "Tool Kit",
+          content: createToolkitTable(view.toolkit),
+        })
+      : null,
+  );
+}
+
+/**
+ * Create the page header with breadcrumb links
+ * @param {Object} view
+ * @param {boolean} showBackLink
+ * @returns {HTMLElement}
+ */
+function createJobHeader(view, showBackLink) {
+  return div(
+    { className: "page-header" },
+    showBackLink
+      ? createBackLink("/job-builder", "← Back to Job Builder")
+      : null,
+    h1({ className: "page-title" }, view.title),
+    div(
+      { className: "page-description" },
+      "Generated from: ",
+      a({ href: `#/discipline/${view.disciplineId}` }, view.disciplineName),
+      " × ",
+      a({ href: `#/level/${view.levelId}` }, view.levelId),
+      " × ",
+      a({ href: `#/track/${view.trackId}` }, view.trackName),
+    ),
+  );
+}
+
+/**
+ * Create the expectations section if expectations exist
+ * @param {Object} view
+ * @returns {HTMLElement|null}
+ */
+function createExpectationsSection(view) {
+  if (!view.expectations || Object.keys(view.expectations).length === 0) {
+    return null;
+  }
+  return createDetailSection({
+    title: "Expectations",
+    content: createExpectationsCard(view.expectations),
+  });
+}
+
+/**
+ * Create the radar charts section
+ * @param {Object} view
+ * @returns {HTMLElement}
+ */
+function createRadarSection(view) {
+  return div(
+    { className: "section auto-grid-lg" },
+    createBehaviourRadar(view.behaviourProfile, {
+      title: "Behaviours Radar",
+      size: 420,
+    }),
+    createSkillRadar(view.skillMatrix, {
+      title: "Skills Radar",
+      size: 420,
+    }),
+  );
+}
+
 export function jobToDOM(view, options = {}) {
   const {
     showBackLink = true,
@@ -46,107 +147,22 @@ export function jobToDOM(view, options = {}) {
   } = options;
 
   const hasEntities = discipline && level && jobTemplate;
+  const job = hasEntities ? buildJobFromView(view) : null;
+  const descParams = hasEntities
+    ? { job, discipline, level, track, template: jobTemplate }
+    : null;
 
   return div(
     { className: "job-detail-page" },
-    // Header
-    div(
-      { className: "page-header" },
-      showBackLink
-        ? createBackLink("/job-builder", "← Back to Job Builder")
-        : null,
-      h1({ className: "page-title" }, view.title),
-      div(
-        { className: "page-description" },
-        "Generated from: ",
-        a({ href: `#/discipline/${view.disciplineId}` }, view.disciplineName),
-        " × ",
-        a({ href: `#/level/${view.levelId}` }, view.levelId),
-        " × ",
-        a({ href: `#/track/${view.trackId}` }, view.trackName),
-      ),
-    ),
-
-    // Expectations card
-    view.expectations && Object.keys(view.expectations).length > 0
-      ? createDetailSection({
-          title: "Expectations",
-          content: createExpectationsCard(view.expectations),
-        })
+    createJobHeader(view, showBackLink),
+    createExpectationsSection(view),
+    createRadarSection(view),
+    showJobDescriptionHtml && descParams
+      ? createJobDescriptionHtml(descParams)
       : null,
-
-    // Radar charts
-    div(
-      { className: "section auto-grid-lg" },
-      createBehaviourRadar(view.behaviourProfile, {
-        title: "Behaviours Radar",
-        size: 420,
-      }),
-      createSkillRadar(view.skillMatrix, {
-        title: "Skills Radar",
-        size: 420,
-      }),
-    ),
-
-    // Job Description HTML (for print view)
-    showJobDescriptionHtml && hasEntities
-      ? createJobDescriptionHtml({
-          job: {
-            title: view.title,
-            skillMatrix: view.skillMatrix,
-            behaviourProfile: view.behaviourProfile,
-            expectations: view.expectations,
-            derivedResponsibilities: view.derivedResponsibilities,
-          },
-          discipline,
-          level,
-          track,
-          template: jobTemplate,
-        })
-      : null,
-
-    // Behaviour profile, Skill matrix, Toolkit, Driver coverage tables
-    showTables
-      ? div(
-          { className: "job-tables-section" },
-          // Behaviour profile table
-          createDetailSection({
-            title: "Behaviour Profile",
-            content: createBehaviourProfile(view.behaviourProfile),
-          }),
-
-          createDetailSection({
-            title: "Skill Matrix",
-            content: createSkillMatrix(view.skillMatrix, {
-              capabilityOrder: view.capabilityOrder,
-            }),
-          }),
-
-          // Toolkit (after skill matrix)
-          view.toolkit && view.toolkit.length > 0
-            ? createDetailSection({
-                title: "Tool Kit",
-                content: createToolkitTable(view.toolkit),
-              })
-            : null,
-        )
-      : null,
-
-    // Job Description (copyable markdown)
-    showJobDescriptionMarkdown && hasEntities
-      ? createJobDescriptionSection({
-          job: {
-            title: view.title,
-            skillMatrix: view.skillMatrix,
-            behaviourProfile: view.behaviourProfile,
-            expectations: view.expectations,
-            derivedResponsibilities: view.derivedResponsibilities,
-          },
-          discipline,
-          level,
-          track,
-          template: jobTemplate,
-        })
+    showTables ? createJobTablesSection(view) : null,
+    showJobDescriptionMarkdown && descParams
+      ? createJobDescriptionSection(descParams)
       : null,
   );
 }