@fluidframework/container-runtime 2.13.0 → 2.21.0

package/src/gc/gcDefinitions.ts

@@ -21,7 +21,9 @@ import {
 import { RuntimeHeaderData } from "../containerRuntime.js";
 import { ContainerRuntimeGCMessage } from "../messageTypes.js";
 import {
+	// eslint-disable-next-line import/no-deprecated
 	IContainerRuntimeMetadata,
+	// eslint-disable-next-line import/no-deprecated
 	ICreateContainerMetadata,
 	IRefreshSummaryResult,
 } from "../summary/index.js";
@@ -29,12 +31,17 @@ import {
 /**
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export type GCVersion = number;
 
-/** The stable/default version of GC Data */
+/**
+ * The stable/default version of GC Data
+ */
 export const stableGCVersion: GCVersion = 3;
-/** The next version of GC Data, to bump to in case we need to regenerate all GC Data across all files. */
+/**
+ * The next version of GC Data, to bump to in case we need to regenerate all GC Data across all files.
+ */
 export const nextGCVersion: GCVersion = 4;
 
 /**
@@ -50,14 +57,22 @@ export const nextGCVersion: GCVersion = 4;
  */
 export const gcGenerationOptionName = "gcGeneration";
 
-/** Config key to turn GC test mode on / off. */
+/**
+ * Config key to turn GC test mode on / off.
+ */
 export const gcTestModeKey = "Fluid.GarbageCollection.GCTestMode";
-/** Config key to expire a session after a set period of time. Defaults to true. */
+/**
+ * Config key to expire a session after a set period of time. Defaults to true.
+ */
 export const runSessionExpiryKey = "Fluid.GarbageCollection.RunSessionExpiry";
-/** Config key to disable throwing an error when tombstone object is loaded (requested). */
+/**
+ * Config key to disable throwing an error when tombstone object is loaded (requested).
+ */
 export const disableThrowOnTombstoneLoadKey =
 	"Fluid.GarbageCollection.DisableThrowOnTombstoneLoad";
-/** Config key to enable GC version upgrade. */
+/**
+ * Config key to enable GC version upgrade.
+ */
 export const gcVersionUpgradeToV4Key = "Fluid.GarbageCollection.GCVersionUpgradeToV4";
 
 // One day in milliseconds.
@@ -79,6 +94,7 @@ export const defaultSweepGracePeriodMs = 1 * oneDayMs; // 1 day
  * @see IGCMetadata.gcFeatureMatrix and @see gcGenerationOptionName
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export type GCFeatureMatrix =
 	| {
@@ -88,7 +104,9 @@ export type GCFeatureMatrix =
 			 * Provided via Container Runtime Options.
 			 */
 			gcGeneration?: number;
-			/** Deprecated property from legacy type. Will not be set concurrently with gcGeneration */
+			/**
+			 * Deprecated property from legacy type. Will not be set concurrently with gcGeneration
+			 */
 			tombstoneGeneration?: undefined;
 	  }
 	| {
@@ -117,6 +135,7 @@ export interface IGCMetadata_Deprecated {
  *
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export interface IGCMetadata {
 	/**
@@ -148,7 +167,9 @@ export interface IGCMetadata {
 	 * @deprecated use GCFeatureMatrix.gcGeneration instead. @see GCFeatureMatrix.gcGeneration
 	 */
 	readonly sweepEnabled?: boolean;
-	/** If this is present, the session for this container will expire after this time and the container will close */
+	/**
+	 * If this is present, the session for this container will expire after this time and the container will close
+	 */
 	readonly sessionExpiryTimeoutMs?: number;
 	/**
 	 * How long to wait after an object is unreferenced before it becomes a Tombstone.
@@ -165,25 +186,44 @@ export interface IGCMetadata {
  * The statistics of the system state after a garbage collection mark phase run.
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export interface IMarkPhaseStats {
-	/** The number of nodes in the container. */
+	/**
+	 * The number of nodes in the container.
+	 */
 	nodeCount: number;
-	/** The number of data stores in the container. */
+	/**
+	 * The number of data stores in the container.
+	 */
 	dataStoreCount: number;
-	/** The number of attachment blobs in the container. */
+	/**
+	 * The number of attachment blobs in the container.
+	 */
 	attachmentBlobCount: number;
-	/** The number of unreferenced nodes in the container. */
+	/**
+	 * The number of unreferenced nodes in the container.
+	 */
 	unrefNodeCount: number;
-	/** The number of unreferenced data stores in the container. */
+	/**
+	 * The number of unreferenced data stores in the container.
+	 */
 	unrefDataStoreCount: number;
-	/** The number of unreferenced attachment blobs in the container. */
+	/**
+	 * The number of unreferenced attachment blobs in the container.
+	 */
 	unrefAttachmentBlobCount: number;
-	/** The number of nodes whose reference state updated since last GC run. */
+	/**
+	 * The number of nodes whose reference state updated since last GC run.
+	 */
 	updatedNodeCount: number;
-	/** The number of data stores whose reference state updated since last GC run. */
+	/**
+	 * The number of data stores whose reference state updated since last GC run.
+	 */
 	updatedDataStoreCount: number;
-	/** The number of attachment blobs whose reference state updated since last GC run. */
+	/**
+	 * The number of attachment blobs whose reference state updated since last GC run.
+	 */
 	updatedAttachmentBlobCount: number;
 }
 
@@ -191,19 +231,32 @@ export interface IMarkPhaseStats {
  * The statistics of the system state after a garbage collection sweep phase run.
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export interface ISweepPhaseStats {
-	/** The number of nodes in the lifetime of the container. */
+	/**
+	 * The number of nodes in the lifetime of the container.
+	 */
 	lifetimeNodeCount: number;
-	/** The number of data stores in the lifetime of the container. */
+	/**
+	 * The number of data stores in the lifetime of the container.
+	 */
 	lifetimeDataStoreCount: number;
-	/** The number of attachment blobs in the lifetime of the container. */
+	/**
+	 * The number of attachment blobs in the lifetime of the container.
+	 */
 	lifetimeAttachmentBlobCount: number;
-	/** The number of deleted nodes in the container. */
+	/**
+	 * The number of deleted nodes in the container.
+	 */
 	deletedNodeCount: number;
-	/** The number of deleted data stores in the container. */
+	/**
+	 * The number of deleted data stores in the container.
+	 */
 	deletedDataStoreCount: number;
-	/** The number of deleted attachment blobs in the container. */
+	/**
+	 * The number of deleted attachment blobs in the container.
+	 */
 	deletedAttachmentBlobCount: number;
 }
 
@@ -211,6 +264,7 @@ export interface ISweepPhaseStats {
  * The statistics of the system state after a garbage collection run.
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export interface IGCStats extends IMarkPhaseStats, ISweepPhaseStats {}
 
@@ -218,6 +272,7 @@ export interface IGCStats extends IMarkPhaseStats, ISweepPhaseStats {}
  * The types of GC nodes in the GC reference graph.
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export const GCNodeType = {
 	// Nodes that are for data stores.
@@ -233,6 +288,7 @@ export const GCNodeType = {
 /**
  * @legacy
  * @alpha
+ * @deprecated This type will be moved to internal in 2.30. External usage is not necessary or supported.
  */
 export type GCNodeType = (typeof GCNodeType)[keyof typeof GCNodeType];
 
@@ -241,9 +297,13 @@ export type GCNodeType = (typeof GCNodeType)[keyof typeof GCNodeType];
  * @internal
  */
 export const GarbageCollectionMessageType = {
-	/** Message sent directing GC to delete the given nodes */
+	/**
+	 * Message sent directing GC to delete the given nodes
+	 */
 	Sweep: "Sweep",
-	/** Message sent notifying GC that a Tombstoned object was Loaded */
+	/**
+	 * Message sent notifying GC that a Tombstoned object was Loaded
+	 */
 	TombstoneLoaded: "TombstoneLoaded",
 } as const;
 
@@ -258,9 +318,13 @@ export type GarbageCollectionMessageType =
  * @internal
  */
 export interface ISweepMessage {
-	/** @see GarbageCollectionMessageType.Sweep */
+	/**
+	 * @see GarbageCollectionMessageType.Sweep
+	 */
 	type: typeof GarbageCollectionMessageType.Sweep;
-	/** The ids of nodes that are deleted. */
+	/**
+	 * The ids of nodes that are deleted.
+	 */
 	deletedNodeIds: string[];
 }
 
@@ -269,9 +333,13 @@ export interface ISweepMessage {
  * @internal
  */
 export interface ITombstoneLoadedMessage {
-	/** @see GarbageCollectionMessageType.TombstoneLoaded */
+	/**
+	 * @see GarbageCollectionMessageType.TombstoneLoaded
+	 */
 	type: typeof GarbageCollectionMessageType.TombstoneLoaded;
-	/** The id of Tombstoned node that was loaded. */
+	/**
+	 * The id of Tombstoned node that was loaded.
+	 */
 	nodePath: string;
 }
 
@@ -285,9 +353,13 @@ export type GarbageCollectionMessage = ISweepMessage | ITombstoneLoadedMessage;
  * Defines the APIs for the runtime object to be passed to the garbage collector.
  */
 export interface IGarbageCollectionRuntime {
-	/** Returns the garbage collection data of the runtime. */
+	/**
+	 * Returns the garbage collection data of the runtime.
+	 */
 	getGCData(fullGC?: boolean): Promise<IGarbageCollectionData>;
-	/** After GC has run, called to notify the runtime of routes that are used in it. */
+	/**
+	 * After GC has run, called to notify the runtime of routes that are used in it.
+	 */
 	updateUsedRoutes(usedRoutes: readonly string[]): void;
 	/**
 	 * After GC has run and identified nodes that are sweep ready, called to delete the sweep ready nodes. The runtime
@@ -295,17 +367,27 @@ export interface IGarbageCollectionRuntime {
 	 * @param sweepReadyRoutes - The routes of nodes that are sweep ready and should be deleted.
 	 */
 	deleteSweepReadyNodes(sweepReadyRoutes: readonly string[]): readonly string[];
-	/** Called to notify the runtime of routes that are tombstones. */
+	/**
+	 * Called to notify the runtime of routes that are tombstones.
+	 */
 	updateTombstonedRoutes(tombstoneRoutes: readonly string[]): void;
-	/** Returns a referenced timestamp to be used to track unreferenced nodes. */
+	/**
+	 * Returns a referenced timestamp to be used to track unreferenced nodes.
+	 */
 	getCurrentReferenceTimestampMs(): number | undefined;
-	/** Returns the type of the GC node. */
+	/**
+	 * Returns the type of the GC node.
+	 */
 	getNodeType(nodePath: string): GCNodeType;
-	/** Called when the runtime should close because of an error. */
+	/**
+	 * Called when the runtime should close because of an error.
+	 */
 	closeFn: (error?: ICriticalContainerError) => void;
 }
 
-/** Defines the contract for the garbage collector. */
+/**
+ * Defines the contract for the garbage collector.
+ */
 export interface IGarbageCollector {
 	/**
 	 * Tells the time at which session expiry timer started in a previous container.
@@ -313,13 +395,21 @@ export interface IGarbageCollector {
 	 * original container's local client time when it was loaded (and started the session expiry timer).
 	 */
 	readonly sessionExpiryTimerStarted: number | undefined;
-	/** Tells whether GC should run or not. */
+	/**
+	 * Tells whether GC should run or not.
+	 */
 	readonly shouldRunGC: boolean;
-	/** The count of data stores whose GC state updated since the last summary. */
+	/**
+	 * The count of data stores whose GC state updated since the last summary.
+	 */
 	readonly updatedDSCountSinceLastSummary: number;
-	/** Initialize the state from the base snapshot after its creation. */
+	/**
+	 * Initialize the state from the base snapshot after its creation.
+	 */
 	initializeBaseState(): Promise<void>;
-	/** Run garbage collection and update the reference / used state of the system. */
+	/**
+	 * Run garbage collection and update the reference / used state of the system.
+	 */
 	collectGarbage(
 		options: {
 			logger?: ITelemetryLoggerExt;
@@ -328,37 +418,51 @@ export interface IGarbageCollector {
 		},
 		telemetryContext?: ITelemetryContext,
 	): Promise<IGCStats | undefined>;
-	/** Summarizes the GC data and returns it as a summary tree. */
+	/**
+	 * Summarizes the GC data and returns it as a summary tree.
+	 */
 	summarize(
 		fullTree: boolean,
 		trackState: boolean,
 		telemetryContext?: ITelemetryContext,
 	): ISummarizeResult | undefined;
-	/** Returns the garbage collector specific metadata to be written into the summary. */
+	/**
+	 * Returns the garbage collector specific metadata to be written into the summary.
+	 */
 	getMetadata(): IGCMetadata;
-	/** Returns the GC details generated from the base snapshot. */
+	/**
+	 * Returns the GC details generated from the base snapshot.
+	 */
 	getBaseGCDetails(): Promise<IGarbageCollectionDetailsBase>;
-	/** Called when the latest summary of the system has been refreshed. */
+	/**
+	 * Called when the latest summary of the system has been refreshed.
+	 */
 	refreshLatestSummary(result: IRefreshSummaryResult): Promise<void>;
 	/**
 	 * Called when a node with the given path is updated. If the node is inactive or tombstoned, this will log an error
 	 * or throw an error if failing on incorrect usage is configured.
 	 */
 	nodeUpdated(props: IGCNodeUpdatedProps): void;
-	/** Called when a reference is added to a node. Used to identify nodes that were referenced between summaries. */
+	/**
+	 * Called when a reference is added to a node. Used to identify nodes that were referenced between summaries.
+	 */
 	addedOutboundReference(
 		fromNodePath: string,
 		toNodePath: string,
 		timestampMs: number,
 		autorecovery?: true,
 	): void;
-	/** Called to process garbage collection messages */
+	/**
+	 * Called to process garbage collection messages
+	 */
 	processMessages(
 		messageContents: GarbageCollectionMessage[],
 		messageTimestampMs: number,
 		local: boolean,
 	): void;
-	/** Returns true if this node has been deleted by GC during sweep phase. */
+	/**
+	 * Returns true if this node has been deleted by GC during sweep phase.
+	 */
 	isNodeDeleted(nodePath: string): boolean;
 	setConnectionState(connected: boolean, clientId?: string): void;
 	dispose(): void;
@@ -369,32 +473,48 @@ export interface IGarbageCollector {
  * @internal
  */
 export interface IGCNodeUpdatedProps {
-	/** Type and path of the updated node */
+	/**
+	 * Type and path of the updated node
+	 */
 	node: { type: (typeof GCNodeType)["DataStore" | "Blob"]; path: string };
-	/** Whether the node (or a subpath) was loaded or changed. */
+	/**
+	 * Whether the node (or a subpath) was loaded or changed.
+	 */
 	reason: "Loaded" | "Changed" | "Realized";
 	/**
 	 * The op-based timestamp when the node changed. If the update is from receiving an op, this should
 	 * be the timestamp of the op. If not, this should be the timestamp of the last op processed.
 	 */
 	timestampMs: number | undefined;
-	/** The package path of the node. This may not be available if the node hasn't been loaded yet */
+	/**
+	 * The package path of the node. This may not be available if the node hasn't been loaded yet
+	 */
 	packagePath?: readonly string[];
-	/** The original request for loads to preserve it in telemetry */
+	/**
+	 * The original request for loads to preserve it in telemetry
+	 */
 	request?: IRequest;
-	/** If the node was loaded via request path, the header data. May be modified from the original request */
+	/**
+	 * If the node was loaded via request path, the header data. May be modified from the original request
+	 */
 	headerData?: RuntimeHeaderData;
-	/** Any other properties to be logged. */
+	/**
+	 * Any other properties to be logged.
+	 */
 	additionalProps?: ITelemetryPropertiesExt;
 }
 
-/** Parameters necessary for creating a GarbageCollector. */
+/**
+ * Parameters necessary for creating a GarbageCollector.
+ */
 export interface IGarbageCollectorCreateParams {
 	readonly runtime: IGarbageCollectionRuntime;
 	readonly gcOptions: IGCRuntimeOptions;
 	readonly baseLogger: ITelemetryLoggerExt;
 	readonly existing: boolean;
+	// eslint-disable-next-line import/no-deprecated
 	readonly metadata: IContainerRuntimeMetadata | undefined;
+	// eslint-disable-next-line import/no-deprecated
 	readonly createContainerMetadata: ICreateContainerMetadata;
 	readonly baseSnapshot: ISnapshotTree | undefined;
 	readonly isSummarizerClient: boolean;
@@ -444,6 +564,8 @@ export interface IGCRuntimeOptions {
 	/**
 	 * Allows additional GC options to be passed.
 	 */
+	// TODO: Use unknown (breaking change)
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any
 	[key: string]: any;
 }
 
@@ -461,44 +583,72 @@ export interface IGarbageCollectorConfigs {
 	 * flag defined below.
 	 */
 	readonly sweepAllowed: boolean;
-	/** Tracks if sweep phase is enabled to run in this session or not */
+	/**
+	 * Tracks if sweep phase is enabled to run in this session or not
+	 */
 	readonly sweepEnabled: boolean;
 	/**
 	 * If true, bypass optimizations and generate GC data for all nodes irrespective of whether a node changed or not.
 	 */
 	readonly runFullGC: boolean | undefined;
-	/** The time in ms to expire a session for a client for gc. */
+	/**
+	 * The time in ms to expire a session for a client for gc.
+	 */
 	readonly sessionExpiryTimeoutMs: number | undefined;
-	/** The time after which an unreferenced node can be Tombstoned - i.e. GC knows it can't be referenced again (revived). */
+	/**
+	 * The time after which an unreferenced node can be Tombstoned - i.e. GC knows it can't be referenced again (revived).
+	 */
 	readonly tombstoneTimeoutMs: number | undefined;
 	/**
 	 * The delay between tombstone and sweep. Not persisted, so concurrent sessions may use different values.
 	 * Sweep is implemented in an eventually-consistent way so this is acceptable.
 	 */
 	readonly sweepGracePeriodMs: number;
-	/** The time after which an unreferenced node is inactive. */
+	/**
+	 * The time after which an unreferenced node is inactive.
+	 */
 	readonly inactiveTimeoutMs: number;
-	/** Tracks whether GC should run in test mode. In this mode, unreferenced objects are deleted immediately. */
+	/**
+	 * Tracks whether GC should run in test mode. In this mode, unreferenced objects are deleted immediately.
+	 */
 	readonly testMode: boolean;
-	/** @see GCFeatureMatrix. */
+	/**
+	 * @see GCFeatureMatrix.
+	 */
 	readonly persistedGcFeatureMatrix: GCFeatureMatrix | undefined;
-	/** The version of GC in the base snapshot. */
+	/**
+	 * The version of GC in the base snapshot.
+	 */
 	readonly gcVersionInBaseSnapshot: GCVersion | undefined;
-	/** The current version of GC data in the running code */
+	/**
+	 * The current version of GC data in the running code
+	 */
 	readonly gcVersionInEffect: GCVersion;
-	/** If true, throw an error when a tombstone data store is retrieved */
+	/**
+	 * If true, throw an error when a tombstone data store is retrieved
+	 */
 	readonly throwOnTombstoneLoad: boolean;
 }
 
-/** The state of node that is unreferenced. */
+/**
+ * The state of node that is unreferenced.
+ */
 export const UnreferencedState = {
-	/** The node is active, i.e., it can become referenced again. */
+	/**
+	 * The node is active, i.e., it can become referenced again.
+	 */
 	Active: "Active",
-	/** The node is inactive, i.e., it should not become referenced. */
+	/**
+	 * The node is inactive, i.e., it should not become referenced.
+	 */
 	Inactive: "Inactive",
-	/** The node is ready to be tombstoned */
+	/**
+	 * The node is ready to be tombstoned
+	 */
 	TombstoneReady: "TombstoneReady",
-	/** The node is ready to be deleted by the sweep phase. */
+	/**
+	 * The node is ready to be deleted by the sweep phase.
+	 */
 	SweepReady: "SweepReady",
 } as const;
 export type UnreferencedState = (typeof UnreferencedState)[keyof typeof UnreferencedState];
@@ -507,8 +657,12 @@ export type UnreferencedState = (typeof UnreferencedState)[keyof typeof Unrefere
  * Represents the result of a GC run.
  */
 export interface IGCResult {
-	/** The ids of nodes that are referenced in the referenced graph */
+	/**
+	 * The ids of nodes that are referenced in the referenced graph
+	 */
 	referencedNodeIds: string[];
-	/** The ids of nodes that are not-referenced or deleted in the referenced graph */
+	/**
+	 * The ids of nodes that are not-referenced or deleted in the referenced graph
+	 */
 	deletedNodeIds: string[];
 }

package/src/gc/gcHelpers.ts

@@ -15,8 +15,11 @@ import {
 import type { IConfigProvider } from "@fluidframework/telemetry-utils/internal";
 
 import {
+	// eslint-disable-next-line import/no-deprecated
 	GCFeatureMatrix,
+	// eslint-disable-next-line import/no-deprecated
 	GCVersion,
+	// eslint-disable-next-line import/no-deprecated
 	IGCMetadata,
 	gcVersionUpgradeToV4Key,
 	nextGCVersion,
@@ -28,6 +31,7 @@ import {
 	IGarbageCollectionState,
 } from "./gcSummaryDefinitions.js";
 
+// eslint-disable-next-line import/no-deprecated
 export function getGCVersion(metadata?: IGCMetadata): GCVersion {
 	if (!metadata) {
 		// Force to 0/disallowed in prior versions
@@ -36,7 +40,9 @@ export function getGCVersion(metadata?: IGCMetadata): GCVersion {
 	return metadata.gcFeature ?? 0;
 }
 
-/** Indicates what GC version is in effect for new GC data being written in this session */
+/**
+ * Indicates what GC version is in effect for new GC data being written in this session
+ */
 export function getGCVersionInEffect(configProvider: IConfigProvider): number {
 	// If version upgrade is not enabled, fall back to the stable GC version.
 	return configProvider.getBoolean(gcVersionUpgradeToV4Key) === true
@@ -61,6 +67,7 @@ export function getGCVersionInEffect(configProvider: IConfigProvider): number {
  * @returns true if GC Sweep should be allowed for this document
  */
 export function shouldAllowGcSweep(
+	// eslint-disable-next-line import/no-deprecated
 	featureMatrix: GCFeatureMatrix,
 	currentGeneration: number | undefined,
 ): boolean {
@@ -103,16 +110,16 @@ export function concatGarbageCollectionStates(
 	const combinedGCNodes: { [id: string]: IGarbageCollectionNodeData } = {};
 	for (const [nodeId, nodeData] of Object.entries(gcState1.gcNodes)) {
 		combinedGCNodes[nodeId] = {
-			outboundRoutes: Array.from(nodeData.outboundRoutes),
+			outboundRoutes: [...nodeData.outboundRoutes],
 			unreferencedTimestampMs: nodeData.unreferencedTimestampMs,
 		};
 	}
 
 	for (const [nodeId, nodeData] of Object.entries(gcState2.gcNodes)) {
-		let combineNodeData: IGarbageCollectionNodeData | undefined = combinedGCNodes[nodeId];
+		let combineNodeData = combinedGCNodes[nodeId];
 		if (combineNodeData === undefined) {
 			combineNodeData = {
-				outboundRoutes: Array.from(nodeData.outboundRoutes),
+				outboundRoutes: [...nodeData.outboundRoutes],
 				unreferencedTimestampMs: nodeData.unreferencedTimestampMs,
 			};
 		} else {
@@ -147,7 +154,7 @@ export function concatGarbageCollectionStates(
 export function cloneGCData(gcData: IGarbageCollectionData): IGarbageCollectionData {
 	const clonedGCNodes: { [id: string]: string[] } = {};
 	for (const [id, outboundRoutes] of Object.entries(gcData.gcNodes)) {
-		clonedGCNodes[id] = Array.from(outboundRoutes);
+		clonedGCNodes[id] = [...outboundRoutes];
 	}
 	return {
 		gcNodes: clonedGCNodes,
@@ -160,11 +167,11 @@ export function cloneGCData(gcData: IGarbageCollectionData): IGarbageCollectionD
 export function concatGarbageCollectionData(
 	gcData1: IGarbageCollectionData,
 	gcData2: IGarbageCollectionData,
-) {
+): IGarbageCollectionData {
 	const combinedGCData: IGarbageCollectionData = cloneGCData(gcData1);
 	for (const [id, routes] of Object.entries(gcData2.gcNodes)) {
 		if (combinedGCData.gcNodes[id] === undefined) {
-			combinedGCData.gcNodes[id] = Array.from(routes);
+			combinedGCData.gcNodes[id] = [...routes];
 		} else {
 			const combinedRoutes = [...routes, ...combinedGCData.gcNodes[id]];
 			combinedGCData.gcNodes[id] = [...new Set(combinedRoutes)];
@@ -202,7 +209,7 @@ export async function getGCDataFromSnapshot(
 			continue;
 		}
 
-		const blobId: string | undefined = gcSnapshotTree.blobs[key];
+		const blobId = gcSnapshotTree.blobs[key];
 		if (blobId === undefined) {
 			continue;
 		}
@@ -219,7 +226,9 @@ export async function getGCDataFromSnapshot(
  * @param gcDetails - The GC details of a node.
  * @returns A map of GC details of each children of the the given node.
  */
-export function unpackChildNodesGCDetails(gcDetails: IGarbageCollectionDetailsBase) {
+export function unpackChildNodesGCDetails(
+	gcDetails: IGarbageCollectionDetailsBase,
+): Map<string, IGarbageCollectionDetailsBase> {
 	const childGCDetailsMap: Map<string, IGarbageCollectionDetailsBase> = new Map();
 
 	// If GC data is not available, bail out.
@@ -290,11 +299,13 @@ export function unpackChildNodesGCDetails(gcDetails: IGarbageCollectionDetailsBa
  * @param str - A string that may contain leading and / or trailing slashes.
  * @returns A new string without leading and trailing slashes.
  */
-function trimLeadingAndTrailingSlashes(str: string) {
+function trimLeadingAndTrailingSlashes(str: string): string {
 	return str.replace(/^\/+|\/+$/g, "");
 }
 
-/** Reformats a request URL to match expected format for a GC node path */
+/**
+ * Reformats a request URL to match expected format for a GC node path
+ */
 export function urlToGCNodePath(url: string): string {
 	return `/${trimLeadingAndTrailingSlashes(url.split("?")[0])}`;
 }

package/src/gc/gcReferenceGraphAlgorithm.ts

@@ -31,7 +31,7 @@ export function runGarbageCollection(
 
 		// Get the node for the referenced id and add its outbound routes to referencedIds since they are
 		// also referenced.
-		const routes: string[] | undefined = referenceGraph[id];
+		const routes = referenceGraph[id];
 		if (routes !== undefined) {
 			referencedIds.push(...routes);
 		}