@fluidframework/container-runtime 2.13.0 → 2.21.0

package/src/dataStore.ts

@@ -26,9 +26,13 @@ import { ContainerMessageType } from "./messageTypes.js";
  * alias to a datastore
  */
 export interface IDataStoreAliasMessage {
-	/** The internal id of the datastore */
+	/**
+	 * The internal id of the datastore
+	 */
 	readonly internalId: string;
-	/** The alias name to be assigned to the datastore */
+	/**
+	 * The alias name to be assigned to the datastore
+	 */
 	readonly alias: string;
 }
 
@@ -39,11 +43,12 @@ export interface IDataStoreAliasMessage {
  * @returns True if the {@link IDataStoreAliasMessage} is fully implemented, false otherwise
  */
 export const isDataStoreAliasMessage = (
-	maybeDataStoreAliasMessage: any,
+	maybeDataStoreAliasMessage: unknown,
 ): maybeDataStoreAliasMessage is IDataStoreAliasMessage => {
 	return (
-		typeof maybeDataStoreAliasMessage?.internalId === "string" &&
-		typeof maybeDataStoreAliasMessage?.alias === "string"
+		typeof (maybeDataStoreAliasMessage as Partial<IDataStoreAliasMessage>)?.internalId ===
+			"string" &&
+		typeof (maybeDataStoreAliasMessage as Partial<IDataStoreAliasMessage>)?.alias === "string"
 	);
 };
 
@@ -77,18 +82,20 @@ class DataStore implements IDataStore {
 		switch (this.aliasState) {
 			// If we're already aliasing, check if it's for the same value and return
 			// the stored promise, otherwise return 'AlreadyAliased'
-			case AliasState.Aliasing:
+			case AliasState.Aliasing: {
 				assert(
 					this.aliasResult !== undefined,
 					0x316 /* There should be a cached promise of in-progress aliasing */,
 				);
 				await this.aliasResult;
 				return this.alias === alias ? "Success" : "AlreadyAliased";
+			}
 
 			// If this datastore is already aliased, return true only if this
 			// is a repeated call for the same alias
-			case AliasState.Aliased:
+			case AliasState.Aliased: {
 				return this.alias === alias ? "Success" : "AlreadyAliased";
+			}
 
 			case AliasState.None: {
 				const existingAlias = this.pendingAliases.get(alias);
@@ -103,8 +110,9 @@ class DataStore implements IDataStore {
 				break;
 			}
 
-			default:
+			default: {
 				unreachableCase(this.aliasState);
+			}
 		}
 
 		this.aliasState = AliasState.Aliasing;
@@ -187,7 +195,7 @@ class DataStore implements IDataStore {
 	private async ackBasedPromise<T>(
 		executor: (
 			resolve: (value: T | PromiseLike<T>) => void,
-			reject: (reason?: any) => void,
+			reject: (reason?: unknown) => void,
 		) => void,
 	): Promise<T> {
 		let rejectBecauseDispose: () => void;

package/src/dataStoreContext.ts

@@ -14,7 +14,11 @@ import {
 	ITelemetryBaseProperties,
 	type IEvent,
 } from "@fluidframework/core-interfaces";
-import { type IFluidHandleInternal } from "@fluidframework/core-interfaces/internal";
+import {
+	type IFluidHandleContext,
+	type IFluidHandleInternal,
+	type ITelemetryBaseLogger,
+} from "@fluidframework/core-interfaces/internal";
 import { assert, LazyPromise, unreachableCase } from "@fluidframework/core-utils/internal";
 import { IClientDetails, IQuorumClients } from "@fluidframework/driver-definitions";
 import {
@@ -104,7 +108,9 @@ export function createAttributesBlob(
 	return new BlobTreeEntry(dataStoreAttributesBlobName, JSON.stringify(attributes));
 }
 
-/** @internal */
+/**
+ * @internal
+ */
 export interface ISnapshotDetails {
 	pkg: readonly string[];
 	isRootDataStore: boolean;
@@ -152,10 +158,6 @@ export interface ILocalFluidDataStoreContextProps extends IFluidDataStoreContext
 	readonly pkg: Readonly<string[]> | undefined;
 	readonly snapshotTree: ISnapshotTree | undefined;
 	readonly makeLocallyVisibleFn: () => void;
-	/**
-	 * @deprecated 0.16 Issue #1635, #3631
-	 */
-	readonly createProps?: any;
 }
 
 /**
@@ -177,7 +179,9 @@ export interface IRemoteFluidDataStoreContextProps extends IFluidDataStoreContex
 
 // back-compat: To be removed in the future.
 // Added in "2.0.0-rc.2.0.0" timeframe (to support older builds).
-/** @internal */
+/**
+ * @internal
+ */
 export interface IFluidDataStoreContextEvents extends IEvent {
 	(event: "attaching" | "attached", listener: () => void);
 }
@@ -195,7 +199,7 @@ export abstract class FluidDataStoreContext
 		return this.pkg;
 	}
 
-	public get options(): Record<string | number, any> {
+	public get options(): Record<string | number, unknown> {
 		return this.parentContext.options;
 	}
 
@@ -207,7 +211,7 @@ export abstract class FluidDataStoreContext
 		return this.parentContext.clientDetails;
 	}
 
-	public get baseLogger() {
+	public get baseLogger(): ITelemetryBaseLogger {
 		return this.parentContext.baseLogger;
 	}
 
@@ -219,7 +223,7 @@ export abstract class FluidDataStoreContext
 		return this.parentContext.connected;
 	}
 
-	public get IFluidHandleContext() {
+	public get IFluidHandleContext(): IFluidHandleContext {
 		return this.parentContext.IFluidHandleContext;
 	}
 
@@ -239,7 +243,7 @@ export abstract class FluidDataStoreContext
 	}
 
 	private _disposed = false;
-	public get disposed() {
+	public get disposed(): boolean {
 		return this._disposed;
 	}
 
@@ -248,7 +252,7 @@ export abstract class FluidDataStoreContext
 	 * Tombstoned objects are eventually deleted by GC.
 	 */
 	private _tombstoned = false;
-	public get tombstoned() {
+	public get tombstoned(): boolean {
 		return this._tombstoned;
 	}
 	/**
@@ -261,7 +265,9 @@ export abstract class FluidDataStoreContext
 	 */
 	public readonly gcTombstoneEnforcementAllowed: boolean = false;
 
-	/** If true, this means that this data store context and its children have been removed from the runtime */
+	/**
+	 * If true, this means that this data store context and its children have been removed from the runtime
+	 */
 	protected deleted: boolean = false;
 
 	public get attachState(): AttachState {
@@ -289,11 +295,13 @@ export abstract class FluidDataStoreContext
 		// We know that if the base snapshot is omitted, then the isRootDataStore flag is not set.
 		// That means we can skip the expensive call to getInitialSnapshotDetails for virtualized datastores,
 		// and get the information from the alias map directly.
+		// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access
 		if (aliasedDataStores !== undefined && (this.baseSnapshot as any)?.omitted === true) {
 			return aliasedDataStores.has(this.id);
 		}
 
-		return (await this.getInitialSnapshotDetails()).isRootDataStore;
+		const snapshotDetails = await this.getInitialSnapshotDetails();
+		return snapshotDetails.isRootDataStore;
 	}
 
 	/**
@@ -319,7 +327,9 @@ export abstract class FluidDataStoreContext
 	protected detachedRuntimeCreation = false;
 	protected channel: IFluidDataStoreChannel | undefined;
 	private loaded = false;
-	/** Tracks the messages for this data store that are sent while it's not loaded */
+	/**
+	 * Tracks the messages for this data store that are sent while it's not loaded
+	 */
 	private pendingMessagesState: IPendingMessagesState | undefined = {
 		messageCollections: [],
 		pendingCount: 0,
@@ -374,14 +384,9 @@ export abstract class FluidDataStoreContext
 				? this.parentContext.attachState
 				: AttachState.Detached;
 
-		const thisSummarizeInternal = async (
-			fullTree: boolean,
-			trackState: boolean,
-			telemetryContext?: ITelemetryContext,
-		) => this.summarizeInternal(fullTree, trackState, telemetryContext);
-
 		this.summarizerNode = props.createSummarizerNodeFn(
-			thisSummarizeInternal,
+			async (fullTree, trackState, telemetryContext) =>
+				this.summarizeInternal(fullTree, trackState, telemetryContext),
 			async (fullGC?: boolean) => this.getGCDataInternal(fullGC),
 		);
 
@@ -429,11 +434,11 @@ export abstract class FluidDataStoreContext
 	 * This function is called to prevent ops from being generated from this data store once it has been deleted. Furthermore, this data store
 	 * should not receive any ops/signals.
 	 */
-	public delete() {
+	public delete(): void {
 		this.deleted = true;
 	}
 
-	public setTombstone(tombstone: boolean) {
+	public setTombstone(tombstone: boolean): void {
 		if (this.tombstoned === tombstone) {
 			return;
 		}
@@ -483,7 +488,7 @@ export abstract class FluidDataStoreContext
 		return this.channelP;
 	}
 
-	protected async factoryFromPackagePath() {
+	protected async factoryFromPackagePath(): Promise<IFluidDataStoreFactory> {
 		const packages = this.pkg;
 		if (packages === undefined) {
 			this.rejectDeferredRealize("packages is undefined");
@@ -555,7 +560,7 @@ export abstract class FluidDataStoreContext
 		return created;
 	}
 
-	private async realizeCore(existing: boolean) {
+	private async realizeCore(existing: boolean): Promise<IFluidDataStoreChannel> {
 		const details = await this.getInitialSnapshotDetails();
 		// Base snapshot is the baseline where pending ops are applied to.
 		// It is important that this be in sync with the pending ops, and also
@@ -584,7 +589,7 @@ export abstract class FluidDataStoreContext
 	 * @param clientId - ID of the client. Its old ID when in disconnected state and
 	 * its new client ID when we are connecting or connected.
 	 */
-	public setConnectionState(connected: boolean, clientId?: string) {
+	public setConnectionState(connected: boolean, clientId?: string): void {
 		// ConnectionState should not fail in tombstone mode as this is internally run
 		this.verifyNotClosed("setConnectionState", false /* checkTombstone */);
 
@@ -608,10 +613,8 @@ export abstract class FluidDataStoreContext
 	private processMessagesCompat(
 		channel: IFluidDataStoreChannel,
 		messageCollection: IRuntimeMessageCollection,
-	) {
-		if (channel.processMessages !== undefined) {
-			channel.processMessages(messageCollection);
-		} else {
+	): void {
+		if (channel.processMessages === undefined) {
 			const { envelope, messagesContent, local } = messageCollection;
 			for (const { contents, localOpMetadata, clientSequenceNumber } of messagesContent) {
 				channel.process(
@@ -620,6 +623,8 @@ export abstract class FluidDataStoreContext
 					localOpMetadata,
 				);
 			}
+		} else {
+			channel.processMessages(messageCollection);
 		}
 	}
 
@@ -647,7 +652,7 @@ export abstract class FluidDataStoreContext
 			);
 			this.pendingMessagesState.messageCollections.push({
 				...messageCollection,
-				messagesContent: Array.from(messagesContent),
+				messagesContent: [...messagesContent],
 			});
 			this.pendingMessagesState.pendingCount += messagesContent.length;
 			this.thresholdOpsCounter.sendIfMultiple(
@@ -769,7 +774,7 @@ export abstract class FluidDataStoreContext
 	 *
 	 * @param usedRoutes - The routes that are used in this data store.
 	 */
-	public updateUsedRoutes(usedRoutes: string[]) {
+	public updateUsedRoutes(usedRoutes: string[]): void {
 		// Update the used routes in this data store's summarizer node.
 		this.summarizerNode.updateUsedRoutes(usedRoutes);
 
@@ -794,10 +799,15 @@ export abstract class FluidDataStoreContext
 	 * @param toPath - The absolute path of the outbound node that is referenced.
 	 * @param messageTimestampMs - The timestamp of the message that added the reference.
 	 */
-	public addedGCOutboundRoute(fromPath: string, toPath: string, messageTimestampMs?: number) {
+	public addedGCOutboundRoute(
+		fromPath: string,
+		toPath: string,
+		messageTimestampMs?: number,
+	): void {
 		this.parentContext.addedGCOutboundRoute(fromPath, toPath, messageTimestampMs);
 	}
 
+	// eslint-disable-next-line jsdoc/require-description
 	/**
 	 * @deprecated 0.18.Should call request on the runtime directly
 	 */
@@ -806,7 +816,7 @@ export abstract class FluidDataStoreContext
 		return runtime.request(request);
 	}
 
-	public submitMessage(type: string, content: any, localOpMetadata: unknown): void {
+	public submitMessage(type: string, content: unknown, localOpMetadata: unknown): void {
 		this.verifyNotClosed("submitMessage");
 		assert(!!this.channel, 0x146 /* "Channel must exist when submitting message" */);
 		// Summarizer clients should not submit messages.
@@ -845,7 +855,7 @@ export abstract class FluidDataStoreContext
 	 * @param content - Content of the signal. Should be a JSON serializable object or primitive.
 	 * @param targetClientId - When specified, the signal is only sent to the provided client id.
 	 */
-	public submitSignal(type: string, content: unknown, targetClientId?: string) {
+	public submitSignal(type: string, content: unknown, targetClientId?: string): void {
 		this.verifyNotClosed("submitSignal");
 
 		assert(!!this.channel, 0x147 /* "Channel must exist on submitting signal" */);
@@ -856,12 +866,12 @@ export abstract class FluidDataStoreContext
 	 * This is called by the data store channel when it becomes locally visible indicating that it is ready to become
 	 * globally visible now.
 	 */
-	public makeLocallyVisible() {
+	public makeLocallyVisible(): void {
 		assert(this.channel !== undefined, 0x2cf /* "undefined channel on datastore context" */);
 		this.makeLocallyVisibleFn();
 	}
 
-	protected processPendingOps(channel: IFluidDataStoreChannel) {
+	protected processPendingOps(channel: IFluidDataStoreChannel): void {
 		const baseSequenceNumber = this.baseSnapshotSequenceNumber ?? -1;
 
 		assert(
@@ -879,7 +889,7 @@ export abstract class FluidDataStoreContext
 		this.pendingMessagesState = undefined;
 	}
 
-	protected completeBindingRuntime(channel: IFluidDataStoreChannel) {
+	protected completeBindingRuntime(channel: IFluidDataStoreChannel): void {
 		// And now mark the runtime active
 		this.loaded = true;
 		this.channel = channel;
@@ -895,7 +905,10 @@ export abstract class FluidDataStoreContext
 		Object.freeze(this.pkg);
 	}
 
-	protected async bindRuntime(channel: IFluidDataStoreChannel, existing: boolean) {
+	protected async bindRuntime(
+		channel: IFluidDataStoreChannel,
+		existing: boolean,
+	): Promise<void> {
 		if (this.channel) {
 			throw new Error("Runtime already bound");
 		}
@@ -946,6 +959,7 @@ export abstract class FluidDataStoreContext
 
 	public abstract getInitialSnapshotDetails(): Promise<ISnapshotDetails>;
 
+	// eslint-disable-next-line jsdoc/require-description
 	/**
 	 * @deprecated Sets the datastore as root, for aliasing purposes: #7948
 	 * This method should not be used outside of the aliasing context.
@@ -955,6 +969,7 @@ export abstract class FluidDataStoreContext
 		this._isInMemoryRoot = true;
 	}
 
+	// eslint-disable-next-line jsdoc/require-description
 	/**
 	 * @deprecated The functionality to get base GC details has been moved to summarizer node.
 	 */
@@ -962,12 +977,12 @@ export abstract class FluidDataStoreContext
 		return {};
 	}
 
-	public reSubmit(type: string, contents: any, localOpMetadata: unknown) {
+	public reSubmit(type: string, contents: unknown, localOpMetadata: unknown): void {
 		assert(!!this.channel, 0x14b /* "Channel must exist when resubmitting ops" */);
 		this.channel.reSubmit(type, contents, localOpMetadata);
 	}
 
-	public rollback(type: string, contents: any, localOpMetadata: unknown) {
+	public rollback(type: string, contents: unknown, localOpMetadata: unknown): void {
 		if (!this.channel) {
 			throw new Error("Channel must exist when rolling back ops");
 		}
@@ -977,7 +992,7 @@ export abstract class FluidDataStoreContext
 		this.channel.rollback(type, contents, localOpMetadata);
 	}
 
-	public async applyStashedOp(contents: any): Promise<unknown> {
+	public async applyStashedOp(contents: unknown): Promise<unknown> {
 		if (!this.channel) {
 			await this.realize();
 		}
@@ -989,7 +1004,7 @@ export abstract class FluidDataStoreContext
 		callSite: string,
 		checkTombstone = true,
 		safeTelemetryProps: ITelemetryBaseProperties = {},
-	) {
+	): void {
 		if (this.deleted) {
 			const messageString = `Context is deleted! Call site [${callSite}]`;
 			const error = DataProcessingError.create(
@@ -1038,7 +1053,7 @@ export abstract class FluidDataStoreContext
 	 * eventual consistency. For example, the next summary (say at ref seq# 100) may contain these changes whereas
 	 * other clients that are up-to-date till seq# 100 may not have them yet.
 	 */
-	protected identifyLocalChangeInSummarizer(eventName: string, type?: string) {
+	protected identifyLocalChangeInSummarizer(eventName: string, type?: string): void {
 		if (
 			this.clientDetails.type !== summarizerClientType ||
 			this.localChangesTelemetryCount <= 0
@@ -1065,7 +1080,7 @@ export abstract class FluidDataStoreContext
 		return (
 			summarizeInternal: SummarizeInternalFn,
 			getGCDataFn: (fullGC?: boolean) => Promise<IGarbageCollectionData>,
-		) =>
+		): ISummarizerNodeWithGC =>
 			this.summarizerNode.createChild(
 				summarizeInternal,
 				id,
@@ -1075,7 +1090,7 @@ export abstract class FluidDataStoreContext
 			);
 	}
 
-	public deleteChildSummarizerNode(id: string) {
+	public deleteChildSummarizerNode(id: string): void {
 		this.summarizerNode.deleteChild(id);
 	}
 
@@ -1087,7 +1102,9 @@ export abstract class FluidDataStoreContext
 	}
 }
 
-/** @internal */
+/**
+ * @internal
+ */
 export class RemoteFluidDataStoreContext extends FluidDataStoreContext {
 	// Tells whether we need to fetch the snapshot before use. This is to support Data Virtualization.
 	private snapshotFetchRequired: boolean | undefined;
@@ -1111,18 +1128,23 @@ export class RemoteFluidDataStoreContext extends FluidDataStoreContext {
 		}
 	}
 
-	/*
-	This API should not be called for RemoteFluidDataStoreContext. But here is one scenario where it's not the case:
-	The scenario (hit by stashedOps.spec.ts, "resends attach op" UT is the following (as far as I understand):
-	1. data store is being attached in attached container
-	2. container state is serialized (stashed ops feature)
-	3. new container instance is rehydrated (from stashed ops)
-	    - As result, we create RemoteFluidDataStoreContext for this data store that is actually in "attaching" state (as of # 2).
-		  But its state is set to attached when loading container from stashed ops
-	4. attach op for this data store is processed - setAttachState() is called.
-	*/
-	public setAttachState(attachState: AttachState.Attaching | AttachState.Attached) {}
+	/**
+	 * This API should not be called for RemoteFluidDataStoreContext. But here is one scenario where it's not the case:
+	 * The scenario (hit by stashedOps.spec.ts, "resends attach op" UT is the following (as far as I understand):
+	 *
+	 * 1. data store is being attached in attached container
+	 *
+	 * 2. container state is serialized (stashed ops feature)
+	 *
+	 * 3. new container instance is rehydrated (from stashed ops) -
+	 * As result, we create RemoteFluidDataStoreContext for this data store that is actually in "attaching" state  * (as of # 2).
+	 * But its state is set to attached when loading container from stashed ops.
+	 *
+	 * 4. attach op for this data store is processed - setAttachState() is called.
+	 */
+	public setAttachState(attachState: AttachState.Attaching | AttachState.Attached): void {}
 
+	// eslint-disable-next-line unicorn/consistent-function-scoping -- Property is defined once; no need to extract inner lambda
 	private readonly initialSnapshotDetailsP = new LazyPromise<ISnapshotDetails>(async () => {
 		// Sequence number of the snapshot.
 		let sequenceNumber: number | undefined;
@@ -1218,14 +1240,14 @@ export class RemoteFluidDataStoreContext extends FluidDataStoreContext {
 	}
 
 	/**
-	 * @see FluidDataStoreContext.getAttachSummary
+	 * {@inheritDoc FluidDataStoreContext.getAttachSummary}
 	 */
 	public getAttachSummary(): ISummaryTreeWithStats {
 		throw new Error("Cannot attach remote store");
 	}
 
 	/**
-	 * @see FluidDataStoreContext.getAttachGCData
+	 * {@inheritDoc FluidDataStoreContext.getAttachGCData}
 	 */
 	public getAttachGCData(telemetryContext?: ITelemetryContext): IGarbageCollectionData {
 		throw new Error("Cannot attach remote store");
@@ -1238,10 +1260,6 @@ export class RemoteFluidDataStoreContext extends FluidDataStoreContext {
  */
 export class LocalFluidDataStoreContextBase extends FluidDataStoreContext {
 	private readonly snapshotTree: ISnapshotTree | undefined;
-	/**
-	 * @deprecated 0.16 Issue #1635, #3631
-	 */
-	public readonly createProps?: any;
 
 	constructor(props: ILocalFluidDataStoreContextProps) {
 		super(
@@ -1255,12 +1273,11 @@ export class LocalFluidDataStoreContextBase extends FluidDataStoreContext {
 		this.identifyLocalChangeInSummarizer("DataStoreCreatedInSummarizer");
 
 		this.snapshotTree = props.snapshotTree;
-		this.createProps = props.createProps;
 	}
 
 	public setAttachState(attachState: AttachState.Attaching | AttachState.Attached): void {
 		switch (attachState) {
-			case AttachState.Attaching:
+			case AttachState.Attaching: {
 				assert(
 					this.attachState === AttachState.Detached,
 					0x14d /* "Should move from detached to attaching" */,
@@ -1274,7 +1291,8 @@ export class LocalFluidDataStoreContextBase extends FluidDataStoreContext {
 					this.emit("attaching");
 				}
 				break;
-			case AttachState.Attached:
+			}
+			case AttachState.Attached: {
 				// We can get called into here twice, as result of both container and data store being attached, if
 				// those processes overlapped, for example, in a flow like that one:
 				// 1. Container attach started
@@ -1297,13 +1315,15 @@ export class LocalFluidDataStoreContextBase extends FluidDataStoreContext {
 					}
 				}
 				break;
-			default:
+			}
+			default: {
 				unreachableCase(attachState, "unreached");
+			}
 		}
 	}
 
 	/**
-	 * @see FluidDataStoreContext.getAttachSummary
+	 * {@inheritDoc FluidDataStoreContext.getAttachSummary}
 	 */
 	public getAttachSummary(telemetryContext?: ITelemetryContext): ISummaryTreeWithStats {
 		assert(
@@ -1333,7 +1353,7 @@ export class LocalFluidDataStoreContextBase extends FluidDataStoreContext {
 	}
 
 	/**
-	 * @see FluidDataStoreContext.getAttachGCData
+	 * {@inheritDoc FluidDataStoreContext.getAttachGCData}
 	 */
 	public getAttachGCData(telemetryContext?: ITelemetryContext): IGarbageCollectionData {
 		assert(
@@ -1343,6 +1363,7 @@ export class LocalFluidDataStoreContextBase extends FluidDataStoreContext {
 		return this.channel.getAttachGCData(telemetryContext);
 	}
 
+	// eslint-disable-next-line unicorn/consistent-function-scoping -- Property is defined once; no need to extract inner lambda
 	private readonly initialSnapshotDetailsP = new LazyPromise<ISnapshotDetails>(async () => {
 		let snapshot = this.snapshotTree;
 		// eslint-disable-next-line import/no-deprecated
@@ -1390,7 +1411,7 @@ export class LocalFluidDataStoreContextBase extends FluidDataStoreContext {
 	 * it was unreferenced. Thus the sweeping container should have loaded from a snapshot and thus creating a remote
 	 * context.
 	 */
-	public delete() {
+	public delete(): void {
 		// TODO: GC:Validation - potentially prevent this from happening or asserting. Maybe throw here.
 		this.mc.logger.sendErrorEvent({
 			eventName: "GC_Deleted_DataStore_Unexpected_Delete",
@@ -1477,7 +1498,7 @@ export class LocalDetachedFluidDataStoreContext
 	 *
 	 * If used incorrectly, this function can result in permanent data corruption.
 	 */
-	public unsafe_AttachRuntimeSync(channel: IFluidDataStoreChannel) {
+	public unsafe_AttachRuntimeSync(channel: IFluidDataStoreChannel): IDataStore {
 		this.channelP = Promise.resolve(channel);
 		this.processPendingOps(channel);
 		this.completeBindingRuntime(channel);

package/src/dataStoreContexts.ts

@@ -12,13 +12,17 @@ import {
 
 import { FluidDataStoreContext, LocalFluidDataStoreContext } from "./dataStoreContext.js";
 
-/** @internal */
+/**
+ * @internal
+ */
 export class DataStoreContexts
 	implements Iterable<[string, FluidDataStoreContext]>, IDisposable
 {
 	private readonly notBoundContexts = new Set<string>();
 
-	/** Attached and loaded context proxies */
+	/**
+	 * Attached and loaded context proxies
+	 */
 	private readonly _contexts = new Map<string, FluidDataStoreContext>();
 
 	/**
@@ -30,6 +34,7 @@ export class DataStoreContexts
 	 */
 	private readonly deferredContexts = new Map<string, Deferred<FluidDataStoreContext>>();
 
+	// eslint-disable-next-line unicorn/consistent-function-scoping -- Property is defined once; no need to extract inner lambda
 	private readonly disposeOnce = new Lazy<void>(() => {
 		// close/stop all store contexts
 		for (const [fluidDataStoreId, contextD] of this.deferredContexts) {
@@ -63,20 +68,20 @@ export class DataStoreContexts
 		return this._contexts.size;
 	}
 
-	public get disposed() {
+	public get disposed(): boolean {
 		return this.disposeOnce.evaluated;
 	}
-	public readonly dispose = () => this.disposeOnce.value;
+	public readonly dispose = (): void => this.disposeOnce.value;
 
-	public notBoundLength() {
+	public notBoundLength(): number {
 		return this.notBoundContexts.size;
 	}
 
-	public isNotBound(id: string) {
+	public isNotBound(id: string): boolean {
 		return this.notBoundContexts.has(id);
 	}
 
-	public has(id: string) {
+	public has(id: string): boolean {
 		return this._contexts.has(id);
 	}
 
@@ -98,7 +103,7 @@ export class DataStoreContexts
 	private readonly _recentlyDeletedContexts: Map<string, FluidDataStoreContext | undefined> =
 		new Map();
 
-	public getRecentlyDeletedContext(id: string) {
+	public getRecentlyDeletedContext(id: string): FluidDataStoreContext | undefined {
 		return this._recentlyDeletedContexts.get(id);
 	}
 
@@ -118,7 +123,7 @@ export class DataStoreContexts
 	/**
 	 * Add the given context, marking it as to-be-bound
 	 */
-	public addUnbound(context: LocalFluidDataStoreContext) {
+	public addUnbound(context: LocalFluidDataStoreContext): void {
 		const id = context.id;
 		assert(!this._contexts.has(id), 0x158 /* "Creating store with existing ID" */);
 
@@ -161,7 +166,7 @@ export class DataStoreContexts
 	/**
 	 * Update this context as bound
 	 */
-	public bind(id: string) {
+	public bind(id: string): void {
 		const removed: boolean = this.notBoundContexts.delete(id);
 		assert(removed, 0x159 /* "The given id was not found in notBoundContexts to delete" */);
 
@@ -172,7 +177,7 @@ export class DataStoreContexts
 	 * Triggers the deferred to resolve, indicating the context is not local-only
 	 * @param id - The id of the context to resolve to
 	 */
-	private resolveDeferred(id: string) {
+	private resolveDeferred(id: string): void {
 		const context = this._contexts.get(id);
 		assert(!!context, 0x15a /* "Cannot find context to resolve to" */);
 		assert(
@@ -190,7 +195,7 @@ export class DataStoreContexts
 	 * This could be because it's a local context that's been bound, or because it's a remote context.
 	 * @param context - The context to add
 	 */
-	public addBoundOrRemoted(context: FluidDataStoreContext) {
+	public addBoundOrRemoted(context: FluidDataStoreContext): void {
 		const id = context.id;
 		assert(!this._contexts.has(id), 0x15d /* "Creating store with existing ID" */);