@flint.fyi/ts 0.14.6 → 0.18.0

package/src/rules/emptyStaticBlocks.test.ts

@@ -1,168 +0,0 @@
-import rule from "./emptyStaticBlocks.js";
-import { ruleTester } from "./ruleTester.js";
-
-ruleTester.describe(rule, {
-	invalid: [
-		{
-			code: `
-class Example {
-    static {
-    }
-}
-`,
-			snapshot: `
-class Example {
-    static {
-    ~~~~~~~~
-    Empty static blocks serve no purpose and should be removed for cleaner code.
-    }
-}
-`,
-			suggestions: [
-				{
-					id: "removeEmptyStaticBlock",
-					updated: `
-class Example {
-    
-}
-`,
-				},
-			],
-		},
-		{
-			code: `
-class Example {
-    static {
-
-
-    }
-}
-`,
-			snapshot: `
-class Example {
-    static {
-    ~~~~~~~~
-    Empty static blocks serve no purpose and should be removed for cleaner code.
-
-
-    }
-}
-`,
-			suggestions: [
-				{
-					id: "removeEmptyStaticBlock",
-					updated: `
-class Example {
-    
-}
-`,
-				},
-			],
-		},
-		{
-			code: `
-class Multiple {
-    static property = 1;
-    
-    static {
-    }
-    
-    method() {}
-}
-`,
-			snapshot: `
-class Multiple {
-    static property = 1;
-    
-    static {
-    ~~~~~~~~
-    Empty static blocks serve no purpose and should be removed for cleaner code.
-    }
-    
-    method() {}
-}
-`,
-			suggestions: [
-				{
-					id: "removeEmptyStaticBlock",
-					updated: `
-class Multiple {
-    static property = 1;
-    
-    
-    
-    method() {}
-}
-`,
-				},
-			],
-		},
-		{
-			code: `
-class MultipleBlocks {
-    static {
-        console.log("first");
-    }
-    
-    static {
-    }
-}
-`,
-			snapshot: `
-class MultipleBlocks {
-    static {
-        console.log("first");
-    }
-    
-    static {
-    ~~~~~~~~
-    Empty static blocks serve no purpose and should be removed for cleaner code.
-    }
-}
-`,
-			suggestions: [
-				{
-					id: "removeEmptyStaticBlock",
-					updated: `
-class MultipleBlocks {
-    static {
-        console.log("first");
-    }
-    
-    
-}
-`,
-				},
-			],
-		},
-	],
-	valid: [
-		`class Example { static property = 1; }`,
-		`class Example { static method() {} }`,
-		`
-class Example {
-    static {
-        console.log("initialization");
-    }
-}
-`,
-		`
-class Example {
-    static {
-        this.property = 1;
-    }
-}
-`,
-		`
-class Multiple {
-    static {
-        console.log("first");
-    }
-    
-    static {
-        console.log("second");
-    }
-}
-`,
-	],
-});

package/src/rules/emptyStaticBlocks.ts

@@ -1,60 +0,0 @@
-import { typescriptLanguage } from "../language.js";
-
-export default typescriptLanguage.createRule({
-	about: {
-		description:
-			"Reports empty static initialization blocks within class declarations.",
-		id: "emptyStaticBlocks",
-		preset: "stylistic",
-	},
-	messages: {
-		emptyStaticBlock: {
-			primary:
-				"Empty static blocks serve no purpose and should be removed for cleaner code.",
-			secondary: [
-				"Static blocks are used to initialize static class properties or perform other one-time setup when a class is loaded.",
-				"An empty static block has no statements and therefore serves no purpose.",
-			],
-			suggestions: [
-				"Remove the empty static block, or add initialization logic if needed.",
-			],
-		},
-	},
-	setup(context) {
-		return {
-			visitors: {
-				ClassStaticBlockDeclaration: (node) => {
-					const statements = node.body.statements;
-					if (statements.length) {
-						return;
-					}
-
-					const openBrace = node.body.getFirstToken(context.sourceFile);
-					if (!openBrace) {
-						return;
-					}
-
-					const range = {
-						begin: node.getStart(context.sourceFile),
-						end: openBrace.getEnd(),
-					};
-
-					context.report({
-						message: "emptyStaticBlock",
-						range,
-						suggestions: [
-							{
-								id: "removeEmptyStaticBlock",
-								range: {
-									begin: node.getStart(context.sourceFile),
-									end: node.getEnd(),
-								},
-								text: "",
-							},
-						],
-					});
-				},
-			},
-		};
-	},
-});

package/src/rules/exceptionAssignments.test.ts

@@ -1,265 +0,0 @@
-import rule from "./exceptionAssignments.js";
-import { ruleTester } from "./ruleTester.js";
-
-ruleTester.describe(rule, {
-	invalid: [
-		{
-			code: `
-try {
-    doSomething();
-} catch (error) {
-    error = new Error("Different error");
-}
-`,
-			snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    error = new Error("Different error");
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-		},
-		{
-			code: `
-try {
-    doSomething();
-} catch (exception) {
-    exception = null;
-}
-`,
-			snapshot: `
-try {
-    doSomething();
-} catch (exception) {
-    exception = null;
-    ~~~~~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-		},
-		{
-			code: `
-try {
-    doSomething();
-} catch (error) {
-    error++;
-}
-`,
-			snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    error++;
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-		},
-		{
-			code: `
-try {
-    doSomething();
-} catch (error) {
-    ++error;
-}
-`,
-			snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    ++error;
-      ~~~~~
-      Exception parameters in catch clauses should not be reassigned.
-}
-`,
-		},
-		{
-			code: `
-try {
-    doSomething();
-} catch (error) {
-    error += "additional info";
-}
-`,
-			snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    error += "additional info";
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-		},
-		{
-			code: `
-try {
-    doSomething();
-} catch (error) {
-    error ??= new Error("default error");
-}
-`,
-			snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    error ??= new Error("default error");
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-		},
-		{
-			code: `
-try {
-    doSomething();
-} catch (error) {
-    error &&= false;
-}
-`,
-			snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    error &&= false;
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-		},
-		{
-			code: `
-try {
-    doSomething();
-} catch (error) {
-    error ||= new Error("fallback");
-}
-`,
-			snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    error ||= new Error("fallback");
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-		},
-		{
-			code: `
-try {
-    doSomething();
-} catch (error) {
-    function inner() {
-        error = "reassigned in nested function";
-    }
-}
-`,
-			snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    function inner() {
-        error = "reassigned in nested function";
-        ~~~~~
-        Exception parameters in catch clauses should not be reassigned.
-    }
-}
-`,
-		},
-		{
-			code: `
-try {
-    doSomething();
-} catch ({ message }) {
-    message = "reassigned destructured parameter";
-}
-`,
-			snapshot: `
-try {
-    doSomething();
-} catch ({ message }) {
-    message = "reassigned destructured parameter";
-    ~~~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-		},
-		{
-			code: `
-try {
-    doSomething();
-} catch ({ message, code }) {
-    code = 500;
-}
-`,
-			snapshot: `
-try {
-    doSomething();
-} catch ({ message, code }) {
-    code = 500;
-    ~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-		},
-		{
-			code: `
-try {
-    doSomething();
-} catch ([first, second]) {
-    first = "reassigned array destructured parameter";
-}
-`,
-			snapshot: `
-try {
-    doSomething();
-} catch ([first, second]) {
-    first = "reassigned array destructured parameter";
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-		},
-	],
-	valid: [
-		`try { doSomething(); } catch (error) { console.log(error); }`,
-		`try { doSomething(); } catch (error) { throw error; }`,
-		`try { doSomething(); } catch (error) { const message = error.message; }`,
-		`try { doSomething(); } catch (error) { if (error instanceof TypeError) { handle(); } }`,
-		`try { doSomething(); } catch { handleError(); }`,
-		`const error = new Error("test");`,
-		`
-try {
-    doSomething();
-} catch (error) {
-    const error = "shadowed variable";
-    console.log(error);
-}
-`,
-		`
-try {
-    doSomething();
-} catch (error) {
-    function inner() {
-        const error = "shadowed in function";
-        error = "reassigning shadowed variable is ok";
-    }
-}
-`,
-		`
-let error = "outer";
-try {
-    doSomething();
-} catch (error) {
-    console.log(error);
-}
-error = "reassigning outer is ok";
-`,
-		`try { doSomething(); } catch ({ message }) { console.log(message); }`,
-		`try { doSomething(); } catch ({ message, code }) { if (code === 404) { handle(); } }`,
-		`try { doSomething(); } catch ([first]) { console.log(first); }`,
-	],
-});

package/src/rules/exceptionAssignments.ts

@@ -1,77 +0,0 @@
-import * as ts from "typescript";
-
-import { typescriptLanguage } from "../language.js";
-import { getModifyingReferences } from "../utils/getModifyingReferences.js";
-
-export default typescriptLanguage.createRule({
-	about: {
-		description: "Reports reassigning exception parameters in catch clauses.",
-		id: "exceptionAssignments",
-		preset: "logical",
-	},
-	messages: {
-		noExAssign: {
-			primary:
-				"Exception parameters in catch clauses should not be reassigned.",
-			secondary: [
-				"Reassigning an exception parameter can make debugging more difficult by obscuring the original error.",
-				"The exception parameter contains important information about what went wrong, and reassigning it can make it harder to understand the root cause of an error.",
-			],
-			suggestions: [
-				"Use a different variable name for the new value instead of reassigning the exception parameter.",
-			],
-		},
-	},
-	setup(context) {
-		function collectBindingElements(name: ts.BindingName): ts.Identifier[] {
-			const identifiers: ts.Identifier[] = [];
-
-			if (ts.isIdentifier(name)) {
-				identifiers.push(name);
-			} else if (
-				ts.isObjectBindingPattern(name) ||
-				ts.isArrayBindingPattern(name)
-			) {
-				for (const element of name.elements) {
-					if (ts.isBindingElement(element)) {
-						identifiers.push(...collectBindingElements(element.name));
-					}
-				}
-			}
-
-			return identifiers;
-		}
-
-		return {
-			visitors: {
-				CatchClause: (node) => {
-					if (!node.variableDeclaration?.name) {
-						return;
-					}
-
-					const identifiers = collectBindingElements(
-						node.variableDeclaration.name,
-					);
-
-					for (const identifier of identifiers) {
-						const modifyingReferences = getModifyingReferences(
-							identifier,
-							context.sourceFile,
-							context.typeChecker,
-						);
-
-						for (const reference of modifyingReferences) {
-							context.report({
-								message: "noExAssign",
-								range: {
-									begin: reference.getStart(context.sourceFile),
-									end: reference.getEnd(),
-								},
-							});
-						}
-					}
-				},
-			},
-		};
-	},
-});

package/src/rules/forDirections.test.ts

@@ -1,125 +0,0 @@
-import rule from "./forDirections.js";
-import { ruleTester } from "./ruleTester.js";
-
-ruleTester.describe(rule, {
-	invalid: [
-		{
-			code: `
-for (let i = 0; i < 10; i--) {}
-`,
-			snapshot: `
-for (let i = 0; i < 10; i--) {}
-                        ~~~
-                        The update moves the counter in the wrong direction for this loop condition.
-`,
-		},
-		{
-			code: `
-for (let index = 0; index < 10; index--) {}
-`,
-			snapshot: `
-for (let index = 0; index < 10; index--) {}
-                                ~~~~~~~
-                                The update moves the counter in the wrong direction for this loop condition.
-`,
-		},
-		{
-			code: `
-for (let index = 10; index >= 0; index++) {}
-`,
-			snapshot: `
-for (let index = 10; index >= 0; index++) {}
-                                 ~~~~~~~
-                                 The update moves the counter in the wrong direction for this loop condition.
-`,
-		},
-		{
-			code: `
-for (let index = 0; index > 10; index++) {}
-`,
-			snapshot: `
-for (let index = 0; index > 10; index++) {}
-                                ~~~~~~~
-                                The update moves the counter in the wrong direction for this loop condition.
-`,
-		},
-		{
-			code: `
-for (let index = 0; 10 > index; index--) {}
-`,
-			snapshot: `
-for (let index = 0; 10 > index; index--) {}
-                                ~~~~~~~
-                                The update moves the counter in the wrong direction for this loop condition.
-`,
-		},
-		{
-			code: `
-for (let index = 0; index < 10; index -= 1) {}
-`,
-			snapshot: `
-for (let index = 0; index < 10; index -= 1) {}
-                                ~~~~~~~~~~
-                                The update moves the counter in the wrong direction for this loop condition.
-`,
-		},
-		{
-			code: `
-for (let index = 10; index > 0; index += 1) {}
-`,
-			snapshot: `
-for (let index = 10; index > 0; index += 1) {}
-                                ~~~~~~~~~~
-                                The update moves the counter in the wrong direction for this loop condition.
-`,
-		},
-		{
-			code: `
-for (let index = 0; index < 10; index += -1) {}
-`,
-			snapshot: `
-for (let index = 0; index < 10; index += -1) {}
-                                ~~~~~~~~~~~
-                                The update moves the counter in the wrong direction for this loop condition.
-`,
-		},
-		{
-			code: `
-declare context text: string;
-for (let i = 10; i >= 0 && text[i] !== " "; i++) { }
-`,
-			snapshot: `
-declare context text: string;
-for (let i = 10; i >= 0 && text[i] !== " "; i++) { }
-                                            ~~~
-                                            The update moves the counter in the wrong direction for this loop condition.
-`,
-		},
-		{
-			code: `
-declare context text: string;
-for (let i = 10; text[i] !== " " && i >= 0; i++) { }
-`,
-			snapshot: `
-declare context text: string;
-for (let i = 10; text[i] !== " " && i >= 0; i++) { }
-                                            ~~~
-                                            The update moves the counter in the wrong direction for this loop condition.
-`,
-		},
-	],
-	valid: [
-		`for (let i = 0; i < 10; i++) { }`,
-		`for (let index = 0; index < 10; index++) { }`,
-		`for (let index = 10; index >= 0; index--) { }`,
-		`for (let index = 0; 10 > index; index++) { }`,
-		`for (let index = 10; 0 < index; index--) { }`,
-		`for (let index = 10; index >= 0; index += step) { }`,
-		`for (let index = 0; index <= 10; index -= 0) { }`,
-		`for (let index = 0; index < 10; index += 1) { }`,
-		`for (let index = 10; index > 0; index -= 1) { }`,
-		`for (let index = 0; index < 10; index += 2) { }`,
-		`for (let index = 10; index > 0; index -= 2) { }`,
-		`for (let i = 10; i >= 0 && text[i] === "\\"; i--) { }`,
-	],
-});