@flint.fyi/ts 0.14.6 → 0.18.0

package/lib/rules/exceptionAssignments.test.js

@@ -1,264 +0,0 @@
-import rule from "./exceptionAssignments.js";
-import { ruleTester } from "./ruleTester.js";
-ruleTester.describe(rule, {
-    invalid: [
-        {
-            code: `
-try {
-    doSomething();
-} catch (error) {
-    error = new Error("Different error");
-}
-`,
-            snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    error = new Error("Different error");
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-        },
-        {
-            code: `
-try {
-    doSomething();
-} catch (exception) {
-    exception = null;
-}
-`,
-            snapshot: `
-try {
-    doSomething();
-} catch (exception) {
-    exception = null;
-    ~~~~~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-        },
-        {
-            code: `
-try {
-    doSomething();
-} catch (error) {
-    error++;
-}
-`,
-            snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    error++;
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-        },
-        {
-            code: `
-try {
-    doSomething();
-} catch (error) {
-    ++error;
-}
-`,
-            snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    ++error;
-      ~~~~~
-      Exception parameters in catch clauses should not be reassigned.
-}
-`,
-        },
-        {
-            code: `
-try {
-    doSomething();
-} catch (error) {
-    error += "additional info";
-}
-`,
-            snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    error += "additional info";
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-        },
-        {
-            code: `
-try {
-    doSomething();
-} catch (error) {
-    error ??= new Error("default error");
-}
-`,
-            snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    error ??= new Error("default error");
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-        },
-        {
-            code: `
-try {
-    doSomething();
-} catch (error) {
-    error &&= false;
-}
-`,
-            snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    error &&= false;
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-        },
-        {
-            code: `
-try {
-    doSomething();
-} catch (error) {
-    error ||= new Error("fallback");
-}
-`,
-            snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    error ||= new Error("fallback");
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-        },
-        {
-            code: `
-try {
-    doSomething();
-} catch (error) {
-    function inner() {
-        error = "reassigned in nested function";
-    }
-}
-`,
-            snapshot: `
-try {
-    doSomething();
-} catch (error) {
-    function inner() {
-        error = "reassigned in nested function";
-        ~~~~~
-        Exception parameters in catch clauses should not be reassigned.
-    }
-}
-`,
-        },
-        {
-            code: `
-try {
-    doSomething();
-} catch ({ message }) {
-    message = "reassigned destructured parameter";
-}
-`,
-            snapshot: `
-try {
-    doSomething();
-} catch ({ message }) {
-    message = "reassigned destructured parameter";
-    ~~~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-        },
-        {
-            code: `
-try {
-    doSomething();
-} catch ({ message, code }) {
-    code = 500;
-}
-`,
-            snapshot: `
-try {
-    doSomething();
-} catch ({ message, code }) {
-    code = 500;
-    ~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-        },
-        {
-            code: `
-try {
-    doSomething();
-} catch ([first, second]) {
-    first = "reassigned array destructured parameter";
-}
-`,
-            snapshot: `
-try {
-    doSomething();
-} catch ([first, second]) {
-    first = "reassigned array destructured parameter";
-    ~~~~~
-    Exception parameters in catch clauses should not be reassigned.
-}
-`,
-        },
-    ],
-    valid: [
-        `try { doSomething(); } catch (error) { console.log(error); }`,
-        `try { doSomething(); } catch (error) { throw error; }`,
-        `try { doSomething(); } catch (error) { const message = error.message; }`,
-        `try { doSomething(); } catch (error) { if (error instanceof TypeError) { handle(); } }`,
-        `try { doSomething(); } catch { handleError(); }`,
-        `const error = new Error("test");`,
-        `
-try {
-    doSomething();
-} catch (error) {
-    const error = "shadowed variable";
-    console.log(error);
-}
-`,
-        `
-try {
-    doSomething();
-} catch (error) {
-    function inner() {
-        const error = "shadowed in function";
-        error = "reassigning shadowed variable is ok";
-    }
-}
-`,
-        `
-let error = "outer";
-try {
-    doSomething();
-} catch (error) {
-    console.log(error);
-}
-error = "reassigning outer is ok";
-`,
-        `try { doSomething(); } catch ({ message }) { console.log(message); }`,
-        `try { doSomething(); } catch ({ message, code }) { if (code === 404) { handle(); } }`,
-        `try { doSomething(); } catch ([first]) { console.log(first); }`,
-    ],
-});

package/lib/rules/forDirections.test.d.ts

@@ -1 +0,0 @@
-export {};

package/lib/rules/forDirections.test.js

@@ -1,124 +0,0 @@
-import rule from "./forDirections.js";
-import { ruleTester } from "./ruleTester.js";
-ruleTester.describe(rule, {
-    invalid: [
-        {
-            code: `
-for (let i = 0; i < 10; i--) {}
-`,
-            snapshot: `
-for (let i = 0; i < 10; i--) {}
-                        ~~~
-                        The update moves the counter in the wrong direction for this loop condition.
-`,
-        },
-        {
-            code: `
-for (let index = 0; index < 10; index--) {}
-`,
-            snapshot: `
-for (let index = 0; index < 10; index--) {}
-                                ~~~~~~~
-                                The update moves the counter in the wrong direction for this loop condition.
-`,
-        },
-        {
-            code: `
-for (let index = 10; index >= 0; index++) {}
-`,
-            snapshot: `
-for (let index = 10; index >= 0; index++) {}
-                                 ~~~~~~~
-                                 The update moves the counter in the wrong direction for this loop condition.
-`,
-        },
-        {
-            code: `
-for (let index = 0; index > 10; index++) {}
-`,
-            snapshot: `
-for (let index = 0; index > 10; index++) {}
-                                ~~~~~~~
-                                The update moves the counter in the wrong direction for this loop condition.
-`,
-        },
-        {
-            code: `
-for (let index = 0; 10 > index; index--) {}
-`,
-            snapshot: `
-for (let index = 0; 10 > index; index--) {}
-                                ~~~~~~~
-                                The update moves the counter in the wrong direction for this loop condition.
-`,
-        },
-        {
-            code: `
-for (let index = 0; index < 10; index -= 1) {}
-`,
-            snapshot: `
-for (let index = 0; index < 10; index -= 1) {}
-                                ~~~~~~~~~~
-                                The update moves the counter in the wrong direction for this loop condition.
-`,
-        },
-        {
-            code: `
-for (let index = 10; index > 0; index += 1) {}
-`,
-            snapshot: `
-for (let index = 10; index > 0; index += 1) {}
-                                ~~~~~~~~~~
-                                The update moves the counter in the wrong direction for this loop condition.
-`,
-        },
-        {
-            code: `
-for (let index = 0; index < 10; index += -1) {}
-`,
-            snapshot: `
-for (let index = 0; index < 10; index += -1) {}
-                                ~~~~~~~~~~~
-                                The update moves the counter in the wrong direction for this loop condition.
-`,
-        },
-        {
-            code: `
-declare context text: string;
-for (let i = 10; i >= 0 && text[i] !== " "; i++) { }
-`,
-            snapshot: `
-declare context text: string;
-for (let i = 10; i >= 0 && text[i] !== " "; i++) { }
-                                            ~~~
-                                            The update moves the counter in the wrong direction for this loop condition.
-`,
-        },
-        {
-            code: `
-declare context text: string;
-for (let i = 10; text[i] !== " " && i >= 0; i++) { }
-`,
-            snapshot: `
-declare context text: string;
-for (let i = 10; text[i] !== " " && i >= 0; i++) { }
-                                            ~~~
-                                            The update moves the counter in the wrong direction for this loop condition.
-`,
-        },
-    ],
-    valid: [
-        `for (let i = 0; i < 10; i++) { }`,
-        `for (let index = 0; index < 10; index++) { }`,
-        `for (let index = 10; index >= 0; index--) { }`,
-        `for (let index = 0; 10 > index; index++) { }`,
-        `for (let index = 10; 0 < index; index--) { }`,
-        `for (let index = 10; index >= 0; index += step) { }`,
-        `for (let index = 0; index <= 10; index -= 0) { }`,
-        `for (let index = 0; index < 10; index += 1) { }`,
-        `for (let index = 10; index > 0; index -= 1) { }`,
-        `for (let index = 0; index < 10; index += 2) { }`,
-        `for (let index = 10; index > 0; index -= 2) { }`,
-        `for (let i = 10; i >= 0 && text[i] === "\\"; i--) { }`,
-    ],
-});

package/lib/rules/forInArrays.test.d.ts

@@ -1 +0,0 @@
-export {};

package/lib/rules/forInArrays.test.js

@@ -1,24 +0,0 @@
-import rule from "./forInArrays.js";
-import { ruleTester } from "./ruleTester.js";
-ruleTester.describe(rule, {
-    invalid: [
-        {
-            code: `
-declare const array: string[];
-for (const i in array) {}
-`,
-            snapshot: `
-declare const array: string[];
-for (const i in array) {}
-~~~~~~~~~~~~~~~~~~~~~~
-For-in loops over arrays have surprising behavior that often leads to bugs.
-`,
-        },
-    ],
-    valid: [
-        `
-declare const array: string[];
-for (const i of array) {}
-`,
-    ],
-});

package/lib/rules/functionAssignments.test.d.ts

@@ -1 +0,0 @@
-export {};

package/lib/rules/functionAssignments.test.js

@@ -1,209 +0,0 @@
-import rule from "./functionAssignments.js";
-import { ruleTester } from "./ruleTester.js";
-ruleTester.describe(rule, {
-    invalid: [
-        {
-            code: `
-function myFunction() {}
-myFunction = function() {};
-`,
-            snapshot: `
-function myFunction() {}
-myFunction = function() {};
-~~~~~~~~~~
-Variables declared with function declarations should not be reassigned.
-`,
-        },
-        {
-            code: `
-function myFunction() {}
-myFunction = 123;
-`,
-            snapshot: `
-function myFunction() {}
-myFunction = 123;
-~~~~~~~~~~
-Variables declared with function declarations should not be reassigned.
-`,
-        },
-        {
-            code: `
-function myFunction() {}
-myFunction += 1;
-`,
-            snapshot: `
-function myFunction() {}
-myFunction += 1;
-~~~~~~~~~~
-Variables declared with function declarations should not be reassigned.
-`,
-        },
-        {
-            code: `
-function myFunction() {}
-myFunction++;
-`,
-            snapshot: `
-function myFunction() {}
-myFunction++;
-~~~~~~~~~~
-Variables declared with function declarations should not be reassigned.
-`,
-        },
-        {
-            code: `
-function myFunction() {}
-++myFunction;
-`,
-            snapshot: `
-function myFunction() {}
-++myFunction;
-  ~~~~~~~~~~
-  Variables declared with function declarations should not be reassigned.
-`,
-        },
-        {
-            code: `
-function myFunction() {
-    return 42;
-}
-myFunction = () => 100;
-`,
-            snapshot: `
-function myFunction() {
-    return 42;
-}
-myFunction = () => 100;
-~~~~~~~~~~
-Variables declared with function declarations should not be reassigned.
-`,
-        },
-        {
-            code: `
-function outer() {
-    function inner() {}
-    inner = function() {};
-}
-`,
-            snapshot: `
-function outer() {
-    function inner() {}
-    inner = function() {};
-    ~~~~~
-    Variables declared with function declarations should not be reassigned.
-}
-`,
-        },
-        {
-            code: `
-function myFunction() {}
-if (condition) {
-    myFunction = null;
-}
-`,
-            snapshot: `
-function myFunction() {}
-if (condition) {
-    myFunction = null;
-    ~~~~~~~~~~
-    Variables declared with function declarations should not be reassigned.
-}
-`,
-        },
-        {
-            code: `
-function getValue() {
-    return 1;
-}
-getValue ??= function() { return 0; };
-`,
-            snapshot: `
-function getValue() {
-    return 1;
-}
-getValue ??= function() { return 0; };
-~~~~~~~~
-Variables declared with function declarations should not be reassigned.
-`,
-        },
-        {
-            code: `
-function getValue() {
-    return true;
-}
-getValue &&= false;
-`,
-            snapshot: `
-function getValue() {
-    return true;
-}
-getValue &&= false;
-~~~~~~~~
-Variables declared with function declarations should not be reassigned.
-`,
-        },
-        {
-            code: `
-function getValue() {
-    return false;
-}
-getValue ||= () => true;
-`,
-            snapshot: `
-function getValue() {
-    return false;
-}
-getValue ||= () => true;
-~~~~~~~~
-Variables declared with function declarations should not be reassigned.
-`,
-        },
-        {
-            code: `
-function calculate(value: number): number {
-    return value * 2;
-}
-calculate = (value: number) => value * 3;
-`,
-            snapshot: `
-function calculate(value: number): number {
-    return value * 2;
-}
-calculate = (value: number) => value * 3;
-~~~~~~~~~
-Variables declared with function declarations should not be reassigned.
-`,
-        },
-    ],
-    valid: [
-        `function myFunction() { return 42; }`,
-        `function myFunction() {} const result = myFunction();`,
-        `const myFunction = function() {}; myFunction = () => {};`,
-        `const myFunction = () => {}; myFunction = function() {};`,
-        `let myFunction = function() {}; myFunction = () => {};`,
-        `function outer() { const inner = function() {}; inner = () => {}; }`,
-        `
-function outer() {
-    const myFunction = "shadowed variable";
-    myFunction = "reassigning shadowed variable is ok";
-}
-`,
-        `
-let myFunction = "outer variable";
-function scope() {
-    function myFunction() {}
-    console.log(myFunction);
-}
-myFunction = "reassigning outer is ok";
-`,
-        `function myFunction() {} const copy = myFunction;`,
-        `function myFunction() {} if (condition) { callWith(myFunction); }`,
-        `
-function myFunction() {
-    return function nested() {
-        return 42;
-    };
-}
-`,
-    ],
-});

package/lib/rules/functionNewCalls.test.d.ts

@@ -1 +0,0 @@
-export {};