@fitlab-ai/agent-infra 0.6.5 → 0.7.1

package/templates/.agents/workflows/feature-development.en.yaml

@@ -1,33 +1,62 @@
-# Feature Development Workflow
+# Feature development workflow
 # Use this workflow when implementing a new feature.
+#
+# Note: a step's `pr_tasks` list is counted toward workflow progress only when
+# `.agents/.airc.json:requiresPullRequest !== false` (see .agents/skills/complete-task/SKILL.md).
 
 name: feature-development
 description: End-to-end workflow for developing a new feature.
 
 steps:
   - name: analysis
-    description: Analyze feature requirements, explore the codebase, and identify impacted areas.
+    description: Analyze feature requirements, explore the codebase, and identify affected areas.
     recommended_agents:
       - claude
       - gemini
     tasks:
       - Read and understand the feature requirements
       - Explore the codebase to identify relevant files and modules
-      - Identify dependencies and potentially impacted areas
-      - Record findings in the task file
+      - Identify dependencies and potential impact areas
+      - Record findings in the task workspace
     inputs:
-      - Feature requirements or issue description
+      - Feature request or Issue description
       - Project codebase
     artifact_versioning:
       outputs:
         - name: analysis
           pattern: "analysis.md | analysis-r{N}.md"
-          rule: "Scan existing analysis artifacts; create analysis.md for the first round, then analysis-r{N}.md for later revisions (N = current highest round + 1)"
+          rule: "Scan existing analysis artifacts; create analysis.md for round 1 and analysis-r{N}.md for later revisions (N = current highest round + 1)"
     outputs:
-      - Updated task file (analysis section)
-      - List of impacted files
+      - Requirement analysis report
+      - Affected files list
       - Identified risks or constraints
 
+  - name: analysis-review
+    description: Review whether the requirement analysis is complete, verifiable, and clearly scoped.
+    recommended_agents:
+      - claude
+      - gemini
+    tasks:
+      - Check requirement scope, constraints, and acceptance criteria
+      - Verify affected areas and risk identification
+      - Confirm the analysis is ready for design
+      - Create the requirement analysis review report
+    inputs:
+      - Latest requirement analysis report
+      - Original request or Issue description
+    artifact_versioning:
+      inputs:
+        - name: analysis
+          pattern: "analysis.md | analysis-r{N}.md"
+          rule: "Read the highest-round analysis artifact as review input"
+      outputs:
+        - name: review-analysis
+          pattern: "review-analysis.md | review-analysis-r{N}.md"
+          rule: "Scan existing requirement-analysis review artifacts; create review-analysis.md for round 1 and review-analysis-r{N}.md for later rounds (N = current highest round + 1)"
+    outputs:
+      - Requirement analysis review report
+      - Findings to fix, if any
+
   - name: design
     description: Create the technical design for the feature implementation.
     recommended_agents:
@@ -36,115 +65,131 @@ steps:
     tasks:
       - Define interfaces and data structures
       - Outline the implementation approach
-      - Identify edge cases and error-handling strategies
-      - Record the design in the task file
+      - Identify edge cases and error-handling strategy
+      - Record the design in the task workspace
     inputs:
-      - Analysis results from the previous step
+      - Approved requirement analysis
       - Project architecture and conventions
     artifact_versioning:
       inputs:
         - name: analysis
           pattern: "analysis.md | analysis-r{N}.md"
           rule: "Read the highest-round analysis artifact as design input"
+        - name: review-analysis
+          pattern: "review-analysis.md | review-analysis-r{N}.md"
+          rule: "Read the highest-round analysis review artifact and confirm feedback is approved or handled"
       outputs:
         - name: plan
           pattern: "plan.md | plan-r{N}.md"
-          rule: "Scan existing plan artifacts; create plan.md for the first round, then plan-r{N}.md for later revisions (N = current highest round + 1)"
+          rule: "Scan existing plan artifacts; create plan.md for round 1 and plan-r{N}.md for later revisions (N = current highest round + 1)"
     outputs:
-      - Updated task file (design section)
+      - Technical plan
       - Interface definitions
       - Implementation plan
 
-  - name: implementation
-    description: Implement the feature according to the design plan.
+  - name: design-review
+    description: Review whether the technical design is implementable, low-risk, and requirement-complete.
+    recommended_agents:
+      - claude
+      - gemini
+    tasks:
+      - Verify the plan covers the approved analysis
+      - Check architecture fit, risks, and test strategy
+      - Confirm the plan is ready for coding
+      - Create the plan review report
+    inputs:
+      - Latest technical plan
+      - Latest requirement analysis and review report
+    artifact_versioning:
+      inputs:
+        - name: plan
+          pattern: "plan.md | plan-r{N}.md"
+          rule: "Read the highest-round plan artifact as review input"
+      outputs:
+        - name: review-plan
+          pattern: "review-plan.md | review-plan-r{N}.md"
+          rule: "Scan existing plan review artifacts; create review-plan.md for round 1 and review-plan-r{N}.md for later rounds (N = current highest round + 1)"
+    outputs:
+      - Plan review report
+      - Findings to fix, if any
+
+  - name: code
+    description: Implement the approved plan; run the same stage again after code review to handle fixes.
     recommended_agents:
       - codex
       - cursor
     tasks:
       - Create a feature branch
-      - Implement the feature code
+      - Implement feature code
       - Write unit tests
       - Write integration tests when applicable
-      - Ensure the code follows project conventions
+      - Fix findings from the latest code-review artifact when in fix mode
+      - Ensure code follows project conventions
     inputs:
-      - Technical design from the previous step
+      - Approved technical design
       - Project coding standards
+      - Latest code review report when in fix mode
     artifact_versioning:
+      inputs:
+        - name: plan
+          pattern: "plan.md | plan-r{N}.md"
+          rule: "Read the highest-round plan artifact as implementation input"
+        - name: review-plan
+          pattern: "review-plan.md | review-plan-r{N}.md"
+          rule: "Read the highest-round plan review artifact and confirm feedback is approved or handled"
+        - name: review-code
+          pattern: "review-code.md | review-code-r{N}.md"
+          rule: "In fix mode, read the highest-round code review artifact and verify it matches the latest Code Review entry in task.md Activity Log"
       outputs:
-        - name: implementation
-          pattern: "implementation.md | implementation-r{N}.md"
-          rule: "Scan existing implementation artifacts; create implementation.md for the first round, then implementation-r{N}.md for later re-implementations (N = current highest round + 1)"
+        - name: code
+          pattern: "code.md | code-r{N}.md"
+          rule: "Scan existing code artifacts; create code.md for round 1 and code-r{N}.md for later fixes or reimplementation (N = current highest round + 1)"
     outputs:
-      - Feature branch with the implementation
+      - Feature branch with implementation or fixes
       - Test files
-      - Updated task file (implementation notes)
+      - Updated task notes
 
-  - name: review
-    description: Review correctness, code style, and best practices in the implementation.
+  - name: code-review
+    description: Review implementation correctness, style, and best practices.
     recommended_agents:
       - claude
     tasks:
-      - Review the correctness of the code changes
-      - Check adherence to project conventions
+      - Review code changes for correctness
+      - Check project convention compliance
       - Verify test coverage and quality
-      - Check for security and performance issues
-      - Create a review report
+      - Check security and performance risks
+      - Create the code review report
     inputs:
       - Implementation branch
       - Project conventions
     artifact_versioning:
       inputs:
-        - name: implementation
-          pattern: "implementation.md | implementation-r{N}.md"
-          rule: "Read the highest-round implementation artifact as review input"
-      outputs:
-        - name: review
-          pattern: "review.md | review-r{N}.md"
-          rule: "Scan existing review artifacts; create review.md for the first round, then review-r{N}.md for later rounds (N = current highest round + 1)"
-    outputs:
-      - Review report
-      - List of issues to fix
-
-  - name: fix
-    description: Address issues found during the review step.
-    recommended_agents:
-      - codex
-      - cursor
-    tasks:
-      - Fix all critical and major review findings
-      - Address minor issues and suggestions when appropriate
-      - Update tests as needed
-      - Verify that all tests pass
-    inputs:
-      - Review report
-      - Implementation branch
-    artifact_versioning:
-      inputs:
-        - name: review
-          pattern: "review.md | review-r{N}.md"
-          rule: "Read the highest-round review artifact and verify that it matches the latest Code Review entry in the task.md Activity Log"
+        - name: code
+          pattern: "code.md | code-r{N}.md"
+          rule: "Read the highest-round code artifact as review input"
       outputs:
-        - name: refinement
-          pattern: "refinement.md | refinement-r{N}.md"
-          rule: "Scan existing refinement artifacts; create refinement.md for the first round, then refinement-r{N}.md for later rounds (N = current highest round + 1)"
+        - name: review-code
+          pattern: "review-code.md | review-code-r{N}.md"
+          rule: "Scan existing code review artifacts; create review-code.md for round 1 and review-code-r{N}.md for later rounds (N = current highest round + 1)"
     outputs:
-      - Updated branch with fixes
-      - Updated task file
+      - Code review report
+      - Findings to fix
 
   - name: commit
-    description: Finalize the changes and create a pull request.
+    description: Finalize changes and create a pull request (the PR portion runs only when the project enables the PR flow).
     recommended_agents:
       - claude
       - human
     tasks:
       - Ensure all tests pass
-      - Write a clear commit message that follows project conventions
-      - Create a pull request with an appropriate description
-      - Link the PR to the relevant issue
+      - Write a clear commit message following conventions
       - Move the task to completed
+    pr_tasks:
+      - Create a pull request with an appropriate description
+      - Link the PR to the related Issue
     inputs:
       - Final implementation branch
-      - Task file
+      - Task workspace
     outputs:
-      - Pull request
-      - Completed task file (stored in .agents/workspace/completed/)
+      - Completed task workspace under .agents/workspace/completed/
+      - Pull request (only when the project enables the PR flow)

package/templates/.agents/workflows/feature-development.zh-CN.yaml

@@ -1,5 +1,8 @@
 # 功能开发工作流
 # 实现新功能时使用此工作流。
+#
+# 注：步骤中的 `pr_tasks` 列表仅在 `.agents/.airc.json:requiresPullRequest !== false` 时
+# 被计入工作流进度判定（详见 .agents/skills/complete-task/SKILL.md）。
 
 name: feature-development
 description: 开发新功能的端到端工作流。
@@ -24,10 +27,36 @@ steps:
           pattern: "analysis.md | analysis-r{N}.md"
           rule: "扫描现有分析产物；首轮创建 analysis.md，后续修订创建 analysis-r{N}.md（N = 当前最高轮次 + 1）"
     outputs:
-      - 更新后的任务文件（分析部分）
+      - 需求分析报告
       - 受影响文件列表
       - 识别的风险或约束
 
+  - name: analysis-review
+    description: 审查需求分析是否完整、可验证且边界清晰。
+    recommended_agents:
+      - claude
+      - gemini
+    tasks:
+      - 检查需求范围、约束和验收标准
+      - 验证受影响区域和风险识别是否充分
+      - 确认分析结论足以进入设计阶段
+      - 创建需求分析审查报告
+    inputs:
+      - 最新需求分析报告
+      - 原始需求或 Issue 描述
+    artifact_versioning:
+      inputs:
+        - name: analysis
+          pattern: "analysis.md | analysis-r{N}.md"
+          rule: "读取最高轮次的分析产物作为审查输入"
+      outputs:
+        - name: review-analysis
+          pattern: "review-analysis.md | review-analysis-r{N}.md"
+          rule: "扫描现有需求分析审查产物；首轮创建 review-analysis.md，后续轮次创建 review-analysis-r{N}.md（N = 当前最高轮次 + 1）"
+    outputs:
+      - 需求分析审查报告
+      - 待修正问题列表（如有）
+
   - name: design
     description: 为功能实现创建技术设计方案。
     recommended_agents:
@@ -39,24 +68,53 @@ steps:
       - 识别边界情况和错误处理策略
       - 在任务文件中记录设计方案
     inputs:
-      - 上一步的分析结果
+      - 已通过审查的需求分析
       - 项目架构和规范
     artifact_versioning:
       inputs:
         - name: analysis
           pattern: "analysis.md | analysis-r{N}.md"
           rule: "读取最高轮次的分析产物作为设计输入"
+        - name: review-analysis
+          pattern: "review-analysis.md | review-analysis-r{N}.md"
+          rule: "读取最高轮次的需求分析审查产物，确认分析已获通过或已处理反馈"
       outputs:
         - name: plan
           pattern: "plan.md | plan-r{N}.md"
           rule: "扫描现有方案产物；首轮创建 plan.md，后续修订创建 plan-r{N}.md（N = 当前最高轮次 + 1）"
     outputs:
-      - 更新后的任务文件（设计部分）
+      - 技术方案
       - 接口定义
       - 实现计划
 
-  - name: implementation
-    description: 按照设计方案实现功能。
+  - name: design-review
+    description: 审查技术方案是否可实施、低风险且覆盖需求。
+    recommended_agents:
+      - claude
+      - gemini
+    tasks:
+      - 验证方案覆盖已批准的需求分析
+      - 检查架构一致性、风险和测试策略
+      - 确认方案足以进入编码阶段
+      - 创建技术方案审查报告
+    inputs:
+      - 最新技术方案
+      - 最新需求分析和审查报告
+    artifact_versioning:
+      inputs:
+        - name: plan
+          pattern: "plan.md | plan-r{N}.md"
+          rule: "读取最高轮次的方案产物作为审查输入"
+      outputs:
+        - name: review-plan
+          pattern: "review-plan.md | review-plan-r{N}.md"
+          rule: "扫描现有方案审查产物；首轮创建 review-plan.md，后续轮次创建 review-plan-r{N}.md（N = 当前最高轮次 + 1）"
+    outputs:
+      - 技术方案审查报告
+      - 待修正问题列表（如有）
+
+  - name: code
+    description: 按照已批准方案实现功能；在审查后再次执行同一阶段处理修复。
     recommended_agents:
       - codex
       - cursor
@@ -65,21 +123,33 @@ steps:
       - 实现功能代码
       - 编写单元测试
       - 编写集成测试（如适用）
+      - 修复最新 code-review 产物中要求处理的问题（如处于修复模式）
       - 确保代码遵循项目规范
     inputs:
-      - 上一步的技术设计
+      - 已通过审查的技术设计
       - 项目编码标准
+      - 最新代码审查报告（修复模式适用）
     artifact_versioning:
+      inputs:
+        - name: plan
+          pattern: "plan.md | plan-r{N}.md"
+          rule: "读取最高轮次的方案产物作为实现输入"
+        - name: review-plan
+          pattern: "review-plan.md | review-plan-r{N}.md"
+          rule: "读取最高轮次的方案审查产物，确认方案已获通过或已处理反馈"
+        - name: review-code
+          pattern: "review-code.md | review-code-r{N}.md"
+          rule: "修复模式读取最高轮次的代码审查产物，并校验其与 task.md Activity Log 中最近一条 Code Review 记录一致"
       outputs:
-        - name: implementation
-          pattern: "implementation.md | implementation-r{N}.md"
-          rule: "扫描现有实现产物；首轮创建 implementation.md，后续重实现创建 implementation-r{N}.md（N = 当前最高轮次 + 1）"
+        - name: code
+          pattern: "code.md | code-r{N}.md"
+          rule: "扫描现有实现产物；首轮创建 code.md，后续修复或重实现创建 code-r{N}.md（N = 当前最高轮次 + 1）"
     outputs:
-      - 包含实现的功能分支
+      - 包含实现或修复的功能分支
       - 测试文件
       - 更新后的任务文件（实现备注）
 
-  - name: review
+  - name: code-review
     description: 审查实现的正确性、代码风格和最佳实践。
     recommended_agents:
       - claude
@@ -88,63 +158,38 @@ steps:
       - 检查是否遵循项目规范
       - 验证测试覆盖率和质量
       - 检查安全和性能问题
-      - 创建审查报告
+      - 创建代码审查报告
     inputs:
       - 实现分支
       - 项目规范
     artifact_versioning:
       inputs:
-        - name: implementation
-          pattern: "implementation.md | implementation-r{N}.md"
+        - name: code
+          pattern: "code.md | code-r{N}.md"
           rule: "读取最高轮次的实现产物作为审查输入"
       outputs:
-        - name: review
-          pattern: "review.md | review-r{N}.md"
-          rule: "扫描现有审查产物；首轮创建 review.md，后续轮次创建 review-r{N}.md（N = 当前最高轮次 + 1）"
+        - name: review-code
+          pattern: "review-code.md | review-code-r{N}.md"
+          rule: "扫描现有代码审查产物；首轮创建 review-code.md，后续轮次创建 review-code-r{N}.md（N = 当前最高轮次 + 1）"
     outputs:
-      - 审查报告
+      - 代码审查报告
       - 待修复问题列表
 
-  - name: fix
-    description: 处理审查阶段发现的问题。
-    recommended_agents:
-      - codex
-      - cursor
-    tasks:
-      - 修复审查中的所有严重和重要问题
-      - 酌情处理次要问题和建议
-      - 根据需要更新测试
-      - 验证所有测试通过
-    inputs:
-      - 审查报告
-      - 实现分支
-    artifact_versioning:
-      inputs:
-        - name: review
-          pattern: "review.md | review-r{N}.md"
-          rule: "读取最高轮次的审查产物，并校验其与 task.md Activity Log 中最近一条 Code Review 记录一致"
-      outputs:
-        - name: refinement
-          pattern: "refinement.md | refinement-r{N}.md"
-          rule: "扫描现有修复产物；首轮创建 refinement.md，后续轮次创建 refinement-r{N}.md（N = 当前最高轮次 + 1）"
-    outputs:
-      - 包含修复的更新分支
-      - 更新后的任务文件
-
   - name: commit
-    description: 最终确认变更并创建拉取请求。
+    description: 最终确认变更并创建拉取请求（PR 部分仅在项目启用 PR 流程时执行）。
     recommended_agents:
       - claude
       - human
     tasks:
       - 确保所有测试通过
       - 按规范编写清晰的提交信息
+      - 将任务移至已完成
+    pr_tasks:
       - 创建包含适当描述的拉取请求
       - 将 PR 关联到相关 Issue
-      - 将任务移至已完成
     inputs:
       - 最终实现分支
       - 任务文件
     outputs:
-      - 拉取请求
       - 已完成的任务文件（位于 .agents/workspace/completed/）
+      - 拉取请求（仅项目启用 PR 流程时）