@fitlab-ai/agent-infra 0.6.5 → 0.7.1

package/templates/.agents/workflows/bug-fix.en.yaml

@@ -1,149 +1,195 @@
-# Bug Fix Workflow
-# Use this workflow when fixing a bug.
+# Bug-fix workflow
+# Use this workflow when fixing a defect.
+#
+# Note: a step's `pr_tasks` list is counted toward workflow progress only when
+# `.agents/.airc.json:requiresPullRequest !== false` (see .agents/skills/complete-task/SKILL.md).
 
 name: bug-fix
-description: Workflow for diagnosing and fixing a bug.
+description: Workflow for diagnosing and fixing a defect.
 
 steps:
   - name: analysis
-    description: Reproduce the bug, identify the root cause, and determine the scope of the fix.
+    description: Reproduce the defect, identify the root cause, and define the fix scope.
     recommended_agents:
       - claude
       - gemini
     tasks:
-      - Understand the bug report and expected behavior
-      - Reproduce the bug when possible
+      - Understand the defect report and expected behavior
+      - Reproduce the defect when possible
       - Trace the code path to identify the root cause
-      - Determine impacted files and components
-      - Record findings in the task file
+      - Determine affected files and components
+      - Record findings in the task workspace
     inputs:
-      - Bug report or issue description
+      - Defect report or Issue description
       - Reproduction steps
       - Project codebase
     artifact_versioning:
       outputs:
         - name: analysis
           pattern: "analysis.md | analysis-r{N}.md"
-          rule: "Scan existing analysis artifacts; create analysis.md for the first round, then analysis-r{N}.md for later revisions (N = current highest round + 1)"
+          rule: "Scan existing analysis artifacts; create analysis.md for round 1 and analysis-r{N}.md for later revisions (N = current highest round + 1)"
     outputs:
-      - Root cause analysis
-      - List of impacted files
-      - Updated task file (analysis section)
+      - Root-cause analysis
+      - Affected files list
+      - Updated task analysis notes
+
+  - name: analysis-review
+    description: Review whether the defect analysis has sufficient reproduction evidence, a clear root cause, and a scoped fix.
+    recommended_agents:
+      - claude
+      - gemini
+    tasks:
+      - Verify reproduction evidence or the non-reproducible explanation
+      - Check root-cause reasoning and impact scope
+      - Confirm the analysis is ready for design
+      - Create the requirement analysis review report
+    inputs:
+      - Latest root-cause analysis
+      - Defect report or Issue description
+    artifact_versioning:
+      inputs:
+        - name: analysis
+          pattern: "analysis.md | analysis-r{N}.md"
+          rule: "Read the highest-round analysis artifact as review input"
+      outputs:
+        - name: review-analysis
+          pattern: "review-analysis.md | review-analysis-r{N}.md"
+          rule: "Scan existing requirement-analysis review artifacts; create review-analysis.md for round 1 and review-analysis-r{N}.md for later rounds (N = current highest round + 1)"
+    outputs:
+      - Requirement analysis review report
+      - Findings to fix, if any
 
   - name: design
-    description: Plan the fix and consider edge cases.
+    description: Plan the fix and account for edge cases.
     recommended_agents:
       - claude
     tasks:
-      - Determine the best approach for fixing the bug
-      - Identify potential side effects of the fix
-      - Plan test cases to validate the fix
-      - Record the fix plan in the task file
+      - Determine the best fix approach
+      - Identify potential side effects
+      - Plan regression tests
+      - Record the fix plan in the task workspace
     inputs:
-      - Root cause analysis from the previous step
+      - Approved root-cause analysis
       - Project architecture
     artifact_versioning:
       inputs:
         - name: analysis
           pattern: "analysis.md | analysis-r{N}.md"
           rule: "Read the highest-round analysis artifact as design input"
+        - name: review-analysis
+          pattern: "review-analysis.md | review-analysis-r{N}.md"
+          rule: "Read the highest-round analysis review artifact and confirm feedback is approved or handled"
       outputs:
         - name: plan
           pattern: "plan.md | plan-r{N}.md"
-          rule: "Scan existing plan artifacts; create plan.md for the first round, then plan-r{N}.md for later revisions (N = current highest round + 1)"
+          rule: "Scan existing plan artifacts; create plan.md for round 1 and plan-r{N}.md for later revisions (N = current highest round + 1)"
     outputs:
-      - Fix plan recorded in the task file
-      - List of test cases to add
+      - Fix plan
+      - Regression test list
 
-  - name: implementation
-    description: Implement the bug fix and add regression tests.
+  - name: design-review
+    description: Review whether the fix plan addresses the root cause, has sufficient tests, and controls side effects.
     recommended_agents:
-      - codex
-      - cursor
+      - claude
+      - gemini
     tasks:
-      - Create a bug-fix branch
-      - Implement the fix
-      - Add regression tests that would fail without the fix
-      - Verify that existing tests still pass
-      - Ensure the code follows project conventions
+      - Verify the plan covers the approved root-cause analysis
+      - Check regression test strategy and potential side effects
+      - Confirm the plan is ready for coding
+      - Create the plan review report
     inputs:
-      - Fix plan from the previous step
-      - Project coding standards
+      - Latest fix plan
+      - Latest root-cause analysis and review report
     artifact_versioning:
+      inputs:
+        - name: plan
+          pattern: "plan.md | plan-r{N}.md"
+          rule: "Read the highest-round plan artifact as review input"
       outputs:
-        - name: implementation
-          pattern: "implementation.md | implementation-r{N}.md"
-          rule: "Scan existing implementation artifacts; create implementation.md for the first round, then implementation-r{N}.md for later re-implementations (N = current highest round + 1)"
+        - name: review-plan
+          pattern: "review-plan.md | review-plan-r{N}.md"
+          rule: "Scan existing plan review artifacts; create review-plan.md for round 1 and review-plan-r{N}.md for later rounds (N = current highest round + 1)"
     outputs:
-      - Bug-fix branch with the implementation
-      - Regression test files
-      - Updated task file (implementation notes)
+      - Plan review report
+      - Findings to fix, if any
 
-  - name: review
-    description: Verify that the fix is correct and complete.
+  - name: code
+    description: Implement the defect fix and regression coverage; run the same stage again after code review to handle fixes.
     recommended_agents:
-      - claude
+      - codex
+      - cursor
     tasks:
-      - Verify that the fix addresses the root cause
-      - Check whether regression tests are sufficient
-      - Ensure no new issues were introduced
-      - Verify that the fix does not break existing functionality
-      - Create a review report
+      - Create a bug-fix branch
+      - Implement the fix
+      - Add a regression test that fails without the fix
+      - Fix findings from the latest code-review artifact when in fix mode
+      - Verify existing tests still pass
+      - Ensure code follows project conventions
     inputs:
-      - Bug-fix branch
-      - Root cause analysis
+      - Approved fix plan
+      - Project coding standards
+      - Latest code review report when in fix mode
     artifact_versioning:
       inputs:
-        - name: implementation
-          pattern: "implementation.md | implementation-r{N}.md"
-          rule: "Read the highest-round implementation artifact as review input"
+        - name: plan
+          pattern: "plan.md | plan-r{N}.md"
+          rule: "Read the highest-round plan artifact as implementation input"
+        - name: review-plan
+          pattern: "review-plan.md | review-plan-r{N}.md"
+          rule: "Read the highest-round plan review artifact and confirm feedback is approved or handled"
+        - name: review-code
+          pattern: "review-code.md | review-code-r{N}.md"
+          rule: "In fix mode, read the highest-round code review artifact and verify it matches the latest Code Review entry in task.md Activity Log"
       outputs:
-        - name: review
-          pattern: "review.md | review-r{N}.md"
-          rule: "Scan existing review artifacts; create review.md for the first round, then review-r{N}.md for later rounds (N = current highest round + 1)"
+        - name: code
+          pattern: "code.md | code-r{N}.md"
+          rule: "Scan existing code artifacts; create code.md for round 1 and code-r{N}.md for later fixes or reimplementation (N = current highest round + 1)"
     outputs:
-      - Review report
-      - List of issues if any
+      - Bug-fix branch with implementation or fixes
+      - Regression test files
+      - Updated task notes
 
-  - name: fix
-    description: Address issues found during review.
+  - name: code-review
+    description: Verify that the fix is correct and complete.
     recommended_agents:
-      - codex
-      - cursor
+      - claude
     tasks:
-      - Fix issues identified in the review
-      - Update tests as needed
-      - Verify that all tests pass
+      - Verify the fix addresses the root cause
+      - Check regression test sufficiency
+      - Ensure no new problems were introduced
+      - Verify the fix does not break existing behavior
+      - Create the code review report
     inputs:
-      - Review report
       - Bug-fix branch
+      - Root-cause analysis
     artifact_versioning:
       inputs:
-        - name: review
-          pattern: "review.md | review-r{N}.md"
-          rule: "Read the highest-round review artifact and verify that it matches the latest Code Review entry in the task.md Activity Log"
+        - name: code
+          pattern: "code.md | code-r{N}.md"
+          rule: "Read the highest-round code artifact as review input"
       outputs:
-        - name: refinement
-          pattern: "refinement.md | refinement-r{N}.md"
-          rule: "Scan existing refinement artifacts; create refinement.md for the first round, then refinement-r{N}.md for later rounds (N = current highest round + 1)"
+        - name: review-code
+          pattern: "review-code.md | review-code-r{N}.md"
+          rule: "Scan existing code review artifacts; create review-code.md for round 1 and review-code-r{N}.md for later rounds (N = current highest round + 1)"
     outputs:
-      - Updated branch with fixes
-      - Updated task file
+      - Code review report
+      - Findings list, if any
 
   - name: commit
-    description: Finalize the bug fix and create a pull request.
+    description: Finalize the defect fix and create a pull request (the PR portion runs only when the project enables the PR flow).
     recommended_agents:
       - claude
       - human
     tasks:
       - Ensure all tests pass
-      - Write a commit message that references the bug or issue
-      - Create a pull request with a bug-fix summary
-      - Link the PR to the bug report issue
+      - Write a commit message that references the defect or Issue
       - Move the task to completed
+    pr_tasks:
+      - Create a pull request with a defect-fix description
+      - Link the PR to the defect report Issue
     inputs:
       - Final bug-fix branch
-      - Task file
+      - Task workspace
     outputs:
-      - Pull request
-      - Completed task file (stored in .agents/workspace/completed/)
+      - Completed task workspace under .agents/workspace/completed/
+      - Pull request (only when the project enables the PR flow)

package/templates/.agents/workflows/bug-fix.zh-CN.yaml

@@ -1,5 +1,8 @@
 # 缺陷修复工作流
 # 修复缺陷时使用此工作流。
+#
+# 注：步骤中的 `pr_tasks` 列表仅在 `.agents/.airc.json:requiresPullRequest !== false` 时
+# 被计入工作流进度判定（详见 .agents/skills/complete-task/SKILL.md）。
 
 name: bug-fix
 description: 诊断和修复缺陷的工作流。
@@ -30,6 +33,32 @@ steps:
       - 受影响文件列表
       - 更新后的任务文件（分析部分）
 
+  - name: analysis-review
+    description: 审查缺陷分析是否复现充分、根因明确且修复范围清晰。
+    recommended_agents:
+      - claude
+      - gemini
+    tasks:
+      - 验证缺陷复现或不可复现说明
+      - 检查根因推导和影响范围
+      - 确认分析结论足以进入设计阶段
+      - 创建需求分析审查报告
+    inputs:
+      - 最新根因分析
+      - 缺陷报告或 Issue 描述
+    artifact_versioning:
+      inputs:
+        - name: analysis
+          pattern: "analysis.md | analysis-r{N}.md"
+          rule: "读取最高轮次的分析产物作为审查输入"
+      outputs:
+        - name: review-analysis
+          pattern: "review-analysis.md | review-analysis-r{N}.md"
+          rule: "扫描现有需求分析审查产物；首轮创建 review-analysis.md，后续轮次创建 review-analysis-r{N}.md（N = 当前最高轮次 + 1）"
+    outputs:
+      - 需求分析审查报告
+      - 待修正问题列表（如有）
+
   - name: design
     description: 规划修复方案并考虑边界情况。
     recommended_agents:
@@ -40,13 +69,16 @@ steps:
       - 规划验证修复的测试用例
       - 在任务文件中记录修复方案
     inputs:
-      - 上一步的根因分析
+      - 已通过审查的根因分析
       - 项目架构
     artifact_versioning:
       inputs:
         - name: analysis
           pattern: "analysis.md | analysis-r{N}.md"
           rule: "读取最高轮次的分析产物作为设计输入"
+        - name: review-analysis
+          pattern: "review-analysis.md | review-analysis-r{N}.md"
+          rule: "读取最高轮次的需求分析审查产物，确认分析已获通过或已处理反馈"
       outputs:
         - name: plan
           pattern: "plan.md | plan-r{N}.md"
@@ -55,8 +87,34 @@ steps:
       - 任务文件中记录的修复方案
       - 待添加的测试用例列表
 
-  - name: implementation
-    description: 实现缺陷修复并添加回归测试。
+  - name: design-review
+    description: 审查修复方案是否覆盖根因、测试充分且副作用可控。
+    recommended_agents:
+      - claude
+      - gemini
+    tasks:
+      - 验证方案覆盖已批准的根因分析
+      - 检查回归测试策略和潜在副作用
+      - 确认方案足以进入编码阶段
+      - 创建技术方案审查报告
+    inputs:
+      - 最新修复方案
+      - 最新根因分析和审查报告
+    artifact_versioning:
+      inputs:
+        - name: plan
+          pattern: "plan.md | plan-r{N}.md"
+          rule: "读取最高轮次的方案产物作为审查输入"
+      outputs:
+        - name: review-plan
+          pattern: "review-plan.md | review-plan-r{N}.md"
+          rule: "扫描现有方案审查产物；首轮创建 review-plan.md，后续轮次创建 review-plan-r{N}.md（N = 当前最高轮次 + 1）"
+    outputs:
+      - 技术方案审查报告
+      - 待修正问题列表（如有）
+
+  - name: code
+    description: 实现缺陷修复并添加回归测试；在审查后再次执行同一阶段处理修复。
     recommended_agents:
       - codex
       - cursor
@@ -64,22 +122,34 @@ steps:
       - 创建缺陷修复分支
       - 实现修复
       - 添加在没有修复时会失败的回归测试
+      - 修复最新 code-review 产物中要求处理的问题（如处于修复模式）
       - 验证现有测试仍然通过
       - 确保代码遵循项目规范
     inputs:
-      - 上一步的修复方案
+      - 已通过审查的修复方案
       - 项目编码标准
+      - 最新代码审查报告（修复模式适用）
     artifact_versioning:
+      inputs:
+        - name: plan
+          pattern: "plan.md | plan-r{N}.md"
+          rule: "读取最高轮次的方案产物作为实现输入"
+        - name: review-plan
+          pattern: "review-plan.md | review-plan-r{N}.md"
+          rule: "读取最高轮次的方案审查产物，确认方案已获通过或已处理反馈"
+        - name: review-code
+          pattern: "review-code.md | review-code-r{N}.md"
+          rule: "修复模式读取最高轮次的代码审查产物，并校验其与 task.md Activity Log 中最近一条 Code Review 记录一致"
       outputs:
-        - name: implementation
-          pattern: "implementation.md | implementation-r{N}.md"
-          rule: "扫描现有实现产物；首轮创建 implementation.md，后续重实现创建 implementation-r{N}.md（N = 当前最高轮次 + 1）"
+        - name: code
+          pattern: "code.md | code-r{N}.md"
+          rule: "扫描现有实现产物；首轮创建 code.md，后续修复或重实现创建 code-r{N}.md（N = 当前最高轮次 + 1）"
     outputs:
-      - 包含实现的缺陷修复分支
+      - 包含实现或修复的缺陷修复分支
       - 回归测试文件
       - 更新后的任务文件（实现备注）
 
-  - name: review
+  - name: code-review
     description: 验证修复是否正确和完整。
     recommended_agents:
       - claude
@@ -88,62 +158,38 @@ steps:
       - 检查回归测试是否充分
       - 确保未引入新问题
       - 验证修复不会破坏现有功能
-      - 创建审查报告
+      - 创建代码审查报告
     inputs:
       - 缺陷修复分支
       - 根因分析
     artifact_versioning:
       inputs:
-        - name: implementation
-          pattern: "implementation.md | implementation-r{N}.md"
+        - name: code
+          pattern: "code.md | code-r{N}.md"
           rule: "读取最高轮次的实现产物作为审查输入"
       outputs:
-        - name: review
-          pattern: "review.md | review-r{N}.md"
-          rule: "扫描现有审查产物；首轮创建 review.md，后续轮次创建 review-r{N}.md（N = 当前最高轮次 + 1）"
+        - name: review-code
+          pattern: "review-code.md | review-code-r{N}.md"
+          rule: "扫描现有代码审查产物；首轮创建 review-code.md，后续轮次创建 review-code-r{N}.md（N = 当前最高轮次 + 1）"
     outputs:
-      - 审查报告
+      - 代码审查报告
       - 问题列表（如有）
 
-  - name: fix
-    description: 处理审查中发现的问题。
-    recommended_agents:
-      - codex
-      - cursor
-    tasks:
-      - 修复审查中识别的问题
-      - 根据需要更新测试
-      - 验证所有测试通过
-    inputs:
-      - 审查报告
-      - 缺陷修复分支
-    artifact_versioning:
-      inputs:
-        - name: review
-          pattern: "review.md | review-r{N}.md"
-          rule: "读取最高轮次的审查产物，并校验其与 task.md Activity Log 中最近一条 Code Review 记录一致"
-      outputs:
-        - name: refinement
-          pattern: "refinement.md | refinement-r{N}.md"
-          rule: "扫描现有修复产物；首轮创建 refinement.md，后续轮次创建 refinement-r{N}.md（N = 当前最高轮次 + 1）"
-    outputs:
-      - 包含修复的更新分支
-      - 更新后的任务文件
-
   - name: commit
-    description: 最终确认缺陷修复并创建拉取请求。
+    description: 最终确认缺陷修复并创建拉取请求（PR 部分仅在项目启用 PR 流程时执行）。
     recommended_agents:
       - claude
       - human
     tasks:
       - 确保所有测试通过
       - 编写引用缺陷/Issue 的提交信息
+      - 将任务移至已完成
+    pr_tasks:
       - 创建包含缺陷修复描述的拉取请求
       - 将 PR 关联到缺陷报告 Issue
-      - 将任务移至已完成
     inputs:
       - 最终缺陷修复分支
       - 任务文件
     outputs:
-      - 拉取请求
       - 已完成的任务文件（位于 .agents/workspace/completed/）
+      - 拉取请求（仅项目启用 PR 流程时）