@firstpick/pi-package-webui 0.11.1 → 0.11.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (309) hide show
  1. package/DEVELOPMENT.md +151 -12
  2. package/README.md +34 -6
  3. package/TECHNICAL.md +75 -8
  4. package/bin/pi-webui.mjs +5390 -11423
  5. package/index.ts +10 -3
  6. package/lib/component-update-state.mjs +2 -2
  7. package/lib/git-workflow-preference-values.mjs +122 -0
  8. package/lib/git-workflow-preferences.mjs +35 -563
  9. package/lib/package-updates.mjs +260 -0
  10. package/lib/rpc-supervisor-client.mjs +8 -4
  11. package/lib/server/app-runners.mjs +1667 -0
  12. package/lib/server/codex-fast-mode.mjs +161 -0
  13. package/lib/server/conversation-mode.mjs +218 -0
  14. package/lib/server/conversation-voice.mjs +318 -0
  15. package/lib/server/extension-ui-requests.mjs +114 -0
  16. package/lib/server/git-generation.mjs +459 -0
  17. package/lib/server/git-mutations.mjs +1827 -0
  18. package/lib/server/git-reads.mjs +608 -0
  19. package/lib/server/git-worktree-sessions.mjs +408 -0
  20. package/lib/server/helper-requests.mjs +82 -0
  21. package/lib/server/no-project-workspaces.mjs +103 -0
  22. package/lib/server/rpc-transports.mjs +394 -0
  23. package/lib/server/settings-store.mjs +544 -0
  24. package/lib/server/sse-delivery.mjs +138 -0
  25. package/lib/server/workspace-files.mjs +563 -0
  26. package/lib/update/supervisor.mjs +4 -0
  27. package/lib/webui-workspaces.mjs +2 -0
  28. package/package.json +4 -4
  29. package/public/activity-agents-controller.mjs +269 -0
  30. package/public/activity-events-controller.mjs +236 -0
  31. package/public/activity-intercom-controller.mjs +627 -0
  32. package/public/activity-queue-controller.mjs +534 -0
  33. package/public/activity-todo-view.mjs +89 -0
  34. package/public/activity-usage-controller.mjs +589 -0
  35. package/public/app.js +3761 -3886
  36. package/public/conversation-overview.css +84 -0
  37. package/public/conversation-overview.mjs +193 -0
  38. package/public/draft-conversations.mjs +135 -0
  39. package/public/focused-composer-controls.css +111 -0
  40. package/public/focused-composer-controls.mjs +143 -0
  41. package/public/focused-composer-disclosure.mjs +223 -0
  42. package/public/focused-shell-adapter.css +264 -0
  43. package/public/focused-shell-adapter.mjs +257 -0
  44. package/public/index.html +137 -80
  45. package/public/model-catalog-order.mjs +63 -0
  46. package/public/platform-event-stream.mjs +64 -0
  47. package/public/project-artifact-controller.mjs +218 -0
  48. package/public/project-file-viewer-controller.mjs +383 -0
  49. package/public/project-git-tools-controller.mjs +181 -0
  50. package/public/project-runners-controller.mjs +220 -0
  51. package/public/service-worker.js +52 -1
  52. package/public/session-attention-scheduler.mjs +182 -0
  53. package/public/session-composer-store.mjs +56 -0
  54. package/public/session-context.mjs +51 -0
  55. package/public/session-extension-requests.mjs +63 -0
  56. package/public/session-shelf-state.mjs +151 -0
  57. package/public/session-shelves.css +171 -0
  58. package/public/session-shelves.mjs +95 -0
  59. package/public/settings-navigation-controller.mjs +249 -0
  60. package/public/settings-navigation.css +61 -0
  61. package/public/settings-resource-controller.mjs +232 -0
  62. package/public/settings-workspace.css +19 -0
  63. package/public/settings-workspace.mjs +175 -0
  64. package/public/shell-actions.mjs +87 -0
  65. package/public/shell-attention-inbox.css +72 -0
  66. package/public/shell-attention-inbox.mjs +198 -0
  67. package/public/shell-context-actions.css +61 -0
  68. package/public/shell-context-actions.mjs +168 -0
  69. package/public/shell-inspector-resize.mjs +124 -0
  70. package/public/shell-navigation-resize.mjs +107 -0
  71. package/public/shell-navigation.mjs +127 -0
  72. package/public/shell-preferences.mjs +108 -0
  73. package/public/shell-surfaces.mjs +99 -0
  74. package/public/shell-tools-launcher.css +97 -0
  75. package/public/shell-tools-launcher.mjs +222 -0
  76. package/public/shell-view-host.mjs +115 -0
  77. package/public/shell-workspace.css +266 -0
  78. package/public/shell-workspace.mjs +402 -0
  79. package/public/sidebar-update-menu.css +190 -0
  80. package/public/sidebar-update-menu.mjs +512 -0
  81. package/public/styles.css +320 -169
  82. package/public/subagent-launch-slot-state.mjs +2 -2
  83. package/public/themed-selects.css +156 -0
  84. package/public/workspace-choices.mjs +104 -0
  85. package/tests/activity-agents-controller.test.mjs +652 -0
  86. package/tests/activity-events-controller.test.mjs +511 -0
  87. package/tests/app-runner-terminal-static.test.mjs +3 -3
  88. package/tests/append-system-http.test.mjs +7 -6
  89. package/tests/append-system-selector-static.test.mjs +6 -6
  90. package/tests/aur-review-widget-static.test.mjs +11 -3
  91. package/tests/boot-failure-diagnostics.test.mjs +8 -3
  92. package/tests/browser/activity-intercom-controller.spec.mjs +457 -0
  93. package/tests/browser/activity-navigation-integration.spec.mjs +45 -0
  94. package/tests/browser/activity-owner-integration.spec.mjs +201 -0
  95. package/tests/browser/activity-queue-controller.spec.mjs +405 -0
  96. package/tests/browser/activity-section-picker.spec.mjs +294 -0
  97. package/tests/browser/activity-todo-view.spec.mjs +60 -0
  98. package/tests/browser/activity-usage-controller.spec.mjs +416 -0
  99. package/tests/browser/compact-layout-integration.spec.mjs +58 -0
  100. package/tests/browser/composer-action-grid-reorder.spec.mjs +16 -0
  101. package/tests/browser/composer-disclosure.spec.mjs +389 -0
  102. package/tests/browser/composer-toolbar-polish.spec.mjs +343 -0
  103. package/tests/browser/control-deck-component-updates.spec.mjs +5 -14
  104. package/tests/browser/control-deck-side-panels.spec.mjs +27 -12
  105. package/tests/browser/control-visibility.spec.mjs +5 -0
  106. package/tests/browser/controls-layout.spec.mjs +21 -2
  107. package/tests/browser/conversation-overview.spec.mjs +251 -0
  108. package/tests/browser/draft-conversations.spec.mjs +276 -0
  109. package/tests/browser/empty-startup-fixture.mjs +135 -0
  110. package/tests/browser/empty-startup.spec.mjs +282 -0
  111. package/tests/browser/events-tree-context-menu.spec.mjs +1 -0
  112. package/tests/browser/focused-composer-more.spec.mjs +127 -0
  113. package/tests/browser/focused-model-shortcuts.spec.mjs +120 -0
  114. package/tests/browser/focused-navigation-fixture.mjs +32 -0
  115. package/tests/browser/focused-project-activity.spec.mjs +111 -0
  116. package/tests/browser/focused-shell-integration.spec.mjs +208 -0
  117. package/tests/browser/folder-picker-layout-fixture.mjs +13 -0
  118. package/tests/browser/folder-picker-layout.spec.mjs +302 -0
  119. package/tests/browser/footer-model-advanced-layout.spec.mjs +27 -14
  120. package/tests/browser/git-setup-cancel.spec.mjs +251 -0
  121. package/tests/browser/guided-git-fallback.spec.mjs +40 -21
  122. package/tests/browser/inspector-header.spec.mjs +221 -0
  123. package/tests/browser/inspector-overview-integration.spec.mjs +104 -0
  124. package/tests/browser/inspector-resize.spec.mjs +227 -0
  125. package/tests/browser/inspector-topic-overflow.spec.mjs +56 -0
  126. package/tests/browser/interaction-action-discovery.spec.mjs +332 -0
  127. package/tests/browser/interaction-attention-inbox.spec.mjs +364 -0
  128. package/tests/browser/interaction-attention-integration.spec.mjs +53 -0
  129. package/tests/browser/interaction-composer-controls.spec.mjs +267 -0
  130. package/tests/browser/interaction-composer-integration.spec.mjs +175 -0
  131. package/tests/browser/interaction-continuity.spec.mjs +50 -26
  132. package/tests/browser/interaction-model-picker.spec.mjs +86 -0
  133. package/tests/browser/last-terminal-close.spec.mjs +280 -0
  134. package/tests/browser/mobile-foundation.spec.mjs +172 -20
  135. package/tests/browser/model-catalog-groups.spec.mjs +104 -0
  136. package/tests/browser/more-row-menus.spec.mjs +258 -0
  137. package/tests/browser/new-tab-hit-target.spec.mjs +228 -0
  138. package/tests/browser/no-project-conversation.spec.mjs +113 -0
  139. package/tests/browser/optimistic-prompt.spec.mjs +3 -0
  140. package/tests/browser/overhaul-w7-accessibility.spec.mjs +227 -0
  141. package/tests/browser/overhaul-w7-capabilities.spec.mjs +298 -0
  142. package/tests/browser/overhaul-w7-companions.spec.mjs +290 -0
  143. package/tests/browser/overhaul-w7-focus-repairs.spec.mjs +210 -0
  144. package/tests/browser/overhaul-w7-layout-repairs.spec.mjs +183 -0
  145. package/tests/browser/overhaul-w7-parent-repairs.spec.mjs +97 -0
  146. package/tests/browser/overhaul-w7-pwa.spec.mjs +247 -0
  147. package/tests/browser/overhaul-w7-responsive.spec.mjs +450 -0
  148. package/tests/browser/overhaul-w7-update.spec.mjs +215 -0
  149. package/tests/browser/overhaul-w7-zoom.spec.mjs +243 -0
  150. package/tests/browser/overview-agent-ownership.spec.mjs +45 -0
  151. package/tests/browser/persistent-ui-layout.spec.mjs +3 -0
  152. package/tests/browser/project-artifact-controller.spec.mjs +324 -0
  153. package/tests/browser/project-artifact-integration.spec.mjs +103 -0
  154. package/tests/browser/project-file-buffer-integration.spec.mjs +230 -0
  155. package/tests/browser/project-git-tools-integration.spec.mjs +369 -0
  156. package/tests/browser/session-fixture.mjs +118 -0
  157. package/tests/browser/session-ownership.spec.mjs +175 -0
  158. package/tests/browser/session-shelves-integration.spec.mjs +219 -0
  159. package/tests/browser/session-shelves.spec.mjs +340 -0
  160. package/tests/browser/session-sidebar-resize.spec.mjs +138 -0
  161. package/tests/browser/session-summary.spec.mjs +17 -12
  162. package/tests/browser/settings-complete-home.spec.mjs +463 -0
  163. package/tests/browser/settings-entrypoint.spec.mjs +104 -0
  164. package/tests/browser/settings-navigation-controller.spec.mjs +383 -0
  165. package/tests/browser/settings-navigation-integration.spec.mjs +348 -0
  166. package/tests/browser/settings-resource-lifetime.spec.mjs +349 -0
  167. package/tests/browser/settings-workspace-integration.spec.mjs +132 -0
  168. package/tests/browser/shell-ownership.spec.mjs +398 -0
  169. package/tests/browser/shell-rollout-fixture.mjs +259 -0
  170. package/tests/browser/shell-rollout.spec.mjs +357 -0
  171. package/tests/browser/shell-tools-launcher.spec.mjs +260 -0
  172. package/tests/browser/shell-workspace.spec.mjs +433 -0
  173. package/tests/browser/side-panel-section-reorder.spec.mjs +3 -1
  174. package/tests/browser/sidebar-floating-tooltips.spec.mjs +37 -0
  175. package/tests/browser/sidebar-update-integration.spec.mjs +277 -0
  176. package/tests/browser/sidebar-update-menu.spec.mjs +402 -0
  177. package/tests/browser/sidebar-update-progress.spec.mjs +472 -0
  178. package/tests/browser/stream-output-isolation.spec.mjs +6 -3
  179. package/tests/browser/themed-selects.spec.mjs +297 -0
  180. package/tests/browser/thread-start-flow.spec.mjs +481 -0
  181. package/tests/browser/ui-polish-activity-controls.spec.mjs +177 -0
  182. package/tests/browser/ui-polish-features.spec.mjs +85 -0
  183. package/tests/browser/ui-polish-file-header.spec.mjs +43 -0
  184. package/tests/browser/ui-polish-local-git.spec.mjs +183 -0
  185. package/tests/browser/ui-polish-mobile-recovery.spec.mjs +36 -0
  186. package/tests/browser/ui-polish-navigation.spec.mjs +127 -0
  187. package/tests/browser/ui-polish-session-actions.spec.mjs +282 -0
  188. package/tests/browser/user-noticeable-fixes.spec.mjs +10 -3
  189. package/tests/browser/windows-drive-parent.spec.mjs +4 -2
  190. package/tests/browser/workspace-draft-selection.spec.mjs +266 -0
  191. package/tests/codex-fast-mode-static.test.mjs +16 -11
  192. package/tests/codex-speed-mode-browser-state.test.mjs +6 -3
  193. package/tests/codex-usage-source.test.mjs +4 -3
  194. package/tests/component-update-api-static.test.mjs +2 -2
  195. package/tests/composer-action-grid-reorder-static.test.mjs +3 -3
  196. package/tests/control-deck-component-updates-static.test.mjs +9 -4
  197. package/tests/control-visibility-static.test.mjs +3 -3
  198. package/tests/controls-layout-static.test.mjs +5 -5
  199. package/tests/conversation-overview-adapter.test.mjs +100 -0
  200. package/tests/document-artifact-static.test.mjs +2 -1
  201. package/tests/draft-conversations.test.mjs +205 -0
  202. package/tests/empty-startup-launcher.test.mjs +197 -0
  203. package/tests/events-tree-context-menu-static.test.mjs +22 -18
  204. package/tests/fake-pi-session-ownership.test.mjs +302 -0
  205. package/tests/fast-mode-client-static.test.mjs +1 -1
  206. package/tests/feature-decision-output-popup-static.test.mjs +2 -2
  207. package/tests/feature-system-prompt-optional-feature-static.test.mjs +1 -1
  208. package/tests/file-viewer-image-static.test.mjs +15 -11
  209. package/tests/file-viewer-search-static.test.mjs +5 -5
  210. package/tests/fixtures/fake-pi.mjs +41 -9
  211. package/tests/footer-provider-usage-visual-static.test.mjs +7 -6
  212. package/tests/foreground-transcript-catch-up-static.test.mjs +7 -4
  213. package/tests/git-footer-context-menu-static.test.mjs +1 -1
  214. package/tests/git-panel-file-preview-static.test.mjs +41 -48
  215. package/tests/git-panel-live-updates-static.test.mjs +2 -1
  216. package/tests/git-workflow-dispatch.test.mjs +66 -0
  217. package/tests/git-workflow-preferences.test.mjs +9 -1
  218. package/tests/guided-git-activation-static.test.mjs +14 -11
  219. package/tests/guided-git-fallback-ui-static.test.mjs +8 -5
  220. package/tests/guided-git-message-reliability-static.test.mjs +10 -6
  221. package/tests/guided-git-publication-backend-static.test.mjs +16 -11
  222. package/tests/http-endpoints-harness.test.mjs +21 -9
  223. package/tests/interaction-state-stability-static.test.mjs +4 -3
  224. package/tests/intercom-conversation-viewer-static.test.mjs +29 -17
  225. package/tests/intercom-tag-layout-static.test.mjs +13 -12
  226. package/tests/intercom-tag-overflow-layout.test.mjs +11 -10
  227. package/tests/main-output-loading-static.test.mjs +4 -4
  228. package/tests/middle-button-drag-scroll-static.test.mjs +3 -3
  229. package/tests/mobile-compact-layout.test.mjs +2 -2
  230. package/tests/mobile-continuity-tablet-static.test.mjs +3 -3
  231. package/tests/mobile-foundation-static.test.mjs +10 -7
  232. package/tests/mobile-phone-experience-static.test.mjs +3 -2
  233. package/tests/mobile-static.test.mjs +173 -135
  234. package/tests/model-catalog-order.test.mjs +103 -0
  235. package/tests/native-parity.test.mjs +6 -4
  236. package/tests/native-session-choice-owner.test.mjs +102 -0
  237. package/tests/native-update-lifecycle.test.mjs +10 -5
  238. package/tests/no-project-http-harness.test.mjs +328 -0
  239. package/tests/no-project-navigation.test.mjs +54 -0
  240. package/tests/no-project-workspaces.test.mjs +77 -0
  241. package/tests/open-issue-wizard-static.test.mjs +1 -1
  242. package/tests/optional-feature-migration-frontend.test.mjs +4 -4
  243. package/tests/optional-feature-prompt-impact-static.test.mjs +3 -3
  244. package/tests/package-updates.test.mjs +630 -0
  245. package/tests/persistent-ui-layout-static.test.mjs +3 -3
  246. package/tests/platform-event-stream.test.mjs +253 -0
  247. package/tests/project-file-viewer-controller.test.mjs +652 -0
  248. package/tests/project-git-tools-adapter.test.mjs +103 -0
  249. package/tests/project-git-tools-controller.test.mjs +577 -0
  250. package/tests/project-runners-controller.test.mjs +453 -0
  251. package/tests/prompt-input-vertical-scroll-static.test.mjs +3 -3
  252. package/tests/prompt-routing-input-clear-static.test.mjs +2 -2
  253. package/tests/questionnaire-dialog.test.mjs +6 -6
  254. package/tests/queue-edit-reorder-static.test.mjs +48 -51
  255. package/tests/rpc-supervisor-host.test.mjs +4 -1
  256. package/tests/safety-guard-auto-review-static.test.mjs +1 -1
  257. package/tests/sampling-native-controls-user-flow.test.mjs +7 -1
  258. package/tests/server-app-runners.test.mjs +536 -0
  259. package/tests/server-codex-fast-mode.test.mjs +346 -0
  260. package/tests/server-conversation-mode.test.mjs +386 -0
  261. package/tests/server-conversation-voice.test.mjs +426 -0
  262. package/tests/server-extension-ui-requests.test.mjs +357 -0
  263. package/tests/server-git-generation.test.mjs +558 -0
  264. package/tests/server-git-mutations.test.mjs +729 -0
  265. package/tests/server-git-reads.test.mjs +381 -0
  266. package/tests/server-git-worktree-sessions.test.mjs +502 -0
  267. package/tests/server-helper-requests.test.mjs +364 -0
  268. package/tests/server-rpc-transports.test.mjs +553 -0
  269. package/tests/server-settings-store.test.mjs +132 -0
  270. package/tests/server-shell-rollout.test.mjs +478 -0
  271. package/tests/server-sse-delivery.test.mjs +410 -0
  272. package/tests/server-workspace-files.test.mjs +546 -0
  273. package/tests/session-attention-scheduler.test.mjs +514 -0
  274. package/tests/session-composer-store.test.mjs +153 -0
  275. package/tests/session-context.test.mjs +134 -0
  276. package/tests/session-extension-requests.test.mjs +193 -0
  277. package/tests/session-ownership-adapter.test.mjs +130 -0
  278. package/tests/session-sampling-ui-static.test.mjs +10 -4
  279. package/tests/session-send-lifetime.test.mjs +140 -0
  280. package/tests/session-shelf-state.test.mjs +348 -0
  281. package/tests/session-shelves-adapter.test.mjs +79 -0
  282. package/tests/session-summary-lifetime.test.mjs +54 -0
  283. package/tests/settings-resource-controller.test.mjs +548 -0
  284. package/tests/shell-action-adapter.test.mjs +169 -0
  285. package/tests/shell-actions.test.mjs +182 -0
  286. package/tests/shell-navigation.test.mjs +348 -0
  287. package/tests/shell-preferences.test.mjs +367 -0
  288. package/tests/side-panel-section-height-removal-static.test.mjs +3 -3
  289. package/tests/stream-output-isolation-static.test.mjs +1 -1
  290. package/tests/subagent-gate-visibility.test.mjs +1 -1
  291. package/tests/subagent-launch-slot-state.test.mjs +2 -2
  292. package/tests/subagent-launch-slots-static.test.mjs +1 -1
  293. package/tests/subagent-observability-static.test.mjs +2 -2
  294. package/tests/subagent-reliability-integration.test.mjs +13 -30
  295. package/tests/syntax-highlighting-static.test.mjs +3 -3
  296. package/tests/tab-close-continuity-static.test.mjs +1 -1
  297. package/tests/tab-metadata-ordering.test.mjs +99 -0
  298. package/tests/terminal-cwd-grouping-static.test.mjs +2 -2
  299. package/tests/terminal-tab-prompt-tooltip-static.test.mjs +2 -0
  300. package/tests/terminal-tab-workspace-static.test.mjs +5 -4
  301. package/tests/terminal-tabs-resize-static.test.mjs +1 -1
  302. package/tests/theme-customizer-static.test.mjs +1 -1
  303. package/tests/thread-display-title.test.mjs +44 -0
  304. package/tests/update-api-harness.test.mjs +15 -14
  305. package/tests/update-tab-restore-harness.test.mjs +3 -0
  306. package/tests/webui-settings-locking.test.mjs +2 -2
  307. package/tests/windows-drive-cwd-picker-static.test.mjs +7 -9
  308. package/tests/workspace-choices.test.mjs +114 -0
  309. package/tests/workspace-save-load-static.test.mjs +7 -4
@@ -0,0 +1,357 @@
1
+ import { navigateFocused } from './focused-navigation-fixture.mjs';
2
+ import { expect } from "@playwright/test";
3
+ import { capture, holdMetadata, INTERFACE_PATH, settleStartup, SHELL_KEY, shellWrites, test } from "./shell-rollout-fixture.mjs";
4
+
5
+ test.use({ video: "off", serviceWorkers: "block" });
6
+ test.setTimeout(45_000);
7
+
8
+ const preference = desktopLayout => JSON.stringify({ v: 1, desktopLayout });
9
+ const destinations = page => page.getByRole("navigation", { name: "Workspace destinations" });
10
+
11
+ async function open(rollout, options, query = "") {
12
+ const client = await rollout.newPage(options);
13
+ await client.page.goto(`${client.origin}/${query}`);
14
+ await settleStartup(client.page, client.audit);
15
+ return client;
16
+ }
17
+
18
+ async function chooseDesktop(page, layout) {
19
+ if (await page.locator("#focusedWorkspace").isVisible()) {
20
+ await navigateFocused(page, 'Settings');
21
+ } else if (!await page.locator("#desktopShellSelect").isVisible()) {
22
+ await page.locator("#sidePanelSectionToggleControls").click();
23
+ }
24
+ await expect(page.locator("#desktopShellSelect")).toBeVisible();
25
+ await page.locator("#desktopShellSelect").selectOption(layout);
26
+ }
27
+
28
+ for (const [state, cohort] of [
29
+ ["fresh", "fresh"], ["established", "established"], ["legacy", "established"],
30
+ ["legacy-root", "established"], ["xdg-state", "established"], ["agent-root", "established"],
31
+ ["unknown", null], ["custom", "established"],
32
+ ]) {
33
+ test.describe(`unmocked ${state} installation`, () => {
34
+ test.use({ rolloutState: state });
35
+ test(`existing interface response reports ${String(cohort)} conservatively`, async ({ rollout }) => {
36
+ const data = await rollout.readInterface();
37
+ expect(data).toHaveProperty("shellRolloutCohort", cohort);
38
+ expect(Object.keys(data).sort()).toEqual(["layout", "layoutRevision", "preferences", "shellRolloutCohort"].sort());
39
+ if (state === "custom") return;
40
+ const before = await rollout.rawSettings();
41
+ expect(await rollout.readInterface()).toEqual(data);
42
+ expect(await rollout.rawSettings(), "Reading metadata must not rewrite settings").toEqual(before);
43
+ if (state === "legacy") {
44
+ expect(data.preferences.sidePanelWidth).toBe(420);
45
+ expect(before.rolloutFixture).toBe("legacy-preserved");
46
+ }
47
+ if (state === "unknown") expect(before.shellRollout).toEqual({ version: 99, cohort: "fresh" });
48
+ else expect(before.shellRollout).toEqual({ version: 1, cohort });
49
+ });
50
+ });
51
+ }
52
+
53
+ for (const cohort of ["fresh", "established"]) {
54
+ test.describe(`valid persisted ${cohort} marker`, () => {
55
+ test.use({ rolloutState: `marked-${cohort}` });
56
+ test("survives server restart and cannot be changed by browser interface writes", async ({ rollout }) => {
57
+ const before = await rollout.rawSettings();
58
+ await rollout.restart();
59
+ expect((await rollout.rawSettings()).shellRollout).toEqual(before.shellRollout);
60
+ const { page } = await open(rollout);
61
+ for (const body of [
62
+ { shellRollout: { version: 1, cohort: cohort === "fresh" ? "established" : "fresh" } },
63
+ { shellRolloutCohort: "fresh" },
64
+ ]) {
65
+ const result = await page.evaluate(async ({ endpoint, body }) => {
66
+ const response = await fetch(endpoint, { method: "PUT", headers: { "Content-Type": "application/json" }, body: JSON.stringify(body) });
67
+ return { status: response.status, payload: await response.json() };
68
+ }, { endpoint: INTERFACE_PATH, body });
69
+ expect(result.status).toBe(400);
70
+ expect(result.payload.ok).toBe(false);
71
+ }
72
+ expect((await rollout.rawSettings()).shellRollout).toEqual(before.shellRollout);
73
+ expect((await rollout.rawSettings()).rolloutFixture).toBe("marker-preserved");
74
+ expect(await rollout.readInterface()).toHaveProperty("shellRolloutCohort", cohort);
75
+ });
76
+ });
77
+ }
78
+
79
+ test("a proven fresh installation defaults to Focused without persisting a browser preference", async ({ rollout }, testInfo) => {
80
+ const { page } = await open(rollout);
81
+ await capture(page, testInfo, "fresh-desktop-observed");
82
+ expect(await page.evaluate(key => localStorage.getItem(key), SHELL_KEY)).toBeNull();
83
+ expect(await shellWrites(page)).toEqual([]);
84
+ await expect(page.locator("#focusedWorkspace")).toBeVisible();
85
+ });
86
+
87
+ for (const scenario of ["new context", "cleared storage", "alternate localhost origin"]) {
88
+ test(`fresh defaults return in ${scenario} after a real explicit Classic choice`, async ({ rollout }) => {
89
+ const first = await open(rollout);
90
+ await chooseDesktop(first.page, "classic");
91
+ await expect(first.page.locator("#focusedWorkspace")).toBeHidden();
92
+ expect(await shellWrites(first.page)).toHaveLength(1);
93
+ await first.page.reload();
94
+ await settleStartup(first.page, first.audit);
95
+ await expect(first.page.locator("#focusedWorkspace")).toBeHidden();
96
+ expect(await first.page.evaluate(key => localStorage.getItem(key), SHELL_KEY)).toBe(preference("classic"));
97
+ expect(await shellWrites(first.page)).toEqual([]);
98
+ let client;
99
+ if (scenario === "cleared storage") {
100
+ await first.page.evaluate(() => localStorage.clear());
101
+ await first.page.reload();
102
+ await settleStartup(first.page, first.audit);
103
+ client = first;
104
+ } else {
105
+ client = await open(rollout, { origin: scenario === "new context" ? rollout.baseURL : rollout.alternateURL });
106
+ expect(await first.page.evaluate(key => localStorage.getItem(key), SHELL_KEY)).toBe(preference("classic"));
107
+ }
108
+ expect(await client.page.evaluate(key => localStorage.getItem(key), SHELL_KEY)).toBeNull();
109
+ expect(await shellWrites(client.page)).toEqual([]);
110
+ await expect(client.page.locator("#focusedWorkspace")).toBeVisible();
111
+ });
112
+ }
113
+
114
+ for (const state of ["established", "legacy", "unknown", "custom"]) {
115
+ test.describe(`${state} browser default`, () => {
116
+ test.use({ rolloutState: state });
117
+ test("keeps Classic in clean and alternate-origin contexts without an implicit preference", async ({ rollout }, testInfo) => {
118
+ for (const origin of [rollout.baseURL, rollout.alternateURL]) {
119
+ const { page } = await open(rollout, { origin });
120
+ await expect(page.locator("#focusedWorkspace")).toBeHidden();
121
+ await expect(page.locator("#promptInput")).toBeVisible();
122
+ expect(await page.evaluate(key => localStorage.getItem(key), SHELL_KEY)).toBeNull();
123
+ expect(await shellWrites(page)).toEqual([]);
124
+ }
125
+ if (state === "unknown") {
126
+ const { page } = await open(rollout);
127
+ await capture(page, testInfo, "unknown-marker-classic");
128
+ }
129
+ });
130
+ });
131
+ }
132
+
133
+ for (const [name, raw, expected] of [
134
+ ["explicit Classic", preference("classic"), "classic"],
135
+ ["explicit Focused", preference("focused"), "focused"],
136
+ ["malformed record", "{broken", "classic"],
137
+ ["future record", JSON.stringify({ v: 99, desktopLayout: "focused" }), "classic"],
138
+ ["invalid optional field", JSON.stringify({ v: 1, desktopLayout: "focused", navigation: "future" }), "classic"],
139
+ ]) {
140
+ test(`${name} wins over fresh metadata and remains byte-for-byte unchanged`, async ({ rollout }) => {
141
+ const { page, audit } = await open(rollout, { storage: { [SHELL_KEY]: raw } });
142
+ await expect(page.locator("#focusedWorkspace")).toBeVisible({ visible: expected === "focused" });
143
+ expect(await page.evaluate(key => localStorage.getItem(key), SHELL_KEY)).toBe(raw);
144
+ expect(await shellWrites(page)).toEqual([]);
145
+ await page.reload();
146
+ await settleStartup(page, audit);
147
+ await expect(page.locator("#focusedWorkspace")).toBeVisible({ visible: expected === "focused" });
148
+ expect(await page.evaluate(key => localStorage.getItem(key), SHELL_KEY)).toBe(raw);
149
+ expect(await shellWrites(page)).toEqual([]);
150
+ });
151
+ }
152
+
153
+ test("unavailable shell storage stays Classic without a repair write", async ({ rollout }, testInfo) => {
154
+ testInfo.annotations.push({ type: "fault injection", description: "Only the shell preference getItem throws SecurityError; the rest of storage remains live." });
155
+ const { page } = await open(rollout, { unavailable: true });
156
+ await expect(page.locator("#focusedWorkspace")).toBeHidden();
157
+ await expect(page.locator("#promptInput")).toBeVisible();
158
+ expect(await shellWrites(page)).toEqual([]);
159
+ });
160
+
161
+ for (const metadata of ["old-server", "unavailable"]) {
162
+ test(`${metadata} metadata conservatively keeps an absent preference Classic`, async ({ rollout }, testInfo) => {
163
+ testInfo.annotations.push({ type: "HTTP mock", description: `${metadata}: only GET ${INTERFACE_PATH}; all mutations and other endpoints stay real.` });
164
+ const { page, audit } = await rollout.newPage();
165
+ await page.route(url => url.pathname === INTERFACE_PATH, async route => {
166
+ if (route.request().method() !== "GET") return route.continue();
167
+ if (metadata === "unavailable") return route.fulfill({ status: 503, json: { ok: false, error: "Fixture metadata unavailable" } });
168
+ const response = await route.fetch();
169
+ const payload = await response.json();
170
+ delete payload.data.shellRolloutCohort;
171
+ await route.fulfill({ response, json: payload });
172
+ });
173
+ await page.goto(rollout.baseURL);
174
+ await settleStartup(page, audit);
175
+ await expect(page.locator("#focusedWorkspace")).toBeHidden();
176
+ expect(await shellWrites(page)).toEqual([]);
177
+ });
178
+ }
179
+
180
+ for (const explicit of [null, "focused"]) {
181
+ test(`Classic URL recovery wins across all viewports with ${explicit ? "an explicit Focused" : "an absent"} preference`, async ({ rollout }, testInfo) => {
182
+ const storage = explicit ? { [SHELL_KEY]: preference(explicit) } : {};
183
+ const { page, audit } = await open(rollout, { storage }, "?shell=classic&mobileShell=v2&tabletShell=v2");
184
+ await page.locator("#promptInput").fill("recovery keeps this draft");
185
+ await page.locator("#promptInput").evaluate(node => { window.rolloutPrompt = node; });
186
+ for (const width of [390, 820, 1440]) {
187
+ await page.setViewportSize({ width, height: 900 });
188
+ await expect(page.locator("#focusedWorkspace")).toBeHidden();
189
+ await expect(page.locator("#mobileShellV2")).toBeHidden();
190
+ await expect(page.locator("#promptInput")).toHaveValue("recovery keeps this draft");
191
+ expect(await page.locator("#promptInput").evaluate(node => node === window.rolloutPrompt)).toBe(true);
192
+ }
193
+ expect(await shellWrites(page)).toEqual([]);
194
+ expect(await page.evaluate(key => localStorage.getItem(key), SHELL_KEY)).toBe(explicit ? preference(explicit) : null);
195
+ if (explicit) await capture(page, testInfo, "classic-recovery");
196
+ await page.goto(rollout.baseURL);
197
+ await settleStartup(page, audit);
198
+ await expect(page.locator("#focusedWorkspace")).toBeVisible();
199
+ });
200
+ }
201
+
202
+ test("real layout controls keep canonical composer, draft and settings nodes through rollback and reload", async ({ rollout }, testInfo) => {
203
+ const { page, audit } = await open(rollout, { storage: { [SHELL_KEY]: preference("focused") } });
204
+ await page.locator("#promptInput").fill("W7 canonical draft survives presentation changes");
205
+ await page.evaluate(() => {
206
+ window.rolloutNodes = Object.fromEntries(["promptInput", "sendButton", "modelSelect", "desktopShellSelect"].map(id => [id, document.getElementById(id)]));
207
+ });
208
+ await chooseDesktop(page, "classic");
209
+ await expect(page.locator("#focusedWorkspace")).toBeHidden();
210
+ await expect(page.locator("#promptInput")).toHaveValue("W7 canonical draft survives presentation changes");
211
+ await chooseDesktop(page, "focused");
212
+ await destinations(page).getByRole("button", { name: "Conversation", exact: true }).click();
213
+ await expect(page.locator("#promptInput")).toHaveValue("W7 canonical draft survives presentation changes");
214
+ expect(await page.evaluate(() => Object.entries(window.rolloutNodes).every(([id, node]) => node === document.getElementById(id) && document.querySelectorAll(`#${id}`).length === 1))).toBe(true);
215
+ expect((await shellWrites(page)).map(write => JSON.parse(write.value).desktopLayout)).toEqual(["classic", "focused"]);
216
+ await capture(page, testInfo, "explicit-focused-canonical-draft");
217
+ await chooseDesktop(page, "classic");
218
+ await page.reload();
219
+ await settleStartup(page, audit);
220
+ await expect(page.locator("#focusedWorkspace")).toBeHidden();
221
+ expect(await page.evaluate(key => localStorage.getItem(key), SHELL_KEY)).toBe(preference("classic"));
222
+ expect(await shellWrites(page)).toEqual([]);
223
+ });
224
+
225
+ test("delayed real fresh metadata preserves the initial Focused deep link, canonical draft and Back history", async ({ rollout }, testInfo) => {
226
+ testInfo.annotations.push({ type: "HTTP delay", description: "Only real interface GET responses are held, with an eight-second maximum; no payload is changed." });
227
+ const { page, audit } = await rollout.newPage();
228
+ const gate = await holdMetadata(page);
229
+ try {
230
+ await page.goto(`${rollout.baseURL}/?view=project&inspector=files`);
231
+ await gate.seen;
232
+ await expect(page.locator("#modelSelect")).not.toBeEmpty();
233
+ await page.locator("#promptInput").fill("draft entered before cohort hydration");
234
+ await page.evaluate(() => {
235
+ window.rolloutPrompt = document.getElementById("promptInput");
236
+ window.rolloutFiles = document.getElementById("fileTreeSearchInput");
237
+ });
238
+ gate.release();
239
+ await settleStartup(page, audit);
240
+ expect(gate.expired).toBe(false);
241
+ await capture(page, testInfo, "delayed-deep-link-observed");
242
+ await expect(page.locator("#focusedWorkspace")).toBeVisible();
243
+ await expect(page.locator("#focusedWorkspace")).toHaveAttribute("data-destination", "project");
244
+ await expect(page.locator("#fileTreeSearchInput")).toBeVisible();
245
+ await page.locator("#fileTreeSearchInput").fill("retain W7 file filter");
246
+ const mutationsAfterMigration = audit.mutations.length;
247
+ await navigateFocused(page, 'Settings');
248
+ await expect(page.locator("#desktopShellSelect")).toBeVisible();
249
+ await page.goBack();
250
+ await expect(page.locator("#focusedWorkspace")).toHaveAttribute("data-destination", "project");
251
+ await expect(page).toHaveURL(/\?view=project&inspector=files$/);
252
+ await expect(page.locator("#fileTreeSearchInput")).toHaveValue("retain W7 file filter");
253
+ await destinations(page).getByRole("button", { name: "Conversation", exact: true }).click();
254
+ await expect(page.locator("#promptInput")).toHaveValue("draft entered before cohort hydration");
255
+ expect(await page.evaluate(() => window.rolloutPrompt === document.getElementById("promptInput") && window.rolloutFiles === document.getElementById("fileTreeSearchInput"))).toBe(true);
256
+ await settleStartup(page, audit);
257
+ expect(audit.mutations.slice(mutationsAfterMigration), "Navigation after the real migration must not save layout").toEqual([]);
258
+ expect(await shellWrites(page)).toEqual([]);
259
+ } finally {
260
+ gate.release();
261
+ }
262
+ });
263
+
264
+ for (const choice of ["classic", "focused"]) {
265
+ test(`an explicit ${choice} control choice wins while real cohort metadata is delayed`, async ({ rollout }, testInfo) => {
266
+ testInfo.annotations.push({ type: "HTTP delay", description: "Real interface GET responses held for at most eight seconds while a desktop layout control is used." });
267
+ const { page, audit } = await rollout.newPage();
268
+ const gate = await holdMetadata(page);
269
+ try {
270
+ await page.goto(rollout.baseURL);
271
+ await gate.seen;
272
+ await expect(page.locator("#modelSelect")).not.toBeEmpty();
273
+ await chooseDesktop(page, choice);
274
+ expect(await page.evaluate(key => localStorage.getItem(key), SHELL_KEY)).toBe(preference(choice));
275
+ const beforeHydration = await shellWrites(page);
276
+ expect(beforeHydration).toHaveLength(1);
277
+ gate.release();
278
+ await settleStartup(page, audit);
279
+ expect(gate.expired).toBe(false);
280
+ await expect(page.locator("#focusedWorkspace")).toBeVisible({ visible: choice === "focused" });
281
+ expect(await page.evaluate(key => localStorage.getItem(key), SHELL_KEY)).toBe(preference(choice));
282
+ expect(await shellWrites(page), "Late hydration cannot overwrite the explicit control choice").toEqual(beforeHydration);
283
+ } finally {
284
+ gate.release();
285
+ }
286
+ });
287
+ }
288
+
289
+ for (const [phone, tablet] of [["preview", "legacy"], ["legacy", "preview"]]) {
290
+ test(`fresh desktop rollout leaves phone=${phone} and tablet=${tablet} independent`, async ({ rollout }, testInfo) => {
291
+ const { page } = await open(rollout, {
292
+ storage: { "pi-webui-mobile-shell-v2": phone, "pi-webui-tablet-shell-v2": tablet }, viewport: { width: 390, height: 844 },
293
+ });
294
+ await expect(page.locator("#focusedWorkspace")).toBeHidden();
295
+ await expect(page.locator("#mobileShellV2")).toBeVisible({ visible: phone === "preview" });
296
+ await page.locator("#promptInput").fill("independent compact mode draft");
297
+ await page.locator("#promptInput").evaluate(node => { window.rolloutPrompt = node; });
298
+ await page.setViewportSize({ width: 820, height: 1180 });
299
+ await expect(page.locator("#focusedWorkspace")).toBeHidden();
300
+ await expect(page.locator("#mobileShellV2")).toBeVisible({ visible: tablet === "preview" });
301
+ if (tablet === "preview") await capture(page, testInfo, "independent-tablet-mode");
302
+ await page.setViewportSize({ width: 1440, height: 900 });
303
+ await expect(page.locator("#focusedWorkspace")).toBeVisible();
304
+ await expect(page.locator("#mobileShellV2")).toBeHidden();
305
+ await expect(page.locator("#promptInput")).toHaveValue("independent compact mode draft");
306
+ expect(await page.locator("#promptInput").evaluate(node => node === window.rolloutPrompt)).toBe(true);
307
+ expect(await page.evaluate(() => [localStorage.getItem("pi-webui-mobile-shell-v2"), localStorage.getItem("pi-webui-tablet-shell-v2")])).toEqual([phone, tablet]);
308
+ expect(await shellWrites(page)).toEqual([]);
309
+ });
310
+ }
311
+
312
+ test.describe("metadata-only hydration", () => {
313
+ test.use({ rolloutState: "established" });
314
+ test("does not need a layout revision and causes no preference, layout or pending-journal write", async ({ rollout }, testInfo) => {
315
+ testInfo.annotations.push({ type: "HTTP mock", description: "After real startup migration, interface GET supplies fresh cohort metadata, null width/layout and no layoutRevision. The width cache is removed before reload to isolate cohort-only hydration. All mutations remain real and are counted." });
316
+ const { page, audit } = await open(rollout);
317
+ const serverBefore = await rollout.readInterface();
318
+ await page.evaluate(() => localStorage.removeItem("pi-webui-side-panel-width"));
319
+ const mutationStart = audit.mutations.length;
320
+ const gate = await holdMetadata(page, payload => {
321
+ const data = { ...payload.data, preferences: { sidePanelWidth: null }, shellRolloutCohort: "fresh", layout: null };
322
+ delete data.layoutRevision;
323
+ return { ...payload, data };
324
+ });
325
+ try {
326
+ await page.reload();
327
+ await gate.seen;
328
+ await expect(page.locator("#modelSelect")).not.toBeEmpty();
329
+ // Let synchronous cache startup finish while the metadata response is held.
330
+ await page.waitForTimeout(350);
331
+ const storageStart = await page.evaluate(() => window.rolloutStorageWrites.length);
332
+ gate.release();
333
+ await settleStartup(page, audit);
334
+ expect(gate.expired).toBe(false);
335
+ await capture(page, testInfo, "metadata-only-hydration-observed");
336
+ await expect.soft(page.locator("#focusedWorkspace")).toBeVisible();
337
+ expect(await shellWrites(page)).toEqual([]);
338
+ expect(audit.mutations.slice(mutationStart), "Every interface mutation since reload is counted, including migration").toEqual([]);
339
+ const layoutWrites = await page.evaluate(start => {
340
+ const keys = new Set([
341
+ "pi-webui-control-deck-layout-v2", "pi-webui-side-panel-width", "pi-webui-file-viewer-width",
342
+ "pi-webui-composer-action-order-v1", "pi-webui-composer-action-layout-v2", "pi-webui-control-visibility-hidden-ids-v1",
343
+ "pi-webui-terminal-tabs-layout", "pi-webui-terminal-custom-groups-v1", "pi-webui-terminal-tabs-sidebar-width",
344
+ "pi-webui-footer-scoped-model-order-v1", "pi-webui-side-panel-collapsed", "pi-webui-side-panel-sections-collapsed",
345
+ "pi-webui-side-panel-sections-hidden", "pi-webui-side-panel-section-order-v1",
346
+ ]);
347
+ return window.rolloutStorageWrites.slice(start).filter(write => write.method === "clear" || keys.has(write.key) || write.key?.startsWith("pi-webui-ui-layout-pending-"));
348
+ }, storageStart);
349
+ expect(layoutWrites, "Metadata alone must not write layout caches or mutation journals").toEqual([]);
350
+ const serverAfter = await rollout.readInterface();
351
+ expect(serverAfter.layout).toEqual(serverBefore.layout);
352
+ expect(serverAfter.layoutRevision).toBe(serverBefore.layoutRevision);
353
+ } finally {
354
+ gate.release();
355
+ }
356
+ });
357
+ });
@@ -0,0 +1,260 @@
1
+ import { readFile } from 'node:fs/promises';
2
+ import { expect, test } from '@playwright/test';
3
+
4
+ test.use({ video: 'off', launchOptions: { executablePath: '/usr/bin/chromium' } });
5
+
6
+ const sources = new Map(await Promise.all([
7
+ 'shell-tools-launcher.mjs', 'shell-actions.mjs', 'shell-tools-launcher.css', 'styles.css',
8
+ ].map(async (name) => [`/${name}`, await readFile(new URL(`../../public/${name}`, import.meta.url), 'utf8')])));
9
+
10
+ const fixture = `<!doctype html><html lang="en"><head><meta charset="utf-8">
11
+ <meta name="viewport" content="width=device-width, initial-scale=1"><title>All tools contract fixture</title>
12
+ <link rel="stylesheet" href="/styles.css"><link rel="stylesheet" href="/shell-tools-launcher.css">
13
+ <style>body{margin:0;background:var(--bg);color:var(--text)}
14
+ #trigger{margin:20px}.fixture-run{display:flex;align-items:center;justify-content:space-between;gap:8px;font-size:12px}
15
+ .fixture-run button{flex-shrink:0;color:var(--danger)}
16
+ html.light{color-scheme:light;--bg:#eff1f5;--text:#4c4f69;--muted:#626880;--border:#bcc0cc;--panel:#e6e9ef;--panel-2:#dce0e8;--panel-3:#eff1f5;--accent:#8839ef;--accent-2:#179299;--warning:#805600;--danger:#d20f39;--shadow:#4c4f6933}</style>
17
+ </head><body><button id="trigger">All tools</button><div id="retained"></div>
18
+ <script type="module">
19
+ import { createToolsLauncher } from '/shell-tools-launcher.mjs';
20
+ window.invocations = []; window.pinChanges = []; window.closes = 0;
21
+ window.target = Object.freeze({ tabId: 'fixture-tab', generation: 8, sessionIdentity: 'fixture-session', cwd: '/fixture' });
22
+ window.actions = [
23
+ { id: 'files', label: 'Files & search', description: 'Browse and edit project files', category: 'Project', keywords: 'directory annotate', available: true, target },
24
+ { id: 'compact', label: 'Compact context', description: 'Reduce the current context', category: 'Sessions', keywords: 'tokens', available: false, unavailableReason: 'Compaction is already running.', target },
25
+ { id: 'queue', label: 'Follow-up queue', description: 'Review prompts waiting for this session', category: 'Activity', keywords: 'steer reorder', available: true, target },
26
+ { id: 'theme', label: 'Appearance', description: 'Change colors and backgrounds', category: 'Settings', keywords: 'theme light dark', available: true },
27
+ ];
28
+ window.launcher = createToolsLauncher({ document,
29
+ onInvoke(action) { invocations.push({ id: action.id, original: actions.includes(action), sameTarget: action.target === target }); },
30
+ onPinsChange(ids) { pinChanges.push(ids); }, onClose() { closes += 1; },
31
+ });
32
+ window.runControls = launcher.slots.runControls;
33
+ window.run = document.createElement('div'); run.className = 'fixture-run';
34
+ const runLabel = document.createElement('span'); runLabel.textContent = 'Fixture session · Response running';
35
+ window.stop = document.createElement('button'); stop.textContent = 'Stop fixture response'; stop.type = 'button';
36
+ window.stops = 0; stop.addEventListener('click', () => { stops += 1; });
37
+ run.append(runLabel, stop); runControls.append(run);
38
+ window.detachedAtConstruction = !launcher.element.isConnected;
39
+ document.body.append(launcher.element);
40
+ window.snapshot = () => ({ actions, pinnedIds: ['queue'], contextLabel: 'Fixture session · /fixture' });
41
+ document.getElementById('trigger').addEventListener('click', () => launcher.open(snapshot()));
42
+ window.ready = true;
43
+ </script></body></html>`;
44
+
45
+ test.beforeEach(async ({ page }) => {
46
+ const errors = [];
47
+ page.on('pageerror', (error) => errors.push(error.message));
48
+ await page.route('http://tools.test/**', async (route) => {
49
+ const pathname = new URL(route.request().url()).pathname;
50
+ const source = sources.get(pathname);
51
+ await route.fulfill({ status: source || pathname === '/' ? 200 : 404,
52
+ contentType: pathname.endsWith('.mjs') ? 'text/javascript' : pathname.endsWith('.css') ? 'text/css' : 'text/html',
53
+ body: source ?? (pathname === '/' ? fixture : '') });
54
+ });
55
+ await page.goto('http://tools.test/');
56
+ await page.waitForFunction(() => window.ready);
57
+ await page.getByRole('button', { name: 'All tools', exact: true }).click();
58
+ await expect(page.getByRole('searchbox', { name: 'Search all tools' })).toBeFocused();
59
+ page.__launcherErrors = errors;
60
+ });
61
+
62
+ test.afterEach(async ({ page }) => {
63
+ expect(page.__launcherErrors).toEqual([]);
64
+ });
65
+
66
+ const actionButtons = (page) => page.locator('.tools-launcher-action');
67
+ const category = (page, name) => page.getByRole('navigation', { name: 'Tool categories' }).getByRole('button', { name, exact: true });
68
+
69
+ test('uses supplied categories and searches the complete catalog without dropping input focus', async ({ page }) => {
70
+ expect(await page.evaluate(() => detachedAtConstruction)).toBe(true);
71
+ await expect(actionButtons(page)).toHaveCount(4);
72
+ await category(page, 'Project').click();
73
+ await expect(category(page, 'Project')).toBeFocused();
74
+ await expect(actionButtons(page)).toHaveText(['Files & searchBrowse and edit project filesProject']);
75
+ const search = page.getByRole('searchbox');
76
+ await search.fill('steer');
77
+ await expect(actionButtons(page)).toHaveCount(1);
78
+ await expect(actionButtons(page).first()).toHaveAccessibleName('Follow-up queue');
79
+ await expect(search).toBeFocused();
80
+ await expect(page.getByRole('status')).toHaveText('1 results across all tools');
81
+ await search.fill('no match');
82
+ await expect(page.getByText('No matching tools. Try another name or purpose.')).toBeVisible();
83
+ await page.evaluate(() => {
84
+ actions = Array.from({ length: 125 }, (_, index) => ({ id: 'action-' + index,
85
+ label: 'Catalog tool ' + index, description: 'Shared purpose', category: 'Project', keywords: index === 124 ? 'rare-final-intent' : '' }));
86
+ launcher.update({ actions });
87
+ });
88
+ await search.fill('');
89
+ await expect(actionButtons(page)).toHaveCount(125);
90
+ await search.fill('shared purpose');
91
+ await expect(actionButtons(page)).toHaveCount(125);
92
+ await search.fill('rare-final-intent');
93
+ await expect(actionButtons(page)).toHaveCount(1);
94
+ await expect(actionButtons(page)).toHaveAccessibleName('Catalog tool 124');
95
+ await expect(search).toBeFocused();
96
+ });
97
+
98
+ test('emits original action and target references and leaves execution and closing to the parent', async ({ page }) => {
99
+ await page.getByRole('button', { name: 'Files & search', exact: true }).click();
100
+ expect(await page.evaluate(() => invocations)).toEqual([{ id: 'files', original: true, sameTarget: true }]);
101
+ await expect(page.getByRole('dialog')).toBeVisible();
102
+ await page.evaluate(() => {
103
+ const replacement = Object.freeze({ ...actions[0], target: Object.freeze({ ...target, generation: 9 }) });
104
+ actions = [replacement];
105
+ launcher.update({ actions });
106
+ window.expectedAction = replacement;
107
+ window.expectedTarget = replacement.target;
108
+ });
109
+ await page.getByRole('button', { name: 'Files & search', exact: true }).click();
110
+ expect(await page.evaluate(() => invocations[1])).toEqual({ id: 'files', original: true, sameTarget: false });
111
+ expect(await page.evaluate(() => actions[0] === expectedAction && actions[0].target === expectedTarget)).toBe(true);
112
+ });
113
+
114
+ test('renders unavailable reasons and treats all supplied strings as text', async ({ page }) => {
115
+ const disabled = page.getByRole('button', { name: 'Compact context', exact: true });
116
+ await expect(disabled).toBeDisabled();
117
+ await expect(disabled).toHaveAccessibleDescription('Compaction is already running.');
118
+ await expect(page.getByText('Compaction is already running.', { exact: true })).toBeVisible();
119
+ await disabled.evaluate((button) => button.click());
120
+ expect(await page.evaluate(() => invocations)).toEqual([]);
121
+ const unsafe = '<img src=x onerror="window.injected=true">';
122
+ await page.evaluate((unsafe) => {
123
+ actions = [{ id: 'unsafe', label: unsafe, description: unsafe, category: unsafe, available: false, unavailableReason: unsafe }];
124
+ launcher.update({ actions, contextLabel: unsafe });
125
+ }, unsafe);
126
+ await expect(actionButtons(page)).toHaveAccessibleName(unsafe);
127
+ expect(await page.locator('#shellToolsLauncher img').count()).toBe(0);
128
+ expect(await page.evaluate(() => window.injected)).toBeUndefined();
129
+ await expect(category(page, unsafe)).toBeVisible();
130
+ });
131
+
132
+ test('pins and unpins with stable focus and a deduplicated maximum of 20 IDs', async ({ page }) => {
133
+ await page.getByRole('button', { name: 'Pin Files & search', exact: true }).click();
134
+ await expect(page.getByRole('button', { name: 'Unpin Files & search', exact: true })).toBeFocused();
135
+ expect(await page.evaluate(() => pinChanges)).toEqual([['queue', 'files']]);
136
+ await category(page, 'Pinned').click();
137
+ await expect(actionButtons(page)).toHaveCount(2);
138
+ await page.getByRole('button', { name: 'Unpin Files & search', exact: true }).click();
139
+ await expect(page.getByRole('searchbox')).toBeFocused();
140
+ await expect(actionButtons(page)).toHaveCount(1);
141
+ await page.getByRole('button', { name: 'Unpin Follow-up queue', exact: true }).click();
142
+ await expect(page.getByText('No pinned tools. Pin a tool from All to keep it here.')).toBeVisible();
143
+ await page.evaluate(() => {
144
+ actions = Array.from({ length: 22 }, (_, index) => ({ id: 'pin-' + index, label: 'Tool ' + index, category: 'Project' }));
145
+ launcher.update({ actions, pinnedIds: ['pin-0', 'pin-0', ...actions.map((action) => action.id)] });
146
+ });
147
+ await category(page, 'All').click();
148
+ await expect(page.locator('.tools-launcher-pin[aria-pressed="true"]')).toHaveCount(20);
149
+ await expect(page.getByRole('button', { name: 'Pin Tool 20', exact: true })).toBeDisabled();
150
+ await expect(page.getByRole('button', { name: 'Pin Tool 20', exact: true })).toHaveAttribute('title', /20 tools/);
151
+ await page.getByRole('button', { name: 'Unpin Tool 0', exact: true }).click();
152
+ await page.getByRole('button', { name: 'Pin Tool 20', exact: true }).click();
153
+ expect(await page.evaluate(() => pinChanges.at(-1))).toEqual(Array.from({ length: 20 }, (_, i) => 'pin-' + (i + 1)));
154
+ await page.evaluate(() => pinChanges.at(-1).push('pin-21'));
155
+ await category(page, 'Pinned').click();
156
+ await expect(actionButtons(page)).toHaveCount(20);
157
+ });
158
+
159
+ test('keyboard navigation skips unavailable actions and keeps parent run controls reachable', async ({ page }) => {
160
+ await page.keyboard.press('ArrowDown');
161
+ await expect(page.getByRole('button', { name: 'Files & search', exact: true })).toBeFocused();
162
+ await page.keyboard.press('ArrowDown');
163
+ await expect(page.getByRole('button', { name: 'Follow-up queue', exact: true })).toBeFocused();
164
+ await page.keyboard.press('End');
165
+ await expect(page.getByRole('button', { name: 'Appearance', exact: true })).toBeFocused();
166
+ await page.keyboard.press('ArrowDown');
167
+ await expect(page.getByRole('button', { name: 'Files & search', exact: true })).toBeFocused();
168
+ await page.keyboard.press('ArrowUp');
169
+ await expect(page.getByRole('button', { name: 'Appearance', exact: true })).toBeFocused();
170
+ await page.keyboard.press('Home');
171
+ await page.keyboard.press('Enter');
172
+ expect(await page.evaluate(() => invocations.length)).toBe(1);
173
+ await page.getByRole('searchbox').fill('steer');
174
+ await page.keyboard.press('Enter');
175
+ expect(await page.evaluate(() => invocations.at(-1).id)).toBe('queue');
176
+ await page.keyboard.press('Tab');
177
+ await expect(page.getByRole('button', { name: 'Stop fixture response' })).toBeFocused();
178
+ await page.keyboard.press('Enter');
179
+ expect(await page.evaluate(() => stops)).toBe(1);
180
+ await page.evaluate(() => launcher.update({ contextLabel: 'Updated session' }));
181
+ await expect(page.getByRole('button', { name: 'Stop fixture response' })).toBeFocused();
182
+ expect(await page.evaluate(() => launcher.slots.runControls === runControls && run.parentNode === runControls && run.firstChild.nextSibling === stop)).toBe(true);
183
+ await page.keyboard.press('Escape');
184
+ await expect(page.getByRole('dialog')).not.toBeVisible();
185
+ await expect(page.getByRole('button', { name: 'All tools', exact: true })).toBeFocused();
186
+ await expect.poll(() => page.evaluate(() => closes)).toBe(1);
187
+ });
188
+
189
+ test('native modality prevents background focus and close/dispose are idempotent without history changes', async ({ page }) => {
190
+ const before = await page.evaluate(() => ({ length: history.length, href: location.href }));
191
+ await page.evaluate(() => document.getElementById('trigger').focus());
192
+ await expect(page.getByRole('searchbox')).toBeFocused();
193
+ await page.getByRole('button', { name: 'Close All tools' }).focus();
194
+ await page.keyboard.press('Shift+Tab');
195
+ // Chromium can visit browser chrome at the boundary before returning to the native modal.
196
+ if (await page.evaluate(() => !document.hasFocus())) await page.keyboard.press('Shift+Tab');
197
+ await expect(page.locator('.tools-launcher-pin').last()).toBeFocused();
198
+ await page.keyboard.press('Tab');
199
+ if (await page.evaluate(() => !document.hasFocus())) await page.keyboard.press('Tab');
200
+ await expect(page.getByRole('button', { name: 'Close All tools' })).toBeFocused();
201
+ await page.getByRole('button', { name: 'Close All tools' }).click();
202
+ await expect.poll(() => page.evaluate(() => closes)).toBe(1);
203
+ await page.evaluate(() => { launcher.close(); launcher.open(snapshot()); launcher.close(); launcher.open(snapshot()); });
204
+ await expect(page.getByRole('dialog')).toBeVisible();
205
+ expect(await page.evaluate(() => closes)).toBe(2);
206
+ await page.evaluate(() => {
207
+ document.getElementById('retained').append(run);
208
+ window.staleAction = document.querySelector('.tools-launcher-action');
209
+ launcher.dispose(); launcher.dispose(); launcher.open(snapshot()); launcher.update(snapshot()); launcher.close();
210
+ staleAction.click(); stop.click();
211
+ });
212
+ await expect(page.locator('#shellToolsLauncher')).toHaveCount(0);
213
+ expect(await page.evaluate(() => ({ closes, invocations: invocations.length, stops, retained: run.parentNode.id,
214
+ navigation: { length: history.length, href: location.href } }))).toEqual({ closes: 3, invocations: 0, stops: 1, retained: 'retained', navigation: before });
215
+ });
216
+
217
+ for (const [width, height] of [[320, 740], [390, 844], [1100, 800], [1440, 900]]) {
218
+ test(`fits and scrolls at ${width}px with dark and light screenshots`, async ({ page }, testInfo) => {
219
+ await page.setViewportSize({ width, height });
220
+ await page.evaluate(() => {
221
+ actions.push(...Array.from({ length: 40 }, (_, index) => ({ id: 'extra-' + index,
222
+ label: index === 0 ? 'LongUnbrokenActionLabel'.repeat(6) : 'Project fixture ' + index,
223
+ description: 'A long description for checking readable wrapping and scroll access to the complete provided catalog.',
224
+ category: index === 0 ? 'LongUnbrokenCategory'.repeat(5) : 'Project' })));
225
+ launcher.update({ actions, contextLabel: 'Fixture session · ' + '/long-project-path'.repeat(8) });
226
+ });
227
+ await expect(page.getByRole('button', { name: 'Stop fixture response' })).toBeVisible();
228
+ for (const control of [page.getByRole('searchbox'), page.getByRole('button', { name: 'Close All tools' }), page.getByRole('button', { name: 'Stop fixture response' })]) {
229
+ const bounds = await control.boundingBox();
230
+ expect(bounds.x).toBeGreaterThanOrEqual(0);
231
+ expect(bounds.x + bounds.width).toBeLessThanOrEqual(width);
232
+ expect(bounds.y + bounds.height).toBeLessThanOrEqual(height);
233
+ await control.click({ trial: true });
234
+ }
235
+ const geometry = await page.evaluate(() => {
236
+ const dialog = launcher.element.getBoundingClientRect();
237
+ return { left: dialog.left, right: dialog.right, bottom: dialog.bottom,
238
+ docOverflow: document.documentElement.scrollWidth > innerWidth,
239
+ regions: ['.tools-launcher-categories', '.tools-launcher-results'].map((selector) => {
240
+ const region = document.querySelector(selector);
241
+ return { width: region.clientWidth, horizontalOverflow: region.scrollWidth > region.clientWidth,
242
+ scrollable: region.scrollHeight > region.clientHeight };
243
+ }) };
244
+ });
245
+ expect(geometry.left).toBeGreaterThanOrEqual(0);
246
+ expect(geometry.right).toBeLessThanOrEqual(width);
247
+ expect(geometry.bottom).toBeLessThanOrEqual(height);
248
+ expect(geometry.docOverflow).toBe(false);
249
+ expect(geometry.regions.every((region) => region.width > 0 && !region.horizontalOverflow)).toBe(true);
250
+ expect(geometry.regions[1].scrollable).toBe(true);
251
+ await page.screenshot({ path: testInfo.outputPath(`launcher-${width}-dark.png`), animations: 'disabled' });
252
+ await actionButtons(page).last().focus();
253
+ await expect(actionButtons(page).last()).toBeInViewport();
254
+ await page.getByRole('searchbox').fill('steer');
255
+ await expect(actionButtons(page)).toHaveAccessibleName('Follow-up queue');
256
+ await page.getByRole('searchbox').fill('');
257
+ await page.evaluate(() => document.documentElement.classList.add('light'));
258
+ await page.screenshot({ path: testInfo.outputPath(`launcher-${width}-light.png`), animations: 'disabled' });
259
+ });
260
+ }