@firstpick/pi-package-webui 0.11.1 → 0.11.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (309) hide show
  1. package/DEVELOPMENT.md +151 -12
  2. package/README.md +34 -6
  3. package/TECHNICAL.md +75 -8
  4. package/bin/pi-webui.mjs +5390 -11423
  5. package/index.ts +10 -3
  6. package/lib/component-update-state.mjs +2 -2
  7. package/lib/git-workflow-preference-values.mjs +122 -0
  8. package/lib/git-workflow-preferences.mjs +35 -563
  9. package/lib/package-updates.mjs +260 -0
  10. package/lib/rpc-supervisor-client.mjs +8 -4
  11. package/lib/server/app-runners.mjs +1667 -0
  12. package/lib/server/codex-fast-mode.mjs +161 -0
  13. package/lib/server/conversation-mode.mjs +218 -0
  14. package/lib/server/conversation-voice.mjs +318 -0
  15. package/lib/server/extension-ui-requests.mjs +114 -0
  16. package/lib/server/git-generation.mjs +459 -0
  17. package/lib/server/git-mutations.mjs +1827 -0
  18. package/lib/server/git-reads.mjs +608 -0
  19. package/lib/server/git-worktree-sessions.mjs +408 -0
  20. package/lib/server/helper-requests.mjs +82 -0
  21. package/lib/server/no-project-workspaces.mjs +103 -0
  22. package/lib/server/rpc-transports.mjs +394 -0
  23. package/lib/server/settings-store.mjs +544 -0
  24. package/lib/server/sse-delivery.mjs +138 -0
  25. package/lib/server/workspace-files.mjs +563 -0
  26. package/lib/update/supervisor.mjs +4 -0
  27. package/lib/webui-workspaces.mjs +2 -0
  28. package/package.json +4 -4
  29. package/public/activity-agents-controller.mjs +269 -0
  30. package/public/activity-events-controller.mjs +236 -0
  31. package/public/activity-intercom-controller.mjs +627 -0
  32. package/public/activity-queue-controller.mjs +534 -0
  33. package/public/activity-todo-view.mjs +89 -0
  34. package/public/activity-usage-controller.mjs +589 -0
  35. package/public/app.js +3761 -3886
  36. package/public/conversation-overview.css +84 -0
  37. package/public/conversation-overview.mjs +193 -0
  38. package/public/draft-conversations.mjs +135 -0
  39. package/public/focused-composer-controls.css +111 -0
  40. package/public/focused-composer-controls.mjs +143 -0
  41. package/public/focused-composer-disclosure.mjs +223 -0
  42. package/public/focused-shell-adapter.css +264 -0
  43. package/public/focused-shell-adapter.mjs +257 -0
  44. package/public/index.html +137 -80
  45. package/public/model-catalog-order.mjs +63 -0
  46. package/public/platform-event-stream.mjs +64 -0
  47. package/public/project-artifact-controller.mjs +218 -0
  48. package/public/project-file-viewer-controller.mjs +383 -0
  49. package/public/project-git-tools-controller.mjs +181 -0
  50. package/public/project-runners-controller.mjs +220 -0
  51. package/public/service-worker.js +52 -1
  52. package/public/session-attention-scheduler.mjs +182 -0
  53. package/public/session-composer-store.mjs +56 -0
  54. package/public/session-context.mjs +51 -0
  55. package/public/session-extension-requests.mjs +63 -0
  56. package/public/session-shelf-state.mjs +151 -0
  57. package/public/session-shelves.css +171 -0
  58. package/public/session-shelves.mjs +95 -0
  59. package/public/settings-navigation-controller.mjs +249 -0
  60. package/public/settings-navigation.css +61 -0
  61. package/public/settings-resource-controller.mjs +232 -0
  62. package/public/settings-workspace.css +19 -0
  63. package/public/settings-workspace.mjs +175 -0
  64. package/public/shell-actions.mjs +87 -0
  65. package/public/shell-attention-inbox.css +72 -0
  66. package/public/shell-attention-inbox.mjs +198 -0
  67. package/public/shell-context-actions.css +61 -0
  68. package/public/shell-context-actions.mjs +168 -0
  69. package/public/shell-inspector-resize.mjs +124 -0
  70. package/public/shell-navigation-resize.mjs +107 -0
  71. package/public/shell-navigation.mjs +127 -0
  72. package/public/shell-preferences.mjs +108 -0
  73. package/public/shell-surfaces.mjs +99 -0
  74. package/public/shell-tools-launcher.css +97 -0
  75. package/public/shell-tools-launcher.mjs +222 -0
  76. package/public/shell-view-host.mjs +115 -0
  77. package/public/shell-workspace.css +266 -0
  78. package/public/shell-workspace.mjs +402 -0
  79. package/public/sidebar-update-menu.css +190 -0
  80. package/public/sidebar-update-menu.mjs +512 -0
  81. package/public/styles.css +320 -169
  82. package/public/subagent-launch-slot-state.mjs +2 -2
  83. package/public/themed-selects.css +156 -0
  84. package/public/workspace-choices.mjs +104 -0
  85. package/tests/activity-agents-controller.test.mjs +652 -0
  86. package/tests/activity-events-controller.test.mjs +511 -0
  87. package/tests/app-runner-terminal-static.test.mjs +3 -3
  88. package/tests/append-system-http.test.mjs +7 -6
  89. package/tests/append-system-selector-static.test.mjs +6 -6
  90. package/tests/aur-review-widget-static.test.mjs +11 -3
  91. package/tests/boot-failure-diagnostics.test.mjs +8 -3
  92. package/tests/browser/activity-intercom-controller.spec.mjs +457 -0
  93. package/tests/browser/activity-navigation-integration.spec.mjs +45 -0
  94. package/tests/browser/activity-owner-integration.spec.mjs +201 -0
  95. package/tests/browser/activity-queue-controller.spec.mjs +405 -0
  96. package/tests/browser/activity-section-picker.spec.mjs +294 -0
  97. package/tests/browser/activity-todo-view.spec.mjs +60 -0
  98. package/tests/browser/activity-usage-controller.spec.mjs +416 -0
  99. package/tests/browser/compact-layout-integration.spec.mjs +58 -0
  100. package/tests/browser/composer-action-grid-reorder.spec.mjs +16 -0
  101. package/tests/browser/composer-disclosure.spec.mjs +389 -0
  102. package/tests/browser/composer-toolbar-polish.spec.mjs +343 -0
  103. package/tests/browser/control-deck-component-updates.spec.mjs +5 -14
  104. package/tests/browser/control-deck-side-panels.spec.mjs +27 -12
  105. package/tests/browser/control-visibility.spec.mjs +5 -0
  106. package/tests/browser/controls-layout.spec.mjs +21 -2
  107. package/tests/browser/conversation-overview.spec.mjs +251 -0
  108. package/tests/browser/draft-conversations.spec.mjs +276 -0
  109. package/tests/browser/empty-startup-fixture.mjs +135 -0
  110. package/tests/browser/empty-startup.spec.mjs +282 -0
  111. package/tests/browser/events-tree-context-menu.spec.mjs +1 -0
  112. package/tests/browser/focused-composer-more.spec.mjs +127 -0
  113. package/tests/browser/focused-model-shortcuts.spec.mjs +120 -0
  114. package/tests/browser/focused-navigation-fixture.mjs +32 -0
  115. package/tests/browser/focused-project-activity.spec.mjs +111 -0
  116. package/tests/browser/focused-shell-integration.spec.mjs +208 -0
  117. package/tests/browser/folder-picker-layout-fixture.mjs +13 -0
  118. package/tests/browser/folder-picker-layout.spec.mjs +302 -0
  119. package/tests/browser/footer-model-advanced-layout.spec.mjs +27 -14
  120. package/tests/browser/git-setup-cancel.spec.mjs +251 -0
  121. package/tests/browser/guided-git-fallback.spec.mjs +40 -21
  122. package/tests/browser/inspector-header.spec.mjs +221 -0
  123. package/tests/browser/inspector-overview-integration.spec.mjs +104 -0
  124. package/tests/browser/inspector-resize.spec.mjs +227 -0
  125. package/tests/browser/inspector-topic-overflow.spec.mjs +56 -0
  126. package/tests/browser/interaction-action-discovery.spec.mjs +332 -0
  127. package/tests/browser/interaction-attention-inbox.spec.mjs +364 -0
  128. package/tests/browser/interaction-attention-integration.spec.mjs +53 -0
  129. package/tests/browser/interaction-composer-controls.spec.mjs +267 -0
  130. package/tests/browser/interaction-composer-integration.spec.mjs +175 -0
  131. package/tests/browser/interaction-continuity.spec.mjs +50 -26
  132. package/tests/browser/interaction-model-picker.spec.mjs +86 -0
  133. package/tests/browser/last-terminal-close.spec.mjs +280 -0
  134. package/tests/browser/mobile-foundation.spec.mjs +172 -20
  135. package/tests/browser/model-catalog-groups.spec.mjs +104 -0
  136. package/tests/browser/more-row-menus.spec.mjs +258 -0
  137. package/tests/browser/new-tab-hit-target.spec.mjs +228 -0
  138. package/tests/browser/no-project-conversation.spec.mjs +113 -0
  139. package/tests/browser/optimistic-prompt.spec.mjs +3 -0
  140. package/tests/browser/overhaul-w7-accessibility.spec.mjs +227 -0
  141. package/tests/browser/overhaul-w7-capabilities.spec.mjs +298 -0
  142. package/tests/browser/overhaul-w7-companions.spec.mjs +290 -0
  143. package/tests/browser/overhaul-w7-focus-repairs.spec.mjs +210 -0
  144. package/tests/browser/overhaul-w7-layout-repairs.spec.mjs +183 -0
  145. package/tests/browser/overhaul-w7-parent-repairs.spec.mjs +97 -0
  146. package/tests/browser/overhaul-w7-pwa.spec.mjs +247 -0
  147. package/tests/browser/overhaul-w7-responsive.spec.mjs +450 -0
  148. package/tests/browser/overhaul-w7-update.spec.mjs +215 -0
  149. package/tests/browser/overhaul-w7-zoom.spec.mjs +243 -0
  150. package/tests/browser/overview-agent-ownership.spec.mjs +45 -0
  151. package/tests/browser/persistent-ui-layout.spec.mjs +3 -0
  152. package/tests/browser/project-artifact-controller.spec.mjs +324 -0
  153. package/tests/browser/project-artifact-integration.spec.mjs +103 -0
  154. package/tests/browser/project-file-buffer-integration.spec.mjs +230 -0
  155. package/tests/browser/project-git-tools-integration.spec.mjs +369 -0
  156. package/tests/browser/session-fixture.mjs +118 -0
  157. package/tests/browser/session-ownership.spec.mjs +175 -0
  158. package/tests/browser/session-shelves-integration.spec.mjs +219 -0
  159. package/tests/browser/session-shelves.spec.mjs +340 -0
  160. package/tests/browser/session-sidebar-resize.spec.mjs +138 -0
  161. package/tests/browser/session-summary.spec.mjs +17 -12
  162. package/tests/browser/settings-complete-home.spec.mjs +463 -0
  163. package/tests/browser/settings-entrypoint.spec.mjs +104 -0
  164. package/tests/browser/settings-navigation-controller.spec.mjs +383 -0
  165. package/tests/browser/settings-navigation-integration.spec.mjs +348 -0
  166. package/tests/browser/settings-resource-lifetime.spec.mjs +349 -0
  167. package/tests/browser/settings-workspace-integration.spec.mjs +132 -0
  168. package/tests/browser/shell-ownership.spec.mjs +398 -0
  169. package/tests/browser/shell-rollout-fixture.mjs +259 -0
  170. package/tests/browser/shell-rollout.spec.mjs +357 -0
  171. package/tests/browser/shell-tools-launcher.spec.mjs +260 -0
  172. package/tests/browser/shell-workspace.spec.mjs +433 -0
  173. package/tests/browser/side-panel-section-reorder.spec.mjs +3 -1
  174. package/tests/browser/sidebar-floating-tooltips.spec.mjs +37 -0
  175. package/tests/browser/sidebar-update-integration.spec.mjs +277 -0
  176. package/tests/browser/sidebar-update-menu.spec.mjs +402 -0
  177. package/tests/browser/sidebar-update-progress.spec.mjs +472 -0
  178. package/tests/browser/stream-output-isolation.spec.mjs +6 -3
  179. package/tests/browser/themed-selects.spec.mjs +297 -0
  180. package/tests/browser/thread-start-flow.spec.mjs +481 -0
  181. package/tests/browser/ui-polish-activity-controls.spec.mjs +177 -0
  182. package/tests/browser/ui-polish-features.spec.mjs +85 -0
  183. package/tests/browser/ui-polish-file-header.spec.mjs +43 -0
  184. package/tests/browser/ui-polish-local-git.spec.mjs +183 -0
  185. package/tests/browser/ui-polish-mobile-recovery.spec.mjs +36 -0
  186. package/tests/browser/ui-polish-navigation.spec.mjs +127 -0
  187. package/tests/browser/ui-polish-session-actions.spec.mjs +282 -0
  188. package/tests/browser/user-noticeable-fixes.spec.mjs +10 -3
  189. package/tests/browser/windows-drive-parent.spec.mjs +4 -2
  190. package/tests/browser/workspace-draft-selection.spec.mjs +266 -0
  191. package/tests/codex-fast-mode-static.test.mjs +16 -11
  192. package/tests/codex-speed-mode-browser-state.test.mjs +6 -3
  193. package/tests/codex-usage-source.test.mjs +4 -3
  194. package/tests/component-update-api-static.test.mjs +2 -2
  195. package/tests/composer-action-grid-reorder-static.test.mjs +3 -3
  196. package/tests/control-deck-component-updates-static.test.mjs +9 -4
  197. package/tests/control-visibility-static.test.mjs +3 -3
  198. package/tests/controls-layout-static.test.mjs +5 -5
  199. package/tests/conversation-overview-adapter.test.mjs +100 -0
  200. package/tests/document-artifact-static.test.mjs +2 -1
  201. package/tests/draft-conversations.test.mjs +205 -0
  202. package/tests/empty-startup-launcher.test.mjs +197 -0
  203. package/tests/events-tree-context-menu-static.test.mjs +22 -18
  204. package/tests/fake-pi-session-ownership.test.mjs +302 -0
  205. package/tests/fast-mode-client-static.test.mjs +1 -1
  206. package/tests/feature-decision-output-popup-static.test.mjs +2 -2
  207. package/tests/feature-system-prompt-optional-feature-static.test.mjs +1 -1
  208. package/tests/file-viewer-image-static.test.mjs +15 -11
  209. package/tests/file-viewer-search-static.test.mjs +5 -5
  210. package/tests/fixtures/fake-pi.mjs +41 -9
  211. package/tests/footer-provider-usage-visual-static.test.mjs +7 -6
  212. package/tests/foreground-transcript-catch-up-static.test.mjs +7 -4
  213. package/tests/git-footer-context-menu-static.test.mjs +1 -1
  214. package/tests/git-panel-file-preview-static.test.mjs +41 -48
  215. package/tests/git-panel-live-updates-static.test.mjs +2 -1
  216. package/tests/git-workflow-dispatch.test.mjs +66 -0
  217. package/tests/git-workflow-preferences.test.mjs +9 -1
  218. package/tests/guided-git-activation-static.test.mjs +14 -11
  219. package/tests/guided-git-fallback-ui-static.test.mjs +8 -5
  220. package/tests/guided-git-message-reliability-static.test.mjs +10 -6
  221. package/tests/guided-git-publication-backend-static.test.mjs +16 -11
  222. package/tests/http-endpoints-harness.test.mjs +21 -9
  223. package/tests/interaction-state-stability-static.test.mjs +4 -3
  224. package/tests/intercom-conversation-viewer-static.test.mjs +29 -17
  225. package/tests/intercom-tag-layout-static.test.mjs +13 -12
  226. package/tests/intercom-tag-overflow-layout.test.mjs +11 -10
  227. package/tests/main-output-loading-static.test.mjs +4 -4
  228. package/tests/middle-button-drag-scroll-static.test.mjs +3 -3
  229. package/tests/mobile-compact-layout.test.mjs +2 -2
  230. package/tests/mobile-continuity-tablet-static.test.mjs +3 -3
  231. package/tests/mobile-foundation-static.test.mjs +10 -7
  232. package/tests/mobile-phone-experience-static.test.mjs +3 -2
  233. package/tests/mobile-static.test.mjs +173 -135
  234. package/tests/model-catalog-order.test.mjs +103 -0
  235. package/tests/native-parity.test.mjs +6 -4
  236. package/tests/native-session-choice-owner.test.mjs +102 -0
  237. package/tests/native-update-lifecycle.test.mjs +10 -5
  238. package/tests/no-project-http-harness.test.mjs +328 -0
  239. package/tests/no-project-navigation.test.mjs +54 -0
  240. package/tests/no-project-workspaces.test.mjs +77 -0
  241. package/tests/open-issue-wizard-static.test.mjs +1 -1
  242. package/tests/optional-feature-migration-frontend.test.mjs +4 -4
  243. package/tests/optional-feature-prompt-impact-static.test.mjs +3 -3
  244. package/tests/package-updates.test.mjs +630 -0
  245. package/tests/persistent-ui-layout-static.test.mjs +3 -3
  246. package/tests/platform-event-stream.test.mjs +253 -0
  247. package/tests/project-file-viewer-controller.test.mjs +652 -0
  248. package/tests/project-git-tools-adapter.test.mjs +103 -0
  249. package/tests/project-git-tools-controller.test.mjs +577 -0
  250. package/tests/project-runners-controller.test.mjs +453 -0
  251. package/tests/prompt-input-vertical-scroll-static.test.mjs +3 -3
  252. package/tests/prompt-routing-input-clear-static.test.mjs +2 -2
  253. package/tests/questionnaire-dialog.test.mjs +6 -6
  254. package/tests/queue-edit-reorder-static.test.mjs +48 -51
  255. package/tests/rpc-supervisor-host.test.mjs +4 -1
  256. package/tests/safety-guard-auto-review-static.test.mjs +1 -1
  257. package/tests/sampling-native-controls-user-flow.test.mjs +7 -1
  258. package/tests/server-app-runners.test.mjs +536 -0
  259. package/tests/server-codex-fast-mode.test.mjs +346 -0
  260. package/tests/server-conversation-mode.test.mjs +386 -0
  261. package/tests/server-conversation-voice.test.mjs +426 -0
  262. package/tests/server-extension-ui-requests.test.mjs +357 -0
  263. package/tests/server-git-generation.test.mjs +558 -0
  264. package/tests/server-git-mutations.test.mjs +729 -0
  265. package/tests/server-git-reads.test.mjs +381 -0
  266. package/tests/server-git-worktree-sessions.test.mjs +502 -0
  267. package/tests/server-helper-requests.test.mjs +364 -0
  268. package/tests/server-rpc-transports.test.mjs +553 -0
  269. package/tests/server-settings-store.test.mjs +132 -0
  270. package/tests/server-shell-rollout.test.mjs +478 -0
  271. package/tests/server-sse-delivery.test.mjs +410 -0
  272. package/tests/server-workspace-files.test.mjs +546 -0
  273. package/tests/session-attention-scheduler.test.mjs +514 -0
  274. package/tests/session-composer-store.test.mjs +153 -0
  275. package/tests/session-context.test.mjs +134 -0
  276. package/tests/session-extension-requests.test.mjs +193 -0
  277. package/tests/session-ownership-adapter.test.mjs +130 -0
  278. package/tests/session-sampling-ui-static.test.mjs +10 -4
  279. package/tests/session-send-lifetime.test.mjs +140 -0
  280. package/tests/session-shelf-state.test.mjs +348 -0
  281. package/tests/session-shelves-adapter.test.mjs +79 -0
  282. package/tests/session-summary-lifetime.test.mjs +54 -0
  283. package/tests/settings-resource-controller.test.mjs +548 -0
  284. package/tests/shell-action-adapter.test.mjs +169 -0
  285. package/tests/shell-actions.test.mjs +182 -0
  286. package/tests/shell-navigation.test.mjs +348 -0
  287. package/tests/shell-preferences.test.mjs +367 -0
  288. package/tests/side-panel-section-height-removal-static.test.mjs +3 -3
  289. package/tests/stream-output-isolation-static.test.mjs +1 -1
  290. package/tests/subagent-gate-visibility.test.mjs +1 -1
  291. package/tests/subagent-launch-slot-state.test.mjs +2 -2
  292. package/tests/subagent-launch-slots-static.test.mjs +1 -1
  293. package/tests/subagent-observability-static.test.mjs +2 -2
  294. package/tests/subagent-reliability-integration.test.mjs +13 -30
  295. package/tests/syntax-highlighting-static.test.mjs +3 -3
  296. package/tests/tab-close-continuity-static.test.mjs +1 -1
  297. package/tests/tab-metadata-ordering.test.mjs +99 -0
  298. package/tests/terminal-cwd-grouping-static.test.mjs +2 -2
  299. package/tests/terminal-tab-prompt-tooltip-static.test.mjs +2 -0
  300. package/tests/terminal-tab-workspace-static.test.mjs +5 -4
  301. package/tests/terminal-tabs-resize-static.test.mjs +1 -1
  302. package/tests/theme-customizer-static.test.mjs +1 -1
  303. package/tests/thread-display-title.test.mjs +44 -0
  304. package/tests/update-api-harness.test.mjs +15 -14
  305. package/tests/update-tab-restore-harness.test.mjs +3 -0
  306. package/tests/webui-settings-locking.test.mjs +2 -2
  307. package/tests/windows-drive-cwd-picker-static.test.mjs +7 -9
  308. package/tests/workspace-choices.test.mjs +114 -0
  309. package/tests/workspace-save-load-static.test.mjs +7 -4
@@ -0,0 +1,364 @@
1
+ import assert from "node:assert/strict";
2
+ import { setImmediate as nextTurn } from "node:timers/promises";
3
+ import { test } from "node:test";
4
+ import * as helperRequests from "../lib/server/helper-requests.mjs";
5
+
6
+ const { createHelperRequestService, WEBUI_HELPER_COMMAND } = helperRequests;
7
+ const responsePrefix = "__PI_WEBUI_HELPER_RESPONSE__:";
8
+ const serviceNames = [
9
+ "parseWebuiHelperResponseEvent", "resolveWebuiHelperResponse", "resolveWebuiHelperRpcResponse",
10
+ "webuiHelperRequestMap", "sendWebuiHelperCommand",
11
+ ];
12
+
13
+ function notification(payload) {
14
+ return { type: "extension_ui_request", method: "notify", message: responsePrefix + JSON.stringify(payload) };
15
+ }
16
+
17
+ function fixture(t) {
18
+ t.mock.timers.enable({ apis: ["setTimeout"] });
19
+ const tabs = [];
20
+ const errors = [];
21
+ const sanitized = [];
22
+ const service = createHelperRequestService({
23
+ makeHttpError(statusCode, message) {
24
+ const error = Object.assign(new Error(message), { statusCode });
25
+ errors.push(error);
26
+ return error;
27
+ },
28
+ sanitizeError(error) {
29
+ sanitized.push(error);
30
+ return "sanitized fixture error";
31
+ },
32
+ });
33
+ function tab(id) {
34
+ const target = {
35
+ id,
36
+ webuiHelperRequests: new Map(),
37
+ webuiHelperResponseIds: new Set(),
38
+ calls: [],
39
+ rpc: {
40
+ send(command, timeoutMs) {
41
+ assert.equal(target.webuiHelperRequests.has(command.id), true, "register before RPC dispatch");
42
+ assert.equal(target.webuiHelperResponseIds.has(command.id), true, "suppress before RPC dispatch");
43
+ return new Promise((resolve, reject) => target.calls.push({ command, timeoutMs, resolve, reject }));
44
+ },
45
+ },
46
+ };
47
+ tabs.push(target);
48
+ return target;
49
+ }
50
+ function send(target, action, payload, timeoutMs) {
51
+ const result = service.sendWebuiHelperCommand(target, action, payload, timeoutMs);
52
+ const call = target.calls.at(-1);
53
+ call.result = result;
54
+ call.state = "pending";
55
+ result.then(() => { call.state = "fulfilled"; }, () => { call.state = "rejected"; });
56
+ return call;
57
+ }
58
+ function acknowledge(target, call, response = { success: true }) {
59
+ const event = { type: "response", command: "prompt", id: call.command.id, ...response };
60
+ assert.equal(service.resolveWebuiHelperRpcResponse(target, event), true);
61
+ call.resolve(event);
62
+ return event;
63
+ }
64
+ function respond(target, call, payload = {}) {
65
+ return service.resolveWebuiHelperResponse(target, notification({ requestId: call.command.id, ...payload }));
66
+ }
67
+ t.after(async () => {
68
+ const disposed = new Error("Disposed helper fixture");
69
+ for (const target of tabs) {
70
+ for (const call of target.calls) call.reject(disposed);
71
+ for (const pending of target.webuiHelperRequests.values()) {
72
+ clearTimeout(pending.timeout);
73
+ pending.reject(disposed);
74
+ }
75
+ target.webuiHelperRequests.clear();
76
+ target.webuiHelperResponseIds.clear();
77
+ }
78
+ await Promise.allSettled(tabs.flatMap((target) => target.calls.map((call) => call.result)));
79
+ });
80
+ return { service, tab, send, acknowledge, respond, errors, sanitized };
81
+ }
82
+
83
+ function httpError(statusCode, message) {
84
+ return (error) => error.statusCode === statusCode && error.message === message;
85
+ }
86
+
87
+ test("import and factory expose the L3 contract without timers or dependency calls", { timeout: 1_000 }, async (t) => {
88
+ const timer = t.mock.method(globalThis, "setTimeout", () => { throw new Error("Unexpected timer"); });
89
+ const interval = t.mock.method(globalThis, "setInterval", () => { throw new Error("Unexpected interval"); });
90
+ const freshModule = await import("../lib/server/helper-requests.mjs?inert-import");
91
+ const dependency = t.mock.fn(() => { throw new Error("Unexpected dependency call"); });
92
+ const service = freshModule.createHelperRequestService({ makeHttpError: dependency, sanitizeError: dependency });
93
+ assert.deepEqual(Object.keys(freshModule).sort(), ["WEBUI_HELPER_COMMAND", "createHelperRequestService"]);
94
+ assert.deepEqual(Object.keys(service).sort(), [...serviceNames].sort());
95
+ assert.equal(WEBUI_HELPER_COMMAND, "webui-helper");
96
+ assert.equal(timer.mock.callCount(), 0);
97
+ assert.equal(interval.mock.callCount(), 0);
98
+ assert.equal(dependency.mock.callCount(), 0);
99
+ });
100
+
101
+ test("request maps are the real tab records and are lazy without creating suppression Sets", (t) => {
102
+ const { service } = fixture(t);
103
+ const existing = new Map([["existing", {}]]);
104
+ const initialized = { webuiHelperRequests: existing, webuiHelperResponseIds: new Set(["existing"]) };
105
+ assert.equal(service.webuiHelperRequestMap(initialized), existing);
106
+ assert.deepEqual([...initialized.webuiHelperResponseIds], ["existing"]);
107
+ const target = {};
108
+ const requests = service.webuiHelperRequestMap(target);
109
+ assert.ok(requests instanceof Map);
110
+ assert.equal(service.webuiHelperRequestMap(target), requests);
111
+ assert.equal(target.webuiHelperRequests, requests);
112
+ assert.equal(target.webuiHelperResponseIds, undefined);
113
+ });
114
+
115
+ test("prompt and helper share one UUID and successful RPC alone cannot finish the request", { timeout: 1_000 }, async (t) => {
116
+ const { service, tab, send, acknowledge, respond, errors } = fixture(t);
117
+ const target = tab("a");
118
+ const map = target.webuiHelperRequests;
119
+ const ids = target.webuiHelperResponseIds;
120
+ const call = send(target, "tools-state");
121
+ assert.match(call.command.id, /^[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/);
122
+ assert.equal(call.command.type, "prompt");
123
+ assert.deepEqual(JSON.parse(call.command.message.slice(`/${WEBUI_HELPER_COMMAND} `.length)), {
124
+ requestId: call.command.id, action: "tools-state", payload: {},
125
+ });
126
+ assert.ok(call.command.message.startsWith(`/${WEBUI_HELPER_COMMAND} `));
127
+ assert.equal(call.timeoutMs, 8_000);
128
+ const event = acknowledge(target, call);
129
+ await nextTurn();
130
+ assert.equal(call.state, "pending");
131
+ assert.equal(map.size, 1);
132
+ assert.equal(ids.size, 0);
133
+ assert.equal(service.resolveWebuiHelperRpcResponse(target, event), false, "consume RPC only once");
134
+ const data = { tools: ["read"], marker: "exact object" };
135
+ assert.equal(respond(target, call, { ok: true, data }), true);
136
+ assert.deepEqual(await call.result, data);
137
+ assert.equal(target.webuiHelperRequests, map);
138
+ assert.equal(target.webuiHelperResponseIds, ids);
139
+ assert.equal(map.size, 0);
140
+ t.mock.timers.tick(8_001);
141
+ assert.deepEqual(errors, [], "successful response cancels the helper timeout");
142
+ });
143
+
144
+ test("overlapping requests in two tabs resolve out of order without cross-tab suppression", { timeout: 1_000 }, async (t) => {
145
+ const { service, tab, send, acknowledge, respond } = fixture(t);
146
+ const a = tab("a");
147
+ const b = tab("b");
148
+ const a1 = send(a, "tools-set", { enabledTools: ["read"] }, 31);
149
+ const a2 = send(a, "skills-state", {}, 47);
150
+ const b1 = send(b, "tools-state", {}, 59);
151
+ assert.equal(new Set([a1.command.id, a2.command.id, b1.command.id]).size, 3);
152
+ assert.deepEqual(JSON.parse(a1.command.message.slice(`/${WEBUI_HELPER_COMMAND} `.length)).payload, { enabledTools: ["read"] });
153
+ assert.equal(respond(b, a1, { data: { wrong: true } }), true, "unmatched helper notices are consumed");
154
+ assert.equal(service.resolveWebuiHelperRpcResponse(b, { type: "response", command: "prompt", id: a1.command.id }), false);
155
+ assert.equal(a.webuiHelperRequests.size, 2);
156
+ assert.equal(b.webuiHelperRequests.size, 1);
157
+ acknowledge(a, a2);
158
+ respond(a, a2, { data: { result: "a2" } });
159
+ assert.deepEqual(await a2.result, { result: "a2" });
160
+ assert.deepEqual([...a.webuiHelperRequests.keys()], [a1.command.id]);
161
+ respond(b, b1, { data: { result: "b1" } });
162
+ acknowledge(b, b1);
163
+ assert.deepEqual(await b1.result, { result: "b1" });
164
+ acknowledge(a, a1);
165
+ respond(a, a1, { data: { result: "a1" } });
166
+ assert.deepEqual(await a1.result, { result: "a1" });
167
+ assert.equal(a.webuiHelperRequests.size + b.webuiHelperRequests.size, 0);
168
+ assert.equal(a.webuiHelperResponseIds.size + b.webuiHelperResponseIds.size, 0);
169
+ });
170
+
171
+ test("notification before RPC waits for RPC, cancels its timer and retains response suppression", { timeout: 1_000 }, async (t) => {
172
+ const { tab, send, acknowledge, respond, errors } = fixture(t);
173
+ const target = tab("a");
174
+ const call = send(target, "sampling-state", {}, 25);
175
+ assert.equal(respond(target, call, { data: { value: "helper first" } }), true);
176
+ assert.equal(target.webuiHelperRequests.size, 0);
177
+ assert.deepEqual([...target.webuiHelperResponseIds], [call.command.id]);
178
+ t.mock.timers.tick(26);
179
+ await nextTurn();
180
+ assert.equal(call.state, "pending");
181
+ assert.deepEqual(errors, []);
182
+ acknowledge(target, call);
183
+ assert.deepEqual(await call.result, { value: "helper first" });
184
+ assert.equal(target.webuiHelperResponseIds.size, 0);
185
+ });
186
+
187
+ test("helper failures wait for RPC and use existing error and fallback payload semantics", { timeout: 1_000 }, async (t) => {
188
+ const { tab, send, acknowledge, respond } = fixture(t);
189
+ const target = tab("a");
190
+ for (const error of ["Helper refused", ""]) {
191
+ const call = send(target, "tools-set");
192
+ respond(target, call, { ok: false, error });
193
+ await nextTurn();
194
+ assert.equal(call.state, "pending");
195
+ acknowledge(target, call);
196
+ await assert.rejects(call.result, httpError(400, error || "Web UI helper command failed"));
197
+ assert.equal(target.webuiHelperResponseIds.size, 0);
198
+ }
199
+ for (const data of [undefined, null, false, 0, "", ["kept"], "kept"]) {
200
+ const call = send(target, "tools-state");
201
+ acknowledge(target, call);
202
+ respond(target, call, { data });
203
+ assert.deepEqual(await call.result, data || {});
204
+ }
205
+ });
206
+
207
+ test("unsuccessful prompt responses clean pending state with existing HTTP errors", { timeout: 1_000 }, async (t) => {
208
+ const { tab, send, acknowledge, errors } = fixture(t);
209
+ const target = tab("a");
210
+ for (const error of ["Prompt refused", ""]) {
211
+ const call = send(target, "tools-state", {}, 20);
212
+ acknowledge(target, call, { success: false, error });
213
+ await assert.rejects(call.result, httpError(400, error || "Web UI helper action failed: tools-state"));
214
+ assert.equal(target.webuiHelperRequests.size, 0);
215
+ assert.equal(target.webuiHelperResponseIds.size, 0);
216
+ }
217
+ assert.equal(errors.length, 2);
218
+ t.mock.timers.tick(21);
219
+ assert.equal(errors.length, 2, "prompt failures cancel their timers");
220
+ });
221
+
222
+ test("prompt exceptions preserve the thrown error and clean only the failed request", { timeout: 1_000 }, async (t) => {
223
+ const { tab, send, acknowledge, respond, errors } = fixture(t);
224
+ const target = tab("a");
225
+ const survivor = send(target, "skills-state", {}, 50);
226
+ const failed = send(target, "tools-state", {}, 20);
227
+ const failure = new Error("RPC transport failed");
228
+ failed.reject(failure);
229
+ await assert.rejects(failed.result, (error) => error === failure);
230
+ assert.deepEqual([...target.webuiHelperRequests.keys()], [survivor.command.id]);
231
+ assert.deepEqual([...target.webuiHelperResponseIds], [survivor.command.id]);
232
+ t.mock.timers.tick(21);
233
+ assert.deepEqual(errors, []);
234
+ acknowledge(target, survivor);
235
+ respond(target, survivor);
236
+ assert.deepEqual(await survivor.result, {});
237
+ target.rpc.send = () => { throw failure; };
238
+ await assert.rejects(createHelperRequestService({ makeHttpError: assert.fail, sanitizeError: assert.fail })
239
+ .sendWebuiHelperCommand(target, "tools-state", {}, 20), (error) => error === failure);
240
+ assert.equal(target.webuiHelperRequests.size, 0);
241
+ assert.equal(target.webuiHelperResponseIds.size, 0);
242
+ t.mock.timers.tick(21);
243
+ assert.deepEqual(errors, []);
244
+ });
245
+
246
+ test("prompt failure still wins after a successful helper notification", { timeout: 1_000 }, async (t) => {
247
+ const { tab, send, respond, errors } = fixture(t);
248
+ const target = tab("a");
249
+ const call = send(target, "tools-state", {}, 20);
250
+ respond(target, call, { data: { premature: true } });
251
+ const failure = new Error("RPC failed after helper notification");
252
+ call.reject(failure);
253
+ await assert.rejects(call.result, (error) => error === failure);
254
+ assert.equal(target.webuiHelperRequests.size, 0);
255
+ assert.equal(target.webuiHelperResponseIds.size, 0);
256
+ t.mock.timers.tick(21);
257
+ assert.deepEqual(errors, []);
258
+ });
259
+
260
+ test("malformed and unmatched helper notifications are consumed without settling other requests", { timeout: 1_000 }, async (t) => {
261
+ const { service, tab, send, acknowledge, respond, sanitized } = fixture(t);
262
+ const target = tab("a");
263
+ const call = send(target, "tools-state");
264
+ acknowledge(target, call);
265
+ const malformed = { type: "extension_ui_request", method: "notify", message: responsePrefix + "{" };
266
+ assert.deepEqual(service.parseWebuiHelperResponseEvent(malformed), {
267
+ ok: false, error: "Invalid Web UI helper response: sanitized fixture error",
268
+ });
269
+ assert.ok(sanitized[0] instanceof SyntaxError);
270
+ for (const event of [malformed, notification({ requestId: "unknown", data: { ignored: true } }),
271
+ notification({}), notification([]), notification("truthy payload"), notification({ requestId: 23 })]) {
272
+ assert.equal(service.resolveWebuiHelperResponse(target, event), true);
273
+ }
274
+ for (const payload of [null, false, 0, ""]) {
275
+ assert.equal(service.parseWebuiHelperResponseEvent(notification(payload)), payload);
276
+ assert.equal(service.resolveWebuiHelperResponse(target, notification(payload)), false);
277
+ }
278
+ await nextTurn();
279
+ assert.equal(call.state, "pending");
280
+ assert.deepEqual([...target.webuiHelperRequests.keys()], [call.command.id]);
281
+ respond(target, call, { data: { accepted: true } });
282
+ assert.deepEqual(await call.result, { accepted: true });
283
+ assert.equal(respond(target, call, { ok: false, error: "duplicate" }), true);
284
+ assert.equal(service.resolveWebuiHelperResponse(undefined, notification({ requestId: "unknown" })), true);
285
+ });
286
+
287
+ test("unrelated notifications and RPC responses preserve active suppression IDs", { timeout: 1_000 }, async (t) => {
288
+ const { service, tab, send, acknowledge, respond } = fixture(t);
289
+ const target = tab("a");
290
+ const call = send(target, "tools-state");
291
+ for (const event of [null, {}, { type: "response" }, { type: "extension_ui_request", method: "setStatus", message: responsePrefix + "{}" },
292
+ { type: "extension_ui_request", method: "notify" }, { type: "extension_ui_request", method: "notify", message: "ordinary notice" },
293
+ { type: "extension_ui_request", method: "notify", message: " " + responsePrefix + "{}" }]) {
294
+ assert.equal(service.parseWebuiHelperResponseEvent(event), undefined);
295
+ assert.equal(service.resolveWebuiHelperResponse(target, event), false);
296
+ }
297
+ for (const event of [null, {}, { type: "response", command: "get_state", id: call.command.id },
298
+ { type: "other", command: "prompt", id: call.command.id }, { type: "response", command: "prompt" },
299
+ { type: "response", command: "prompt", id: "unknown" }]) {
300
+ assert.equal(service.resolveWebuiHelperRpcResponse(target, event), false);
301
+ }
302
+ assert.deepEqual([...target.webuiHelperResponseIds], [call.command.id]);
303
+ acknowledge(target, call);
304
+ respond(target, call);
305
+ await call.result;
306
+ assert.equal(service.resolveWebuiHelperRpcResponse({ webuiHelperResponseIds: new Set(["23"]) },
307
+ { type: "response", command: "prompt", id: 23 }), true);
308
+ assert.equal(service.resolveWebuiHelperRpcResponse(undefined, { type: "response", command: "prompt", id: "unknown" }), false);
309
+ });
310
+
311
+ test("helper timeout removes only its request and suppression ID, then ignores late responses", { timeout: 1_000 }, async (t) => {
312
+ const { service, tab, send, acknowledge, respond, errors } = fixture(t);
313
+ const target = tab("a");
314
+ const expired = send(target, "tools-state", {}, 20);
315
+ const survivor = send(target, "skills-state", {}, 50);
316
+ expired.resolve({ success: true });
317
+ await nextTurn();
318
+ t.mock.timers.tick(19);
319
+ assert.equal(expired.state, "pending");
320
+ t.mock.timers.tick(1);
321
+ await assert.rejects(expired.result, httpError(504, "Timed out waiting for Web UI helper action: tools-state. Try /reload in this tab, then retry."));
322
+ assert.deepEqual([...target.webuiHelperRequests.keys()], [survivor.command.id]);
323
+ assert.deepEqual([...target.webuiHelperResponseIds], [survivor.command.id]);
324
+ assert.equal(service.resolveWebuiHelperRpcResponse(target, { type: "response", command: "prompt", id: expired.command.id }), false);
325
+ assert.equal(respond(target, expired, { data: { late: true } }), true);
326
+ acknowledge(target, survivor);
327
+ respond(target, survivor);
328
+ await survivor.result;
329
+ t.mock.timers.tick(100);
330
+ assert.equal(errors.length, 1);
331
+ });
332
+
333
+ test("default helper deadline is eight seconds and RPC still gates an earlier timeout", { timeout: 1_000 }, async (t) => {
334
+ const { tab, send, errors } = fixture(t);
335
+ const target = tab("a");
336
+ const call = send(target, "skills-state");
337
+ t.mock.timers.tick(7_999);
338
+ assert.equal(target.webuiHelperRequests.size, 1);
339
+ t.mock.timers.tick(1);
340
+ await nextTurn();
341
+ assert.equal(target.webuiHelperRequests.size, 0);
342
+ assert.equal(target.webuiHelperResponseIds.size, 0);
343
+ assert.equal(call.state, "pending", "the helper timeout does not replace RPC settlement");
344
+ call.resolve({ success: true });
345
+ await assert.rejects(call.result, httpError(504, "Timed out waiting for Web UI helper action: skills-state. Try /reload in this tab, then retry."));
346
+ assert.equal(errors.length, 1);
347
+ });
348
+
349
+ test("separate factories and parent reset events retain tab-owned requests until ordinary completion", { timeout: 1_000 }, async (t) => {
350
+ const { service, tab, send, acknowledge } = fixture(t);
351
+ const target = tab("a");
352
+ const call = send(target, "tools-state");
353
+ for (const event of [{ type: "pi_process_exit" }, { type: "pi_process_error" }, { type: "session_start" }]) {
354
+ assert.equal(service.resolveWebuiHelperResponse(target, event), false);
355
+ assert.equal(service.resolveWebuiHelperRpcResponse(target, event), false);
356
+ }
357
+ assert.equal(target.webuiHelperRequests.size, 1);
358
+ assert.equal(target.webuiHelperResponseIds.size, 1);
359
+ const secondService = createHelperRequestService({ makeHttpError: assert.fail, sanitizeError: assert.fail });
360
+ assert.equal(secondService.webuiHelperRequestMap(target), target.webuiHelperRequests);
361
+ assert.equal(secondService.resolveWebuiHelperResponse(target, notification({ requestId: call.command.id, data: { retained: true } })), true);
362
+ acknowledge(target, call);
363
+ assert.deepEqual(await call.result, { retained: true });
364
+ });