@finos/legend-graph 2.1.3 → 3.0.0

package/src/models/metamodels/pure/packageableElements/store/modelToModel/mapping/PureInstanceSetImplementation.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import type { Class } from '../../../domain/Class';
@@ -38,9 +37,9 @@ export class PureInstanceSetImplementation
   extends InstanceSetImplementation
   implements Hashable, Stubable
 {
+  declare propertyMappings: PurePropertyMapping[];
   srcClass: OptionalPackageableElementReference<Class>;
   filter?: RawLambda | undefined; // @MARKER GENERATED MODEL DISCREPANCY --- Studio does not process lambda
-  declare propertyMappings: PurePropertyMapping[];
 
   constructor(
     id: InferableMappingElementIdValue,
@@ -50,13 +49,6 @@ export class PureInstanceSetImplementation
     srcClass: OptionalPackageableElementReference<Class>,
   ) {
     super(id, parent, _class, root);
-
-    makeObservable(this, {
-      filter: observable,
-      isStub: computed,
-      hashCode: computed,
-    });
-
     this.srcClass = srcClass;
   }
 

package/src/models/metamodels/pure/packageableElements/store/modelToModel/mapping/PurePropertyMapping.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import {
@@ -32,6 +31,7 @@ export class PurePropertyMapping
   extends PropertyMapping
   implements Hashable, Stubable
 {
+  // TODO: convert to reference
   transformer?: EnumerationMapping | undefined;
   transform: RawLambda; // @MARKER GENERATED MODEL DISCREPANCY --- Studio does not process lambda
   explodeProperty?: boolean | undefined;
@@ -45,15 +45,6 @@ export class PurePropertyMapping
     explodeProperty?: boolean,
   ) {
     super(owner, property, source, target);
-
-    makeObservable(this, {
-      transformer: observable,
-      transform: observable,
-      explodeProperty: observable,
-      isStub: computed,
-      hashCode: computed,
-    });
-
     this.transform = transform;
     this.explodeProperty = explodeProperty;
   }

package/src/models/metamodels/pure/packageableElements/store/relational/connection/AuthenticationStrategy.ts

@@ -16,7 +16,6 @@
 
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { type Hashable, hashArray } from '@finos/legend-shared';
-import { observable, computed, makeObservable } from 'mobx';
 
 export abstract class AuthenticationStrategy implements Hashable {
   private readonly _$nominalTypeBrand!: 'AuthenticationStrategy';
@@ -29,13 +28,6 @@ export class DelegatedKerberosAuthenticationStrategy
   implements Hashable
 {
   serverPrincipal?: string | undefined;
-  constructor() {
-    super();
-
-    makeObservable(this, {
-      hashCode: computed,
-    });
-  }
 
   get hashCode(): string {
     return hashArray([
@@ -49,14 +41,6 @@ export class DefaultH2AuthenticationStrategy
   extends AuthenticationStrategy
   implements Hashable
 {
-  constructor() {
-    super();
-
-    makeObservable(this, {
-      hashCode: computed,
-    });
-  }
-
   get hashCode(): string {
     return hashArray([CORE_HASH_STRUCTURE.DEFAULT_H2_AUTHENTICATION_STRATEGY]);
   }
@@ -70,12 +54,6 @@ export class ApiTokenAuthenticationStrategy
 
   constructor(apiToken: string) {
     super();
-
-    makeObservable(this, {
-      apiToken: observable,
-      hashCode: computed,
-    });
-
     this.apiToken = apiToken;
   }
 
@@ -96,12 +74,6 @@ export class OAuthAuthenticationStrategy
 
   constructor(oauthKey: string, scopeName: string) {
     super();
-
-    makeObservable(this, {
-      oauthKey: observable,
-      scopeName: observable,
-      hashCode: computed,
-    });
     this.oauthKey = oauthKey;
     this.scopeName = scopeName;
   }
@@ -129,14 +101,6 @@ export class SnowflakePublicAuthenticationStrategy
     publicUserName: string,
   ) {
     super();
-
-    makeObservable(this, {
-      privateKeyVaultReference: observable,
-      passPhraseVaultReference: observable,
-      publicUserName: observable,
-      hashCode: computed,
-    });
-
     this.privateKeyVaultReference = privateKeyVaultReference;
     this.passPhraseVaultReference = passPhraseVaultReference;
     this.publicUserName = publicUserName;
@@ -156,14 +120,6 @@ export class GCPApplicationDefaultCredentialsAuthenticationStrategy
   extends AuthenticationStrategy
   implements Hashable
 {
-  constructor() {
-    super();
-
-    makeObservable(this, {
-      hashCode: computed,
-    });
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.GCP_APPLICATION_DEFAULT_CREDENTIALS_AUTHENTICATION_STRATEGY,
@@ -181,14 +137,6 @@ export class UsernamePasswordAuthenticationStrategy
 
   constructor(userNameVaultReference: string, passwordVaultReference: string) {
     super();
-
-    makeObservable(this, {
-      hashCode: computed,
-      userNameVaultReference: observable,
-      passwordVaultReference: observable,
-      baseVaultReference: observable,
-    });
-
     this.userNameVaultReference = userNameVaultReference;
     this.passwordVaultReference = passwordVaultReference;
   }

package/src/models/metamodels/pure/packageableElements/store/relational/connection/DatasourceSpecification.ts

@@ -16,7 +16,6 @@
 
 import { type Hashable, hashArray } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
-import { observable, computed, makeObservable } from 'mobx';
 
 export abstract class DatasourceSpecification implements Hashable {
   private readonly _$nominalTypeBrand!: 'DatasourceSpecification';
@@ -34,13 +33,6 @@ export class StaticDatasourceSpecification
 
   constructor(host: string, port: number, databaseName: string) {
     super();
-
-    makeObservable(this, {
-      host: observable,
-      port: observable,
-      databaseName: observable,
-      hashCode: computed,
-    });
     this.host = host;
     this.port = port;
     this.databaseName = databaseName;
@@ -72,14 +64,6 @@ export class DatabricksDatasourceSpecification
     httpPath: string,
   ) {
     super();
-
-    makeObservable(this, {
-      hostname: observable,
-      port: observable,
-      protocol: observable,
-      httpPath: observable,
-      hashCode: computed,
-    });
     this.hostname = hostname;
     this.port = port;
     this.protocol = protocol;
@@ -111,13 +95,6 @@ export class EmbeddedH2DatasourceSpecification
     autoServerMode: boolean,
   ) {
     super();
-
-    makeObservable(this, {
-      databaseName: observable,
-      directory: observable,
-      autoServerMode: observable,
-      hashCode: computed,
-    });
     this.databaseName = databaseName;
     this.directory = directory;
     this.autoServerMode = autoServerMode;
@@ -140,16 +117,6 @@ export class LocalH2DatasourceSpecification
   testDataSetupCsv?: string | undefined;
   testDataSetupSqls: string[] = [];
 
-  constructor() {
-    super();
-
-    makeObservable(this, {
-      testDataSetupCsv: observable,
-      testDataSetupSqls: observable,
-      hashCode: computed,
-    });
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.LOCAL_H2_DATASOURCE_SPECIFICATION,
@@ -183,23 +150,6 @@ export class SnowflakeDatasourceSpecification
     databaseName: string,
   ) {
     super();
-
-    makeObservable(this, {
-      accountName: observable,
-      region: observable,
-      warehouseName: observable,
-      databaseName: observable,
-      cloudType: observable,
-      quotedIdentifiersIgnoreCase: observable,
-      proxyHost: observable,
-      proxyPort: observable,
-      nonProxyHosts: observable,
-      organization: observable,
-      accountType: observable,
-      role: observable,
-      hashCode: computed,
-    });
-
     this.region = region;
     this.warehouseName = warehouseName;
     this.databaseName = databaseName;
@@ -245,16 +195,6 @@ export class RedshiftDatasourceSpecification
     region: string,
   ) {
     super();
-
-    makeObservable(this, {
-      databaseName: observable,
-      endpointURL: observable,
-      port: observable,
-      region: observable,
-      clusterID: observable,
-      host: observable,
-      hashCode: computed,
-    });
     this.clusterID = clusterID;
     this.region = region;
     this.host = host;
@@ -284,12 +224,6 @@ export class BigQueryDatasourceSpecification
 
   constructor(projectId: string, defaultDataset: string) {
     super();
-
-    makeObservable(this, {
-      projectId: observable,
-      defaultDataset: observable,
-      hashCode: computed,
-    });
     this.projectId = projectId;
     this.defaultDataset = defaultDataset;
   }

package/src/models/metamodels/pure/packageableElements/store/relational/connection/RelationalDatabaseConnection.ts

@@ -14,16 +14,15 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
-import { hashArray, guaranteeType } from '@finos/legend-shared';
+import { hashArray } from '@finos/legend-shared';
 import {
   type ConnectionVisitor,
   Connection,
 } from '../../../connection/Connection';
 import type { DatasourceSpecification } from './DatasourceSpecification';
 import type { AuthenticationStrategy } from './AuthenticationStrategy';
-import { Database } from '../model/Database';
+import type { Database } from '../model/Database';
 import type { PackageableElementReference } from '../../../PackageableElementReference';
 import type { PostProcessor } from './postprocessor/PostProcessor';
 
@@ -45,6 +44,7 @@ export enum DatabaseType {
 }
 
 export abstract class DatabaseConnection extends Connection {
+  declare store: PackageableElementReference<Database>;
   type: DatabaseType;
   // debug?: boolean | undefined;
   timeZone?: string | undefined;
@@ -56,13 +56,6 @@ export abstract class DatabaseConnection extends Connection {
     type: DatabaseType,
   ) {
     super(store);
-
-    makeObservable(this, {
-      type: observable,
-      timeZone: observable,
-      quoteIdentifiers: observable,
-    });
-
     this.type = type;
   }
 }
@@ -72,14 +65,6 @@ export class RelationalDatabaseConnection extends DatabaseConnection {
   authenticationStrategy: AuthenticationStrategy;
   postProcessors: PostProcessor[] = [];
 
-  get database(): Database {
-    return guaranteeType(
-      this.store.value,
-      Database,
-      'Relational database connection must have a database store',
-    );
-  }
-
   constructor(
     store: PackageableElementReference<Database>,
     type: DatabaseType,
@@ -87,14 +72,6 @@ export class RelationalDatabaseConnection extends DatabaseConnection {
     authenticationStrategy: AuthenticationStrategy,
   ) {
     super(store, type);
-
-    makeObservable(this, {
-      datasourceSpecification: observable,
-      authenticationStrategy: observable,
-      database: computed,
-      hashCode: computed,
-    });
-
     this.datasourceSpecification = datasourceSpecification;
     this.authenticationStrategy = authenticationStrategy;
   }

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/EmbeddedRelationalInstanceSetImplementation.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import {
   UnsupportedOperationError,
   hashArray,
@@ -50,7 +49,7 @@ export class EmbeddedRelationalInstanceSetImplementation
     Hashable
 {
   root = InferableMappingElementRootExplicitValue.create(false);
-  override isEmbedded = true;
+  override readonly isEmbedded = true;
   id: InferableMappingElementIdValue;
   propertyMappings: PropertyMapping[] = [];
   class: PackageableElementReference<Class>;
@@ -68,15 +67,6 @@ export class EmbeddedRelationalInstanceSetImplementation
     target?: SetImplementation,
   ) {
     super(owner, property, source, target);
-
-    makeObservable(this, {
-      id: observable,
-      propertyMappings: observable,
-      rootInstanceSetImplementation: observable,
-      parent: observable,
-      primaryKey: observable,
-    });
-
     this.class = _class;
     this.id = id;
     this.rootInstanceSetImplementation = rootInstanceSetImplementation;

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/FilterMapping.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { computed, observable, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import type { Database } from '../model/Database';
@@ -22,25 +21,16 @@ import {
   extractLine,
   type JoinTreeNode,
 } from '../model/RelationalOperationElement';
-import type { RelationalInstanceSetImplementation } from './RelationalInstanceSetImplementation';
 import type { FilterReference } from '../model/FilterReference';
 
 export class FilterMapping implements Hashable {
-  setMappingOwner?: RelationalInstanceSetImplementation | undefined;
+  // setMappingOwner?: RelationalInstanceSetImplementation | undefined;
   joinTreeNode?: JoinTreeNode | undefined;
   database: Database;
   filterName: string;
   filter: FilterReference;
 
   constructor(db: Database, filterName: string, filter: FilterReference) {
-    makeObservable(this, {
-      setMappingOwner: observable,
-      joinTreeNode: observable,
-      database: observable,
-      filterName: observable,
-      hashCode: computed,
-    });
-
     this.database = db;
     this.filterName = filterName;
     this.filter = filter;

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/GroupByMapping.ts

@@ -14,18 +14,9 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import type { RelationalOperationElement } from '../model/RelationalOperationElement';
-import type { RelationalInstanceSetImplementation } from './RelationalInstanceSetImplementation';
 
 export class GroupByMapping {
-  setMappingOwner?: RelationalInstanceSetImplementation | undefined;
+  // setMappingOwner?: RelationalInstanceSetImplementation | undefined;
   columns: RelationalOperationElement[] = [];
-
-  constructor() {
-    makeObservable(this, {
-      setMappingOwner: observable,
-      columns: observable,
-    });
-  }
 }

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/InlineEmbeddedRelationalInstanceSetImplementation.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import { EmbeddedRelationalInstanceSetImplementation } from './EmbeddedRelationalInstanceSetImplementation';
 import type { InlineEmbeddedSetImplementation } from '../../../mapping/EmbeddedSetImplementation';
 import type {
@@ -22,12 +21,6 @@ import type {
   SetImplementationVisitor,
 } from '../../../mapping/SetImplementation';
 import type { PropertyMappingVisitor } from '../../../mapping/PropertyMapping';
-import type { PropertyMappingsImplementation } from '../../../mapping/PropertyMappingsImplementation';
-import type { PropertyReference } from '../../../domain/PropertyReference';
-import type { RootRelationalInstanceSetImplementation } from './RootRelationalInstanceSetImplementation';
-import type { PackageableElementReference } from '../../../PackageableElementReference';
-import type { Class } from '../../../domain/Class';
-import type { InferableMappingElementIdValue } from '../../../mapping/InferableMappingElementId';
 import { hashArray, UnsupportedOperationError } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 
@@ -37,30 +30,6 @@ export class InlineEmbeddedRelationalInstanceSetImplementation
 {
   inlineSetImplementation!: SetImplementation;
 
-  constructor(
-    owner: PropertyMappingsImplementation,
-    property: PropertyReference,
-    rootInstanceSetImplementation: RootRelationalInstanceSetImplementation,
-    source: SetImplementation,
-    _class: PackageableElementReference<Class>,
-    id: InferableMappingElementIdValue,
-    target?: SetImplementation,
-  ) {
-    super(
-      owner,
-      property,
-      rootInstanceSetImplementation,
-      source,
-      _class,
-      id,
-      target,
-    );
-
-    makeObservable(this, {
-      inlineSetImplementation: observable,
-    });
-  }
-
   override accept_PropertyMappingVisitor<T>(
     visitor: PropertyMappingVisitor<T>,
   ): T {

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/OtherwiseEmbeddedRelationalInstanceSetImplementation.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable } from 'mobx';
 import {
   type Hashable,
   hashArray,
@@ -23,20 +22,11 @@ import {
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { EmbeddedRelationalInstanceSetImplementation } from './EmbeddedRelationalInstanceSetImplementation';
 import type { OtherwiseEmebddedSetImplementation } from '../../../mapping/EmbeddedSetImplementation';
-import type {
-  SetImplementation,
-  SetImplementationVisitor,
-} from '../../../mapping/SetImplementation';
+import type { SetImplementationVisitor } from '../../../mapping/SetImplementation';
 import type {
   PropertyMapping,
   PropertyMappingVisitor,
 } from '../../../mapping/PropertyMapping';
-import type { PropertyMappingsImplementation } from '../../../mapping/PropertyMappingsImplementation';
-import type { PropertyReference } from '../../../domain/PropertyReference';
-import type { RootRelationalInstanceSetImplementation } from './RootRelationalInstanceSetImplementation';
-import type { PackageableElementReference } from '../../../PackageableElementReference';
-import type { Class } from '../../../domain/Class';
-import type { InferableMappingElementIdValue } from '../../../mapping/InferableMappingElementId';
 
 export class OtherwiseEmbeddedRelationalInstanceSetImplementation
   extends EmbeddedRelationalInstanceSetImplementation
@@ -44,31 +34,6 @@ export class OtherwiseEmbeddedRelationalInstanceSetImplementation
 {
   otherwisePropertyMapping!: PropertyMapping;
 
-  constructor(
-    owner: PropertyMappingsImplementation,
-    property: PropertyReference,
-    rootInstanceSetImplementation: RootRelationalInstanceSetImplementation,
-    source: SetImplementation,
-    _class: PackageableElementReference<Class>,
-    id: InferableMappingElementIdValue,
-    target?: SetImplementation,
-  ) {
-    super(
-      owner,
-      property,
-      rootInstanceSetImplementation,
-      source,
-      _class,
-      id,
-      target,
-    );
-
-    makeObservable(this, {
-      otherwisePropertyMapping: observable,
-      hashCode: computed,
-    });
-  }
-
   override accept_PropertyMappingVisitor<T>(
     visitor: PropertyMappingVisitor<T>,
   ): T {

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/RelationalInputData.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable } from 'mobx';
 import {
   hashArray,
   UnsupportedOperationError,
@@ -58,14 +57,6 @@ export class RelationalInputData extends InputData implements Hashable {
     inputType: RelationalInputType,
   ) {
     super();
-
-    makeObservable(this, {
-      data: observable,
-      inputType: observable,
-      validationResult: computed,
-      hashCode: computed,
-    });
-
     this.database = database;
     this.data = data;
     this.inputType = inputType;

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/RelationalInstanceSetImplementation.ts

@@ -14,18 +14,12 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import { type Hashable, hashArray } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { InstanceSetImplementation } from '../../../mapping/InstanceSetImplementation';
 import type { SetImplementationVisitor } from '../../../mapping/SetImplementation';
 import type { RelationalOperationElement } from '../model/RelationalOperationElement';
 import type { PropertyMapping } from '../../../mapping/PropertyMapping';
-import type { InferableMappingElementIdValue } from '../../../mapping/InferableMappingElementId';
-import type { Mapping } from '../../../mapping/Mapping';
-import type { PackageableElementReference } from '../../../PackageableElementReference';
-import type { Class } from '../../../domain/Class';
-import type { InferableMappingElementRoot } from '../../../mapping/InferableMappingElementRoot';
 import { EmbeddedRelationalInstanceSetImplementation } from './EmbeddedRelationalInstanceSetImplementation';
 
 export class RelationalInstanceSetImplementation
@@ -34,19 +28,6 @@ export class RelationalInstanceSetImplementation
 {
   primaryKey: RelationalOperationElement[] = [];
 
-  constructor(
-    id: InferableMappingElementIdValue,
-    parent: Mapping,
-    _class: PackageableElementReference<Class>,
-    root: InferableMappingElementRoot,
-  ) {
-    super(id, parent, _class, root);
-
-    makeObservable(this, {
-      primaryKey: observable,
-    });
-  }
-
   getEmbeddedSetImplmentations(): InstanceSetImplementation[] {
     const embeddedPropertyMappings = this.propertyMappings.filter(
       (

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/RelationalPropertyMapping.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import type { EnumerationMapping } from '../../../mapping/EnumerationMapping';
@@ -22,40 +21,22 @@ import {
   type PropertyMappingVisitor,
   PropertyMapping,
 } from '../../../mapping/PropertyMapping';
-import type { PropertyMappingsImplementation } from '../../../mapping/PropertyMappingsImplementation';
-import type { PropertyReference } from '../../../domain/PropertyReference';
-import type { SetImplementation } from '../../../mapping/SetImplementation';
 import { hashObjectWithoutSourceInformation } from '../../../../../../../MetaModelUtils';
 import {
   isStubRelationalOperationElement,
   type RawRelationalOperationElement,
 } from '../model/RawRelationalOperationElement';
-import type { BindingTransformer } from '../../../externalFormat/store/BindingTransformer';
+import type { BindingTransformer } from '../../../externalFormat/store/DSLExternalFormat_BindingTransformer';
 
 export class RelationalPropertyMapping
   extends PropertyMapping
   implements Hashable
 {
+  // TODO: convert to reference
   transformer?: EnumerationMapping | undefined;
   relationalOperation!: RawRelationalOperationElement; // @MARKER GENERATED MODEL DISCREPANCY --- Studio does not process relational operation element
   bindingTransformer?: BindingTransformer | undefined;
 
-  constructor(
-    owner: PropertyMappingsImplementation,
-    property: PropertyReference,
-    source: SetImplementation,
-    target?: SetImplementation,
-  ) {
-    super(owner, property, source, target);
-
-    makeObservable(this, {
-      transformer: observable,
-      relationalOperation: observable.ref,
-      bindingTransformer: observable,
-      hashCode: computed,
-    });
-  }
-
   accept_PropertyMappingVisitor<T>(visitor: PropertyMappingVisitor<T>): T {
     return visitor.visit_RelationalPropertyMapping(this);
   }