@finos/legend-graph 2.1.3 → 3.0.0

package/src/models/metamodels/pure/packageableElements/mapping/InferableMappingElementId.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { computed, makeObservable } from 'mobx';
 import { fromElementPathToMappingElementId } from '../../../../../MetaModelUtils';
 import { InferableValue } from '../../InferableValue';
 
@@ -26,11 +25,6 @@ export abstract class InferableMappingElementIdValue extends InferableValue<
 
   constructor(value: string, defaultValue: string) {
     super(value);
-
-    makeObservable(this, {
-      isDefault: computed,
-    });
-
     this.defaultValue = defaultValue;
   }
 
@@ -40,14 +34,6 @@ export abstract class InferableMappingElementIdValue extends InferableValue<
 }
 
 export class InferableMappingElementIdExplicitValue extends InferableMappingElementIdValue {
-  constructor(value: string, defaultValue: string) {
-    super(value, defaultValue);
-
-    makeObservable(this, {
-      valueForSerialization: computed,
-    });
-  }
-
   static create(
     value: string,
     targetPath: string,
@@ -73,11 +59,6 @@ export class InferableMappingElementIdImplicitValue extends InferableMappingElem
 
   constructor(value: string, defaultValue: string, input: string | undefined) {
     super(value, defaultValue);
-
-    makeObservable(this, {
-      valueForSerialization: computed,
-    });
-
     this.input = input;
   }
 

package/src/models/metamodels/pure/packageableElements/mapping/InferableMappingElementRoot.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { computed, makeObservable } from 'mobx';
 import { InferableValue } from '../../InferableValue';
 
 export abstract class InferableMappingElementRoot extends InferableValue<
@@ -25,10 +24,6 @@ export abstract class InferableMappingElementRoot extends InferableValue<
 export class InferableMappingElementRootExplicitValue extends InferableMappingElementRoot {
   private constructor(value: boolean) {
     super(value);
-
-    makeObservable(this, {
-      valueForSerialization: computed,
-    });
   }
 
   static create(value: boolean): InferableMappingElementRootExplicitValue {
@@ -45,11 +40,6 @@ export class InferableMappingElementRootImplicitValue extends InferableMappingEl
 
   private constructor(value: boolean, input: boolean) {
     super(value);
-
-    makeObservable(this, {
-      valueForSerialization: computed,
-    });
-
     this.input = input;
   }
 

package/src/models/metamodels/pure/packageableElements/mapping/InstanceSetImplementation.ts

@@ -14,17 +14,11 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import type { Hashable } from '@finos/legend-shared';
 import type { MappingClass } from './MappingClass';
 import { SetImplementation } from './SetImplementation';
 import type { PropertyMappingsImplementation } from './PropertyMappingsImplementation';
 import type { PropertyMapping } from './PropertyMapping';
-import type { InferableMappingElementIdValue } from './InferableMappingElementId';
-import type { Mapping } from './Mapping';
-import type { PackageableElementReference } from '../PackageableElementReference';
-import type { Class } from '../domain/Class';
-import type { InferableMappingElementRoot } from './InferableMappingElementRoot';
 
 export abstract class InstanceSetImplementation
   extends SetImplementation
@@ -34,20 +28,6 @@ export abstract class InstanceSetImplementation
   propertyMappings: PropertyMapping[] = [];
   // aggregateSpecification: AggregateSpecification[0..1];
 
-  constructor(
-    id: InferableMappingElementIdValue,
-    parent: Mapping,
-    _class: PackageableElementReference<Class>,
-    root: InferableMappingElementRoot,
-  ) {
-    super(id, parent, _class, root);
-
-    makeObservable(this, {
-      mappingClass: observable,
-      propertyMappings: observable,
-    });
-  }
-
   abstract getEmbeddedSetImplmentations(): InstanceSetImplementation[];
   abstract findPropertyMapping(
     propertyName: string,

package/src/models/metamodels/pure/packageableElements/mapping/LocalMappingPropertyInfo.ts

@@ -21,6 +21,7 @@ import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 
 export class LocalMappingPropertyInfo implements Hashable {
   localMappingProperty!: boolean;
+  // TODO: refactor this to use `PackageableElementReference`
   localMappingPropertyType!: Type;
   localMappingPropertyMultiplicity!: Multiplicity;
 

package/src/models/metamodels/pure/packageableElements/mapping/Mapping.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable, override } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import type { EnumerationMapping } from './EnumerationMapping';
@@ -35,23 +34,6 @@ export class Mapping extends PackageableElement implements Hashable, Stubable {
   associationMappings: AssociationImplementation[] = [];
   tests: MappingTest[] = [];
 
-  constructor(name: string) {
-    super(name);
-
-    makeObservable<Mapping, '_elementHashCode'>(this, {
-      includes: observable,
-      classMappings: observable,
-      enumerationMappings: observable,
-      associationMappings: observable,
-      tests: observable,
-      allOwnClassMappings: computed,
-      allOwnEnumerationMappings: computed,
-      allIncludedMappings: computed,
-      isStub: computed,
-      _elementHashCode: override,
-    });
-  }
-
   get allOwnClassMappings(): SetImplementation[] {
     return this.classMappings;
   }
@@ -95,7 +77,6 @@ export class Mapping extends PackageableElement implements Hashable, Stubable {
     return hashArray([
       CORE_HASH_STRUCTURE.MAPPING,
       this.path,
-      // TODO mapping include
       hashArray(this.classMappings),
       hashArray(this.enumerationMappings),
       hashArray(this.associationMappings),

package/src/models/metamodels/pure/packageableElements/mapping/MappingClass.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import type { SetImplementation } from './SetImplementation';
 import { Class } from '../domain/Class';
 import type { Property } from '../domain/Property';
@@ -23,12 +22,4 @@ export class MappingClass extends Class {
   setImplementation?: SetImplementation | undefined;
   class?: Class | undefined;
   localProperties: Property[] = [];
-
-  constructor(name: string) {
-    super(name);
-    makeObservable(this, {
-      setImplementation: observable,
-      class: observable,
-    });
-  }
 }

package/src/models/metamodels/pure/packageableElements/mapping/MappingInclude.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import { hashArray, getNullableFirstElement } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { PackageableElementReference } from '../PackageableElementReference';
@@ -27,11 +26,6 @@ export class MappingInclude {
   storeSubstitutions: SubstituteStore[] = [];
 
   constructor(owner: Mapping, included: PackageableElementReference<Mapping>) {
-    makeObservable(this, {
-      included: observable,
-      storeSubstitutions: observable,
-    });
-
     this.owner = owner;
     this.included = included;
   }

package/src/models/metamodels/pure/packageableElements/mapping/MappingTest.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable } from 'mobx';
 import { uuid, hashArray, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { MappingTestAssert } from './MappingTestAssert';
@@ -26,7 +25,8 @@ import {
 } from '../../../../../helpers/ValidationHelper';
 
 export class MappingTest implements Hashable {
-  uuid = uuid();
+  readonly uuid = uuid();
+
   name: string;
   query: RawLambda; // @MARKER GENERATED MODEL DISCREPANCY --- Studio does not process lambda
   inputData: InputData[] = [];
@@ -38,15 +38,6 @@ export class MappingTest implements Hashable {
     inputData: InputData[],
     assert: MappingTestAssert,
   ) {
-    makeObservable(this, {
-      name: observable,
-      query: observable,
-      inputData: observable,
-      assert: observable,
-      validationResult: computed,
-      hashCode: computed,
-    });
-
     this.name = name;
     this.query = query;
     this.inputData = inputData;

package/src/models/metamodels/pure/packageableElements/mapping/MergeOperationSetImplementation.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import { type Hashable, hashArray } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { PackageableElementReference } from '../PackageableElementReference';
@@ -46,11 +45,6 @@ export class MergeOperationSetImplementation
     validationFunction: RawLambda,
   ) {
     super(id, parent, pureClass, root, operation);
-
-    makeObservable(this, {
-      validationFunction: observable,
-    });
-
     this.validationFunction = validationFunction;
   }
 

package/src/models/metamodels/pure/packageableElements/mapping/OperationSetImplementation.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable } from 'mobx';
 import {
   type Hashable,
   hashArray,
@@ -61,14 +60,6 @@ export class OperationSetImplementation
     operation: OperationType,
   ) {
     super(id, parent, pureClass, root);
-
-    makeObservable(this, {
-      parameters: observable,
-      operation: observable,
-      isStub: computed,
-      hashCode: computed,
-    });
-
     this.operation = operation;
   }
 

package/src/models/metamodels/pure/packageableElements/mapping/PropertyMapping.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import {
   UnsupportedOperationError,
   hashArray,
@@ -62,7 +61,7 @@ export interface PropertyMappingVisitor<T> {
 }
 
 export abstract class PropertyMapping implements Hashable, Stubable {
-  isEmbedded = false;
+  readonly isEmbedded: boolean = false;
   property: PropertyReference;
   owner: PropertyMappingsImplementation; // the immediate parent instance set implementation that holds the property mappings
   // NOTE: in case the holder of this property mapping is an embedded property mapping, that embedded property mapping is considered the source
@@ -82,11 +81,6 @@ export abstract class PropertyMapping implements Hashable, Stubable {
     source: SetImplementation,
     target?: SetImplementation,
   ) {
-    makeObservable(this, {
-      sourceSetImplementation: observable,
-      targetSetImplementation: observable,
-    });
-
     this.owner = owner;
     this.sourceSetImplementation = source;
     this.targetSetImplementation = target;

package/src/models/metamodels/pure/packageableElements/mapping/SetImplementation.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import { fromElementPathToMappingElementId } from '../../../../../MetaModelUtils';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
@@ -79,7 +78,7 @@ export interface SetImplementationVisitor<T> {
 export abstract class SetImplementation
   implements PropertyOwnerImplementation, Hashable, Stubable
 {
-  isEmbedded = false;
+  readonly isEmbedded: boolean = false;
   id: InferableMappingElementIdValue;
   class: PackageableElementReference<Class>;
   root: InferableMappingElementRoot;
@@ -91,17 +90,12 @@ export abstract class SetImplementation
     _class: PackageableElementReference<Class>,
     root: InferableMappingElementRoot,
   ) {
-    makeObservable(this, {
-      root: observable,
-      parent: observable,
-      label: computed,
-    });
-
     this.id = id;
     this.parent = parent;
     this.class = _class;
     this.root = root;
   }
+
   get label(): MappingElementLabel {
     return {
       value: `${
@@ -151,7 +145,7 @@ export enum SET_IMPLEMENTATION_TYPE {
   AGGREGATION_AWARE = 'aggregationAware',
 }
 
-/* @MARKER: RELAXED GRAPH CHECK - See https://github.com/finos/legend-studio/issues/880 */
+/* @MARKER: RELAXED GRAPH CHECK - See https://github.com/finos/legend-studio/issues/941 */
 /**
  * When set implementation cannot be resolved by ID,
  * we try to avoid failing graph building for now
@@ -160,6 +154,7 @@ export enum SET_IMPLEMENTATION_TYPE {
  * NOTE: this is just a temporary solutions until we make this a hard-fail post migration.
  *
  * See https://github.com/finos/legend-studio/issues/880
+ * See https://github.com/finos/legend-studio/issues/941
  */
 export class TEMPORARY__UnresolvedSetImplementation extends SetImplementation {
   constructor(id: string, parent: Mapping) {

package/src/models/metamodels/pure/packageableElements/mapping/SetImplementationContainer.ts

@@ -14,20 +14,16 @@
  * limitations under the License.
  */
 
-import { computed, makeObservable } from 'mobx';
 import { uuid } from '@finos/legend-shared';
 import type { SetImplementationReference } from './SetImplementationReference';
 import type { Stubable } from '../../../../../helpers/Stubable';
 
 export class SetImplementationContainer implements Stubable {
-  uuid = uuid();
+  readonly uuid = uuid();
+
   setImplementation: SetImplementationReference;
 
   constructor(setImplementation: SetImplementationReference) {
-    makeObservable(this, {
-      isStub: computed,
-    });
-
     this.setImplementation = setImplementation;
   }
 

package/src/models/metamodels/pure/packageableElements/mapping/SetImplementationReference.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -33,19 +32,9 @@ export abstract class SetImplementationReference extends ReferenceWithOwner {
     value: SetImplementation,
   ) {
     super(ownerReference);
-
-    makeObservable(this, {
-      value: observable,
-    });
-
     this.ownerReference = ownerReference;
     this.value = value;
   }
-
-  setValue(value: SetImplementation): void {
-    this.value = value;
-    this.ownerReference.value = value.parent;
-  }
 }
 
 export class SetImplementationExplicitReference extends SetImplementationReference {

package/src/models/metamodels/pure/packageableElements/mapping/SubstituteStore.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable } from 'mobx';
 import type { Store } from '../store/Store';
 import type { PackageableElementReference } from '../PackageableElementReference';
 import type { MappingInclude } from './MappingInclude';
@@ -29,11 +28,6 @@ export class SubstituteStore {
     original: PackageableElementReference<Store>,
     substitue: PackageableElementReference<Store>,
   ) {
-    makeObservable(this, {
-      original: observable,
-      substitute: observable,
-    });
-
     this.owner = owner;
     this.original = original;
     this.substitute = substitue;

package/src/models/metamodels/pure/packageableElements/runtime/PackageableRuntime.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable, override } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import {
@@ -26,15 +25,6 @@ import type { EngineRuntime } from './Runtime';
 export class PackageableRuntime extends PackageableElement implements Hashable {
   runtimeValue!: EngineRuntime;
 
-  constructor(name: string) {
-    super(name);
-
-    makeObservable<PackageableRuntime, '_elementHashCode'>(this, {
-      runtimeValue: observable,
-      _elementHashCode: override,
-    });
-  }
-
   protected override get _elementHashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.PACKAGEABLE_RUNTIME,

package/src/models/metamodels/pure/packageableElements/runtime/Runtime.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable } from 'mobx';
 import {
   type Hashable,
   hashArray,
@@ -34,17 +33,12 @@ import {
 import type { PackageableElementReference } from '../PackageableElementReference';
 
 export class IdentifiedConnection implements Hashable {
-  uuid = uuid();
+  readonly uuid = uuid();
+
   id: string;
   connection: Connection;
 
   constructor(id: string, connection: Connection) {
-    makeObservable(this, {
-      id: observable,
-      connection: observable,
-      hashCode: computed,
-    });
-
     this.id = id;
     this.connection = connection;
   }
@@ -63,12 +57,6 @@ export class StoreConnections implements Hashable {
   storeConnections: IdentifiedConnection[] = [];
 
   constructor(store: PackageableElementReference<Store>) {
-    makeObservable(this, {
-      storeConnections: observable,
-      isStub: computed,
-      hashCode: computed,
-    });
-
     this.store = store;
   }
 
@@ -96,17 +84,6 @@ export class EngineRuntime extends Runtime implements Hashable {
   mappings: PackageableElementReference<Mapping>[] = [];
   connections: StoreConnections[] = [];
 
-  constructor() {
-    super();
-
-    makeObservable(this, {
-      mappings: observable,
-      connections: observable,
-      allIdentifiedConnections: computed,
-      hashCode: computed,
-    });
-  }
-
   get allIdentifiedConnections(): IdentifiedConnection[] {
     return this.connections.flatMap(
       (storeConnections) => storeConnections.storeConnections,
@@ -152,11 +129,6 @@ export class RuntimePointer extends Runtime implements Hashable {
     packageableRuntime: PackageableElementReference<PackageableRuntime>,
   ) {
     super();
-
-    makeObservable(this, {
-      hashCode: computed,
-    });
-
     this.packageableRuntime = packageableRuntime;
   }
 

package/src/models/metamodels/pure/packageableElements/section/Section.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import type { PackageableElement } from '../PackageableElement';
@@ -33,12 +32,6 @@ export abstract class Section implements Hashable {
   elements: PackageableElementExplicitReference<PackageableElement>[] = [];
 
   constructor(parserName: string, parent: SectionIndex) {
-    makeObservable(this, {
-      parent: observable,
-      parserName: observable,
-      elements: observable,
-    });
-
     this.parserName = parserName;
     this.parent = parent;
   }
@@ -55,15 +48,6 @@ export abstract class Section implements Hashable {
 export class ImportAwareCodeSection extends Section {
   imports: PackageableElementExplicitReference<Package>[] = [];
 
-  constructor(parserName: string, parent: SectionIndex) {
-    super(parserName, parent);
-
-    makeObservable(this, {
-      imports: observable,
-      hashCode: computed,
-    });
-  }
-
   override get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.IMPORT_AWARE_CODE_SECTION,
@@ -74,14 +58,6 @@ export class ImportAwareCodeSection extends Section {
 }
 
 export class DefaultCodeSection extends Section {
-  constructor(parserName: string, parent: SectionIndex) {
-    super(parserName, parent);
-
-    makeObservable(this, {
-      hashCode: computed,
-    });
-  }
-
   override get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.DEFAULT_CODE_SECTION,

package/src/models/metamodels/pure/packageableElements/section/SectionIndex.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, makeObservable, override } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import {
@@ -26,15 +25,6 @@ import type { Section } from './Section';
 export class SectionIndex extends PackageableElement implements Hashable {
   sections: Section[] = [];
 
-  constructor(name: string) {
-    super(name);
-
-    makeObservable<SectionIndex, '_elementHashCode'>(this, {
-      sections: observable,
-      _elementHashCode: override,
-    });
-  }
-
   protected override get _elementHashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.SECTION_INDEX,

package/src/models/metamodels/pure/packageableElements/service/Service.ts

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable, override } from 'mobx';
 import { hashArray, uniq, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { ServiceExecution } from './ServiceExecution';
@@ -40,18 +39,6 @@ export class Service extends PackageableElement implements Hashable {
 
   constructor(name: string) {
     super(name);
-
-    makeObservable<Service, '_elementHashCode'>(this, {
-      pattern: observable,
-      owners: observable,
-      documentation: observable,
-      autoActivateUpdates: observable,
-      execution: observable,
-      test: observable,
-      patternParameters: computed,
-      _elementHashCode: override,
-    });
-
     this.test = new SingleExecutionTest(this, '');
   }
   get patternParameters(): string[] {