@finos/legend-graph 2.1.0 → 2.1.3

package/src/models/metamodels/pure/packageableElements/mapping/EnumValueMapping.ts

@@ -14,22 +14,11 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
-import {
-  type Hashable,
-  uuid,
-  isNumber,
-  hashArray,
-  guaranteeNonNullable,
-} from '@finos/legend-shared';
-import {
-  CORE_HASH_STRUCTURE,
-  PRIMITIVE_TYPE,
-} from '../../../../../MetaModelConst';
+import { observable, computed, makeObservable } from 'mobx';
+import { type Hashable, uuid, isNumber, hashArray } from '@finos/legend-shared';
+import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import { Enum } from '../domain/Enum';
 import type { Stubable } from '../../../../../helpers/Stubable';
-import { Type } from '../domain/Type';
-import { Enumeration } from '../domain/Enumeration';
 import type { EnumValueReference } from '../domain/EnumValueReference';
 
 export class SourceValue implements Stubable {
@@ -39,17 +28,12 @@ export class SourceValue implements Stubable {
   constructor(value: Enum | string | number | undefined) {
     makeObservable(this, {
       value: observable,
-      setValue: action,
       isStub: computed,
     });
 
     this.value = value;
   }
 
-  setValue(value: Enum | string | number | undefined): void {
-    this.value = value;
-  }
-
   get isStub(): boolean {
     return this.value === undefined;
   }
@@ -62,50 +46,12 @@ export class EnumValueMapping implements Hashable, Stubable {
   constructor(enumValue: EnumValueReference) {
     makeObservable(this, {
       sourceValues: observable,
-      addSourceValue: action,
-      setSourceValues: action,
-      deleteSourceValue: action,
-      updateSourceValue: action,
       isStub: computed,
       hashCode: computed,
     });
 
     this.enum = enumValue;
   }
-
-  addSourceValue(): void {
-    this.sourceValues.push(new SourceValue(undefined));
-  }
-  setSourceValues(value: SourceValue[]): void {
-    this.sourceValues = value;
-  }
-  deleteSourceValue(idx: number): void {
-    this.sourceValues.splice(idx, 1);
-  }
-  updateSourceValue(
-    idx: number,
-    val: Enum | string | undefined,
-    sourceType: Type | undefined,
-  ): void {
-    const sourceValue = guaranteeNonNullable(this.sourceValues[idx]);
-    // If the source type is an enumeration but the value does NOT match an enum value (most likely user is mid typing an enum value)
-    // we move on to update the source value with the string value
-    if (
-      sourceType instanceof Enumeration &&
-      typeof val === 'string' &&
-      sourceType.getValueNames().includes(val)
-    ) {
-      sourceValue.setValue(sourceType.getValue(val));
-    } else {
-      // Here we update the source values depending on the source type.
-      sourceValue.setValue(
-        sourceType instanceof Type && sourceType.name === PRIMITIVE_TYPE.INTEGER
-          ? parseInt(val as string)
-          : val,
-      );
-    }
-  }
-
   get isStub(): boolean {
     return !this.sourceValues.filter((value) => !value.isStub).length;
   }

package/src/models/metamodels/pure/packageableElements/mapping/EnumerationMapping.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import { fromElementPathToMappingElementId } from '../../../../../MetaModelUtils';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
@@ -50,10 +50,6 @@ export class EnumerationMapping implements Hashable, Stubable {
     makeObservable(this, {
       sourceType: observable,
       enumValueMappings: observable,
-      setId: action,
-      setSourceType: action,
-      setEnumValueMappings: action,
-      updateSourceType: action,
       label: computed,
       isStub: computed,
       hashCode: computed,
@@ -65,29 +61,6 @@ export class EnumerationMapping implements Hashable, Stubable {
     this.sourceType = sourceType;
   }
 
-  setId(value: string): void {
-    this.id.setValue(value);
-  }
-  setSourceType(value: Type | undefined): void {
-    this.sourceType.setValue(value);
-  }
-  setEnumValueMappings(value: EnumValueMapping[]): void {
-    this.enumValueMappings = value;
-  }
-
-  updateSourceType(type: Type | undefined): void {
-    if (this.sourceType.value !== type) {
-      this.setSourceType(type);
-      this.enumValueMappings = this.enumValueMappings.map(
-        (enumValueMapping) => {
-          enumValueMapping.sourceValues = [];
-          enumValueMapping.addSourceValue();
-          return enumValueMapping;
-        },
-      );
-    }
-  }
-
   get label(): MappingElementLabel {
     return {
       value: `${

package/src/models/metamodels/pure/packageableElements/mapping/ExpectedOutputMappingTestAssert.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable, action } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import {
   type Hashable,
   hashArray,
@@ -40,7 +40,6 @@ export class ExpectedOutputMappingTestAssert
 
     makeObservable(this, {
       expectedOutput: observable,
-      setExpectedOutput: action,
       validationResult: computed,
       hashCode: computed,
     });
@@ -49,10 +48,6 @@ export class ExpectedOutputMappingTestAssert
     this.expectedOutput = tryToMinifyLosslessJSONString(expectedOutput);
   }
 
-  setExpectedOutput(val: string): void {
-    this.expectedOutput = val;
-  }
-
   get validationResult(): ValidationIssue | undefined {
     return !isValidJSONString(fromGrammarString(this.expectedOutput))
       ? createValidationError([

package/src/models/metamodels/pure/packageableElements/mapping/Mapping.ts

@@ -14,14 +14,9 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable, override } from 'mobx';
+import { observable, computed, makeObservable, override } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
-import {
-  hashArray,
-  deleteEntry,
-  addUniqueEntry,
-  type Hashable,
-} from '@finos/legend-shared';
+import { hashArray, type Hashable } from '@finos/legend-shared';
 import type { EnumerationMapping } from './EnumerationMapping';
 import type { SetImplementation } from './SetImplementation';
 import type { AssociationImplementation } from './AssociationImplementation';
@@ -49,14 +44,6 @@ export class Mapping extends PackageableElement implements Hashable, Stubable {
       enumerationMappings: observable,
       associationMappings: observable,
       tests: observable,
-      addClassMapping: action,
-      deleteClassMapping: action,
-      addEnumerationMapping: action,
-      deleteEnumerationMapping: action,
-      addAssociationMapping: action,
-      deleteAssociationMapping: action,
-      deleteTest: action,
-      addTest: action,
       allOwnClassMappings: computed,
       allOwnEnumerationMappings: computed,
       allIncludedMappings: computed,
@@ -65,38 +52,6 @@ export class Mapping extends PackageableElement implements Hashable, Stubable {
     });
   }
 
-  addClassMapping(val: SetImplementation): void {
-    addUniqueEntry(this.classMappings, val);
-  }
-
-  deleteClassMapping(val: SetImplementation): void {
-    deleteEntry(this.classMappings, val);
-  }
-
-  addEnumerationMapping(val: EnumerationMapping): void {
-    addUniqueEntry(this.enumerationMappings, val);
-  }
-
-  deleteEnumerationMapping(val: EnumerationMapping): void {
-    deleteEntry(this.enumerationMappings, val);
-  }
-
-  addAssociationMapping(val: AssociationImplementation): void {
-    addUniqueEntry(this.associationMappings, val);
-  }
-
-  deleteAssociationMapping(val: AssociationImplementation): void {
-    deleteEntry(this.associationMappings, val);
-  }
-
-  deleteTest(val: MappingTest): void {
-    deleteEntry(this.tests, val);
-  }
-
-  addTest(val: MappingTest): void {
-    addUniqueEntry(this.tests, val);
-  }
-
   get allOwnClassMappings(): SetImplementation[] {
     return this.classMappings;
   }

package/src/models/metamodels/pure/packageableElements/mapping/MappingInclude.ts

@@ -14,12 +14,8 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable } from 'mobx';
-import {
-  hashArray,
-  getNullableFirstElement,
-  addUniqueEntry,
-} from '@finos/legend-shared';
+import { observable, makeObservable } from 'mobx';
+import { hashArray, getNullableFirstElement } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { PackageableElementReference } from '../PackageableElementReference';
 import type { Mapping } from './Mapping';
@@ -34,17 +30,12 @@ export class MappingInclude {
     makeObservable(this, {
       included: observable,
       storeSubstitutions: observable,
-      addStoreSubstitution: action,
     });
 
     this.owner = owner;
     this.included = included;
   }
 
-  addStoreSubstitution(value: SubstituteStore): void {
-    addUniqueEntry(this.storeSubstitutions, value);
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.MAPPING_INCLUDE,

package/src/models/metamodels/pure/packageableElements/mapping/MappingTest.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { uuid, hashArray, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { MappingTestAssert } from './MappingTestAssert';
@@ -43,10 +43,6 @@ export class MappingTest implements Hashable {
       query: observable,
       inputData: observable,
       assert: observable,
-      setName: action,
-      setInputData: action,
-      setQuery: action,
-      setAssert: action,
       validationResult: computed,
       hashCode: computed,
     });
@@ -57,22 +53,6 @@ export class MappingTest implements Hashable {
     this.assert = assert;
   }
 
-  setName(value: string): void {
-    this.name = value;
-  }
-
-  setInputData(value: InputData[]): void {
-    this.inputData = value;
-  }
-
-  setQuery(value: RawLambda): void {
-    this.query = value;
-  }
-
-  setAssert(value: MappingTestAssert): void {
-    this.assert = value;
-  }
-
   get validationResult(): ValidationIssue[] | undefined {
     let problems: ValidationIssue[] = [];
     // query

package/src/models/metamodels/pure/packageableElements/mapping/MergeOperationSetImplementation.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable } from 'mobx';
+import { observable, makeObservable } from 'mobx';
 import { type Hashable, hashArray } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { PackageableElementReference } from '../PackageableElementReference';
@@ -49,16 +49,11 @@ export class MergeOperationSetImplementation
 
     makeObservable(this, {
       validationFunction: observable,
-      setValidationFunction: action,
     });
 
     this.validationFunction = validationFunction;
   }
 
-  setValidationFunction(value: RawLambda): void {
-    this.validationFunction = value;
-  }
-
   override get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.OPERATION_SET_IMPLEMENTATION,

package/src/models/metamodels/pure/packageableElements/mapping/OperationSetImplementation.ts

@@ -14,14 +14,11 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import {
   type Hashable,
   hashArray,
   guaranteeNonNullable,
-  addUniqueEntry,
-  deleteEntry,
-  changeEntry,
 } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { PackageableElementReference } from '../PackageableElementReference';
@@ -68,11 +65,6 @@ export class OperationSetImplementation
     makeObservable(this, {
       parameters: observable,
       operation: observable,
-      setOperation: action,
-      setParameters: action,
-      addParameter: action,
-      changeParameter: action,
-      deleteParameter: action,
       isStub: computed,
       hashCode: computed,
     });
@@ -80,25 +72,6 @@ export class OperationSetImplementation
     this.operation = operation;
   }
 
-  setOperation(value: OperationType): void {
-    this.operation = value;
-  }
-  setParameters(value: SetImplementationContainer[]): void {
-    this.parameters = value;
-  }
-  addParameter(value: SetImplementationContainer): void {
-    addUniqueEntry(this.parameters, value);
-  }
-  changeParameter(
-    oldValue: SetImplementationContainer,
-    newValue: SetImplementationContainer,
-  ): void {
-    changeEntry(this.parameters, oldValue, newValue);
-  }
-  deleteParameter(value: SetImplementationContainer): void {
-    deleteEntry(this.parameters, value);
-  }
-
   /**
    * Get all leaf impls of an operation Set Implementation. Accounts for loops and duplication (which should be caught by compiler).
    */

package/src/models/metamodels/pure/packageableElements/mapping/SetImplementation.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import { fromElementPathToMappingElementId } from '../../../../../MetaModelUtils';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
@@ -94,8 +94,6 @@ export abstract class SetImplementation
     makeObservable(this, {
       root: observable,
       parent: observable,
-      setId: action,
-      setRoot: action,
       label: computed,
     });
 
@@ -104,14 +102,6 @@ export abstract class SetImplementation
     this.class = _class;
     this.root = root;
   }
-
-  setId(value: string): void {
-    this.id.setValue(value);
-  }
-  setRoot(value: boolean): void {
-    this.root.setValue(value);
-  }
-
   get label(): MappingElementLabel {
     return {
       value: `${

package/src/models/metamodels/pure/packageableElements/mapping/SetImplementationContainer.ts

@@ -14,11 +14,10 @@
  * limitations under the License.
  */
 
-import { computed, action, makeObservable } from 'mobx';
+import { computed, makeObservable } from 'mobx';
 import { uuid } from '@finos/legend-shared';
 import type { SetImplementationReference } from './SetImplementationReference';
 import type { Stubable } from '../../../../../helpers/Stubable';
-import type { SetImplementation } from './SetImplementation';
 
 export class SetImplementationContainer implements Stubable {
   uuid = uuid();
@@ -26,17 +25,12 @@ export class SetImplementationContainer implements Stubable {
 
   constructor(setImplementation: SetImplementationReference) {
     makeObservable(this, {
-      setSetImplementation: action,
       isStub: computed,
     });
 
     this.setImplementation = setImplementation;
   }
 
-  setSetImplementation(value: SetImplementation): void {
-    this.setImplementation.setValue(value);
-  }
-
   get isStub(): boolean {
     return !this.setImplementation.value.id;
   }

package/src/models/metamodels/pure/packageableElements/mapping/SetImplementationReference.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable } from 'mobx';
+import { observable, makeObservable } from 'mobx';
 import {
   PackageableElementExplicitReference,
   type PackageableElementReference,
@@ -23,7 +23,6 @@ import {
 import type { Mapping } from './Mapping';
 import type { SetImplementation } from './SetImplementation';
 import { ReferenceWithOwner } from '../../Reference';
-import { setPackageableElementReferenceValue } from '../../../../DomainModifierHelper';
 
 export abstract class SetImplementationReference extends ReferenceWithOwner {
   override readonly ownerReference: PackageableElementReference<Mapping>;
@@ -37,7 +36,6 @@ export abstract class SetImplementationReference extends ReferenceWithOwner {
 
     makeObservable(this, {
       value: observable,
-      setValue: action,
     });
 
     this.ownerReference = ownerReference;
@@ -46,7 +44,7 @@ export abstract class SetImplementationReference extends ReferenceWithOwner {
 
   setValue(value: SetImplementation): void {
     this.value = value;
-    setPackageableElementReferenceValue(this.ownerReference, value.parent);
+    this.ownerReference.value = value.parent;
   }
 }
 

package/src/models/metamodels/pure/packageableElements/runtime/PackageableRuntime.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable, override } from 'mobx';
+import { observable, makeObservable, override } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import {
@@ -31,15 +31,10 @@ export class PackageableRuntime extends PackageableElement implements Hashable {
 
     makeObservable<PackageableRuntime, '_elementHashCode'>(this, {
       runtimeValue: observable,
-      setRuntimeValue: action,
       _elementHashCode: override,
     });
   }
 
-  setRuntimeValue(value: EngineRuntime): void {
-    this.runtimeValue = value;
-  }
-
   protected override get _elementHashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.PACKAGEABLE_RUNTIME,

package/src/models/metamodels/pure/packageableElements/runtime/Runtime.ts

@@ -14,30 +14,24 @@
  * limitations under the License.
  */
 
-import { observable, computed, action, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import {
   type Hashable,
   hashArray,
   generateEnumerableNameFromToken,
   assertTrue,
   uuid,
-  addUniqueEntry,
-  deleteEntry,
 } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { Connection } from '../connection/Connection';
 import type { PackageableRuntime } from './PackageableRuntime';
 import type { Mapping } from '../mapping/Mapping';
 import type { Store } from '../store/Store';
-import {
-  type PackageableElementReference,
-  PackageableElementExplicitReference,
-} from '../PackageableElementReference';
 import {
   getElementPointerHashCode,
   PACKAGEABLE_ELEMENT_POINTER_TYPE,
 } from '../PackageableElement';
-import { setPackageableElementReferenceValue } from '../../../../DomainModifierHelper';
+import type { PackageableElementReference } from '../PackageableElementReference';
 
 export class IdentifiedConnection implements Hashable {
   uuid = uuid();
@@ -108,58 +102,11 @@ export class EngineRuntime extends Runtime implements Hashable {
     makeObservable(this, {
       mappings: observable,
       connections: observable,
-      addIdentifiedConnection: action,
-      deleteIdentifiedConnection: action,
-      addUniqueStoreConnectionsForStore: action,
-      setMappings: action,
-      addMapping: action,
-      deleteMapping: action,
       allIdentifiedConnections: computed,
       hashCode: computed,
     });
   }
 
-  addIdentifiedConnection(value: IdentifiedConnection): void {
-    const store = value.connection.store;
-    const storeConnections =
-      this.connections.find((sc) => sc.store.value === store.value) ??
-      new StoreConnections(store);
-    addUniqueEntry(this.connections, storeConnections);
-    assertTrue(
-      !storeConnections.storeConnections
-        .map((connection) => connection.id)
-        .includes(value.id),
-      `Can't add identified connection as a connection with the same ID '${value.id} already existed'`,
-    );
-    addUniqueEntry(storeConnections.storeConnections, value);
-  }
-
-  deleteIdentifiedConnection(value: IdentifiedConnection): void {
-    const storeConnections = this.connections.find(
-      (sc) => sc.store.value === value.connection.store.value,
-    );
-    if (storeConnections) {
-      deleteEntry(storeConnections.storeConnections, value);
-    }
-  }
-
-  addUniqueStoreConnectionsForStore(value: Store): void {
-    if (!this.connections.find((sc) => sc.store.value === value)) {
-      this.connections.push(
-        new StoreConnections(PackageableElementExplicitReference.create(value)),
-      );
-    }
-  }
-  setMappings(value: PackageableElementReference<Mapping>[]): void {
-    this.mappings = value;
-  }
-  addMapping(value: PackageableElementReference<Mapping>): void {
-    addUniqueEntry(this.mappings, value);
-  }
-  deleteMapping(value: PackageableElementReference<Mapping>): void {
-    deleteEntry(this.mappings, value);
-  }
-
   get allIdentifiedConnections(): IdentifiedConnection[] {
     return this.connections.flatMap(
       (storeConnections) => storeConnections.storeConnections,
@@ -213,10 +160,6 @@ export class RuntimePointer extends Runtime implements Hashable {
     this.packageableRuntime = packageableRuntime;
   }
 
-  setPackageableRuntime(value: PackageableRuntime): void {
-    setPackageableElementReferenceValue(this.packageableRuntime, value);
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.RUNTIME_POINTER,