@finos/legend-graph 2.1.0 → 2.1.3

package/src/models/ModelGenerationConfiguration.ts

@@ -0,0 +1,25 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export abstract class ModelGenerationConfiguration {
+  key: string;
+  label?: string | undefined;
+
+  protected constructor(key: string, label: string | undefined) {
+    this.key = key;
+    this.label = label;
+  }
+}

package/src/models/metamodels/pure/packageableElements/PackageableElement.ts

@@ -91,10 +91,7 @@ export abstract class PackageableElement implements Hashable, Stubable {
       _elementHashCode: computed,
       // We need to enable `keepAlive` to facillitate precomputation of element hash code
       hashCode: computed({ keepAlive: true }),
-      setName: action,
-      setPackage: action,
       setIsDeleted: action,
-      deleteElementFromGraph: action,
       dispose: action,
       freeze: action,
     });
@@ -110,27 +107,10 @@ export abstract class PackageableElement implements Hashable, Stubable {
     return this._isDeleted;
   }
 
-  setName(value: string): void {
-    this.name = value;
-  }
-
-  setPackage(val: Package | undefined): void {
-    this.package = val;
-  }
-
   setIsDeleted(value: boolean): void {
     this._isDeleted = value;
   }
 
-  deleteElementFromGraph(): void {
-    if (this.package) {
-      this.package.children = this.package.children.filter(
-        (child) => child !== this,
-      );
-    }
-    this.setIsDeleted(true);
-  }
-
   /**
    * Get root element. In the ideal case, this method is important for finding the root package, but
    * if we do something like `this instanceof Package` that would case circular dependency.

package/src/models/metamodels/pure/packageableElements/connection/Connection.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { computed, makeObservable, action, observable } from 'mobx';
+import { computed, makeObservable, observable } from 'mobx';
 import { hashArray, uuid, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { Store } from '../store/Store';
@@ -25,7 +25,6 @@ import type { PackageableConnection } from './PackageableConnection';
 import type { RelationalDatabaseConnection } from '../store/relational/connection/RelationalDatabaseConnection';
 import type { PackageableElementReference } from '../PackageableElementReference';
 import type { ModelChainConnection } from '../store/modelToModel/connection/ModelChainConnection';
-import { setPackageableElementReferenceValue } from '../../../../DomainModifierHelper';
 
 export interface ConnectionVisitor<T> {
   visit_Connection(connection: Connection): T;
@@ -48,15 +47,10 @@ export abstract class Connection implements Hashable {
     this.store = store;
 
     makeObservable(this, {
-      setStore: action,
       store: observable,
     });
   }
 
-  setStore(val: PackageableElementReference<Store>): void {
-    this.store = val;
-  }
-
   abstract get hashCode(): string;
 
   abstract accept_ConnectionVisitor<T>(visitor: ConnectionVisitor<T>): T;
@@ -78,7 +72,7 @@ export class ConnectionPointer extends Connection implements Hashable {
   }
 
   setPackageableConnection(value: PackageableConnection): void {
-    setPackageableElementReferenceValue(this.packageableConnection, value);
+    this.packageableConnection.value = value;
   }
 
   get hashCode(): string {

package/src/models/metamodels/pure/packageableElements/connection/PackageableConnection.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable, override } from 'mobx';
+import { observable, makeObservable, override } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import {
@@ -34,15 +34,10 @@ export class PackageableConnection
 
     makeObservable<PackageableConnection, '_elementHashCode'>(this, {
       connectionValue: observable,
-      setConnectionValue: action,
       _elementHashCode: override,
     });
   }
 
-  setConnectionValue(connection: Connection): void {
-    this.connectionValue = connection;
-  }
-
   protected override get _elementHashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.PACKAGEABLE_CONNECTION,

package/src/models/metamodels/pure/packageableElements/domain/Association.ts

@@ -39,7 +39,6 @@ import type { TaggedValue } from './TaggedValue';
 import type { StereotypeReference } from './StereotypeReference';
 import { DerivedProperty } from './DerivedProperty';
 import type { AbstractProperty } from './AbstractProperty';
-import { setGenericTypeReferenceValue } from '../../../../DomainModifierHelper';
 
 // NOTE: we might want to revisit this decision to initialize to association properties to stubs
 const initAssociationProperties = (
@@ -147,7 +146,9 @@ export class Association
     // set up the relationship between the other property and the new class
     addUniqueEntry(type.propertiesFromAssociations, otherProperty);
     // set new type for the property
-    setGenericTypeReferenceValue(property.genericType, new GenericType(type));
+    const _genType = new GenericType(type);
+    property.genericType.value = _genType;
+    property.genericType.ownerReference.value = _genType.rawType;
   };
 
   override get isStub(): boolean {

package/src/models/metamodels/pure/packageableElements/domain/Package.ts

@@ -29,7 +29,6 @@ import {
   type PackageableElementVisitor,
   PackageableElement,
 } from '../PackageableElement';
-import { addPackageChild } from '../../../../DomainModifierHelper';
 
 export const RESERVERD_PACKAGE_NAMES = ['$implicit'];
 
@@ -51,7 +50,7 @@ export class Package extends PackageableElement implements Hashable {
       `Can't create package with reserved name '${name}'`,
     );
     const newPackage = new Package(name);
-    newPackage.setPackage(parent);
+    newPackage.package = parent;
     return newPackage;
   }
 
@@ -89,7 +88,9 @@ export class Package extends PackageableElement implements Hashable {
       }
       // create the node if it is not in parent package
       node = Package.createPackageFromParent(str, parent);
-      addPackageChild(parent, node);
+      // NOTE: here we directly push the element to the children array without any checks rather than use `addUniqueEntry` to improve performance.
+      // Duplication checks should be handled separately
+      parent.children.push(node);
     }
     if (index !== -1) {
       return Package.getOrCreatePackage(

package/src/models/metamodels/pure/packageableElements/externalFormat/connection/DSLExternalFormat_ExternalFormatConnection.ts

@@ -15,7 +15,7 @@
  */
 
 import { type Hashable, ContentType, hashArray } from '@finos/legend-shared';
-import { action, computed, makeObservable, observable } from 'mobx';
+import { computed, makeObservable, observable } from 'mobx';
 import type { Binding } from '../store/DSLExternalFormat_Binding';
 import type { UrlStream } from './DSLExternalFormat_UrlStream';
 import {
@@ -34,7 +34,6 @@ export class ExternalFormatConnection extends Connection implements Hashable {
 
     makeObservable(this, {
       externalSource: observable,
-      setSource: action,
       hashCode: computed,
     });
   }

package/src/models/metamodels/pure/packageableElements/externalFormat/connection/DSLExternalFormat_UrlStream.ts

@@ -15,7 +15,7 @@
  */
 
 import { type Hashable, hashArray } from '@finos/legend-shared';
-import { action, computed, makeObservable, observable } from 'mobx';
+import { computed, makeObservable, observable } from 'mobx';
 import { DSL_EXTERNAL_FORMAT_HASH_STRUCTURE } from '../../../../../DSLExternalFormat_ModelUtils';
 
 export class UrlStream implements Hashable {
@@ -25,14 +25,9 @@ export class UrlStream implements Hashable {
     makeObservable(this, {
       url: observable,
       hashCode: computed,
-      setUrl: action,
     });
   }
 
-  setUrl(val: string): void {
-    this.url = val;
-  }
-
   get hashCode(): string {
     return hashArray([DSL_EXTERNAL_FORMAT_HASH_STRUCTURE.URL_STREAM, this.url]);
   }

package/src/models/metamodels/pure/packageableElements/externalFormat/schemaSet/DSLExternalFormat_Schema.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable, action } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { uuid, hashArray, type Hashable } from '@finos/legend-shared';
 import { DSL_EXTERNAL_FORMAT_HASH_STRUCTURE } from '../../../../../DSLExternalFormat_ModelUtils';
 
@@ -29,25 +29,10 @@ export class Schema implements Hashable {
       id: observable,
       location: observable,
       content: observable,
-      setId: action,
-      setLocation: action,
-      setContent: action,
       hashCode: computed,
     });
   }
 
-  setId(value: string): void {
-    this.id = value;
-  }
-
-  setLocation(value: string): void {
-    this.location = value;
-  }
-
-  setContent(value: string): void {
-    this.content = value;
-  }
-
   get hashCode(): string {
     return hashArray([
       DSL_EXTERNAL_FORMAT_HASH_STRUCTURE.SCHEMA,

package/src/models/metamodels/pure/packageableElements/externalFormat/schemaSet/DSLExternalFormat_SchemaSet.ts

@@ -14,13 +14,8 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable, override } from 'mobx';
-import {
-  hashArray,
-  addUniqueEntry,
-  deleteEntry,
-  type Hashable,
-} from '@finos/legend-shared';
+import { observable, makeObservable, override } from 'mobx';
+import { hashArray, type Hashable } from '@finos/legend-shared';
 import type { Schema } from './DSLExternalFormat_Schema';
 import {
   type PackageableElementVisitor,
@@ -38,25 +33,10 @@ export class SchemaSet extends PackageableElement implements Hashable {
     makeObservable<SchemaSet, '_elementHashCode'>(this, {
       format: observable,
       schemas: observable,
-      setFormat: action,
-      addSchema: action,
-      deleteSchema: action,
       _elementHashCode: override,
     });
   }
 
-  setFormat(value: string): void {
-    this.format = value;
-  }
-
-  addSchema(value: Schema): void {
-    addUniqueEntry(this.schemas, value);
-  }
-
-  deleteSchema(value: Schema): void {
-    deleteEntry(this.schemas, value);
-  }
-
   protected override get _elementHashCode(): string {
     return hashArray([
       DSL_EXTERNAL_FORMAT_HASH_STRUCTURE.SCHEMA_SET,

package/src/models/metamodels/pure/packageableElements/externalFormat/store/BindingTransformer.ts

@@ -15,7 +15,7 @@
  */
 
 import { type Hashable, hashArray } from '@finos/legend-shared';
-import { action, computed, makeObservable, observable } from 'mobx';
+import { computed, makeObservable, observable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../../MetaModelConst';
 import type { PackageableElementReference } from '../../PackageableElementReference';
 import type { Binding } from './DSLExternalFormat_Binding';
@@ -27,14 +27,9 @@ export class BindingTransformer implements Hashable {
     makeObservable(this, {
       binding: observable,
       hashCode: computed,
-      setBinding: action,
     });
   }
 
-  setBinding(value: PackageableElementReference<Binding>): void {
-    this.binding = value;
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.BINDING_TRANSFORMER,

package/src/models/metamodels/pure/packageableElements/externalFormat/store/DSLExternalFormat_Binding.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable, override } from 'mobx';
+import { observable, makeObservable, override } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import type { SchemaSet } from '../schemaSet/DSLExternalFormat_SchemaSet';
 import { Store } from '../../store/Store';
@@ -37,30 +37,10 @@ export class Binding extends Store implements Hashable {
       schemaId: observable,
       contentType: observable,
       modelUnit: observable,
-      setSchemaSet: action,
-      setSchemaId: action,
-      setContentType: action,
-      setModelUnit: action,
       _elementHashCode: override,
     });
   }
 
-  setSchemaSet(value: SchemaSet | undefined): void {
-    this.schemaSet.setValue(value);
-  }
-
-  setSchemaId(value: string | undefined): void {
-    this.schemaId = value;
-  }
-
-  setContentType(value: string): void {
-    this.contentType = value;
-  }
-
-  setModelUnit(value: ModelUnit): void {
-    this.modelUnit = value;
-  }
-
   protected override get _elementHashCode(): string {
     return hashArray([
       DSL_EXTERNAL_FORMAT_HASH_STRUCTURE.BINDING,

package/src/models/metamodels/pure/packageableElements/externalFormat/store/DSLExternalFormat_ModelUnit.ts

@@ -14,14 +14,8 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable, action } from 'mobx';
-import {
-  type Hashable,
-  addUniqueEntry,
-  changeEntry,
-  deleteEntry,
-  hashArray,
-} from '@finos/legend-shared';
+import { observable, computed, makeObservable } from 'mobx';
+import { type Hashable, hashArray } from '@finos/legend-shared';
 import type { PackageableElementReference } from '../../PackageableElementReference';
 import type { PackageableElement } from '../../PackageableElement';
 import { DSL_EXTERNAL_FORMAT_HASH_STRUCTURE } from '../../../../../DSLExternalFormat_ModelUtils';
@@ -37,53 +31,9 @@ export class ModelUnit implements Hashable {
       packageableElementIncludes: observable,
       packageableElementExcludes: observable,
       hashCode: computed,
-      addPackageableElementIncludes: action,
-      deletePackageableElementIncludes: action,
-      updatePackageableElementIncludes: action,
-      addPackageableElementExcludes: action,
-      deletePackageableElementExcludes: action,
-      updatePackageableElementExcludes: action,
     });
   }
 
-  addPackageableElementIncludes(
-    value: PackageableElementReference<PackageableElement>,
-  ): void {
-    addUniqueEntry(this.packageableElementIncludes, value);
-  }
-
-  deletePackageableElementIncludes(
-    value: PackageableElementReference<PackageableElement>,
-  ): void {
-    deleteEntry(this.packageableElementIncludes, value);
-  }
-
-  updatePackageableElementIncludes(
-    oldValue: PackageableElementReference<PackageableElement>,
-    newValue: PackageableElementReference<PackageableElement>,
-  ): void {
-    changeEntry(this.packageableElementIncludes, oldValue, newValue);
-  }
-
-  addPackageableElementExcludes(
-    value: PackageableElementReference<PackageableElement>,
-  ): void {
-    addUniqueEntry(this.packageableElementExcludes, value);
-  }
-
-  deletePackageableElementExcludes(
-    value: PackageableElementReference<PackageableElement>,
-  ): void {
-    deleteEntry(this.packageableElementExcludes, value);
-  }
-
-  updatePackageableElementExcludes(
-    oldValue: PackageableElementReference<PackageableElement>,
-    newValue: PackageableElementReference<PackageableElement>,
-  ): void {
-    changeEntry(this.packageableElementExcludes, oldValue, newValue);
-  }
-
   get hashCode(): string {
     return hashArray([
       DSL_EXTERNAL_FORMAT_HASH_STRUCTURE.MODEL_UNIT,

package/src/models/metamodels/pure/packageableElements/fileGeneration/ConfigurationProperty.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { hashArray, hashObject, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 
@@ -26,7 +26,6 @@ export class ConfigurationProperty implements Hashable {
     makeObservable(this, {
       name: observable,
       value: observable.ref,
-      setValue: action,
       hashCode: computed,
     });
 
@@ -34,10 +33,6 @@ export class ConfigurationProperty implements Hashable {
     this.value = value;
   }
 
-  setValue(value: unknown): void {
-    this.value = value;
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.CONFIGURATION_PROPERTY,

package/src/models/metamodels/pure/packageableElements/fileGeneration/FileGenerationSpecification.ts

@@ -14,14 +14,8 @@
  * limitations under the License.
  */
 
-import {
-  type Hashable,
-  hashArray,
-  addUniqueEntry,
-  deleteEntry,
-  changeEntry,
-} from '@finos/legend-shared';
-import { observable, action, makeObservable, override } from 'mobx';
+import { type Hashable, hashArray } from '@finos/legend-shared';
+import { observable, makeObservable, override } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type {
   PackageableElementVisitor,
@@ -49,49 +43,10 @@ export class FileGenerationSpecification
       generationOutputPath: observable,
       scopeElements: observable,
       configurationProperties: observable,
-      setGenerationOutputPath: action,
-      setType: action,
-      setScopeElements: action,
-      addScopeElement: action,
-      deleteScopeElement: action,
-      changeScopeElement: action,
       _elementHashCode: override,
     });
   }
 
-  setType(value: string): void {
-    this.type = value;
-  }
-
-  setGenerationOutputPath(val?: string): void {
-    this.generationOutputPath = val;
-  }
-
-  setScopeElements(
-    value: (PackageableElementReference<PackageableElement> | string)[],
-  ): void {
-    this.scopeElements = value;
-  }
-
-  addScopeElement(
-    value: PackageableElementReference<PackageableElement> | string,
-  ): void {
-    addUniqueEntry(this.scopeElements, value);
-  }
-
-  deleteScopeElement(
-    value: PackageableElementReference<PackageableElement> | string,
-  ): void {
-    deleteEntry(this.scopeElements, value);
-  }
-
-  changeScopeElement(
-    oldValue: PackageableElementReference<PackageableElement> | string,
-    newValue: PackageableElementReference<PackageableElement> | string,
-  ): void {
-    changeEntry(this.scopeElements, oldValue, newValue);
-  }
-
   getConfigValue(name: string): unknown | undefined {
     return this.getConfig(name)?.value;
   }

package/src/models/metamodels/pure/packageableElements/generationSpecification/GenerationSpecification.ts

@@ -14,27 +14,17 @@
  * limitations under the License.
  */
 
-import { computed, observable, action, makeObservable, override } from 'mobx';
+import { computed, observable, makeObservable, override } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
-import {
-  type Hashable,
-  UnsupportedOperationError,
-  hashArray,
-  addUniqueEntry,
-  deleteEntry,
-} from '@finos/legend-shared';
-import { FileGenerationSpecification } from '../fileGeneration/FileGenerationSpecification';
+import { type Hashable, hashArray } from '@finos/legend-shared';
 import {
   type PackageableElementVisitor,
   PackageableElement,
   PACKAGEABLE_ELEMENT_POINTER_TYPE,
   getElementPointerHashCode,
 } from '../PackageableElement';
-import {
-  type PackageableElementReference,
-  PackageableElementExplicitReference,
-} from '../PackageableElementReference';
-import { ModelGenerationSpecification } from './ModelGenerationSpecification';
+import type { PackageableElementReference } from '../PackageableElementReference';
+import type { FileGenerationSpecification } from '../fileGeneration/FileGenerationSpecification';
 
 // NOTE: As of now the tree only supports a linear order of generation. This is because the only use case is linear,
 // but the shape has been left as a tree to support 'branching' off in the future.
@@ -51,17 +41,12 @@ export class GenerationTreeNode implements Hashable {
       id: observable,
       parent: observable,
       hashCode: computed,
-      setId: action,
     });
 
     this.generationElement = generationElement;
     this.id = id ?? generationElement.value.path;
   }
 
-  setId(val: string): void {
-    this.id = val;
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.GENERATION_TREE_NODE,
@@ -85,58 +70,10 @@ export class GenerationSpecification
     makeObservable<GenerationSpecification, '_elementHashCode'>(this, {
       generationNodes: observable,
       fileGenerations: observable,
-      deleteFileGeneration: action,
-      addGenerationElement: action,
-      deleteGenerationNode: action,
-      addNode: action,
-      addFileGeneration: action,
-      findGenerationElementById: action,
       _elementHashCode: override,
     });
   }
 
-  // NOTE as of now the generation specification only supports model generation elements i.e elements that generate another graph compatabile with the current graph.
-  addGenerationElement(element: PackageableElement): void {
-    if (
-      !(
-        element instanceof ModelGenerationSpecification ||
-        element instanceof FileGenerationSpecification
-      )
-    ) {
-      throw new UnsupportedOperationError(
-        `Can't add generation element: only model generation elements can be added to the generation specification`,
-        element,
-      );
-    }
-    if (element instanceof FileGenerationSpecification) {
-      this.addFileGeneration(element);
-    } else {
-      this.addNode(
-        new GenerationTreeNode(
-          PackageableElementExplicitReference.create(element),
-        ),
-      );
-    }
-  }
-
-  addNode(value: GenerationTreeNode): void {
-    addUniqueEntry(this.generationNodes, value);
-  }
-  addFileGeneration(value: FileGenerationSpecification): void {
-    addUniqueEntry(
-      this.fileGenerations,
-      PackageableElementExplicitReference.create(value),
-    );
-  }
-  deleteFileGeneration(
-    value: PackageableElementReference<FileGenerationSpecification>,
-  ): void {
-    deleteEntry(this.fileGenerations, value);
-  }
-  deleteGenerationNode(value: GenerationTreeNode): void {
-    deleteEntry(this.generationNodes, value);
-  }
-
   findGenerationElementById(id: string): PackageableElement | undefined {
     return this.generationNodes.find((node) => node.id === id)
       ?.generationElement.value;