@finos/legend-graph 2.0.4 → 2.1.2

package/src/models/metamodels/pure/packageableElements/store/modelToModel/connection/JsonModelConnection.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, computed, action, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import {
   type Hashable,
   hashArray,
@@ -50,8 +50,6 @@ export class JsonModelConnection
 
     makeObservable(this, {
       url: observable,
-      setClass: action,
-      setUrl: action,
       hashCode: computed,
     });
 
@@ -59,13 +57,6 @@ export class JsonModelConnection
     this.url = url;
   }
 
-  setClass(value: Class): void {
-    this.class.setValue(value);
-  }
-  setUrl(value: string): void {
-    this.url = value;
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.JSON_MODEL_CONNECTION,

package/src/models/metamodels/pure/packageableElements/store/modelToModel/connection/XmlModelConnection.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, computed, action, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { hashArray, ContentType, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../../../MetaModelConst';
 import type { ConnectionVisitor } from '../../../connection/Connection';
@@ -41,8 +41,6 @@ export class XmlModelConnection
 
     makeObservable(this, {
       url: observable,
-      setClass: action,
-      setUrl: action,
       hashCode: computed,
     });
 
@@ -50,13 +48,6 @@ export class XmlModelConnection
     this.url = url;
   }
 
-  setClass(value: Class): void {
-    this.class.setValue(value);
-  }
-  setUrl(value: string): void {
-    this.url = value;
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.XML_MODEL_CONNECTION,

package/src/models/metamodels/pure/packageableElements/store/relational/mapping/EmbeddedRelationalInstanceSetImplementation.ts

@@ -83,9 +83,6 @@ export class EmbeddedRelationalInstanceSetImplementation
     this.parent = rootInstanceSetImplementation.parent;
   }
 
-  setId(value: string): void {
-    throw new UnsupportedOperationError();
-  }
   setRoot(value: boolean): void {
     throw new UnsupportedOperationError();
   }

package/src/models/metamodels/pure/packageableElements/store/relational/model/ColumnReference.ts

@@ -46,7 +46,7 @@ export abstract class ColumnReference extends ReferenceWithOwner {
 
   setValue(value: Column): void {
     this.value = value;
-    this.ownerReference.setValue(getSchemaFromRelation(value.owner).owner);
+    this.ownerReference.value = getSchemaFromRelation(value.owner).owner;
   }
 }
 

package/src/models/metamodels/pure/packageableElements/store/relational/model/FilterReference.ts

@@ -45,7 +45,7 @@ export abstract class FilterReference extends ReferenceWithOwner {
 
   setValue(value: Filter): void {
     this.value = value;
-    this.ownerReference.setValue(value.owner);
+    this.ownerReference.value = value.owner;
   }
 }
 

package/src/models/metamodels/pure/packageableElements/store/relational/model/JoinReference.ts

@@ -45,7 +45,7 @@ export abstract class JoinReference extends ReferenceWithOwner {
 
   setValue(value: Join): void {
     this.value = value;
-    this.ownerReference.setValue(value.owner);
+    this.ownerReference.value = value.owner;
   }
 }
 

package/src/models/metamodels/pure/packageableElements/store/relational/model/Table.ts

@@ -30,7 +30,7 @@ export class Table extends NamedRelation implements Hashable {
   schema!: Schema;
   primaryKey: Column[] = [];
   milestoning: Milestoning[] = [];
-  // // TODO
+  //TODO
   // temporaryTable : Boolean[0..1];
 
   constructor(name: string, schema: Schema) {

package/src/models/metamodels/pure/packageableElements/store/relational/model/TableReference.ts

@@ -57,7 +57,7 @@ export abstract class TableReference extends NamedRelationalReference {
 
   setValue(value: Table): void {
     this.value = value;
-    this.ownerReference.setValue(value.schema.owner);
+    this.ownerReference.value = value.schema.owner;
   }
 
   get pointerHashCode(): string {

package/src/models/metamodels/pure/packageableElements/store/relational/model/ViewReference.ts

@@ -48,7 +48,7 @@ export abstract class ViewReference extends NamedRelationalReference {
 
   setValue(value: View): void {
     this.value = value;
-    this.ownerReference.setValue(value.schema.owner);
+    this.ownerReference.value = value.schema.owner;
   }
 
   get pointerHashCode(): string {

package/src/models/metamodels/pure/rawValueSpecification/RawVariableExpression.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { hashArray, uuid, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../MetaModelConst';
 import type { Type } from '../packageableElements/domain/Type';
@@ -48,9 +48,6 @@ export class RawVariableExpression
     makeObservable(this, {
       name: observable,
       multiplicity: observable,
-      setName: action,
-      setType: action,
-      setMultiplicity: action,
       isStub: computed,
       hashCode: computed,
     });
@@ -60,16 +57,6 @@ export class RawVariableExpression
     this.type = type;
   }
 
-  setName(value: string): void {
-    this.name = value;
-  }
-  setType(value: Type): void {
-    this.type.setValue(value);
-  }
-  setMultiplicity(value: Multiplicity): void {
-    this.multiplicity = value;
-  }
-
   static createStub = (type: Type): RawVariableExpression =>
     new RawVariableExpression(
       '',

package/src/models/protocols/pure/DSLExternalFormat_PureProtocolProcessorPlugin.ts

@@ -118,9 +118,6 @@ export class DSLExternalFormat_PureProtocolProcessorPlugin
             elementProtocol.package,
             elementProtocol.name,
           );
-          context.currentSubGraph
-            .getOrCreatePackage(elementProtocol.package)
-            .addElement(element);
           context.currentSubGraph.setOwnStore(path, element);
           return element;
         },
@@ -193,11 +190,9 @@ export class DSLExternalFormat_PureProtocolProcessorPlugin
           element.format = guaranteeNonEmptyString(elementProtocol.format);
           element.schemas = elementProtocol.schemas.map((schema) => {
             const schemaElement = new Schema();
-            schemaElement.setContent(
-              guaranteeNonEmptyString(
-                schema.content,
-                `Schema 'content' field is missing or empty`,
-              ),
+            schemaElement.content = guaranteeNonEmptyString(
+              schema.content,
+              `Schema 'content' field is missing or empty`,
             );
             schemaElement.id = schema.id;
             schemaElement.location = schema.location;
@@ -353,11 +348,9 @@ export class DSLExternalFormat_PureProtocolProcessorPlugin
             `External format connection 'externalSource' field is missing`,
           );
           const urlStream = new UrlStream();
-          urlStream.setUrl(
-            guaranteeNonEmptyString(
-              connection.externalSource.url,
-              `URL stream 'url' field is missing or empty`,
-            ),
+          urlStream.url = guaranteeNonEmptyString(
+            connection.externalSource.url,
+            `URL stream 'url' field is missing or empty`,
           );
           externalFormatConnection.externalSource = urlStream;
           return externalFormatConnection;

package/src/models/protocols/pure/MappingGeneration_PureProtocolProcessorPlugin_Extension.ts

@@ -0,0 +1,34 @@
+/**
+ * Copyright (c) 2020-present, Goldman Sachs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import type { ModelGenerationConfiguration } from '../../ModelGenerationConfiguration';
+import type { V1_PureModelContextData } from './v1/model/context/V1_PureModelContextData';
+import type { V1_Engine } from './v1/engine/V1_Engine';
+import type { PureProtocolProcessorPlugin } from './PureProtocolProcessorPlugin';
+
+export type V1_ModelGeneratorFromConfiguration = (
+  config: ModelGenerationConfiguration,
+  model: V1_PureModelContextData,
+  engine: V1_Engine,
+) => Promise<V1_PureModelContextData | undefined>;
+
+export interface MappingGeneration_PureProtocolProcessorPlugin_Extension
+  extends PureProtocolProcessorPlugin {
+  /**
+   * Get generators for model generation from configuration.
+   */
+  V1_getExtraModelGeneratorsFromConfiguration?(): V1_ModelGeneratorFromConfiguration[];
+}

package/src/models/protocols/pure/v1/V1_PureGraphManager.ts

@@ -234,6 +234,8 @@ import {
 import { V1_MAPPING_ELEMENT_PROTOCOL_TYPE } from './transformation/pureProtocol/serializationHelpers/V1_MappingSerializationHelper';
 import { V1_SERVICE_ELEMENT_PROTOCOL_TYPE } from './transformation/pureProtocol/serializationHelpers/V1_ServiceSerializationHelper';
 import { MappingInclude } from '../../../metamodels/pure/packageableElements/mapping/MappingInclude';
+import type { ModelGenerationConfiguration } from '../../../ModelGenerationConfiguration';
+import type { MappingGeneration_PureProtocolProcessorPlugin_Extension } from '../MappingGeneration_PureProtocolProcessorPlugin_Extension';
 
 const V1_FUNCTION_SUFFIX_MULTIPLICITY_INFINITE = 'MANY';
 
@@ -411,7 +413,6 @@ const indexPureModelContextData = (
 interface V1_GraphBuilderInput {
   model: BasicModel;
   data: V1_PureModelContextDataIndex;
-  parentElementPath?: string | undefined;
 }
 
 export interface V1_EngineSetupConfig {
@@ -960,28 +961,6 @@ export class V1_PureGraphManager extends AbstractPureGraphManager {
         ),
       );
     }
-    if (!options?.TEMPORARY_skipGeneratedElementsPostProcessing) {
-      // Assign generated elements to their parent generation element (config that drives generation)
-      yield Promise.all(
-        inputs
-          .filter((input) => Boolean(input.parentElementPath))
-          .flatMap((input) =>
-            input.data.elements.map((el) =>
-              promisify(() =>
-                runInAction(() => {
-                  // TODO: check performance once `getNullableElement` is optimized
-                  const element = graph.getElement(el.path);
-                  if (input.parentElementPath) {
-                    element.generationParentElement = graph.getElement(
-                      input.parentElementPath,
-                    );
-                  }
-                }),
-              ),
-            ),
-          ),
-      );
-    }
     /**
      * For now, we delete the section index. We are able to read both resolved and unresolved element paths
      * but when we write (serialize) we write only resolved paths. In the future once the issue with dependency is solved we will
@@ -1615,6 +1594,36 @@ export class V1_PureGraphManager extends AbstractPureGraphManager {
     return this.pureModelContextDataToEntities(generatedModel);
   }
 
+  async generateModelFromConfiguration(
+    config: ModelGenerationConfiguration,
+    graph: PureModel,
+  ): Promise<Entity[]> {
+    const model = this.getFullGraphModelData(graph);
+    let generatedModel: V1_PureModelContextData | undefined = undefined;
+    const extraModelGenerators = this.pluginManager
+      .getPureProtocolProcessorPlugins()
+      .flatMap(
+        (plugin) =>
+          (
+            plugin as MappingGeneration_PureProtocolProcessorPlugin_Extension
+          ).V1_getExtraModelGeneratorsFromConfiguration?.() ?? [],
+      );
+    for (const generator of extraModelGenerators) {
+      const _model = await generator(config, model, this.engine);
+      if (_model) {
+        generatedModel = _model;
+        break;
+      }
+    }
+    if (!generatedModel) {
+      throw new UnsupportedOperationError(
+        `Can't generate model using the specified configuration: no compatible generator available from plugins`,
+        config,
+      );
+    }
+    return this.pureModelContextDataToEntities(generatedModel);
+  }
+
   // ------------------------------------------- ValueSpecification -------------------------------------------
 
   buildValueSpecification(
@@ -2198,11 +2207,9 @@ export class V1_PureGraphManager extends AbstractPureGraphManager {
         const runtime = runtimes.find((e) => e.path === element.path);
         if (runtime) {
           const runtimeValue = new EngineRuntime();
-          runtime.setRuntimeValue(runtimeValue);
-          runtimeValue.setMappings(
-            element.runtimeValue.mappings.map((mapping) =>
-              context.resolveMapping(mapping.path),
-            ),
+          runtime.runtimeValue = runtimeValue;
+          runtimeValue.mappings = element.runtimeValue.mappings.map((mapping) =>
+            context.resolveMapping(mapping.path),
           );
         }
       });
@@ -2269,15 +2276,13 @@ export class V1_PureGraphManager extends AbstractPureGraphManager {
                     new EngineRuntime(),
                   ),
               );
-            service.setExecution(execution);
+            service.execution = execution;
           } else if (serviceExecution instanceof V1_PureSingleExecution) {
-            service.setExecution(
-              new PureSingleExecution(
-                RawLambda.createStub(),
-                service,
-                PackageableElementExplicitReference.create(new Mapping('')),
-                new EngineRuntime(),
-              ),
+            service.execution = new PureSingleExecution(
+              RawLambda.createStub(),
+              service,
+              PackageableElementExplicitReference.create(new Mapping('')),
+              new EngineRuntime(),
             );
           }
         }

package/src/models/protocols/pure/v1/transformation/pureGraph/to/V1_ElementBuilder.ts

@@ -19,6 +19,7 @@ import {
   assertNonEmptyString,
   assertTrue,
 } from '@finos/legend-shared';
+import { _package_addElement } from '../../../../../../GraphModifierHelper';
 import type { PackageableElement } from '../../../../../../metamodels/pure/packageableElements/PackageableElement';
 import type { V1_PackageableElement } from '../../../model/packageableElements/V1_PackageableElement';
 import type { V1_GraphBuilderContext } from './V1_GraphBuilderContext';
@@ -121,9 +122,10 @@ export class V1_ElementBuilder<T extends V1_PackageableElement> {
       `Element '${path}' already exists`,
     );
     const element = this.firstPass(elementProtocol, context);
-    context.currentSubGraph
-      .getOrCreatePackage(elementProtocol.package)
-      .addElement(element);
+    _package_addElement(
+      context.currentSubGraph.getOrCreatePackage(elementProtocol.package),
+      element,
+    );
     return element;
   }
 

package/src/models/protocols/pure/v1/transformation/pureGraph/to/V1_ProtocolToMetaModelGraphFirstPassBuilder.ts

@@ -56,6 +56,7 @@ import type { V1_PackageableConnection } from '../../../model/packageableElement
 import type { V1_FileGenerationSpecification } from '../../../model/packageableElements/fileGeneration/V1_FileGenerationSpecification';
 import type { V1_Measure } from '../../../model/packageableElements/domain/V1_Measure';
 import type { V1_SectionIndex } from '../../../model/packageableElements/section/V1_SectionIndex';
+import { _package_addElement } from '../../../../../../GraphModifierHelper';
 
 export class V1_ProtocolToMetaModelGraphFirstPassBuilder
   implements V1_PackageableElementVisitor<PackageableElement>
@@ -112,9 +113,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(profile);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      profile,
+    );
     this.context.currentSubGraph.setOwnProfile(path, profile);
     return profile;
   }
@@ -137,9 +139,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(pureEnumeration);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      pureEnumeration,
+    );
     this.context.currentSubGraph.setOwnType(path, pureEnumeration);
     return pureEnumeration;
   }
@@ -162,9 +165,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(pureMeasure);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      pureMeasure,
+    );
     this.context.currentSubGraph.setOwnType(path, pureMeasure);
     return pureMeasure;
   }
@@ -187,9 +191,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(_class);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      _class,
+    );
     this.context.currentSubGraph.setOwnType(path, _class);
     return _class;
   }
@@ -212,9 +217,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(association);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      association,
+    );
     this.context.currentSubGraph.setOwnAssociation(path, association);
     return association;
   }
@@ -249,9 +255,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(func);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      func,
+    );
     this.context.currentSubGraph.setOwnFunction(path, func);
     return func;
   }
@@ -274,9 +281,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(flatData);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      flatData,
+    );
     this.context.currentSubGraph.setOwnStore(path, flatData);
     return flatData;
   }
@@ -299,9 +307,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(database);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      database,
+    );
     this.context.currentSubGraph.setOwnStore(path, database);
     return database;
   }
@@ -324,9 +333,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(pureMapping);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      pureMapping,
+    );
     this.context.currentSubGraph.setOwnMapping(path, pureMapping);
     return pureMapping;
   }
@@ -349,9 +359,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(service);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      service,
+    );
     this.context.currentSubGraph.setOwnService(path, service);
     return service;
   }
@@ -376,9 +387,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(fileGeneration);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      fileGeneration,
+    );
     this.context.currentSubGraph.setOwnFileGeneration(path, fileGeneration);
     return fileGeneration;
   }
@@ -404,9 +416,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(generationSpec);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      generationSpec,
+    );
     this.context.currentSubGraph.setOwnGenerationSpecification(
       path,
       generationSpec,
@@ -432,9 +445,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(runtime);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      runtime,
+    );
     this.context.currentSubGraph.setOwnRuntime(path, runtime);
     return runtime;
   }
@@ -459,9 +473,10 @@ export class V1_ProtocolToMetaModelGraphFirstPassBuilder
       !this.context.graph.getNullableElement(path),
       `Element '${path}' already exists`,
     );
-    this.context.currentSubGraph
-      .getOrCreatePackage(element.package)
-      .addElement(connection);
+    _package_addElement(
+      this.context.currentSubGraph.getOrCreatePackage(element.package),
+      connection,
+    );
     this.context.currentSubGraph.setOwnConnection(path, connection);
     return connection;
   }

package/src/models/protocols/pure/v1/transformation/pureGraph/to/V1_ProtocolToMetaModelGraphSecondPassBuilder.ts

@@ -165,13 +165,11 @@ export class V1_ProtocolToMetaModelGraphSecondPassBuilder
     const measure = this.context.graph.getMeasure(
       this.context.graph.buildPath(element.package, element.name),
     );
-    measure.setCanonicalUnit(
-      V1_buildUnit(
-        element.canonicalUnit,
-        measure,
-        this.context.graph,
-        this.context,
-      ),
+    measure.canonicalUnit = V1_buildUnit(
+      element.canonicalUnit,
+      measure,
+      this.context.graph,
+      this.context,
     );
     measure.nonCanonicalUnits = element.nonCanonicalUnits.map((unit) =>
       V1_buildUnit(unit, measure, this.context.currentSubGraph, this.context),
@@ -290,8 +288,10 @@ export class V1_ProtocolToMetaModelGraphSecondPassBuilder
     service.documentation = element.documentation;
     service.autoActivateUpdates = element.autoActivateUpdates;
     // NOTE: process execution before the test, so we can do some check between test and execution (such matching type, keys, etc.)
-    service.setExecution(
-      V1_buildServiceExecution(element.execution, this.context, service),
+    service.execution = V1_buildServiceExecution(
+      element.execution,
+      this.context,
+      service,
     );
     service.test = V1_buildServiceTest(element.test, this.context, service);
   }
@@ -313,10 +313,10 @@ export class V1_ProtocolToMetaModelGraphSecondPassBuilder
     const fileGeneration = this.context.graph.getFileGeneration(
       this.context.graph.buildPath(element.package, element.name),
     );
-    fileGeneration.setType(element.type);
+    fileGeneration.type = element.type;
     fileGeneration.configurationProperties =
       element.configurationProperties.map(V1_buildConfigurationProperty);
-    fileGeneration.setGenerationOutputPath(element.generationOutputPath);
+    fileGeneration.generationOutputPath = element.generationOutputPath;
     fileGeneration.scopeElements = element.scopeElements.map((scopeElement) =>
       V1_buildScopeElement(scopeElement, this.context),
     );
@@ -338,8 +338,9 @@ export class V1_ProtocolToMetaModelGraphSecondPassBuilder
     const runtime = this.context.graph.getRuntime(
       this.context.graph.buildPath(element.package, element.name),
     );
-    runtime.setRuntimeValue(
-      V1_buildEngineRuntime(element.runtimeValue, this.context),
+    runtime.runtimeValue = V1_buildEngineRuntime(
+      element.runtimeValue,
+      this.context,
     );
   }
 
@@ -352,10 +353,9 @@ export class V1_ProtocolToMetaModelGraphSecondPassBuilder
         'Packageable connection value cannot be a connection pointer',
       );
     }
-    connection.setConnectionValue(
+    connection.connectionValue =
       element.connectionValue.accept_ConnectionVisitor(
         new V1_ProtocolToMetaModelConnectionBuilder(this.context),
-      ),
-    );
+      );
   }
 }