@finos/legend-graph 2.0.4 → 2.1.2

package/src/models/metamodels/pure/packageableElements/domain/Package.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable, override } from 'mobx';
+import { observable, makeObservable, override } from 'mobx';
 import {
   CORE_HASH_STRUCTURE,
   ELEMENT_PATH_DELIMITER,
@@ -40,8 +40,6 @@ export class Package extends PackageableElement implements Hashable {
 
     makeObservable(this, {
       children: observable,
-      addChild: action,
-      addElement: action,
       hashCode: override,
     });
   }
@@ -52,21 +50,10 @@ export class Package extends PackageableElement implements Hashable {
       `Can't create package with reserved name '${name}'`,
     );
     const newPackage = new Package(name);
-    newPackage.setPackage(parent);
+    newPackage.package = parent;
     return newPackage;
   }
 
-  addChild(value: PackageableElement): void {
-    // NOTE: here we directly push the element to the children array without any checks rather than use `addUniqueEntry` to improve performance.
-    // Duplication checks should be handled separately
-    this.children.push(value);
-  }
-
-  addElement(element: PackageableElement): void {
-    this.addChild(element);
-    element.setPackage(this);
-  }
-
   get fullPath(): string {
     if (!this.package) {
       return '';
@@ -77,12 +64,6 @@ export class Package extends PackageableElement implements Hashable {
       : `${parentPackageName}${ELEMENT_PATH_DELIMITER}${this.name}`;
   }
 
-  deleteElement(packageableElement: PackageableElement): void {
-    this.children = this.children.filter(
-      (child) => child !== packageableElement,
-    );
-  }
-
   /**
    * If package name is a path, continue to recursively traverse the package chain to find the leaf package
    * NOTE: if we do not allow insertion, error could be thrown if a package in the path is not found
@@ -107,7 +88,9 @@ export class Package extends PackageableElement implements Hashable {
       }
       // create the node if it is not in parent package
       node = Package.createPackageFromParent(str, parent);
-      parent.addChild(node);
+      // NOTE: here we directly push the element to the children array without any checks rather than use `addUniqueEntry` to improve performance.
+      // Duplication checks should be handled separately
+      parent.children.push(node);
     }
     if (index !== -1) {
       return Package.getOrCreatePackage(

package/src/models/metamodels/pure/packageableElements/domain/Profile.ts

@@ -14,13 +14,11 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable, override } from 'mobx';
+import { observable, computed, makeObservable, override } from 'mobx';
 import {
   type Hashable,
   guaranteeNonNullable,
   hashArray,
-  deleteEntry,
-  addUniqueEntry,
 } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import {
@@ -41,31 +39,11 @@ export class Profile extends PackageableElement implements Hashable, Stubable {
     makeObservable<Profile, '_elementHashCode'>(this, {
       stereotypes: observable,
       tags: observable,
-      addTag: action,
-      deleteTag: action,
-      addStereotype: action,
-      deleteStereotype: action,
       isStub: computed,
       _elementHashCode: override,
     });
   }
 
-  addTag(value: Tag): void {
-    addUniqueEntry(this.tags, value);
-  }
-
-  deleteTag(value: Tag): void {
-    deleteEntry(this.tags, value);
-  }
-
-  addStereotype(value: Stereotype): void {
-    addUniqueEntry(this.stereotypes, value);
-  }
-
-  deleteStereotype(value: Stereotype): void {
-    deleteEntry(this.stereotypes, value);
-  }
-
   getTag = (value: string): Tag =>
     guaranteeNonNullable(
       this.tags.find((tag) => tag.value === value),

package/src/models/metamodels/pure/packageableElements/domain/Property.ts

@@ -14,15 +14,8 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
-import {
-  type Hashable,
-  hashArray,
-  uuid,
-  deleteEntry,
-  addUniqueEntry,
-  changeEntry,
-} from '@finos/legend-shared';
+import { observable, computed, makeObservable } from 'mobx';
+import { type Hashable, hashArray, uuid } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import {
   type GenericTypeReference,
@@ -60,14 +53,6 @@ export class Property
       multiplicity: observable,
       stereotypes: observable,
       taggedValues: observable,
-      setName: action,
-      setGenericType: action,
-      setMultiplicity: action,
-      addTaggedValue: action,
-      deleteTaggedValue: action,
-      addStereotype: action,
-      changeStereotype: action,
-      deleteStereotype: action,
       isStub: computed,
       hashCode: computed,
     });
@@ -78,34 +63,6 @@ export class Property
     this.owner = owner;
   }
 
-  setName(value: string): void {
-    this.name = value;
-  }
-  setGenericType(value: GenericType): void {
-    this.genericType.setValue(value);
-  }
-  setMultiplicity(value: Multiplicity): void {
-    this.multiplicity = value;
-  }
-  addTaggedValue(value: TaggedValue): void {
-    addUniqueEntry(this.taggedValues, value);
-  }
-  deleteTaggedValue(value: TaggedValue): void {
-    deleteEntry(this.taggedValues, value);
-  }
-  addStereotype(value: StereotypeReference): void {
-    addUniqueEntry(this.stereotypes, value);
-  }
-  changeStereotype(
-    oldValue: StereotypeReference,
-    newValue: StereotypeReference,
-  ): void {
-    changeEntry(this.stereotypes, oldValue, newValue);
-  }
-  deleteStereotype(value: StereotypeReference): void {
-    deleteEntry(this.stereotypes, value);
-  }
-
   static createStub = (type: Type, _class: Class): Property =>
     new Property(
       '',

package/src/models/metamodels/pure/packageableElements/domain/PropertyReference.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import { hashString } from '@finos/legend-shared';
 import {
@@ -45,7 +45,6 @@ export abstract class PropertyReference
 
     makeObservable(this, {
       value: observable,
-      setValue: action,
       isStub: computed,
       pointerHashCode: computed,
     });
@@ -54,15 +53,6 @@ export abstract class PropertyReference
     this.value = value;
   }
 
-  setValue(value: AbstractProperty): void {
-    this.value = value;
-    this.ownerReference.setValue(
-      value.owner instanceof Association
-        ? value.owner.getPropertyAssociatedClass(this.value)
-        : value.owner,
-    );
-  }
-
   get isStub(): boolean {
     return !this.value.isStub;
   }

package/src/models/metamodels/pure/packageableElements/domain/Stereotype.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { uuid } from '@finos/legend-shared';
 import type { Profile } from './Profile';
 import type { Stubable } from '../../../../../helpers/Stubable';
@@ -27,7 +27,6 @@ export class Stereotype implements Stubable {
   constructor(owner: Profile, value: string) {
     makeObservable(this, {
       value: observable,
-      setValue: action,
       isStub: computed,
     });
 
@@ -35,10 +34,6 @@ export class Stereotype implements Stubable {
     this.value = value;
   }
 
-  setValue(value: string): void {
-    this.value = value;
-  }
-
   static createStub = (profile: Profile): Stereotype =>
     new Stereotype(profile, '');
   get isStub(): boolean {

package/src/models/metamodels/pure/packageableElements/domain/StereotypeReference.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import { hashString } from '@finos/legend-shared';
 import {
@@ -42,7 +42,6 @@ export abstract class StereotypeReference
 
     makeObservable(this, {
       value: observable,
-      setValue: action,
       isStub: computed,
       pointerHashCode: computed,
     });
@@ -51,11 +50,6 @@ export abstract class StereotypeReference
     this.value = value;
   }
 
-  setValue(value: Stereotype): void {
-    this.value = value;
-    this.ownerReference.setValue(value.owner);
-  }
-
   get isStub(): boolean {
     return !this.value.isStub;
   }

package/src/models/metamodels/pure/packageableElements/domain/Tag.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { uuid } from '@finos/legend-shared';
 import type { Profile } from './Profile';
 import type { Stubable } from '../../../../../helpers/Stubable';
@@ -27,7 +27,6 @@ export class Tag implements Stubable {
   constructor(owner: Profile, value: string) {
     makeObservable(this, {
       value: observable,
-      setValue: action,
       isStub: computed,
     });
 
@@ -35,10 +34,6 @@ export class Tag implements Stubable {
     this.value = value;
   }
 
-  setValue(value: string): void {
-    this.value = value;
-  }
-
   static createStub = (profile: Profile): Tag => new Tag(profile, '');
   get isStub(): boolean {
     return !this.value;

package/src/models/metamodels/pure/packageableElements/domain/TagReference.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import { hashString } from '@finos/legend-shared';
 import {
@@ -42,7 +42,6 @@ export abstract class TagReference
 
     makeObservable(this, {
       value: observable,
-      setValue: action,
       isStub: computed,
       pointerHashCode: computed,
     });
@@ -51,11 +50,6 @@ export abstract class TagReference
     this.value = value;
   }
 
-  setValue(value: Tag): void {
-    this.value = value;
-    this.ownerReference.setValue(value.owner);
-  }
-
   get isStub(): boolean {
     return !this.value.isStub;
   }

package/src/models/metamodels/pure/packageableElements/domain/TaggedValue.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { hashArray, uuid, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type { Tag } from './Tag';
@@ -29,8 +29,6 @@ export class TaggedValue implements Hashable, Stubable {
   constructor(tag: TagReference, value: string) {
     makeObservable(this, {
       value: observable,
-      setTag: action,
-      setValue: action,
       isStub: computed,
       hashCode: computed,
     });
@@ -39,13 +37,6 @@ export class TaggedValue implements Hashable, Stubable {
     this.value = value;
   }
 
-  setTag(tag: Tag): void {
-    this.tag.setValue(tag);
-  }
-  setValue(value: string): void {
-    this.value = value;
-  }
-
   static createStub = (tag: Tag): TaggedValue =>
     new TaggedValue(TagExplicitReference.create(tag), '');
   get isStub(): boolean {

package/src/models/metamodels/pure/packageableElements/externalFormat/connection/DSLExternalFormat_ExternalFormatConnection.ts

@@ -15,7 +15,7 @@
  */
 
 import { type Hashable, ContentType, hashArray } from '@finos/legend-shared';
-import { action, computed, makeObservable, observable } from 'mobx';
+import { computed, makeObservable, observable } from 'mobx';
 import type { Binding } from '../store/DSLExternalFormat_Binding';
 import type { UrlStream } from './DSLExternalFormat_UrlStream';
 import {
@@ -34,7 +34,6 @@ export class ExternalFormatConnection extends Connection implements Hashable {
 
     makeObservable(this, {
       externalSource: observable,
-      setSource: action,
       hashCode: computed,
     });
   }

package/src/models/metamodels/pure/packageableElements/externalFormat/connection/DSLExternalFormat_UrlStream.ts

@@ -15,7 +15,7 @@
  */
 
 import { type Hashable, hashArray } from '@finos/legend-shared';
-import { action, computed, makeObservable, observable } from 'mobx';
+import { computed, makeObservable, observable } from 'mobx';
 import { DSL_EXTERNAL_FORMAT_HASH_STRUCTURE } from '../../../../../DSLExternalFormat_ModelUtils';
 
 export class UrlStream implements Hashable {
@@ -25,14 +25,9 @@ export class UrlStream implements Hashable {
     makeObservable(this, {
       url: observable,
       hashCode: computed,
-      setUrl: action,
     });
   }
 
-  setUrl(val: string): void {
-    this.url = val;
-  }
-
   get hashCode(): string {
     return hashArray([DSL_EXTERNAL_FORMAT_HASH_STRUCTURE.URL_STREAM, this.url]);
   }

package/src/models/metamodels/pure/packageableElements/externalFormat/schemaSet/DSLExternalFormat_Schema.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable, action } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { uuid, hashArray, type Hashable } from '@finos/legend-shared';
 import { DSL_EXTERNAL_FORMAT_HASH_STRUCTURE } from '../../../../../DSLExternalFormat_ModelUtils';
 
@@ -29,25 +29,10 @@ export class Schema implements Hashable {
       id: observable,
       location: observable,
       content: observable,
-      setId: action,
-      setLocation: action,
-      setContent: action,
       hashCode: computed,
     });
   }
 
-  setId(value: string): void {
-    this.id = value;
-  }
-
-  setLocation(value: string): void {
-    this.location = value;
-  }
-
-  setContent(value: string): void {
-    this.content = value;
-  }
-
   get hashCode(): string {
     return hashArray([
       DSL_EXTERNAL_FORMAT_HASH_STRUCTURE.SCHEMA,

package/src/models/metamodels/pure/packageableElements/externalFormat/schemaSet/DSLExternalFormat_SchemaSet.ts

@@ -14,13 +14,8 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable, override } from 'mobx';
-import {
-  hashArray,
-  addUniqueEntry,
-  deleteEntry,
-  type Hashable,
-} from '@finos/legend-shared';
+import { observable, makeObservable, override } from 'mobx';
+import { hashArray, type Hashable } from '@finos/legend-shared';
 import type { Schema } from './DSLExternalFormat_Schema';
 import {
   type PackageableElementVisitor,
@@ -38,25 +33,10 @@ export class SchemaSet extends PackageableElement implements Hashable {
     makeObservable<SchemaSet, '_elementHashCode'>(this, {
       format: observable,
       schemas: observable,
-      setFormat: action,
-      addSchema: action,
-      deleteSchema: action,
       _elementHashCode: override,
     });
   }
 
-  setFormat(value: string): void {
-    this.format = value;
-  }
-
-  addSchema(value: Schema): void {
-    addUniqueEntry(this.schemas, value);
-  }
-
-  deleteSchema(value: Schema): void {
-    deleteEntry(this.schemas, value);
-  }
-
   protected override get _elementHashCode(): string {
     return hashArray([
       DSL_EXTERNAL_FORMAT_HASH_STRUCTURE.SCHEMA_SET,

package/src/models/metamodels/pure/packageableElements/externalFormat/store/DSLExternalFormat_Binding.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, makeObservable, override } from 'mobx';
+import { observable, makeObservable, override } from 'mobx';
 import { hashArray, type Hashable } from '@finos/legend-shared';
 import type { SchemaSet } from '../schemaSet/DSLExternalFormat_SchemaSet';
 import { Store } from '../../store/Store';
@@ -37,30 +37,10 @@ export class Binding extends Store implements Hashable {
       schemaId: observable,
       contentType: observable,
       modelUnit: observable,
-      setSchemaSet: action,
-      setSchemaId: action,
-      setContentType: action,
-      setModelUnit: action,
       _elementHashCode: override,
     });
   }
 
-  setSchemaSet(value: SchemaSet | undefined): void {
-    this.schemaSet.setValue(value);
-  }
-
-  setSchemaId(value: string | undefined): void {
-    this.schemaId = value;
-  }
-
-  setContentType(value: string): void {
-    this.contentType = value;
-  }
-
-  setModelUnit(value: ModelUnit): void {
-    this.modelUnit = value;
-  }
-
   protected override get _elementHashCode(): string {
     return hashArray([
       DSL_EXTERNAL_FORMAT_HASH_STRUCTURE.BINDING,

package/src/models/metamodels/pure/packageableElements/externalFormat/store/DSLExternalFormat_ModelUnit.ts

@@ -14,14 +14,8 @@
  * limitations under the License.
  */
 
-import { observable, computed, makeObservable, action } from 'mobx';
-import {
-  type Hashable,
-  addUniqueEntry,
-  changeEntry,
-  deleteEntry,
-  hashArray,
-} from '@finos/legend-shared';
+import { observable, computed, makeObservable } from 'mobx';
+import { type Hashable, hashArray } from '@finos/legend-shared';
 import type { PackageableElementReference } from '../../PackageableElementReference';
 import type { PackageableElement } from '../../PackageableElement';
 import { DSL_EXTERNAL_FORMAT_HASH_STRUCTURE } from '../../../../../DSLExternalFormat_ModelUtils';
@@ -37,53 +31,9 @@ export class ModelUnit implements Hashable {
       packageableElementIncludes: observable,
       packageableElementExcludes: observable,
       hashCode: computed,
-      addPackageableElementIncludes: action,
-      deletePackageableElementIncludes: action,
-      updatePackageableElementIncludes: action,
-      addPackageableElementExcludes: action,
-      deletePackageableElementExcludes: action,
-      updatePackageableElementExcludes: action,
     });
   }
 
-  addPackageableElementIncludes(
-    value: PackageableElementReference<PackageableElement>,
-  ): void {
-    addUniqueEntry(this.packageableElementIncludes, value);
-  }
-
-  deletePackageableElementIncludes(
-    value: PackageableElementReference<PackageableElement>,
-  ): void {
-    deleteEntry(this.packageableElementIncludes, value);
-  }
-
-  updatePackageableElementIncludes(
-    oldValue: PackageableElementReference<PackageableElement>,
-    newValue: PackageableElementReference<PackageableElement>,
-  ): void {
-    changeEntry(this.packageableElementIncludes, oldValue, newValue);
-  }
-
-  addPackageableElementExcludes(
-    value: PackageableElementReference<PackageableElement>,
-  ): void {
-    addUniqueEntry(this.packageableElementExcludes, value);
-  }
-
-  deletePackageableElementExcludes(
-    value: PackageableElementReference<PackageableElement>,
-  ): void {
-    deleteEntry(this.packageableElementExcludes, value);
-  }
-
-  updatePackageableElementExcludes(
-    oldValue: PackageableElementReference<PackageableElement>,
-    newValue: PackageableElementReference<PackageableElement>,
-  ): void {
-    changeEntry(this.packageableElementExcludes, oldValue, newValue);
-  }
-
   get hashCode(): string {
     return hashArray([
       DSL_EXTERNAL_FORMAT_HASH_STRUCTURE.MODEL_UNIT,

package/src/models/metamodels/pure/packageableElements/fileGeneration/ConfigurationProperty.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { observable, action, computed, makeObservable } from 'mobx';
+import { observable, computed, makeObservable } from 'mobx';
 import { hashArray, hashObject, type Hashable } from '@finos/legend-shared';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 
@@ -26,7 +26,6 @@ export class ConfigurationProperty implements Hashable {
     makeObservable(this, {
       name: observable,
       value: observable.ref,
-      setValue: action,
       hashCode: computed,
     });
 
@@ -34,10 +33,6 @@ export class ConfigurationProperty implements Hashable {
     this.value = value;
   }
 
-  setValue(value: unknown): void {
-    this.value = value;
-  }
-
   get hashCode(): string {
     return hashArray([
       CORE_HASH_STRUCTURE.CONFIGURATION_PROPERTY,

package/src/models/metamodels/pure/packageableElements/fileGeneration/FileGenerationSpecification.ts

@@ -14,14 +14,8 @@
  * limitations under the License.
  */
 
-import {
-  type Hashable,
-  hashArray,
-  addUniqueEntry,
-  deleteEntry,
-  changeEntry,
-} from '@finos/legend-shared';
-import { observable, action, makeObservable, override } from 'mobx';
+import { type Hashable, hashArray } from '@finos/legend-shared';
+import { observable, makeObservable, override } from 'mobx';
 import { CORE_HASH_STRUCTURE } from '../../../../../MetaModelConst';
 import type {
   PackageableElementVisitor,
@@ -49,49 +43,10 @@ export class FileGenerationSpecification
       generationOutputPath: observable,
       scopeElements: observable,
       configurationProperties: observable,
-      setGenerationOutputPath: action,
-      setType: action,
-      setScopeElements: action,
-      addScopeElement: action,
-      deleteScopeElement: action,
-      changeScopeElement: action,
       _elementHashCode: override,
     });
   }
 
-  setType(value: string): void {
-    this.type = value;
-  }
-
-  setGenerationOutputPath(val?: string): void {
-    this.generationOutputPath = val;
-  }
-
-  setScopeElements(
-    value: (PackageableElementReference<PackageableElement> | string)[],
-  ): void {
-    this.scopeElements = value;
-  }
-
-  addScopeElement(
-    value: PackageableElementReference<PackageableElement> | string,
-  ): void {
-    addUniqueEntry(this.scopeElements, value);
-  }
-
-  deleteScopeElement(
-    value: PackageableElementReference<PackageableElement> | string,
-  ): void {
-    deleteEntry(this.scopeElements, value);
-  }
-
-  changeScopeElement(
-    oldValue: PackageableElementReference<PackageableElement> | string,
-    newValue: PackageableElementReference<PackageableElement> | string,
-  ): void {
-    changeEntry(this.scopeElements, oldValue, newValue);
-  }
-
   getConfigValue(name: string): unknown | undefined {
     return this.getConfig(name)?.value;
   }